[ Cc: qemu-stable ] Am 19.07.2017 um 11:21 hat Manos Pitsidianakis geschrieben: > On Wed, Jul 19, 2017 at 10:44:47AM +0200, Kevin Wolf wrote: > >Commits 0db832f and 6cdbceb introduced the automatic insertion of filter > >nodes above the top layer of mirror and commit block jobs. The > >assumption made there was that since libvirt doesn't do node-level > >management of the block layer yet, it shouldn't be affected by added > >nodes. > > > >This is true as far as commands issued by libvirt are concerned. It only > >uses BlockBackend names to address nodes, so any operations it performs > >still operate on the root of the tree as intended. > > > >However, the assumption breaks down when you consider query commands, > >which return data for the wrong node now. These commands also return > >information on some child nodes (bs->file and/or bs->backing), which > >libvirt does make use of, and which refer to the wrong nodes, too. > > > >One of the consequences is that oVirt gets wrong information about the > >image size and stops the VM in response as long as a mirror or commit > >job is running: > > > >https://bugzilla.redhat.com/show_bug.cgi?id=1470634 > > > >This patch fixes the problem by hiding the implict nodes created > s/implict/implicit
Fixed. > Also, it seems like qemu-stable wasn't successfully CC'd (the patch > is not in the list archives either). Ah yes, forgot to actually CC it on the mail. Adding it to this mail. > Reviewed-by: Manos Pitsidianakis <el13...@mail.ntua.gr> Thanks! Kevin
pgpC_MDYm8kkk.pgp
Description: PGP signature
