Hi
On Wed, Jul 19, 2017 at 9:09 AM, Markus Armbruster <arm...@redhat.com> wrote:
> QMP command
>
> { "execute": "change",
> "arguments": { "device": "vnc", "target": "password", "arg": PWD } }
>
> behaves just like
>
> { "execute": "change-vnc-password",
> "arguments": { "password", "arg": PWD } }
>
> Their documentation differs, however. According to
> change-vnc-password's documentation, "an empty password [...] will set
> the password to the empty string", while change's documentation claims
> "no future logins will be allowed". The former is actually correct.
> Replace the incorrect claim by a reference to change-vnc-password.
>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
The password would have to be NULL to disallow further login, is that
what your other series will allow to do?
> ---
> qapi-schema.json | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 8b015be..58d3a02 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3011,8 +3011,7 @@
> # @arg: If @device is a block device, then this is an optional format to
> open
> # the device with.
> # If @device is 'vnc' and @target is 'password', this is the new VNC
> -# password to set. If this argument is an empty string, then no
> future
> -# logins will be allowed.
> +# password to set. See change-vnc-password for additional notes.
> #
> # Returns: Nothing on success.
> # If @device is not a valid block device, DeviceNotFound
> --
> 2.7.5
>
>
--
Marc-André Lureau
