Re: [Qemu-devel] [PATCH for-2.9 4/5] rbd: Peel off redundant RbdAuthMethod wrapper struct

2017-03-24 Thread Markus Armbruster
Adding Daniel Berrange for QCryptoSecret expertise. Jeff Cody writes: > On Thu, Mar 23, 2017 at 04:56:30PM -0500, Eric Blake wrote: >> On 03/23/2017 04:43 PM, Eric Blake wrote: >> >> > We'd still have to allow libvirt's use of >> > ":key=...:auth_supported=cephx\\;none" on the command line, but

Re: [Qemu-devel] Guest application reading from pl011 without device driver

2017-03-24 Thread Jiahuan Zhang
Hi, here are the patch files for char-pipe.c, char-win.c, char-win.h On 23 March 2017 at 18:31, Paolo Bonzini wrote: > > > On 23/03/2017 18:28, Jiahuan Zhang wrote: > > Hi, the method doesn't work for pipe. It still causes the same issue. > > The only difference is that the first byte in the UA

Re: [Qemu-devel] [PATCH v4 01/16] s390: cio: introduce cio_cancel_halt_clear

2017-03-24 Thread Dong Jia Shi
* Sebastian Ott [2017-03-23 12:51:40 +0100]: > On Fri, 17 Mar 2017, Dong Jia Shi wrote: > > For future code reuse purpose, this decouples the cio code with > > the ccw device specific parts from ccw_device_cancel_halt_clear, > > and makes a new common I/O interface named cio_cancel_halt_clear. >

[Qemu-devel] [Bug 1490611] Re: Using qemu >=2.2.1 to convert raw->VHD (fixed) adds extra padding to the result file, which Microsoft Azure rejects as invalid

2017-03-24 Thread ChristianEhrhardt
Verified Proposed: dd if=/dev/zero of=source-disk.img bs=1M count=4096 qemu-img convert -f raw -o subformat=fixed -O vpc source-disk.img dest-disk-old.vhd #upgrade $qemu-img convert -f raw -o subformat=fixed -O vpc source-disk.img dest-disk-new.vhd $qemu-img convert -f raw -o subformat=fixed,for

Re: [Qemu-devel] [Bug 1675108] Re: Cocoa UI always crashes on startup

2017-03-24 Thread Alex Bennée
Brendan Shanks writes: > Tested on 10.12.3, it doesn't crash immediately (like before) but > crashes reliably once I send some keyboard input to qemu: > > $ i386-softmmu/qemu-system-i386 > ** > ERROR:/Users/pip/no_backup/qemu/translate-common.c:34:tcg_handle_interrupt: > assertion failed: (qemu

Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class

2017-03-24 Thread Juergen Gross
On 23/03/17 22:28, Eduardo Habkost wrote: > The xen-backend devices created by the Xen code are not supposed > to be treated as dynamic sysbus devices. This is an attempt to > change that and see what happens, but I couldn't test it because > I don't have a Xen host set up. > > If this patch break

Re: [Qemu-devel] [PATCH for-2.9 3/5] rbd: Rewrite the code to extract list-valued options

2017-03-24 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: > >> Am 23.03.2017 um 11:55 hat Markus Armbruster geschrieben: >>> We have two list-values options: >>> >>> * "server" is a list of InetSocketAddress. We use members "host" and >>> "port", and silently ignore the rest. >>> >>> * "auth-supported

Re: [Qemu-devel] [RFC 0/4] Replace has_dynamic_sysbus with device type whitelist

2017-03-24 Thread Juergen Gross
On 23/03/17 22:28, Eduardo Habkost wrote: > Summary > --- > > This series replaces the existing has_dynamic_sysbus flag (that > makes the machine accept every single sysbus device type on the > command-line) with a short whitelist. > > This will be helpful when implementing the new query-devi

Re: [Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

2017-03-24 Thread Juan Quintela
Yang Hongyang wrote: > On 2017/3/24 4:45, Juan Quintela wrote: >> We change the meaning of start to be the offset from the beggining of >> the block. >> >> @@ -701,7 +701,7 @@ static void migration_bitmap_sync(RAMState *rs) >> qemu_mutex_lock(&rs->bitmap_mutex); >> rcu_read_lock(); >>

Re: [Qemu-devel] [RFC] Split migration bitmaps by ramblock

2017-03-24 Thread Juan Quintela
Yang Hongyang wrote: > Hi Juan, > > First of all, I like the refactor patchset about RAMState, it makes > things clean, great! Thanks. The whole idea of the series was to make testing changes easier. > On 2017/3/24 5:01, Juan Quintela wrote: >> Hi >> >> This series split the migration and un

Re: [Qemu-devel] [PATCH v2] xen-platform: separate unplugging of NVMe disks

2017-03-24 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 24 March 2017 00:51 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Stefano > Stabellini ; Anthony Perard > > Subject: Re: [PATCH v2] xen-platform: separate unplugging o

Re: [Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

2017-03-24 Thread Yang Hongyang
Hi Juan, On 2017/3/24 16:29, Juan Quintela wrote: > Yang Hongyang wrote: >> On 2017/3/24 4:45, Juan Quintela wrote: >>> We change the meaning of start to be the offset from the beggining of >>> the block. >>> >>> @@ -701,7 +701,7 @@ static void migration_bitmap_sync(RAMState *rs) >>> qemu_mu

Re: [Qemu-devel] [RFC] Split migration bitmaps by ramblock

2017-03-24 Thread Yang Hongyang
On 2017/3/24 16:34, Juan Quintela wrote: > Yang Hongyang wrote: >> Hi Juan, >> >> First of all, I like the refactor patchset about RAMState, it makes >> things clean, great! > > Thanks. > > The whole idea of the series was to make testing changes easier. > >> On 2017/3/24 5:01, Juan Quintel

[Qemu-devel] [PATCH] target/s390x/kvm: Fix problem when running with SELinux under z/VM

2017-03-24 Thread Thomas Huth
When running QEMU with KVM under z/VM, the memory for the guest is allocated via legacy_s390_alloc() since the KVM_CAP_S390_COW extension is not supported on z/VM. legacy_s390_alloc() then uses mmap(... PROT_EXEC ...) for the guest memory - but this does not work when running with SELinux enabled,

[Qemu-devel] [Bug 1675549] Re: tcg softmmu i386 crashes on BE hardware

2017-03-24 Thread Thomas Huth
This is likely the same or at least a similar problem as reported in this bug here: https://bugs.launchpad.net/qemu/+bug/1675108 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1675549 Title: tcg s

Re: [Qemu-devel] [Qemu-ppc] Bug in qemu-system-ppc in Windows using the SDL2 GUI

2017-03-24 Thread Thomas Huth
On 24.03.2017 09:56, Mark Cave-Ayland wrote: > On 24/03/17 08:47, Howard Spoelstra wrote: > >> Hi, >> >> Running qemu-system-ppc.exe in windows with the SDL2 GUI results in a >> hangup. I bisected to this commit: >> >> 8bb93c6f99a42c2e0943bc904b283cd622d302c5 is the first bad commit >> commit 8bb9

Re: [Qemu-devel] [PULL 5/7] pci: introduce a bus master container

2017-03-24 Thread Alexey Kardashevskiy
On 16/03/17 05:01, Michael S. Tsirkin wrote: > From: Jason Wang > > 96a8821d2141 ("virtio: unbreak virtio-pci with IOMMU after caching ring > translations") tries to make IOMMU works with virtio memory region > cache, but it requires IOMMU to be created before any virtio > devices. This is sub op

Re: [Qemu-devel] [PATCH] target/s390x/kvm: Fix problem when running with SELinux under z/VM

2017-03-24 Thread Cornelia Huck
On Fri, 24 Mar 2017 10:26:55 +0100 Thomas Huth wrote: > When running QEMU with KVM under z/VM, the memory for the guest > is allocated via legacy_s390_alloc() since the KVM_CAP_S390_COW > extension is not supported on z/VM. legacy_s390_alloc() then uses > mmap(... PROT_EXEC ...) for the guest mem

Re: [Qemu-devel] [PATCH] target/s390x/kvm: Fix problem when running with SELinux under z/VM

2017-03-24 Thread Christian Borntraeger
On 03/24/2017 10:26 AM, Thomas Huth wrote: > When running QEMU with KVM under z/VM, the memory for the guest > is allocated via legacy_s390_alloc() since the KVM_CAP_S390_COW > extension is not supported on z/VM. legacy_s390_alloc() then uses > mmap(... PROT_EXEC ...) for the guest memory - but thi

Re: [Qemu-devel] [PATCH v2] qemu-ga: add guest-get-osinfo command

2017-03-24 Thread Vinzenz Feenstra
> On Mar 23, 2017, at 3:58 PM, Eric Blake wrote: > > On 03/16/2017 09:50 AM, Vinzenz 'evilissimo' Feenstra wrote: >> From: Vinzenz Feenstra >> >> Add a new 'guest-get-osinfo' command for reporting basic information of >> the guest operating system (hereafter just 'OS'). This information >> inc

Re: [Qemu-devel] [PATCH 1/2] migration: Disable hotplug/unplug during migration

2017-03-24 Thread Thomas Huth
On 23.03.2017 21:50, Juan Quintela wrote: > Until we have reviewed what can/can't be hotplug during migration, > disable it. We can enable it later for the things that we know that > work. For instance, memory hotplug during postcopy don't work > currently. > > Signed-off-by: Juan Quintela > --

Re: [Qemu-devel] [PATCH 1/2] migration: Disable hotplug/unplug during migration

2017-03-24 Thread Juan Quintela
Thomas Huth wrote: > On 23.03.2017 21:50, Juan Quintela wrote: >> Until we have reviewed what can/can't be hotplug during migration, >> disable it. We can enable it later for the things that we know that >> work. For instance, memory hotplug during postcopy don't work >> currently. >> >> Signed

Re: [Qemu-devel] [PATCH] target/s390x/kvm: Fix problem when running with SELinux under z/VM

2017-03-24 Thread Thomas Huth
On 24.03.2017 10:38, Cornelia Huck wrote: > On Fri, 24 Mar 2017 10:26:55 +0100 > Thomas Huth wrote: [...] >> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c >> index ac47154..5167436 100644 >> --- a/target/s390x/kvm.c >> +++ b/target/s390x/kvm.c >> @@ -678,8 +678,7 @@ static void *legacy_s390

Re: [Qemu-devel] [PATCH 01/51] ram: Update all functions comments

2017-03-24 Thread Peter Xu
Hi, Juan, Got several nitpicks below... (along with some questions) On Thu, Mar 23, 2017 at 09:44:54PM +0100, Juan Quintela wrote: [...] > static void xbzrle_cache_zero_page(ram_addr_t current_addr) > { > @@ -459,8 +474,8 @@ static void xbzrle_cache_zero_page(ram_addr_t > current_addr) > *

Re: [Qemu-devel] Guest application reading from pl011 without device driver

2017-03-24 Thread Jiahuan Zhang
Hi, now it is working with the following char-pipe_new.c. See the patch. Doing the "if fifo has space" polling only when there are data on the pipe, and next reading from pipe. The sub_thread does these three things, and the main thread only does writing to UART fifo when the subthread signalled i

Re: [Qemu-devel] [PATCH] target/s390x/kvm: Fix problem when running with SELinux under z/VM

2017-03-24 Thread Thomas Huth
On 24.03.2017 10:39, Christian Borntraeger wrote: > On 03/24/2017 10:26 AM, Thomas Huth wrote: >> When running QEMU with KVM under z/VM, the memory for the guest >> is allocated via legacy_s390_alloc() since the KVM_CAP_S390_COW >> extension is not supported on z/VM. legacy_s390_alloc() then uses >

Re: [Qemu-devel] [PATCH 42/51] ram: Pass RAMBlock to bitmap_sync

2017-03-24 Thread Juan Quintela
Yang Hongyang wrote: > Hi Juan, > > On 2017/3/24 16:29, Juan Quintela wrote: >> Yang Hongyang wrote: >>> On 2017/3/24 4:45, Juan Quintela wrote: We change the meaning of start to be the offset from the beggining of the block. @@ -701,7 +701,7 @@ static void migration_bitmap_sy

Re: [Qemu-devel] [Qemu-arm] [patch 1/1]about armv8's prefetch decode

2017-03-24 Thread Peter Maydell
On 24 March 2017 at 06:14, Wangjintang wrote: > Hi Pranith, > > Thanks for your reply. patch as below, new added code default is off, > please review. > The major thinking is about translate Armv8's prefetch instruction into > intermediate code, at the same time don't effect the rm/rn re

Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class

2017-03-24 Thread Peter Maydell
On 24 March 2017 at 08:23, Juergen Gross wrote: > On 23/03/17 22:28, Eduardo Habkost wrote: >> The xen-backend devices created by the Xen code are not supposed >> to be treated as dynamic sysbus devices. This is an attempt to >> change that and see what happens, but I couldn't test it because >> I

Re: [Qemu-devel] [PATCH 17/51] ram: Move xbzrle_bytes into RAMState

2017-03-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 690ca8f..721fd66 100644 > --- a/mi

Re: [Qemu-devel] [PATCH 18/51] ram: Move xbzrle_pages into RAMState

2017-03-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > migration/ram.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 721fd66..b4e647a 100644 > --- a/migration/ram.c > +++ b/migration/ram.c >

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2017-03-24 Thread Nikunj A Dadhania
Richard Henderson writes: > On 09/12/2016 06:47 AM, Alex Bennée wrote: >>> > +/* Notice an IO access, or a notdirty page. */ >>> > +if (unlikely(tlb_addr & ~TARGET_PAGE_MASK)) { >>> > +/* There's really nothing that can be done to >>> > + support this apart from stop-th

Re: [Qemu-devel] [PATCH 19/51] ram: Move xbzrle_cache_miss into RAMState

2017-03-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index b4e647a..cc19406 100644 > ---

Re: [Qemu-devel] [PATCH 20/51] ram: Move xbzrle_cache_miss_rate into RAMState

2017-03-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index cc19406..c398ff9 100644 > --- a/mi

Re: [Qemu-devel] [PATCH 21/51] ram: Move xbzrle_overflows into RAMState

2017-03-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Once there, remove the now unused AccountingInfo struct and var. Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Juan Quintela > --- > migration/ram.c | 21 + > 1 file changed, 5 insertions(+), 16 deletions(-) > > diff --

Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class

2017-03-24 Thread Juergen Gross
On 24/03/17 11:09, Peter Maydell wrote: > On 24 March 2017 at 08:23, Juergen Gross wrote: >> On 23/03/17 22:28, Eduardo Habkost wrote: >>> The xen-backend devices created by the Xen code are not supposed >>> to be treated as dynamic sysbus devices. This is an attempt to >>> change that and see wha

Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class

2017-03-24 Thread Thomas Huth
On 24.03.2017 11:09, Peter Maydell wrote: > On 24 March 2017 at 08:23, Juergen Gross wrote: >> On 23/03/17 22:28, Eduardo Habkost wrote: >>> The xen-backend devices created by the Xen code are not supposed >>> to be treated as dynamic sysbus devices. This is an attempt to >>> change that and see w

[Qemu-devel] guest-exec of qemu-guest-agent fails on Windows guest

2017-03-24 Thread Armin Ranjbar
Hi everyone, We are trying to use guest-exec[0] command of qemu-guest-agent. However, discovered that whatever command we try to run, it ends up with the following error on the host side: > error: Guest agent is not responding: Guest agent not available for now An example of what we run on the h

Re: [Qemu-devel] [Qemu-ppc] [Bug 1674925] Re: Qemu PPC64 kvm no display if --device virtio-gpu-pci is selected

2017-03-24 Thread Cédric Le Goater
Hello Luigi, I have some difficulty sorting out what is going on and what could be considered a regression :/ you are reporting many issues at the same time with a home made kernel. Could you please use the kernel shipped with the distro to start with ? > yes usually with 2.8 i boot the V

Re: [Qemu-devel] [PATCH for-2.9 v3 0/2] virtio-scsi: Fix assertion failure on dataplane handlers

2017-03-24 Thread Paolo Bonzini
On 17/03/2017 07:14, Fam Zheng wrote: > v3: Don't forget the virtio_scsi_release in virtio_scsi_handle_event_vq. [Ed > Swierk] > v2: Use virtio_scsi_acquire/release. [Paolo] > > Fam Zheng (2): > virtio-scsi: Make virtio_scsi_acquire/release public > virtio-scsi: Fix acquire/release in datap

Re: [Qemu-devel] [PATCH] tcg/i386: Check the size of instruction being translated

2017-03-24 Thread Paolo Bonzini
Queued, thanks. Paolo On 23/03/2017 18:58, Pranith Kumar wrote: > Sending again since I messed by pbonzini's email. > > This fixes the bug: 'user-to-root privesc inside VM via bad translation > caching' reported by Jann Horn here: > https://bugs.chromium.org/p/project-zero/issues/detail?id=1122

Re: [Qemu-devel] [PATCH] mem-prealloc: fix sysconf(_SC_NPROCESSORS_ONLN) failure case.

2017-03-24 Thread Paolo Bonzini
On 21/03/2017 07:50, Jitendra Kolhe wrote: > This was spotted by Coverity, in case where sysconf(_SC_NPROCESSORS_ONLN) > fails and returns -1. This results in memset_num_threads getting set to -1. > Which we then pass to g_new0(). > The patch replaces MAX_MEM_PREALLOC_THREAD_COUNT macro with a fu

Re: [Qemu-devel] q35 and sysbus devices

2017-03-24 Thread Marcel Apfelbaum
On 03/22/2017 10:46 PM, Laszlo Ersek wrote: On 03/22/17 21:31, Eduardo Habkost wrote: Hi, I am investigating the current status of has_dynamic_sysbus and sysbus device support on each of QEMU's machine types. The good news is that almost all has_dynamic_sysbus=1 machines have their own internal

Re: [Qemu-devel] [PATCH 35/51] ram: Add QEMUFile to RAMState

2017-03-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > migration/ram.c | 17 ++--- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index c0d6841..7667e73 100644 > --- a/migration/ram.c > +++ b/migrat

[Qemu-devel] qemu-system-s390x tests/boot-serial-test intermittent failure

2017-03-24 Thread Peter Maydell
Hi; qemu-system-s390x seems to have an intermittent failure at the moment -- it's been causing our Travis builds to flap. I actually caught it doing this on one of my local test builds (which happens to be aarch64 but I don't think that matters, since Travis is doing x86 builds): while QTEST_QEMU

Re: [Qemu-devel] [PATCH v3 13/34] tcg: Add atomic helpers

2017-03-24 Thread Alex Bennée
Nikunj A Dadhania writes: > Richard Henderson writes: > >> On 09/12/2016 06:47 AM, Alex Bennée wrote: > +/* Notice an IO access, or a notdirty page. */ > +if (unlikely(tlb_addr & ~TARGET_PAGE_MASK)) { > +/* There's really nothing that can be done to > +

Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class

2017-03-24 Thread Eduardo Habkost
On Fri, Mar 24, 2017 at 11:24:31AM +0100, Juergen Gross wrote: > On 24/03/17 11:09, Peter Maydell wrote: > > On 24 March 2017 at 08:23, Juergen Gross wrote: > >> On 23/03/17 22:28, Eduardo Habkost wrote: > >>> The xen-backend devices created by the Xen code are not supposed > >>> to be treated as

Re: [Qemu-devel] qemu-system-s390x tests/boot-serial-test intermittent failure

2017-03-24 Thread Christian Borntraeger
On 03/24/2017 11:57 AM, Peter Maydell wrote: > Hi; qemu-system-s390x seems to have an intermittent failure at > the moment -- it's been causing our Travis builds to flap. I actually > caught it doing this on one of my local test builds (which happens > to be aarch64 but I don't think that matters,

Re: [Qemu-devel] [PATCH 02/51] ram: rename block_name to rbname

2017-03-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > So all places are consisten on the nambing of a block name parameter. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > migration/ram.c | 17 - > 1 file changed, 8 insertions(+), 9 deletions(-) > > diff

Re: [Qemu-devel] [PATCH 35/51] ram: Add QEMUFile to RAMState

2017-03-24 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela >> --- >> migration/ram.c | 17 ++--- >> 1 file changed, 10 insertions(+), 7 deletions(-) >> >> diff --git a/migration/ram.c b/migration/ram.c >> index c0d6841..7667e73 100

Re: [Qemu-devel] [PATCH for-2.9] disas/microblaze: Remove unused REG_PC define

2017-03-24 Thread Peter Maydell
On 23 March 2017 at 19:41, Edgar E. Iglesias wrote: > On Thu, Mar 23, 2017 at 12:42:41PM +, Peter Maydell wrote: >> The REG_PC define in disas/microblaze.c clashes with a define in >> the Linux SPARC system headers: >> >> /home/pm215/qemu/disas/microblaze.c:162:0: error: "REG_PC" redefined >>

Re: [Qemu-devel] qemu-system-s390x tests/boot-serial-test intermittent failure

2017-03-24 Thread Thomas Huth
On 24.03.2017 12:11, Christian Borntraeger wrote: > On 03/24/2017 11:57 AM, Peter Maydell wrote: >> Hi; qemu-system-s390x seems to have an intermittent failure at >> the moment -- it's been causing our Travis builds to flap. I actually >> caught it doing this on one of my local test builds (which h

Re: [Qemu-devel] qemu-system-s390x tests/boot-serial-test intermittent failure

2017-03-24 Thread Peter Maydell
On 24 March 2017 at 11:26, Thomas Huth wrote: > I was not able to reproduce this issue so far (on my x86 laptop since I > don't have an aarch64 host) ... can you reproduce it by running the test > directly, too, e.g. something like: > > QTEST_QEMU_BINARY=s390x-softmmu/qemu-system-s390x tests/boot-

Re: [Qemu-devel] q35 and sysbus devices

2017-03-24 Thread Thomas Huth
On 22.03.2017 21:31, Eduardo Habkost wrote: > Hi, > > I am investigating the current status of has_dynamic_sysbus and > sysbus device support on each of QEMU's machine types. The good > news is that almost all has_dynamic_sysbus=1 machines have their > own internal (often short) whitelist of suppo

Re: [Qemu-devel] [PATCH 01/51] ram: Update all functions comments

2017-03-24 Thread Juan Quintela
Peter Xu wrote: > Hi, Juan, > > Got several nitpicks below... (along with some questions) > > On Thu, Mar 23, 2017 at 09:44:54PM +0100, Juan Quintela wrote: > > [...] > >> static void xbzrle_cache_zero_page(ram_addr_t current_addr) >> { >> @@ -459,8 +474,8 @@ static void xbzrle_cache_zero_page(r

Re: [Qemu-devel] qemu-system-s390x tests/boot-serial-test intermittent failure

2017-03-24 Thread Paolo Bonzini
On 24/03/2017 12:11, Christian Borntraeger wrote: > One idea. Maybe qemu exits before the other side is ready. > Does reverting > > commit 864111f422babcf8ce837fb47f7f9e1948446f22 > Author: Christian Borntraeger > AuthorDate: Tue Oct 18 09:29:54 2016 +0200 > Commit: Paolo Bonzini > Com

Re: [Qemu-devel] qemu-system-s390x tests/boot-serial-test intermittent failure

2017-03-24 Thread Peter Maydell
On 24 March 2017 at 11:11, Christian Borntraeger wrote: > One idea. Maybe qemu exits before the other side is ready. > Does reverting > > commit 864111f422babcf8ce837fb47f7f9e1948446f22 > Author: Christian Borntraeger > AuthorDate: Tue Oct 18 09:29:54 2016 +0200 > Commit: Paolo Bonzini >

Re: [Qemu-devel] .PO files modified under build

2017-03-24 Thread Dr. David Alan Gilbert
* James Hanley (jhan...@dgtlrift.com) wrote: > I have a git clone of qemu, and I build out of qemu-build... essentially > the layout looks like: > ./ > ./qemu/ -> clone of qemu > ./qemu-build/ > ./Makefile > > The contents of the top level Makefile contain the following rules: > rwildcard=$

Re: [Qemu-devel] [Qemu-ppc] [Bug 1674925] Re: Qemu PPC64 kvm no display if --device virtio-gpu-pci is selected

2017-03-24 Thread luigiburdo
Hi Cèdric, first of all thanks for your relpy. >I have some difficulty sorting out what is going on and what >could be considered a regression :/ you are reporting many >issues at the same time with a home made kernel. >Could you please use the kernel shipped with the distro to >start with ? I

Re: [Qemu-devel] [PATCH for-2.10 15/23] QMP: include CpuInstanceProperties into query_cpus output output

2017-03-24 Thread Igor Mammedov
On Thu, 23 Mar 2017 08:19:24 -0500 Eric Blake wrote: > On 03/22/2017 08:32 AM, Igor Mammedov wrote: > > if board supports CpuInstanceProperties, report them for > > each CPU thread listed. Main motivation for this is to > > provide these properties introspection via QMP interface > > for using in

Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class

2017-03-24 Thread Juergen Gross
On 24/03/17 12:10, Eduardo Habkost wrote: > On Fri, Mar 24, 2017 at 11:24:31AM +0100, Juergen Gross wrote: >> On 24/03/17 11:09, Peter Maydell wrote: >>> On 24 March 2017 at 08:23, Juergen Gross wrote: On 23/03/17 22:28, Eduardo Habkost wrote: > The xen-backend devices created by the Xen

[Qemu-devel] Making QMP 'block-job-cancel' transactionable

2017-03-24 Thread Kashyap Chamarthy
While debugging some other issue, I happened to stumble across an old libvirt commit[*] that adds support for pivot (whether QEMU should switch to a target copy or not) operation as a result of issuing QMP 'block-job-cancel' to a 'drive-mirror' (in libvirt parlance, "block copy"). In the libvirt c

Re: [Qemu-devel] [PATCH for-2.9 4/5] rbd: Peel off redundant RbdAuthMethod wrapper struct

2017-03-24 Thread Jeff Cody
On Fri, Mar 24, 2017 at 08:05:49AM +0100, Markus Armbruster wrote: > Adding Daniel Berrange for QCryptoSecret expertise. > > Jeff Cody writes: > > > On Thu, Mar 23, 2017 at 04:56:30PM -0500, Eric Blake wrote: > >> On 03/23/2017 04:43 PM, Eric Blake wrote: > >> > >> > We'd still have to allow li

Re: [Qemu-devel] [PATCH 0/3] script for crash-testing -device

2017-03-24 Thread Marcel Apfelbaum
On 03/23/2017 05:43 PM, Thomas Huth wrote: On 22.03.2017 20:13, Eduardo Habkost wrote: On Wed, Mar 22, 2017 at 01:00:49PM -0300, Eduardo Habkost wrote: This series adds scripts/device-crashtest.py, that can be used to crash-test -device with multiple machine/accel/device combinations. The scri

[Qemu-devel] [PATCH] ppc_booke: drop useless assignment

2017-03-24 Thread fred . konrad
From: KONRAD Frederic The tb_env variable is set two lines above. So just drop the double assignment. Signed-off-by: KONRAD Frederic --- hw/ppc/ppc_booke.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ppc/ppc_booke.c b/hw/ppc/ppc_booke.c index 60baffa..23bcf1b 100644 --- a/hw/ppc/ppc_

Re: [Qemu-devel] qemu-system-s390x tests/boot-serial-test intermittent failure

2017-03-24 Thread Peter Maydell
On 24 March 2017 at 11:50, Peter Maydell wrote: > On 24 March 2017 at 11:11, Christian Borntraeger > wrote: >> diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c >> index 57edf6a..11f48b0 100644 >> --- a/tests/boot-serial-test.c >> +++ b/tests/boot-serial-test.c >> @@ -79,8 +79,8 @

Re: [Qemu-devel] qemu-system-s390x tests/boot-serial-test intermittent failure

2017-03-24 Thread Christian Borntraeger
On 03/24/2017 01:56 PM, Peter Maydell wrote: > On 24 March 2017 at 11:50, Peter Maydell wrote: >> On 24 March 2017 at 11:11, Christian Borntraeger >> wrote: >>> diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c >>> index 57edf6a..11f48b0 100644 >>> --- a/tests/boot-serial-test.c >

[Qemu-devel] [PATCH] boot-serial-test: use -no-shutdown

2017-03-24 Thread Christian Borntraeger
a qemu with an empty s390 guest will exit very quickly. This races against the testsuite reading from the console pipe leading to intermittent test suite failures. Using -no-shutdown will keep the guest running. Fixes: 864111f422ba (vl: exit qemu on guest panic if -no-shutdown is not set) Reported

Re: [Qemu-devel] [PATCH for-2.10 22/23] numa: add '-numa cpu, ...' option for property based node mapping

2017-03-24 Thread Igor Mammedov
On Thu, 23 Mar 2017 08:23:32 -0500 Eric Blake wrote: ... > > > > +@samp{cpu} option is new alternative to @samp{cpus} option > > s/is/is a/ > > > +uses @samp{socket-id|core-id|thread-id} properties to assign > > s/uses/which uses/ > > > +CPU objects to a @var{node} using topology layout

Re: [Qemu-devel] [PATCH for-2.9 3/5] rbd: Rewrite the code to extract list-valued options

2017-03-24 Thread Eric Blake
On 03/24/2017 03:25 AM, Markus Armbruster wrote: -value = host; -if (port) { +host = qstring_get_str(qobject_to_qstring(val)); +sprintf(keybuf, "server.%d.port", i); +port = qdict_get_str(options, keybuf); >>> >>> This segfa

Re: [Qemu-devel] [Qemu-arm] [patch 1/1]about armv8's prefetch decode

2017-03-24 Thread Wangjintang
Hi Pranith, Thanks for your reply. patch as below, new added code default is off, please review. The major thinking is about translate Armv8's prefetch instruction into intermediate code, at the same time don't effect the rm/rn register. diff --git a/translate-a64.c b/translate-a64.

Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

2017-03-24 Thread Stefan Hajnoczi
On Thu, Mar 16, 2017 at 2:12 PM, Gerd Hoffmann wrote: >> > -#define DEPTH 8 >> > -#include "cirrus_vga_rop2.h" >> > - >> > -#define DEPTH 16 >> > -#include "cirrus_vga_rop2.h" >> > - >> > -#define DEPTH 24 >> > -#include "cirrus_vga_rop2.h" >> > - >> > #define DEPTH 32 >> > #include "cirrus_vga_

[Qemu-devel] [PATCH v3] xen-platform: separate unplugging of NVMe disks

2017-03-24 Thread Paul Durrant
Commit 090fa1c8 "add support for unplugging NVMe disks..." extended the existing disk unplug flag to cover NVMe disks as well as IDE and SCSI. The recent thread on the xen-devel mailing list [1] has highlighted that this is not desirable behaviour: PV frontends should be able to distinguish NVMe d

Re: [Qemu-devel] [PATCH] Dead code removal: removing code for unsupported DEPTH.

2017-03-24 Thread Peter Maydell
On 24 March 2017 at 13:36, Stefan Hajnoczi wrote: > Gerd, please reply if this is wrong, but here is a summary of the task: > > Some emulated graphics cards use qemu_console_surface() and that > surface is always in 32 bits per pixel format. Therefore, code for > dealing with other pixel formats

Re: [Qemu-devel] q35 and sysbus devices

2017-03-24 Thread Eduardo Habkost
On Fri, Mar 24, 2017 at 01:49:16PM +0300, Marcel Apfelbaum wrote: > On 03/22/2017 10:46 PM, Laszlo Ersek wrote: > > On 03/22/17 21:31, Eduardo Habkost wrote: > > > Hi, > > > > > > I am investigating the current status of has_dynamic_sysbus and > > > sysbus device support on each of QEMU's machine

Re: [Qemu-devel] [PATCH for-2.9 4/5] rbd: Peel off redundant RbdAuthMethod wrapper struct

2017-03-24 Thread Eric Blake
On 03/24/2017 07:42 AM, Jeff Cody wrote: > Agree. My preference is to leave it as an array of methods, so long as that > is tenable to libvirt. The -drive syntax should remain unchanged (that's an absolute must for libvirt). But the QMP syntax being an array of methods sounds best to me, and I

Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class

2017-03-24 Thread Eduardo Habkost
On Fri, Mar 24, 2017 at 01:27:31PM +0100, Juergen Gross wrote: > On 24/03/17 12:10, Eduardo Habkost wrote: > > On Fri, Mar 24, 2017 at 11:24:31AM +0100, Juergen Gross wrote: > >> On 24/03/17 11:09, Peter Maydell wrote: > >>> On 24 March 2017 at 08:23, Juergen Gross wrote: > On 23/03/17 22:28,

Re: [Qemu-devel] [RFC 1/4] [UNTESTED] xen: Don't force has_dynamic_sysbus on machine class

2017-03-24 Thread Juergen Gross
On 24/03/17 14:50, Eduardo Habkost wrote: > On Fri, Mar 24, 2017 at 01:27:31PM +0100, Juergen Gross wrote: >> On 24/03/17 12:10, Eduardo Habkost wrote: >>> On Fri, Mar 24, 2017 at 11:24:31AM +0100, Juergen Gross wrote: On 24/03/17 11:09, Peter Maydell wrote: > On 24 March 2017 at 08:23, Ju

[Qemu-devel] [PULL for-2.9 1/3] trace: Fix backwards mirror_yield parameters

2017-03-24 Thread Stefan Hajnoczi
From: Eric Blake block/trace-events lists the parameters for mirror_yield consistently with other mirror events (cnt just after s, like in mirror_before_sleep; in_flight last, like in mirror_yield_in_flight). But the callers were passing parameters in the wrong order, leading to poor trace messag

[Qemu-devel] [PULL for-2.9 3/3] trace: Avoid abuse of amdvi_mmio_read

2017-03-24 Thread Stefan Hajnoczi
From: Eric Blake hw/i386/trace-events has an amdvi_mmio_read trace that is used for both normal reads (listing the register name, address, size, and offset) and for an error case (abusing the register name to show an error message, the address to show the maximum value supported, then shoehorning

[Qemu-devel] [PULL for-2.9 2/3] trace: Fix incorrect megasas trace parameters

2017-03-24 Thread Stefan Hajnoczi
From: Eric Blake hw/scsi/trace-events lists cmd as the first parameter for both megasas_iovec_overflow and megasas_iovec_underflow, but the caller was mistakenly passing cmd->iov_size twice instead of the command index. Also, trace_megasas_abort_invalid is called with parameters in the wrong ord

[Qemu-devel] [PULL for-2.9 0/3] Tracing patches

2017-03-24 Thread Stefan Hajnoczi
The following changes since commit 08329701199449bde497570dcfdb9c86062baf20: qom: Fix regression with 'qom-type' (2017-03-23 17:59:40 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request for you to fetch changes up to 0d3ef78829332f2fdc

Re: [Qemu-devel] [PATCH for-2.9 4/5] rbd: Peel off redundant RbdAuthMethod wrapper struct

2017-03-24 Thread Jeff Cody
On Fri, Mar 24, 2017 at 08:49:20AM -0500, Eric Blake wrote: > On 03/24/2017 07:42 AM, Jeff Cody wrote: > > > Agree. My preference is to leave it as an array of methods, so long as that > > is tenable to libvirt. > > The -drive syntax should remain unchanged (that's an absolute must for > libvirt

[Qemu-devel] [PATCH v5] qga: Add `guest-get-timezone` command

2017-03-24 Thread Vinzenz 'evilissimo' Feenstra
From: Vinzenz Feenstra Adds a new command `guest-get-timezone` reporting the currently configured timezone on the system. The information on what timezone is currently is configured is useful in case of Windows VMs where the offset of the hardware clock is required to have the same offset. This c

[Qemu-devel] [PATCH v5] qga: Add `guest-get-timezone` command

2017-03-24 Thread Vinzenz 'evilissimo' Feenstra
From: Vinzenz Feenstra Changes since v4: - Corrected usage of the optional zone (Missing has_zone = true) - Updated documentation string for offset in the schema - Removed unnecessary checks - Uses the current time to check for the interval, not 0 - Switched to UNIVERSAL time type, since that can

Re: [Qemu-devel] [PATCH] boot-serial-test: use -no-shutdown

2017-03-24 Thread Peter Maydell
On 24 March 2017 at 13:19, Christian Borntraeger wrote: > a qemu with an empty s390 guest will exit very quickly. This races > against the testsuite reading from the console pipe leading to > intermittent test suite failures. Using -no-shutdown will keep > the guest running. > > Fixes: 864111f422b

Re: [Qemu-devel] q35 and sysbus devices

2017-03-24 Thread Peter Maydell
On 24 March 2017 at 13:48, Eduardo Habkost wrote: > The problem with today's mechanism is that we have no way to make > a machine accept one type of sysbus device without making it > start accepting every other sysbus devices. If we thought all > !cannot_instantiate_with_device_add_yet sysbus devi

Re: [Qemu-devel] [PATCH 2/2 v1] throttle: factor out the redundant code

2017-03-24 Thread Pradeep Jagadeesh
On 3/23/2017 7:14 PM, Eric Blake wrote: On 03/23/2017 09:46 AM, Eric Blake wrote: On 03/23/2017 07:20 AM, Pradeep Jagadeesh wrote: This patchset removes the throttle redundant code that was present in block and fsdev files. Signed-off-by: Pradeep Jagadeesh --- I think you want portions of t

Re: [Qemu-devel] guest-exec of qemu-guest-agent fails on Windows guest

2017-03-24 Thread Marc-André Lureau
Hi On Fri, Mar 24, 2017 at 2:38 PM Armin Ranjbar wrote: > Hi everyone, > > We are trying to use guest-exec[0] command of qemu-guest-agent. However, > discovered that whatever command we try to run, it ends up with the > following error on the host side: > > > error: Guest agent is not responding

[Qemu-devel] [PATCH 1/2] virtio-input: free event queue when finalizing

2017-03-24 Thread Ladi Prosek
VirtIOInput.queue was never freed. This commit adds an explicit g_free to virtio_input_finalize and switches the allocation function from realloc to g_realloc in virtio_input_send. Signed-off-by: Ladi Prosek --- hw/input/virtio-input.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH 2/2] virtio-input: fix eventq batching

2017-03-24 Thread Ladi Prosek
virtio_input_send buffers input events until it sees a SYNC. Then it either sends or drops the entire batch, depending on whether eventq has enough space available. The case to avoid here is partial sends where only part of the batch would get to the guest. Using virtqueue_get_avail_bytes to check

Re: [Qemu-devel] [PATCH for-2.9 4/5] rbd: Peel off redundant RbdAuthMethod wrapper struct

2017-03-24 Thread Eric Blake
On 03/24/2017 09:10 AM, Jeff Cody wrote: > On Fri, Mar 24, 2017 at 08:49:20AM -0500, Eric Blake wrote: >> On 03/24/2017 07:42 AM, Jeff Cody wrote: >> >>> Agree. My preference is to leave it as an array of methods, so long as that >>> is tenable to libvirt. >> >> The -drive syntax should remain unc

Re: [Qemu-devel] [PATCH 1/2] migration: Disable hotplug/unplug during migration

2017-03-24 Thread Igor Mammedov
On Thu, 23 Mar 2017 21:50:24 +0100 Juan Quintela wrote: > Until we have reviewed what can/can't be hotplug during migration, > disable it. We can enable it later for the things that we know that > work. For instance, memory hotplug during postcopy don't work > currently. > > Signed-off-by: Jua

[Qemu-devel] [PATCH 0/2] virtio-input: eventq batching fixes

2017-03-24 Thread Ladi Prosek
Two bugs found when reviewing the code against the candidate spec: * memory leak: the event queue is never freed * incorrect virtqueue check: virtqueue_get_avail_bytes does not guarantee number of available buffers Ladi Prosek (2): virtio-input: free event queue when finalizing virtio-input

Re: [Qemu-devel] [PULL for-2.9 0/3] Tracing patches

2017-03-24 Thread Peter Maydell
On 24 March 2017 at 14:08, Stefan Hajnoczi wrote: > The following changes since commit 08329701199449bde497570dcfdb9c86062baf20: > > qom: Fix regression with 'qom-type' (2017-03-23 17:59:40 +) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git tags/tracing-p

Re: [Qemu-devel] guest-exec of qemu-guest-agent fails on Windows guest

2017-03-24 Thread Michael Roth
What steps did you use to install qga? Did you use the .msi installer? If not you'll need to make those glib helper executables available to the agent by placing them in the install directory or somewhere in its executable paths. The MSI installer should handle all this for you.

Re: [Qemu-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-24 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 22 March 2017 18:22 > To: Juergen Gross > Cc: Stefano Stabellini ; qemu-devel@nongnu.org; > xen-de...@lists.xenproject.org; Anthony Perard > ; kra...@redhat.com; Paul Durrant > > Subject: Re: [PATCH 2/

Re: [Qemu-devel] [PULL v3 1/3] replay: add record/replay for audio passthrough

2017-03-24 Thread Alex Bennée
Gerd Hoffmann writes: > From: Pavel Dovgalyuk > > This patch adds recording and replaying audio data. Is saves synchronization > information for audio out and inputs from the microphone. > > v2: removed unneeded whitespace change > > Signed-off-by: Pavel Dovgalyuk > Message-id: 20170202055054.

Re: [Qemu-devel] guest-exec of qemu-guest-agent fails on Windows guest

2017-03-24 Thread Armin Ranjbar
We have tried qemu-ga from Fedora [1] which didn't have guest-exec and guest-exec-status (qemu-ga -b ? didn't list them and running guest-exec returned command not found) and also build msi from HEAD ourselves. gspawn-exec files are there, when we try to run guest-exec command qemu-ga windows appl

Re: [Qemu-devel] [PATCH 2/2] configure: use pkg-config for obtaining xen version

2017-03-24 Thread Paul Durrant
> -Original Message- > From: Paul Durrant > Sent: 24 March 2017 15:13 > To: 'Stefano Stabellini' ; Juergen Gross > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Anthony > Perard ; kra...@redhat.com > Subject: RE: [PATCH 2/2] configure: use pkg-config for obtaining xen versio

  1   2   >