On 24 March 2017 at 13:36, Stefan Hajnoczi <stefa...@gmail.com> wrote: > Gerd, please reply if this is wrong, but here is a summary of the task: > > Some emulated graphics cards use qemu_console_surface() and that > surface is always in 32 bits per pixel format. Therefore, code for > dealing with other pixel formats can be removed. > > When looking for emulated graphics cards where this cleanup is > possible, keep in mind that some of the code operates on the guest's > frame buffer, whose pixel format is not under QEMU's control. > Therefore we cannot assume that 32bpp is always used and this cleanup > doesn't apply there. Limit yourself to code that uses > qemu_console_surface() exclusively to access the surface and you > should be fine. Other code is likely to need support for additional > pixel formats.
Also worth pointing at an example of a patchset that does this for some other device, eg Gerd's recent pl110 set, as a guide to what's getting removed. thanks -- PMM
