Re: [Qemu-devel] [PATCH 1/6] msix_init: assert programming error

2016-08-18 Thread Markus Armbruster
Cao jin writes: > CC: Markus Armbruster > CC: Marcel Apfelbaum > CC: Michael S. Tsirkin > Signed-off-by: Cao jin > --- > hw/pci/msix.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/pci/msix.c b/hw/pci/msix.c > index 0ec1cb1..384a29d 100644 > --- a/hw/pci/m

[Qemu-devel] [Bug 1614348] Re: qemu-arm core dumped for no entry symbol programe

2016-08-18 Thread Leslie Zhai
file a.out a.out: ELF 32-bit LSB executable, ARM, EABI5 version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-armhf.so.3, BuildID[sha1]=6a86f764c1200a41253e1bc80d3155a295b87818, not stripped -- You received this bug notification because you are a member of qemu- devel-ml, which is subs

[Qemu-devel] [Bug 1614348] [NEW] qemu-arm core dumped for no entry symbol programe

2016-08-18 Thread Leslie Zhai
Public bug reported: Hi qemu developers, Environment: * Fedora 24 x86_64 * qemu-arm version 2.6.92, Copyright (c) 2003-2008 Fabrice Bellard * arm-linux-gnu-gcc 6.1.1 20160621 (Red Hat Cross 6.1.1-2) (GCC) target: arm-linux-gnueabi * glibc-arm-linux-gnu-devel-2.23 very simple hello.c: #include

Re: [Qemu-devel] [PATCH 4/6] e1000e: drop unnecessary funtions

2016-08-18 Thread Cao jin
On 08/18/2016 01:23 PM, Dmitry Fleytman wrote: On 17 Aug 2016, at 17:39, Cao jin wrote: Internal helper function: e1000e_init_msix(), e1000e_cleanup_msix() is unnecessary, remove them all. Is there any reason to drop these functions? They exist to improve code readability and modularisat

[Qemu-devel] [PATCH 4/4] lsi: never set DMA FIFO Empty (DFE) bit in DSTAT register

2016-08-18 Thread Hervé Poussineau
53C895A datasheet says: "This bit (DFE) is a pure status bit and will not cause an interrupt" This bit is already auto-generated in lsi_read_reg when reading the DSTAT register. This fixes IBM RS/6000 7020 firmware, which is: - resetting the adapter - enabling all interrupt sources (including DI

[Qemu-devel] [PATCH 3/4] lsi: implement I/O memory space for Memory Move instructions

2016-08-18 Thread Hervé Poussineau
Memory Move instructions can read/write data either from PCI memory or from PCI I/O. Implement second case. Windows 98 now works with LSI 53C810A adapter. Signed-off-by: Hervé Poussineau --- hw/scsi/lsi53c895a.c | 49 +++-- 1 file changed, 39 inserti

[Qemu-devel] [PATCH 1/4] lsi: print register names in debug prints

2016-08-18 Thread Hervé Poussineau
Modify lsi_reg_readb function to have a single exit point. Debug print can now contain the returned value. Signed-off-by: Hervé Poussineau --- hw/scsi/lsi53c895a.c | 219 ++- 1 file changed, 146 insertions(+), 73 deletions(-) diff --git a/hw/scsi/

[Qemu-devel] [PATCH 2/4] lsi: do not exit QEMU if reading invalid register

2016-08-18 Thread Hervé Poussineau
When guest accesses invalid register, return 0xff instead of exiting. Also add a log when reading or writing invalid registers. Signed-off-by: Hervé Poussineau --- hw/scsi/lsi53c895a.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/

[Qemu-devel] [PATCH 0/4] lsi: misc fixes

2016-08-18 Thread Hervé Poussineau
Hi, This patchset are some miscellaneous changes I did on LSI SCSI adapter: - patch 1: some debugging help (register names) - patch 2: removed one triggerable guest QEMU exit - patch 3: compatibility with stock Windows 98 driver - patch 4: compatibility with a real firmware Note that patch 1 does

Re: [Qemu-devel] [PATCH 1/6] msix_init: assert programming error

2016-08-18 Thread Cao jin
On 08/18/2016 03:14 PM, Markus Armbruster wrote: Cao jin writes: Please explain in the commit message why these are programming errors. If you're unsure how, give it a try in a reply to this message, and we'll hammer out something together. Ok, how about this: The input parameters is

Re: [Qemu-devel] Help: Does Qemu support virtio-pci for net-device and disk device?

2016-08-18 Thread Andrew Jones
On Wed, Aug 17, 2016 at 01:00:05PM -0400, Laine Stump wrote: > On 08/17/2016 12:13 PM, Andrew Jones wrote: > > On Wed, Aug 17, 2016 at 08:08:11PM +0800, Kevin Zhao wrote: > > > Hi all, > > > Now I'm investigating net device hot plug and disk hotplug for > > > AArch64. For virtio , the default

Re: [Qemu-devel] [PATCH 0/4] lsi: misc fixes

2016-08-18 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 1471505489-1221-1-git-send-email-hpous...@reactos.org Subject: [Qemu-devel] [PATCH 0/4] lsi: misc fixes Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log -

Re: [Qemu-devel] [PATCH 2/6] pci: Convert msix_init() to Error and fix callers to check it

2016-08-18 Thread Markus Armbruster
Cao jin writes: > msix_init() has the same issue with msi_init(), which reports errors > via error_report(), that is not suitable when it's used in realize(). Suggest to point to commit 1108b2f. Perhaps: msix_init() reports errors with error_report(), which is wrong when it's used in r

Re: [Qemu-devel] [RFC PATCH v2 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-18 Thread Vijay Kilari
On Wed, Aug 17, 2016 at 7:09 PM, Paolo Bonzini wrote: > > > On 16/08/2016 14:02, vijay.kil...@gmail.com wrote: >> From: Vijaya Kumar K >> >> Add helper API to read MIDR_EL1 registers to fetch >> cpu identification information. This helps in >> adding errata's and architecture specific features. >

Re: [Qemu-devel] [PATCH v4 1/2] trace: Remove 'trace_events_dstate_init'

2016-08-18 Thread Daniel P. Berrange
On Fri, Aug 12, 2016 at 05:33:41PM +0200, Lluís Vilanova wrote: > Removes the event state array used for early initialization. Since only > events with the "vcpu" property need a late initialization fixup, > threats their initialization specially. > > Assumes that the user won't touch the state of

Re: [Qemu-devel] [PATCH v4 2/2] trace: Avoid implicit bool->integer conversions

2016-08-18 Thread Daniel P. Berrange
On Fri, Aug 12, 2016 at 05:33:46PM +0200, Lluís Vilanova wrote: > An explicit if/else is clearer than arithmetic assuming #true is 1, > while the compiler should be able to generate just as optimal code. > > Signed-off-by: Lluís Vilanova > --- > stubs/trace-control.c | 17 +++-- >

Re: [Qemu-devel] [PATCH v4 12/17] qapi: check invalid arguments on no-args commands

2016-08-18 Thread Marc-André Lureau
Hi On Thu, Aug 18, 2016 at 10:50 AM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi > > > > On Wed, Aug 17, 2016 at 6:49 PM Markus Armbruster > wrote: > > > >> marcandre.lur...@redhat.com writes: > >> > >> > From: Marc-André Lureau > >> > > >> > The generated marshal functions d

Re: [Qemu-devel] [RFC v6-based v1 0/5] refine mdev framework

2016-08-18 Thread Dong Jia
On Wed, 17 Aug 2016 03:09:10 -0700 Neo Jia wrote: > On Wed, Aug 17, 2016 at 04:58:14PM +0800, Dong Jia wrote: > > On Tue, 16 Aug 2016 16:14:12 +0800 > > Jike Song wrote: > > > > > > > > This patchset is based on NVidia's "Add Mediated device support" series, > > > version 6: > > > > > > ht

Re: [Qemu-devel] [PATCH 0/4] lsi: misc fixes

2016-08-18 Thread Paolo Bonzini
On 18/08/2016 09:31, Hervé Poussineau wrote: > Hi, > > This patchset are some miscellaneous changes I did on LSI SCSI adapter: > - patch 1: some debugging help (register names) > - patch 2: removed one triggerable guest QEMU exit > - patch 3: compatibility with stock Windows 98 driver > - patch

Re: [Qemu-devel] [RFC PATCH v2 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-18 Thread Paolo Bonzini
On 18/08/2016 09:56, Vijay Kilari wrote: > The get_aarch_cpu_id() has check " if (unlikely(!cpu_info_read)) ". > If we call get_aarch_cpu_id() from is_thunderx_pass2_cpu() which is > called from inside the loop, we will be adding one additional check. On the other hand, you are making an assumpt

Re: [Qemu-devel] [RFC PATCH v2 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-18 Thread Vijay Kilari
On Thu, Aug 18, 2016 at 2:20 PM, Paolo Bonzini wrote: > > > On 18/08/2016 09:56, Vijay Kilari wrote: >> The get_aarch_cpu_id() has check " if (unlikely(!cpu_info_read)) ". >> If we call get_aarch_cpu_id() from is_thunderx_pass2_cpu() which is >> called from inside the loop, we will be adding one a

Re: [Qemu-devel] [PATCH v2] hw/vfio/platform: Add Qualcomm Technologies, Inc HIDMA device support

2016-08-18 Thread Auger Eric
Hi Shanker, Adding Alex in CC for (*) On 14/08/2016 17:42, Shanker Donthineni wrote: > This patch introduces the Qualcomm Technologies, Inc HIDMA device and > allows passthrough the host HIDMA device to a guest machine using the > vfio-platform framework. > > A platform device tree node is creat

Re: [Qemu-devel] [RFC PATCH v2 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-18 Thread Paolo Bonzini
On 18/08/2016 11:01, Vijay Kilari wrote: > On Thu, Aug 18, 2016 at 2:20 PM, Paolo Bonzini wrote: >> >> >> On 18/08/2016 09:56, Vijay Kilari wrote: >>> The get_aarch_cpu_id() has check " if (unlikely(!cpu_info_read)) ". >>> If we call get_aarch_cpu_id() from is_thunderx_pass2_cpu() which is >>> c

[Qemu-devel] nvml test failures with QEMU nvdimm device

2016-08-18 Thread Stefan Hajnoczi
Hi, Several nvml test suite failures were found with QEMU's nvdimm device. They don't look immediately obvious to me so I'm posting them for discussion. The majority of tests are passing. The failure logs are below. Full details: https://bugzilla.redhat.com/show_bug.cgi?id=1365721 Stefan --- #

[Qemu-devel] [PATCH] atapi: allow 0 transfer bytes for read_cd command

2016-08-18 Thread Hervé Poussineau
This fixes Windows NT4 startup when a cdrom is inserted. Fixes: 9ef2e93f9b1888c7d0deb4a105149138e6ad2e98 Signed-off-by: Hervé Poussineau --- hw/ide/atapi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 6189675..63312f2 100644 --- a/hw/i

Re: [Qemu-devel] [PATCH 0/6] hypertrace: Lightweight guest-to-QEMU trace channel

2016-08-18 Thread Stefan Hajnoczi
On Fri, Aug 05, 2016 at 06:59:23PM +0200, Lluís Vilanova wrote: > The hypertrace channel allows guest code to emit events in QEMU (the host) > using > its tracing infrastructure (see "docs/trace.txt"). This works in both 'system' > and 'user' modes. That is, hypertrace is to tracing, what hypercal

Re: [Qemu-devel] [PATCH 5/7] nios2: Add periodic timer emulation

2016-08-18 Thread Dmitry Osipenko
On 17.08.2016 23:19, Marek Vasut wrote: > On 08/16/2016 11:38 PM, Dmitry Osipenko wrote: > > [...] > > Well what is sane clock frequency for hardware which can have arbitrary > frequency configured in ? > You could set to the one that is used by "10M50 GHRD" patch for exampl

Re: [Qemu-devel] [PATCH] atapi: allow 0 transfer bytes for read_cd command

2016-08-18 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 1471513714-11709-1-git-send-email-hpous...@reactos.org Subject: [Qemu-devel] [PATCH] atapi: allow 0 transfer bytes for read_cd command Type: series === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PULL 0/1] Fix 'make docker-test-mingw@fedora'

2016-08-18 Thread Peter Maydell
On 17 August 2016 at 13:15, Fam Zheng wrote: > The following changes since commit 5f0e775348082c355769a3df612e055abea61c06: > > Update version for v2.7.0-rc3 release (2016-08-16 17:34:30 +0100) > > are available in the git repository at: > > g...@github.com:famz/qemu tags/docker-pull-request >

[Qemu-devel] 答复: Re: [PATCH] object: Add 'help' option to print all available object backend types

2016-08-18 Thread Lin Ma
>>> Markus Armbruster 2016/8/17 星期三 下午 2:48 >>> >Lin Ma writes: > >> Signed-off-by: Lin Ma >> --- >> qemu-options.hx | 5 - >> qom/object_interfaces.c | 16 >> 2 files changed, 20 insertions(+), 1 deletion(-) >> >> diff --git a/qemu-options.hx b/qemu-options.hx >>

Re: [Qemu-devel] [PATCH] qemu_opt_foreach: Fix crasher

2016-08-18 Thread Peter Maydell
On 17 August 2016 at 08:35, Marc-André Lureau wrote: > fwiw, this crash can be reproduced with 2.5: it's not a regression. Imho, it > shouldn't prevent or delay 2.7. Thanks for checking. OK, let's not try to squeeze a fix into 2.7; better to investigate more carefully and try to line up our QemuO

Re: [Qemu-devel] [PATCH 2/6] hypertrace: Add tracing event "guest_hypertrace"

2016-08-18 Thread Stefan Hajnoczi
On Fri, Aug 05, 2016 at 06:59:34PM +0200, Lluís Vilanova wrote: > +# hypertrace > +hyperargs=$hypertrace > +if test $hypertrace = "disabled"; then > +hyperargs=0 > +fi > +echo "CONFIG_HYPERTRACE_ARGS=$hyperargs" >> $config_host_mak > +hypertrace_events=hypertrace/trace-events > +mkdir -p $(dirn

[Qemu-devel] [PATCH v1 1/1] qapi/block-core: add doc describing GlusterServer vs. SocketAddress

2016-08-18 Thread Prasanna Kumar Kalever
Added documentation describing relation between GlusterServer and SocketAddress qapi schemas. Thanks to Markus Armbruster Signed-off-by: Prasanna Kumar Kalever --- qapi/block-core.json | 9 + 1 file changed, 9 insertions(+) diff --git a/qapi/block-core.json b/qapi/block-core.json inde

Re: [Qemu-devel] [RFC PATCH] build-sys: add make 'help' target

2016-08-18 Thread Paolo Bonzini
On 20/06/2016 17:19, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Add a make 'help', to print a summary of the main Makefile targets. > The format is loosely inspired by Linux make 'help' output. > > Signed-off-by: Marc-André Lureau > --- > Makefile | 33 +

Re: [Qemu-devel] 答复: Re: [PATCH] object: Add 'help' option to print all available object backend types

2016-08-18 Thread Andreas Färber
Am 18.08.2016 um 11:57 schrieb Lin Ma: Markus Armbruster 2016/8/17 星期三 下午 2:48 >>> >>Lin Ma writes: >> >>> Signed-off-by: Lin Ma >>> --- >>> qemu-options.hx | 5 - >>> qom/object_interfaces.c | 16 >>> 2 files changed, 20 insertions(+), 1 deletion(-) >>> >>> d

Re: [Qemu-devel] [PATCH 3/6] hypertrace: [*-user] Add QEMU-side proxy to "guest_hypertrace" event

2016-08-18 Thread Stefan Hajnoczi
On Fri, Aug 05, 2016 at 06:59:39PM +0200, Lluís Vilanova wrote: > +static void init_channel(const char *base, const char *suffix, size_t size, > + char ** path, int *fd, uint64_t **addr) > +{ > +*path = g_malloc(strlen(base) + strlen(suffix) + 1); > +sprintf(*path, "

Re: [Qemu-devel] [FIX PATCH] spapr: Gracefully fail CPU thread unplug

2016-08-18 Thread Bharata B Rao
On Thu, Aug 18, 2016 at 10:57:04AM +1000, David Gibson wrote: > On Wed, Aug 17, 2016 at 07:31:38PM +0530, Bharata B Rao wrote: > > sPAPR supports only Core level CPU plug and unplug, but nothing > > prevents user from issuing a device_del on the underlying thread > > device by using its qom path di

Re: [Qemu-devel] [RFC PATCH] build-sys: add make 'help' target

2016-08-18 Thread Peter Maydell
On 20 June 2016 at 16:19, wrote: > From: Marc-André Lureau > > Add a make 'help', to print a summary of the main Makefile targets. > The format is loosely inspired by Linux make 'help' output. > > Signed-off-by: Marc-André Lureau > --- > Makefile | 33 + > 1 fil

Re: [Qemu-devel] [PATCH 0/6] hypertrace: Lightweight guest-to-QEMU trace channel

2016-08-18 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Fri, Aug 05, 2016 at 06:59:23PM +0200, Lluís Vilanova wrote: >> The hypertrace channel allows guest code to emit events in QEMU (the host) >> using >> its tracing infrastructure (see "docs/trace.txt"). This works in both >> 'system' >> and 'user' modes. That is, hype

Re: [Qemu-devel] [PULL 0/2] Net patches

2016-08-18 Thread Peter Maydell
On 18 August 2016 at 06:40, Jason Wang wrote: > The following changes since commit 5f0e775348082c355769a3df612e055abea61c06: > > Update version for v2.7.0-rc3 release (2016-08-16 17:34:30 +0100) > > are available in the git repository at: > > https://github.com/jasowang/qemu.git tags/net-pull-

Re: [Qemu-devel] [PATCH 2/6] hypertrace: Add tracing event "guest_hypertrace"

2016-08-18 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Fri, Aug 05, 2016 at 06:59:34PM +0200, Lluís Vilanova wrote: >> +# hypertrace >> +hyperargs=$hypertrace >> +if test $hypertrace = "disabled"; then >> +hyperargs=0 >> +fi >> +echo "CONFIG_HYPERTRACE_ARGS=$hyperargs" >> $config_host_mak >> +hypertrace_events=hypertra

Re: [Qemu-devel] [RFC PATCH] build-sys: add make 'help' target

2016-08-18 Thread Marc-André Lureau
Hi - Original Message - > On 20 June 2016 at 16:19, wrote: > > From: Marc-André Lureau > > > > Add a make 'help', to print a summary of the main Makefile targets. > > The format is loosely inspired by Linux make 'help' output. > > > > Signed-off-by: Marc-André Lureau > > --- > > Makef

Re: [Qemu-devel] QEMU TCG issue when executing UEFI

2016-08-18 Thread Peter Maydell
On 16 August 2016 at 13:08, Ard Biesheuvel wrote: > I am hitting this strange issue when executing the UEFI firmware for > QEMU mach-virt/AArch64. This only occurs when building the firmware > with GCC5 in RELEASE mode, but the failure mode suggests that this may > not be relevant. Yeah, we shoul

Re: [Qemu-devel] QEMU TCG issue when executing UEFI

2016-08-18 Thread Ard Biesheuvel
On 18 August 2016 at 12:40, Peter Maydell wrote: > On 16 August 2016 at 13:08, Ard Biesheuvel wrote: >> I am hitting this strange issue when executing the UEFI firmware for >> QEMU mach-virt/AArch64. This only occurs when building the firmware >> with GCC5 in RELEASE mode, but the failure mode su

Re: [Qemu-devel] [PATCH 3/6] e1000e: fix for migration compatibility

2016-08-18 Thread Paolo Bonzini
On 17/08/2016 16:39, Cao jin wrote: > commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, but it > is used by intr_state which exists in vmstate. Restore it for migration > to older QEMU versions > > CC: Dmitry Fleytman > CC: Jason Wang > CC: Markus Armbruster > CC: Marcel Apfelba

Re: [Qemu-devel] [PATCH RFC] msix_init: input params *_offset isn't the real one

2016-08-18 Thread Marcel Apfelbaum
On 08/10/2016 06:18 AM, Cao jin wrote: The parameter table_offset & pba_offset is kind of confusing, they shouldn't include bir field. Signed-off-by: Cao jin --- Hi, According to the passed arguments, I guess all the callers of msix_init() has the same feeling with me, but I am not quite s

Re: [Qemu-devel] [PATCH 0/6] hypertrace: Lightweight guest-to-QEMU trace channel

2016-08-18 Thread Stefan Hajnoczi
On Fri, Aug 05, 2016 at 06:59:23PM +0200, Lluís Vilanova wrote: > The hypertrace channel allows guest code to emit events in QEMU (the host) > using > its tracing infrastructure (see "docs/trace.txt"). This works in both 'system' > and 'user' modes. That is, hypertrace is to tracing, what hypercal

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5 2/4] adb.c: add support for QKeyCode

2016-08-18 Thread BALATON Zoltan
Hello, Not a review just some style comments. On Wed, 17 Aug 2016, John Arbuckle wrote: static int adb_kbd_poll(ADBDevice *d, uint8_t *obuf) { -static int ext_keycode; KBDState *s = ADB_KEYBOARD(d); -int adb_keycode, keycode; +int keycode; int olen; olen = 0; -for(;

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5 4/4] adb.c: prevent NO_KEY value from going to guest

2016-08-18 Thread BALATON Zoltan
On Wed, 17 Aug 2016, John Arbuckle wrote: @@ -446,7 +438,10 @@ static void adb_keyboard_event(DeviceState *dev, QemuConsole *src, return; } keycode = qcode_to_adb_keycode[qcode]; - +if (keycode == NO_KEY) { /* We don't want to send this to the guest */ +ADB_DPRINTF("

[Qemu-devel] [PATCH v17 3/9] target-avr: adding a sample AVR board

2016-08-18 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- MAINTAINERS | 1 + hw/avr/Makefile.objs | 21 ++ hw/avr/sample.c | 112 +++ 3 files changed, 134 insertions(+) create mode 100644 hw/avr/Makefile.objs create mode 100644 hw/avr/sample.c d

[Qemu-devel] [PATCH v17 2/9] target-avr: adding AVR CPU features/flavors

2016-08-18 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/cpu.c | 311 +++ target-avr/cpu.h | 48 + 2 files changed, 359 insertions(+) diff --git a/target-avr/cpu.c b/target-avr/cpu.c index e99f804..d817266 100644 --- a/target-avr/cpu.c +++ b/targe

[Qemu-devel] [PATCH v17 5/9] target-avr: adding AVR interrupt handling

2016-08-18 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/helper.c | 55 + 1 file changed, 55 insertions(+) diff --git a/target-avr/helper.c b/target-avr/helper.c index b48222d..8511fb7 100644 --- a/target-avr/helper.c +++ b/target-avr/helper.c @@ -32,11 +3

[Qemu-devel] [PATCH v17 0/9] 8bit AVR cores

2016-08-18 Thread Michael Rolnik
This series of patches adds 8bit AVR cores to QEMU. All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested yet. However I was able to execute simple code with functions. e.g fibonacci calculation. This series of patches include a non real, sample board. No fuses support yet

Re: [Qemu-devel] Help: Does Qemu support virtio-pci for net-device and disk device?

2016-08-18 Thread Kevin Zhao
Hi Jones: Thanks~It is great that Qemu has been working on that :-) On 18 August 2016 at 00:13, Andrew Jones wrote: > On Wed, Aug 17, 2016 at 08:08:11PM +0800, Kevin Zhao wrote: > > Hi all, > > Now I'm investigating net device hot plug and disk hotplug for > > AArch64. For virtio , the d

[Qemu-devel] [PATCH v17 7/9] target-avr: adding instruction translation

2016-08-18 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/Makefile.objs|1 + target-avr/translate-inst.c | 2641 +++ target-avr/translate.h |1 + 3 files changed, 2643 insertions(+) create mode 100644 target-avr/translate-inst.c diff --git a/target-av

Re: [Qemu-devel] [PATCH v1 1/1] qapi/block-core: add doc describing GlusterServer vs. SocketAddress

2016-08-18 Thread Markus Armbruster
Prasanna Kumar Kalever writes: > Added documentation describing relation between GlusterServer and > SocketAddress qapi schemas. > > Thanks to Markus Armbruster > > Signed-off-by: Prasanna Kumar Kalever > --- > qapi/block-core.json | 9 + > 1 file changed, 9 insertions(+) > > diff --gi

Re: [Qemu-devel] nvml test failures with QEMU nvdimm device

2016-08-18 Thread Xiao Guangrong
Stefan, I am digging into it. On 08/18/2016 12:04 AM, Stefan Hajnoczi wrote: Hi, Several nvml test suite failures were found with QEMU's nvdimm device. They don't look immediately obvious to me so I'm posting them for discussion. The majority of tests are passing. The failure logs are below.

Re: [Qemu-devel] [PATCH v4 0/2] trace: Simplify late initialization

2016-08-18 Thread Stefan Hajnoczi
On Fri, Aug 12, 2016 at 05:33:35PM +0200, Lluís Vilanova wrote: > Removes the need for 'trace_events_dstate_init' and does a little cleanup in > how > state values are modified (to avoid implicit conversions from bool). > > Changes in v2 > = > > * Fix late-init state value [Daniel P.

[Qemu-devel] [PATCH v17 4/9] target-avr: adding instructions encodings

2016-08-18 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/translate-inst.h | 805 1 file changed, 805 insertions(+) create mode 100644 target-avr/translate-inst.h diff --git a/target-avr/translate-inst.h b/target-avr/translate-inst.h new file mode 100644 index 00

[Qemu-devel] [PATCH v17 8/9] target-avr: instruction decoder generator

2016-08-18 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/cpugen/CMakeLists.txt | 38 +++ target-avr/cpugen/README.md| 17 ++ target-avr/cpugen/cpu/avr.yaml | 214 ++ target-avr/cpugen/src/CMakeLists.txt | 63 target-avr/cpugen/src/cpugen.cpp

Re: [Qemu-devel] [PATCH for 2.7 0/2] block: fixes for deadlock in flush code

2016-08-18 Thread Stefan Hajnoczi
On Wed, Aug 17, 2016 at 09:06:52PM +0300, Denis V. Lunev wrote: > We have suffered from the following deadlock > > Thread 2 (Thread 0x7f1b7edf9700 (LWP 240293)): > #0 0x7f1bd1f0675f in ppoll () from /lib64/libc.so.6 > #1 0x7f1bd8c1d78b in ppoll (__ss=0x0, __timeout=0x0, __nfds= out>, __f

[Qemu-devel] [PATCH v17 6/9] target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported instructions

2016-08-18 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/cpu.h | 10 ++ target-avr/helper.c| 256 - target-avr/helper.h| 7 ++ target-avr/translate.c | 8 ++ 4 files changed, 277 insertions(+), 4 deletions(-) diff --git a/target-avr/cpu.h b/

Re: [Qemu-devel] Help: Does Qemu support virtio-pci for net-device and disk device?

2016-08-18 Thread Kevin Zhao
Hi Laine, Thanks :-) I also has a little questions below. On 18 August 2016 at 01:00, Laine Stump wrote: > On 08/17/2016 12:13 PM, Andrew Jones wrote: > >> On Wed, Aug 17, 2016 at 08:08:11PM +0800, Kevin Zhao wrote: >> >>> Hi all, >>> Now I'm investigating net device hot plug and disk

[Qemu-devel] [PATCH v17 9/9] target-avr: adding instruction decoder

2016-08-18 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/Makefile.objs | 1 + target-avr/decode.c | 693 +++ target-avr/translate.c | 2 + 3 files changed, 696 insertions(+) create mode 100644 target-avr/decode.c diff --git a/target-avr/Makefile.objs b

Re: [Qemu-devel] Help: Does Qemu support virtio-pci for net-device and disk device?

2016-08-18 Thread Marcel Apfelbaum
On 08/17/2016 08:00 PM, Laine Stump wrote: On 08/17/2016 12:13 PM, Andrew Jones wrote: On Wed, Aug 17, 2016 at 08:08:11PM +0800, Kevin Zhao wrote: Hi all, [...] Hi, 1) If we want to support both PCIe devices and PCI, then things are messy. Currently we propose dropping PCI support. mac

[Qemu-devel] [PATCH v17 1/9] target-avr: AVR cores support is added.

2016-08-18 Thread Michael Rolnik
1. basic CPU structure 2. registers 3. no instructions 4. saving sreg, rampD, rampX, rampY, rampD, eind in HW representation Signed-off-by: Michael Rolnik --- MAINTAINERS | 5 + arch_init.c | 2 + configure | 5 +

Re: [Qemu-devel] [PATCH v17 0/9] 8bit AVR cores

2016-08-18 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 1471522070-77598-1-git-send-email-mrol...@gmail.com Subject: [Qemu-devel] [PATCH v17 0/9] 8bit AVR cores Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] Help: Does Qemu support virtio-pci for net-device and disk device?

2016-08-18 Thread Kevin Zhao
Hi All, Thanks for your all kindly response. Really Great and helpful :-) On 18 August 2016 at 20:30, Kevin Zhao wrote: > Hi Jones: >Thanks~It is great that Qemu has been working on that :-) > > On 18 August 2016 at 00:13, Andrew Jones wrote: > >> On Wed, Aug 17, 2016 at 08:08:11PM +080

[Qemu-devel] errno 13, fopen qemu trace file.

2016-08-18 Thread Nir Levy
Hello everybody, I have a progress in tracing qemu, I add the thread and tag done for each kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl in purpose of investigating pure hypervisor activity and delays on host. the kvm type print only for convenience. for example: kvm_ioctl 3106435.230545 pid=11347 thre

Re: [Qemu-devel] [PATCH 3/6] e1000e: fix for migration compatibility

2016-08-18 Thread Cao jin
On 08/18/2016 06:47 PM, Paolo Bonzini wrote: On 17/08/2016 16:39, Cao jin wrote: commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, but it is used by intr_state which exists in vmstate. Restore it for migration to older QEMU versions CC: Dmitry Fleytman CC: Jason Wang CC: Mar

Re: [Qemu-devel] [PATCH 3/6] e1000e: fix for migration compatibility

2016-08-18 Thread Paolo Bonzini
On 18/08/2016 15:11, Cao jin wrote: > > > On 08/18/2016 06:47 PM, Paolo Bonzini wrote: >> >> >> On 17/08/2016 16:39, Cao jin wrote: >>> commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, but it >>> is used by intr_state which exists in vmstate. Restore it for migration >>> to older

Re: [Qemu-devel] [PATCH v4 0/2] trace: Simplify late initialization

2016-08-18 Thread Stefan Hajnoczi
On Fri, Aug 12, 2016 at 05:33:35PM +0200, Lluís Vilanova wrote: > Removes the need for 'trace_events_dstate_init' and does a little cleanup in > how > state values are modified (to avoid implicit conversions from bool). > > Changes in v2 > = > > * Fix late-init state value [Daniel P.

[Qemu-devel] [Bug 1614521] [NEW] -display accepts "none[a-z, 0-9]*" instead of 'none'

2016-08-18 Thread Kai Poeritz
Public bug reported: When using the '-display' option the parameter 'none' is not the only string that causes the behaviour of 'none'. I can use '-display noneMICKEYMOUSE' and still have the none behaviour. ** Affects: qemu Importance: Undecided Status: New -- You received this bu

Re: [Qemu-devel] errno 13, fopen qemu trace file.

2016-08-18 Thread Daniel P. Berrange
On Thu, Aug 18, 2016 at 12:58:29PM +, Nir Levy wrote: > Hello everybody, > > I have a progress in tracing qemu, > I add the thread and tag done for each kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl > in purpose of investigating pure hypervisor activity and delays on host. > the kvm type print only

Re: [Qemu-devel] [PATCH] test-logging: don't hard-code paths in /tmp

2016-08-18 Thread Peter Maydell
On 15 August 2016 at 19:24, Sascha Silbe wrote: > Dear Peter, > > Peter Maydell writes: > >> On 15 July 2016 at 17:24, Sascha Silbe wrote: > [...] >>> Instead of hard-coding the paths, create a temporary directory using >>> g_dir_make_tmp() and clean it up afterwards. >>> >>> Fixes: f6880b7f ("q

Re: [Qemu-devel] [PATCH 3/6] e1000e: fix for migration compatibility

2016-08-18 Thread Cao jin
On 08/18/2016 09:04 PM, Paolo Bonzini wrote: On 18/08/2016 15:11, Cao jin wrote: On 08/18/2016 06:47 PM, Paolo Bonzini wrote: On 17/08/2016 16:39, Cao jin wrote: commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, but it is used by intr_state which exists in vmstate. Restor

Re: [Qemu-devel] [PATCH 3/6] e1000e: fix for migration compatibility

2016-08-18 Thread Paolo Bonzini
On 18/08/2016 15:25, Cao jin wrote: > > > On 08/18/2016 09:04 PM, Paolo Bonzini wrote: >> >> >> On 18/08/2016 15:11, Cao jin wrote: >>> >>> >>> On 08/18/2016 06:47 PM, Paolo Bonzini wrote: On 17/08/2016 16:39, Cao jin wrote: > commit 66bf7d58 removed internal msi state flag E

Re: [Qemu-devel] errno 13, fopen qemu trace file.

2016-08-18 Thread Stefan Hajnoczi
On Thu, Aug 18, 2016 at 1:58 PM, Nir Levy wrote: > I have a progress in tracing qemu, > I add the thread and tag done for each kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl > in purpose of investigating pure hypervisor activity and delays on host. > the kvm type print only for convenience. > > for examp

[Qemu-devel] [PULL for-2.7 0/2] Block patches

2016-08-18 Thread Stefan Hajnoczi
The following changes since commit 5844365fe8e5e4598222d276d2af54fd45c7e3d3: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2016-08-18 10:56:41 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for

[Qemu-devel] [PULL for-2.7 1/2] block: fix deadlock in bdrv_co_flush

2016-08-18 Thread Stefan Hajnoczi
From: Evgeny Yakovlev The following commit commit 3ff2f67a7c24183fcbcfe1332e5223ac6f96438c Author: Evgeny Yakovlev Date: Mon Jul 18 22:39:52 2016 +0300 block: ignore flush requests when storage is clean has introduced a regression. There is a problem that it is still possible

[Qemu-devel] [PULL for-2.7 2/2] block: fix possible reorder of flush operations

2016-08-18 Thread Stefan Hajnoczi
From: "Denis V. Lunev" This patch reduce CPU usage of flush operations a bit. When we have one flush completed we should kick only next operation. We should not start all pending operations in the hope that they will go back to wait on wait_queue. Also there is a technical possibility that reque

Re: [Qemu-devel] errno 13, fopen qemu trace file.

2016-08-18 Thread Daniel P. Berrange
On Thu, Aug 18, 2016 at 01:31:19PM +, Nir Levy wrote: > Daniel, Thanks for your response. > > But I have succeeded using simpletrace when building libvirt from source file > into some/other/dir/install I can only assume you built libvirt so that qemu runs as root, instead of an unprivileged

Re: [Qemu-devel] [PATCH 0/6] hypertrace: Lightweight guest-to-QEMU trace channel

2016-08-18 Thread Luiz Capitulino
On Thu, 18 Aug 2016 11:54:24 +0100 Stefan Hajnoczi wrote: > On Fri, Aug 05, 2016 at 06:59:23PM +0200, Lluís Vilanova wrote: > > The hypertrace channel allows guest code to emit events in QEMU (the host) > > using > > its tracing infrastructure (see "docs/trace.txt"). This works in both > > 'sys

[Qemu-devel] [PATCH] slirp: fix segv when init failed

2016-08-18 Thread Marc-André Lureau
Since commit f6c2e66ae8c8a, slirp uses an exit notifier to call slirp_smb_cleanup. However, if init() failed, the notifier isn't added, and removing it will fail: ==18447== Invalid write of size 8 ==18447==at 0x7EF2B5: notifier_remove (notify.c:32) ==18447==by 0x48E80C: qemu_remove_exit_no

Re: [Qemu-devel] [PATCH v5 13/14] nbd: Implement NBD_CMD_WRITE_ZEROES on server

2016-08-18 Thread Vladimir Sementsov-Ogievskiy
On 19.07.2016 07:08, Eric Blake wrote: Upstream NBD protocol recently added the ability to efficiently write zeroes without having to send the zeroes over the wire, along with a flag to control whether the client wants a hole. Signed-off-by: Eric Blake --- v4: rebase, fix value for constant v3

Re: [Qemu-devel] Help: Does Qemu support virtio-pci for net-device and disk device?

2016-08-18 Thread Andrea Bolognani
On Thu, 2016-08-18 at 20:43 +0800, Kevin Zhao wrote: > What's the minimum version of  Qemu that support virito-1.0? > Does Qemu 2.6 works?  2.6 definitely has virtio 1.0 support, however libvirt does not yet allow you to control whether a device uses 0.9, 1.0 or both. The default for 2.6 should be

Re: [Qemu-devel] [Qemu-arm] [PATCH v2] hw/vfio/platform: Add Qualcomm Technologies, Inc HIDMA device support

2016-08-18 Thread Sinan Kaya
On 8/18/2016 5:37 AM, Auger Eric wrote: > Some general comments: > - I preferred the previous series organization where we had the creation > of the VFIO device first and its sysbus-fdt dynamic instantiation in a > separate patch. > > Peter requested sysbus-fdt stops growing and advised to split t

Re: [Qemu-devel] [PATCH v5 13/14] nbd: Implement NBD_CMD_WRITE_ZEROES on server

2016-08-18 Thread Paolo Bonzini
On 18/08/2016 15:50, Vladimir Sementsov-Ogievskiy wrote: > > from nbd proto.md: > > "Finally, it SHOULD return |EPERM| if it receives a write or trim > request on a read-only export." > > And EROFS is not mentioned in proto.md > > (however the same bug is in NBD_CMD_WRITE case.) system_errno

Re: [Qemu-devel] [PATCH 0/6] hypertrace: Lightweight guest-to-QEMU trace channel

2016-08-18 Thread Stefan Hajnoczi
On Thu, Aug 18, 2016 at 12:22:18PM +0200, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > On Fri, Aug 05, 2016 at 06:59:23PM +0200, Lluís Vilanova wrote: > >> The hypertrace channel allows guest code to emit events in QEMU (the host) > >> using > >> its tracing infrastructure (see "docs/tra

[Qemu-devel] hw/arm/virt: vmstate-static-checker.py results

2016-08-18 Thread Andrew Jones
Hi all, We've recently started versioning mach-virt, v2.6 was the first versioned release. As an effort to try and make sure we're doing things right, I tried the vmstate-static-checker.py script. I compared a 2.6 machine from a QEMU built from the v2.6.0 tag with a 2.6 machine from a QEMU built f

Re: [Qemu-devel] [RFC PATCH v2 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-18 Thread Richard Henderson
On 08/18/2016 02:39 AM, Paolo Bonzini wrote: On 18/08/2016 11:01, Vijay Kilari wrote: On Thu, Aug 18, 2016 at 2:20 PM, Paolo Bonzini wrote: On 18/08/2016 09:56, Vijay Kilari wrote: The get_aarch_cpu_id() has check " if (unlikely(!cpu_info_read)) ". If we call get_aarch_cpu_id() from is_th

Re: [Qemu-devel] hw/arm/virt: vmstate-static-checker.py results

2016-08-18 Thread Andrew Jones
On Thu, Aug 18, 2016 at 04:00:14PM +0200, Andrew Jones wrote: > Hi all, > > We've recently started versioning mach-virt, v2.6 was the first versioned > release. As an effort to try and make sure we're doing things right, I > tried the vmstate-static-checker.py script. I compared a 2.6 machine > fr

[Qemu-devel] [PATCH] e1000e: remove internal interrupt flag

2016-08-18 Thread Cao jin
Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, E1000E_USE_MSIX is not necessary too, remove it now. And interrupt flag field intr_state also can be removed now. CC: Dmitry Fleytman CC: Jason Wang CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin CC: Paolo Bonz

Re: [Qemu-devel] [PULL for-2.7 0/2] Block patches

2016-08-18 Thread Peter Maydell
On 18 August 2016 at 14:39, Stefan Hajnoczi wrote: > The following changes since commit 5844365fe8e5e4598222d276d2af54fd45c7e3d3: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into > staging (2016-08-18 10:56:41 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] QEMU TCG issue when executing UEFI

2016-08-18 Thread Ard Biesheuvel
On 18 August 2016 at 16:10, Peter Maydell wrote: > On 16 August 2016 at 13:08, Ard Biesheuvel wrote: >> Bad ram pointer 0x54 >> Aborted (core dumped) > > So the reason this happens is that get_page_addr_code() doesn't > correctly handle the case of the memory region being a > ROM that's not in RO

Re: [Qemu-devel] [RFC PATCH v2 1/2] utils: Add helper to read arm MIDR_EL1 register

2016-08-18 Thread Peter Maydell
On 18 August 2016 at 15:04, Richard Henderson wrote: > or (2) ifunc While we're on the subject, can somebody explain to me why we use ifuncs at all? I couldn't work out why it would be better than just using a straightforward function pointer -- when I tried single stepping through things the ifu

Re: [Qemu-devel] [PATCH 0/6] hypertrace: Lightweight guest-to-QEMU trace channel

2016-08-18 Thread Luiz Capitulino
On Thu, 18 Aug 2016 14:53:27 +0100 Stefan Hajnoczi wrote: > On Thu, Aug 18, 2016 at 12:22:18PM +0200, Lluís Vilanova wrote: > > Stefan Hajnoczi writes: > > > > > On Fri, Aug 05, 2016 at 06:59:23PM +0200, Lluís Vilanova wrote: > > >> The hypertrace channel allows guest code to emit events in

Re: [Qemu-devel] [Qemu-block] [PATCH] atapi: allow 0 transfer bytes for read_cd command

2016-08-18 Thread Kevin Wolf
Am 18.08.2016 um 11:48 hat Hervé Poussineau geschrieben: > This fixes Windows NT4 startup when a cdrom is inserted. > > Fixes: 9ef2e93f9b1888c7d0deb4a105149138e6ad2e98 > Signed-off-by: Hervé Poussineau Hm, which of the paths in cmd_read_cd() does this hit? Is it the one that directly calls ide_a

Re: [Qemu-devel] hw/arm/virt: vmstate-static-checker.py results

2016-08-18 Thread Peter Maydell
On 18 August 2016 at 15:00, Andrew Jones wrote: > We've recently started versioning mach-virt, v2.6 was the first versioned > release. As an effort to try and make sure we're doing things right, I > tried the vmstate-static-checker.py script. I compared a 2.6 machine > from a QEMU built from the v

Re: [Qemu-devel] QEMU TCG issue when executing UEFI

2016-08-18 Thread Peter Maydell
On 16 August 2016 at 13:08, Ard Biesheuvel wrote: > Bad ram pointer 0x54 > Aborted (core dumped) So the reason this happens is that get_page_addr_code() doesn't correctly handle the case of the memory region being a ROM that's not in ROMD mode. That is, the flash memory can be either in "reads ma

  1   2   >