Hi On Thu, Aug 18, 2016 at 10:50 AM Markus Armbruster <arm...@redhat.com> wrote:
> Marc-André Lureau <marcandre.lur...@gmail.com> writes: > > > Hi > > > > On Wed, Aug 17, 2016 at 6:49 PM Markus Armbruster <arm...@redhat.com> > wrote: > > > >> marcandre.lur...@redhat.com writes: > >> > >> > From: Marc-André Lureau <marcandre.lur...@redhat.com> > >> > > >> > The generated marshal functions do not visit arguments from commands > >> > that take no arguments. Thus they fail to catch invalid > >> > members. Visit the arguments, if provided, to throw an error in case > of > >> > invalid members. > >> > > >> > Currently, qmp_check_client_args() checks for invalid arguments and > >> > correctly catches this case. When switching to qmp_dispatch() we want > to > >> > keep that behaviour. The commands using 'O' may have arbitrary > >> > arguments, and must have 'gen': false in the qapi schema to skip the > >> > generated checks. > >> > >> Explains why this isn't a bug fix for QMP. What about QGA? > >> > > > > Sorry, I don't understand what you ask. I thought the above paragraph > that > > I added described the current QMP behaviour and why we want to keep it. > And > > yes, it'a fix for qga too (it's qapi) > > If it *is* a fix for QGA (have you tested it?), the commit message needs > to mention the fact more prominently. I'll make a suggestion on v5 of > this patch. > I added a test for QGA (to be added in v6): https://github.com/elmarco/qemu/commit/a6912f43dcd06f558c0c88a5321fcbd8a507b5bc > > [...] > -- Marc-André Lureau
