Hi all,
We've recently started versioning mach-virt, v2.6 was the first versioned
release. As an effort to try and make sure we're doing things right, I
tried the vmstate-static-checker.py script. I compared a 2.6 machine
from a QEMU built from the v2.6.0 tag with a 2.6 machine from a QEMU
built from today's latest pull (5844365fe8). I see lots of errors. I have
no experience in this area, so I can't even state whether they're truly
a concern or not. I can say a few things;
1) Most of the errors look like the same problem. Something is wrong
with xilinx_spi state, which shows up everywhere. Here's an example
Section "en25q64", Description "xilinx_spi": expected field "nonvolatile_cfg",
got "cur_addr"; skipping rest
2) Several of the remaining problems are also present on a check of the
x86_64 pc-i440fx-2.6 machine type. To be precise
Section "am53c974", Description "esp": expected field "cmdlen", got "cmdbuf";
skipping rest
Section "dc390", Description "esp": expected field "cmdlen", got "cmdbuf";
skipping rest
Section "e1000-82544gc", Description "e1000": expected field "tx.ipcss", got
"tx.props.ipcss"; skipping rest
Section "e1000-82545em", Description "e1000": expected field "tx.ipcss", got
"tx.props.ipcss"; skipping rest
Section "e1000", Description "e1000": expected field "tx.ipcss", got
"tx.props.ipcss"; skipping rest
Section "esp", Description "esp": expected field "cmdlen", got "cmdbuf";
skipping rest
Section "rtl8139", Description "rtl8139": expected field "tally_counters", got
"tally_counters.TxOk"; skipping rest
x86 only has three additional messages, which look harmless to me
Section "apic-common" does not exist in dest
Section "apic" does not exist in dest
Section "kvm-apic" does not exist in dest
3) I analyzed one error I saw, and see it should be fine, as the device
simply went from unmigratable to migratable (for TCG anyway)
Section "arm-gicv3-common" Section "arm-gicv3-common" Description "arm_gicv3":
minimum version error: 0 < 1
Any help with this would be appreciated. I probably won't be looking into
it myself, at least not any time soon. So, IOW, this mail is really just a
bug report, not a progress report :-)
Steps I did and full output attached.
Thanks,
drew
