On 18/08/2016 15:25, Cao jin wrote: > > > On 08/18/2016 09:04 PM, Paolo Bonzini wrote: >> >> >> On 18/08/2016 15:11, Cao jin wrote: >>> >>> >>> On 08/18/2016 06:47 PM, Paolo Bonzini wrote: >>>> >>>> >>>> On 17/08/2016 16:39, Cao jin wrote: >>>>> commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, but it >>>>> is used by intr_state which exists in vmstate. Restore it for >>>>> migration >>>>> to older QEMU versions >>>>> >>>>> CC: Dmitry Fleytman <dmi...@daynix.com> >>>>> CC: Jason Wang <jasow...@redhat.com> >>>>> CC: Markus Armbruster <arm...@redhat.com> >>>>> CC: Marcel Apfelbaum <mar...@redhat.com> >>>>> CC: Michael S. Tsirkin <m...@redhat.com> >>>>> Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> >>>> >>>> Not necessary. No released version of QEMU had e1000e and lacked >>>> commit >>>> 66bf7d58. >>>> >>>> Paolo >>>> >>> >>> Ok, then I will make this patch as separated one and send it out asap, >>> so maybe it goes in 2.7 >> >> It's not necessary at all; why would it be useful in 2.7? >> >> Paolo >> > > commit 66bf7d58I already removed E1000E_USE_MSI, so I think maybe I can > send a patch to remove E1000E_USE_MSIX & intr_state, so there will be no > migration compatibility issue
Please do, worst case it won't be accepted. Paolo
