On 2016年08月05日 17:02, Cornelia Huck wrote:
On Thu, 4 Aug 2016 22:52:29 +0300
"Michael S. Tsirkin" wrote:
On Thu, Aug 04, 2016 at 09:35:15AM +0200, Cornelia Huck wrote:
On Thu, 4 Aug 2016 02:16:14 +0300
"Michael S. Tsirkin" wrote:
This allows increasing the rx queue size up to 1024: unlik
The original issue turned out to be trivial. The dot and dot-dot entries
need to be the two very first entries in a non-root directory table;
however, readdir() does not guarantee that "." and ".." will be the
first items returned. When I patched read_directory() to generate "."
and ".." entries fi
> Paolo Bonzini writes:
>
> > This only leaves a warning-level message for extra-long lines, which
> > are relatively common and cause patchew to send email that will likely
> > be ignored.
> >
> > Signed-off-by: Paolo Bonzini
>
> Are we ready to give up on illegibly long lines?
We have other
On Tue, 9 Aug 2016 12:14:14 -0400 (EDT)
Paolo Bonzini wrote:
>
>
> - Original Message -
> > From: "Radim Krčmář"
> > To: no-re...@ec2-52-6-146-230.compute-1.amazonaws.com
> > Cc: f...@redhat.com, ehabk...@redhat.com, m...@redhat.com,
> > qemu-devel@nongnu.org, pet...@redhat.com, "jan
On Wed, Aug 10, 2016 at 09:30:52AM +0300, David Kiarie wrote:
> On Wed, Aug 10, 2016 at 8:49 AM, Peter Xu wrote:
>
> > On Tue, Aug 09, 2016 at 05:32:17PM +0300, David Kiarie wrote:
> >
> > [...]
> >
> > > @@ -2252,14 +2250,17 @@ static MemTxResult vtd_mem_ir_write(void
> > *opaque, hwaddr addr,
>
Jeff Cody writes:
> On Tue, Aug 09, 2016 at 02:20:09PM +0530, Prasanna Kumar Kalever wrote:
>> using atoi() for converting string to int may be error prone in case if
>> string supplied in the argument is not a fold of numerical number,
>>
>> This is not a bug because in the existing code,
>>
>
> On Tue, 08/09 17:21, Paolo Bonzini wrote:
> > On 05/08/2016 11:04, Fam Zheng wrote:
> > > We don't have .git in the docker checkout, add this to enable -Werror
> > > explicitly.
> > >
> > > Signed-off-by: Fam Zheng
> > > Message-id: 1469453510-658-1-git-send-email-f...@redhat.com
> > > ---
> >
On 08/10/2016 04:10 AM, Fam Zheng wrote:
> On Tue, 08/09 17:47, Paolo Bonzini wrote:
>> My proposal after having watched patchew complain for a couple days
>> about patches being sent on the list.
>
> Looks good to me, I think patchew will just work as you want (be silent with
> long line warnings
On Wed, Aug 10, 2016 at 09:35:25AM +0300, David Kiarie wrote:
> On Wed, Aug 10, 2016 at 8:41 AM, Peter Xu wrote:
>
> > On Tue, Aug 09, 2016 at 05:32:16PM +0300, David Kiarie wrote:
> > > When using IOMMU platform devices like IOAPIC are required to make
> > > interrupt remapping requests using ex
On Wed, 10 Aug 2016 08:46:07 +0200
Markus Armbruster wrote:
> I'm afraid "if not then tabs are allowed" is confusing. We're obviously
> skipping more than just the tabs check: RCS/CVS revision markers, and a
> whole bunch of C style checks. Makes sense, we don't want to do these
> checks for im
Prasanna Kumar Kalever writes:
> After introduction of qapi schema in gluster block driver code, the port
> type is now string as per InetSocketAddress
>
> { 'struct': 'InetSocketAddress',
> 'data': {
> 'host': 'str',
> 'port': 'str',
> '*to': 'uint16',
> '*ipv4': 'bool',
>
On Tue, 9 Aug 2016 17:47:43 +0200
Paolo Bonzini wrote:
> This only leaves a warning-level message for extra-long lines, which
> are relatively common and cause patchew to send email that will likely
> be ignored.
>
> Signed-off-by: Paolo Bonzini
> ---
> scripts/checkpatch.pl | 66
> +
Paolo Bonzini writes:
>> Paolo Bonzini writes:
>>
>> > This only leaves a warning-level message for extra-long lines, which
>> > are relatively common and cause patchew to send email that will likely
>> > be ignored.
>> >
>> > Signed-off-by: Paolo Bonzini
>>
>> Are we ready to give up on ille
On Wed, 08/10 03:09, Paolo Bonzini wrote:
>
> > On Tue, 08/09 17:21, Paolo Bonzini wrote:
> > > On 05/08/2016 11:04, Fam Zheng wrote:
> > > > We don't have .git in the docker checkout, add this to enable -Werror
> > > > explicitly.
> > > >
> > > > Signed-off-by: Fam Zheng
> > > > Message-id: 146
On Wed, 10 Aug 2016 03:08:33 -0400 (EDT)
Paolo Bonzini wrote:
> > Paolo Bonzini writes:
> >
> > > This only leaves a warning-level message for extra-long lines, which
> > > are relatively common and cause patchew to send email that will likely
> > > be ignored.
> > >
> > > Signed-off-by: Paolo
On Tue, 9 Aug 2016 17:47:41 +0200
Paolo Bonzini wrote:
> My proposal after having watched patchew complain for a couple days
> about patches being sent on the list.
>
> Paolo
>
> Paolo Bonzini (3):
> checkpatch: tweak the files in which TABs are checked
> checkpatch: bump most warnings to
- Original Message -
> From: "Cornelia Huck"
> To: "Paolo Bonzini"
> Cc: qemu-devel@nongnu.org, th...@redhat.com, f...@redhat.com,
> arm...@redhat.com
> Sent: Wednesday, August 10, 2016 9:46:14 AM
> Subject: Re: [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to errors
>
> On
- Original Message -
> From: "Markus Armbruster"
> To: "Paolo Bonzini"
> Cc: th...@redhat.com, f...@redhat.com, qemu-devel@nongnu.org
> Sent: Wednesday, August 10, 2016 9:48:24 AM
> Subject: Re: [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to errors
>
> Paolo Bonzini writes
On Wed, Aug 10, 2016 at 09:41:40AM +0800, Fam Zheng wrote:
> On Tue, 08/09 18:11, Daniel P. Berrange wrote:
> >
> > Can we get this report to include details of the
> >
> > a) the software versions of gcc, binutils, and any -devel packages
> > we're building against
> >
> > b) the exact
Hi~ paolo~~
Just a ping...
Have any comments for this patch?
Thanks
Zhang Chen
On 08/04/2016 04:49 PM, Zhang Chen wrote:
Add qemu_chr_add_handlers_full() API, we can use
this API pass in a GMainContext,make handler run
in the context rather than main_loop.
This comments from Daniel P . Berr
On Wed, 08/10 09:06, Daniel P. Berrange wrote:
> On Wed, Aug 10, 2016 at 09:41:40AM +0800, Fam Zheng wrote:
> > On Tue, 08/09 18:11, Daniel P. Berrange wrote:
> > >
> > > Can we get this report to include details of the
> > >
> > > a) the software versions of gcc, binutils, and any -devel packa
Line lengths above 80 characters do exist. They are rare, but
they happen from time to time. An ignored rule is worse than an
exception to the rule, so do the latter.
Some on the list expressed their preference for a soft limit that
is slightly lower than 80 characters, to account for extra char
Include Python and shell scripts, and make an exception for Perl
scripts we imported from Linux or elsewhere.
Signed-off-by: Paolo Bonzini
---
scripts/checkpatch.pl | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 8d
My proposal after having watched patchew complain for a couple days
about patches being sent on the list; amended after observations
from reviewers.
v1->v2: perform more checks on all sources (patch 2)
revive patch to update line length rules (patch 3)
Paolo Bonzini (5):
checkpatch: twe
These should apply to all files, not just C/C++. Tweak the regular
expression to check for whole words, to avoid false positives on Perl
variables starting with "Id".
Signed-off-by: Paolo Bonzini
---
scripts/checkpatch.pl | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --
CHK-level checks have been removed from checkpatch or bumped to
errors, so there is no effect anymore for --strict/--subjective.
Furthermore, even most WARNs have been bumped to errors, with
WARN only reserved to things that patchew probably ought not
to complain about (and that maintainers probabl
On 08/09/2016 06:59 PM, Thomas Huth wrote:
> Hard-coding the CPU alias names in the spapr_cores[] array has
> two big disadvantages:
>
> 1) We register a real type with the CPU alias name in
>spapr_cpu_core_register_types() - this prevents us from registering
>a CPU family name in kvm_ppc_
On Wed, Aug 10, 2016 at 04:13:10PM +0800, Fam Zheng wrote:
> On Wed, 08/10 09:06, Daniel P. Berrange wrote:
> > On Wed, Aug 10, 2016 at 09:41:40AM +0800, Fam Zheng wrote:
> > > On Tue, 08/09 18:11, Daniel P. Berrange wrote:
> > > >
> > > > Can we get this report to include details of the
> > > >
This only leaves a warning-level message for the extra-long lines
soft limit. Everything else is bumped up.
In the future warnings can be added for checks that can have false
positives.
Signed-off-by: Paolo Bonzini
---
scripts/checkpatch.pl | 66 +---
On Tue, Aug 9, 2016 at 11:27 PM, David Kiarie
wrote:
> Hi all,
>
> This patchset adds basic AMD IOMMU emulation support to Qemu.
>
> Change since v14
>-MMIO register reading/write bug fix [Peter]
>-Endian-ness issue fix[Peter]
>-Bitfields layouts in IOMMU commands fix[Peter]
>
I seem
On Wed, 08/10 09:24, Daniel P. Berrange wrote:
> On Wed, Aug 10, 2016 at 04:13:10PM +0800, Fam Zheng wrote:
> > On Wed, 08/10 09:06, Daniel P. Berrange wrote:
> > > On Wed, Aug 10, 2016 at 09:41:40AM +0800, Fam Zheng wrote:
> > > > On Tue, 08/09 18:11, Daniel P. Berrange wrote:
> > > > >
> > > > >
On Wed, Aug 10, 2016 at 04:39:21PM +0800, Fam Zheng wrote:
> On Wed, 08/10 09:24, Daniel P. Berrange wrote:
> > On Wed, Aug 10, 2016 at 04:13:10PM +0800, Fam Zheng wrote:
> > > On Wed, 08/10 09:06, Daniel P. Berrange wrote:
> > > > On Wed, Aug 10, 2016 at 09:41:40AM +0800, Fam Zheng wrote:
> > > >
On Tue, 9 Aug 2016 21:35:04 +0800
Peter Xu wrote:
> On Tue, Aug 09, 2016 at 10:28:41AM +0200, Igor Mammedov wrote:
> > On Mon, 8 Aug 2016 16:57:14 +0800
> > Peter Xu wrote:
> >
> > > On Mon, Aug 08, 2016 at 03:41:23PM +0800, Chao Gao wrote:
> > > > HI, everyone.
> > > >
> > > > We have don
On Wed, 10 Aug 2016 10:22:46 +0200
Paolo Bonzini wrote:
> Include Python and shell scripts, and make an exception for Perl
> scripts we imported from Linux or elsewhere.
>
> Signed-off-by: Paolo Bonzini
> ---
> scripts/checkpatch.pl | 9 +
> 1 file changed, 5 insertions(+), 4 deletions
On Wed, 10 Aug 2016 10:22:48 +0200
Paolo Bonzini wrote:
> Line lengths above 80 characters do exist. They are rare, but
> they happen from time to time. An ignored rule is worse than an
> exception to the rule, so do the latter.
>
> Some on the list expressed their preference for a soft limit
Lai Jiangshan wrote:
Hi
First of all, I like a lot the patchset, but I would preffer to split it
to find "possible" bugs along the lines, especially in postcopy, but not only.
[very nice description of the patch]
Nothing to say about the QMP and shared memory detection, looks correct
to me.
>
Paolo Bonzini writes:
> My proposal after having watched patchew complain for a couple days
> about patches being sent on the list; amended after observations
> from reviewers.
>
> v1->v2: perform more checks on all sources (patch 2)
> revive patch to update line length rules (patch 3)
Ser
- Original Message -
> From: "Cornelia Huck"
> To: "Paolo Bonzini"
> Cc: qemu-devel@nongnu.org, th...@redhat.com, arm...@redhat.com,
> f...@redhat.com
> Sent: Wednesday, August 10, 2016 10:57:30 AM
> Subject: Re: [PATCH 1/5] checkpatch: tweak the files in which TABs are checked
>
> On
On Wed, 10 Aug 2016 05:02:53 -0400 (EDT)
Paolo Bonzini wrote:
> - Original Message -
> > From: "Cornelia Huck"
> > To: "Paolo Bonzini"
> > Cc: qemu-devel@nongnu.org, th...@redhat.com, arm...@redhat.com,
> > f...@redhat.com
> > Sent: Wednesday, August 10, 2016 10:57:30 AM
> > Subject: R
"Li, Liang Z" wrote:
>> On Wed, Aug 10, 2016 at 10:22 AM, Li, Liang Z wrote:
>> > Hi Jiangshan,
>> >
>> > Glad to see your patch. It's a simple implementation which could provide
>> very useful functions.
>> >
>> >> +static void migration_bitmap_init(unsigned long *bitmap) {
>> >> +RAMBlock *
Richard Henderson writes:
> On 08/08/2016 10:57 AM, Richard Henderson wrote:
>> On 08/07/2016 11:06 PM, Nikunj A Dadhania wrote:
>>> +#define LXV(name, access, swap, type, elems) \
>>> +uint64_t helper_##name(CPUPPCState *env, \
>>> +
On Di, 2016-08-09 at 16:55 +0100, Alex Bennée wrote:
> Hi,
>
> I'm proposing for the 2.8 cycle we officially drop supporting 64 bit
> guests on 32 bit hosts. For most of the KVM targets it doesn't make
> any sense anyway and for TCG it makes things harder (e.g. supporting
> 64 bit atomics on a 32
On 10.08.2016 10:22, Paolo Bonzini wrote:
> Line lengths above 80 characters do exist. They are rare, but
> they happen from time to time. An ignored rule is worse than an
> exception to the rule, so do the latter.
>
> Some on the list expressed their preference for a soft limit that
> is slight
On 10.08.2016 10:22, Paolo Bonzini wrote:
> This only leaves a warning-level message for the extra-long lines
> soft limit. Everything else is bumped up.
>
> In the future warnings can be added for checks that can have false
> positives.
>
> Signed-off-by: Paolo Bonzini
> ---
> scripts/checkpa
On Tue, Aug 09, 2016 at 09:15:20AM +0530, Gadre Nayan wrote:
> echo virtqueue_kick_prepare > /sys/kernel/debug/tracing/set_ftrace_filter
> echo virtqueue_kick >> /sys/kernel/debug/tracing/set_ftrace_filter
> echo scsi_kick_queue >> /sys/kernel/debug/tracing/set_ftrace_filter
> echo virtio_dev_match
On 08/10/2016 02:51 PM, Nikunj A Dadhania wrote:
I can fix the BE case using following but not sure if that will be
correct !
tcg_gen_qemu_ld_i64(xth, EA, ctx->mem_idx, MO_Q);
gen_helper_bswap32x2(xth, xth);
tcg_gen_addi_tl(EA, EA, 8);
tcg_gen_qemu_ld_i64(xtl, EA,
Marc-André Lureau writes:
> Hi
>
> On Tue, Aug 9, 2016 at 9:35 PM Markus Armbruster wrote:
>
>> Marc-André Lureau writes:
>>
>> > Hi
>> >
>> > - Original Message -
>> >> Marc-André Lureau writes:
>> >>
>> >> > Hi
>> >> >
>> >> > - Original Message -
>> >> >> marcandre.lur...@re
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 714a000..ab08ca2 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -1289,11 +1289,11 @@ sub process {
> > # This is a signoff, if ugly, so do not double report.
> >
On 10.08.2016 12:25, Paolo Bonzini wrote:
>
>>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>>> index 714a000..ab08ca2 100755
>>> --- a/scripts/checkpatch.pl
>>> +++ b/scripts/checkpatch.pl
>>> @@ -1289,11 +1289,11 @@ sub process {
>>> # This is a signoff, if ugl
On Tue, Aug 09, 2016 at 07:34:14PM +0200, Paulina Szubarczyk wrote:
> On 08/09/2016 06:56 PM, Anthony PERARD wrote:
> > On Tue, Aug 02, 2016 at 04:06:30PM +0200, Paulina Szubarczyk wrote:
> > > diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h
> > > index 640c31e..e80c61f 10064
On 07.08.2016 23:27, Marek Vasut wrote:
> On 07/30/2016 11:42 PM, Dmitry Osipenko wrote:
>> Hello Marek,
>
> Hi!
>
> Sorry for the late reply, I got back from vacation only recently.
>
> I noticed that a lot of files in this patchset are under LGPLv2.1 , I
> believe that needs fixing too, right
Richard Henderson writes:
> On 08/10/2016 02:51 PM, Nikunj A Dadhania wrote:
>> I can fix the BE case using following but not sure if that will be
>> correct !
>>
>> tcg_gen_qemu_ld_i64(xth, EA, ctx->mem_idx, MO_Q);
>> gen_helper_bswap32x2(xth, xth);
>> tcg_gen_addi_tl(EA,
On 08/10/2016 12:32 AM, Pranith Kumar wrote:
typedef struct float_status {
+int float_exception_flags;
signed char float_detect_tininess;
signed char float_rounding_mode;
-signed char float_exception_flags;
Given that there are no flags outside 8 bits, why is this sup
On 10 August 2016 at 11:32, Richard Henderson wrote:
> On 08/10/2016 12:32 AM, Pranith Kumar wrote:
>>
>> typedef struct float_status {
>> +int float_exception_flags;
>> signed char float_detect_tininess;
>> signed char float_rounding_mode;
>> -signed char float_exceptio
> >>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> >>> index 714a000..ab08ca2 100755
> >>> --- a/scripts/checkpatch.pl
> >>> +++ b/scripts/checkpatch.pl
> >>> @@ -1289,11 +1289,11 @@ sub process {
> >>> # This is a signoff, if ugly, so do not double report.
> >>>
On 10.08.2016 12:44, Paolo Bonzini wrote:
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 714a000..ab08ca2 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1289,11 +1289,11 @@ sub process {
> # This is a signoff,
On 08/09/2016 12:19 PM, Fam Zheng wrote:
+/* Version 4 UUID (pseudo random numbers), RFC4122 4.4. */
+
+typedef struct {
+unsigned char data[16];
+} QemuUUID;
...
+void qemu_uuid_generate(QemuUUID *uuid)
+{
+int i;
+uint32_t *out = (uint32_t *)&uuid->data[0];
You can't do this cas
The test case overwrites the Coroutine object with 0xff as a way to
assert that the coroutine isn't used any more. However, this means that
the coroutine pool now contains a corrupted object and later test cases
may get this corrupted object and crash.
This patch saves the real content of the obje
On Wed, Aug 10, 2016 at 04:43:12AM +0200, Reda Sallahi wrote:
> This patch adds a basic dd subcommand analogous to dd(1) to qemu-img.
>
> For the start, this implements the bs, if, of and count options and requires
> both if and of to be specified (no stdin/stdout if not specified) and doesn't
> s
On Mon, Aug 08, 2016 at 01:34:21PM +0200, Reda Sallahi wrote:
> @@ -4111,6 +4139,10 @@ static int img_dd(int argc, char **argv)
>
> in.buf = g_new(uint8_t, in.bsz);
>
> +if (dd.flags & C_SKIP) {
> +incount = in.offset * in.bsz;
> +}
Not worth changing unless there are othe
On Tue, Aug 09, 2016 at 01:20:19PM +0200, Kevin Wolf wrote:
> It is generally not expected that io_submit() fails other than with
> -EAGAIN, but corner cases like SELinux refusing I/O when permissions are
> revoked are still possible. In this case, we shouldn't abort, but just
> return an I/O error
On 10/08/2016 12:37, Peter Maydell wrote:
> On 10 August 2016 at 11:32, Richard Henderson wrote:
>> On 08/10/2016 12:32 AM, Pranith Kumar wrote:
>>>
>>> typedef struct float_status {
>>> +int float_exception_flags;
>>> signed char float_detect_tininess;
>>> signed char flo
On 2016-08-09 22:12, Peter Maydell wrote:
> On 9 August 2016 at 20:16, Aurelien Jarno wrote:
> > On 2016-08-09 15:02, Pranith Kumar wrote:
> >> Change the flag type to 'int' to fix the implicit conversion error.
> >>
> >> Suggested-by: Peter Maydell
> >> Signed-off-by: Pranith Kumar
> >> ---
> >
On 10.08.2016 13:30, Dmitry Osipenko wrote:
[snip]
> I suggest to provide "reset" function, otherwise it's likely that you would
> get
> unexpected result or crash on QEMU reset. This also applies to the "interrupt
> controller" patch.
>
Correction: I didn't notice that "interrupt controller"
On Wed, Aug 10, 2016 at 09:42:04AM +0200, Markus Armbruster wrote:
> Prasanna Kumar Kalever writes:
>
> > After introduction of qapi schema in gluster block driver code, the port
> > type is now string as per InetSocketAddress
> >
> > { 'struct': 'InetSocketAddress',
> > 'data': {
> > 'host
On Fri, 10 Jun 2016 07:26:52 -0700
Richard Henderson wrote:
This patch make SIGSEGVs QEMU when debugging KVM guest with gdb
Steps to reproduce:
Seabios:
clone and build current master with
defconfig plus CONFIG_RELOCATE_INIT=n on top of it
QEMU:
./configure --enable-debug --target-lis
Hi -
This is a bug report that includes a patch. My understanding of your
submission guidelines in that it should go to qemu-devel and not to the bug
tracker. Sorry if I didn't understand your procedures.
I'm running qemu-system-i386 built from the master branch from git://
git.qemu-project.org
Hello!
I ran into an issue where qemu (specifically, the unicorn engine)
would hang forever in the middle of the emulated square root
instruction under certain circumstances. I eventually tracked the
issue down to the square root of an "unnormal" long double, one
without the integer part bit set.
Am 08.08.2016 um 17:04 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Make getter signature const-correct. This allows other functions with
> const dirty bitmap parameter use bdrv_dirty_bitmap_granularity().
>
> Reviewed-by: Eric Blake
> Reviewed-by: John Snow
> Signed-off-by: Vladimir Sementso
Am 08.08.2016 um 17:04 hat Vladimir Sementsov-Ogievskiy geschrieben:
> If dirty bitmap was cleared during iterator life, we can went to zero
> current in hbitmap_iter_skip_words, starting from saved (and currently
> wrong hbi->cur[...]).
I was going to suggest improved grammar, but actually I find
Am 08.08.2016 um 17:04 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Add bdrv_dirty_bitmap_deserialize_ones() function, which is needed for
> qcow2 bitmap loading, to handle unallocated bitmap parts, marked as
> all-ones.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Kevin Wolf
Sergey Fedorov writes:
> On 03/06/16 23:40, Alex Bennée wrote:
>>
>
> From: Jan Kiszka
>
> (See http://thread.gmane.org/gmane.comp.emulators.qemu/402092/focus=403090)
>
>> This finally allows TCG to benefit from the iothread introduction: Drop
>> the global mutex while running pure TCG CPU code
2016-08-10 09:09+0200, Cornelia Huck:
> On Tue, 9 Aug 2016 12:14:14 -0400 (EDT)
> Paolo Bonzini wrote:
>> > Make scripts/checkpatch.pl accept tabs in linux-headers/, instead of
>> > changing scripts/update-linux-headers.sh to expand tabs when importing.
>> >
>> > Signed-off-by: Radim Krčmář
>> >
On Tue, Jul 19, 2016 at 12=59=36AM +0300, Michael S. Tsirkin wrote:
> On Thu, Jul 14, 2016 at 06:54:29PM +0200, Igor Mammedov wrote:
> > Changelog:
>
> So for pc and apic bits:
>
> Reviewed-by: Michael S. Tsirkin
>
> Since Eduardo picked up first part of this, feel free
> to merge the rest too.
Two fixes are needed. First, mingw does not have -D_FORTIFY_SOURCE,
hence --enable-debug disables optimization. This is not acceptable
for ROMs, which should override CFLAGS to force inclusion of -O2.
Second, PE stores global constructors and destructors using the
following linker script snippet
From: Marc-André Lureau
When calling make with a CFLAGS=.. argument, the -g/-O filter is not
applied, which may result with build failure with ASAN for example. It
could be solved with an 'override' directive on CFLAGS, but that would
actually prevent setting different CFLAGS manually.
Instead,
Jeff Cody writes:
> On Wed, Aug 10, 2016 at 09:42:04AM +0200, Markus Armbruster wrote:
>> Prasanna Kumar Kalever writes:
>>
>> > After introduction of qapi schema in gluster block driver code, the port
>> > type is now string as per InetSocketAddress
>> >
>> > { 'struct': 'InetSocketAddress',
>
With the latest clang, we have the following warning:
/home/pranith/devops/code/qemu/include/qemu/seqlock.h:62:21: warning:
passing 'typeof (*&sl->sequence) *' (aka 'const unsigned int *') to parameter
of type 'unsigned int *' discards qualifiers
[-Wincompatible-pointer-types-discards-quali
Recent GCC compiles linuxboot_dma.c to 921 bytes, while CentOS 6 needs
1029 and clang needs 1527. Because the size of the ROM, rounded to the
next 512 bytes, must match, this causes the API to break between a <1K
ROM and one that is bigger.
We want to make the ROM 1.5 KB in size, but it's better
The following changes since commit 2bb15bddf2607110820d5ce5aa43baac27292fb3:
Merge remote-tracking branch 'remotes/jnsnow/tags/ide-pull-request' into
staging (2016-08-09 16:53:32 +0100)
are available in the git repository at:
git://github.com/bonzini/qemu.git tags/for-upstream
for you to
From: Pranith Kumar
It seems like there's no good reason for the compiler to exploit the
undefinedness of left shifts. GCC explicitly documents that they do not
use at all this possibility and, while they also say this is subject
to change, they have been saying this for 10 years (since the word
Include Python and shell scripts, and make an exception for Perl
scripts we imported from Linux or elsewhere.
Acked-by: Cornelia Huck
Signed-off-by: Paolo Bonzini
---
scripts/checkpatch.pl | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/scripts/checkpatch.pl b/scrip
CHK-level checks have been removed from checkpatch or bumped to
errors, so there is no effect anymore for --strict/--subjective.
Furthermore, even most WARNs have been bumped to errors, with
WARN only reserved to things that patchew probably ought not
to complain about (and that maintainers probabl
This is required by OpenBSD.
Signed-off-by: Paolo Bonzini
---
pc-bios/optionrom/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/pc-bios/optionrom/Makefile b/pc-bios/optionrom/Makefile
index 6bab490..9c018ea 100644
--- a/pc-bios/optionrom/Makefile
+++ b/pc-bios/optionrom/Makefile
@@
On 2 August 2016 at 19:32, Michael S. Tsirkin wrote:
> I think this is adequately answered here:
> http://git.qemu.org/?p=qemu.git;a=blob;f=docs/specs/vhost-
> user.txt;hb=HEAD#l149
>
Thanks for the gentle nudge :). Indeed, it is working great with all QEMU
versions now. I see now why my patch i
From: Pranith Kumar
Clang produces the following warning. The warning is detailed here:
https://reviews.llvm.org/D15866. Fix the warning.
/home/pranith/devops/code/qemu/hw/display/qxl.c:507:5: warning: macro expansion
producing 'defined' has undefined behavior [-Wexpansion-to-defined]
^
/ho
From: Gonglei
(commit 80dcfb8532ae76343109a48f12ba8ca1c505c179)
Upon migration, the code use a timer based on vm_clock for 1ns
in the future from post_load to do the event send in case host_connected
differs between migration source and target.
However, it's not guaranteed that the apic is ready
From: Radim Krčmář
Linux uses tabs for indentation and checkpatch always complained about
automatically imported headers. update-linux-headers.sh could be modified to
expand tabs, but there is no real reason to complain about any ugly code in
Linux headers, so skip all hunk-related checks.
Sign
These should apply to all files, not just C/C++. Tweak the regular
expression to check for whole words, to avoid false positives on Perl
variables starting with "Id".
Signed-off-by: Paolo Bonzini
---
scripts/checkpatch.pl | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --
On 10.08.2016 16:41, Kevin Wolf wrote:
Am 08.08.2016 um 17:04 hat Vladimir Sementsov-Ogievskiy geschrieben:
If dirty bitmap was cleared during iterator life, we can went to zero
current in hbitmap_iter_skip_words, starting from saved (and currently
wrong hbi->cur[...]).
I was going to suggest i
This only leaves a warning-level message for the extra-long lines
soft limit. Everything else is bumped up.
In the future warnings can be added for checks that can have false
positives.
Reviewed-by: Markus Armbruster
Signed-off-by: Paolo Bonzini
---
scripts/checkpatch.pl | 66
Line lengths above 80 characters do exist. They are rare, but
they happen from time to time. An ignored rule is worse than an
exception to the rule, so do the latter.
Some on the list expressed their preference for a soft limit that
is slightly lower than 80 characters, to account for extra char
** Changed in: qemu
Assignee: (unassigned) => Dr. David Alan Gilbert (dgilbert-h)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1545052
Title:
RDMA migration will hang forever if target QEMU f
Daniel P Berrange writes:
[...]
> diff --git a/scripts/tracetool/format/events_c.py
> b/scripts/tracetool/format/events_c.py
> index 9203377..bab6404 100644
> --- a/scripts/tracetool/format/events_c.py
> +++ b/scripts/tracetool/format/events_c.py
> @@ -25,7 +25,10 @@ def generate(events, backend):
On Tue, 9 Aug 2016 19:38:41 +0200
Radim Krčmář wrote:
> Linux uses tabs for indentation and checkpatch always complained about
> automatically imported headers. update-linux-headers.sh could be modified to
> expand tabs, but there is no real reason to complain about any ugly code in
> Linux hea
On Wed, 10 Aug 2016 15:55:28 +0200
Radim Krčmář wrote:
> 2016-08-10 09:09+0200, Cornelia Huck:
> > On Tue, 9 Aug 2016 12:14:14 -0400 (EDT)
> > Paolo Bonzini wrote:
> >> > Make scripts/checkpatch.pl accept tabs in linux-headers/, instead of
> >> > changing scripts/update-linux-headers.sh to expan
This adds the skip option which allows qemu-img dd to skip a number of blocks
before copying the input.
A test case was added to test the skip option.
Signed-off-by: Reda Sallahi
---
Depends on:
[PATCH v9] qemu-img: add the 'dd' subcommand
Changes from v4:
* Rebase.
Changes from v3:
* Change wr
Daniel P Berrange writes:
> I previously split the global trace-events file up into one file
> per-subdirectory to avoid merge conflict hell.
> This series builds on that to now actually generate the individual
> trace files per-subdirectory too. The key benefit of doing this is
> that a change i
On Wed, 10 Aug 2016 15:56:24 +0200
Eduardo Otubo wrote:
> On Tue, Jul 19, 2016 at 12=59=36AM +0300, Michael S. Tsirkin wrote:
> > On Thu, Jul 14, 2016 at 06:54:29PM +0200, Igor Mammedov wrote:
> > > Changelog:
> >
> > So for pc and apic bits:
> >
> > Reviewed-by: Michael S. Tsirkin
> >
>
On Sun, Aug 07, 2016 at 07:01:01PM -0700, Ashish Mittal wrote:
> This patch adds support for a new block device type called "vxhs".
> Source code for the library that this code loads can be downloaded from:
> https://github.com/MittalAshish/libqnio.git
>
> Version 2 patch submission fixes the foll
1 - 100 of 241 matches
Mail list logo
