On Mon, Aug 08, 2016 at 01:34:21PM +0200, Reda Sallahi wrote:
> @@ -4111,6 +4139,10 @@ static int img_dd(int argc, char **argv)
>
> in.buf = g_new(uint8_t, in.bsz);
>
> + if (dd.flags & C_SKIP) {
> + incount = in.offset * in.bsz;
> + }Not worth changing unless there are other comments, but does this need to be conditional? If in.offset = 0 because C_SKIP was not specified then incount = 0, which is correct. Unconditional code is simpler. Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature
