Paolo Bonzini <pbonz...@redhat.com> writes: >> Paolo Bonzini <pbonz...@redhat.com> writes: >> >> > This only leaves a warning-level message for extra-long lines, which >> > are relatively common and cause patchew to send email that will likely >> > be ignored. >> > >> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> >> >> Are we ready to give up on illegibly long lines? > > We have other levels of code review than checkpatch. 80 chars can be > illegibly short in some circumstances where 83 or 84 are enough.
Isn't that addressed neatly in your patch? It has a soft and a hard limit. Exceeding the hard limit is an error, exceeding the soft limit is a warning. I rather liked that. If I remember correctly, the only disagreements were about the value of the soft limit. > Paolo > >> What happened to "[PATCH 2/4] CODING_STYLE, checkpatch: update line >> length rules"?