Re: [Qemu-devel] [PULL 04/16] Makefile: Rules for docker testing

2016-06-06 Thread Fam Zheng
On Fri, 06/03 15:26, Eduardo Habkost wrote: > On Fri, Jun 03, 2016 at 09:23:28AM +0800, Fam Zheng wrote: > > On Thu, 06/02 16:13, Eduardo Habkost wrote: > > > On Wed, Jun 01, 2016 at 05:45:12PM +0800, Fam Zheng wrote: > > > [...] > > > > + > > > > +CUR_TIME := $(shell date +%Y-%m-%d-%H.%M.%S.)

Re: [Qemu-devel] [RFC PATCH v3 3/3] VFIO Type1 IOMMU change: to support with iommu and without iommu

2016-06-06 Thread Dong Jia
On Fri, 20 May 2016 03:21:31 + "Tian, Kevin" wrote: > > From: Dong Jia [mailto:bjsdj...@linux.vnet.ibm.com] > > Sent: Thursday, May 19, 2016 3:28 PM > > > > On Fri, 13 May 2016 02:05:01 -0700 > > Neo Jia wrote: > > > > ...snip... > > > > > > > > Hi Dong, > > > > > > We should definitely b

[Qemu-devel] [PULL 2/5] hw/audio: QOM'ify cs4231.c

2016-06-06 Thread Gerd Hoffmann
From: xiaoqiang zhao Drop the old SysBus init function and use instance_init Reviewed-by: Paolo Bonzini Signed-off-by: xiaoqiang zhao Message-id: 1463111220-30335-2-git-send-email-zxq_yx_...@163.com Signed-off-by: Gerd Hoffmann --- hw/audio/cs4231.c | 12 +--- 1 file changed, 5 inser

[Qemu-devel] [PULL 5/5] hw/audio: QOM'ify milkymist-ac97.c

2016-06-06 Thread Gerd Hoffmann
From: xiaoqiang zhao * Drop the old SysBus init function and use instance_init * Move AUD_open_in / AUD_open_out function into realize stage Acked-by: Michael Walle Tested-by: Michael Walle Signed-off-by: xiaoqiang zhao Message-id: 1463111220-30335-5-git-send-email-zxq_yx_...@163.com Signed-o

[Qemu-devel] [PULL 0/5] audio patch queue

2016-06-06 Thread Gerd Hoffmann
motes/jasowang/tags/net-pull-request' into staging (2016-06-02 14:26:57 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-audio-20160606-1 for you to fetch changes up to 07b9098dfca4209ea1fca3cb26297164fcb4ae3c: hw/audio: QOM'ify milkymist-ac97.c (2016

[Qemu-devel] [PULL 3/5] hw/audio: QOM cleanup for intel-hda

2016-06-06 Thread Gerd Hoffmann
From: xiaoqiang zhao drop the DO_UPCAST macro Signed-off-by: xiaoqiang zhao Message-id: 1463111220-30335-3-git-send-email-zxq_yx_...@163.com Signed-off-by: Gerd Hoffmann --- hw/audio/intel-hda.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/audi

[Qemu-devel] [PULL 1/5] audio: pa: Set volume of recording stream instead of recording device

2016-06-06 Thread Gerd Hoffmann
From: Peter Krempa Since pulseaudio 1.0 it's possible to set the individual stream volume rather than setting the device volume. With this, setting hardware mixer of a emulated sound card doesn't mess up the volume configuration of the host. A side effect is that this limits compatible pulseaudi

[Qemu-devel] [PULL 3/6] vmsvga: add more fifo checks

2016-06-06 Thread Gerd Hoffmann
Make sure all fifo ptrs are within range. Fixes: CVE-2016-4454 Cc: qemu-sta...@nongnu.org Cc: P J P Reported-by: 李强 Signed-off-by: Gerd Hoffmann Message-id: 1464592161-18348-3-git-send-email-kra...@redhat.com --- hw/display/vmware_vga.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[Qemu-devel] [PULL 4/6] vmsvga: shadow fifo registers

2016-06-06 Thread Gerd Hoffmann
The fifo is normal ram. So kvm vcpu threads and qemu iothread can access the fifo in parallel without syncronization. Which in turn implies we can't use the fifo pointers in-place because the guest can try changing them underneath us. So add shadows for them, to make sure the guest can't modify

[Qemu-devel] [PULL 4/5] hw/audio: QOM'ify intel-hda

2016-06-06 Thread Gerd Hoffmann
From: xiaoqiang zhao * use DeviceClass::realize instead of DeviceClass::init Signed-off-by: xiaoqiang zhao Message-id: 1463111220-30335-4-git-send-email-zxq_yx_...@163.com Signed-off-by: Gerd Hoffmann --- hw/audio/intel-hda.c | 12 1 file changed, 8 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/3] ppc: complete the new HV mode

2016-06-06 Thread Benjamin Herrenschmidt
On Mon, 2016-06-06 at 07:29 +0100, Mark Cave-Ayland wrote: > > The best reproducer is to run from David's ppc-for-2.7 branch with > the above patch applied manually and then try booting the following > ISOs which now panic on boot with the split I/D MMU mode enabled: So at least HelenOS is fixed

[Qemu-devel] [PULL 1/6] virtio-gpu: fix scanout rectangles

2016-06-06 Thread Gerd Hoffmann
Commit "ca58b45 ui/virtio-gpu: add and use qemu_create_displaysurface_pixman" breaks scanouts which use a region of the underlying resource only. So, we need another way to handle the underlying issue. Lets create a new pixman image, grab a reference on the pixman providing the underlying storage

[Qemu-devel] [PULL v2 0/6] vga patch queue

2016-06-06 Thread Gerd Hoffmann
branch 'remotes/jasowang/tags/net-pull-request' into staging (2016-06-02 14:26:57 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-vga-20160606-1 for you to fetch changes up to 0c244e50ee12311037efd507ee37df0e846e4a18: virtio-gpu: add live migrati

[Qemu-devel] [PULL 5/6] vmsvga: don't process more than 1024 fifo commands at once

2016-06-06 Thread Gerd Hoffmann
vmsvga_fifo_run is called in regular intervals (on each display update) and will resume where it left off. So we can simply exit the loop, without having to worry about how processing will continue. Fixes: CVE-2016-4453 Cc: qemu-sta...@nongnu.org Cc: P J P Reported-by: 李强 Signed-off-by: Gerd Ho

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/3] ppc: complete the new HV mode

2016-06-06 Thread Benjamin Herrenschmidt
On Mon, 2016-06-06 at 17:04 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2016-06-06 at 07:29 +0100, Mark Cave-Ayland wrote: > > > > > > The best reproducer is to run from David's ppc-for-2.7 branch with > > the above patch applied manually and then try booting the following > > ISOs which now p

[Qemu-devel] [PULL 6/6] virtio-gpu: add live migration support

2016-06-06 Thread Gerd Hoffmann
Store some additional state for cursor and resource backing storage, so we can write out and reload things. Implement vmsave+vmload for 2d mode. Continue blocking live migration in 3d/virgl mode. Signed-off-by: Gerd Hoffmann Message-id: 1464009727-7753-1-git-send-email-kra...@redhat.com --- hw

[Qemu-devel] [PULL 2/6] vmsvga: move fifo sanity checks to vmsvga_fifo_length

2016-06-06 Thread Gerd Hoffmann
Sanity checks are applied when the fifo is enabled by the guest (SVGA_REG_CONFIG_DONE write). Which doesn't help much if the guest changes the fifo registers afterwards. Move the checks to vmsvga_fifo_length so they are done each time qemu is about to read from the fifo. Fixes: CVE-2016-4454 Cc:

Re: [Qemu-devel] [PATCH 2/2] Explicitly print out default vnc option in use

2016-06-06 Thread Markus Armbruster
Robert Hu writes: > On Tue, 2016-05-31 at 13:17 +0200, Markus Armbruster wrote: >> Robert Hu writes: >> >> > On Tue, 2016-05-31 at 09:51 +0200, Markus Armbruster wrote: >> >> Robert Ho writes: >> >> >> >> > If no display option defined in QEMU command line, and SDL is not >> >> > available, t

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/3] ppc: complete the new HV mode

2016-06-06 Thread Cédric Le Goater
On 06/06/2016 06:17 AM, Benjamin Herrenschmidt wrote: > On Sun, 2016-06-05 at 19:41 +0200, Cédric Le Goater wrote: >> >> Here is a fix I think. Could you give it a try ? > > This is somewhat wrong... > >> commit cd0c6f473532 ('ppc: Do some batching of TCG tlb flushes') >> introduced an optimis

Re: [Qemu-devel] [PATCH 1/6] vubr: remove false comment

2016-06-06 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > dispatcher_remove() is in use. > > Signed-off-by: Marc-André Lureau > --- > tests/vhost-user-bridge.c | 2 -- > 1 file changed, 2 deletions(-) Suggest to change the title to tests/vhost-user-bridge: Remove false comment or

Re: [Qemu-devel] [PATCH v3 3/3] IOMMU: Integrate between VFIO and vIOMMU to support device assignment

2016-06-06 Thread Peter Xu
Some questions not quite related to this patch content but vfio... On Mon, May 23, 2016 at 11:53:42AM -0600, Alex Williamson wrote: > On Sat, 21 May 2016 19:19:50 +0300 > "Aviv B.D" wrote: [...] > > +#if 0 > > static hwaddr vfio_container_granularity(VFIOContainer *container) > > { > > r

[Qemu-devel] [PATCH v7 00/15] Add param Error ** for msi_init()

2016-06-06 Thread Cao jin
v7 changelog: 1. 4 new patches, patch 11, 13, 14, 15. previous patch 11 numbered 12 now. 2. patch 2: remove comment of "errp", add it in patch 12 3. patch 4: fix commit message as sugguestion 4. replace all "msi == ON_OFF_AUTO_ON || msi == ON_OFF_AUTO_AUTO" to "msi != ON_OFF_AUTO_OFF", before pa

[Qemu-devel] [PATCH v7 02/15] fix some coding style problems

2016-06-06 Thread Cao jin
It has: 1. More newlines make the code block well separated. 2. Add more comments for msi_init. 3. Fix a indentation in vmxnet3.c. 4. ioh3420 & xio3130_downstream: put PCI Express capability init function together, make it more readable. cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel

[Qemu-devel] [PATCH v7 01/15] pci core: assert ENOSPC when add capability

2016-06-06 Thread Cao jin
ENOSPC is programming error, assert it for debugging. cc: Michael S. Tsirkin cc: Marcel Apfelbaum cc: Markus Armbruster Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/pci/pci.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c

[Qemu-devel] [PATCH v7 04/15] megasas: Fix check for msi_init() failure

2016-06-06 Thread Cao jin
msi_init returns non-zero value on both failure and success. cc: Paolo Bonzini cc: Marcel Apfelbaum cc: Markus Armbruster Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/scsi/megasas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/megasas.c b/hw/scs

[Qemu-devel] [PATCH v7 05/15] mptsas: change .realize function name

2016-06-06 Thread Cao jin
All the other devices` .realize function name are xxx_realize, except this one. cc: Paolo Bonzini cc: Markus Armbruster Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/scsi/mptsas.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/scsi/mptsas.c b/hw/scsi

[Qemu-devel] [PATCH v7 14/15] mptsas: remove unnecessary internal msi state flag

2016-06-06 Thread Cao jin
internal flag msi_in_use in unnecessary, msi_uninit() could be called directly, and msi_enabled() is enough to check device msi state. cc: Markus Armbruster cc: Marcel Apfelbaum cc: Paolo Bonzini cc: Michael S. Tsirkin Signed-off-by: Cao jin --- hw/scsi/mptsas.c | 18 ++ hw/

[Qemu-devel] [PATCH v7 06/15] usb xhci: change msi/msix property type

2016-06-06 Thread Cao jin
>From bit to enum OnOffAuto cc: Gerd Hoffmann cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/usb/hcd-xhci.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 43ba6

[Qemu-devel] [PATCH v7 10/15] pci bridge dev: change msi property type

2016-06-06 Thread Cao jin
>From bit to enum OnOffAuto. cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/pci-bridge/pci_bridge_dev.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridge

[Qemu-devel] [PATCH v7 03/15] change pvscsi_init_msi() type to void

2016-06-06 Thread Cao jin
Nobody use its return value, so change the type to void. cc: Paolo Bonzini cc: Markus Armbruster cc: Marcel Apfelbaum Acked-by: Dmitry Fleytman Reviewed-by: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/scsi/vmw_pvscsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH v7 11/15] msi_init: change return value to 0 on success

2016-06-06 Thread Cao jin
No caller use its return value as msi capability offset, in order to make its return behaviour consistent with msix_init(). cc: Michael S. Tsirkin cc: Paolo Bonzini cc: Hannes Reinecke cc: Markus Armbruster cc: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/pci/msi.c | 6 +++--- hw/s

[Qemu-devel] [PATCH v7 08/15] mptsas: change msi property type

2016-06-06 Thread Cao jin
>From uint32 to enum OnOffAuto, and give it a shorter name. cc: Paolo Bonzini cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/scsi/mptsas.c | 5 +++-- hw/scsi/mptsas.h | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/

Re: [Qemu-devel] [PATCH] Modify net/socket.c to use socket_* functions from include/qemu/sockets.h

2016-06-06 Thread Paolo Bonzini
On 05/06/2016 20:06, Ashijeet Acharya wrote: > > > On Tuesday 31 May 2016 08:31 PM, Paolo Bonzini wrote: >> >> >> On 31/05/2016 11:27, Ashijeet Acharya wrote: >>> Changed the listen(),connect(),parse_host_port() in net/socket.c with >>> the socket_*()functions in include/qemu/sockets.h. >>> >>>

[Qemu-devel] [PATCH v7 09/15] megasas: change msi/msix property type

2016-06-06 Thread Cao jin
>From bit to enum OnOffAuto. cc: Hannes Reinecke cc: Paolo Bonzini cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/scsi/megasas.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/hw/scsi/megas

Re: [Qemu-devel] [PATCH v2] blockdev: clean up error handling in do_open_tray

2016-06-06 Thread Markus Armbruster
Colin Lord writes: > Returns negative error codes and accompanying error messages in cases where > the device has no tray or the tray is locked and isn't forced open. This > extra information should result in better flexibility in functions that > call do_open_tray. > > Signed-off-by: Colin Lord

[Qemu-devel] [PATCH v7 07/15] intel-hda: change msi property type

2016-06-06 Thread Cao jin
>From uint32 to enum OnOffAuto. msi_enabled() should be enough to check device msi state, and change local variant type from int to bool. cc: Gerd Hoffmann cc: Michael S. Tsirkin cc: Markus Armbruster cc: Marcel Apfelbaum Signed-off-by: Cao jin --- hw/audio/intel-hda.c | 9 + 1 file

Re: [Qemu-devel] [PATCH v3 3/3] IOMMU: Integrate between VFIO and vIOMMU to support device assignment

2016-06-06 Thread Peter Xu
On Thu, Jun 02, 2016 at 07:34:17AM -0600, Alex Williamson wrote: > On Thu, 02 Jun 2016 13:09:27 + > "Aviv B.D." wrote: > > > Hi, > > > > In case of hot plug vfio device there should not be any active mapping > > to this device prior the device addition. > > Counter example - a device is hot

[Qemu-devel] [PATCH v7 15/15] vmw_pvscsi: remove unnecessary internal msi state flag

2016-06-06 Thread Cao jin
Internal flag msi_used is uncesessary, msi_uninit() could be called directly, msi_enabled() is enough to check device msi state. cc: Paolo Bonzini cc: Dmitry Fleytman cc: Markus Armbruster cc: Marcel Apfelbaum cc: Michael S. Tsirkin Signed-off-by: Cao jin --- hw/scsi/vmw_pvscsi.c | 14 +++-

[Qemu-devel] [PATCH v7 13/15] megasas: remove unnecessary megasas_use_msi()

2016-06-06 Thread Cao jin
megasas overwrite user configuration when msi_init fail to reflect internal msi state, which is unsuitable. megasa_use_msi() is unnecessary, we can call msi_uninit() when unrealize, even no bother to call msi_enabled() first. cc: Hannes Reinecke cc: Paolo Bonzini cc: Markus Armbruster cc: Marce

[Qemu-devel] [PATCH v7 12/15] pci: Convert msi_init() to Error and fix callers to check it

2016-06-06 Thread Cao jin
msi_init() reports errors with error_report(), which is wrong when it's used in realize(). Fix by converting it to Error. Fix its callers to handle failure instead of ignoring it. For those callers who don't handle the failure, it might happen: when user want msi on, but he doesn't get what he w

Re: [Qemu-devel] [PATCH qemu v17 11/12] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW)

2016-06-06 Thread Alexey Kardashevskiy
On 06/06/16 15:57, David Gibson wrote: > On Wed, Jun 01, 2016 at 06:57:42PM +1000, Alexey Kardashevskiy wrote: >> This adds support for Dynamic DMA Windows (DDW) option defined by >> the SPAPR specification which allows to have additional DMA window(s) >> >> The "ddw" property is enabled by default

[Qemu-devel] [Bug 1580459] Re: Windows (10?) guest freezes entire host on shutdown if using PCI passthrough

2016-06-06 Thread Jimi
If your Windows VM does and always has a sound card being passed in (like the .1 address of your video card), then we can't know for sure that you don't have that other bug. In that other bug, you can fix the crash by not passing in any sound cards, real or virtual, to the VM. It's definitely not t

Re: [Qemu-devel] [PATCH v7 12/15] pci: Convert msi_init() to Error and fix callers to check it

2016-06-06 Thread Cao jin
On 06/06/2016 04:00 PM, Cao jin wrote: diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c +if (xhci->msi != ON_OFF_AUTO_OFF) { +ret = msi_init(dev, 0x70, xhci->numintrs, true, false, &err); +/* Any error other than -ENOTSUP(board's MSI support is broken) + * is

Re: [Qemu-devel] [PATCH v7 09/15] megasas: change msi/msix property type

2016-06-06 Thread Hannes Reinecke
On 06/06/2016 10:00 AM, Cao jin wrote: > From bit to enum OnOffAuto. > > cc: Hannes Reinecke > cc: Paolo Bonzini > cc: Michael S. Tsirkin > cc: Markus Armbruster > cc: Marcel Apfelbaum > > Signed-off-by: Cao jin > --- > hw/scsi/megasas.c | 28 +++- > 1 file changed,

Re: [Qemu-devel] [PATCH v7 11/15] msi_init: change return value to 0 on success

2016-06-06 Thread Hannes Reinecke
On 06/06/2016 10:00 AM, Cao jin wrote: > No caller use its return value as msi capability offset, in order > to make its return behaviour consistent with msix_init(). > > cc: Michael S. Tsirkin > cc: Paolo Bonzini > cc: Hannes Reinecke > cc: Markus Armbruster > cc: Marcel Apfelbaum > > Sign

Re: [Qemu-devel] [RFC PATCH v4 1/3] Mediated device Core driver

2016-06-06 Thread Dong Jia
On Sun, 5 Jun 2016 23:27:42 -0700 Neo Jia wrote: > On Mon, Jun 06, 2016 at 02:01:48PM +0800, Dong Jia wrote: > > On Mon, 6 Jun 2016 10:57:49 +0530 > > Kirti Wankhede wrote: > > > > > > > > > > > On 6/3/2016 2:27 PM, Dong Jia wrote: > > > > On Wed, 25 May 2016 01:28:15 +0530 > > > > Kirti Wank

Re: [Qemu-devel] [PATCH v7 13/15] megasas: remove unnecessary megasas_use_msi()

2016-06-06 Thread Hannes Reinecke
On 06/06/2016 10:01 AM, Cao jin wrote: > megasas overwrite user configuration when msi_init fail to reflect internal > msi > state, which is unsuitable. megasa_use_msi() is unnecessary, we can call > msi_uninit() when unrealize, even no bother to call msi_enabled() first. > > cc: Hannes Reinecke

Re: [Qemu-devel] [PATCH v7 12/15] pci: Convert msi_init() to Error and fix callers to check it

2016-06-06 Thread Hannes Reinecke
On 06/06/2016 10:00 AM, Cao jin wrote: > msi_init() reports errors with error_report(), which is wrong > when it's used in realize(). > > Fix by converting it to Error. > > Fix its callers to handle failure instead of ignoring it. > > For those callers who don't handle the failure, it might happ

Re: [Qemu-devel] [PULL 5/7] vnc: Add support for color map

2016-06-06 Thread Paolo Bonzini
On 03/06/2016 09:04, Gerd Hoffmann wrote: > static void set_pixel_format(VncState *vs, > int bits_per_pixel, int depth, > int big_endian_flag, int true_color_flag, > @@ -2101,8 +2119,15 @@ static void set_pixel_format(VncState *vs, >

Re: [Qemu-devel] [PATCH v7 09/15] megasas: change msi/msix property type

2016-06-06 Thread Cao jin
On 06/06/2016 04:27 PM, Hannes Reinecke wrote: On 06/06/2016 10:00 AM, Cao jin wrote: @@ -2422,10 +2420,8 @@ static Property megasas_properties_gen1[] = { MEGASAS_DEFAULT_FRAMES), DEFINE_PROP_STRING("hba_serial", MegasasState, hba_serial), DEFINE_PROP_UIN

Re: [Qemu-devel] [PULL 10/28] migration: add reporting of errors for outgoing migration

2016-06-06 Thread Paolo Bonzini
On 26/05/2016 08:12, Amit Shah wrote: > @@ -863,12 +867,15 @@ static void migrate_fd_cleanup(void *opaque) > notifier_list_notify(&migration_state_notifiers, s); > } > > -void migrate_fd_error(MigrationState *s) > +void migrate_fd_error(MigrationState *s, const Error *error) > { > -tra

Re: [Qemu-devel] [PULL 01/31] block: Fix bdrv_next() memory leak

2016-06-06 Thread Paolo Bonzini
On 25/05/2016 19:39, Kevin Wolf wrote: > @@ -395,20 +399,27 @@ int bdrv_all_delete_snapshot(const char *name, > BlockDriverState **first_bad_bs, > { > int ret = 0; > BlockDriverState *bs; > -BdrvNextIterator *it = NULL; > +BdrvNextIterator it; > QEMUSnapshotInfo sn1, *sna

Re: [Qemu-devel] [for-2.7 PATCH v3 13/15] QMP: Add query-hotpluggable-cpus

2016-06-06 Thread Igor Mammedov
On Mon, 6 Jun 2016 15:28:09 +1000 David Gibson wrote: > On Thu, May 12, 2016 at 09:18:23AM +0530, Bharata B Rao wrote: > > From: Igor Mammedov > > > > It will allow mgmt to query present and hotpluggable CPU objects, > > it is required from a target platform that wishes to support command > > t

Re: [Qemu-devel] Bug in ppc/BookE wait instruction

2016-06-06 Thread Jakub Horak
Hello, David Gibson (da...@gibson.dropbear.id.au) wrote: > On Fri, Jun 03, 2016 at 05:45:49PM +0200, Jakub Horak wrote: > > Hello, > > I think there's a bug in "wait" instruction code generator for PowerPC > > architecture. It doesn't make sense to store a non-initialized register. > > > > Best

Re: [Qemu-devel] [RFC v1 07/12] cpus: introduce async_safe_run_on_cpu.

2016-06-06 Thread Alex Bennée
Sergey Fedorov writes: > On 15/04/16 17:23, Alex Bennée wrote: >> diff --git a/cpu-exec-common.c b/cpu-exec-common.c >> index 3d7eaa3..c2f7c29 100644 >> --- a/cpu-exec-common.c >> +++ b/cpu-exec-common.c >> @@ -79,3 +79,4 @@ void cpu_loop_exit_restore(CPUState *cpu, uintptr_t pc) >> cpu->cu

Re: [Qemu-devel] [RFC v1 08/12] cputlb: introduce tlb_flush_* async work.

2016-06-06 Thread Alex Bennée
Sergey Fedorov writes: > On 15/04/16 17:23, Alex Bennée wrote: >> diff --git a/cputlb.c b/cputlb.c >> index 1412049..42a3b07 100644 >> --- a/cputlb.c >> +++ b/cputlb.c >> @@ -56,22 +56,14 @@ >> } \ >> } while (0) >> >> +/* We need a solution for stuffing 64 bit pointers in 32 bit ones if >

Re: [Qemu-devel] [RFC v1 09/12] translate-all: introduces tb_flush_safe.

2016-06-06 Thread Alex Bennée
Sergey Fedorov writes: > On 15/04/16 17:23, Alex Bennée wrote: >> diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h >> index f695577..858055b 100644 >> --- a/include/exec/exec-all.h >> +++ b/include/exec/exec-all.h >> @@ -307,6 +307,7 @@ struct TBContext { >> >> void tb_free(Transl

Re: [Qemu-devel] [RFC v1 10/12] arm: use tlb_flush_page_all for tlbimva[a]

2016-06-06 Thread Alex Bennée
Sergey Fedorov writes: > On 15/04/16 17:23, Alex Bennée wrote: >> From: KONRAD Frederic >> >> Instead of flushing each individual vCPU use the tlb_flush_page_all >> functions which is async enabled for MTTCG. >> >> Signed-off-by: KONRAD Frederic >> Signed-off-by: Alex Bennée >> --- >> includ

Re: [Qemu-devel] [RFC v1 12/12] cpus: default MTTCG to on for 32 bit ARM on x86

2016-06-06 Thread Alex Bennée
Sergey Fedorov writes: > On 15/04/16 17:23, Alex Bennée wrote: >> This makes multi-threading the default for 32 bit ARM on x86. It has >> been tested with Debian Jessie as well as my extended KVM unit tests >> which stress the SMC and TB invalidation code. Those tests can be found >> at: >> >>

Re: [Qemu-devel] [PATCH 07/10] vhost-net: save & restore vhost-user acked features

2016-06-06 Thread Yuanhan Liu
On Tue, May 10, 2016 at 06:03:57PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The initial vhost-user connection sets the features to be negotiated > with the driver. Renegotiation isn't possible without device reset. > > To handle reconnection of vhost-user backend,

Re: [Qemu-devel] [PATCH] e1000e: Fix build with gcc 4.6.3 and ust tracing

2016-06-06 Thread Peter Maydell
On 6 June 2016 at 02:18, Jason Wang wrote: > > > On 2016年06月04日 15:02, Dmitry Fleytman wrote: >> >> This patch fixes used-uninitialized false >> positive while compiling with ust tracing >> backend plus gcc 4.6.3: >> >> hw/net/e1000e.c: In function ‘e1000e_io_write’: >> hw/net/e1000e.c:170:39: err

Re: [Qemu-devel] [PATCH v7 11/15] msi_init: change return value to 0 on success

2016-06-06 Thread Cao jin
On 06/06/2016 04:28 PM, Hannes Reinecke wrote: On 06/06/2016 10:00 AM, Cao jin wrote: diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c index 4ff4d06..d4773e2 100644 --- a/hw/scsi/mptsas.c +++ b/hw/scsi/mptsas.c @@ -1286,7 +1286,7 @@ static void mptsas_scsi_realize(PCIDevice *dev, Error **er

Re: [Qemu-devel] [PULL 00/52] Trivial patches for 2016-06-05

2016-06-06 Thread Peter Maydell
On 5 June 2016 at 08:42, Michael Tokarev wrote: > This is a big pile of patches collected in -trivial queue > for quite a while. I was busy with other stuff in recent > months, now am trying to catch up. This is the result, > with everything all over. Please consider pulling. > > /mjt > > The f

[Qemu-devel] [PATCH] vnc: drop unused depth arg for set_pixel_format

2016-06-06 Thread Gerd Hoffmann
Spotted by Coverity. Cc: Paolo Bonzini Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index c862fdc..942cfb9 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2115,8 +2115,7 @@ static void send_color_map(VncState *v

Re: [Qemu-devel] [RFC PATCH 0/3] x86: Add support for guest DMA dirty page tracking

2016-06-06 Thread Zhou Jie
Hi Alex, On 2016/1/6 0:18, Alexander Duyck wrote: On Tue, Jan 5, 2016 at 1:40 AM, Michael S. Tsirkin wrote: On Mon, Jan 04, 2016 at 07:11:25PM -0800, Alexander Duyck wrote: The two mechanisms referenced above would likely require coordination with QEMU and as such are open to discussion. I h

Re: [Qemu-devel] [RFC v1 07/12] cpus: introduce async_safe_run_on_cpu.

2016-06-06 Thread Sergey Fedorov
On 06/06/16 11:50, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 15/04/16 17:23, Alex Bennée wrote: >>> diff --git a/cpus.c b/cpus.c >>> index 9177161..860e2a9 100644 >>> --- a/cpus.c >>> +++ b/cpus.c >>> @@ -928,6 +928,19 @@ static QemuCond qemu_cpu_cond; >>> static QemuCond qemu_pause_con

Re: [Qemu-devel] [PATCH 07/10] vhost-net: save & restore vhost-user acked features

2016-06-06 Thread Marc-André Lureau
Hi - Original Message - > > +uint64_t vhost_net_get_acked_features(VHostNetState *net) > > +{ > > +return net->dev.acked_features; > > +} > > Note that you need add a dummy implementation for !VHOST_NET. Otherwise, > build won't work. good catch, fixed. > And sorry for being noisy,

[Qemu-devel] [PATCH 1/1] vnc: remove unused depth argument in set_pixel_format

2016-06-06 Thread Denis V. Lunev
Spotted by coverity, reported by Paolo. Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Gerd Hoffmann --- ui/vnc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index c862fdc..cc94024 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2116,7 +2116,7 @@

[Qemu-devel] [PATCH 1/2] ppc: Properly tag the translation cache based on MMU mode

2016-06-06 Thread Benjamin Herrenschmidt
We used to always flush the TLB when changing relocation mode in MSR:IR and MSR:DR (ie. MMU on/off for Instructions and Data). We don't anymore since we have split mmu_idx for instruction and data. However, since we hard code the mmu_idx in the translated code, we now need to also make sure MSR:I

[Qemu-devel] [PATCH 2/2] ppc: Fix tlb invalidations on 6xx/7xx/7xxx 32-bit processors

2016-06-06 Thread Benjamin Herrenschmidt
The processor only uses some bits of the address and invalidates an entire congruence class. Some OSes such as Darwin and HelenOS take advantage of this and occasionally invalidate the entire TLB by just doing a series of 64 consecutive tlbie for example. Our code tries to be too smart here only i

Re: [Qemu-devel] [PATCH 15/33] docs: update ACPI CPU hotplug spec with new protocol

2016-06-06 Thread Igor Mammedov
On Wed, 1 Jun 2016 00:09:57 +0300 "Michael S. Tsirkin" wrote: > On Tue, May 31, 2016 at 05:07:41PM +0200, Igor Mammedov wrote: > > On Tue, 31 May 2016 07:49:16 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, May 17, 2016 at 04:43:07PM +0200, Igor Mammedov wrote: > > > > Signed-off-b

Re: [Qemu-devel] [PATCH 1/5] qemu-img bench

2016-06-06 Thread Denis V. Lunev
On 06/03/2016 03:30 PM, Kevin Wolf wrote: This adds a qemu-img command that allows doing some simple benchmarks for the block layer without involving guest devices and a real VM. For the start, this implements only a test of sequential reads. Signed-off-by: Kevin Wolf --- qemu-img-cmds.hx |

Re: [Qemu-devel] [PATCH RFC 0/8] cpus: make "-cpu cpux, features" global properties

2016-06-06 Thread David Hildenbrand
> I assume Igor explained it, already, and his suggestion sounds OK > to you. But I will answer your questions to confirm that this is > really the case: Yes, this all sounds good to me, thanks for the additional explanation! [...] > > > > > d) has to work for us. Otherwise we will have to fal

Re: [Qemu-devel] [PATCH 3/5] qemu-img bench: Make start offset configurable

2016-06-06 Thread Denis V. Lunev
On 06/03/2016 03:30 PM, Kevin Wolf wrote: This patch adds an option the specify the offset of the first request made by qemu-img bench. This allows to benchmark misaligned requests. Signed-off-by: Kevin Wolf --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 23 --- qemu

Re: [Qemu-devel] [PATCH 4/5] qemu-img bench: Implement -S (step size)

2016-06-06 Thread Denis V. Lunev
On 06/03/2016 03:30 PM, Kevin Wolf wrote: With this new option, qemu-img bench can be told to advance the current offset after each request by a different value than the buffer size. This is useful for controlling the conditions for cluster allocation in image formats (e.g. qcow2 cluster allocati

Re: [Qemu-devel] [RFC v1 09/12] translate-all: introduces tb_flush_safe.

2016-06-06 Thread Sergey Fedorov
On 06/06/16 11:54, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 15/04/16 17:23, Alex Bennée wrote: >>> diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h >>> index f695577..858055b 100644 >>> --- a/include/exec/exec-all.h >>> +++ b/include/exec/exec-all.h >>> @@ -307,6 +307,7 @@

Re: [Qemu-devel] [RFC v1 08/12] cputlb: introduce tlb_flush_* async work.

2016-06-06 Thread Sergey Fedorov
On 06/06/16 11:54, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 15/04/16 17:23, Alex Bennée wrote: >>> diff --git a/cputlb.c b/cputlb.c >>> index 1412049..42a3b07 100644 >>> --- a/cputlb.c >>> +++ b/cputlb.c (snip) >>> @@ -89,6 +81,34 @@ void tlb_flush(CPUState *cpu, int flush_global) >>>

Re: [Qemu-devel] [PATCH v8 5/9] linux-user: Update preprocessor constants for Mips-specific e_flags bits

2016-06-06 Thread Leon Alrae
On Fri, Jun 03, 2016 at 08:43:11PM +0200, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Missing values EF_MIPS_FP64 and EF_MIPS_NAN2008 added, and the format > of the surrounding code segment adjusted. Please don't include whitespace fixes of other lines into the same patch: http://

Re: [Qemu-devel] [PATCH v13 6/8] hw/ptimer: Support running with counter = 0 by introducing new policy feature

2016-06-06 Thread Peter Maydell
On 27 May 2016 at 18:03, Dmitry Osipenko wrote: > Currently ptimer prints error message and clears enable flag for an arming > timer that has delta = load = 0. That actually is a valid case for most > of the timers, like instant IRQ trigger for oneshot timer or continuous in > periodic mode. There

Re: [Qemu-devel] [PATCH v8 6/9] target-mips: Activate IEEE 754-2008 signaling NaN bit meaning for MSA

2016-06-06 Thread Leon Alrae
On Fri, Jun 03, 2016 at 08:43:12PM +0200, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Function msa_reset() is updated so that flag snan_bit_is_one is > properly set to 0. > > By applying this patch, a number of incorrect MSA behaviors that > require IEEE 754-2008 compliance will b

Re: [Qemu-devel] [PULL 00/25] pc, pci, virtio: new features, cleanups, fixes

2016-06-06 Thread Peter Maydell
On 5 June 2016 at 14:20, Michael S. Tsirkin wrote: > The following changes since commit 6b3532b20b787cbd697a68b383232f5c3b39bd1e: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160603-1' into > staging (2016-06-03 12:03:36 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH 1/6] vubr: remove false comment

2016-06-06 Thread Marc-André Lureau
Hi - Original Message - > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > dispatcher_remove() is in use. > > > > Signed-off-by: Marc-André Lureau > > --- > > tests/vhost-user-bridge.c | 2 -- > > 1 file changed, 2 deletions(-) > > Suggest to change the title

Re: [Qemu-devel] [RFC v1 12/12] cpus: default MTTCG to on for 32 bit ARM on x86

2016-06-06 Thread Sergey Fedorov
On 06/06/16 11:58, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 15/04/16 17:23, Alex Bennée wrote: >>> diff --git a/cpus.c b/cpus.c >>> index 860e2a9..daa92c7 100644 >>> --- a/cpus.c >>> +++ b/cpus.c >>> @@ -171,12 +171,24 @@ opts_init(tcg_register_config); >>> >>> static bool default_mttc

[Qemu-devel] [RFC/PATCH] ppc: Batch TLB flushes on 32-bit 6xx/7xx/7xxx in hash mode

2016-06-06 Thread Benjamin Herrenschmidt
This ports the existing 64-bit mechanism to 32-bit, thus series of 64 tlbie's followed by a sync like some versions of Darwin (ab)use will result in a single flush. We apply a pending flush on any sync instruction though, as Darwin doesn't use tlbsync on non-SMP systems. Signed-off-by: Benjamin H

Re: [Qemu-devel] [RFC v1 12/12] cpus: default MTTCG to on for 32 bit ARM on x86

2016-06-06 Thread Peter Maydell
On 15 April 2016 at 15:23, Alex Bennée wrote: > This makes multi-threading the default for 32 bit ARM on x86. It has > been tested with Debian Jessie as well as my extended KVM unit tests > which stress the SMC and TB invalidation code. Those tests can be found > at: > > https://github.com/stsqu

[Qemu-devel] [Bug 1581796] Re: console-gl.c:96:surface_gl_create_texture:code should not be reached

2016-06-06 Thread luigiburdo
Hi T. i been test and build your patch with the qemu 2.6 on mate 16.10 and look like not crashing when qemu open like before but i continue have the black display here,look like the emulated hardware have a issue someware. (check the attached image)... the strange of this issue is it was not pres

[Qemu-devel] [PATCH] scsi-disk: add missing break

2016-06-06 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index d5e8c8b..4b596d2 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -2740,6 +2740,7 @@ static int32_t scsi_block_dma_command(SCSIRequ

[Qemu-devel] [PATCH v4 0/9] 8bit AVR cores

2016-06-06 Thread Michael Rolnik
This series of patches adds 8bit AVR cores to QEMU. All instruction, except BREAK/DES/SPM/SPMX, are implemented. Not fully tested yet. However I was able to execute simple code with functions. e.g fibonacci calculation. This series of patches include a non real, sample board. No fuses support yet

[Qemu-devel] [PATCH v4 1/9] target-avr: AVR cores support is added. 1. basic CPU structure 2. registers 3. no instructions

2016-06-06 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- arch_init.c | 2 + configure | 5 + default-configs/avr-softmmu.mak | 1 + disas/Makefile.objs | 1 + disas/avr.c | 10 ++ include/disas/bfd.h | 7 + include/sysemu/a

[Qemu-devel] [PATCH v4 2/9] target-avr: adding AVR CPU features/flavors

2016-06-06 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/cpu.c | 311 ++- target-avr/cpu.h | 59 +++ 2 files changed, 368 insertions(+), 2 deletions(-) diff --git a/target-avr/cpu.c b/target-avr/cpu.c index cfc1aee..97653c5 100644 --- a/target-avr

[Qemu-devel] [PATCH v4 3/9] target-avr: adding a sample AVR board

2016-06-06 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- hw/Makefile.objs | 1 + hw/avr/Makefile.objs | 1 + hw/avr/sample-io.c | 217 +++ hw/avr/sample.c | 118 4 files changed, 337 insertions(+) create mode 100644 hw/avr/Make

[Qemu-devel] [PATCH v4 5/9] target-avr: adding AVR interrupt handling

2016-06-06 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/helper.c | 59 - 1 file changed, 58 insertions(+), 1 deletion(-) diff --git a/target-avr/helper.c b/target-avr/helper.c index fbab91d..e798dd9 100644 --- a/target-avr/helper.c +++ b/target-avr/helper

[Qemu-devel] [PATCH v4 4/9] target-avr: adding instructions encodings

2016-06-06 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/translate-inst.h | 730 1 file changed, 730 insertions(+) create mode 100644 target-avr/translate-inst.h diff --git a/target-avr/translate-inst.h b/target-avr/translate-inst.h new file mode 100644 index 00

[Qemu-devel] [PATCH v4 9/9] target-avr: updating translate.c to use instructions translation

2016-06-06 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/Makefile.objs | 4 +- target-avr/translate.c | 132 --- 2 files changed, 59 insertions(+), 77 deletions(-) diff --git a/target-avr/Makefile.objs b/target-avr/Makefile.objs index c503546..8d06d54 100644 -

[Qemu-devel] [PATCH v4 7/9] target-avr: adding instruction decoder

2016-06-06 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/decode.c | 724 1 file changed, 724 insertions(+) create mode 100644 target-avr/decode.c diff --git a/target-avr/decode.c b/target-avr/decode.c new file mode 100644 index 000..6fb7b83 --- /dev/

[Qemu-devel] [PATCH v4 8/9] target-avr: adding instruction translation

2016-06-06 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-avr/translate-inst.c | 2499 +++ target-avr/translate.h | 120 +++ 2 files changed, 2619 insertions(+) create mode 100644 target-avr/translate-inst.c create mode 100644 target-avr/translate.h diff --git a/ta

Re: [Qemu-devel] [PATCH v8 9/9] target-mips: Implement FCR31's R/W bitmask and related functionalities

2016-06-06 Thread Leon Alrae
> @@ -110,9 +110,11 @@ struct CPUMIPSFPUContext { > #define FCR0_PRID 8 > #define FCR0_REV 0 > /* fcsr */ > +uint32_t fcr31_rw_bitmask; > uint32_t fcr31; > -#define FCR31_ABS2008 19 > -#define FCR31_NAN2008 18 > +#define FCR31_NAN2008 18 > +#define FCR31_ABS2008 19 Now the

Re: [Qemu-devel] [PATCH 1/2] ppc: Properly tag the translation cache based on MMU mode

2016-06-06 Thread Cédric Le Goater
On 06/06/2016 11:52 AM, Benjamin Herrenschmidt wrote: > We used to always flush the TLB when changing relocation mode in > MSR:IR and MSR:DR (ie. MMU on/off for Instructions and Data). > > We don't anymore since we have split mmu_idx for instruction and data. > > However, since we hard code the m

Re: [Qemu-devel] [kvm-unit-tests PATCH v2 01/10] lib: xstr: allow multiple args

2016-06-06 Thread Alex Bennée
Andrew Jones writes: > Signed-off-by: Andrew Jones > --- > lib/libcflat.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/libcflat.h b/lib/libcflat.h > index 582e3fc60e287..e5e588c742763 100644 > --- a/lib/libcflat.h > +++ b/lib/libcflat.h > @@ -27,8 +27,8 @@ >

Re: [Qemu-devel] [PATCH 2/2] ppc: Fix tlb invalidations on 6xx/7xx/7xxx 32-bit processors

2016-06-06 Thread Cédric Le Goater
On 06/06/2016 11:52 AM, Benjamin Herrenschmidt wrote: > The processor only uses some bits of the address and invalidates an > entire congruence class. Some OSes such as Darwin and HelenOS take > advantage of this and occasionally invalidate the entire TLB by just > doing a series of 64 consecutive

  1   2   3   4   5   >