Re: [Qemu-devel] [PATCH v7 11/15] msi_init: change return value to 0 on success

[Cao jin]

On 06/06/2016 04:28 PM, Hannes Reinecke wrote:

On 06/06/2016 10:00 AM, Cao jin wrote:

diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c
index 4ff4d06..d4773e2 100644
--- a/hw/scsi/mptsas.c
+++ b/hw/scsi/mptsas.c
@@ -1286,7 +1286,7 @@ static void mptsas_scsi_realize(PCIDevice *dev, Error 
**errp)
                            "mptsas-diag", 0x10000);

      if (s->msi != ON_OFF_AUTO_OFF &&
-        msi_init(dev, 0, 1, true, false) >= 0) {
+        msi_init(dev, 0, 1, true, false) > 0) {

I am so sorry I made the mistake...it should be msi_init() == 0

          /* TODO check for errors */
          s->msi_in_use = true;
      }

--
Yours Sincerely,

Cao jin