On 06/06/2016 10:00 AM, Cao jin wrote: > msi_init() reports errors with error_report(), which is wrong > when it's used in realize(). > > Fix by converting it to Error. > > Fix its callers to handle failure instead of ignoring it. > > For those callers who don't handle the failure, it might happen: > when user want msi on, but he doesn't get what he want because of > msi_init fails silently. > > cc: Gerd Hoffmann <kra...@redhat.com> > cc: John Snow <js...@redhat.com> > cc: Dmitry Fleytman <dmi...@daynix.com> > cc: Jason Wang <jasow...@redhat.com> > cc: Michael S. Tsirkin <m...@redhat.com> > cc: Hannes Reinecke <h...@suse.de> > cc: Paolo Bonzini <pbonz...@redhat.com> > cc: Alex Williamson <alex.william...@redhat.com> > cc: Markus Armbruster <arm...@redhat.com> > cc: Marcel Apfelbaum <mar...@redhat.com> > > Signed-off-by: Cao jin <caoj.f...@cn.fujitsu.com> > --- > hw/audio/intel-hda.c | 25 +++++++++++++++++++++---- > hw/ide/ich.c | 15 +++++++++------ > hw/net/vmxnet3.c | 38 > +++++++++++++------------------------- > hw/pci-bridge/ioh3420.c | 6 +++++- > hw/pci-bridge/pci_bridge_dev.c | 20 ++++++++++++++++---- > hw/pci-bridge/xio3130_downstream.c | 6 +++++- > hw/pci-bridge/xio3130_upstream.c | 6 +++++- > hw/pci/msi.c | 11 ++++++++--- > hw/scsi/megasas.c | 27 ++++++++++++++++++++++----- > hw/scsi/mptsas.c | 31 ++++++++++++++++++++++++------- > hw/scsi/vmw_pvscsi.c | 4 +++- > hw/usb/hcd-xhci.c | 23 +++++++++++++++++++---- > hw/vfio/pci.c | 7 +++++-- > include/hw/pci/msi.h | 3 ++- > 14 files changed, 157 insertions(+), 65 deletions(-) > For the megasas parts:
Acked-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
