Re: [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function

2015-10-19 Thread Michael S. Tsirkin
On Mon, Oct 19, 2015 at 12:39:24PM +0800, Xiao Guangrong wrote: > > > On 10/19/2015 02:05 AM, Michael S. Tsirkin wrote: > >On Mon, Oct 19, 2015 at 08:54:14AM +0800, Xiao Guangrong wrote: > >>__DSM is defined in ACPI 6.0: 9.14.1 _DSM (Device Specific Method) > >> > >>Function 0 is a query function

Re: [Qemu-devel] [PATCH v4 27/33] nvdimm acpi: save arg3 for NVDIMM device _DSM method

2015-10-19 Thread Michael S. Tsirkin
On Mon, Oct 19, 2015 at 12:04:48PM +0800, Xiao Guangrong wrote: > > > On 10/19/2015 01:16 AM, Michael S. Tsirkin wrote: > >On Mon, Oct 19, 2015 at 08:54:13AM +0800, Xiao Guangrong wrote: > >>Check if the input Arg3 is valid then store it into dsm_in if needed > >> > >>Signed-off-by: Xiao Guangron

Re: [Qemu-devel] [PATCH] hw/display/tcx: Remove superfluous OBJECT() typecasts

2015-10-19 Thread Markus Armbruster
Mark Cave-Ayland writes: > On 15/10/15 09:54, Thomas Huth wrote: > >> The tcx_initfn() function is already supplied with an >> Object *obj pointer, so there is no need to cast the >> state pointer back to an Object pointer all over the >> place. And while we're at it, also remove the superfluous

Re: [Qemu-devel] [PATCH v3 26/32] nvdimm: save arg3 for NVDIMM device _DSM method

2015-10-19 Thread Xiao Guangrong
On 10/19/2015 02:50 PM, Michael S. Tsirkin wrote: On Sun, Oct 11, 2015 at 11:52:58AM +0800, Xiao Guangrong wrote: Check if the input Arg3 is valid then store it into dsm_in if needed We only do the save on NVDIMM device since we are not going to support any function on root device Signed-off

Re: [Qemu-devel] [Qemu-block] [RFC] transactions: add transaction-wide property

2015-10-19 Thread Markus Armbruster
John Snow writes: > On 10/16/2015 08:23 AM, Stefan Hajnoczi wrote: >> On Mon, Oct 12, 2015 at 12:50:20PM -0400, John Snow wrote: >>> Ping -- any consensus on how we should implement the "do-or-die" >>> argument for transactions that start block jobs? :) >>> >>> This patch may look a little hokey

Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI

2015-10-19 Thread Xiao Guangrong
On 10/19/2015 02:56 PM, Michael S. Tsirkin wrote: On Sun, Oct 11, 2015 at 11:52:54AM +0800, Xiao Guangrong wrote: We reserve the memory region 0xFF0 ~ 0xFFF0 for NVDIMM ACPI which is used as: - the first page is mapped as MMIO, ACPI write data to this page to transfer the control to

Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI

2015-10-19 Thread Michael S. Tsirkin
On Mon, Oct 19, 2015 at 03:27:21PM +0800, Xiao Guangrong wrote: > >>+nvdimm_init_memory_state(&pcms->nvdimm_memory, system_memory, > >>machine, > >>+ TARGET_PAGE_SIZE); > >>+ > > > >Shouldn't this be conditional on presence of the nvdimm device? > > > > We

Re: [Qemu-devel] [PATCH V5 0/8] Xilinx DisplayPort.

2015-10-19 Thread Frederic Konrad
On 16/10/2015 23:57, Alistair Francis wrote: > On Fri, Oct 16, 2015 at 6:41 AM, wrote: >> From: KONRAD Frederic >> >> This is the fifth version of this patch-set of the implementation of the >> Xilinx >> DisplayPort and DPDMA. >> >> This fifth version moves some headers files to the right direc

Re: [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function

2015-10-19 Thread Xiao Guangrong
On 10/19/2015 03:06 PM, Michael S. Tsirkin wrote: On Mon, Oct 19, 2015 at 12:39:24PM +0800, Xiao Guangrong wrote: On 10/19/2015 02:05 AM, Michael S. Tsirkin wrote: On Mon, Oct 19, 2015 at 08:54:14AM +0800, Xiao Guangrong wrote: __DSM is defined in ACPI 6.0: 9.14.1 _DSM (Device Specific Met

Re: [Qemu-devel] [PATCH v3 26/32] nvdimm: save arg3 for NVDIMM device _DSM method

2015-10-19 Thread Michael S. Tsirkin
On Mon, Oct 19, 2015 at 03:14:28PM +0800, Xiao Guangrong wrote: > > > On 10/19/2015 02:50 PM, Michael S. Tsirkin wrote: > >On Sun, Oct 11, 2015 at 11:52:58AM +0800, Xiao Guangrong wrote: > >>Check if the input Arg3 is valid then store it into dsm_in if needed > >> > >>We only do the save on NVDIM

Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI

2015-10-19 Thread Xiao Guangrong
On 10/19/2015 03:39 PM, Michael S. Tsirkin wrote: On Mon, Oct 19, 2015 at 03:27:21PM +0800, Xiao Guangrong wrote: +nvdimm_init_memory_state(&pcms->nvdimm_memory, system_memory, machine, + TARGET_PAGE_SIZE); + Shouldn't this be conditional on presence o

Re: [Qemu-devel] QEMU patch to allow VM introspection via libvmi

2015-10-19 Thread Markus Armbruster
Valerio Aimale writes: > On 10/16/15 2:15 AM, Markus Armbruster wrote: >> vale...@aimale.com writes: >> >>> All- >>> >>> I've produced a patch for the current QEMU HEAD, for libvmi to >>> introspect QEMU/KVM VMs. >>> >>> Libvmi has patches for the old qeum-kvm fork, inside its source tree: >>> ht

Re: [Qemu-devel] [PATCH v3 26/32] nvdimm: save arg3 for NVDIMM device _DSM method

2015-10-19 Thread Xiao Guangrong
On 10/19/2015 03:47 PM, Michael S. Tsirkin wrote: aml_arg(3) is used many times below. Pls give it a name that makes sense (not arg3! what is it for?) Er. aml_arg(3) is just the fourth parameter of _DSM method. Will add some comments: /* * The fourth parameter (Arg3) of _DMS is a package

Re: [Qemu-devel] [PATCH v2] kvm: Allow the Hyper-V vendor ID to be specified

2015-10-19 Thread Paolo Bonzini
On 16/10/2015 17:38, Alex Williamson wrote: > According to Microsoft documentation, the signature in the standard > hypervisor CPUID leaf at 0x4000 identifies the Vendor ID and is > for reporting and diagnostic purposes only. We can therefore allow > the user to change it to whatever they wa

Re: [Qemu-devel] [PATCH] qapi: Adding websocket information inside VncInfo structure.

2015-10-19 Thread Gerd Hoffmann
Hi, > diff --git a/qapi-schema.json b/qapi-schema.json > index a386605..e97f78f 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -916,7 +916,8 @@ > { 'struct': 'VncInfo', >'data': {'enabled': 'bool', '*host': 'str', > '*family': 'NetworkAddressFamily', > -

[Qemu-devel] [PULL 0/1] audio: Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-19 Thread Gerd Hoffmann
le ;) The following changes since commit 40fe17bea478793fc9106a630fa3610dad51f939: hw/ide/ahci.c: Fix shift left into sign bit (2015-10-18 11:00:40 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-audio-20151019-1 for you to fetch cha

[Qemu-devel] [PULL 1/1] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-19 Thread Gerd Hoffmann
From: Nutan Shinde Signed-off-by: Nutan Shinde Reviewed-by: Peter Maydell Reviewed-by: Stefan Hajnoczi Signed-off-by: Gerd Hoffmann --- hw/audio/adlib.c | 9 ++--- hw/audio/es1370.c | 17 ++--- hw/audio/gus.c| 9 ++--- hw/audio/sb16.c | 15 +-- 4 file

[Qemu-devel] [PULL 28/49] qemu-char: convert parallel backend to data-driven creation

2015-10-19 Thread Paolo Bonzini
Conversion to Error * brings better error messages; before: qemu-system-x86_64: -chardev id=serial,backend=parallel,path=vl.c: Failed to create chardev After: qemu-system-x86_64: -chardev id=serial,backend=parallel,path=vl.c: not a parallel port: Inappropriate ioctl for device Reviewe

[Qemu-devel] [PULL v2 00/49] Misc patches for 2015-10-16

2015-10-19 Thread Paolo Bonzini
The following changes since commit 5451316ed07b758a187dedf21047bed8f843f7f1: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2015-10-12 15:52:54 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you

[Qemu-devel] [PULL 37/49] qemu-char: convert testdev backend to data-driven creation

2015-10-19 Thread Paolo Bonzini
Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini --- backends/testdev.c| 7 +-- include/sysemu/char.h | 3 --- qemu-char.c | 2 +- stubs/Makefile.objs | 1 - stubs/chr-testdev.c | 7 --- 5 files changed, 6 insertions(+), 14 deletions(-) delete mode 100644 stubs/chr

[Qemu-devel] [PULL 49/49] kvm: Allow the Hyper-V vendor ID to be specified

2015-10-19 Thread Paolo Bonzini
From: Alex Williamson According to Microsoft documentation, the signature in the standard hypervisor CPUID leaf at 0x4000 identifies the Vendor ID and is for reporting and diagnostic purposes only. We can therefore allow the user to change it to whatever they want, within the 12 character li

Re: [Qemu-devel] [PATCH v5 2/4] pcie: Add support for Single Root I/O Virtualization (SR/IOV)

2015-10-19 Thread Paolo Bonzini
On 18/10/2015 13:02, Marcel Apfelbaum wrote: > > +pci_device_deassert_intx(dev); > +assert(dev->irq_state == 0); > + > +/* Clear all writable bits */ > +pci_word_test_and_clear_mask(dev->config + PCI_COMMAND, > + pci_get_word(dev->wmask + PCI_COMMA

Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI

2015-10-19 Thread Michael S. Tsirkin
On Mon, Oct 19, 2015 at 03:44:13PM +0800, Xiao Guangrong wrote: > > > On 10/19/2015 03:39 PM, Michael S. Tsirkin wrote: > >On Mon, Oct 19, 2015 at 03:27:21PM +0800, Xiao Guangrong wrote: > +nvdimm_init_memory_state(&pcms->nvdimm_memory, system_memory, > machine, > +

Re: [Qemu-devel] [PATCH COLO-Frame v9 06/32] migration: Integrate COLO checkpoint process into loadvm

2015-10-19 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > Switch from normal migration loadvm process into COLO checkpoint process if > COLO mode is enabled. > We add three new members to struct MigrationIncomingState, > 'have_colo_incoming_thread' > and 'colo_incoming_thread' record the colo rela

[Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline.

2015-10-19 Thread Gerd Hoffmann
pull, Gerd The following changes since commit 40fe17bea478793fc9106a630fa3610dad51f939: hw/ide/ahci.c: Fix shift left into sign bit (2015-10-18 11:00:40 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-fw_cfg-20151019-1 for you to fetch changes

[Qemu-devel] [PULL 7/7] fw_cfg: Define a static signature to be returned on DMA port reads

2015-10-19 Thread Gerd Hoffmann
From: Kevin O'Connor Return a static signature ("QEMU CFG") if the guest does a read to the DMA address io register. Signed-off-by: Kevin O'Connor Reviewed-by: Laszlo Ersek Reviewed-by: Stefan Hajnoczi Signed-off-by: Gerd Hoffmann --- docs/specs/fw_cfg.txt | 3 +++ hw/nvram/fw_cfg.c |

[Qemu-devel] [PULL 4/7] Implement fw_cfg DMA interface

2015-10-19 Thread Gerd Hoffmann
From: Marc Marí Based on the specifications on docs/specs/fw_cfg.txt This interface is an addon. The old interface can still be used as usual. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí Reviewed-by: Laszlo Ersek Signed-off-by: Gerd Hoffmann --- hw/arm/virt.c

[Qemu-devel] [PULL 1/7] fw_cfg: insert string blobs via qemu cmdline

2015-10-19 Thread Gerd Hoffmann
From: "Gabriel L. Somlo" Allow users to provide custom fw_cfg blobs with ascii string payloads specified directly on the qemu command line. Suggested-by: Jordan Justen Suggested-by: Laszlo Ersek Signed-off-by: Gabriel Somlo Message-id: 1443544141-26568-1-git-send-email-so...@cmu.edu Reviewd-b

[Qemu-devel] [PULL 5/7] Enable fw_cfg DMA interface for ARM

2015-10-19 Thread Gerd Hoffmann
From: Marc Marí Enable the fw_cfg DMA interface for the ARM virt machine. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí Reviewed-by: Peter Maydell Reviewed-by: Laszlo Ersek Signed-off-by: Gerd Hoffmann --- hw/arm/virt.c | 8 1 file changed, 4 insertions(

[Qemu-devel] [PULL 3/7] fw_cfg DMA interface documentation

2015-10-19 Thread Gerd Hoffmann
From: Marc Marí Add fw_cfg DMA interface specification in the documentation. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí Reviewed-by: Peter Maydell Reviewed-by: Laszlo Ersek Signed-off-by: Gerd Hoffmann --- docs/specs/fw_cfg.txt | 65 +++

[Qemu-devel] [PULL 2/7] fw_cfg: document fw_cfg_modify_iXX() update functions

2015-10-19 Thread Gerd Hoffmann
From: "Gabriel L. Somlo" Document the behavior of fw_cfg_modify_iXX() for leak-less updating of integer-type blobs. Currently only fw_cfg_modify_i16() is coded, but 32- and 64-bit versions may be added later if necessary.. Signed-off-by: Gabriel Somlo Reviewed-by: Laszlo Ersek Signed-off-by:

Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI

2015-10-19 Thread Igor Mammedov
On Mon, 19 Oct 2015 12:17:22 +0300 "Michael S. Tsirkin" wrote: > On Mon, Oct 19, 2015 at 03:44:13PM +0800, Xiao Guangrong wrote: > > > > > > On 10/19/2015 03:39 PM, Michael S. Tsirkin wrote: > > >On Mon, Oct 19, 2015 at 03:27:21PM +0800, Xiao Guangrong wrote: > > +nvdimm_init_memory

Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI

2015-10-19 Thread Igor Mammedov
On Mon, 19 Oct 2015 09:56:12 +0300 "Michael S. Tsirkin" wrote: > On Sun, Oct 11, 2015 at 11:52:54AM +0800, Xiao Guangrong wrote: [...] > > diff --git a/include/hw/mem/nvdimm.h b/include/hw/mem/nvdimm.h > > index f6bd2c4..aa95961 100644 > > --- a/include/hw/mem/nvdimm.h > > +++ b/include/hw/mem/nv

[Qemu-devel] [PULL 6/7] Enable fw_cfg DMA interface for x86

2015-10-19 Thread Gerd Hoffmann
From: Marc Marí Enable the fw_cfg DMA interface for all the x86 platforms. Based on Gerd Hoffman's initial implementation. Signed-off-by: Marc Marí Reviewed-by: Laszlo Ersek Signed-off-by: Gerd Hoffmann --- hw/i386/pc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --g

[Qemu-devel] [PATCH] qemu-options: add documentation for using UDP unicast network backend.

2015-10-19 Thread Victor Kaplansky
For a long time QEMU has had support for UDP unicast network backend, but manual was missing description and usage examples. This patch adds some more documentation and an example. Signed-off-by: Victor Kaplansky --- qemu-options.hx | 23 +++ 1 file changed, 23 insertions(+)

Re: [Qemu-devel] [PULL 0/1] audio: Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-19 Thread Peter Maydell
he git repository at: > > git://git.kraxel.org/qemu tags/pull-audio-20151019-1 > > for you to fetch changes up to 8307c294a355bbf3c5352e00877365b0cda66d52: > > Remove macros IO_READ_PROTO and IO_WRITE_PROTO (2015-10-19 09:03:53 +0200) > > ---

Re: [Qemu-devel] [PATCH COLO-Frame v9 08/32] COLO/migration: establish a new communication path from destination to source

2015-10-19 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > Add a new member 'to_src_file' to MigrationIncomingState and a > new member 'from_dst_file' to MigrationState. > They will be used for returning messages from destination to source. > It will also be used by post-copy migration. > > Signed-

Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI

2015-10-19 Thread Xiao Guangrong
On 10/19/2015 05:46 PM, Igor Mammedov wrote: On Mon, 19 Oct 2015 12:17:22 +0300 "Michael S. Tsirkin" wrote: On Mon, Oct 19, 2015 at 03:44:13PM +0800, Xiao Guangrong wrote: On 10/19/2015 03:39 PM, Michael S. Tsirkin wrote: On Mon, Oct 19, 2015 at 03:27:21PM +0800, Xiao Guangrong wrote: +

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

2015-10-19 Thread Gerd Hoffmann
Hi, > OK. For cleaner (purpose is separation of curses code), I introduced > hw_text_update_cb() interface (looks like possible to use text data for > other than curses interface too). But you may feel this is overkill. Waded through the code a bit. The whole text interface isn't cleanly abstr

[Qemu-devel] How to log DRAM access address in QEMU

2015-10-19 Thread Yu-Cheng Liu
Dear all: I want to log out DRAM access information( address,read,write ) in QEMU when guest OS or application use the DRAM, which function can I add the log ? thanks for your help~

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-19 Thread Stefano Stabellini
On Fri, 16 Oct 2015, John Snow wrote: > On 10/13/2015 01:10 PM, Stefano Stabellini wrote: > > On Tue, 13 Oct 2015, John Snow wrote: > >> On 10/13/2015 11:55 AM, Fabio Fantoni wrote: > >>> I added ahci disk support in libxl and using it for week seems that was > >>> ok, after a reply of Stefano Stab

Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI

2015-10-19 Thread Michael S. Tsirkin
On Mon, Oct 19, 2015 at 11:18:36AM +0200, Igor Mammedov wrote: > On Mon, 19 Oct 2015 09:56:12 +0300 > "Michael S. Tsirkin" wrote: > > > On Sun, Oct 11, 2015 at 11:52:54AM +0800, Xiao Guangrong wrote: > [...] > > > diff --git a/include/hw/mem/nvdimm.h b/include/hw/mem/nvdimm.h > > > index f6bd2c4.

[Qemu-devel] [PULL 0/2] Xen 2015-10-19-tag

2015-10-19 Thread Stefano Stabellini
The following changes since commit aedc8806172dd1ae904f04169ee3b19fce1d7893: Merge remote-tracking branch 'remotes/kraxel/tags/pull-audio-20151019-1' into staging (2015-10-19 10:06:56 +0100) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-d

[Qemu-devel] [PULL 2/2] xen-platform: Ensure xen is enabled when initializing

2015-10-19 Thread Stefano Stabellini
From: Eduardo Habkost The xen-platform code crashes on reset if the xen backend is not initialized, because it calls xc_hvm_set_mem_type(). Ensure xen-platform won't be created without initializing the xen backend. The assert can't be triggered by the user because the device is not hotpluggable,

[Qemu-devel] [PULL 1/2] pc: Require xen when initializing xenfv machine

2015-10-19 Thread Stefano Stabellini
From: Eduardo Habkost Without this check, the xen-platform device will crash on reset if using the accel option with anything other than xen (e.g. "-machine xenfv,accel=kvm"). Signed-off-by: Eduardo Habkost Reviewed-by: Stefano Stabellini Signed-off-by: Stefano Stabellini --- hw/i386/pc_piix

Re: [Qemu-devel] [PATCH] qemu-options: add documentation for using UDP unicast network backend.

2015-10-19 Thread Michael S. Tsirkin
On Mon, Oct 19, 2015 at 12:49:15PM +0300, Victor Kaplansky wrote: > For a long time QEMU has had support for UDP unicast network > backend, but manual was missing description and usage examples. > > This patch adds some more documentation and an example. > > Signed-off-by: Victor Kaplansky Goo

Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI

2015-10-19 Thread Michael S. Tsirkin
On Mon, Oct 19, 2015 at 06:01:17PM +0800, Xiao Guangrong wrote: > > > On 10/19/2015 05:46 PM, Igor Mammedov wrote: > >On Mon, 19 Oct 2015 12:17:22 +0300 > >"Michael S. Tsirkin" wrote: > > > >>On Mon, Oct 19, 2015 at 03:44:13PM +0800, Xiao Guangrong wrote: > >>> > >>> > >>>On 10/19/2015 03:39 PM,

Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI

2015-10-19 Thread Igor Mammedov
On Mon, 19 Oct 2015 18:01:17 +0800 Xiao Guangrong wrote: > > > On 10/19/2015 05:46 PM, Igor Mammedov wrote: > > On Mon, 19 Oct 2015 12:17:22 +0300 > > "Michael S. Tsirkin" wrote: > > > >> On Mon, Oct 19, 2015 at 03:44:13PM +0800, Xiao Guangrong wrote: > >>> > >>> > >>> On 10/19/2015 03:39 PM,

Re: [Qemu-devel] [PULL v2 00/49] Misc patches for 2015-10-16

2015-10-19 Thread Peter Maydell
On 19 October 2015 at 09:38, Paolo Bonzini wrote: > The following changes since commit 5451316ed07b758a187dedf21047bed8f843f7f1: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2015-10-12 15:52:54 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [PULL 2/2] xen-platform: Ensure xen is enabled when initializing

2015-10-19 Thread Paolo Bonzini
On 19/10/2015 12:23, Stefano Stabellini wrote: > The xen-platform code crashes on reset if the xen backend is not > initialized, because it calls xc_hvm_set_mem_type(). Ensure xen-platform > won't be created without initializing the xen backend. > > The assert can't be triggered by the user beca

Re: [Qemu-devel] [PATCH] target-*: Advance pc after recognizing a breakpoint

2015-10-19 Thread Sergey Fedorov
On 19.10.2015 01:46, Richard Henderson wrote: > On 10/16/2015 04:08 AM, Sergey Fedorov wrote: >> On 16.10.2015 04:14, Richard Henderson wrote: >>> On 10/16/2015 03:36 AM, Peter Maydell wrote: On 14 October 2015 at 22:02, Richard Henderson wrote: > On 10/15/2015 06:34 AM, Peter Maydel

Re: [Qemu-devel] [PATCH v6 1/4] Add new block driver interface to add/delete a BDS's child

2015-10-19 Thread Alberto Garcia
On Fri 16 Oct 2015 10:57:43 AM CEST, Wen Congyang wrote: > In some cases, we want to take a quorum child offline, and take > another child online. > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Reviewed-by: Eric Blake > --- Reviewed-by: Alberto Garci

[Qemu-devel] [PATCH] qdev: free qemu-opts when the QOM path goes away

2015-10-19 Thread Paolo Bonzini
Otherwise there is a race where the DEVICE_DELETED event has been sent but attempts to reuse the ID will fail. Reported-by: Michael S. Tsirkin Signed-off-by: Paolo Bonzini --- hw/core/qdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c i

Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline.

2015-10-19 Thread Peter Maydell
are available in the git repository at: > > git://git.kraxel.org/qemu tags/pull-fw_cfg-20151019-1 > > for you to fetch changes up to 7b0eec285d447057405df73beae78c8e8aeb9793: > > fw_cfg: Define a static signature to be returned on DMA port reads > (2015-10-19 11:00:50 +0200) > &

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-19 Thread Gerd Hoffmann
Hi, > > I'm trying to follow this discussion as best as I am able, but my lack > > of experience with Xen prevents me from really participating in a > > meaningful way. > > > > (I see that Laszlo is still discussing some CD-ROM issues with Fabio > > which may be of interest to me...) > > > > A

Re: [Qemu-devel] [PATCH 0/3] Add 'blockdev-del' command

2015-10-19 Thread Kevin Wolf
Am 13.10.2015 um 15:48 hat Alberto Garcia geschrieben: > Here's my first attempt at the 'blockdev-del' command. > > This series goes on top of Max's "BlockBackend and media" v6: > > https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg02810.html > > With Max's code, 'blockdev-add' can now cr

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-19 Thread Stefano Stabellini
On Mon, 19 Oct 2015, Gerd Hoffmann wrote: > Hi, > > > > I'm trying to follow this discussion as best as I am able, but my lack > > > of experience with Xen prevents me from really participating in a > > > meaningful way. > > > > > > (I see that Laszlo is still discussing some CD-ROM issues with

Re: [Qemu-devel] [PULL 0/2] Xen 2015-10-19-tag

2015-10-19 Thread Peter Maydell
On 19 October 2015 at 11:23, Stefano Stabellini wrote: > The following changes since commit aedc8806172dd1ae904f04169ee3b19fce1d7893: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-audio-20151019-1' > into staging (2015-10-19 10:06:56 +0100) > > are ava

Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline.

2015-10-19 Thread Kevin O'Connor
On Mon, Oct 19, 2015 at 12:12:34PM +0100, Peter Maydell wrote: > On 19 October 2015 at 10:17, Gerd Hoffmann wrote: > > > > fw_cfg: add dma interface, add strings via cmdline. > > > > --

Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default

2015-10-19 Thread Cornelia Huck
On Sun, 18 Oct 2015 10:59:59 +0300 "Michael S. Tsirkin" wrote: > On Fri, Oct 16, 2015 at 01:07:28PM +0200, Christian Borntraeger wrote: > > Lets keep this patch as is to have scsi=off as default for virtio 1.0 > > > > (some iotests do fail because of this) > > > > Christian > > What fails, ex

Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default

2015-10-19 Thread Michael S. Tsirkin
On Mon, Oct 19, 2015 at 01:53:50PM +0200, Cornelia Huck wrote: > On Sun, 18 Oct 2015 10:59:59 +0300 > "Michael S. Tsirkin" wrote: > > > On Fri, Oct 16, 2015 at 01:07:28PM +0200, Christian Borntraeger wrote: > > > > Lets keep this patch as is to have scsi=off as default for virtio 1.0 > > > > >

Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline.

2015-10-19 Thread Peter Maydell
On 19 October 2015 at 12:52, Kevin O'Connor wrote: > On Mon, Oct 19, 2015 at 12:12:34PM +0100, Peter Maydell wrote: >> Windows fails to compile: >> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c: In function >> ‘fw_cfg_dma_mem_read’: >> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cf

[Qemu-devel] [PATCH v2] target-arm/translate.c: Handle non-executable page-straddling Thumb insns

2015-10-19 Thread Peter Maydell
When the memory we're trying to translate code from is not executable we have to turn this into a guest fault. In order to report the correct PC for this fault, and to make sure it is not reported until after any other possible faults for instructions earlier in execution, we must terminate TBs at

Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline.

2015-10-19 Thread Kevin O'Connor
On Mon, Oct 19, 2015 at 01:02:41PM +0100, Peter Maydell wrote: > On 19 October 2015 at 12:52, Kevin O'Connor wrote: > > On Mon, Oct 19, 2015 at 12:12:34PM +0100, Peter Maydell wrote: > >> Windows fails to compile: > >> /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c: In function > >> ‘fw_c

[Qemu-devel] [PATCH v2] qemu-options: add documentation for using UDP unicast network backend.

2015-10-19 Thread Victor Kaplansky
For the long time QEMU has support for UDP unicast network backend added by commit 0e0e7facc775e9, but manual was missing description and usage examples. Changes from v1: Address comments by Michael S. Tsirkin: - remove superfluous empty lines. - place the note about two QEMU inst

[Qemu-devel] [PATCH 3/3] block/gluster: code cleanup

2015-10-19 Thread Prasanna Kumar Kalever
unified coding styles of multiline function arguments and other error functions moved random declarations of structures and other list variables Signed-off-by: Prasanna Kumar Kalever --- block/gluster.c | 109 ++-- 1 file changed, 59 insertions

[Qemu-devel] [PATCH 2/3] block/gluster: rename [server, volname, image] -> [host, volume, path]

2015-10-19 Thread Prasanna Kumar Kalever
for example in 'servers' tuple values we use 'server' variable for key 'host' in the code, it will be quite messy to have colliding names for variables, so to maintain better readability and makes it consistent with other existing code as well as the input keys/options, this patch renames the follo

Re: [Qemu-devel] [PATCH v2 3/3] virtio-blk: switch off scsi-passthrough by default

2015-10-19 Thread Cornelia Huck
On Mon, 19 Oct 2015 14:57:31 +0300 "Michael S. Tsirkin" wrote: > On Mon, Oct 19, 2015 at 01:53:50PM +0200, Cornelia Huck wrote: > > On Sun, 18 Oct 2015 10:59:59 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Oct 16, 2015 at 01:07:28PM +0200, Christian Borntraeger wrote: > > > > > > Le

Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode

2015-10-19 Thread OGAWA Hirofumi
Gerd Hoffmann writes: > Lets go with v2 of this patch. > > There are some codestyle issues in the patch (and the others too), > please fix them them (scripts/checkpatch.pl helps), then resend the > whole series. OK. I'll send with new thread, not this thread. -- OGAWA Hirofumi

[Qemu-devel] [PATCH v2 1/3] ui/curses: Fix monitor color with -curses when 256 colors

2015-10-19 Thread OGAWA Hirofumi
If TERM=xterm-256color, COLOR_PAIRS==256 and monitor passes chtype like 0x74xx. Then, the code uses uninitialized color pair. As result, monitor uses black for both of fg and bg color, i.e. terminal is filled by black. To fix, this initialize above than 64 with default color (fg=white,bg=black).

Re: [Qemu-devel] [PATCH v6 2/4] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-10-19 Thread Alberto Garcia
On Fri 16 Oct 2015 10:57:44 AM CEST, Wen Congyang wrote: > +static void quorum_add_child(BlockDriverState *bs, BlockDriverState > *child_bs, > + Error **errp) > +{ > +BDRVQuorumState *s = bs->opaque; > +BdrvChild *child; > + > +bdrv_drain(bs); > + > +ass

[Qemu-devel] [PATCH v2 2/3] ui/curses: Support line graphics chars on -curses mode

2015-10-19 Thread OGAWA Hirofumi
This converts vga code to curses code in console_write_bh(). With this changes, we can see line graphics (for example, dialog uses) correctly. Signed-off-by: OGAWA Hirofumi --- include/ui/console.h | 12 +++- ui/curses.c | 44 2

[Qemu-devel] [PATCHv3] fw_cfg: Define a static signature to be returned on DMA port reads

2015-10-19 Thread Kevin O'Connor
Return a static signature ("QEMU CFG") if the guest does a read to the DMA address io register. Signed-off-by: Kevin O'Connor Reviewed-by: Laszlo Ersek Reviewed-by: Stefan Hajnoczi Signed-off-by: Gerd Hoffmann --- Gerd/Marc - if you respin the fw_cfg series, I believe this patch will avoid th

Re: [Qemu-devel] [PULL v3 00/13] qemu-ga patch queue

2015-10-19 Thread Michael Roth
Quoting Peter Maydell (2015-10-18 16:21:30) > On 17 October 2015 at 17:59, Michael Roth wrote: > > Hi Peter, > > > > Please note that 'glib-compat: add 2.38/2.40/2.46 asserts' is also in > > Marc-André's recent ivshmem PULL. The 2 versions of the patches are > > identical, > > but let me know if

Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline.

2015-10-19 Thread Marc Marí
On Mon, 19 Oct 2015 08:12:22 -0400 "Kevin O'Connor" wrote: > On Mon, Oct 19, 2015 at 01:02:41PM +0100, Peter Maydell wrote: > > On 19 October 2015 at 12:52, Kevin O'Connor > > wrote: > > > On Mon, Oct 19, 2015 at 12:12:34PM +0100, Peter Maydell wrote: > > >> Windows fails to compile: > > >> /hom

Re: [Qemu-devel] Question about odd snapshot behaviour

2015-10-19 Thread Kevin Wolf
[ CC: qemu-block ] Am 19.10.2015 um 07:27 hat Sam Bobroff geschrieben: > Hi all, > > While working through the QEMU code that saves and loads snapshots, I've > noticed some confusing behaviour when using named VM snapshots that may need > to > be fixed somehow. This is what I've noticed: > > *

[Qemu-devel] [PATCH v2 3/3] ui/curses: Fix pageup/pagedown on -curses

2015-10-19 Thread OGAWA Hirofumi
Current KEY_NPAGE/KEY_PPAGE handling is broken on -curses. Those uses "GREY", but "KEY_MASK" masked out "GREY". To fix, we have to use correct mask value - SCANCODE_KEYMASK. Then, this adds support of "shift + pageup/pagedown". With this, -curses mode can use scroll-up/down as usual like other di

[Qemu-devel] [PATCH 1/3] block/gluster: add support for multiple gluster servers

2015-10-19 Thread Prasanna Kumar Kalever
This patch adds a way to specify multiple volfile servers to the gluster block backend of QEMU with tcp|rdma transport types and their port numbers. Problem: Currenly VM Image on gluster volume is specified like this: file=gluster[+tcp]://host[:port]/testvol/a.img Assuming we have three hosts i

[Qemu-devel] [PATCH] net: Remove duplicate data from query-rx-filter on multiqueue net devices

2015-10-19 Thread Vladislav Yasevich
When responding to a query-rx-filter command on a multiqueue netdev, qemu reports the data for each queue. The data, however, is not per-queue, but per device and the same data is reported multiple times. This causes confusion and may also cause extra unnecessary processing when looking at the da

[Qemu-devel] [PATCH 1/1] vhost: set the correct queue index in case of migration with multiqueue

2015-10-19 Thread Thibaut Collet
When a live migration is started the log address to mark dirty pages is provided to the vhost backend through the vhost_dev_set_log function. This function is called for each queue pairs but the queue index is wrongly set: always set to the first queue pair. Then vhost backend lost descriptor addre

[Qemu-devel] [PATCH 0/1] vhost-user: support of live migration with multiqueue

2015-10-19 Thread Thibaut Collet
Patches serie for vhost-user live migration from Marc-Andre Lureau [PATCH v8 00/27] vhost-user: add migration support (http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg02452.html) does not work if multiqueue is set. This patch correct an issue of queue index when a migration is started wi

Re: [Qemu-devel] What's the intended use of log.h logging?

2015-10-19 Thread Markus Armbruster
Peter Maydell writes: > On 16 October 2015 at 15:17, Paolo Bonzini wrote: >> On 16/10/2015 15:36, Peter Maydell wrote: We could add "-d trace:help" to list valid tracepoint names. >>> >>> I think people are mostly going to care about categories >>> (eg "enable tracing for device X", or "ena

Re: [Qemu-devel] [PATCH QEMU] target-arm: Add support for SPSR_(ABT|UND|IRQ|FIQ)

2015-10-19 Thread Peter Maydell
On 15 October 2015 at 05:41, Soren Brinkmann wrote: > Signed-off-by: Soren Brinkmann > --- > Hi, > > I recently came across some code that caused undefined instruction exceptions > when executing instructions 'mrs x11, spsr_abt' and the like. I'm not > sure I > get the full picture, but it s

Re: [Qemu-devel] What's the intended use of log.h logging?

2015-10-19 Thread Paolo Bonzini
On 19/10/2015 15:17, Markus Armbruster wrote: > This is at least as much an argument for use of tracing as against it. > Tracing is a lot more flexible than log.h, and with the right backend, > it's much more efficient, too. > > If the appropriate trace patterns turn out to be too hard to rememb

Re: [Qemu-devel] [PATCH v8 00/27] vhost-user: add migration support

2015-10-19 Thread Thibaut Collet
On Sun, Oct 18, 2015 at 10:21 AM, Michael S. Tsirkin wrote: > > On Tue, Oct 13, 2015 at 02:19:41PM +0200, Thibaut Collet wrote: > > Hi, > > > > I have still a comment on this serie. During rebase operation with > > multiqueue a > > modification has been lost. > > This lost impact only guest witho

Re: [Qemu-devel] [PULL 08/14] net: merge qemu_deliver_packet and qemu_deliver_packet_iov

2015-10-19 Thread Paolo Bonzini
On 12/10/2015 10:17, Jason Wang wrote: > static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov, > - int iovcnt) > + int iovcnt, unsigned flags) > { > -uint8_t buffer[NET_BUFSIZE]; > +uint8_t buf[NET_BUFSIZE

Re: [Qemu-devel] [PULL 11/14] netfilter: print filter info associate with the netdev

2015-10-19 Thread Paolo Bonzini
On 12/10/2015 10:17, Jason Wang wrote: > +} > +QTAILQ_FOREACH(nf, &nc->filters, next) { > +monitor_printf(mon, " - %s: type=%s%s\n", > + object_get_canonical_path_component(OBJECT(nf)), The value returned from object_get_canonical_path_component must be fre

Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline.

2015-10-19 Thread Gerd Hoffmann
Hi > > Windows fails to compile: > > /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c: In function > > ‘fw_cfg_dma_mem_read’: > > /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c:406: warning: > > integer constant is too large for ‘long’ type > > I don't have a Windows test enviro

Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline.

2015-10-19 Thread Gerd Hoffmann
Hi, > Yes, that's the solution. We updated the version number, and the test > expects exclusively version 1. Fixed that. Patch updated, tests running, updated pull soon. > And it would also be nice to update the > test to test also fw_cfg DMA Patch for that is welcome. thanks, Gerd

[Qemu-devel] qemu-guest-agent question

2015-10-19 Thread Vasiliy Tolstov
I'm try to understand sources of qga and have a question- does agent execute commands synchronous or if i'm send firstly long running command and after that send short lived command, short lived command response can be sended before first command result? Thanks! -- Vasiliy Tolstov, e-mail: v.to

Re: [Qemu-devel] Question about xen disk unplug support for ahci missed in qemu

2015-10-19 Thread Fabio Fantoni
Il 16/10/2015 18:53, Paul Durrant ha scritto: -Original Message- From: Kevin Wolf [mailto:kw...@redhat.com] Sent: 16 October 2015 17:43 To: Paul Durrant Cc: Fabio Fantoni; Stefano Stabellini; John Snow; Anthony Perard; qemu- de...@nongnu.org; xen-de...@lists.xen.org; qemu-bl...@nongnu.org

Re: [Qemu-devel] [PATCH v2 00/16] Introduce I/O channels framework

2015-10-19 Thread Daniel P. Berrange
Ping, does anyone feel like doing a review of this series, if not I'll just do a pull request as-is... Daniel On Mon, Oct 12, 2015 at 12:14:53PM +0100, Daniel P. Berrange wrote: > This series of patches is a followup submission for review of another > chunk of my large series supporting TLS acros

Re: [Qemu-devel] What's the intended use of log.h logging?

2015-10-19 Thread Peter Maydell
On 19 October 2015 at 14:17, Markus Armbruster wrote: > Peter Maydell writes: >> In a lot of cases, especially with the TCG logging, not enabling >> voluminous tracing is really important because if you turn it all >> on then the system is way too slow (and can behave differently >> as a result),

Re: [Qemu-devel] [PULL 0/7] fw_cfg: add dma interface, add strings via cmdline.

2015-10-19 Thread Peter Maydell
On 19 October 2015 at 14:29, Gerd Hoffmann wrote: > Hi > >> > Windows fails to compile: >> > /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c: In function >> > ‘fw_cfg_dma_mem_read’: >> > /home/petmay01/linaro/qemu-for-merges/hw/nvram/fw_cfg.c:406: warning: >> > integer constant is too la

[Qemu-devel] [PATCH] target-alpha: fix uninitialized variable

2015-10-19 Thread Paolo Bonzini
I am not sure why the compiler does not catch it. There is no semantic change since gen_excp returns EXIT_NORETURN, but the old code is wrong. Reported by Coverity. Signed-off-by: Paolo Bonzini --- target-alpha/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tar

[Qemu-devel] [PATCH] bt: fix use of uninitialized variable seqlen

2015-10-19 Thread Paolo Bonzini
sdp_svc_match, sdp_attr_match and sdp_svc_attr_match read the last argument. The only sensible way to change the code is to make that last argument "len" instead of "seqlen" which is the length of a subsequence in the previous "if" branch. To make the structure of the code clearer, use "else" ins

[Qemu-devel] [PATCH] xen: fix invalid assertion

2015-10-19 Thread Paolo Bonzini
Asserting "true" is not that useful. Reported by Coverity. Signed-off-by: Paolo Bonzini --- hw/xen/xen_pt_config_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c index 4a5bc11..f6969ad 100644 --- a/hw/xen/xe

Re: [Qemu-devel] [PATCH v2 00/16] Introduce I/O channels framework

2015-10-19 Thread Paolo Bonzini
On 19/10/2015 15:47, Daniel P. Berrange wrote: > Ping, does anyone feel like doing a review of this series, if not I'll > just do a pull request as-is... You can certainly do a pull request of patches 1-7. For 8-16, I haven't reviewed it because I'm not sure how much it makes sense to commit QI

Re: [Qemu-devel] [PATCH 0/3] Add 'blockdev-del' command

2015-10-19 Thread Alberto Garcia
On Mon 19 Oct 2015 01:27:45 PM CEST, Kevin Wolf wrote: > I've been thinking a bit about the creation and deletion of > BlockBackends a bit last week, and honestly it still feels a bit messy > (or maybe I just don't fully understand it yet). Anyway, the cover > letter of this series seems to be a go

Re: [Qemu-devel] [PATCH v6 18/39] block: Add BlockBackendRootState

2015-10-19 Thread Kevin Wolf
Am 12.10.2015 um 22:00 hat Max Reitz geschrieben: > This structure will store some of the state of the root BDS if the BDS > tree is removed, so that state can be restored once a new BDS tree is > inserted. > > Signed-off-by: Max Reitz Random thought, not directly related to this series: We cur

  1   2   3   4   >