On Mon, Oct 19, 2015 at 01:53:50PM +0200, Cornelia Huck wrote: > On Sun, 18 Oct 2015 10:59:59 +0300 > "Michael S. Tsirkin" <m...@redhat.com> wrote: > > > On Fri, Oct 16, 2015 at 01:07:28PM +0200, Christian Borntraeger wrote: > > > > Lets keep this patch as is to have scsi=off as default for virtio 1.0 > > > > > > (some iotests do fail because of this) > > > > > > Christian > > > > What fails, exactly? > > For example, testcase 068 (on s390x, since we default virtio-1 to on):
I see, thanks. So it's just the assertion that we have in code that fires. Sure, scsi must be off by default before virtio 1 is on. > --- /data/git/yyy/qemu/tests/qemu-iotests/068.out 2015-03-09 > 12:32:35.245444052 +0100 > +++ 068.out.bad 2015-10-19 13:48:00.023772655 +0200 > @@ -3,9 +3,8 @@ > === Saving and reloading a VM state to/from a qcow2 image === > > Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=131072 > +qemu-system-s390x: -hda > /data/git/yyy/qemu/build/tests/qemu-iotests/scratch/t.qcow2: Please set > scsi=off for virtio-blk devices in order to use virtio 1.0 > QEMU X.Y.Z monitor - type 'help' for more information > -(qemu) savevm 0 > -(qemu) quit > +(qemu) qemu-system-s390x: -hda > /data/git/yyy/qemu/build/tests/qemu-iotests/scratch/t.qcow2: Please set > scsi=off for virtio-blk devices in order to use virtio 1.0 > QEMU X.Y.Z monitor - type 'help' for more information > -(qemu) quit > -*** done > +(qemu) *** done
