[Qemu-devel] [PATCH v2 3/3] qapi: support nested structs in OptsVisitor

2015-09-23 Thread Kővágó, Zoltán
The current OptsVisitor flattens the whole structure, if there are same named fields under different paths (like `in' and `out' in `Audiodev'), the current visitor can't cope with them (for example setting `frequency=44100' will set the in's frequency to 44100 and leave out's frequency unspecified)

[Qemu-devel] [PATCH v2 0/2] Split up ram_find_and_save_block

2015-09-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Chop up ram_find_and_save_block so it's smaller again. (from comments on my postcopy patch that adds more to it). This pair is based on top of my previous 5 patch cleanup series posted in August, but rebased on current qemu master. Dave Dr. David Alan Gilbert (2

[Qemu-devel] [PATCH v2 2/2] ram_find_and_save_block: Split out the finding

2015-09-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Split out the finding of the dirty page and all the wrap detection into a separate function since it was getting a bit hairy. Signed-off-by: Dr. David Alan Gilbert --- migration/ram.c | 84 - 1 file changed,

[Qemu-devel] [PATCH v2 2/3] qapi: change NetLegacy into a flat union

2015-09-23 Thread Kővágó, Zoltán
This is required to keep backward compatibility while applying the proposed changes to OptsVisitor in the next commit. Strictly speaking this change breaks QMP compatibility, but since this struct is only used by the (legacy) -net option, it's not a problem. (The command line syntax doesn't change

Re: [Qemu-devel] [RFC PATCH 03/10] vfio: Check guest IOVA ranges against host IOMMU capabilities

2015-09-23 Thread Laurent Vivier
On 17/09/2015 15:09, David Gibson wrote: > The current vfio core code assumes that the host IOMMU is capable of > mapping any IOVA the guest wants to use to where we need. However, real > IOMMUs generally only support translating a certain range of IOVAs (the > "DMA window") not a full 64-bit ad

Re: [Qemu-devel] [RFC PATCH 04/10] vfio: Record host IOMMU's available IO page sizes

2015-09-23 Thread Laurent Vivier
On 17/09/2015 15:09, David Gibson wrote: > Depending on the host IOMMU type we determine and record the available page > sizes for IOMMU translation. We'll need this for other validation in > future patches. > > Signed-off-by: David Gibson > --- > hw/vfio/common.c | 13 ++

Re: [Qemu-devel] [PATCH v2 4/7] device-introspect-test: New, covering device introspection

2015-09-23 Thread Eric Blake
On 09/23/2015 08:09 AM, Markus Armbruster wrote: > The test doesn't check that the output makes any sense, only that QEMU > survives. Useful since we've had an astounding number of crash bugs > around there. > > In fact, we have a bunch of them right now: several devices crash or > hang, and all

[Qemu-devel] [PATCH v2 1/2] Move dirty page search state into separate structure

2015-09-23 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Pull the search state for one iteration of the dirty page search into a structure. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah --- migration/ram.c | 55 +++ 1 file changed, 35 insertions(+), 20

Re: [Qemu-devel] [PATCH v2 1/3] qapi: convert NumaOptions into a flat union

2015-09-23 Thread Eric Blake
On 09/23/2015 08:27 AM, Kővágó, Zoltán wrote: > Changes the NumaOptions to flat union from a simple one. This is > required by my later OptsVisitor patch to preserve backward > compatibility. > > Strictly speaking this would break QMP compatibility (as specified in > docs/qapi-code-gen.txt), but

Re: [Qemu-devel] [PATCH] hw/arm/virt: smbios: inform guest of kvm

2015-09-23 Thread Wei Huang
On 9/23/15 09:18, Andrew Jones wrote: > ARM/AArch64 KVM guests don't have any way to identify > themselves as KVM guests (x86 guests use a CPUID leaf). Now, we > could discuss all sorts of reasons why guests shouldn't need to > know that, but then there's always some case where it'd be One examp

Re: [Qemu-devel] [PATCH 05/16] block: Convert bs->file to BdrvChild

2015-09-23 Thread Alberto Garcia
On Thu 17 Sep 2015 03:48:09 PM CEST, Kevin Wolf wrote: > @@ -1929,6 +1925,11 @@ void bdrv_close(BlockDriverState *bs) > bdrv_unref(backing_hd); > } > > +if (bs->file != NULL) { > +bdrv_unref(bs->file->bs); > +bs->file = NULL; > +} > +

Re: [Qemu-devel] [PATCH v3 05/25] tcg: Allow extra data to be attached to insn_start

2015-09-23 Thread Kevin O'Connor
On Tue, Sep 22, 2015 at 01:24:47PM -0700, Richard Henderson wrote: > With an eye toward having this data replace the gen_opc_* arrays > that each target collects in order to enable restore_state_from_tb. Hi Richard, Instead of having each architecture front-end determine the constants to be resto

Re: [Qemu-devel] [PATCH v3 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-09-23 Thread Peter Krempa
On Tue, Sep 22, 2015 at 04:06:54 -0400, Prasanna Kalever wrote: > > > On 09/21/2015 05:24 AM, Prasanna Kumar Kalever wrote: > > > This patch adds a way to specify multiple backup volfile servers to the > > > gluster > > > block backend of QEMU with tcp|rdma transport types and their port > > > nu

[Qemu-devel] [PATCH] pc: Set broken_reserved_end on pc-*-2.4, not 2.5

2015-09-23 Thread Eduardo Habkost
Version 1 of the pc-*-2.5 machine class series was applied to the PCI tree instead of v3 (which was rebased after the broken_reserved_end patch by Igor was included). This patch includes the missing hunks from v3, to make sure broken_reserved_end is set at the right machine class. Signed-off-by:

Re: [Qemu-devel] [PATCH v5 01/46] qapi: Sort qapi-schema tests

2015-09-23 Thread Markus Armbruster
Eric Blake writes: > On 09/21/2015 03:57 PM, Eric Blake wrote: >> Recent changes to qapi have provided quite a bit of churn in >> the makefile, because we are inconsistent on what order test >> names appear in, and on whether to re-wrap the list of tests or >> just add arbitrary line lengths. Wr

Re: [Qemu-devel] [PATCH v5 03/46] qapi: Test for C member name collisions

2015-09-23 Thread Markus Armbruster
Eric Blake writes: > On 09/23/2015 08:02 AM, Markus Armbruster wrote: > >>> However, I'm not sure it would always help. The conversion of >>> netdev_add to full qapi relies on being able to access the variant >>> through a named struct (such as NetdevTapOptions); unboxing the variant >>> would g

Re: [Qemu-devel] [PATCH v2] docs: describe the QEMU build system structure / design

2015-09-23 Thread John Snow
On 09/23/2015 05:59 AM, Daniel P. Berrange wrote: > Developers who are new to QEMU, or have a background familiarity > with GNU autotools, can have trouble getting their head around the > home-grown QEMU build system. This document attempts to explain > the structure / design of the configure scr

Re: [Qemu-devel] [PATCH v5 01/46] qapi: Sort qapi-schema tests

2015-09-23 Thread Eric Blake
On 09/23/2015 09:09 AM, Markus Armbruster wrote: > Eric Blake writes: > >> On 09/21/2015 03:57 PM, Eric Blake wrote: >>> Recent changes to qapi have provided quite a bit of churn in >>> the makefile, because we are inconsistent on what order test >>> names appear in, and on whether to re-wrap the

[Qemu-devel] Loading image/elf to cpu that has different not system memory address space

2015-09-23 Thread Marcin Krzemiński
Hello, I am trying to write a model of embedded board that have corterx-m3 and cotex a9 processors. Because M3 see different memory at address 0x0 than A9 (m3 has small rom, a9 has whole ram) I created different address space for m3 (thanks Peter Crosthwaite! for hints how to do this!). Now I stac

[Qemu-devel] [Bug 1498144] Re: Failure booting hurd with qemu-system-i386 on ARM

2015-09-23 Thread PeteVine
I can't get any more useful info - either the script is expecting some outdated version of python or there's simply nothing else to see cause qemu failed to start. For example: (gdb) source qemu-gdb.py (gdb) run Starting program: /usr/bin/qemu-system-i386 -m 512 -hda /media/odroid/debian-hurd-20

[Qemu-devel] [PATCH] spice-qemu-char: do not use port device when it is not active

2015-09-23 Thread Pavel Grunt
Avoid segmentation fault when the webdav channel (spice port channel) is used with the vnc display: #0 0x77ab2594 in spice_char_device_state_opaque_get (dev=0x0) at char_device.c:700 #1 0x77b0def3 in spice_server_port_event (sin=, event=) at spicevmc.c:572 #2 0x55781

Re: [Qemu-devel] [PATCH 08/16] block: Manage backing file references in bdrv_set_backing_hd()

2015-09-23 Thread Max Reitz
On 17.09.2015 15:48, Kevin Wolf wrote: > This simplifies the code somewhat, especially when dropping whole > backing file subchains. > > The exception is the mirroring code that does adventurous things with > bdrv_swap() and in order to keep it working, I had to duplicate most of > bdrv_set_backin

Re: [Qemu-devel] [PATCH 10/16] block/io: Make bdrv_requests_pending() public

2015-09-23 Thread Max Reitz
On 17.09.2015 15:48, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/io.c| 2 +- > include/block/block_int.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz In addition: Shouldn't we iterate over all children in that function instead

[Qemu-devel] [PULL] remove libcacard

2015-09-23 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 27c7275a56948f48f536e2d1599b22355f5714ac: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ipxe-20150903-1' into staging (2015-09-22 19:22:23 +0100) are available in the git repository at: https://github.com/elmarco/qemu tag

Re: [Qemu-devel] [PATCH v5 45/46] net: Complete qapi-fication of netdev_add

2015-09-23 Thread Paolo Bonzini
On 21/09/2015 23:58, Eric Blake wrote: > We finally have all the required pieces for doing a type-safe > representation of netdev_add as a flat union, where the > discriminator 'type' now selects which additional members may > appear in the "arguments" JSON object sent over QMP, while > making no

Re: [Qemu-devel] qemu-system-arm system support for big endian BE8

2015-09-23 Thread Peter Maydell
On 23 September 2015 at 03:48, sridhar kulkarni wrote: > Hi Peter, > > I was able to progress well using the BE8 work in the branch that you > pointed out. I am experiencing floating point issue. The qemu just exits, by > putting a message that "floating point exception(core dumped)". I suppose >

Re: [Qemu-devel] [PATCH v3 17/46] ivshmem: improve debug messages

2015-09-23 Thread Marc-André Lureau
Hi On Wed, Sep 23, 2015 at 2:10 PM, Claudio Fontana wrote: >> Let's change it for IVSHMEM_DPRINTF("use msix, present: %d\n", >> msix_present(d)); ok? >> > > what about something like > > IVSHMEM_DPRINTF("%susing MSI-X\n", msix_present(d) ? "" : "not "); > > or just > > if (!msix_present(d) { >

Re: [Qemu-devel] Loading image/elf to cpu that has different not system memory address space

2015-09-23 Thread Peter Maydell
On 23 September 2015 at 08:17, Marcin Krzemiński wrote: > Hello, > > I am trying to write a model of embedded board that have corterx-m3 and > cotex a9 processors. > Because M3 see different memory at address 0x0 than A9 (m3 has small rom, a9 > has whole ram) I created different address space for

Re: [Qemu-devel] [PATCH] hw/arm/virt: smbios: inform guest of kvm

2015-09-23 Thread Peter Maydell
On 23 September 2015 at 07:18, Andrew Jones wrote: > ARM/AArch64 KVM guests don't have any way to identify > themselves as KVM guests (x86 guests use a CPUID leaf). Now, we > could discuss all sorts of reasons why guests shouldn't need to > know that, but then there's always some case where it'd b

Re: [Qemu-devel] [PATCH v2] docs: describe the QEMU build system structure / design

2015-09-23 Thread Laszlo Ersek
On 09/23/15 17:46, Laszlo Ersek wrote: > before, and Jon commented that you probably pronounced it as "a dot-exe Aaargh, John <-> Jon drives me crazy. Sorry. Laszlo

Re: [Qemu-devel] [PATCH v2] docs: describe the QEMU build system structure / design

2015-09-23 Thread Laszlo Ersek
I diffed this version against v1. Thank you for addressing my comments too; however I found some newly introduced typos: On 09/23/15 11:59, Daniel P. Berrange wrote: > +The utility code that is used by all binaries is built into a > +static archive called libqemuutil.a, which is then linked to al

Re: [Qemu-devel] [PATCH 11/16] block-backend: Add blk_set_bs()

2015-09-23 Thread Max Reitz
On 17.09.2015 15:48, Kevin Wolf wrote: > It allows changing the BlockDriverState that a BlockBackend points to. > > Signed-off-by: Kevin Wolf > --- > block/block-backend.c | 16 > include/block/block_int.h | 2 ++ > 2 files changed, 18 insertions(+) > > diff --git a/block/

Re: [Qemu-devel] [Bug 1498144] Re: Failure booting hurd with qemu-system-i386 on ARM

2015-09-23 Thread Laszlo Ersek
On 09/23/15 17:13, PeteVine wrote: > I can't get any more useful info - either the script is expecting some > outdated version of python or there's simply nothing else to see cause > qemu failed to start. > > For example: > > (gdb) source qemu-gdb.py > (gdb) run > Starting program: /usr/bin/qemu-

Re: [Qemu-devel] [PATCH 11/16] block-backend: Add blk_set_bs()

2015-09-23 Thread Kevin Wolf
Am 23.09.2015 um 17:46 hat Max Reitz geschrieben: > On 17.09.2015 15:48, Kevin Wolf wrote: > > It allows changing the BlockDriverState that a BlockBackend points to. > > > > Signed-off-by: Kevin Wolf > > --- > > block/block-backend.c | 16 > > include/block/block_int.h | 2

Re: [Qemu-devel] [PATCH v2] docs: describe the QEMU build system structure / design

2015-09-23 Thread John Snow
On 09/23/2015 11:46 AM, Laszlo Ersek wrote: > I diffed this version against v1. Thank you for addressing my comments > too; however I found some newly introduced typos: > > On 09/23/15 11:59, Daniel P. Berrange wrote: > >> +The utility code that is used by all binaries is built into a >> +stati

Re: [Qemu-devel] [PATCH] target-arm: Implement AArch64 OSLSR_EL1 sysreg dummy

2015-09-23 Thread Peter Maydell
On 22 September 2015 at 11:35, Davorin Mista wrote: > Define a dummy version of the AArch64 OSLAR_EL1 system register Should read "OSLSR_EL1" :-) > which just ignores reads. > Linux reads from this register during its suspend/resume procedure. > Signed-off-by: Davorin Mista > > --- > target-a

Re: [Qemu-devel] [PATCH] MAINTAINERS: update Allwinner A10 maintainer

2015-09-23 Thread Peter Maydell
On 21 September 2015 at 12:52, Beniamino Galvani wrote: > Change the maintainer for Allwinner A10 to myself as Li Guang's mail > address bounces. While at it, extend the file pattern for the entry to > include allwinner_emac.[ch]. > > Signed-off-by: Beniamino Galvani > --- > MAINTAINERS | 6 +++-

Re: [Qemu-devel] [PATCH] hw/arm/virt: smbios: inform guest of kvm

2015-09-23 Thread Peter Maydell
On 23 September 2015 at 08:43, Peter Maydell wrote: > On 23 September 2015 at 07:18, Andrew Jones wrote: >> ARM/AArch64 KVM guests don't have any way to identify >> themselves as KVM guests (x86 guests use a CPUID leaf). Now, we >> could discuss all sorts of reasons why guests shouldn't need to >

Re: [Qemu-devel] [PATCH v7 11/14] block/backup: support block job transactions

2015-09-23 Thread John Snow
On 09/23/2015 07:09 AM, Markus Armbruster wrote: > John, your MUA turned the QMP examples to mush. You may want to teach > it manners. > Ugh, sorry. I apparently can't trust > John Snow writes: > >> On 09/22/2015 06:34 PM, Eric Blake wrote: >>> On 09/22/2015 03:08 PM, John Snow wrote:

[Qemu-devel] [PATCH] iotests: disable core dumps in test 061

2015-09-23 Thread Alberto Garcia
Commit 934659c460 disabled the supression of segmentation faults in bash tests. The new output of test 061, however, assumes that a core dump will be produced if a program aborts. This is not necessarily the case because core dumps can be disabled using ulimit. We cannot guarantee that core dumps

Re: [Qemu-devel] [PATCH RFC 1/8] target-arm: Add HPFAR_EL2

2015-09-23 Thread Peter Maydell
On 19 September 2015 at 07:15, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h| 1 + > target-arm/helper.c | 7 +++ > 2 files changed, 8 insertions(+) > > diff --git a/target-arm/cpu.h b/target-arm/cpu.h > index 1b80516.

Re: [Qemu-devel] [RFC PATCH 05/10] memory: Allow replay of IOMMU mapping notifications

2015-09-23 Thread Laurent Vivier
On 23/09/2015 12:40, Thomas Huth wrote: > On 17/09/15 15:09, David Gibson wrote: >> When we have guest visible IOMMUs, we allow notifiers to be registered >> which will be informed of all changes to IOMMU mappings. This is used by >> vfio to keep the host IOMMU mappings in sync with guest IOMMU

Re: [Qemu-devel] [PATCH RFC 2/8] target-arm: Add computation of starting level for S2 PTW

2015-09-23 Thread Peter Maydell
On 19 September 2015 at 07:15, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > The starting level for S2 pagetable walks is computed > differently from the S1 starting level. Implement the S2 > variant. > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/helper.c | 32 +

Re: [Qemu-devel] [PATCH 09/16] block: Split bdrv_move_feature_fields()

2015-09-23 Thread Max Reitz
On 17.09.2015 15:48, Kevin Wolf wrote: > After bdrv_swap(), some fields must be moved back to their original BDS > to compensate for the effects that a swap of the contents of the objects > has while keeping the old addresses. Other fields must be moved back > because they should logically be moved

Re: [Qemu-devel] [PATCH v3 05/25] tcg: Allow extra data to be attached to insn_start

2015-09-23 Thread Richard Henderson
On 09/23/2015 07:55 AM, Kevin O'Connor wrote: > On Tue, Sep 22, 2015 at 01:24:47PM -0700, Richard Henderson wrote: >> With an eye toward having this data replace the gen_opc_* arrays >> that each target collects in order to enable restore_state_from_tb. > > Hi Richard, > > Instead of having each

Re: [Qemu-devel] [PATCH v5 45/46] net: Complete qapi-fication of netdev_add

2015-09-23 Thread Eric Blake
On 09/23/2015 09:40 AM, Paolo Bonzini wrote: > > > On 21/09/2015 23:58, Eric Blake wrote: >> We finally have all the required pieces for doing a type-safe >> representation of netdev_add as a flat union, where the >> discriminator 'type' now selects which additional members may >> appear in the "

Re: [Qemu-devel] [PATCH 13/16] block: Implement bdrv_append() without bdrv_swap()

2015-09-23 Thread Max Reitz
On 17.09.2015 15:48, Kevin Wolf wrote: > Remember all parent nodes and just change the pointers there instead of > swapping the contents of the BlockDriverState. > > Handling of snapshot=on must be moved further down in bdrv_open() > because *pbs (which is the bs pointer in the BlockBackend) must

Re: [Qemu-devel] [PATCH v3 05/25] tcg: Allow extra data to be attached to insn_start

2015-09-23 Thread Richard Henderson
On 09/23/2015 07:55 AM, Kevin O'Connor wrote: > On Tue, Sep 22, 2015 at 01:24:47PM -0700, Richard Henderson wrote: >> With an eye toward having this data replace the gen_opc_* arrays >> that each target collects in order to enable restore_state_from_tb. > > Hi Richard, > > Instead of having each

Re: [Qemu-devel] [PATCH 12/16] block: Introduce parents list

2015-09-23 Thread Max Reitz
On 17.09.2015 15:48, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block.c | 3 +++ > include/block/block_int.h | 2 ++ > 2 files changed, 5 insertions(+) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH v7 33/42] postcopy_ram.c: place_page and helpers

2015-09-23 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > postcopy_place_page (etc) provide a way for postcopy to place a page > > into guests memory atomically (using the copy ioctl on the ufd). > > > > Signed-off-by: Dr. Davi

[Qemu-devel] [Bug 1463172] Re: destination arm board hangs after migration from x86 source

2015-09-23 Thread Chris J Arges
** Changed in: qemu (Ubuntu) Importance: Undecided => Low -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1463172 Title: destination arm board hangs after migration from x86 source Status in QEMU

Re: [Qemu-devel] [PATCH 14/16] blockjob: Store device name at job creation

2015-09-23 Thread Max Reitz
On 17.09.2015 15:48, Kevin Wolf wrote: > Some block jobs change the block device graph on completion. This means > that the device that owns the job and originally was addressed with its > device name may no longer be what the corresponding BlockBackend points > to. > > Previously, the effects of

Re: [Qemu-devel] [PATCH v2] docs: describe the QEMU build system structure / design

2015-09-23 Thread Eric Blake
On 09/23/2015 09:52 AM, John Snow wrote: >>> +Windows platform portability >>> + >>> + >>> +On Windows all binaries have a 'exe' suffix, so all the Makefile rules >> >> This was >> >> "a .exe suffix" >> >> before, and Jon commented that you probably pronounced it as "

[Qemu-devel] [Bug 1463172] Re: destination arm board hangs after migration from x86 source

2015-09-23 Thread Serge Hallyn
Hi, would it be possible to run the emulator on arm under gdb (with debugging symbols intalled), do the incoming migration, and then when it hangs, show a backtrace from gdb? ** Changed in: qemu (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a me

Re: [Qemu-devel] [RFC PATCH 00/10] pseries: Allow VFIO devices on spapr-pci-host-bridge

2015-09-23 Thread Laurent Vivier
On 17/09/2015 15:09, David Gibson wrote: > Currently the pseries machine type uses two types of PCI Host Bridge > (PHB) devices: "spapr-pci-host-bridge" the 'normal' variant intended > for emulated PCI devices, and "spapr-pci-vfio-host-bridge" intended > for VFIO devices. > > When using VFIO wit

Re: [Qemu-devel] [PATCH RFC 3/8] target-arm: Add support for S2 page-table protection bits

2015-09-23 Thread Peter Maydell
On 19 September 2015 at 07:15, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/helper.c | 48 +--- > 1 file changed, 45 insertions(+), 3 deletions(-) > > diff --git a/target-arm/helper.c b/t

[Qemu-devel] [Bug 1042388] Re: qemu: Unsupported syscall: 257 (timer_create)

2015-09-23 Thread Serge Hallyn
@erikd, can you check whether this has been fixed in wily? ** Changed in: qemu (Ubuntu) Status: Triaged => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1042388 Title: qemu: U

Re: [Qemu-devel] [PATCH RFC 4/8] target-arm: Avoid inline for get_phys_addr

2015-09-23 Thread Peter Maydell
On 19 September 2015 at 07:15, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Avoid inline for get_phys_addr() to prepare for future recursive use. Does the compiler actually complain? In any case this function is a lot more complex than it used to be so we might as well just rely on

[Qemu-devel] [Bug 1486278] Re: 'info vnc' monitor command does not show websocket information

2015-09-23 Thread Serge Hallyn
** Changed in: qemu (Ubuntu) Status: New => Confirmed ** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1486278 Title: 'info vn

Re: [Qemu-devel] [PATCH RFC 5/8] target-arm: Add ARMMMUFaultInfo

2015-09-23 Thread Peter Maydell
On 19 September 2015 at 07:15, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Introduce ARMMMUFaultInfo to propagate MMU Fault information > across the MMU translation code path. This is in preparation for > adding State-2 translation. > > No functional changes. > > Signed-off-by: Edgar

Re: [Qemu-devel] [PATCH v7 23/42] MIGRATION_STATUS_POSTCOPY_ACTIVE: Add new migration state

2015-09-23 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: > On (Tue) 16 Jun 2015 [11:26:36], Dr. David Alan Gilbert (git) wrote: > > > -if (s->state == MIGRATION_STATUS_ACTIVE || > > -s->state == MIGRATION_STATUS_SETUP) { > > +if (migration_already_active(s)) { > > (I know, not introduced here, b

[Qemu-devel] Virtio device "exit" function

2015-09-23 Thread Chris Johnson
Hello, I am working on adding a virtio device to support a PCIe card (PCIe pass-through wasn't an option). I need to do some cleanup when a VM that is using this device is shutdown. It doesn't seem like the device_unrealize function runs on shutdown unlike the device_realize function that run

Re: [Qemu-devel] [RFC PATCH 05/10] memory: Allow replay of IOMMU mapping notifications

2015-09-23 Thread Laurent Vivier
On 17/09/2015 15:09, David Gibson wrote: > When we have guest visible IOMMUs, we allow notifiers to be registered > which will be informed of all changes to IOMMU mappings. This is used by > vfio to keep the host IOMMU mappings in sync with guest IOMMU mappings. > > However, unlike with a memor

Re: [Qemu-devel] [PATCH 15/16] block: Add and use bdrv_replace_in_backing_chain()

2015-09-23 Thread Max Reitz
On 17.09.2015 15:48, Kevin Wolf wrote: > This cleans up the mess we left behind in the mirror code after the > previous patch. Instead of using bdrv_swap(), just change pointers. > > The interface change of the mirror job that callers must consider is > that after job completion, their local BDS p

Re: [Qemu-devel] [PATCH 16/16] block: Remove bdrv_swap()

2015-09-23 Thread Max Reitz
On 17.09.2015 15:48, Kevin Wolf wrote: > bdrv_swap() is unused now. Remove it and all functions that have > no other users than bdrv_swap(). In particular, this removes the > .bdrv_rebind callbacks from block drivers. > > Signed-off-by: Kevin Wolf > --- > block.c | 155 > +

Re: [Qemu-devel] [PATCH v2 1/3] qapi: convert NumaOptions into a flat union

2015-09-23 Thread Kővágó Zoltán
2015-09-23 16:40 keltezéssel, Eric Blake írta: On 09/23/2015 08:27 AM, Kővágó, Zoltán wrote: Changes the NumaOptions to flat union from a simple one. This is required by my later OptsVisitor patch to preserve backward compatibility. Strictly speaking this would break QMP compatibility (as spec

Re: [Qemu-devel] [PATCH RFC 0/8] arm: Steps towards EL2 support round 5

2015-09-23 Thread Peter Maydell
On 19 September 2015 at 07:15, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Hi, > > Another round of patches towards EL2 support. This one adds partial > support for 2-stage MMU for AArch64. I've marked it RFC because I > expect a few iterations. Once we can settle on the approach I'l

[Qemu-devel] [Bug 1336801] Re: 12.04 guest hangs on a 14.04 host server with cirrus graphics

2015-09-23 Thread Stefan Bader
The errors about the frame buffer device happen because grub is started in graphical mode and then the boot wants to replace the framebuffer device/driver while plymouth still holds it. I thought we should have fixed this before release by adding cirrus to the list of graphics that should get in

[Qemu-devel] [Bug 1350435] Re: tcg.c:1693: tcg fatal error

2015-09-23 Thread Serge Hallyn
This patch is still not applied upstream. As there has been no discussion in over a year, I assume it is no longer a problem and I'm going to mark it invalid. Please rep;ly if that is not the case. If it *is* still a problem, then we should go discuss on oftc#qemu. ** Changed in: qemu (Ubuntu)

Re: [Qemu-devel] [PATCH] iotests: disable core dumps in test 061

2015-09-23 Thread Max Reitz
On 23.09.2015 18:11, Alberto Garcia wrote: > Commit 934659c460 disabled the supression of segmentation faults in > bash tests. The new output of test 061, however, assumes that a core > dump will be produced if a program aborts. This is not necessarily the > case because core dumps can be disabled

Re: [Qemu-devel] [PULL 00/36] spapr-next queue 20150923

2015-09-23 Thread Peter Maydell
ble in the git repository at: > > git://github.com/dgibson/qemu.git tags/spapr-next-20150923 > > for you to fetch changes up to d76548a98f4e18d3c65a3d921bbb70caf9be6138: > > sPAPR: Enable EEH on VFIO PCI device only (2015-09-23 10:51:11 +1000) > > Apologies for the break

[Qemu-devel] [PATCHv2] target-arm: Use physical addresses for ldrex/strex

2015-09-23 Thread Christopher Covington
As different virtual addresses may end up aliasing by pointing to the same physical address, modify load- and store-exclusive to use physical addresses with the exclusive monitor. Written by Derek Hower. Signed-off-by: Christopher Covington --- target-arm/helper-a64.h| 2 ++ target-arm/hel

Re: [Qemu-devel] [PULL] remove libcacard

2015-09-23 Thread Peter Maydell
On 23 September 2015 at 08:36, wrote: > From: Marc-André Lureau > > The following changes since commit 27c7275a56948f48f536e2d1599b22355f5714ac: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-ipxe-20150903-1' > into staging (2015-09-22 19:22:23 +0100) > > are available in the git

Re: [Qemu-devel] [RFC PATCH 11/14] spapr_pci: Allow EEH on spapr-pci-host-bridge

2015-09-23 Thread Alex Williamson
On Sat, 2015-09-19 at 17:18 +1000, David Gibson wrote: > The pseries machine type has two variants of the PCI Host Bridge device: > spapr-pci-host-bridge and spapr-pci-vfio-host-bridge. Originally, only the > latter could support VFIO devices, but we've now extended the VFIO code so > that they bo

Re: [Qemu-devel] [RFC PATCH 02/14] spapr_pci: Switch EEH to vfio_eeh_op() interface

2015-09-23 Thread Alex Williamson
On Sat, 2015-09-19 at 17:18 +1000, David Gibson wrote: > This switches all EEH on VFIO operations in spapr_pci_vfio() from the old > broken vfio_container_ioctl() interface to the new vfio_eeh_op() interface. > > In order to obtain the VFIOGroup * handle that vfio_eeh_op() requires, we > add a hel

Re: [Qemu-devel] [RFC PATCH 01/14] vfio: Start adding VFIO/EEH interface

2015-09-23 Thread Alex Williamson
On Sat, 2015-09-19 at 17:18 +1000, David Gibson wrote: > At present the code handling IBM's Enhanced Error Handling (EEH) interface > on VFIO devices operates by bypassing the usual VFIO logic with > vfio_container_ioctl(). That's a poorly designed interface with unclear > semantics about exactly

Re: [Qemu-devel] [RFC PATCH 09/14] vfio: Expose a VFIO PCI device's group for EEH

2015-09-23 Thread Alex Williamson
On Sat, 2015-09-19 at 17:18 +1000, David Gibson wrote: > The Enhanced Error Handling (EEH) interface in PAPR operates on units of a > Partitionable Endpoint (PE). For VFIO devices, the PE boundaries the guest > sees must match the PE (i.e. IOMMU group) boundaries on the host. To > implement this

Re: [Qemu-devel] Loading image/elf to cpu that has different not system memory address space

2015-09-23 Thread mar.krzeminski
W dniu 23.09.2015 o 17:46, Peter Maydell pisze: On 23 September 2015 at 08:17, Marcin Krzemiński wrote: Hello, I am trying to write a model of embedded board that have corterx-m3 and cotex a9 processors. Because M3 see different memory at address 0x0 than A9 (m3 has small rom, a9 has whole ram

Re: [Qemu-devel] [PATCH v2] ui/cocoa.m: verify with user before quitting QEMU

2015-09-23 Thread Peter Maydell
On 20 September 2015 at 12:20, Programmingkid wrote: > This patch prevents the user from accidentally quitting QEMU by pushing > Command-Q or by pushing the close button on the main window. When the user > does > one of these two things, a dialog box appears verifying with the user if he or > she

Re: [Qemu-devel] [PATCH v7 28/42] Postcopy: Postcopy startup in migration thread

2015-09-23 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > >> > + * We need to leave the fd free for page transfers during the > >> > + * loading of the device state, so wrap all the remaining > >> > + * commands and state into a package that gets sent in one go

Re: [Qemu-devel] [PATCH] ui/cocoa.m: prevent stuck key situation

2015-09-23 Thread Peter Maydell
On 18 September 2015 at 14:46, Programmingkid wrote: > When the user puts QEMU in the background while holding down a key, QEMU > will > not receive the keyup event when the user lets go of the key. When the user > goes > back to QEMU, QEMU will think the key is still down causing stuck key > symp

Re: [Qemu-devel] [PATCH v2 2/2] PCI-e device multi-function hot-add support

2015-09-23 Thread Alex Williamson
On Wed, 2015-09-23 at 21:37 +0800, Cao jin wrote: > Hi Alex, > > On 09/23/2015 01:51 AM, Alex Williamson wrote: > > On Tue, 2015-09-22 at 18:08 +0800, Cao jin wrote: > >> Hi Alex > >> > >> On 09/22/2015 02:00 AM, Alex Williamson wrote: > >>> > >>> Please use different subjects that uniquely identi

Re: [Qemu-devel] [PATCH] tilegx: Support raise instruction

2015-09-23 Thread Richard Henderson
You forgot to cc qemu-devel. This patch needs to be split. On 09/22/2015 03:38 PM, gang.chen.5...@gmail.com wrote: > From: Chen Gang > > It passes the related test. > > Signed-off-by: Chen Gang > --- > linux-user/main.c | 25 + > linux-user/signal.c | 129 > ++

Re: [Qemu-devel] [RFC PATCH 06/10] vfio: Allow hotplug of containers onto existing guest IOMMU mappings

2015-09-23 Thread Laurent Vivier
On 17/09/2015 15:09, David Gibson wrote: > At present the memory listener used by vfio to keep host IOMMU mappings > in sync with the guest memory image assumes that if a guest IOMMU > appears, then it has no existing mappings. > > This may not be true if a VFIO device is hotplugged onto a guest

Re: [Qemu-devel] [RFC PATCH 07/10] spapr_pci: Allow PCI host bridge DMA window to be configured

2015-09-23 Thread Laurent Vivier
On 17/09/2015 15:09, David Gibson wrote: > At present the PCI host bridge (PHB) for the pseries machine type has a > fixed DMA window from 0..1GB (in PCI address space) which is mapped to real > memory via the PAPR paravirtualized IOMMU. > > For better support of VFIO devices, we're going to wan

Re: [Qemu-devel] [PATCH] ui/cocoa.m: remove open dialog code

2015-09-23 Thread Peter Maydell
On 10 September 2015 at 17:49, Programmingkid wrote: > Remove the open dialog code that runs when no arguments are supplied with > QEMU. > Not everyone needs a hard drive or cdrom to boot their target. A user might > only > need to use their target's bios to do work. With that said, this patch > r

Re: [Qemu-devel] [PATCH v7 26/42] postcopy: Incoming initialisation

2015-09-23 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Signed-off-by: Dr. David Alan Gilbert > > Reviewed-by: David Gibson > > --- > > include/migration/migration.h| 3 + > > include/migration/postcopy-ram.h | 12 +

Re: [Qemu-devel] [PATCH] target-arm: Implement AArch64 OSLSR_EL1 sysreg dummy

2015-09-23 Thread Davorin Mista
On 09/23/2015 09:07 AM, Peter Maydell wrote: On 22 September 2015 at 11:35, Davorin Mista wrote: Define a dummy version of the AArch64 OSLAR_EL1 system register Should read "OSLSR_EL1" :-) Yes, sorry about that :) which just ignores reads. Linux reads from this register during its sus

Re: [Qemu-devel] [PATCH v3 04/25] target-*: Introduce and use cpu_breakpoint_test

2015-09-23 Thread Peter Maydell
On 22 September 2015 at 13:24, Richard Henderson wrote: > Reduce the boilerplate required for each target. At the same time, > move the test for breakpoint after calling tcg_gen_insn_start. > > Note that arm and aarch64 do not use cpu_breakpoint_test, but still > move the inline test down after t

Re: [Qemu-devel] [PATCH v3 20/25] tcg: Save insn data and use it in cpu_restore_state_from_tb

2015-09-23 Thread Peter Maydell
On 22 September 2015 at 13:25, Richard Henderson wrote: > We can now restore state without retranslation. > > Signed-off-by: Richard Henderson > --- > include/exec/exec-all.h | 1 + > tcg/tcg.c | 40 - > tcg/tcg.h | 4 +- > translate-all.c | 1

Re: [Qemu-devel] [PATCH 2/2] hw/vfio/platform: do not set resamplefd for edge-sensitive IRQS

2015-09-23 Thread Alex Williamson
On Wed, 2015-09-23 at 00:00 +0100, Eric Auger wrote: > In irqfd mode, current code attempts to set a resamplefd whatever > the type of the IRQ. For an edge-sensitive IRQ this attempt fails > and as a consequence the whole irqfd setup fails and we fall back > to the slow mode. This patch bypasses th

Re: [Qemu-devel] [PATCH v3 23/25] tcg: Emit prologue to the beginning of code_gen_buffer

2015-09-23 Thread Peter Maydell
On 22 September 2015 at 13:25, Richard Henderson wrote: > By putting the prologue at the end, we risk overwriting the > prologue should our estimate of maximum TB size. Given the > two different placements of the call to tcg_prologue_init, > move the high water mark computation into tcg_prologue_

Re: [Qemu-devel] [PATCH v3 24/25] tcg: Allocate a guard page after code_gen_buffer

2015-09-23 Thread Peter Maydell
On 22 September 2015 at 13:25, Richard Henderson wrote: > This will catch any overflow of the buffer. > > Add a native win32 alternative for alloc_code_gen_buffer; > remove the malloc alternative. > > Signed-off-by: Richard Henderson > --- > translate-all.c | 210 > +

Re: [Qemu-devel] [PATCH v3 23/25] tcg: Emit prologue to the beginning of code_gen_buffer

2015-09-23 Thread Richard Henderson
On 09/23/2015 12:28 PM, Peter Maydell wrote: >> -/* Steal room for the prologue at the end of the buffer. This ensures >> - (via the MAX_CODE_GEN_BUFFER_SIZE limits above) that direct branches >> - from TB's to the prologue are going to be in range. It also means >> - that w

Re: [Qemu-devel] [PATCH v3 25/25] tcg: Check for overflow via highwater mark

2015-09-23 Thread Peter Maydell
On 22 September 2015 at 13:25, Richard Henderson wrote: > We currently pre-compute an worst case code size for any TB, which > works out to be 122kB. Since the average TB size is near 1kB, this > wastes quite a lot of storage. > > Instead, check for overflow in between generating code for each op

Re: [Qemu-devel] [PATCH v3 24/25] tcg: Allocate a guard page after code_gen_buffer

2015-09-23 Thread Richard Henderson
On 09/23/2015 12:39 PM, Peter Maydell wrote: >> +# ifdef _WIN32 > > Why the space before ifdef here ? #ifdef USE_STATIC_CODE_GEN_BUFFER # ifdef _WIN32 # else # endif /* WIN32 */ #elif defined(_WIN32) #else #endif It's something that glibc requires for its coding style, and I find myself using it

Re: [Qemu-devel] [PATCH v3 25/25] tcg: Check for overflow via highwater mark

2015-09-23 Thread Richard Henderson
On 09/23/2015 12:42 PM, Peter Maydell wrote: >> +/* Threshold to flush the translated code buffer, and where to go >> + upon overflow. */ >> +void *code_gen_highwater; > > I don't understand what the "and where to go upon overflow" part > of this comment means. Can you elaborate? H

Re: [Qemu-devel] [opnfv-tech-discuss] RFC: virtio-peer shared memory based peer communication device

2015-09-23 Thread Ergin, Mesut A
On 18/09/2015 18:29, Claudio Fontana wrote: > The Virtio Peer shared memory communication device (virtio-peer) is a > virtual device which allows high performance low latency guest to guest > communication. It uses a new queue extension feature tentatively called > VIRTIO_F_WINDOW which indicates

[Qemu-devel] [PULL 00/19] VFIO updates

2015-09-23 Thread Alex Williamson
The following changes since commit 684bb5770ec5d72a66620f64fc5d9672bf8d3509: Merge remote-tracking branch 'remotes/dgibson/tags/spapr-next-20150923' into staging (2015-09-23 16:52:54 +0100) are available in the git repository at: git://github.com/awilliam/qemu-vfio.git tags/v

[Qemu-devel] [PULL 02/19] vfio/pci: Cleanup vfio_early_setup_msix() error path

2015-09-23 Thread Alex Williamson
With the addition of the Chelsio quirk we have an error path out of vfio_early_setup_msix() that doesn't free the allocated VFIOMSIXInfo struct. This doesn't introduce a leak as it still gets freed in the vfio_put_device() path, but it's complicated and sloppy to rely on that. Restructure to free

<    1   2   3   4   >