On 23.09.2015 18:11, Alberto Garcia wrote: > Commit 934659c460 disabled the supression of segmentation faults in > bash tests. The new output of test 061, however, assumes that a core > dump will be produced if a program aborts. This is not necessarily the > case because core dumps can be disabled using ulimit. > > We cannot guarantee that core dumps can be enabled in all cases, so we > should disable them completely and update the test output accordingly. > > Signed-off-by: Alberto Garcia <be...@igalia.com> > --- > tests/qemu-iotests/061 | 3 +++ > tests/qemu-iotests/061.out | 4 ++-- > 2 files changed, 5 insertions(+), 2 deletions(-)
As noted in the commit message for 3f394472c5bca59de5cab9baafdff1984b0213a3, ulimit -c 0 does not work for everyone (for instance, for me it fails, probably because I'm using systemd's coredumpctl). Generally speaking, it'll only prevent a core dump from being created if your /proc/sys/kernel/core_pattern points to a file, but it won't if it points to a program for gathering the dump. What we really want is to use "sigraise $(kill -l KILL)" instead of "abort", because SIGKILL never creates a core dump, but will have basically the same effect of crashing qemu-io. Max > > diff --git a/tests/qemu-iotests/061 b/tests/qemu-iotests/061 > index 1df887a..7d8415b 100755 > --- a/tests/qemu-iotests/061 > +++ b/tests/qemu-iotests/061 > @@ -43,6 +43,9 @@ _supported_fmt qcow2 > _supported_proto file > _supported_os Linux > > +# Disable core dumps or they'll mess up the test output > +ulimit -c 0 > + > echo > echo "=== Testing version downgrade with zero expansion ===" > echo > diff --git a/tests/qemu-iotests/061.out b/tests/qemu-iotests/061.out > index a683f46..0499138 100644 > --- a/tests/qemu-iotests/061.out > +++ b/tests/qemu-iotests/061.out > @@ -57,7 +57,7 @@ No errors were found on the image. > Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 > wrote 131072/131072 bytes at offset 0 > 128 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > -./common.config: Aborted (core dumped) ( exec > "$QEMU_IO_PROG" $QEMU_IO_OPTIONS "$@" ) > +./common.config: Aborted ( exec "$QEMU_IO_PROG" > $QEMU_IO_OPTIONS "$@" ) > magic 0x514649fb > version 3 > backing_file_offset 0x0 > @@ -215,7 +215,7 @@ No errors were found on the image. > Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 > wrote 131072/131072 bytes at offset 0 > 128 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > -./common.config: Aborted (core dumped) ( exec > "$QEMU_IO_PROG" $QEMU_IO_OPTIONS "$@" ) > +./common.config: Aborted ( exec "$QEMU_IO_PROG" > $QEMU_IO_OPTIONS "$@" ) > magic 0x514649fb > version 3 > backing_file_offset 0x0 >
signature.asc
Description: OpenPGP digital signature
