Eric Blake <ebl...@redhat.com> writes: > On 09/21/2015 03:57 PM, Eric Blake wrote: >> Recent changes to qapi have provided quite a bit of churn in >> the makefile, because we are inconsistent on what order test >> names appear in, and on whether to re-wrap the list of tests or >> just add arbitrary line lengths. Writing the list in a sorted >> fashion, one test per line, will make future patches easier >> to see what tests are being added or removed by a patch. >> >> Signed-off-by: Eric Blake <ebl...@redhat.com> >> --- >> tests/Makefile | 160 >> ++++++++++++++++++++++++++++++++++++++++----------------- >> 1 file changed, 114 insertions(+), 46 deletions(-) >> > >> +qapi-schema += alternate-array.json >> +qapi-schema += alternate-base.json > > Hmm, I just realized we require GNU make, and that we already use > $(wildcard) when building up other tests. Would it be worth writing > this patch to merely use $(wildcard qapi-tests/*.json)? Then further > additions (and removals) of .json files would automatically be picked up > without requiring Makefile tweaking.
I really dislike picking up source files with $(wildcard), because it can also pick up random junk. Something like $(shell git ls-files tests/qapi-schema/*.json) avoids random junk, but doesn't work when you build a tarball.
