This allows to include "stdint.h" in virtio header files. Otherwise,
scripts/update-linux-headers.sh fails when updating headers from
Linux 4.2.rc8 kernel. include/uapi/linux/virtio_ring.h starts to
include "stdint.h" from commit d768f32a ("virtio: Fix typecast of
pointer in vring_init()").
Signed
The patchset depends on below Linux upstream commits:
commit ed3e81f ("powerpc/eeh: Move PE state constants around")
commit ec33d36 ("powerpc/eeh: Introduce eeh_pe_inject_err()")
According to PAPR specification 2.7, there're 3 RTAS calls relevent to error
injection: "ibm,open-errinjct", "ibm,
This submits changes with formatted commit log while updating Linux
headers using scripts/update-linux-headers.sh.
Signed-off-by: Gavin Shan
---
scripts/update-linux-headers.sh | 24
1 file changed, 24 insertions(+)
diff --git a/scripts/update-linux-headers.sh b/scripts
This includes linux/arch/powerpc/include/uapi/asm/eeh.h while
updating linux header files. The specific header file, introduced
by the following Linux upstream commits for EEH on sPAPR platform:
ed3e81f ("powerpc/eeh: Move PE state constants around")
ec33d36 ("powerpc/eeh: Introduce eeh_pe_inj
On 27.08.2015 20:39, Peter Maydell wrote:
On 12 August 2015 at 12:50, Denis V. Lunev wrote:
From: Pavel Butsykin
It will be easier if you need to add info-commands to edit
only hmp-commands-info.hx, before this had to edit monitor.c and
hmp-commands.hx
Signed-off-by: Pavel Butsykin
Signed
Synchronize the Linux headers from kernel version 4.2.0-rc8
(commit c13dcf9)
Signed-off-by: Gavin Shan
---
include/standard-headers/linux/pci_regs.h| 381 ---
include/standard-headers/linux/virtio_ring.h | 3 +-
linux-headers/asm-powerpc/eeh.h | 56 +++
This replaces PCI_MSIX_FLAGS_BIRMASK with PCI_MSIX_TABLE_BIR. Also,
3 more macros regarding MSIx table offset, MSIx PBA BAR index and
MSIx PBA offset and this uses them. Besides, PCI_ERR_UNC_TRAIN is
replaced with PCI_ERR_UNC_UND. The changes were introduced by
below Linux upstream commits:
comm
This introduces rtas_ldq() to load 64-bits parameter from continuous
two 4-bytes memory chunk of RTAS parameter buffer, to simplify the
code.
Signed-off-by: Gavin Shan
Reviewed-by: Thomas Huth
---
hw/ppc/spapr_pci.c | 20 ++--
include/hw/ppc/spapr.h | 5 +
2 files chang
This supports RTAS calls "ibm,{open,close}-errinjct" to manupliate
the token, which is passed to RTAS call "ibm,errinjct" to indicate
the valid context for error injection. Each VM is permitted to have
only one token at once and we simply have sequential number for that.
The token is resetted in pp
Problem is solved in current master branch
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1488901
Title:
KVM guest crashes when doing a block commit command
Status in QEMU:
New
Bug description:
The patch supports RTAS call "ibm,errinjct" to allow injecting
EEH errors to VFIO PCI devices. The implementation is similiar
to EEH support for VFIO PCI devices: The RTAS request is captured
by QEMU and routed to sPAPRPHBClass::eeh_inject_error() where the
request is translated to VFIO container I
Hi all,
> Sorry for the long delay. Please CC qemu-...@nongnu.org on the next
submission, so that more PPC people have the chance to review the patch ;).
I see, I missed this mailing list -
http://wiki.qemu.org/Contribute/SubmitAPatch
As it do not not mention it.
Thanks, applied to ppc-next
On 2015/8/27 20:43, Dr. David Alan Gilbert wrote:
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
Hi Dave,
On 2015/8/27 18:40, Dr. David Alan Gilbert wrote:
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
We need communications protocol of user-defined to control the checkpoin
On 28 August 2015 at 08:00, Pavel Butsykin wrote:
>
>
> On 27.08.2015 20:39, Peter Maydell wrote:
>>
>> On 12 August 2015 at 12:50, Denis V. Lunev wrote:
>>>
>>> From: Pavel Butsykin
>>>
>>> It will be easier if you need to add info-commands to edit
>>> only hmp-commands-info.hx, before this had
On Mon, 24 Aug 2015 12:37:06 -0700
Richard Henderson wrote:
> From: Laurent Vivier
>
> As we have removed CONFIG_USE_GUEST_BASE, we always use a guest base
> and the macros GUEST_BASE and RESERVED_VA become useless: replace
> them by their values.
>
> Reviewed-by: Alexander Graf
> Signed-off-
On Wed 26 Aug 2015 02:57:13 PM CEST, Stefan Hajnoczi wrote:
>> In principle extending the QMP command sounds as simple as adding
>> 'options': 'BlockdevOptions' to 'blockdev-snapshot-sync', but it's
>> surely more complicated than that :) Is the 'BlockdevOptions' API
>> even stable?
>
> Some block
On Fri, Aug 28, 2015 at 3:31 AM, Josh Durgin wrote:
> On 08/27/2015 09:49 AM, Stefan Hajnoczi wrote:
>>
>> On Mon, Aug 25, 2014 at 03:50:02PM -0600, Chris Friesen wrote:
>>>
>>> The only limit I see in the whole call chain from
>>> virtio_blk_handle_request() on down is the call to
>>> bdrv_io_lim
Le 28/08/2015 10:21, Cornelia Huck a écrit :
> On Mon, 24 Aug 2015 12:37:06 -0700
> Richard Henderson wrote:
>
>> From: Laurent Vivier
>>
>> As we have removed CONFIG_USE_GUEST_BASE, we always use a guest base
>> and the macros GUEST_BASE and RESERVED_VA become useless: replace
>> them by thei
On Thu, Aug 27, 2015 at 01:26:35PM -0400, Programmingkid wrote:
>
> On Aug 27, 2015, at 12:13 PM, Daniel P. Berrange wrote:
>
> > Currently both object_del and device_del require that the
> > client provide the object/device short ID. While user
> > creatable objects require an ID to be provided
On 28/08/2015 04:19, Emilio G. Cota wrote:
> translate-all.c-1478-} else {
> translate-all.c:1479:cpu->tcg_exit_req = 1;
This one is only run in the CPU thread.
> translate-all.c-1643-cpu->interrupt_request |= mask;
> translate-all.c:1644:cpu->tcg_exit_req = 1;
This one is
For platform that supports AVX2 instructions, use the AVX2 instructions
instead of SSE2 instructions in buffer_find_nonzero_offset() can help to
improve the performance about 30%. Zero page check during live migration
can be faster with this optimization.
Signed-off-by: Liang Li
---
include/qemu
Add the --enable-avx2 option so as to enable the AVX2
instruction optimization for buffer_find_nonzero_offset().
Signed-off-by: Liang Li
---
configure | 16
1 file changed, 16 insertions(+)
diff --git a/configure b/configure
index 9d24d59..ee84172 100755
--- a/configure
+++ b/c
The buffer_find_nonzero_offset() will be called to check the zero page
during live migration, it's a hot function. buffer_find_nonzero_offset()
has already been optimized with SSE2 instructions, for platform that
supports AVX2, we can optimize this function with AVX2 instructions and
achieve about
On Fri, 28 Aug 2015 10:33:25 +0200
Laurent Vivier wrote:
>
>
> Le 28/08/2015 10:21, Cornelia Huck a écrit :
> > On Mon, 24 Aug 2015 12:37:06 -0700
> > Richard Henderson wrote:
> >
> >> From: Laurent Vivier
> >>
> >> As we have removed CONFIG_USE_GUEST_BASE, we always use a guest base
> >> an
On Thu, Aug 27, 2015 at 07:14:28PM -0400, Programmingkid wrote:
> Add device ID generation to each device if an ID isn't given.
>
> An auto-generated ID will begin with an underscore character. This will
> distinguish it from user-made ID's.
>
> An user-made ID cannot begin with an underscore, s
> From: Aurelien Jarno [mailto:aurel...@aurel32.net]
> On 2015-08-13 14:12, Leon Alrae wrote:
> > On 10/07/2015 10:57, Pavel Dovgalyuk wrote:
> > > @@ -2364,14 +2363,12 @@ static void gen_st_cond (DisasContext *ctx,
> > > uint32_t opc, int rt,
> > > #if defined(TARGET_MIPS64)
> > > case OPC_
guest_base must be used only in linux-user mode.
Signed-off-by: Laurent Vivier
---
tcg/s390/tcg-target.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c
index ee2e58d..2122744 100644
--- a/tcg/s390/tcg-target.c
+++ b/tcg/s390/tcg-target.c
@@ -2
On Fri, 28 Aug 2015 11:09:05 +0200
Laurent Vivier wrote:
> guest_base must be used only in linux-user mode.
>
> Signed-off-by: Laurent Vivier
> ---
> tcg/s390/tcg-target.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Thanks, that fixed compilation on s390 for me.
On 27.08.2015 20:31, Peter Maydell wrote:
On 12 August 2015 at 12:50, Denis V. Lunev wrote:
From: Pavel Butsykin
Move target-specific code out of /monitor.c to /target-*/monitor.c,
this will avoid code cluttering and using random ifdeffery. The solution
is quite simple, but solves the issu
Eduardo Habkost writes:
> On Thu, Aug 27, 2015 at 01:50:10PM +0300, Michael S. Tsirkin wrote:
>> On Tue, Aug 25, 2015 at 05:21:16PM +0100, Daniel P. Berrange wrote:
>> > On Mon, Aug 24, 2015 at 11:54:48AM +0200, Markus Armbruster wrote:
>> > > John Snow writes:
>> > >
>> > > > On 08/19/2015 02:
On 28 August 2015 at 10:15, Cornelia Huck wrote:
> On Fri, 28 Aug 2015 11:09:05 +0200
> Laurent Vivier wrote:
>
>> guest_base must be used only in linux-user mode.
>>
>> Signed-off-by: Laurent Vivier
>> ---
>> tcg/s390/tcg-target.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>
> Thanks, that
"Kővágó Zoltán" writes:
> 2015-08-26 15:15 keltezéssel, Markus Armbruster írta:
>> Stefan Hajnoczi writes:
>>
>>> On Tue, Jul 7, 2015 at 3:42 PM, Kővágó, Zoltán
>>> wrote:
This will let us print options in a format that the user would actually
write it on the command line (foo=bar,baz
On 28 August 2015 at 11:03, Peter Maydell wrote:
> On 28 August 2015 at 10:15, Cornelia Huck wrote:
>> On Fri, 28 Aug 2015 11:09:05 +0200
>> Laurent Vivier wrote:
>>
>>> guest_base must be used only in linux-user mode.
>>>
>>> Signed-off-by: Laurent Vivier
>>> ---
>>> tcg/s390/tcg-target.c | 2
Le 28/08/2015 12:08, Peter Maydell a écrit :
> On 28 August 2015 at 11:03, Peter Maydell wrote:
>> On 28 August 2015 at 10:15, Cornelia Huck wrote:
>>> On Fri, 28 Aug 2015 11:09:05 +0200
>>> Laurent Vivier wrote:
>>>
guest_base must be used only in linux-user mode.
Signed-off-by
On 28 August 2015 at 10:21, Pavel Butsykin wrote:
> Yes, this is a good way if we make the interface: const MonitorDef
> *target_monitor_defs(void);
> But we can't include the 'monitor/monitor-common.h' to
> stubs/target-monitor-defs.c, because
> there is a dependency with a target-specific header
guest_base must be used only in linux-user mode.
Signed-off-by: Laurent Vivier
---
v2: minor cleanup, drop TCG_GUEST_BASE_REG if CONFIG_SOFTMMU
tcg/s390/tcg-target.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c
index ee2e58
On Fri, 28 Aug 2015 12:23:41 +0200
Laurent Vivier wrote:
> guest_base must be used only in linux-user mode.
>
> Signed-off-by: Laurent Vivier
> ---
> v2: minor cleanup, drop TCG_GUEST_BASE_REG if CONFIG_SOFTMMU
> tcg/s390/tcg-target.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
"Denis V. Lunev" writes:
> The monivation of this set is simple. Recently we have proposed patch
> to monitor.c with specific x86 APIC HMP commands. The patchset was denied
> with the main motivation "No more arch specific code in monitor.c"
> This patchset is the first step to move arch specific
Yang Hongyang writes:
> On 08/26/2015 10:04 PM, Markus Armbruster wrote:
>> Missed a bunch of revisions of this series, please excuse gaps in my
>> understanding.
>
> Thank you for the review.
>
>>
>> Yang Hongyang writes:
>>
>>> Add the framework for a new netfilter object and a new
>>> -netfil
Eric Blake writes:
> On 08/26/2015 09:17 AM, Markus Armbruster wrote:
>> Only reviewing QAPI/QMP and HMP interface parts for now.
>>
>> I apologize for not having reviewed this series earlier. v8 is awfully
>> late for the kind of review comments I have.
>
> And I've also been behind the curve,
Yang Hongyang writes:
> On 08/26/2015 11:55 PM, Markus Armbruster wrote:
>> Yang Hongyang writes:
>>
>>> now that we have a buffer netfilter, update the command
>>> description and help.
>>>
>>> Signed-off-by: Yang Hongyang
>>> CC: Luiz Capitulino
>>> CC: Markus Armbruster
>>> ---
>>> v8: add
On Mo, 2015-08-24 at 15:13 -0400, Programmingkid wrote:
> +monitor_printf(mon, " Device %d.%d, Port %s, Speed %s
> Mb/s,"
> +"Product %s, ID %s\n",
> + bus->busnr, dev->addr, port->path,
> + usb_speed(d
On Wed, Jul 29, 2015 at 12:42:12PM +0800, Fam Zheng wrote:
> +bool bdrv_aio_poll(AioContext *ctx, bool blocking)
> +{
> +bool ret;
> +
> +ret = aio_poll(ctx, blocking);
> +return ret;
> +}
This function would fit into bdrv_*() APIs better if the first argument
was BlockDriverState *bs
On 28/08/2015 09:15, Gavin Shan wrote:
> This submits changes with formatted commit log while updating Linux
> headers using scripts/update-linux-headers.sh.
>
> Signed-off-by: Gavin Shan
> ---
> scripts/update-linux-headers.sh | 24
> 1 file changed, 24 insertions(+)
On Wed, Jul 29, 2015 at 12:42:13PM +0800, Fam Zheng wrote:
> Just a manual search and replace. No semantic change here.
>
> Signed-off-by: Fam Zheng
> ---
> block.c | 2 +-
> block/curl.c | 2 +-
> block/io.c| 18 +-
> block/nfs.c | 2 +-
> block/q
On Wed, Jul 29, 2015 at 12:42:03PM +0800, Fam Zheng wrote:
> v2: Switch to disable/enable model. [Paolo]
>
> Most existing nested aio_poll()'s in block layer are inconsiderate of
> dispatching potential new r/w requests from ioeventfds and nbd exports, which
> might result in responsiveness issues
On Do, 2015-08-27 at 14:46 +0200, Peter Lieven wrote:
> I have observed that depending on the contents and the encoding it happens
> that sending data as RAW sometimes would take less space than the encoded
> data.
> This is especially the case for small updates or areas with high color images.
>
On Wed, Aug 26, 2015 at 06:40:26PM +0800, Xiao Guangrong wrote:
> On 08/26/2015 12:03 AM, Stefan Hajnoczi wrote:
> >On Fri, Aug 14, 2015 at 10:52:01PM +0800, Xiao Guangrong wrote:
> >
> >>+if (fd < 0) {
> >>+error_setg(errp, "can not open %s", nvdimm->file);
> >
> >s/can not/cannot/
> >
On Wed, Aug 26, 2015 at 06:42:01PM +0800, Xiao Guangrong wrote:
>
>
> On 08/26/2015 12:16 AM, Stefan Hajnoczi wrote:
> >On Fri, Aug 14, 2015 at 10:52:06PM +0800, Xiao Guangrong wrote:
> >>+#ifdef NVDIMM_DEBUG
> >>+#define nvdebug(fmt, ...) fprintf(stderr, "nvdimm: " fmt, ## __VA_ARGS__)
> >>+#els
On 28/08/15 13:27, Alexander Graf wrote:
> The current U-Boot binary in QEMU has a bug where it fails to support
> dynamic CCSR addressing. Without this support, u-boot can not boot the
> ppce500 machine anymore. This has been fixed upstream in u-boot commit
> e834975b.
>
> Update the u-boot blob
On Wed, Aug 26, 2015 at 06:46:35PM +0800, Xiao Guangrong wrote:
> On 08/26/2015 12:23 AM, Stefan Hajnoczi wrote:
> >On Fri, Aug 14, 2015 at 10:52:07PM +0800, Xiao Guangrong wrote:
> >> static void dsm_write(void *opaque, hwaddr addr,
> >>uint64_t val, unsigned size)
> >> {
On Fri, Aug 28, 2015 at 01:50:47PM +0200, Laurent Vivier wrote:
>On 28/08/2015 09:15, Gavin Shan wrote:
>> This submits changes with formatted commit log while updating Linux
>> headers using scripts/update-linux-headers.sh.
>>
>> Signed-off-by: Gavin Shan
>> ---
>> scripts/update-linux-headers.
Copying Andreas and Paolo for QOM expertise.
"Daniel P. Berrange" writes:
> Currently both object_del and device_del require that the
> client provide the object/device short ID. While user
> creatable objects require an ID to be provided at time of
> creation, qdev devices may be created withou
Gah, missed your v2! Sorry for the noise on v1.
Still copying Andreas and Paolo for QOM expertise.
"Daniel P. Berrange" writes:
> Currently both object_del and device_del require that the
> client provide the object/device short ID. While user
> creatable objects require an ID to be provided a
On Fri, Aug 28, 2015 at 02:53:41PM +0200, Markus Armbruster wrote:
> Copying Andreas and Paolo for QOM expertise.
>
> "Daniel P. Berrange" writes:
>
> > Currently both object_del and device_del require that the
> > client provide the object/device short ID. While user
> > creatable objects requi
On Thu, Aug 27, 2015 at 08:33:43AM -0600, Eric Blake wrote:
> On 08/26/2015 09:05 AM, Daniel P. Berrange wrote:
> > Introduce a QCryptoTLSSession object that will encapsulate
> > all the code for setting up and using a client/sever TLS
> > session. This isolates the code which depends on the gnutls
John Snow writes:
> On 08/27/2015 11:29 AM, Eric Blake wrote:
>> On 08/27/2015 09:17 AM, Peter Maydell wrote:
>>> I've noticed recently that tests/hd-geo-test.c creates test disk
>>> images which are 4GB in size, which is a problem if the filesystem
>>> on the host doesn't support sparse files. I
On Aug 28, 2015, at 7:50 AM, Gerd Hoffmann wrote:
> On Mo, 2015-08-24 at 15:13 -0400, Programmingkid wrote:
>> +monitor_printf(mon, " Device %d.%d, Port %s, Speed %s
>> Mb/s,"
>> +"Product %s, ID %s\n",
>> + bus->busnr, dev->a
On Fri, Aug 28, 2015 at 09:08:12AM -0400, Programmingkid wrote:
>
> On Aug 28, 2015, at 7:50 AM, Gerd Hoffmann wrote:
>
> > On Mo, 2015-08-24 at 15:13 -0400, Programmingkid wrote:
> >> +monitor_printf(mon, " Device %d.%d, Port %s, Speed %s
> >> Mb/s,"
> >> +
On Aug 28, 2015, at 9:35 AM, Daniel P. Berrange wrote:
> On Fri, Aug 28, 2015 at 09:08:12AM -0400, Programmingkid wrote:
>>
>> On Aug 28, 2015, at 7:50 AM, Gerd Hoffmann wrote:
>>
>>> On Mo, 2015-08-24 at 15:13 -0400, Programmingkid wrote:
+monitor_printf(mon, " Device %d.%d,
On Fri, Aug 28, 2015 at 10:30:48PM +1000, Gavin Shan wrote:
>On Fri, Aug 28, 2015 at 01:50:47PM +0200, Laurent Vivier wrote:
>>On 28/08/2015 09:15, Gavin Shan wrote:
>>> This submits changes with formatted commit log while updating Linux
>>> headers using scripts/update-linux-headers.sh.
>>>
>>> S
On Fri, Aug 28, 2015 at 09:39:43AM -0400, Programmingkid wrote:
>
> On Aug 28, 2015, at 9:35 AM, Daniel P. Berrange wrote:
>
> > On Fri, Aug 28, 2015 at 09:08:12AM -0400, Programmingkid wrote:
> >>
> >> On Aug 28, 2015, at 7:50 AM, Gerd Hoffmann wrote:
> >>
> >>> On Mo, 2015-08-24 at 15:13 -040
On Fr, 2015-08-28 at 09:39 -0400, Programmingkid wrote:
> On Aug 28, 2015, at 9:35 AM, Daniel P. Berrange wrote:
>
> > On Fri, Aug 28, 2015 at 09:08:12AM -0400, Programmingkid wrote:
> >>
> >> On Aug 28, 2015, at 7:50 AM, Gerd Hoffmann wrote:
> >>
> >>> On Mo, 2015-08-24 at 15:13 -0400, Programm
On Aug 28, 2015, at 9:50 AM, Gerd Hoffmann wrote:
> On Fr, 2015-08-28 at 09:39 -0400, Programmingkid wrote:
>> On Aug 28, 2015, at 9:35 AM, Daniel P. Berrange wrote:
>>
>>> On Fri, Aug 28, 2015 at 09:08:12AM -0400, Programmingkid wrote:
On Aug 28, 2015, at 7:50 AM, Gerd Hoffmann wrote
When rtl8139 card is running in standard mode, it is very easy
to overlflow and the receive buffer and get into a siutation
where all packets are dropped. Simply reproduction case is
to ping the guest from the host with 6500 byte packets.
There are actually 2 problems here.
1) When the rtl8129
In standard operation mode, when the receive ring buffer
is full, the buffer actually appears empty to the driver since
the RxBufAddr (the location we wirte new data to) and RxBufPtr
(the location guest would stat reading from) are the same.
As a result, the call to rtl8139_RxBufferEmpty ends up
re
When operation in standard mode, we currently return the size
of packet during buffer overflow. This consumes the overflow
packet. Return 0 instead so we can re-process the overflow packet
when we have room.
This fixes issues with lost/dropped fragments of large messages.
Signed-off-by: Vladisl
On Thu, Aug 27, 2015 at 09:33:00PM +0200, Laurent Vivier wrote:
> Originally, timers were ticks based, and it made sense to
> add ticks to current time to know when to trigger an alarm.
>
> But since commit:
>
> 7447545 change all other clock references to use nanosecond resolution
> accessors
>
On Thu, Aug 27, 2015 at 09:33:01PM +0200, Laurent Vivier wrote:
> Originally, timers were ticks based, and it made sense to
> add ticks to current time to know when to trigger an alarm.
>
> But since commit:
>
> 7447545 change all other clock references to use nanosecond resolution
> accessors
>
On Thu, Aug 27, 2015 at 09:33:07PM +0200, Laurent Vivier wrote:
> muldiv64() is used to convert nanoseconds to microseconds.
>
> x = muldiv64(qemu_clock_get_ns(..), 100, get_ticks_per_sec());
>
> As get_ticks_per_sec() is 10^9, it can be replaced by:
>
> x = qemu_clock_get_us(..);
>
On 12 August 2015 at 17:40, Paolo Bonzini wrote:
> From: KONRAD Frederic
>
> Protect the list of queued work items with something other than
> the BQL, as a preparation for running the work items outside it.
>
> Signed-off-by: KONRAD Frederic
> Signed-off-by: Paolo Bonzini
Reviewed-by: Peter M
On 12 August 2015 at 17:40, Paolo Bonzini wrote:
> From: KONRAD Frederic
>
> This removes tcg_halt_cond global variable.
> We need one QemuCond per virtual cpu for multithread TCG.
>
> Signed-off-by: KONRAD Frederic
> Message-Id: <1439220437-23957-9-git-send-email-fred.kon...@greensocs.com>
> [K
On 12 August 2015 at 17:40, Paolo Bonzini wrote:
> From: KONRAD Frederic
>
> spinlock is only used in two cases:
> * cpu-exec.c: to protect TranslationBlock
> * mem_helper.c: for lock helper in target-i386 (which seems broken).
>
> It's a pthread_mutex_t in user-mode so better using QemuMutex
On 28/08/2015 16:49, Peter Maydell wrote:
On 12 August 2015 at 17:40, Paolo Bonzini wrote:
From: KONRAD Frederic
spinlock is only used in two cases:
* cpu-exec.c: to protect TranslationBlock
* mem_helper.c: for lock helper in target-i386 (which seems broken).
It's a pthread_mutex_t in
On 12 August 2015 at 17:40, Paolo Bonzini wrote:
> The header is included from basically everywhere, thanks to cpu.h.
> It should be moved to the (TCG only) files that actually need it.
> As a start, remove non-TCG stuff.
>
> While adding a #ifndef CONFIG_USER_ONLY include section to cpu-exec.c,
>
On 28.08.2015 11:19, Peter Maydell wrote:
On 28 August 2015 at 08:00, Pavel Butsykin wrote:
On 27.08.2015 20:39, Peter Maydell wrote:
On 12 August 2015 at 12:50, Denis V. Lunev wrote:
From: Pavel Butsykin
It will be easier if you need to add info-commands to edit
only hmp-commands-info.
On 12 August 2015 at 17:40, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> cpu-exec.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/cpu-exec.c b/cpu-exec.c
> index 599e64d..bde5fd1 100644
> --- a/cpu-exec.c
> +++ b/cpu-exec.c
> @@ -228,6 +228,7 @@ static inline tcg_
Hi,
I have add this bug today on 3 debian jessie guests (kernel 3.16), after
migration from qemu 2.3 to qemu 2.4.
Is it a qemu bug or guest kernel 3.16 ?
Regards,
Alexandre Derumier
- Mail original -
De: "Michael Tokarev"
À: "qemu-devel" , debian-ad...@lists.debian.org
Cc: "Marcelo
On 12 August 2015 at 17:40, Paolo Bonzini wrote:
> More #ifdefs are not nice, but this clarifies why its usage is not
> protected by tb_lock.
Does it? I thought the idea of this series was to add locking
which we needed for adding multi-threading to softmmu, in
which case presumably we need to pr
On 28.08.2015 13:12, Peter Maydell wrote:
On 28 August 2015 at 10:21, Pavel Butsykin wrote:
Yes, this is a good way if we make the interface: const MonitorDef
*target_monitor_defs(void);
But we can't include the 'monitor/monitor-common.h' to
stubs/target-monitor-defs.c, because
there is a dep
On 12 August 2015 at 17:40, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> translate-all.c | 29 ++---
> 1 file changed, 22 insertions(+), 7 deletions(-)
Some overall documentation on what the mmap_lock is protecting
(and thus when it needs to be taken) woul
On 28 August 2015 at 11:23, Laurent Vivier wrote:
> guest_base must be used only in linux-user mode.
>
> Signed-off-by: Laurent Vivier
> ---
> v2: minor cleanup, drop TCG_GUEST_BASE_REG if CONFIG_SOFTMMU
> tcg/s390/tcg-target.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks;
On 12 August 2015 at 17:41, Paolo Bonzini wrote:
> page_find is reading the radix tree outside all locks, so it has to
> use the RCU primitives. It does not need RCU critical sections
> because the PageDescs are never removed, so there is never a need
> to wait for the end of code sections that u
On 12 August 2015 at 17:41, Paolo Bonzini wrote:
> There is some iffy lock hierarchy going on in translate-all.c. To
> fix it, we need to take the mmap_lock in cpu-exec.c. Make the
> functions globally available.
>
> Signed-off-by: Paolo Bonzini
> ---
> bsd-user/qemu.h | 2 --
> includ
Am 27.08.2015 um 22:20 schrieb Richard Henderson:
> On 08/27/2015 03:47 PM, Andreas Färber wrote:
>> Am 12.07.2015 um 06:18 schrieb Andreas Färber:
>>> Am 12.07.2015 um 03:59 schrieb Peter Crosthwaite:
Continue QOMifying target-specific disassembly. Convert all arches
except for
X86
On 12 August 2015 at 17:41, Paolo Bonzini wrote:
> tb_lock has to be taken inside the mmap_lock (example:
> tb_invalidate_phys_range is called by target_mmap), but
> tb_link_page is taking the mmap_lock and it is called
> with the tb_lock held.
>
> To fix this, take the mmap_lock in tb_find_slow,
On 28 August 2015 at 16:46, Andreas Färber wrote:
> Two to go, moxie as the next one untested by Peter.
The last email on qemu-devel from the moxie maintainer was
in 2013, so I wouldn't hold your breath.
-- PMM
On 28 August 2015 at 14:55, Programmingkid wrote:
> On Aug 28, 2015, at 9:50 AM, Gerd Hoffmann wrote:
>> Even better: Don't print "ID: ..." in the first place in case it is not
>> present.
>
> The ID is printed so if the user needs to remove the device, device_del
> can be used.
>
> If the ID is
On Aug 28, 2015, at 12:07 PM, Peter Maydell wrote:
> On 28 August 2015 at 14:55, Programmingkid wrote:
>> On Aug 28, 2015, at 9:50 AM, Gerd Hoffmann wrote:
>>> Even better: Don't print "ID: ..." in the first place in case it is not
>>> present.
>>
>> The ID is printed so if the user needs to re
On Fri, Aug 28, 2015 at 9:02 AM, Peter Maydell wrote:
> On 28 August 2015 at 16:46, Andreas Färber wrote:
>> Two to go, moxie as the next one untested by Peter.
>
> The last email on qemu-devel from the moxie maintainer was
> in 2013, so I wouldn't hold your breath.
>
It is also unfortunately th
On 28 August 2015 at 17:19, Peter Crosthwaite
wrote:
> Longer term though, maybe these homogeneous every-arch change patterns
> should only need a critical mass of acks from the arch maintainers for
> the whole thing to go through. It's unlikely that I botched moxie with
> most of the other arches
Am 27.08.2015 um 22:30 schrieb Richard Henderson:
> On 08/27/2015 04:47 PM, Andreas Färber wrote:
>> The argument order for the !CONFIG_SOFTMMU case was jumbled up since
>> ffc6372851d8631a9f9fa56ec613b3244dc635b9 ("tcg/aarch64: use 32-bit
>> offset for 32-bit user-mode emulation"), regressing from
On Thu, Aug 27, 2015 at 5:27 PM, Peter Crosthwaite
wrote:
> On Thu, Aug 27, 2015 at 5:16 PM, Alistair Francis
> wrote:
>> The AHCIState struct can either have AHCIPCIState or SysbusAHCIState
>> as a parent. The ahci_irq_lower() and ahci_irq_raise() functions
>> assume that it is always AHCIPCISta
qapi-event.py breaks when you ask for a funny prefix like '@'.
Protect it.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
scripts/qapi.py | 6 ++
1 file changed, 6 insertions(+)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index ba11c54..bc3f4d3 100644
--- a/scripts/qapi.py
We generate a declaration, but no definition.
The QMP schema has two: Qcow2OverlapChecks and BlockdevRef. Neither
visit_type_Qcow2OverlapChecksKind() nor visit_type_BlockdevRefKind()
is actually used.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
tests/qapi-schema/qapi-schema-t
Use c_name() instead of ad hoc code. Doesn't upcase the -p prefix,
which is an improvement in my book. Unbreaks prefix containing '.',
but other funny characters remain broken. To be fixed next.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
docs/qapi-code-gen.txt | 8
Use set because that's what it is. While there, rename to
implicit_structs_seen.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
scripts/qapi-visit.py | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py
index b3a
It's idempotent.
While there, update examples to current code.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
docs/qapi-code-gen.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt
index 61b5be4..e7e7281 1006
v2:
* Trivially rebased, R-bys retained
* [PATCH 02] Clean up string literal to please pylint
* [PATCH 07] Commit message fix [Eric]
* [PATCH 20] Doc fix [Eric]
* [PATCH 21] Update test cases for the change even though they fail
for other reasons [Eric]
Previously posted as part of "[PATCH RFC v
The guards around built-in declarations lose their _H. It never made
much sense anyway.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
scripts/qapi.py | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index e656beb..b
1 - 100 of 155 matches
Mail list logo
