[Qemu-devel] [PATCH] quorum: don't share qiov

2015-01-30 Thread Wen Congyang
If the child touches qiov->iov, it will cause unexpected results. Signed-off-by: Wen Congyang --- block/quorum.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index cdc026c..ef0c1e9 100644 --- a/block/quorum.c +++ b/block/quorum.c @

Re: [Qemu-devel] -device xen-platform crashes

2015-01-30 Thread Markus Armbruster
Stefano Stabellini writes: > On Thu, 29 Jan 2015, Markus Armbruster wrote: >> Stefano Stabellini writes: >> >> > On Thu, 29 Jan 2015, Markus Armbruster wrote: >> >> Reproducer: qemu -nodefaults -S -display none -device xen-platform >> >> >> >> Yes, xen-platform makes no sense without Xen, but

Re: [Qemu-devel] [RFC PATCH v1 07/13] spapr: Start all the threads of CPU core when core is hotplugged

2015-01-30 Thread Bharata B Rao
On Thu, Jan 29, 2015 at 12:36:55PM +1100, David Gibson wrote: > On Thu, Jan 08, 2015 at 11:40:14AM +0530, Bharata B Rao wrote: > > PowerPC kernel adds or removes CPUs in core granularity and hence > > onlines/offlines all the SMT threads of a core during hot plug/unplug. > > Support this notion by

Re: [Qemu-devel] [RFC PATCH v1 09/13] spapr: CPU hot unplug support

2015-01-30 Thread Bharata B Rao
On Thu, Jan 29, 2015 at 12:39:58PM +1100, David Gibson wrote: > On Thu, Jan 08, 2015 at 11:40:16AM +0530, Bharata B Rao wrote: > > Support hot removal of CPU for sPAPR guests. > > > > Signed-off-by: Bharata B Rao > > --- > > hw/ppc/spapr.c | 43 +++ > > 1

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-01-30 Thread Gonglei
On 2015/1/30 15:46, Markus Armbruster wrote: > Gonglei writes: > >> On 2015/1/30 0:03, Alexander Graf wrote: >> >>> >>> >>> On 29.01.15 14:29, arei.gong...@huawei.com wrote: From: Gonglei If boot order is invaild or is set failed, exit qemu. Signed-off-by: Gonglei

Re: [Qemu-devel] [RFC PATCH v1 10/13] cpus, spapr: reclaim allocated vCPU objects

2015-01-30 Thread Bharata B Rao
On Thu, Jan 29, 2015 at 12:48:39PM +1100, David Gibson wrote: > On Thu, Jan 08, 2015 at 11:40:17AM +0530, Bharata B Rao wrote: > > From: Gu Zheng > > This needs a commit message, it's not at all clear from the 1-line > description. Borrowed patch, but I should have put in a description. > > di

Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line

2015-01-30 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Eric Blake (ebl...@redhat.com) wrote: >> On 01/29/2015 09:28 AM, Dr. David Alan Gilbert wrote: >> > * Eric Blake (ebl...@redhat.com) wrote: >> > > On 01/29/2015 08:54 AM, Dr. David Alan Gilbert wrote: >> > > >> The idea of a QMP command to trigger incoming mig

Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line

2015-01-30 Thread Markus Armbruster
Eric Blake writes: > On 01/29/2015 08:15 AM, Daniel P. Berrange wrote: > >>> ./bin/qemu-system-x86_64 -nographic -nodefaults -qmp-command >> {"execute": "migrate-set-capabilities", >> "arguments":{"capabilities":[{"capability":"xbzrle","state":true}]}}' >> -qmp-command '{"execute": "query-migrate

[Qemu-devel] [PATCH 6/7] block: use fallocate(FALLOC_FL_PUNCH_HOLE) & fallocate(0) to write zeroes

2015-01-30 Thread Denis V. Lunev
This sequence works efficiently if FALLOC_FL_ZERO_RANGE is not supported. Unfortunately, FALLOC_FL_ZERO_RANGE is supported on really modern systems and only for a couple of filesystems. FALLOC_FL_PUNCH_HOLE is much more mature. The sequence of 2 operations FALLOC_FL_PUNCH_HOLE and 0 is necessary d

[Qemu-devel] [PATCH 4/7] block: use fallocate(FALLOC_FL_ZERO_RANGE) in handle_aiocb_write_zeroes

2015-01-30 Thread Denis V. Lunev
This efficiently writes zeroes on Linux if the kernel is capable enough. FALLOC_FL_ZERO_RANGE correctly handles all cases, including and not including file expansion. Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz CC: Kevin Wolf CC: Stefan Hajnoczi CC: Peter Lieven CC: Fam Zheng --- b

[Qemu-devel] [PATCH 2/7] block/raw-posix: create do_fallocate helper

2015-01-30 Thread Denis V. Lunev
The pattern do { if (fallocate(s->fd, mode, offset, len) == 0) { return 0; } } while (errno == EINTR); ret = translate_err(-errno); will be commonly useful in next patches. Create helper for it. Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz CC: Kevi

[Qemu-devel] [PATCH 5/7] block/raw-posix: call plain fallocate in handle_aiocb_write_zeroes

2015-01-30 Thread Denis V. Lunev
There is a possibility that we are extending our image and thus writing zeroes beyond the end of the file. In this case we do not need to care about the hole to make sure that there is no data in the file under this offset (pre-condition to fallocate(0) to work). We could simply call fallocate(0).

[Qemu-devel] [PATCH v6 0/7] eliminate data write in bdrv_write_zeroes on Linux in raw-posix.c

2015-01-30 Thread Denis V. Lunev
I have performed several tests with non-aligned fallocate calls and in all cases (with non-aligned fallocates) Linux performs fine, i.e. areas are zeroed correctly. Checks were made on Linux 3.16.0-28-generic #38-Ubuntu SMP This should seriously increase performance of bdrv_write_zeroes Changes f

[Qemu-devel] [PATCH 7/7] block/raw-posix: set max_write_zeroes to INT_MAX for regular files

2015-01-30 Thread Denis V. Lunev
fallocate() works fine and could handle properly with arbitrary size requests. There is no sense to reduce the amount of space to fallocate. The bigger is the size, the better is the performance as the amount of journal updates is reduced. The patch changes behavior for both generic filesystem and

[Qemu-devel] [PATCH 1/7] block/raw-posix: create translate_err helper to merge errno values

2015-01-30 Thread Denis V. Lunev
actually the code if (ret == -ENODEV || ret == -ENOSYS || ret == -EOPNOTSUPP || ret == -ENOTTY) { ret = -ENOTSUP; } is present twice and will be added a couple more times. Create helper for this. Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz CC: Kevin Wolf CC: Ste

[Qemu-devel] [PATCH 3/7] block/raw-posix: refactor handle_aiocb_write_zeroes a bit

2015-01-30 Thread Denis V. Lunev
move code dealing with a block device to a separate function. This will allow to implement additional processing for ordinary files. Please note, that xfs_code has been moved before checking for s->has_write_zeroes as xfs_write_zeroes does not touch this flag inside. This makes code a bit more con

Re: [Qemu-devel] [PATCH 1/7] block/raw-posix: create translate_err helper to merge errno values

2015-01-30 Thread Peter Lieven
Am 30.01.2015 um 09:42 schrieb Denis V. Lunev: > actually the code > if (ret == -ENODEV || ret == -ENOSYS || ret == -EOPNOTSUPP || > ret == -ENOTTY) { > ret = -ENOTSUP; > } > is present twice and will be added a couple more times. Create helper > for this. > > Signed-off-by:

Re: [Qemu-devel] [PATCH 2/7] block/raw-posix: create do_fallocate helper

2015-01-30 Thread Peter Lieven
Am 30.01.2015 um 09:42 schrieb Denis V. Lunev: > The pattern > do { > if (fallocate(s->fd, mode, offset, len) == 0) { > return 0; > } > } while (errno == EINTR); > ret = translate_err(-errno); > will be commonly useful in next patches. Create helper for it. >

Re: [Qemu-devel] [PATCH 2/7] block/raw-posix: create do_fallocate helper

2015-01-30 Thread Denis V. Lunev
On 30/01/15 11:47, Peter Lieven wrote: Am 30.01.2015 um 09:42 schrieb Denis V. Lunev: The pattern do { if (fallocate(s->fd, mode, offset, len) == 0) { return 0; } } while (errno == EINTR); ret = translate_err(-errno); will be commonly useful in next

Re: [Qemu-devel] [PATCH 2/7] block/raw-posix: create do_fallocate helper

2015-01-30 Thread Peter Lieven
Am 30.01.2015 um 09:49 schrieb Denis V. Lunev: > On 30/01/15 11:47, Peter Lieven wrote: >> Am 30.01.2015 um 09:42 schrieb Denis V. Lunev: >>> The pattern >>> do { >>> if (fallocate(s->fd, mode, offset, len) == 0) { >>> return 0; >>> } >>> } while (errno == E

Re: [Qemu-devel] [RFC PATCH v1 05/13] spapr: Support ibm, lrdr-capacity device tree property

2015-01-30 Thread Bharata B Rao
On Thu, Jan 22, 2015 at 03:55:40PM -0600, Michael Roth wrote: > Quoting Bharata B Rao (2015-01-08 00:10:12) > > Add support for ibm,lrdr-capacity since this is needed by the guest > > kernel to know about the possible hot-pluggable CPUs and Memory. > > > > Define minimum hotpluggable memory size a

Re: [Qemu-devel] [PATCH 7/8] qmp: print dirty bitmap

2015-01-30 Thread Vladimir Sementsov-Ogievskiy
is it better to add qmp_query_dirty_bitmap with underlying bdrv_query_dirty_bitmap, or to modify (add dirty regions information) existing qmp_query_block/qmp_query_dirty_bitmapS? Best regards, Vladimir On 27.01.2015 18:53, Eric Blake wrote: On 01/13/2015 10:02 AM, Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH RFC 00/10] pci: Partial conversion to realize

2015-01-30 Thread Markus Armbruster
Markus Armbruster writes: > Markus Armbruster writes: > >> Andreas Färber writes: >> >>> Hi Markus, >>> >>> Am 28.10.2014 um 08:35 schrieb Markus Armbruster: While discussing Gonglei's "[PATCH v2 00/19] usb: convert device init to realize", Paolo called the PCI conversion job "Gargant

Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line

2015-01-30 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Eric Blake (ebl...@redhat.com) wrote: > >> On 01/29/2015 09:28 AM, Dr. David Alan Gilbert wrote: > >> > * Eric Blake (ebl...@redhat.com) wrote: > >> > > On 01/29/2015 08:54 AM, Dr. David Alan Gilbert wrote:

Re: [Qemu-devel] [PATCH v2 16/17] ahci: Recompute cur_cmd on migrate post load

2015-01-30 Thread Paolo Bonzini
On 17/12/2014 02:36, John Snow wrote: > When the AHCI HBA device is migrated, all of the information that > led to the request being created is stored in the AHCIDevice > structures, except for pointers into guest data where return > information needs to be stored. > > The "cur_cmd" field is usu

Re: [Qemu-devel] [PATCH v2 17/17] qtest/ide: Test flush / retry for ISA and PCI

2015-01-30 Thread Paolo Bonzini
On 17/12/2014 02:36, John Snow wrote: > This patch adds tests for werror and rerror functionality > for the PCI and ISA ide buses. > > Tests for the AHCI device are to be included at a later > date after requisite patches have been merged upstream > to support needed functionality by the tests.

Re: [Qemu-devel] [PATCH v2 00/17] ide: rerror and werror support for IDE and AHCI

2015-01-30 Thread Paolo Bonzini
On 30/01/2015 01:44, John Snow wrote: > Post-holiday bump that this is sitting out there, awaiting love. > If this gets merged, we should be able to enable Q35 migration soon, > which would be nice. Not sure how valuable my opinion is as the author of around 85% of the series... So I reviewed t

Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line

2015-01-30 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 01/29/2015 01:21 PM, Dr. David Alan Gilbert wrote: > > * Eric Blake (ebl...@redhat.com) wrote: > >> On 01/29/2015 09:28 AM, Dr. David Alan Gilbert wrote: > >>> > >>> So what would the .args_type look like in qmp-commands.hx; something like > >>> this? >

Re: [Qemu-devel] [PATCH v2 14/17] ahci: Migrate IDEStatus

2015-01-30 Thread Paolo Bonzini
On 17/12/2014 02:36, John Snow wrote: > Amazingly, we weren't doing this before. > > Make sure we migrate the IDEState structure that belongs to > the AHCIDevice.IDEBus structure during migrations. > > No version numbering changes because AHCI is not officially > migratable (and we can all see

Re: [Qemu-devel] [PATCH] target-arm: Squash input denormals in FRECPS and FRSQRTS

2015-01-30 Thread Laurent Desnogues
On Thu, Jan 29, 2015 at 8:31 PM, Peter Maydell wrote: > The helper functions for FRECPS and FRSQRTS have special case > handling that includes checks for zero inputs, so squash input > denormals if necessary before those checks. This fixes incorrect > output when the FPCR DZ bit is set to enable s

Re: [Qemu-devel] [RFC 0/1] Incoming migration vs early monitor commands

2015-01-30 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 29/01/2015 16:06, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > The attached patch allows you to execute QMP commands from the command > > line prior to -incoming or loadvm. > > What about doing the opposite

Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line

2015-01-30 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * Eric Blake (ebl...@redhat.com) wrote: >> >> On 01/29/2015 09:28 AM, Dr. David Alan Gilbert wrote: >> >> > * Eric Blake (ebl...@redhat.com) wrote: >> >> > > On 01/29/20

Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line

2015-01-30 Thread Paolo Bonzini
On 30/01/2015 10:38, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: >> On 01/29/2015 01:21 PM, Dr. David Alan Gilbert wrote: >>> * Eric Blake (ebl...@redhat.com) wrote: On 01/29/2015 09:28 AM, Dr. David Alan Gilbert wrote: > > So what would the .args_type loo

Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line

2015-01-30 Thread Daniel P. Berrange
On Fri, Jan 30, 2015 at 09:38:50AM +, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: > > On 01/29/2015 01:21 PM, Dr. David Alan Gilbert wrote: > > > * Eric Blake (ebl...@redhat.com) wrote: > > >> On 01/29/2015 09:28 AM, Dr. David Alan Gilbert wrote: > > >>> > > >>> So w

Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line

2015-01-30 Thread Paolo Bonzini
On 29/01/2015 16:22, Dr. David Alan Gilbert wrote: > I'm a bit worried about whether starting an incoming migrate afterwards is > different in any subtle way. I can see there are a handful of devices that > have 'runstate_check(RUN_STATE_INMIGRATE)' calls in, and thus I'm not sure > that startin

Re: [Qemu-devel] address order of virtio-mmio devices

2015-01-30 Thread Daniel P. Berrange
On Thu, Jan 29, 2015 at 08:05:50PM +, Peter Maydell wrote: > On 29 January 2015 at 19:47, Laszlo Ersek wrote: > > On 01/29/15 20:12, Laszlo Ersek wrote: > >> If the guest kernel changed its "assignment strategy" at some point, but > >> earlier it used to match the comment (and the code), then

Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line

2015-01-30 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 30/01/2015 10:38, Dr. David Alan Gilbert wrote: > > * Eric Blake (ebl...@redhat.com) wrote: > >> On 01/29/2015 01:21 PM, Dr. David Alan Gilbert wrote: > >>> * Eric Blake (ebl...@redhat.com) wrote: > On 01/29/2015 09:28 AM, Dr. David Alan

Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line

2015-01-30 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 29/01/2015 16:22, Dr. David Alan Gilbert wrote: > > I'm a bit worried about whether starting an incoming migrate afterwards is > > different in any subtle way. I can see there are a handful of devices that > > have 'runstate_check(RUN_STATE_I

Re: [Qemu-devel] address order of virtio-mmio devices

2015-01-30 Thread Laszlo Ersek
On 01/30/15 10:54, Daniel P. Berrange wrote: > On Thu, Jan 29, 2015 at 08:05:50PM +, Peter Maydell wrote: >> On 29 January 2015 at 19:47, Laszlo Ersek wrote: >>> On 01/29/15 20:12, Laszlo Ersek wrote: If the guest kernel changed its "assignment strategy" at some point, but earlier it

Re: [Qemu-devel] New IOREQ type -- IOREQ_TYPE_VMWARE_PORT

2015-01-30 Thread Paul Durrant
> -Original Message- > From: Don Slutz [mailto:dsl...@verizon.com] > Sent: 29 January 2015 19:41 > To: Paul Durrant; Don Slutz; qemu-devel@nongnu.org; Stefano Stabellini > Cc: Peter Maydell; Olaf Hering; Alexey Kardashevskiy; Stefan Weil; Michael > Tokarev; Alexander Graf; Gerd Hoffmann; St

Re: [Qemu-devel] [PATCH v11 00/13] block: Incremental backup series

2015-01-30 Thread Vladimir Sementsov-Ogievskiy
About added functions for BdrvDirtyBitmap: some functions has needless BlockDriverState* parameter, and others - doesn't: with needless *bs: bdrv_dirty_bitmap_make_anon bdrv_dirty_bitmap_granularity bdrv_clear_dirty_bitmap without *bs: bdrv_dirty_bitmap_enabled bdrv_disable_dirty_bitmap bdrv_

Re: [Qemu-devel] [PATCH v2 09/11] target-arm: Use mmu_idx in get_phys_addr()

2015-01-30 Thread Peter Maydell
On 30 January 2015 at 02:03, Edgar E. Iglesias wrote: > On Thu, Jan 29, 2015 at 06:55:15PM +, Peter Maydell wrote: >> Now we have the mmu_idx in get_phys_addr(), use it correctly to >> determine the behaviour of virtual to physical address translations, >> rather than using just an is_user fla

Re: [Qemu-devel] [PATCH v2 2/4] pci: Add generic PCIe host bridge

2015-01-30 Thread Paolo Bonzini
On 29/01/2015 15:25, Peter Maydell wrote: > > Ah, right, I forgot about that. Unfortunately I can't reserve PCI IDs in > > the Red Hat PCI range. > > > > Michael, what's the process here? > > Last time this came up I think Paolo said the official registration > was getting a patch into QEMU maste

Re: [Qemu-devel] QEMU and Real Time OS

2015-01-30 Thread Marc Marí
El Fri, 30 Jan 2015 08:37:47 +0100 Jan Kiszka escribió: > On 2015-01-30 00:06, Paolo Bonzini wrote: > > > > > > On 29/01/2015 20:37, Marc Marí wrote: > >> Is this an expected behaviour? I can't see why. > >> > >> I'd like to know if there is a certain reason why it doesn't work. > >> Or if it sh

Re: [Qemu-devel] [RFC 1/1] Execute arbitrary QMP commands from command line

2015-01-30 Thread Paolo Bonzini
On 30/01/2015 11:02, Dr. David Alan Gilbert wrote: > Yes; I've not got a clue what it's effect is, but given it's glued into > the block code I'm sure that breaking it will be subtle and nasty. I'm > also reasonably sure it's probably going to do something different in the > loadvm > case which

Re: [Qemu-devel] address order of virtio-mmio devices

2015-01-30 Thread Peter Maydell
On 30 January 2015 at 09:54, Daniel P. Berrange wrote: > While it is clear there is no solution that works correctly with all > kernels, I hate to think that we're going to stick with an ordering > that is clearly wrong for modern kernels, forever going forward. The > aarch64 world is only just st

Re: [Qemu-devel] QEMU and Real Time OS

2015-01-30 Thread Frederic Konrad
On 30/01/2015 11:26, Marc Marí wrote: El Fri, 30 Jan 2015 08:37:47 +0100 Jan Kiszka escribió: On 2015-01-30 00:06, Paolo Bonzini wrote: On 29/01/2015 20:37, Marc Marí wrote: Is this an expected behaviour? I can't see why. I'd like to know if there is a certain reason why it doesn't work. Or

Re: [Qemu-devel] QEMU and Real Time OS

2015-01-30 Thread Marc Marí
El Fri, 30 Jan 2015 11:36:37 +0100 Frederic Konrad escribió: > On 30/01/2015 11:26, Marc Marí wrote: > > El Fri, 30 Jan 2015 08:37:47 +0100 > > Jan Kiszka escribió: > >> On 2015-01-30 00:06, Paolo Bonzini wrote: > >>> > >>> On 29/01/2015 20:37, Marc Marí wrote: > Is this an expected behaviou

Re: [Qemu-devel] [PATCH v2 00/11] target-arm: handle mmu_idx/translation regimes properly

2015-01-30 Thread Peter Maydell
On 30 January 2015 at 01:36, Edgar E. Iglesias wrote: > IIRC, last time the dedicated S-EL0 and S-EL1 MMU idx came up the > discussion went around flushing the qemu tlbs when switching between > S/NS. Having the dedicated MMU-idx is faster but for Aarch64 I think > we would need logic in at least

Re: [Qemu-devel] [RFC PATCH v8 15/21] aio: replace stack of bottom halves with queue

2015-01-30 Thread Paolo Bonzini
On 22/01/2015 09:52, Pavel Dovgalyuk wrote: > Bottom halves in AIO context are stored and removes > in LIFO order. It makes their execution non-deterministic. > This patch replaces the stack with queue to preserve the > order of bottom halves processing. > > Signed-off-by: Pavel Dovgalyuk > ---

Re: [Qemu-devel] QEMU and Real Time OS

2015-01-30 Thread Jan Kiszka
On 2015-01-30 11:36, Frederic Konrad wrote: > On 30/01/2015 11:26, Marc Marí wrote: >> El Fri, 30 Jan 2015 08:37:47 +0100 >> Jan Kiszka escribió: >>> On 2015-01-30 00:06, Paolo Bonzini wrote: On 29/01/2015 20:37, Marc Marí wrote: > Is this an expected behaviour? I can't see why.

Re: [Qemu-devel] address order of virtio-mmio devices

2015-01-30 Thread Daniel P. Berrange
On Fri, Jan 30, 2015 at 10:29:46AM +, Peter Maydell wrote: > On 30 January 2015 at 09:54, Daniel P. Berrange wrote: > > While it is clear there is no solution that works correctly with all > > kernels, I hate to think that we're going to stick with an ordering > > that is clearly wrong for mod

Re: [Qemu-devel] [RFC PATCH v8 16/21] replay: bottom halves

2015-01-30 Thread Paolo Bonzini
On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > This patch introduces bottom half event for replay queue. It saves the events > into the queue and process them at the checkpoints and instructions execution. Which bottom halves must _not_ go through aio/qemu_bh_new_replay? > +QEMUBH *aio_bh_new_re

Re: [Qemu-devel] [RFC PATCH v8 20/21] replay: command line options

2015-01-30 Thread Paolo Bonzini
On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > This patch introduces command line options for enabling recording or replaying > virtual machine behavior. "-record" option starts recording of the execution > and saves it into the log, specified with "fname" parameter. "-replay" option > is intended

Re: [Qemu-devel] address order of virtio-mmio devices

2015-01-30 Thread Peter Maydell
On 30 January 2015 at 10:48, Daniel P. Berrange wrote: > Long term though it will be much better of AArch64 would just do PCI > instead of MMIO bus. Then we have proper device addressing which we > can control in a predictable manner that will be stable across hotplug > and unplug and migration.

Re: [Qemu-devel] [RFC PATCH v8 19/21] replay: initialization and deinitialization

2015-01-30 Thread Paolo Bonzini
On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > This patch introduces the functions for enabling the record/replay and for > freeing the resources when simulator closes. > > Signed-off-by: Pavel Dovgalyuk > --- > block.c |2 - > exec.c |1 > replay/rep

Re: [Qemu-devel] [RFC PATCH v8 14/21] replay: checkpoints

2015-01-30 Thread Paolo Bonzini
On 22/01/2015 09:52, Pavel Dovgalyuk wrote: > This patch introduces checkpoints that synchronize cpu thread and iothread. > When checkpoint is met in the code all asynchronous events from the queue > are executed. > > Signed-off-by: Pavel Dovgalyuk I cannot understand this patch. Please docum

Re: [Qemu-devel] [RFC PATCH v8 17/21] replay: replay aio requests

2015-01-30 Thread Paolo Bonzini
On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > This patch adds identifier to aio requests. ID is used for creating bottom > halves and identifying them while replaying. > The patch also introduces several functions that make possible replaying > of the aio requests. > > Signed-off-by: Pavel Dovga

Re: [Qemu-devel] [RFC PATCH v8 18/21] replay: thread pool

2015-01-30 Thread Paolo Bonzini
On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > -return thread_pool_submit_aio(pool, aio_worker, acb, cb, opaque); > +return thread_pool_submit_aio(pool, aio_worker, acb, cb, opaque, > + qiov ? qiov->replay : false, > + qiov

Re: [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input

2015-01-30 Thread Paolo Bonzini
On 22/01/2015 09:53, Pavel Dovgalyuk wrote: > +void replay_input_event(QemuConsole *src, InputEvent *evt) > +{ > +if (replay_mode == REPLAY_MODE_PLAY) { > +/* Nothing */ > +} else if (replay_mode == REPLAY_MODE_RECORD) { > +replay_add_input_event(evt); Does replay_add_inp

Re: [Qemu-devel] [RFC PATCH v8 00/21] Deterministic replay core

2015-01-30 Thread Paolo Bonzini
On 29/01/2015 11:21, Paolo Bonzini wrote: > > > On 28/01/2015 12:45, Pavel Dovgaluk wrote: >> Ping? > > Reviewed 13 patches out of 21. Made some comments, but overall I'm > really pleased. Thanks for persisting! > > Will continue tomorrow. The second part has a few more problems: 1) some

Re: [Qemu-devel] address order of virtio-mmio devices

2015-01-30 Thread Peter Maydell
On 30 January 2015 at 10:54, Peter Maydell wrote: > On 30 January 2015 at 10:48, Daniel P. Berrange wrote: >> Long term though it will be much better of AArch64 would just do PCI >> instead of MMIO bus. Then we have proper device addressing which we >> can control in a predictable manner that wil

Re: [Qemu-devel] address order of virtio-mmio devices

2015-01-30 Thread Laszlo Ersek
On 01/30/15 11:48, Daniel P. Berrange wrote: > On Fri, Jan 30, 2015 at 10:29:46AM +, Peter Maydell wrote: >> On 30 January 2015 at 09:54, Daniel P. Berrange wrote: >>> While it is clear there is no solution that works correctly with all >>> kernels, I hate to think that we're going to stick wi

Re: [Qemu-devel] address order of virtio-mmio devices

2015-01-30 Thread Laszlo Ersek
On 01/30/15 11:54, Peter Maydell wrote: > On 30 January 2015 at 10:48, Daniel P. Berrange wrote: >> Long term though it will be much better of AArch64 would just do PCI >> instead of MMIO bus. Then we have proper device addressing which we >> can control in a predictable manner that will be stable

Re: [Qemu-devel] address order of virtio-mmio devices

2015-01-30 Thread Peter Maydell
On 30 January 2015 at 11:38, Laszlo Ersek wrote: > Please note that (as far as I understand) the patch that I referenced is > indeed very new, it's not part of v3.18, but the reversal can easily be > seen with v3.18. In other words, the kernel patch I referenced > introduces no functional change,

Re: [Qemu-devel] address order of virtio-mmio devices

2015-01-30 Thread Peter Maydell
On 30 January 2015 at 11:39, Laszlo Ersek wrote: > On 01/30/15 11:54, Peter Maydell wrote: >> On 30 January 2015 at 10:48, Daniel P. Berrange wrote: >>> Long term though it will be much better of AArch64 would just do PCI >>> instead of MMIO bus. Then we have proper device addressing which we >>>

Re: [Qemu-devel] [PATCH v6 3/5] acpi: add build_append_namestring() helper

2015-01-30 Thread Igor Mammedov
On Wed, 28 Jan 2015 17:16:17 +0200 "Michael S. Tsirkin" wrote: > On Wed, Jan 28, 2015 at 02:34:48PM +, Igor Mammedov wrote: > > Use build_append_namestring() instead of build_append_nameseg() > > So user won't have to care whether name is NameSeg, NamePath or > > NameString. > > > > See for

Re: [Qemu-devel] address order of virtio-mmio devices

2015-01-30 Thread Laszlo Ersek
On 01/30/15 12:40, Peter Maydell wrote: > On 30 January 2015 at 11:38, Laszlo Ersek wrote: >> Please note that (as far as I understand) the patch that I referenced is >> indeed very new, it's not part of v3.18, but the reversal can easily be >> seen with v3.18. In other words, the kernel patch I r

Re: [Qemu-devel] address order of virtio-mmio devices

2015-01-30 Thread Peter Maydell
On 30 January 2015 at 11:48, Laszlo Ersek wrote: > On 01/30/15 12:40, Peter Maydell wrote: >> Just as a sanity check, do we actually have an old kernel that >> enumerates in the opposite order (as opposed to my two-year-old >> "I'm sure this used to be right" memories...) ? > > I never saw one. :)

[Qemu-devel] [PATCH] Fix comparisons between implicit booleans and integers.

2015-01-30 Thread Richard W.M. Jones
In GCC 5 there is a new warning (-Wlogical-not-parentheses) which prevents you from writing: if ( == ) ... A typical error would be: kvm-all.c: In function ‘kvm_set_migration_log’: kvm-all.c:383:54: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-pa

Re: [Qemu-devel] [PATCH 0/7] MIPS: IEEE 754-2008 features support

2015-01-30 Thread Peter Maydell
On 9 December 2014 at 01:54, Maciej W. Rozycki wrote: > This patch series comprises changes to QEMU, both the MIPS backend and > generic SoftFloat support code, to support IEEE 754-2008 features > introduced to revision 3.50 of the MIPS Architecture as follows. Just to let you know that: (1) the

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-01-30 Thread Markus Armbruster
Gonglei writes: > On 2015/1/30 15:46, Markus Armbruster wrote: > >> Gonglei writes: >> >>> On 2015/1/30 0:03, Alexander Graf wrote: >>> On 29.01.15 14:29, arei.gong...@huawei.com wrote: > From: Gonglei > > If boot order is invaild or is set failed, > exit qemu. >

Re: [Qemu-devel] [PATCH] Fix comparisons between implicit booleans and integers.

2015-01-30 Thread Paolo Bonzini
On 30/01/2015 12:52, Richard W.M. Jones wrote: > In GCC 5 there is a new warning (-Wlogical-not-parentheses) which > prevents you from writing: > > if ( == ) ... > > A typical error would be: > > kvm-all.c: In function ‘kvm_set_migration_log’: > kvm-all.c:383:54: error: logical not is only a

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-01-30 Thread Gonglei
On 2015/1/30 20:01, Markus Armbruster wrote: > Gonglei writes: > >> On 2015/1/30 15:46, Markus Armbruster wrote: >> >>> Gonglei writes: >>> On 2015/1/30 0:03, Alexander Graf wrote: > > > On 29.01.15 14:29, arei.gong...@huawei.com wrote: >> From: Gonglei >> >>

Re: [Qemu-devel] [PATCH] vhost-scsi: introduce an ioctl to get the minimum tpgt

2015-01-30 Thread Gonglei
On 2015/1/26 21:13, Gonglei (Arei) wrote: > From: Gonglei > > In order to support to assign a boot order for > vhost-scsi device, we should get the tpgt for > user level (such as Qemu). and at present, we > only support the minimum tpgt can boot. > Ping... > Signed-off-by: Gonglei > Signed-o

Re: [Qemu-devel] [RFC][PATCH 1/1] libxl: add one machine property to support IGD GFX passthrough

2015-01-30 Thread Wei Liu
On Fri, Jan 30, 2015 at 08:56:48AM +0800, Chen, Tiejun wrote: [...] > >>> > >>>Just remember to handle old option in libxl if your old option is already > >>>released by some older version of QEMUs. > >> > >>I just drop that old option, -gfx_passthru, if we're under qemu upstream > >>circumstance,

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-01-30 Thread Markus Armbruster
Gonglei writes: > On 2015/1/30 20:01, Markus Armbruster wrote: > >> Gonglei writes: >> >>> On 2015/1/30 15:46, Markus Armbruster wrote: >>> Gonglei writes: > On 2015/1/30 0:03, Alexander Graf wrote: > >> >> >> On 29.01.15 14:29, arei.gong...@huawei.com wrote:

[Qemu-devel] [PATCH] target-arm: check that LSB <= MSB in BFI instruction

2015-01-30 Thread Kirill Batuzov
The documentation states that if LSB > MSB in BFI instruction behaviour is unpredictable. Currently QEMU crashes because of assertion failure in this case: tcg/tcg-op.h:2061: tcg_gen_deposit_i32: Assertion `len <= 32' failed. While assertion failure may meet the "unpredictable" definition this be

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-01-30 Thread Gonglei
On 2015/1/30 20:32, Markus Armbruster wrote: > Gonglei writes: > >> On 2015/1/30 20:01, Markus Armbruster wrote: >> >>> Gonglei writes: >>> On 2015/1/30 15:46, Markus Armbruster wrote: > Gonglei writes: > >> On 2015/1/30 0:03, Alexander Graf wrote: >> >>> >>>

Re: [Qemu-devel] [PATCH] target-arm: check that LSB <= MSB in BFI instruction

2015-01-30 Thread Peter Maydell
On 30 January 2015 at 12:36, Kirill Batuzov wrote: > The documentation states that if LSB > MSB in BFI instruction behaviour > is unpredictable. Currently QEMU crashes because of assertion failure in > this case: > > tcg/tcg-op.h:2061: tcg_gen_deposit_i32: Assertion `len <= 32' failed. > > While a

Re: [Qemu-devel] -device xen-platform crashes

2015-01-30 Thread Stefano Stabellini
On Fri, 30 Jan 2015, Markus Armbruster wrote: > Stefano Stabellini writes: > > > On Thu, 29 Jan 2015, Markus Armbruster wrote: > >> Stefano Stabellini writes: > >> > >> > On Thu, 29 Jan 2015, Markus Armbruster wrote: > >> >> Reproducer: qemu -nodefaults -S -display none -device xen-platform > >

Re: [Qemu-devel] [RFC PATCH v8 04/21] replay: internal functions for replay log

2015-01-30 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:51, Pavel Dovgalyuk wrote: > > This patch adds functions to perform read and write operations > > with replay log. > > > > Signed-off-by: Pavel Dovgalyuk > > --- > > +void replay_check_error(void) > > Could this be static? (I h

[Qemu-devel] [PATCH v2] target-arm: check that LSB <= MSB in BFI instruction

2015-01-30 Thread Kirill Batuzov
The documentation states that if LSB > MSB in BFI instruction behaviour is unpredictable. Currently QEMU crashes because of assertion failure in this case: tcg/tcg-op.h:2061: tcg_gen_deposit_i32: Assertion `len <= 32' failed. While assertion failure may meet the "unpredictable" definition this be

Re: [Qemu-devel] [RFC PATCH v8 04/21] replay: internal functions for replay log

2015-01-30 Thread Paolo Bonzini
On 30/01/2015 13:56, Pavel Dovgaluk wrote: > > Could this be static? (I haven't checked). > > No, because it is used from several replay files. I wonder if that's a layering violation. > > Perhaps qemu_system_vmstop_request_prepare + > > qemu_system_vmstop_request(RUN_STATE_PAUSED) instead of

Re: [Qemu-devel] [RFC PATCH v8 04/21] replay: internal functions for replay log

2015-01-30 Thread Mark Burton
I believe thats what we concluded too Cheers Mark. > On 30 Jan 2015, at 14:06, Paolo Bonzini wrote: > > > > On 30/01/2015 13:56, Pavel Dovgaluk wrote: >>> Could this be static? (I haven't checked). >> >> No, because it is used from several replay files. > > I wonder if that's a layering viol

Re: [Qemu-devel] [PATCH v2 1/3] vnc: fix qemu crash when not configure vnc option

2015-01-30 Thread Don Slutz
On 01/29/15 21:14, arei.gong...@huawei.com wrote: > From: Gonglei > > Add missing vnc options: to, ipv4, ipv6 and fix > qemu crash. > > Reproducer: > $ x86_64-softmmu/qemu-system-x86_64 > qemu-system-x86_64: Invalid parameter 'to' > Segmentation fault (core dumped) > > BTW the patch fix the bel

[Qemu-devel] [PATCH v7 3/5] acpi: drop min-bytes in build_package()

2015-01-30 Thread Igor Mammedov
Signed-off-by: Igor Mammedov Reviewed-by: Claudio Fontana Reviewed-by: Marcel Apfelbaum --- hw/acpi/aml-build.c | 14 -- hw/i386/acpi-build.c| 13 ++--- include/hw/acpi/aml-build.h | 4 ++-- 3 files changed, 12 insertions(+), 19 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH v7 0/5] pc: acpi: various fixes and cleanups

2015-01-30 Thread Igor Mammedov
NOTE to maintainer: please update test data (ACPI blobs) in test cases changes from v6: * drop "[PATCH v6 1/5] pc: acpi-build: cleanup AcpiPmInfo initialization" * fixup and cleanup build_append_namestring patch as Michael requested * add extra patch based on "acpi-build: skip hotplugged bridge

[Qemu-devel] [PATCH v7 1/5] acpi: move generic aml building helpers into dedictated file

2015-01-30 Thread Igor Mammedov
the will be later used for composing AML primitives and all that could be reused later for ARM machines as well. Signed-off-by: Igor Mammedov Acked-by: Marcel Apfelbaum --- v4: * rename acpi_gen_utils.[ch] to aml-build.[ch] * fix Copyright from 2014 to 2015 v3: * rename acpi_gen_utils.[ch]

[Qemu-devel] [PATCH v7 5/5] acpi-build: skip hotplugged bridges

2015-01-30 Thread Igor Mammedov
Hotplugged bridges don't get bsel allocated so acpi hotplug doesn't work for them anyway, also it causes ACPI tables size change across reboot when bridge was hotplugged before reboot, which doesn't work with immutable RSDP. This patch works around static RSDP issue, where if ACPI tables blob chang

[Qemu-devel] [PATCH v7 4/5] pc: acpi-build: simplify PCI bus tree generation

2015-01-30 Thread Igor Mammedov
it basicaly does the same as original approach, * just without bus/notify tables tracking (less obscure) which is easier to follow. * drops unnecessary loops and bitmaps, creating devices and notification method in the same loop. * saves us ~100LOC Signed-off-by: Igor Mammedov Reviewed-by: Ma

[Qemu-devel] [PATCH v7 2/5] acpi: add build_append_namestring() helper

2015-01-30 Thread Igor Mammedov
Use build_append_namestring() instead of build_append_nameseg() So user won't have to care whether name is NameSeg, NamePath or NameString. See for reference ACPI 5.0: 20.2.2 Name Objects Encoding Signed-off-by: Igor Mammedov --- v5: * replace g_array_append_val() with build_append_byte() and

[Qemu-devel] [Bug 1397157] Re: cpu high with ps2 keyboard on multi-core win7 guest os

2015-01-30 Thread Dr. David Alan Gilbert
Thanks; I see your matching RH bugzilla entry; https://bugzilla.redhat.com/show_bug.cgi?id=1169267 ** Bug watch added: Red Hat Bugzilla #1169267 https://bugzilla.redhat.com/show_bug.cgi?id=1169267 -- You received this bug notification because you are a member of qemu- devel-ml, which is subsc

Re: [Qemu-devel] [PATCH 1/2] acpi-build: fix memory leak with bridge hp off

2015-01-30 Thread Igor Mammedov
On Wed, 28 Jan 2015 18:30:34 +0200 "Michael S. Tsirkin" wrote: > When bridge hotplug is disabled for old machine types, > we never free memory allocated for temporary tables. > Fix this up. patch "pc: acpi-build: simplify PCI bus tree generation" http://lists.gnu.org/archive/html/qemu-devel/2015-

Re: [Qemu-devel] [PATCH] quorum: don't share qiov

2015-01-30 Thread Kevin Wolf
Am 30.01.2015 um 09:07 hat Wen Congyang geschrieben: > If the child touches qiov->iov, it will cause unexpected results. > > Signed-off-by: Wen Congyang Any specific child you're thinking of? I think children are not supposed to modify their qiov (which would also fail for init_external qiovs).

Re: [Qemu-devel] [PATCH 0/7] MIPS: IEEE 754-2008 features support

2015-01-30 Thread Maciej W. Rozycki
On Fri, 30 Jan 2015, Peter Maydell wrote: > > This patch series comprises changes to QEMU, both the MIPS backend and > > generic SoftFloat support code, to support IEEE 754-2008 features > > introduced to revision 3.50 of the MIPS Architecture as follows. > > Just to let you know that: > (1) the

Re: [Qemu-devel] [PATCH RFC v6 18/20] virtio: support revision-specific features

2015-01-30 Thread Cornelia Huck
On Wed, 7 Jan 2015 21:10:07 +0200 "Michael S. Tsirkin" wrote: > On Wed, Jan 07, 2015 at 05:22:32PM +0100, Cornelia Huck wrote: > > On Sun, 28 Dec 2014 10:32:06 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Dec 11, 2014 at 02:25:20PM +0100, Cornelia Huck wrote: > > > > Devices may supp

Re: [Qemu-devel] [PATCH v2 3/7] softfloat: Convert `*_default_nan' variables into inline functions

2015-01-30 Thread Leon Alrae
On 12/12/2014 19:34, Maciej W. Rozycki wrote: > Mechanically replace `*_default_nan' variables with inline functions and > convert references accordingly. Use `__inline__' rather than `inline' > so that the latter does not cause the definitions to become static as a > result of macro expansion,

Re: [Qemu-devel] [PATCH RFC v6 19/20] virtio-blk: revision specific feature bits

2015-01-30 Thread Cornelia Huck
On Wed, 7 Jan 2015 21:11:44 +0200 "Michael S. Tsirkin" wrote: > On Wed, Jan 07, 2015 at 05:29:49PM +0100, Cornelia Huck wrote: > > On Sun, 28 Dec 2014 12:24:46 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Dec 11, 2014 at 02:25:21PM +0100, Cornelia Huck wrote: > > > > Wire up virtio-b

Re: [Qemu-devel] [PATCH] target-arm: Squash input denormals in FRECPS and FRSQRTS

2015-01-30 Thread Greg Bellows
On Fri, Jan 30, 2015 at 3:41 AM, Laurent Desnogues < laurent.desnog...@gmail.com> wrote: > On Thu, Jan 29, 2015 at 8:31 PM, Peter Maydell > wrote: > > The helper functions for FRECPS and FRSQRTS have special case > > handling that includes checks for zero inputs, so squash input > > denormals if

  1   2   3   >