* Eric Blake (ebl...@redhat.com) wrote: > On 01/29/2015 01:21 PM, Dr. David Alan Gilbert wrote: > > * Eric Blake (ebl...@redhat.com) wrote: > >> On 01/29/2015 09:28 AM, Dr. David Alan Gilbert wrote: > >>> > >>> So what would the .args_type look like in qmp-commands.hx; something like > >>> this? > >>> > >>> .args-type = "type:s,port:-i,host:-s,command:-s" > >> > >> No, it would be more like the blockdev-add interface, where one command > >> accepts a dictionary object containing a union of valid values, where > >> the set of valid values is determined by the discriminator field. > >> .args_type = "options:q". > > > > What causes the parser to generate a 'BlockdevOptions' as opposed to any > > standard options type for the parameter of qmp_blockdev_add? > > Kevin Wolf has the most experience here, as he was the one that figured > out how to correlate command line and QMP as part of adding blockdev-add.
OK, this is getting more complicated than I'd expected; how about a simpler suggestion. The current suggestion is: Modify -incoming to take 'pause' as an argument Add migrate-incoming command that takes parsed URI New suggestion: Modify -incoming to take a pause: prefix (e.g. -incoming pause:tcp:host:port ) Add migrate-incoming-start command (takes no arguments). It seems simpler. Dave > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
