On Fri, Jan 30, 2015 at 09:38:50AM +0000, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: > > On 01/29/2015 01:21 PM, Dr. David Alan Gilbert wrote: > > > * Eric Blake (ebl...@redhat.com) wrote: > > >> On 01/29/2015 09:28 AM, Dr. David Alan Gilbert wrote: > > >>> > > >>> So what would the .args_type look like in qmp-commands.hx; something > > >>> like this? > > >>> > > >>> .args-type = "type:s,port:-i,host:-s,command:-s" > > >> > > >> No, it would be more like the blockdev-add interface, where one command > > >> accepts a dictionary object containing a union of valid values, where > > >> the set of valid values is determined by the discriminator field. > > >> .args_type = "options:q". > > > > > > What causes the parser to generate a 'BlockdevOptions' as opposed to any > > > standard options type for the parameter of qmp_blockdev_add? > > > > Kevin Wolf has the most experience here, as he was the one that figured > > out how to correlate command line and QMP as part of adding blockdev-add. > > OK, this is getting more complicated than I'd expected; how about a simpler > suggestion. > > The current suggestion is: > Modify -incoming to take 'pause' as an argument > Add migrate-incoming command that takes parsed URI
FWIW, the existing source side 'migrate' command already expects URI string, so personally I'm fine with the dest side 'migrate-incoming' also taking a URI string. I don't think we need to explode the URI into its pieces. URI is a well defined data format we should feel free to use when appropriate. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
