Re: [Qemu-devel] qemu sources and makefile system

2015-01-07 Thread Stefan Hajnoczi
On Tue, Jan 06, 2015 at 11:44:34AM +0200, Catalin Vasile wrote: > I'm new to qemu-devel and I'm trying to add a ".c" source to qemu. > To be more specific, I'm trying to add a file into /hw/virtio/. > I've added "common-obj-y += virtio-src.o" to the Makefile.objs in that > folder > and when I'm com

Re: [Qemu-devel] [PATCH v2 01/10] pci: move REDHAT_SDHCI device ID to make room for Rocker

2015-01-07 Thread Peter Maydell
On 7 January 2015 at 07:47, Paolo Bonzini wrote: > > > On 06/01/2015 10:52, Peter Maydell wrote: >> On 6 January 2015 at 02:24, wrote: >>> From: Scott Feldman >>> >>> The rocker device uses same PCI device ID as sdhci. Since rocker device >>> driver >>> has already been accepted into Linux 3.

Re: [Qemu-devel] [PATCH v3] vl.c: fix regression when reading machine type from config file

2015-01-07 Thread William Dauchy
On Jan07 14:11, Marcel Apfelbaum wrote: > After 'Machine as QOM' series the machine type input triggers > the creation of the machine class. > If the machine type is set in the configuration file, the machine > class is not updated accordingly and remains the default. I have also tested it; it doe

Re: [Qemu-devel] [PULL 0/8] pc: resizeable ROM blocks

2015-01-07 Thread Michael S. Tsirkin
On Wed, Jan 07, 2015 at 11:52:40AM +0100, Paolo Bonzini wrote: > Maybe it's too optimistic. That's why I'm saying do not trim the tables > for a couple releases more. I think it is too optimistic, and not trimming the tables does not solve it convincingly enough to my taste. > If you have a bug,

Re: [Qemu-devel] [PATCH v2] vl.c: fix regression when reading machine type from config file

2015-01-07 Thread Paolo Bonzini
On 07/01/2015 12:34, Marcel Apfelbaum wrote: > After 'Machine as QOM' series the machine type input triggers > the creation of the machine class. > If the machine type is set in the configuration file, the machine > class is not updated accordingly and remains the default. > > Fixed that by quer

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Marcel Apfelbaum
On 01/07/2015 01:15 PM, Alexander Graf wrote: On 07.01.15 12:07, Paolo Bonzini wrote: On 07/01/2015 12:03, Marcel Apfelbaum wrote: While I agree it will be better if we place this in instance_init, setting the machine_usb to defaults_enabled() there would be problematic since it depends on

Re: [Qemu-devel] [PATCH 09/10] block/dmg: support bzip2 block entry types

2015-01-07 Thread Paolo Bonzini
On 07/01/2015 11:31, Peter Wu wrote: > Already taken care of in v2 which was posted to the list yesterday :-) > > I named it "BZIP2_LIBS" though (matching the package name). Great. :) Paolo

Re: [Qemu-devel] [PATCH v3] vl.c: fix regression when reading machine type from config file

2015-01-07 Thread Paolo Bonzini
On 07/01/2015 13:11, Marcel Apfelbaum wrote: > After 'Machine as QOM' series the machine type input triggers > the creation of the machine class. > If the machine type is set in the configuration file, the machine > class is not updated accordingly and remains the default. > > Fixed that by quer

Re: [Qemu-devel] [PATCH v2 01/10] pci: move REDHAT_SDHCI device ID to make room for Rocker

2015-01-07 Thread Paolo Bonzini
On 06/01/2015 10:52, Peter Maydell wrote: > On 6 January 2015 at 02:24, wrote: >> From: Scott Feldman >> >> The rocker device uses same PCI device ID as sdhci. Since rocker device >> driver >> has already been accepted into Linux 3.18, and REDHAT_SDHCI device ID isn't >> used by any drivers,

Re: [Qemu-devel] [PATCH v2 11/12] block/dmg: support bzip2 block entry types

2015-01-07 Thread Paolo Bonzini
On 06/01/2015 18:48, Peter Wu wrote: > v2: split block type check into a different patch ("[PATCH v2 10/12] > block/dmg: factor out block type check"). > Add BZIP2_LIBS instead of polluting libs_softmmu with -lbz2 (which > would also end up in fsdev/virtfs-proxy-helper). > Fix

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Paolo Bonzini
On 07/01/2015 12:03, Marcel Apfelbaum wrote: > > While I agree it will be better if we place this in instance_init, > setting the machine_usb to defaults_enabled() there would be problematic > since it depends on > - papr_vga_init(phb->bus) for sparpr and That's effectively vga_interface_type

Re: [Qemu-devel] [PULL 1/8] cpu: add cpu_physical_memory_clear_dirty_range_nocode

2015-01-07 Thread Paolo Bonzini
On 24/12/2014 12:51, Michael S. Tsirkin wrote: > simple wrapper so callers don't need to know about > dirty bitmap clients. > > Signed-off-by: Michael S. Tsirkin > --- > include/exec/ram_addr.h | 8 > 1 file changed, 8 insertions(+) > > diff --git a/include/exec/ram_addr.h b/include/

Re: [Qemu-devel] [PULL 5/8] exec: qemu_ram_alloc_resizeable, qemu_ram_resize

2015-01-07 Thread Michael S. Tsirkin
On Wed, Jan 07, 2015 at 08:18:02AM +0100, Paolo Bonzini wrote: > > > On 24/12/2014 12:51, Michael S. Tsirkin wrote: > > +/* On-device RAM allocated with g_malloc: supports realloc, > > + * not accessible to vcpu on kvm. > > + */ > > Is this still true? > > Paolo No! Will drop.

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-07 Thread Stefan Hajnoczi
On Tue, Jan 06, 2015 at 03:29:11PM +0200, Marcel Apfelbaum wrote: > Patch e79d5a6 ("machine: remove qemu_machine_opts global list") removed option > descriptions from the -machine QemuOptsList to avoid repeating MachineState's > QOM properties. > > This resulted in a Qemu crash: > $ qemu-system-x

[Qemu-devel] [PATCH v3] vl.c: fix regression when reading machine type from config file

2015-01-07 Thread Marcel Apfelbaum
After 'Machine as QOM' series the machine type input triggers the creation of the machine class. If the machine type is set in the configuration file, the machine class is not updated accordingly and remains the default. Fixed that by querying the machine options after the configuration file is lo

[Qemu-devel] [PATCH V2] char: restore stdio echo on resume from suspend.

2015-01-07 Thread Gal Hammer
The monitor's auto-completion feature stopped working when stdio is used as an input and qemu was resumed after it was suspended (using ctrl-z). Signed-off-by: Gal Hammer --- V2 - restore old echo state rather than alway disable it. - don't check signal identifier in the handler function. -

Re: [Qemu-devel] [PATCH 1/1] ich9: add disable_s3, disable_s4, s4_val properties

2015-01-07 Thread Paolo Bonzini
On 05/01/2015 13:23, Amit Shah wrote: > I modeled this based on how i440fx works, so there's also the case for > keeping things similar to an existing implementation... Yes, I agree. Paolo

Re: [Qemu-devel] [PULL 0/8] pc: resizeable ROM blocks

2015-01-07 Thread Michael S. Tsirkin
On Wed, Jan 07, 2015 at 08:33:07AM +0100, Paolo Bonzini wrote: > > > On 24/12/2014 13:41, Michael S. Tsirkin wrote: > >> I don't think these are necessary, and I thought these were just RFC > >> when they were posted. I and mst didn't really understand each other, > >> and I take the fault for n

Re: [Qemu-devel] [PATCH 0/6] relicense QEMU softfloat from 2b to to 2a

2015-01-07 Thread Paolo Bonzini
On 07/01/2015 11:34, Peter Maydell wrote: > The thing is that after all these relicensings we end up with a > file with a mix of licenses in it. So for somebody actually > using the file the controlling license is GPLv2+. (In particular > all the RedHat contributions are GPLv2+, not SoftFloat-2a.

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-07 Thread Paolo Bonzini
On 06/01/2015 22:33, G 3 wrote: > > 00:01.0 VGA compatible controller: Technical Corp. Device (rev > 02) (prog-if 00 [VGA controller]) > Subsystem: Qumranet, Inc. Device 1100 > Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- > ParErr- Stepping- SERR- FastB2B- Dis

[Qemu-devel] [Makefile] Compiling Qemu to dynamic library

2015-01-07 Thread Halsey Pian
Dear All, Recently, I would try to compile qemu to a so in order to call qemu internal functions in my program, I'm trying to do this by steps, 1. Add rules in qemu-2.1.2/ rules.mak %.so: $(call quiet-command,rm -f $@ && $(LINKPROG) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAG

Re: [Qemu-devel] [PULL 0/8] pc: resizeable ROM blocks

2015-01-07 Thread Paolo Bonzini
On 07/01/2015 11:03, Michael S. Tsirkin wrote: > On Wed, Jan 07, 2015 at 08:33:07AM +0100, Paolo Bonzini wrote: >> >> >> On 24/12/2014 13:41, Michael S. Tsirkin wrote: I don't think these are necessary, and I thought these were just RFC when they were posted. I and mst didn't really un

Re: [Qemu-devel] [PATCH 0/4] ARM: Add support for a generic PCI Express host bridge

2015-01-07 Thread Claudio Fontana
Hi Alexander, happy new year! On 06.01.2015 17:03, Alexander Graf wrote: > Linux implements a nice binding to describe a "generic" PCI Express host > bridge > using only device tree. > > This patch set adds enough emulation logic to expose the parts that are > "generic" as a simple sysbus device

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Alexander Graf
On 07.01.15 12:22, Paolo Bonzini wrote: > > > On 07/01/2015 12:15, Alexander Graf wrote: >> >> >> On 07.01.15 12:07, Paolo Bonzini wrote: >>> >>> >>> On 07/01/2015 12:03, Marcel Apfelbaum wrote: While I agree it will be better if we place this in instance_init, setting the machin

Re: [Qemu-devel] [Bug 1404278] Re: tap connections not working on windows host

2015-01-07 Thread Stefan Hajnoczi
On Tue, Jan 06, 2015 at 09:30:46PM -, timsoft wrote: > I have also run the 64bit version of qemu with the slight modification > of the batch/cmd line > > cd "c:\program files\qemu" > qemu-system-x86_64w.exe -m 512 -net nic -net tap,ifname=tap01 -hda > "c:\\data\\images\\test.img" > > and ge

Re: [Qemu-devel] [Bug 1404278] Re: tap connections not working on windows host

2015-01-07 Thread Stefan Hajnoczi
On Tue, Jan 06, 2015 at 09:12:53PM -, timsoft wrote: > output as requested from the guest: > ip addr > 1: lo: mtu 65536 qdisc noqueue state UNKOWN > link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 > inet 127.0.0.1/8 scope host lo >valid_lft forever preferred_lft forever

Re: [Qemu-devel] [PATCH v2 07/10] rocker: add new rocker switch device

2015-01-07 Thread Stefan Hajnoczi
On Tue, Jan 06, 2015 at 08:45:44AM -0800, Scott Feldman wrote: > On Tue, Jan 6, 2015 at 7:12 AM, Stefan Hajnoczi wrote: > > On Mon, Jan 05, 2015 at 06:24:58PM -0800, sfel...@gmail.com wrote: > >> From: Scott Feldman > >> > >> Rocker is a simulated ethernet switch device. The device supports up t

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Alexander Graf
On 07.01.15 12:32, Paolo Bonzini wrote: > > > On 07/01/2015 12:27, Alexander Graf wrote: >>> Hmm, then I guess let's apply these patches and fix things up later? >> >> Certainly works for me ;). > > Send a pull request then. :) Ok, applied the patch set to ppc-next. Now let's see how much of

Re: [Qemu-devel] [PULL 5/8] exec: qemu_ram_alloc_resizeable, qemu_ram_resize

2015-01-07 Thread Paolo Bonzini
On 24/12/2014 12:51, Michael S. Tsirkin wrote: > +/* On-device RAM allocated with g_malloc: supports realloc, > + * not accessible to vcpu on kvm. > + */ Is this still true? Paolo

[Qemu-devel] [RESEND PATCH v1 0/5] Common unplug and unplug request cb for memory and CPU hot-unplug.

2015-01-07 Thread Tang Chen
Memory and CPU hot unplug are both asynchronize procedures. When the unplug operation happens, unplug request cb is called first. And when ghest OS finished handling unplug, unplug cb will be called to do the real removal of device. They both need pc-machine, piix4 and ich9 unplug and unplug reque

[Qemu-devel] [RESEND PATCH v1 2/5] acpi, ich9: Add hotunplug request cb for ich9.

2015-01-07 Thread Tang Chen
Memory and CPU hot unplug are both asynchronize procedures. They both need unplug request cb when the unplug operation happens. This patch adds hotunplug request cb for ich9, and memory and CPU hot unplug will base on it. --- hw/acpi/ich9.c | 7 +++ hw/isa/lpc_ich9.c | 5 +++-- i

[Qemu-devel] [RESEND PATCH v1 3/5] acpi, pc: Add unplug cb for pc machine.

2015-01-07 Thread Tang Chen
Memory and CPU hot unplug are both asynchronize procedures. When the unplug operation happens, unplug request cb is called first. And when ghest OS finished handling unplug, unplug cb will be called to do the real removal of device. This patch adds hotunplug cb for pc machine, and memory and CPU h

[Qemu-devel] [RESEND PATCH v1 4/5] acpi, ich9: Add unplug cb for ich9.

2015-01-07 Thread Tang Chen
Memory and CPU hot unplug are both asynchronize procedures. When the unplug operation happens, unplug request cb is called first. And when ghest OS finished handling unplug, unplug cb will be called to do the real removal of device. This patch adds hotunplug cb for ich9, and memory and CPU hot unp

[Qemu-devel] [RESEND PATCH v1 5/5] acpi, piix4: Add unplug cb for piix4.

2015-01-07 Thread Tang Chen
Memory and CPU hot unplug are both asynchronize procedures. When the unplug operation happens, unplug request cb is called first. And when ghest OS finished handling unplug, unplug cb will be called to do the real removal of device. This patch adds hotunplug cb for piix4, and memory and CPU hot un

Re: [Qemu-devel] [PATCH 0/4] ARM: Add support for a generic PCI Express host bridge

2015-01-07 Thread Alexander Graf
> Am 07.01.2015 um 14:52 schrieb Claudio Fontana : > > Hi Alexander, happy new year! > >> On 06.01.2015 17:03, Alexander Graf wrote: >> Linux implements a nice binding to describe a "generic" PCI Express host >> bridge >> using only device tree. >> >> This patch set adds enough emulation log

[Qemu-devel] [PATCH] vmstate: type-check sub-arrays

2015-01-07 Thread Paolo Bonzini
While we cannot check against the type of the full array, we can check against the type of the fields. Signed-off-by: Paolo Bonzini --- include/migration/vmstate.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index

Re: [Qemu-devel] [PATCH v2 01/12] block/dmg: properly detect the UDIF trailer

2015-01-07 Thread Stefan Hajnoczi
On Tue, Jan 06, 2015 at 06:48:04PM +0100, Peter Wu wrote: > DMG files have a variable length with a UDIF trailer at the end of a > file. This UDIF trailer is essential as it describes the contents of > the image. At the moment however, the start of this trailer is almost > always incorrect as bdrv_

Re: [Qemu-devel] [PATCH] block: Split BLOCK_OP_TYPE_COMMIT to BLOCK_OP_TYPE_COMMIT_{SOURCE, TARGET}

2015-01-07 Thread Stefan Hajnoczi
On Thu, Sep 11, 2014 at 01:14:00PM +0800, Fam Zheng wrote: > Like BLOCK_OP_TYPE_BACKUP_SOURCE and BLOCK_OP_TYPE_BACKUP_TARGET, > block-commit involves two asymmetric devices. > > This change is not user-visible (yet), because commit only works with > device names. > > But once we enable backing r

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Alexander Graf
On 07.01.15 12:07, Paolo Bonzini wrote: > > > On 07/01/2015 12:03, Marcel Apfelbaum wrote: >> >> While I agree it will be better if we place this in instance_init, >> setting the machine_usb to defaults_enabled() there would be problematic >> since it depends on >> - papr_vga_init(phb->bus) fo

[Qemu-devel] [RESEND PATCH v1 1/5] acpi, pc: Add hotunplug request cb for pc machine.

2015-01-07 Thread Tang Chen
Memory and CPU hot unplug are both asynchronous procedures. They both need unplug request callback to initiate unplug operation. Add unplug handler to pc machine that will be used by following CPU and memory unplug patches. --- hw/i386/pc.c | 8 1 file changed, 8 insertions(+) diff --gi

Re: [Qemu-devel] [PATCH v2] vl.c: fix regression when reading machine type from config file

2015-01-07 Thread Marcel Apfelbaum
On 01/07/2015 01:35 PM, Paolo Bonzini wrote: On 07/01/2015 12:34, Marcel Apfelbaum wrote: After 'Machine as QOM' series the machine type input triggers the creation of the machine class. If the machine type is set in the configuration file, the machine class is not updated accordingly and rema

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Paolo Bonzini
On 07/01/2015 12:15, Alexander Graf wrote: > > > On 07.01.15 12:07, Paolo Bonzini wrote: >> >> >> On 07/01/2015 12:03, Marcel Apfelbaum wrote: >>> >>> While I agree it will be better if we place this in instance_init, >>> setting the machine_usb to defaults_enabled() there would be problematic

Re: [Qemu-devel] [PATCH V2] char: restore stdio echo on resume from suspend.

2015-01-07 Thread Paolo Bonzini
On 07/01/2015 09:38, Gal Hammer wrote: > The monitor's auto-completion feature stopped working when stdio is used > as an input and qemu was resumed after it was suspended (using ctrl-z). > > Signed-off-by: Gal Hammer Looks good, thanks Peter for reviewing v1. Paolo > --- > V2 - restore old

Re: [Qemu-devel] [PATCH] vl.c: fix regression when reading machine type from config file

2015-01-07 Thread Marcel Apfelbaum
On 01/06/2015 09:44 PM, Paolo Bonzini wrote: On 06/01/2015 18:41, Marcel Apfelbaum wrote: After 'Machine as QOM' series the machine type input triggers the creation of the machine class. If the machine type is set in the configuration file, the machine class is not updated accordingly and rema

[Qemu-devel] [PATCH v2] vl.c: fix regression when reading machine type from config file

2015-01-07 Thread Marcel Apfelbaum
After 'Machine as QOM' series the machine type input triggers the creation of the machine class. If the machine type is set in the configuration file, the machine class is not updated accordingly and remains the default. Fixed that by querying the machine options after the configuration file is lo

Re: [Qemu-devel] [PATCH v2 01/10] pci: move REDHAT_SDHCI device ID to make room for Rocker

2015-01-07 Thread Paolo Bonzini
On 07/01/2015 11:39, Peter Maydell wrote: >> > Within the virt team, we have always considered the authoritative source >> > to be qemu.git and Gerd to be the maintainer. Jiri is a Red Hatter but >> > not in the virt team, hence the confusion. > OK, so do we: > (1) say that the authoritative li

Re: [Qemu-devel] [PATCH 09/10] block/dmg: support bzip2 block entry types

2015-01-07 Thread Paolo Bonzini
On 05/01/2015 20:32, John Snow wrote: >> >> fi >> >> ## >> +# bzip2 check >> + >> +if test "$bzip2" != "no" ; then >> +cat > $TMPC << EOF >> +#include >> +int main(void) { BZ2_bzlibVersion(); return 0; } >> +EOF >> +if compile_prog "" "-lbz2" ;

Re: [Qemu-devel] [PATCH v2 01/12] block/dmg: properly detect the UDIF trailer

2015-01-07 Thread Peter Wu
On Wednesday 07 January 2015 13:19:34 Stefan Hajnoczi wrote: > On Tue, Jan 06, 2015 at 06:48:04PM +0100, Peter Wu wrote: > > DMG files have a variable length with a UDIF trailer at the end of a > > file. This UDIF trailer is essential as it describes the contents of > > the image. At the moment how

Re: [Qemu-devel] [PATCH v2] vl.c: fix regression when reading machine type from config file

2015-01-07 Thread Marcel Apfelbaum
On 01/07/2015 01:34 PM, Marcel Apfelbaum wrote: After 'Machine as QOM' series the machine type input triggers the creation of the machine class. If the machine type is set in the configuration file, the machine class is not updated accordingly and remains the default. Fixed that by querying the

Re: [Qemu-devel] [PATCH v8 1/3] hw/arm/sysbus-fdt: helpers for platform bus nodes addition

2015-01-07 Thread Eric Auger
Hi Peter, On 01/06/2015 07:40 PM, Peter Maydell wrote: > On 5 January 2015 at 16:14, Eric Auger wrote: >> This new C module will be used by ARM machine files to generate >> platform bus node and their dynamic sysbus device tree nodes. >> >> Dynamic sysbus device node addition is done in a machine

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Marcel Apfelbaum
On 01/06/2015 10:45 PM, Paolo Bonzini wrote: On 06/01/2015 14:29, Marcel Apfelbaum wrote: @@ -1484,9 +1484,10 @@ static void ppc_spapr_init(MachineState *machine) /* Graphics */ if (spapr_vga_init(phb->bus)) { spapr->has_graphics = true; +machine->usb |= defaults_

Re: [Qemu-devel] [PATCH 0/4] ARM: Add support for a generic PCI Express host bridge

2015-01-07 Thread Claudio Fontana
On 07.01.2015 15:07, Alexander Graf wrote: > > > >> Am 07.01.2015 um 14:52 schrieb Claudio Fontana : >> >> Hi Alexander, happy new year! >> >>> On 06.01.2015 17:03, Alexander Graf wrote: >>> Linux implements a nice binding to describe a "generic" PCI Express host >>> bridge >>> using only devic

Re: [Qemu-devel] [PULL 0/8] pc: resizeable ROM blocks

2015-01-07 Thread Paolo Bonzini
On 07/01/2015 13:37, Michael S. Tsirkin wrote: > On Wed, Jan 07, 2015 at 11:52:40AM +0100, Paolo Bonzini wrote: >> Maybe it's too optimistic. That's why I'm saying do not trim the tables >> for a couple releases more. > > I think it is too optimistic, and not trimming the tables does not > solv

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Paolo Bonzini
On 07/01/2015 12:27, Alexander Graf wrote: > > Hmm, then I guess let's apply these patches and fix things up later? > > Certainly works for me ;). Send a pull request then. :) Paolo

Re: [Qemu-devel] [PATCH 09/10] block/dmg: support bzip2 block entry types

2015-01-07 Thread Peter Wu
On Wednesday 07 January 2015 11:29:20 Paolo Bonzini wrote: > > On 05/01/2015 20:32, John Snow wrote: > >> > >> fi > >> > >> ## > >> +# bzip2 check > >> + > >> +if test "$bzip2" != "no" ; then > >> +cat > $TMPC << EOF > >> +#include > >> +int main(vo

Re: [Qemu-devel] PPC: E500 [PATCH v2 ]: Add FSL i2c controller and integrate RTC with it.

2015-01-07 Thread Alexander Graf
On 29.12.14 11:25, Amit Tomar wrote: > > Changes since v1: > * Move it to GPL v2+ > * Replace the printf with DPRINTF > * Fix the coding style issues > * Change the subject line > > This patch adds an emulation model for i2c controller found on most of the > FSL SoCs. > It als

Re: [Qemu-devel] [Bug 1391942] [NEW] Unnecessary events option of the trace argument with UST backend

2015-01-07 Thread Stefan Hajnoczi
On Wed, Nov 12, 2014 at 04:01:38PM -, Francis Deslauriers wrote: > When running configure with the --enable-trace-backends=ust option and > compiling. > The user should not have to specify a the "events" and "file" options because > they are not used with that tracing framework. > > Right n

Re: [Qemu-devel] [PATCH 0/4] ARM: Add support for a generic PCI Express host bridge

2015-01-07 Thread Alexander Graf
On 07.01.15 15:26, Claudio Fontana wrote: > On 07.01.2015 15:07, Alexander Graf wrote: >> >> >> >>> Am 07.01.2015 um 14:52 schrieb Claudio Fontana : >>> >>> Hi Alexander, happy new year! >>> On 06.01.2015 17:03, Alexander Graf wrote: Linux implements a nice binding to describe a "generi

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-07 Thread Gerd Hoffmann
Hi, > However, you should specify it whatever the host endianness and the host > OS is. If this is not the case, you're just exchanging a bug with another. > > If something > > a) works with Linux host but not with Mac OS X host > > b) and works with Linux guest but not with Mac OS X guest >

Re: [Qemu-devel] [PATCH 0/6] relicense QEMU softfloat from 2b to to 2a

2015-01-07 Thread Peter Maydell
On 7 January 2015 at 06:13, Paolo Bonzini wrote: > > > On 25/11/2014 15:17, Peter Maydell wrote: >> Questions for review: >> * can we do the git cherry-pick thing I mention above? > > I'm afraid that would double the size of the repository (in terms of > number of commits). > > One possibility is

Re: [Qemu-devel] [PULL 0/8] pc: resizeable ROM blocks

2015-01-07 Thread Paolo Bonzini
On 24/12/2014 13:41, Michael S. Tsirkin wrote: >> I don't think these are necessary, and I thought these were just RFC >> when they were posted. I and mst didn't really understand each other, >> and I take the fault for not reviewing the submission; however, Peter, >> please hold these for a lit

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Marcel Apfelbaum
On 01/07/2015 01:37 PM, Alexander Graf wrote: On 07.01.15 12:32, Paolo Bonzini wrote: On 07/01/2015 12:27, Alexander Graf wrote: Hmm, then I guess let's apply these patches and fix things up later? Certainly works for me ;). Send a pull request then. :) Ok, applied the patch set to pp

Re: [Qemu-devel] [PATCH v2 0/6] aio: Support epoll by introducing qemu_poll abstraction

2015-01-07 Thread Stefan Hajnoczi
On Tue, Dec 16, 2014 at 10:04:38AM +0800, Fam Zheng wrote: > On Thu, 12/04 11:43, Fam Zheng wrote: > > v2: Emulate nanoseconds precison of timeout with ppoll and timerfd. > > Their performance is on par with each other, but both much better than > > qemu.git: > > > > syscall hi

Re: [Qemu-devel] [PULL v2 0/7] s390x patches for 2.3

2015-01-07 Thread Cornelia Huck
On Sat, 20 Dec 2014 22:03:34 + Peter Maydell wrote: > On 18 December 2014 at 16:34, Cornelia Huck wrote: > > Next try for s390x updates. The previous build failures should be > > fixed now. > > Still not building on w32, I'm afraid. I think most of this is run-on > error from using __uint16

Re: [Qemu-devel] [PATCH 0/4] ARM: Add support for a generic PCI Express host bridge

2015-01-07 Thread Claudio Fontana
On 07.01.2015 15:36, Alexander Graf wrote: > > > On 07.01.15 15:26, Claudio Fontana wrote: >> On 07.01.2015 15:07, Alexander Graf wrote: >>> >>> >>> Am 07.01.2015 um 14:52 schrieb Claudio Fontana : Hi Alexander, happy new year! > On 06.01.2015 17:03, Alexander Graf w

[Qemu-devel] [PULL 22/37] target-ppc: Introduce tm_enabled Bit to CPU State

2015-01-07 Thread Alexander Graf
From: Tom Musta Add a bit (tm_enabled) to CPU state that mirrors the MSR[TM] bit. This is analogous to the other "available" bits in the MSR (FP, VSX, etc.). NOTE: Since MSR[TM] occupies big-endian bit 31, the code is wrapped with a PPC64 bit check. Signed-off-by: Tom Musta Signed-off-by: Alex

[Qemu-devel] [PULL 02/37] PPC: e500: Move CCSR and MMIO space to upper end of address space

2015-01-07 Thread Alexander Graf
On e500 we're basically guaranteed to have 36bits of physical address space available for our enjoyment. Older chips (like the mpc8544) only had 32bits, but everything from e500v2 onwards bumped it up. It's reasonably safe to assume that if you're using the PV machine, your guest kernel is configu

[Qemu-devel] [PULL 05/37] target-ppc: Load/Store Vector Element Storage Alignment

2015-01-07 Thread Alexander Graf
From: Tom Musta The Load Vector Element Indexed and Store Vector Element Indexed instructions compute an effective address in the usual manner. However, they truncate that address to the natural boundary. For example, the lvewx instruction will ignore the least significant two bits of the address

[Qemu-devel] [PULL 03/37] PPC: mpc8554ds: Tell user about exceeding RAM limits

2015-01-07 Thread Alexander Graf
The mpc8544ds board only supports up to 3GB of RAM due to its limited address space. When the user requests more, abort and tell him that he should use less. Signed-off-by: Alexander Graf --- hw/ppc/mpc8544ds.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/ppc/mpc8544ds.c b/hw/pp

[Qemu-devel] [PULL 13/37] spapr: Fix stale HTAB during live migration (KVM)

2015-01-07 Thread Alexander Graf
From: Samuel Mendoza-Jonas If a guest reboots during a running migration, changes to the hash page table are not necessarily updated on the destination. Opening a new file descriptor to the HTAB forces the migration handler to resend the entire table. Signed-off-by: Samuel Mendoza-Jonas Reviewe

[Qemu-devel] [PULL 08/37] target-ppc: mffs. Should Set CR1 from FPSCR Bits

2015-01-07 Thread Alexander Graf
From: Tom Musta Update the Move From FPSCR (mffs.) instruction to correctly set CR[1] from FPSCR[FX,FEX,VX,OX]. Signed-off-by: Tom Musta Signed-off-by: Alexander Graf --- target-ppc/translate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target-ppc/translate.c b/tar

[Qemu-devel] [PULL 07/37] target-ppc: Fix Floating Point Move Instructions That Set CR1

2015-01-07 Thread Alexander Graf
From: Tom Musta The Floating Point Move instructions (fmr., fabs., fnabs., fneg., and fcpsgn.) incorrectly copy FPSCR[FPCC] instead of [FX,FEX,VX,OX]. Furthermore, the current code does this via a call to gen_compute_fprf, which is awkward since these instructions do not actually set FPRF. Chang

[Qemu-devel] [PULL 29/37] PPC: e500: Fix GPIO controller interrupt number

2015-01-07 Thread Alexander Graf
From: Amit Tomar The GPIO controller lives at IRQ 47, not 43 on real hardware. This is a problem because IRQ 43 is occupied by the I2C controller which we want to implement next, so we'd have a conflict on that IRQ number. Move the GPIO controller to IRQ 47 where it belongs. Signed-off-by: Amit

[Qemu-devel] [PULL 00/37] ppc patch queue 2015-01-07

2015-01-07 Thread Alexander Graf
Hi Peter, This is my current patch queue for ppc. Please pull. Alex The following changes since commit ab0302ee764fd702465aef6d88612cdff4302809: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20141223' into staging (2014-12-23 15:05:22 +) are available in the git

[Qemu-devel] [PULL 14/37] spapr: Fix integer overflow during migration (TCG)

2015-01-07 Thread Alexander Graf
From: Samuel Mendoza-Jonas The n_valid and n_invalid fields are unsigned short integers but it is possible to have more than 65535 entries in a contiguous hunk, overflowing the field. This results in an incorrect HTAB being sent to the destination during migration. Signed-off-by: Samuel Mendoza-

[Qemu-devel] [PULL 20/37] target-ppc: Introduce Instruction Type for Transactional Memory

2015-01-07 Thread Alexander Graf
From: Tom Musta Add a category (PPC2_TM) for the Transactional Memory instructions introduced in Power ISA 2.07. Signed-off-by: Tom Musta Signed-off-by: Alexander Graf --- target-ppc/cpu.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target-ppc/cpu.h b/target-ppc/cpu

[Qemu-devel] [PULL 04/37] PPC: e500 pci host: Add support for ATMUs

2015-01-07 Thread Alexander Graf
The e500 PCI controller has configurable windows that allow a guest OS to selectively map parts of the PCI bus space to CPU address space and to selectively map parts of the CPU address space for DMA requests into PCI visible address ranges. So far, we've simply assumed that this mapping is 1:1 an

[Qemu-devel] [PULL 16/37] device-tree: fix memory leak

2015-01-07 Thread Alexander Graf
From: Sergey Fedorov Signed-off-by: Sergey Fedorov Signed-off-by: Alexander Graf --- device_tree.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/device_tree.c b/device_tree.c index df9eed9..4cb1cd5 100644 --- a/device_tree.c +++ b/device_tree.c @@ -324,6 +

[Qemu-devel] [PULL 33/37] hw/machine: added machine_usb wrapper

2015-01-07 Thread Alexander Graf
From: Marcel Apfelbaum Following QOM convention, object properties should not be accessed directly. Signed-off-by: Marcel Apfelbaum Reviewed-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Alexander Graf --- hw/core/machine.c | 5 + include/hw/boards.h | 2 ++ 2 files ch

[Qemu-devel] [PULL 23/37] target-ppc: Power8 Supports Transactional Memory

2015-01-07 Thread Alexander Graf
From: Tom Musta The Power8 processor implements the Transactional Memory Facility as defined in Power ISA 2.07. Update the initialization code to indicate this. Signed-off-by: Tom Musta Signed-off-by: Alexander Graf --- target-ppc/translate_init.c | 5 +++-- 1 file changed, 3 insertions(+),

[Qemu-devel] [PULL 31/37] target-ppc: Cast ssize_t to size_t before printing with %zx

2015-01-07 Thread Alexander Graf
From: Peter Maydell The mingw32 compiler complains about trying to print variables of type ssize_t with the %z format string specifier. Since we're printing it as unsigned hex anyway, cast to size_t to silence the warning. Signed-off-by: Peter Maydell Signed-off-by: Alexander Graf --- hw/ppc/

[Qemu-devel] [PULL 10/37] target-ppc: Eliminate set_fprf Argument From gen_compute_fprf

2015-01-07 Thread Alexander Graf
From: Tom Musta The set_fprf argument to the gen_compute_fprf() utility is no longer needed -- gen_compute_fprf() is now called only when FPRF is actually computed and set. Eliminate the obsolete argument. Signed-off-by: Tom Musta Signed-off-by: Alexander Graf --- target-ppc/translate.c | 38

[Qemu-devel] [PULL 06/37] target-ppc: VXSQRT Should Not Be Set for NaNs

2015-01-07 Thread Alexander Graf
From: Tom Musta The Power ISA square root instructions (fsqrt[s], frsqrte[s]) must set the FPSCR[VXSQRT] flag when operating on a negative value. However, NaNs have no sign and therefore this flag should not be set when operating on one. Change the order of the checks in the helper code. Move t

[Qemu-devel] [PULL 27/37] target-ppc: Introduce tcheck

2015-01-07 Thread Alexander Graf
From: Tom Musta Add a degenerate implementation of the Transaction Check (tcheck) instruction. Since transaction always immediately fail, this implementation simply sets CR[BF] to 0b1000, i.e. TDOOMED = 1 and MSR[TS] == 0. Signed-off-by: Tom Musta Signed-off-by: Alexander Graf --- target-ppc

[Qemu-devel] [PULL 17/37] ppc: do not use get_clock_realtime()

2015-01-07 Thread Alexander Graf
From: Paolo Bonzini Use the external qemu-timer API instead. Signed-off-by: Paolo Bonzini Signed-off-by: Alexander Graf --- hw/ppc/ppc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index bec82cd..5ce565d 100644 --- a/hw/ppc/ppc.c +++ b/h

[Qemu-devel] [PULL 30/37] target-ppc: Mark SR() and gen_sync_exception() as !CONFIG_USER_ONLY

2015-01-07 Thread Alexander Graf
From: Peter Maydell The functions SR() and gen_sync_exception() are only used in softmmu configs; wrap them in #ifndef CONFIG_USER_ONLY to suppress clang warnings on the linux-user builds. Signed-off-by: Peter Maydell Signed-off-by: Alexander Graf --- target-ppc/translate.c | 5 + 1 file

[Qemu-devel] [PULL 12/37] target-ppc: explicitly save page table headers in big endian

2015-01-07 Thread Alexander Graf
From: Cédric Le Goater Currently, when the page tables are saved, the kvm_get_htab_header structs and the ptes are assumed being big endian and dumped as a indistinct blob in the statefile. This is no longer true when the host is little endian and this breaks restoration. This patch unfolds the

[Qemu-devel] [PULL 21/37] target-ppc: Introduce Feature Flag for Transactional Memory

2015-01-07 Thread Alexander Graf
From: Tom Musta Add a flag (POWERPC_FLAG_TM) for the Transactional Memory Facility introduced in Power ISA 2.07. Signed-off-by: Tom Musta Signed-off-by: Alexander Graf --- target-ppc/cpu.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index 3510083.

[Qemu-devel] [PULL 01/37] PPC: e500: Move CCSR definition to params

2015-01-07 Thread Alexander Graf
We want to have different MMIO region offsets for the mpc8544ds machine and our e500 PV machine, so move the definitions of those into the machine specific params struct. Signed-off-by: Alexander Graf --- hw/ppc/e500.c | 30 ++ hw/ppc/e500.h | 3 +++ hw/ppc

[Qemu-devel] [PULL 09/37] target-ppc: Fully Migrate to gen_set_cr1_from_fpscr

2015-01-07 Thread Alexander Graf
From: Tom Musta Eliminate the set_rc argument from the gen_compute_fprf utility and the corresponding (and incorrect) implementation. Replace it with calls to the gen_set_cr1_from_fpscr() utility. Signed-off-by: Tom Musta Signed-off-by: Alexander Graf --- target-ppc/translate.c | 55

[Qemu-devel] [PULL 37/37] hw/ppc/mac_newworld: simplify usb controller creation logic

2015-01-07 Thread Alexander Graf
From: Marcel Apfelbaum Signed-off-by: Marcel Apfelbaum Reviewed-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Signed-off-by: Alexander Graf --- hw/ppc/mac_newworld.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c index b

[Qemu-devel] [PULL 35/37] hw/ppc/mac_newworld: QOMified mac99 machines

2015-01-07 Thread Alexander Graf
From: Marcel Apfelbaum Signed-off-by: Marcel Apfelbaum Reviewed-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Signed-off-by: Alexander Graf --- hw/ppc/mac_newworld.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/hw/ppc/mac_newworld.c b/h

[Qemu-devel] [PULL 11/37] target-ppc: Eliminate set_fprf Argument From helper_compute_fprf

2015-01-07 Thread Alexander Graf
From: Tom Musta The set_fprf argument to the helper_compute_fprf helper function is no longer necessary -- the helper is only invoked when FPSCR[FPRF] is going to be set. Eliminate the unnecessary argument from the function signature and its corresponding implementation. Change the return value

[Qemu-devel] [PULL 36/37] hw/ppc/spapr: simplify usb controller creation logic

2015-01-07 Thread Alexander Graf
From: Marcel Apfelbaum Signed-off-by: Marcel Apfelbaum Reviewed-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Signed-off-by: Alexander Graf --- hw/ppc/spapr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index d2b8b12..b560459 100644

[Qemu-devel] [PULL 34/37] hw/usb: simplified usb_enabled

2015-01-07 Thread Alexander Graf
From: Marcel Apfelbaum The argument is not longer used and the implementation uses now QOM instead of QemuOpts. Signed-off-by: Marcel Apfelbaum Reviewed-by: Stefan Hajnoczi Reviewed-by: Paolo Bonzini Signed-off-by: Alexander Graf --- hw/arm/nseries.c| 2 +- hw/arm/pxa2xx.c

[Qemu-devel] [PULL 15/37] spapr: Fix stale HTAB during live migration (TCG)

2015-01-07 Thread Alexander Graf
From: Samuel Mendoza-Jonas If a TCG guest reboots during a running migration HTAB entries are not marked dirty, and the destination boots with an invalid HTAB. When a reboot occurs, explicitly mark the current HTAB dirty after clearing it. Signed-off-by: Samuel Mendoza-Jonas Reviewed-by: Alexe

[Qemu-devel] [PULL 26/37] target-ppc: Introduce TM Noops

2015-01-07 Thread Alexander Graf
From: Tom Musta Add degenerate implementations of the non-privileged Transactional Memory instructions tend., tabort*. and tsr. This implementation simply checks the MSR[TM] bit and then sets CR0 to 0b. This is a reasonable degenerate implementation since transactions are never allowed to b

[Qemu-devel] [PULL 28/37] target-ppc: Introduce Privileged TM Noops

2015-01-07 Thread Alexander Graf
From: Tom Musta Add the supervisory Transactional Memory instructions treclaim. and trechkpt. The implementation is a degenerate one that simply checks privileged state, TM availability and then sets CR[0] to 0b, just like the unprivileged noops. Signed-off-by: Tom Musta Signed-off-by: Ale

[Qemu-devel] [PULL 25/37] target-ppc: Introduce tbegin

2015-01-07 Thread Alexander Graf
From: Tom Musta Provide a degenerate implementation of the tbegin instruction. This implementation always fails the transaction, recording the failure per Book II Section 5.3.2 of the Power ISA V2.07. Signed-off-by: Tom Musta Signed-off-by: Alexander Graf --- target-ppc/helper.h | 2 ++

Re: [Qemu-devel] [PATCH v3] vl.c: fix regression when reading machine type from config file

2015-01-07 Thread Marcel Apfelbaum
On 01/07/2015 02:12 PM, Paolo Bonzini wrote: On 07/01/2015 13:11, Marcel Apfelbaum wrote: After 'Machine as QOM' series the machine type input triggers the creation of the machine class. If the machine type is set in the configuration file, the machine class is not updated accordingly and rema

  1   2   3   >