Re: [Qemu-devel] [PATCH v8 1/3] hw/arm/sysbus-fdt: helpers for platform bus nodes addition

2015-01-06 Thread Peter Maydell
On 5 January 2015 at 16:14, Eric Auger wrote: > This new C module will be used by ARM machine files to generate > platform bus node and their dynamic sysbus device tree nodes. > > Dynamic sysbus device node addition is done in a machine init > done notifier. arm_register_platform_bus_fdt_creator d

Re: [Qemu-devel] [PATCH] char: disable stdio echo on resume from suspend.

2015-01-06 Thread Gal Hammer
- Original Message - > From: "Peter Maydell" > To: "Gal Hammer" > Cc: "Paolo Bonzini" , "QEMU Developers" > > Sent: Tuesday, January 6, 2015 4:36:19 PM > Subject: Re: [Qemu-devel] [PATCH] char: disable stdio echo on resume from > suspend. > > On 6 January 2015 at 14:30, Gal Hamme

Re: [Qemu-devel] [PATCH v8 3/3] hw/arm/virt: add dynamic sysbus device support

2015-01-06 Thread Peter Maydell
On 5 January 2015 at 16:14, Eric Auger wrote: > Allows sysbus devices to be instantiated from command line by > using -device option. Machvirt creates a platform bus at init. > The dynamic sysbus devices are attached to this platform bus device. > @@ -59,6 +61,8 @@ > #define GIC_FDT_IRQ_PPI_CPU_

Re: [Qemu-devel] [PATCH] vl.c: fix regression when reading machine type from config file

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 18:41, Marcel Apfelbaum wrote: > After 'Machine as QOM' series the machine type input triggers > the creation of the machine class. > If the machine type is set in the configuration file, the machine > class is not updated accordingly and remains the default. > > Fixed that by quer

Re: [Qemu-devel] qemu sources and makefile system

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 13:25, Vasile Catalin-B50542 wrote: > I'm new to qemu-devel and I'm trying to add a ".c" source to qemu. > To be more specific, I'm trying to add a file into src>/hw/virtio/. I've added "common-obj-y += virtio-src.o" to the > src>Makefile.objs in that folder > and when I'm compilin

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 14:29, Marcel Apfelbaum wrote: > Patch e79d5a6 ("machine: remove qemu_machine_opts global list") removed option > descriptions from the -machine QemuOptsList to avoid repeating MachineState's > QOM properties. > > This resulted in a Qemu crash: > $ qemu-system-x86_64 -usb > qemu-s

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 19:07, Programmingkid wrote: > http://www.mcamafia.de/pdf/ibm_vgaxga_trm2.pdf This file is the > specifications to the VGA standard. It makes no mention of pixel > endian format. There is no mention of bit order in the > specifications. It's probably assumed to be little endian. Th

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 20:48, Paolo Bonzini wrote: > I like the way you structured the series! > > Reviewed-by: Paolo Bonzini Hmm, actually doesn't this break -machine usb=no? Paolo

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 14:29, Marcel Apfelbaum wrote: > @@ -1484,9 +1484,10 @@ static void ppc_spapr_init(MachineState *machine) > /* Graphics */ > if (spapr_vga_init(phb->bus)) { > spapr->has_graphics = true; > +machine->usb |= defaults_enabled(); > } Could the solution b

Re: [Qemu-devel] [PATCH 4/4] arm: enable Bochs PCI VGA

2015-01-06 Thread Alexander Graf
On 06.01.15 17:16, Peter Maydell wrote: > On 6 January 2015 at 16:03, Alexander Graf wrote: >> Some ARM platforms can successfully map PCI devices into the guest, so it >> only >> makes sense to also add support for the Bochs virtual VGA adapter on those. >> >> Signed-off-by: Alexander Graf >>

Re: [Qemu-devel] [PATCH v3 2/5] QJSON: Add JSON writer

2015-01-06 Thread Alexander Graf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06.01.15 16:44, Eric Blake wrote: > On 12/26/2014 07:42 AM, Alexander Graf wrote: >> To support programmatic JSON assembly while keeping the code that >> generates it readable, this patch introduces a simple JSON >> writer. It emits JSON serially

[Qemu-devel] [Bug 1404278] Re: tap connections not working on windows host

2015-01-06 Thread timsoft
output as requested from the guest: ip addr 1: lo: mtu 65536 qdisc noqueue state UNKOWN link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo valid_lft forever preferred_lft forever inet6 ::1/128 scope host valid_lft forever preferred_lft f

Re: [Qemu-devel] [PATCH v3 4/5] migration: Append JSON description of migration stream

2015-01-06 Thread Alexander Graf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06.01.15 16:56, Eric Blake wrote: > On 12/26/2014 07:42 AM, Alexander Graf wrote: >> One of the annoyances of the current migration format is the fact >> that it's not self-describing. In fact, it's not properly >> describing at all. Some code ran

Re: [Qemu-devel] [PATCH 4/4] arm: enable Bochs PCI VGA

2015-01-06 Thread Peter Maydell
On 6 January 2015 at 21:08, Alexander Graf wrote: > On 06.01.15 17:16, Peter Maydell wrote: >> On 6 January 2015 at 16:03, Alexander Graf wrote: >>> +CONFIG_VGA_PCI=y >> >> Why isn't this just in pci.mak like all the other PCI devices? > > Honestly, I have no idea. Maybe Michael knows? But if eve

Re: [Qemu-devel] [PATCH v3 5/5] Add migration stream analyzation script

2015-01-06 Thread Alexander Graf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06.01.15 17:05, Eric Blake wrote: > On 12/26/2014 07:42 AM, Alexander Graf wrote: >> This patch adds a python tool to the scripts directory that can >> read a dumped migration stream if it contains the JSON >> description of the device states. I c

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread G 3
I start the guest like this: qemu-system-ppc -hdd ~/machd.img -boot c -prom-env boot-args=-v Hope this is what you wanted: 00:00.0 Host bridge: Motorola MPC106 [Grackle] (prog-if 01) Subsystem: Qumranet, Inc. Device 1100 Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-

Re: [Qemu-devel] [PATCH v3 1/5] QJSON: Add JSON writer

2015-01-06 Thread Alexander Graf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06.01.15 16:41, Eric Blake wrote: > On 12/26/2014 07:42 AM, Alexander Graf wrote: >> To support programmatic JSON assembly while keeping the code that >> generates it readable, this patch introduces a simple JSON >> writer. It emits JSON serially

[Qemu-devel] [Bug 1404278] Re: tap connections not working on windows host

2015-01-06 Thread timsoft
I have also run the 64bit version of qemu with the slight modification of the batch/cmd line cd "c:\program files\qemu" qemu-system-x86_64w.exe -m 512 -net nic -net tap,ifname=tap01 -hda "c:\\data\\images\\test.img" and get the same output both for the client(ip addr; ip route; ip tables -L -n

[Qemu-devel] [Bug 1274170] Re: qemu window hides in the background on osx

2015-01-06 Thread Stefan Weil
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1274170 Title: qemu window hides in the background on osx Status in QEMU: Confirmed Bug descrip

Re: [Qemu-devel] [PATCH 4/4] arm: enable Bochs PCI VGA

2015-01-06 Thread Alexander Graf
On 06.01.15 22:28, Peter Maydell wrote: > On 6 January 2015 at 21:08, Alexander Graf wrote: >> On 06.01.15 17:16, Peter Maydell wrote: >>> On 6 January 2015 at 16:03, Alexander Graf wrote: +CONFIG_VGA_PCI=y >>> >>> Why isn't this just in pci.mak like all the other PCI devices? >> >> Honest

Re: [Qemu-devel] [PATCH 1/6] hw/ppc: modified the condition for usb controllers to be created for some ppc machines

2015-01-06 Thread Alexander Graf
On 06.01.15 14:29, Marcel Apfelbaum wrote: > Some ppc machines create a default usb controller based on a 'machine > condition'. > Until now the logic was: create the usb controller if: > - the usb option was supplied in cli and value is true or > - the usb option was absent and both set_def

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-06 Thread Alexander Graf
On 06.01.15 21:41, Paolo Bonzini wrote: > > > On 06/01/2015 20:48, Paolo Bonzini wrote: >> I like the way you structured the series! >> >> Reviewed-by: Paolo Bonzini > > Hmm, actually doesn't this break -machine usb=no? I think it does, but I don't think we really need to care. We can just a

[Qemu-devel] [PATCH v3 0/2] Reworked Zynq GPIO model

2015-01-06 Thread Colin Leitner
Hello everyone, this is the third version of the Zynq GPIO model patch. It includes * mostly code cleanup (variable naming, removed unneeded casts, added some local vars for better readability) * moved zynq-gpio.h to include/hw/gpio * enhancement in the reset/init logic to ensure that reset

[Qemu-devel] [PATCH v3 2/2] xilinx_zynq: Add zynq-gpio to the machine

2015-01-06 Thread Colin Leitner
Signed-off-by: Colin Leitner --- hw/arm/xilinx_zynq.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index 06e6e24..6d8c0d9 100644 --- a/hw/arm/xilinx_zynq.c +++ b/hw/arm/xilinx_zynq.c @@ -202,6 +202,8 @@ static void zynq_init(MachineState *ma

[Qemu-devel] [PATCH v3 1/2] zynq_gpio: GPIO model for Zynq SoC

2015-01-06 Thread Colin Leitner
Based on the pl061 model. This model implements all four banks with 32 I/Os each. The I/Os are placed in named groups: * bankX_in for the 32 inputs of each bank * bankX_out for the 32 outputs of each bank Basic I/O and IRQ support tested with the Zynq GPIO driver in Linux 3.12. Signed-off-by:

[Qemu-devel] [Bug 1408152] [NEW] latest qemu git doesn't load

2015-01-06 Thread Nigel Horne
Public bug reported: commit ab0302ee764fd702465aef6d88612cdff4302809This is with qemu-system-x86_64: util/qemu-option.c:387: qemu_opt_get_bool_helper: Assertion `opt->desc && opt->desc->type == QEMU_OPT_BOOL' failed. /home/njh/bin/kfreebsd-amd64: line 7: 32549 Aborted (core dump

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Programmingkid
Just curious, if someone installed a cirrus vga video card into a PowerMac with Mac OS 10.2 installed, and it had the same color issue that QEMU has, would you be convinced that this problem is an issue with Mac OS X?

[Qemu-devel] [PATCH] vfio-pci: Fix BAR size overflow

2015-01-06 Thread Alex Williamson
We use an unsigned int when working with the PCI BAR size, which can obviously overflow if the BAR is 4GB or larger. This needs to change to an unsigned long. A similar issue is possible, though even more unlikely, when mapping the region above an MSI-X table. The start of the table must be belo

[Qemu-devel] [Bug 1408152] Re: latest qemu git doesn't load

2015-01-06 Thread Nigel Horne
Seems to be failing to parse kernel_irqchip=on correctly. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1408152 Title: latest qemu git doesn't load Status in QEMU: New Bug description: commit

Re: [Qemu-devel] [RFC][PATCH] qemu_opt_get_bool_helper: back finding desc by name just if !opt->desc

2015-01-06 Thread Chen, Tiejun
On 2015/1/6 22:56, Stefan Hajnoczi wrote: On Tue, Jan 06, 2015 at 10:39:13AM +0800, Chen, Tiejun wrote: On 2015/1/6 9:21, Chen, Tiejun wrote: On 2015/1/6 1:13, Eric Blake wrote: On 01/04/2015 10:35 PM, Tiejun Chen wrote: After one commit 49d2e648e808, "machine: remove qemu_machine_opts global

[Qemu-devel] [Bug 1408152] Re: latest qemu git doesn't load

2015-01-06 Thread Tiejun Chen
This issue seems to be similar to 1406706 and 1407454. Looks Marcel is working on a fix, and he also posted something to first address USB stuff, https://www.mail-archive.com/qemu-devel@nongnu.org/msg272607.html -- You received this bug notification because you are a member of qemu- devel-ml, wh

Re: [Qemu-devel] [PATCH] vfio-pci: Fix BAR size overflow

2015-01-06 Thread Don Slutz
On 01/06/15 19:03, Alex Williamson wrote: We use an unsigned int when working with the PCI BAR size, which can obviously overflow if the BAR is 4GB or larger. This needs to change to an unsigned long. A similar issue is possible, though even more unlikely, when mapping the region above an MSI-X

Re: [Qemu-devel] [PATCH v3 0/13] migration: Add a new feature to do live migration

2015-01-06 Thread Li, Liang Z
Hi All, Have you returned from vacation? If so, could you help to review my patches I have submitted three weeks ago? Thanks a lot. Liang > -Original Message- > From: Li, Liang Z > Sent: Friday, December 12, 2014 9:29 AM > To: qemu-devel@nongnu.org > Cc: quint...@redhat.com; lcapit

Re: [Qemu-devel] [PATCH] vfio-pci: Fix BAR size overflow

2015-01-06 Thread Alex Williamson
- Original Message - > On 01/06/15 19:03, Alex Williamson wrote: > > We use an unsigned int when working with the PCI BAR size, which can > > obviously overflow if the BAR is 4GB or larger. This needs to change > > to an unsigned long. A similar issue is possible, though even more > > unl

Re: [Qemu-devel] Gives user ability to select endian format for video display - fixes Mac OS X guest color issue.

2015-01-06 Thread Paolo Bonzini
On 07/01/2015 00:57, Programmingkid wrote: > Just curious, if someone installed a cirrus vga video card into a > PowerMac with Mac OS 10.2 installed, and it had the same color issue > that QEMU has, would you be convinced that this problem is an issue > with Mac OS X? G 3 replied that he's not u

Re: [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 22:54, Alexander Graf wrote: > > > On 06.01.15 21:41, Paolo Bonzini wrote: >> >> >> On 06/01/2015 20:48, Paolo Bonzini wrote: >>> I like the way you structured the series! >>> >>> Reviewed-by: Paolo Bonzini >> >> Hmm, actually doesn't this break -machine usb=no? > > I think it d

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/1] Do not hang on full PTY

2015-01-06 Thread Paolo Bonzini
On 30/12/2014 00:41, Peter Maydell wrote: > On 29 December 2014 at 20:27, Don Slutz wrote: >> I was not sure on this being trivial also, but it looked like it could >> be to me. The uses of this FD all looked that they handle non-blocking. > > Does g_io_channel_read_chars() definitely return G

Re: [Qemu-devel] [PATCH 0/6] relicense QEMU softfloat from 2b to to 2a

2015-01-06 Thread Paolo Bonzini
On 25/11/2014 15:17, Peter Maydell wrote: > Questions for review: > * can we do the git cherry-pick thing I mention above? I'm afraid that would double the size of the repository (in terms of number of commits). One possibility is this: git checkout 158142c2 git cherry-pick this-serie

Re: [Qemu-devel] [PATCH 4/4] arm: enable Bochs PCI VGA

2015-01-06 Thread Paolo Bonzini
On 06/01/2015 22:42, Alexander Graf wrote: > I've not moved CIRRUS or QXL yet though. When I tried, cirrus didn't > work - it probably needs access to the legacy VGA regions that don't get > mapped with the gpex phb. Yes, Bochs VGA has the registers-in-BAR thing, so it always works. Paolo

<    1   2