On 06.01.15 21:41, Paolo Bonzini wrote: > > > On 06/01/2015 20:48, Paolo Bonzini wrote: >> I like the way you structured the series! >> >> Reviewed-by: Paolo Bonzini <pbonz...@redhat.com> > > Hmm, actually doesn't this break -machine usb=no?
I think it does, but I don't think we really need to care. We can just assume that the 64bit mac99 always has USB and it's impossible to turn off. For sPAPR, we only ever enable USB as convenience option when VGA is enabled. I think it's a pretty fair thing to do there and simply ignore usb=no. If you really need it, just don't use -vga. At the end of the day, I don't think anyone will notice. I'd definitely prefer to keep the code simple. However, I think looking forward we'll want to spawn an XHCI adapter rather than OHCI. It's just a lot cheaper to emulate. But that's out of scope of this patch set. Alex
