[Qemu-devel] [Bug 1381879] [NEW] can not run vm with a serial port

2014-10-16 Thread ychen
Public bug reported: environment: server: centOS 6.5, 3.14.19, x86_64 qemu-kvm: QEMU PC emulator version 0.12.1 (qemu-kvm-0.12.1.2), Copyright (c) 2003-2008 Fabrice Bellard qemu-system-x86_64 :QEMU emulator version 1.2.0 (qemu-kvm-1.2.0), Copyright (c) 2003-2008 Fabrice Bellard virt-manager: 0.9

Re: [Qemu-devel] [PING] [PATCH v2 1/1] -machine vmport=off: Allow disabling of VMWare ioport emulation

2014-10-16 Thread Paolo Bonzini
Il 15/10/2014 23:20, Slutz, Donald Christopher ha scritto: > Do I need to repost with the 2 Reviewed-by ? No, I'll attend to this as soon as I get back home. Paolo > On 10/06/14 05:26, Richard W.M. Jones wrote: >> On Fri, Oct 03, 2014 at 05:33:37PM -0400, Don Slutz wrote: >>> From: "Dr. David Al

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Paolo Bonzini
Il 15/10/2014 19:30, Peter Maydell ha scritto: > On 15 October 2014 11:16, Paul Durrant wrote: >> The ioreq-server API added to Xen 4.5 offers better security than >> the existing Xen/QEMU interface because the shared pages that are >> used to pass emulation request/results back and forth are remo

Re: [Qemu-devel] [PATCH v2] target-i386: move generic memory hotplug methods to DSDTs

2014-10-16 Thread Paolo Bonzini
Il 15/10/2014 15:19, Igor Mammedov ha scritto: > however I'm not sure that SSDT byte-for-byte compatible will make > things better. > Since SSDT includes snippets of AML compiled by IASL, hex-templates > could be different depending on IASL version. SSDT is simple enough that there shouldn't be di

[Qemu-devel] [PATCH 3/3] Split the QEMU buffered file code out

2014-10-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The splitting of qemu-file and addition of the buffered file landed at the same time; so now split the buffered file code out. Signed-off-by: Dr. David Alan Gilbert --- migration/Makefile.objs | 2 +- migration/qemu-file-buf.c | 486 ++

[Qemu-devel] [PATCH 0/3] More migration file cleanup

2014-10-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This is a small set of patches that shuffle migration code around, but doesn't change the behaviour: 1) Move a lot of the migration source into a separate 'migration' directory Note this moves a lot of files around, git format-patch -M -B spots the ren

[Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The migration code now occupies a fair chunk of the top level .c files, it seems time to give it it's own directory. I've not touched: arch_init.c - that's mostly RAM migration but has a few random other bits savevm.c- because it's built

[Qemu-devel] [PATCH 2/3] Split struct QEMUFile out

2014-10-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Now we've got multiple QEMUFile source files, some of them need access to things that were defined in qemu-file.c, so create a -internal header for them. Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file-internal.h | 53 +++

[Qemu-devel] [PATCHv4 2/4] BlockLimits: introduce max_transfer_length

2014-10-16 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block.c |4 include/block/block_int.h |3 +++ 2 files changed, 7 insertions(+) diff --git a/block.c b/block.c index 27533f3..0fbf916 100644 --- a/block.c +++ b/block.c @@ -536,6 +536,7 @@ void bdrv_refresh_limits(BlockDriverState *bs

[Qemu-devel] [PATCHv4 3/4] block/iscsi: set max_transfer_length

2014-10-16 Thread Peter Lieven
the limit of 0xff for 16 byte CDBs is intentional to avoid overflows on 32-bit architectures. Signed-off-by: Peter Lieven Reviewed-by: Ronnie Sahlberg --- block/iscsi.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 3a

[Qemu-devel] [PATCHv4 0/4] introduce max_transfer_length

2014-10-16 Thread Peter Lieven
This series adds the basics for introducing a maximum transfer length to the block layer. Its main purpose is currently avoiding that a multiwrite_merge exceeds the max_xfer_len of an attached iSCSI LUN. This is a required bug fix. Splitting up requests according to the max_transfer_length will fo

[Qemu-devel] [PATCHv4 1/4] util: introduce MIN_NON_ZERO

2014-10-16 Thread Peter Lieven
at least in block layer we have the case of limits being defined for a BlockDriverState. However, in this context often zero (0) has the special meanining of undefined which means no limit. If two of those limits are combined and the minimum is needed the minimum function should only return zero if

[Qemu-devel] [PATCHv4 4/4] block: avoid creating oversized writes in multiwrite_merge

2014-10-16 Thread Peter Lieven
Signed-off-by: Peter Lieven Reviewed-by: Ronnie Sahlberg --- block.c |5 + 1 file changed, 5 insertions(+) diff --git a/block.c b/block.c index 0fbf916..9ad2287 100644 --- a/block.c +++ b/block.c @@ -4554,6 +4554,11 @@ static int multiwrite_merge(BlockDriverState *bs, BlockRequest *req

[Qemu-devel] [Bug 1307225] Re: Running a virtual machine on a Haswell system produces machine check events

2014-10-16 Thread Ilya Almametov
Just my 2 cents. I have two Haswell boxes with Ubuntu Server 14.04 each running bunch of VMs. The first one is Intel Core i7-4770K and it runs only Linux VMs. There is no single MCE here for at least one year. The second box is Intel Core i7-4790K and it runs mix of Linux and Windows 2003 VMs. MCE

Re: [Qemu-devel] Counting barrier instructions in ARM

2014-10-16 Thread Peter Maydell
On 16 October 2014 03:45, Pranith Kumar wrote: > The problem I am facing is that this seems to be crashing when run with a > multi-threaded executable. This is nothing to do with your changes -- user-mode QEMU does not support multi-threaded guest executables. QEMU may crash, hang, or stop with a

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-16 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: G> From: "Dr. David Alan Gilbert" > > The migration code now occupies a fair chunk of the top level .c > files, it seems time to give it it's own directory. > > I've not touched: >arch_init.c - that's mostly RAM migration but has a few random other >

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-16 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > The migration code now occupies a fair chunk of the top level .c > files, it seems time to give it it's own directory. > > I've not touched: >arch_init.c - that's mostly RAM migration but has a few random other >

Re: [Qemu-devel] [PATCH 2/3] Split struct QEMUFile out

2014-10-16 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Now we've got multiple QEMUFile source files, some of them need > access to things that were defined in qemu-file.c, so create > a -internal header for them. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Qu

Re: [Qemu-devel] [PATCH 3/3] Split the QEMU buffered file code out

2014-10-16 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > The splitting of qemu-file and addition of the buffered file landed > at the same time; so now split the buffered file code out. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH 1/3] Start moving migration code into a migration directory

2014-10-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > G> From: "Dr. David Alan Gilbert" > > > > The migration code now occupies a fair chunk of the top level .c > > files, it seems time to give it it's own directory. > > > > I've not touched: > >arch_init.c -

Re: [Qemu-devel] [PATCH v1.5] nbd: Fix filename generation

2014-10-16 Thread Kevin Wolf
Am 08.10.2014 um 19:55 hat Max Reitz geschrieben: > Export names may be used with nbd+unix, too, fix nbd_refresh_filename() > accordingly. Also, for nbd+tcp, the documented path schema is > "nbd://host[:port]/export", so use it. Furthermore, as can be seen from > that schema, the port is optional.

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Paul Durrant
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: 15 October 2014 18:30 > To: Paul Durrant > Cc: QEMU Developers; xen-de...@lists.xenproject.org; Stefano Stabellini; > Paolo Bonzini; Michael Tokarev; Stefan Hajnoczi; Stefan Weil; Olaf Hering; > Gerd Hoffma

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Paul Durrant
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: 16 October 2014 08:37 > To: Peter Maydell; Paul Durrant > Cc: QEMU Developers; xen-de...@lists.xenproject.org; Stefano Stabellini; > Michael Tokarev; Stefan Hajnoczi; Stefan Weil; Olaf Hering; Gerd Hoffmann; > A

Re: [Qemu-devel] [PULL 00/34] allow changing bootorder via monitor

2014-10-16 Thread Peter Maydell
On 15 October 2014 11:05, Gerd Hoffmann wrote: > Hi, > > It's finally sorted, here comes the pull request for the bootindex patch > series which turns bootindex into a writable qom property and thereby > allows changing the bootorder at runtime via monitor. > > please pull, > Gerd > > The foll

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-10-16 Thread zhanghailiang
On 2014/10/4 1:47, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Open a return path, and handle messages that are received upon it. Signed-off-by: Dr. David Alan Gilbert --- include/migration/migration.h | 10 +++ migration.c | 181 ++

Re: [Qemu-devel] [PATCH v2 1/2] raw-posix: Fix raw_co_get_block_status() after EOF

2014-10-16 Thread Kevin Wolf
Am 22.09.2014 um 17:36 hat Max Reitz geschrieben: > As its comment states, raw_co_get_block_status() should unconditionally > return 0 and set *pnum to 0 for after EOF. > > An assertion after lseek(..., SEEK_HOLE) tried to catch this case by > asserting that errno != -ENXIO (which would indicate a

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-10-16 Thread Dr. David Alan Gilbert
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > >+case MIG_RPCOMM_ACK: > >+tmp32 = be32_to_cpup((uint32_t *)buf); > >+DPRINTF("RP: Received ACK 0x%x", tmp32); > >+atomic_xchg(&ms->rp_state.latest_ack, tmp32); > > I didn't see *ms->rp_state.lat

[Qemu-devel] [PATCH RFC 3/7] tcg: add sync_temp opcode

2014-10-16 Thread Kirill Batuzov
Currently every field of CPUArchState can be accessed from the TCG-generated code as a memory location or as a global but not both. In order to be able to mix these two approaches we need to restore consistency between value of global (possibly kept on register) and value in corresponding memory l

[Qemu-devel] [PATCH RFC 5/7] target-arm: support access to 128-bit guest registers as globals

2014-10-16 Thread Kirill Batuzov
To support 128-bit guest registers as globals we need to do two things: 1) create corresponding globals, 2) add sync_temp/discard to code that access these registers as memory locations. Note that the second part is not complete in this RFC yet and mixing NEON with VFP code can result in misco

[Qemu-devel] [PATCH RFC 2/7] tcg: store ENV global in TCGContext

2014-10-16 Thread Kirill Batuzov
When a TCG backend does not support some vector operation we need to emulate this operation. Unlike arguments of the scalar operations vector values are hard to operate on directly or to be passed as function arguments (because a target may lack corresponding type support). To avoid this we will us

[Qemu-devel] [PATCH RFC 1/7] tcg: add support for 128bit vector type

2014-10-16 Thread Kirill Batuzov
Introduce TCG_TYPE_V128 and corresponding TCGv_v128 for TCG temps. Add wrapper functions that work with temps of this new type. Signed-off-by: Kirill Batuzov --- tcg/tcg-op.h | 23 +++ tcg/tcg.c| 24 tcg/tcg.h| 28 +++

[Qemu-devel] [PATCH RFC 6/7] target-arm: use add_i32x4 opcode to handle vadd.i32 instruction

2014-10-16 Thread Kirill Batuzov
Signed-off-by: Kirill Batuzov --- target-arm/translate.c | 12 1 file changed, 12 insertions(+) diff --git a/target-arm/translate.c b/target-arm/translate.c index 22855d8..00ea5cf 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -5239,6 +5239,18 @@ static int d

[Qemu-devel] [PATCH RFC 0/7] Translate guest vector operations to host vector operations

2014-10-16 Thread Kirill Batuzov
> (4) Consider supporting generic vector operations in the TCG? I gave it a go and was quite happy with the result. I have implemented the add_i32x4 opcode which is addition of 128-bit vectors composed of four 32-bit integers and used it to translate NEON vadd.i32 to SSE paddd instruction. I used

[Qemu-devel] [PATCH RFC 7/7] tcg/i386: add support for vector opcodes

2014-10-16 Thread Kirill Batuzov
To be able to generate vector operations in TCG backend we need to do several things. 1. We need to tell the register allocator about the target's vector registers. In the case of x86 we'll use xmm0..xmm7. xmm7 is designated as a scratch register, others can be used by register allocator. 2

[Qemu-devel] [PATCH RFC 4/7] tcg: add add_i32x4 opcode

2014-10-16 Thread Kirill Batuzov
Introduce INDEX_op_add_i32x4 opcode which adds two 128-bit variables as vectors of four 32-bit integers. Add tcg_gen_add_i32x4 wrapper function that generates this opcode. If a TCG target does not support it, the wrapper falls back to emulation of vector operation as a series of scalar ones. Wrap

Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

2014-10-16 Thread zhanghailiang
On 2014/10/16 16:35, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: +case MIG_RPCOMM_ACK: +tmp32 = be32_to_cpup((uint32_t *)buf); +DPRINTF("RP: Received ACK 0x%x", tmp32); +atomic_xchg(&ms->rp_state.latest_ack, t

Re: [Qemu-devel] [PULL 0/2] vga patch queue

2014-10-16 Thread Peter Maydell
On 15 October 2014 11:37, Gerd Hoffmann wrote: > Hi, > > vga patch queue with two patches, one deleting some unused bits and one > adding the qext region to stdvga mmio to allow switching vga framebuffer > endianess (needed for ppc64le). > > please pull, > Gerd > > The following changes since

Re: [Qemu-devel] [PATCH 0/6] AHCI Device Fixes

2014-10-16 Thread John Snow
Ping! At KVM Forum I had a discussion with (someone, sorry!) that having some pointers to which specifications to look at here might be helpful, since some of the fixes were just spec-adherence fixes. See below, in-line, for some additional notes on how to review these patches. On 10/02/20

Re: [Qemu-devel] [Bug 1379340] [NEW] qemu-kvm guest panic for smp trusty guests

2014-10-16 Thread Serge Hallyn
affects: ubuntu/qemu importance: high affects: qemu importance: high ** Also affects: qemu (Ubuntu) Importance: High Status: New ** Also affects: qemu Importance: High Status: New ** No longer affects: qemu-kvm (Ubuntu) -- You received this bug notification because you

Re: [Qemu-devel] [PULL 00/28] target-mips queue

2014-10-16 Thread Peter Maydell
On 15 October 2014 11:53, Leon Alrae wrote: > Hi, > > This pull request has been assembled from pending target-mips patches which > look good to me and received in my opinion sufficient review comments. They > were tested mainly in context of MIPS. Please have a look and pull. Thanks for putting

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: 15 October 2014 15:38 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Stefano > Stabellini; Peter Maydell; Paolo Bonzini; Michael Tokarev; Stefan Hajnoczi; > Ste

Re: [Qemu-devel] [PULL 00/28] target-mips queue

2014-10-16 Thread Leon Alrae
On 16/10/2014 10:49, Peter Maydell wrote: > > One question for now: > >> Leon Alrae (17): >> softfloat: add functions corresponding to IEEE-2008 min/maxNumMag > > Can you confirm that you're happy for your softfloat changes > to be licensed under both of the softfloat-2a and softfloat-2b > lic

Re: [Qemu-devel] [PATCH RFC 0/7] Translate guest vector operations to host vector operations

2014-10-16 Thread Alex Bennée
Kirill Batuzov writes: >> (4) Consider supporting generic vector operations in the TCG? > > I gave it a go and was quite happy with the result. I have implemented the > add_i32x4 > opcode which is addition of 128-bit vectors composed of four 32-bit integers > and used it to translate NEON vadd.

Re: [Qemu-devel] [PULL 03/34] bootindex: add del_boot_device_path function

2014-10-16 Thread Peter Maydell
On 15 October 2014 11:05, Gerd Hoffmann wrote: > From: Gonglei > > Introduce del_boot_device_path() to clean up fw_cfg content when > hot-unplugging a device that refers to a bootindex or update a > existent devcie's bootindex. > +void del_boot_device_path(DeviceState *dev, const char *suffix) >

Re: [Qemu-devel] [PATCH V5 0/8] cpu/acpi: convert cpu hot plug to hotplug_handler API

2014-10-16 Thread Gu Zheng
ping... On 10/10/2014 10:15 AM, Gu Zheng wrote: > Previously we use cpu_added_notifiers to register cpu hotplug notifier > callback > which is not able to pass/handle errors, so we switch it to unified hotplug > handler API which allows to pass errors and would allow to cancel device_add > in ca

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Paolo Bonzini
Il 16/10/2014 10:25, Paul Durrant ha scritto: >>> +static void xen_hvm_pre_save(void *opaque) >>> +{ >>> +XenIOState *state = opaque; >>> + >>> +/* Stop servicing emulation requests */ >>> +xen_set_ioreq_server_state(xen_xc, xen_domid, state->ioservid, 0); >>> +xen_destroy_ioreq_ser

Re: [Qemu-devel] [PULL 03/34] bootindex: add del_boot_device_path function

2014-10-16 Thread Gonglei
On 2014/10/16 18:04, Peter Maydell wrote: > On 15 October 2014 11:05, Gerd Hoffmann wrote: >> From: Gonglei >> >> Introduce del_boot_device_path() to clean up fw_cfg content when >> hot-unplugging a device that refers to a bootindex or update a >> existent devcie's bootindex. > >> +void del_boo

Re: [Qemu-devel] pending target-mips patches

2014-10-16 Thread Aurelien Jarno
Hi, On Wed, Oct 01, 2014 at 04:35:46PM +0100, Leon Alrae wrote: > Hi All, > > I noticed that it's quite difficult to get target-mips changes > reviewed/accepted. There is already a queue of relatively big features > and bug fixes which are stuck for months. Does anyone have an idea how > to impro

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Paul Durrant
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: 16 October 2014 11:10 > To: Paul Durrant; Peter Maydell > Cc: QEMU Developers; xen-de...@lists.xenproject.org; Stefano Stabellini; > Michael Tokarev; Stefan Hajnoczi; Stefan Weil; Olaf Hering; Gerd Hoffmann; > A

Re: [Qemu-devel] pending target-mips patches

2014-10-16 Thread Leon Alrae
On 16/10/2014 11:12, Aurelien Jarno wrote: > Hi, > > On Wed, Oct 01, 2014 at 04:35:46PM +0100, Leon Alrae wrote: >> Hi All, >> >> I noticed that it's quite difficult to get target-mips changes >> reviewed/accepted. There is already a queue of relatively big features >> and bug fixes which are stuc

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Paolo Bonzini
Il 16/10/2014 12:16, Paul Durrant ha scritto: >> What exactly is the right semantics? Note that save _can_ fail, >> so you need the ability to roll back to the source machine. I >> think this is missing from your patch, and there is no post_save >> hook that you can use. > > I need something tha

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Paul Durrant
> -Original Message- > From: Paul Durrant > Sent: 16 October 2014 11:17 > To: 'Paolo Bonzini'; Peter Maydell > Cc: QEMU Developers; xen-de...@lists.xenproject.org; Stefano Stabellini; > Michael Tokarev; Stefan Hajnoczi; Stefan Weil; Olaf Hering; Gerd Hoffmann; > Alexey Kardashevskiy; Alexan

Re: [Qemu-devel] [PATCH v4] pc-dimm/numa: Fix stat of memory size in node when hotplug memory

2014-10-16 Thread Igor Mammedov
On Thu, 9 Oct 2014 20:21:57 +0800 zhanghailiang wrote: reword subj with: numa: make 'info numa' take into account hotplugged memory > When do memory hotplug, if there is numa node, we should add > the memory size to the corresponding node memory size. > > For now, it mainly affects the result o

Re: [Qemu-devel] [PATCH 6/6] vnc: track & limit connections

2014-10-16 Thread Gerd Hoffmann
Hi, > > I try to prevent that by dropping the *oldest* connection, so you have a > > chance to connect even if a unprivileged attacker tries to use up all > > connection slots. > > Lets say the limit is 5. The bad guy has 5 open idle connections. > The good guy opens a new one and pushes off on

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Stefano Stabellini
On Thu, 16 Oct 2014, Paul Durrant wrote: > > -Original Message- > > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > > Sent: 15 October 2014 15:38 > > To: Paul Durrant > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Stefano > > Stabellini; Peter Maydell; P

Re: [Qemu-devel] [PATCH v2 7/9] target-mips: add TLBINV support

2014-10-16 Thread Yongbok Kim
Hi Leon, As the issues below are all corrected in the PRPL already, Reviewed-by: Yongbok Kim Regards, Yongbok On 08/07/2014 08:57, Leon Alrae wrote: For Standard TLB configuration (Config.MT=1): TLBINV invalidates a set of TLB entries based on ASID. The virtual address is ignored in the e

Re: [Qemu-devel] [PATCH v2 0/5] vmware-vga: fix CVE-2014-3689

2014-10-16 Thread Gerd Hoffmann
On Mi, 2014-10-15 at 17:43 +0200, Michael Tokarev wrote: > On 15.10.2014 12:10, Gerd Hoffmann wrote: > >Hi, > > > > vmware-vga emulation lacks sanity checks in the hardware acceleration > > (blit + fill) functions. This patch series plugs the holes. > > > > v2 changes: > > * small whitespace

[Qemu-devel] [PATCH] glib: add compatibility interface for g_strcmp0()

2014-10-16 Thread arei.gonglei
From: Gonglei This patch fixes compilation errors when building against glib < 2.16.0 due to the missing g_strcmp0() function. Suggested-by: Peter Maydell Signed-off-by: Gonglei --- Because g_strcmp0() was called in three places, I provide a back-compat implementation. --- include/glib-com

Re: [Qemu-devel] [PATCH RFC 0/7] Translate guest vector operations to host vector operations

2014-10-16 Thread Kirill Batuzov
On Thu, 16 Oct 2014, Alex Bennée wrote: > > > > From Valgrind experience there are enough genericism. Valgrind can translate > > SSE, AltiVec and NEON instructions to vector opcodes. Most of the opcodes > > are > > reused between instruction sets. > > Doesn't Valgrind have the advantage of same-

Re: [Qemu-devel] [PATCH v4] pc-dimm/numa: Fix stat of memory size in node when hotplug memory

2014-10-16 Thread zhanghailiang
On 2014/10/16 18:36, Igor Mammedov wrote: On Thu, 9 Oct 2014 20:21:57 +0800 zhanghailiang wrote: reword subj with: numa: make 'info numa' take into account hotplugged memory When do memory hotplug, if there is numa node, we should add the memory size to the corresponding node memory size. Fo

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Stefano Stabellini
On Wed, 15 Oct 2014, Peter Maydell wrote: > On 15 October 2014 11:16, Paul Durrant wrote: > > The ioreq-server API added to Xen 4.5 offers better security than > > the existing Xen/QEMU interface because the shared pages that are > > used to pass emulation request/results back and forth are remove

[Qemu-devel] [PATCH] MAINTAINERS: add myself as MIPS guest cores co-maintainer

2014-10-16 Thread Leon Alrae
Add myself to the maintainer list for MIPS guest cores and update the status from "Odd Fixes" to "Maintained". Signed-off-by: Leon Alrae --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 206bf7e..e07662f 100644 --- a/MAINTAINERS

Re: [Qemu-devel] [PATCH v3 1/2] qdev: add qdev_build_hotpluggable_device_list helper

2014-10-16 Thread Igor Mammedov
On Mon, 6 Oct 2014 19:38:43 +0800 Zhu Guihua wrote: > For peripheral device del completion, add a function to build a list > for hotpluggable devices. > > Signed-off-by: Zhu Guihua > --- > hw/core/qdev.c | 14 ++ > include/hw/qdev-core.h | 2 ++ > 2 files changed, 16 inser

Re: [Qemu-devel] [PATCH v3 2/2] monitor: add del completion for peripheral device

2014-10-16 Thread Igor Mammedov
On Mon, 6 Oct 2014 19:38:44 +0800 Zhu Guihua wrote: > Add peripheral_device_del_completion() to let peripheral device del > completion be possible. > > Signed-off-by: Zhu Guihua > --- > monitor.c | 24 > 1 file changed, 24 insertions(+) > > diff --git a/monitor.c b/mo

Re: [Qemu-devel] [PATCH v3] qemu-char: Do not disconnect when there's data for reading

2014-10-16 Thread Zifei Tong
Friendly ping. I've saw a couple of scripts affected by this bug. Thanks, Zifei On Sep 19, 2014 10:03 PM, "Kirill Batuzov" wrote: > On 19.09.2014 11:12, Zifei Tong wrote: > >> After commit 812c1057f6175ac9a9829fa2920a2b5783814193 (Handle G_IO_HUP >> in tcp_chr_read for tcp chardev), connections

[Qemu-devel] [PATCH v5] numa: make 'info numa' take into account hotplugged memory

2014-10-16 Thread zhanghailiang
When do memory hotplug, if there is numa node, we should add the memory size to the corresponding node memory size. For now, it mainly affects the result of hmp command "info numa". Reviewed-by: Igor Mammedov Signed-off-by: zhanghailiang --- v5: - reword the subject (Igor Mammedov) - turn quer

[Qemu-devel] [PATCH] block: fix implicit convertion to invalid type

2014-10-16 Thread Igor Mammedov
change type of variable to expected IoOperationType which fixes compile warning: block.c:3655:20: warning: implicit conversion from enumeration type enum IoOperationType to different enumeration type BlockErrorAction Signed-off-by: Igor Mammedov --- block.c | 6 +++--- 1 file changed, 3 insert

[Qemu-devel] [PATCH v4 1/2] Add device listener interface

2014-10-16 Thread Paul Durrant
The Xen ioreq-server API, introduced in Xen 4.5, requires that PCI device models explicitly register with Xen for config space accesses. This patch adds a listener interface into qdev-core which can be used by the Xen interface code to monitor for arrival and departure of PCI devices. Signed-off-b

[Qemu-devel] [PATCH v4 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Paul Durrant
The ioreq-server API added to Xen 4.5 offers better security than the existing Xen/QEMU interface because the shared pages that are used to pass emulation request/results back and forth are removed from the guest's memory space before any requests are serviced. This prevents the guest from mapping

[Qemu-devel] [PATCH v4 0/2] Use ioreq-server API

2014-10-16 Thread Paul Durrant
This patch series is v4 of what was originally the single patch "Xen: Use the ioreq-server API when available". v2 of the series moved the code that added the PCI bus listener to patch #1 and the remainder of the changes to patch #2. Patch #2 was then re-worked to constrain the #ifdefing to xen_co

Re: [Qemu-devel] [PATCH 1/8] virtio-gpu/2d: add hardware spec include file

2014-10-16 Thread Gerd Hoffmann
Hi, > > How stable are these numbers? > > In theory the mesa/gallium numbers aren't stable, though I've never > seen them change yet, > > If they diverge in the future I'll just provide a remapping table > inside the guest driver. > > So it should be fine to expose these formats for 2D use.

Re: [Qemu-devel] [PATCH v3 2/2] Xen: Use the ioreq-server API when available

2014-10-16 Thread Peter Maydell
On 16 October 2014 13:29, Stefano Stabellini wrote: > Unfortunately even though it is pretty x86 specific, it is still > compiled on ARM, even though it is never actually used (it is used in > i386 emulation with Xen acceleration support, while on ARM we only use > the PV machine). Really? CONFIG

Re: [Qemu-devel] [PATCH v3 1/2] Add device listener interface

2014-10-16 Thread Igor Mammedov
On Wed, 15 Oct 2014 10:05:32 + Paul Durrant wrote: > > > > -Original Message- > > From: Igor Mammedov [mailto:imamm...@redhat.com] > > Sent: 15 October 2014 10:54 > > To: Paul Durrant > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Michael > > S. Tsirkin; Andreas Faer

Re: [Qemu-devel] [PATCH v5] numa: make 'info numa' take into account hotplugged memory

2014-10-16 Thread Gonglei
On 2014/10/16 20:02, zhanghailiang wrote: > When do memory hotplug, if there is numa node, we should add > the memory size to the corresponding node memory size. > > For now, it mainly affects the result of hmp command "info numa". > > Reviewed-by: Igor Mammedov > Signed-off-by: zhanghailiang

[Qemu-devel] [PATCH v5 0/7] Netduino 2 Machine Model

2014-10-16 Thread Alistair Francis
This patch series adds the Netduino 2 Machine to QEMU Information on the board is avalible at: http://www.netduino.com/netduino2/specs.htm The git tree can be found at: https://github.com/alistair23/qemu/tree/netduino2.5 This patch series makes some changes to the armv7m_init function that allow

[Qemu-devel] [PATCH v5 1/7] stm32f205_timer: Add the stm32f205 Timer

2014-10-16 Thread Alistair Francis
This patch adds the stm32f205 timers: TIM2, TIM3, TIM4 and TIM5 to QEMU. Signed-off-by: Alistair Francis --- V4: - Update timer units again - Thanks to Peter C V3: - Update debug statements - Correct the units for timer_mod - Correctly set timer_offset from resets V2: - Reorder the Makef

Re: [Qemu-devel] [PATCH v3 1/2] Add device listener interface

2014-10-16 Thread Paul Durrant
> -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: 16 October 2014 13:41 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Michael S. > Tsirkin; Andreas Faerber > Subject: Re: [PATCH v3 1/2] Add device listener interface > > On Wed

[Qemu-devel] [PATCH v5 7/7] netduino2: Add the Netduino 2 Machine

2014-10-16 Thread Alistair Francis
This patch adds the Netduino 2 Machine. This is a Cortex-M3 based machine. Information can be found at: http://www.netduino.com/netduino2/specs.htm Signed-off-by: Alistair Francis --- hw/arm/Makefile.objs | 1 + hw/arm/netduino2.c | 54 2

[Qemu-devel] [PATCH v5 3/7] stm32f205_SYSCFG: Add the stm32f205 SYSCFG

2014-10-16 Thread Alistair Francis
This patch adds the stm32f205 System Configuration Controller. This is used to configure what memory is mapped at address 0 (although that is not supported) as well as configure how the EXTI interrupts work (also not supported at the moment). This device is not required for basic examples, but mor

[Qemu-devel] [PATCH v5 2/7] stm32f205_USART: Add the stm32f205 USART Controller

2014-10-16 Thread Alistair Francis
This patch adds the stm32f205 USART controller (UART also uses the same controller). Signed-off-by: Alistair Francis --- default-configs/arm-softmmu.mak | 1 + hw/char/Makefile.objs | 1 + hw/char/stm32f205_usart.c | 218 ++ include/h

[Qemu-devel] [PATCH v5 5/7] target_arm: Parameterise the irq lines for armv7m_init

2014-10-16 Thread Alistair Francis
This patch allows the board to specifiy the number of NVIC interrupt lines when using armv7m_init. Signed-off-by: Alistair Francis --- hw/arm/armv7m.c | 7 --- hw/arm/stellaris.c | 5 - include/hw/arm/arm.h | 2 +- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/

[Qemu-devel] [PATCH v5 4/7] target_arm: Remove memory region init from armv7m_init

2014-10-16 Thread Alistair Francis
This patch moves the memory region init code from the armv7m_init function to the stellaris_init function Signed-off-by: Alistair Francis --- hw/arm/armv7m.c | 33 +++-- hw/arm/stellaris.c | 24 include/hw/arm/arm.h | 3 +-- 3 files ch

[Qemu-devel] [PATCH v5 6/7] stm32f205: Add the stm32f205 SoC

2014-10-16 Thread Alistair Francis
This patch adds the stm32f205 SoC. This will be used by the Netduino 2 to create a machine. Signed-off-by: Alistair Francis --- default-configs/arm-softmmu.mak | 1 + hw/arm/Makefile.objs| 1 + hw/arm/stm32f205_soc.c | 157 includ

Re: [Qemu-devel] [PATCH v2 7/9] target-mips: add TLBINV support

2014-10-16 Thread Leon Alrae
On 16/10/2014 11:52, Yongbok Kim wrote: >> +ctx.ie = (env->CP0_Config4 >> CP0C4_IE) & 1; > > & 3 > Yeah, initially I tested TLBINV using mips64r6-generic cpu where Config4.IE is set to 3, thus it worked... Thanks, Leon

Re: [Qemu-devel] [Bug 1381642] [NEW] ecovec.c:66: buffer too small by one.

2014-10-16 Thread Peter Maydell
On 15 October 2014 19:00, dcb <1381...@bugs.launchpad.net> wrote: > Public bug reported: > > [qemu-2.1.2/roms/u-boot/board/renesas/ecovec/ecovec.c:66]: (error) > Buffer is accessed out of bounds. This is in the u-boot code which we just carry a copy of to produce certain boot ROMs. You should repo

Re: [Qemu-devel] [PATCH v2 9/9] target-mips: update cpu_save/cpu_load to support new registers

2014-10-16 Thread Yongbok Kim
EHINV bit from TLB also required to be saved/ restored. Regards, Yongbok On 08/07/2014 08:57, Leon Alrae wrote: Signed-off-by: Leon Alrae --- target-mips/cpu.h |2 +- target-mips/machine.c | 14 ++ 2 files changed, 15 insertions(+), 1 deletions(-) diff --git a/targe

[Qemu-devel] [PATCH] util: Improve os_mem_prealloc error message

2014-10-16 Thread Michal Privoznik
Currently, when the preallocating guest memory process fails, an not so helpful error message is printed out: # virsh start migt10 error: Failed to start domain migt10 error: internal error: process exited while connecting to monitor: os_mem_prealloc: failed to preallocate pages >

[Qemu-devel] [PATCH 2/2] iotests: Add test for qcow2 L1 table update

2014-10-16 Thread Max Reitz
Updating the L1 table should not result in random data being written. This adds a test for that. Signed-off-by: Max Reitz --- tests/qemu-iotests/107 | 61 ++ tests/qemu-iotests/107.out | 10 tests/qemu-iotests/group | 1 + 3 files chang

[Qemu-devel] [PATCH 0/2] qcow2: Do not overflow when writing an L1 sector

2014-10-16 Thread Max Reitz
qcow2_write_l1_entry() may read L1 entries from beyond the end of the in-memory L1 table when updating a sector. Fix this and add a qemu-iotest. Max Reitz (2): qcow2: Do not overflow when writing an L1 sector iotests: Add test for qcow2 L1 table update block/qcow2-cluster.c | 6 +++--

[Qemu-devel] [PATCH 1/2] qcow2: Do not overflow when writing an L1 sector

2014-10-16 Thread Max Reitz
While writing an L1 table sector, qcow2_write_l1_entry() copies the respective range from s->l1_table to the local "buf" array. The size of s->l1_table does not have to be a multiple of L1_ENTRIES_PER_SECTOR; thus, limit the index which is used for copying all entries to the L1 size. Cc: qemu-sta.

Re: [Qemu-devel] [PATCH] block: fix implicit convertion to invalid type

2014-10-16 Thread Max Reitz
Am 16.10.2014 um 14:10 schrieb Igor Mammedov: change type of variable to expected IoOperationType which fixes compile warning: block.c:3655:20: warning: implicit conversion from enumeration type enum IoOperationType to different enumeration type BlockErrorAction Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH] block: fix implicit convertion to invalid type

2014-10-16 Thread Max Reitz
Am 16.10.2014 um 15:34 schrieb Max Reitz: Am 16.10.2014 um 14:10 schrieb Igor Mammedov: change type of variable to expected IoOperationType which fixes compile warning: block.c:3655:20: warning: implicit conversion from enumeration type enum IoOperationType to different enumeration type Bloc

Re: [Qemu-devel] Vmware Patch

2014-10-16 Thread Don Slutz
On 10/15/14 18:54, Ikbal Cam wrote: Hi All, I need to run ESXI as nested HV in KVM. Do you know if this patch has been ported to any qemu release and maybe available as RPM? ( Fedora, Redhat, Centos etc. ) https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg03806.html This is not i

Re: [Qemu-devel] [PATCH v2 1/5] vmware-vga: CVE-2014-3689: turn off hw accel

2014-10-16 Thread Don Koch
On Wed, 15 Oct 2014 12:10:35 +0200 Gerd Hoffmann wrote: > Quick & easy stopgap for CVE-2014-3689: We just compile out the > hardware acceleration functions which lack sanity checks. Thankfully > we have capability bits for them (SVGA_CAP_RECT_COPY and > SVGA_CAP_RECT_FILL), so guests should dea

Re: [Qemu-devel] [PATCH v2 3/5] vmware-vga: use vmsvga_verify_rect in vmsvga_update_rect

2014-10-16 Thread Don Koch
On Wed, 15 Oct 2014 12:10:37 +0200 Gerd Hoffmann wrote: > Switch vmsvga_update_rect over to use vmsvga_verify_rect. Slight change > in behavior: We don't try to automatically fixup rectangles any more. > In case we find invalid update requests we'll do a full-screen update > instead. This is g

Re: [Qemu-devel] [PATCH v2 4/5] vmware-vga: use vmsvga_verify_rect in vmsvga_copy_rect

2014-10-16 Thread Don Koch
On Wed, 15 Oct 2014 12:10:38 +0200 Gerd Hoffmann wrote: > Add verification to vmsvga_copy_rect, re-enable HW_RECT_ACCEL. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Gerd Hoffmann > --- > hw/display/vmware_vga.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH 1/6] target-mips: add Config5.SBRI

2014-10-16 Thread Yongbok Kim
Please update message body as it also adds dm{f,t}c0 for config{4,5}. See the comment below. Reviewed-by: Yongbok Kim Regards, Yongbok On 14/07/2014 17:19, Leon Alrae wrote: SDBBP instruction Reserved Instruction control. The purpose of this field is to restrict availability of SDBBP to kerne

Re: [Qemu-devel] [PATCH] util: Improve os_mem_prealloc error message

2014-10-16 Thread Eric Blake
On 10/16/2014 07:13 AM, Michal Privoznik wrote: > Currently, when the preallocating guest memory process fails, an not s/an/a/ > so helpful error message is printed out: > > # virsh start migt10 > error: Failed to start domain migt10 > error: internal error: process exited while conn

Re: [Qemu-devel] [PATCH 0/2] qcow2: Do not overflow when writing an L1 sector

2014-10-16 Thread Eric Blake
On 10/16/2014 07:25 AM, Max Reitz wrote: > qcow2_write_l1_entry() may read L1 entries from beyond the end of the > in-memory L1 table when updating a sector. Fix this and add a > qemu-iotest. > > > Max Reitz (2): > qcow2: Do not overflow when writing an L1 sector > iotests: Add test for qcow2

Re: [Qemu-devel] [PATCH] MAINTAINERS: add myself as MIPS guest cores co-maintainer

2014-10-16 Thread Aurelien Jarno
On Thu, Oct 16, 2014 at 12:38:07PM +0100, Leon Alrae wrote: > Add myself to the maintainer list for MIPS guest cores and update the status > from "Odd Fixes" to "Maintained". > > Signed-off-by: Leon Alrae > --- > MAINTAINERS | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --g

  1   2   >