On 15 October 2014 11:05, Gerd Hoffmann <kra...@redhat.com> wrote:
> From: Gonglei <arei.gong...@huawei.com>
>
> Introduce del_boot_device_path() to clean up fw_cfg content when
> hot-unplugging a device that refers to a bootindex or update a
> existent devcie's bootindex.
> +void del_boot_device_path(DeviceState *dev, const char *suffix)
> +{
> + FWBootEntry *i;
> +
> + if (dev == NULL) {
> + return;
> + }
> +
> + QTAILQ_FOREACH(i, &fw_boot_order, link) {
> + if ((!suffix || !g_strcmp0(i->suffix, suffix)) &&
I've just noticed that this won't build with our minimum
required glib version: g_strcmp0 wasn't introduced
until glib 2.16.
It should be fairly easy to provide a back-compat implementation
in our glib-compat.h header, or you could just rephrase this
to work with the usual strcmp, since you're already doing a
manual NULL check on one of the arguments.
thanks
-- PMM
