Re: [Qemu-devel] [PATCH v2] configure: make libnfs not_found message user friendly

2014-07-18 Thread Liu Yuan
On Tue, Jul 15, 2014 at 04:16:14PM +0200, Stefan Hajnoczi wrote: > On Mon, Jul 14, 2014 at 11:06:08AM +0800, Hu Tao wrote: > > On Sat, Jul 12, 2014 at 11:17:40AM +0800, Liu Yuan wrote: > > > Cc: Kevin Wolf > > > Signed-off-by: Liu Yuan > > > --- > > > configure | 2 +- > > > 1 file changed, 1 in

Re: [Qemu-devel] [Qemu-trivial] [PATCH] slirp: Give error message if hostfwd_add/remove for unrecognized vlan/stack

2014-07-18 Thread Peter Maydell
On 18 July 2014 06:22, Michael Tokarev wrote: > 08.07.2014 15:39, Peter Maydell wrote: >> On 26 June 2014 13:35, Peter Maydell wrote: >>> On 16 June 2014 16:47, Peter Maydell wrote: If the user specified a (vlan ID, slirp stack name) tuple in a monitor hostfwd_add/remove command and we

[Qemu-devel] [PATCH for-2.1] linux-user: hide reserved mmap in /proc/self/mmap

2014-07-18 Thread Mikhail Ilin
Hi, Running 32-bits binaries with address sanitizer (ASAN) instrumentations fails under 64-bits qemu. During initialization ASAN relies on the output from /proc/self/mmap then tries to find a big chunk for shadow memory but it is not happened. Reserved memory for guest address space is used priv

Re: [Qemu-devel] [PATCH v2] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-18 Thread Amit Shah
On (Fri) 18 Jul 2014 [08:27:59], Markus Armbruster wrote: > John Snow writes: > > > If a negative integer is used for the max_bytes parameter, QEMU currently > > calls abort() and leaves behind a core dump. This patch adds a simple > > error message to make the reason for the termination clearer.

Re: [Qemu-devel] [RFC PATCH v2 00/49] Series short description

2014-07-18 Thread Frederic Konrad
On 17/07/2014 13:01, Pavel Dovgalyuk wrote: This set of patches is related to the reverse execution and deterministic replay of qemu execution Our implementation of deterministic replay can be used for deterministic and reverse debugging of guest code through gdb remote interface. Execution rec

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-18 Thread Marcin Gibuła
could you try attached patch? It's an incredibly ugly workaround that calls cpu_synchronize_all_states() in a way that bypasses lazy execution logic. But it works for me. If that works for you as well, its somehow related to lazy execution of cpu_synchronize_all_states. -- mg Yes, it working w

Re: [Qemu-devel] can't boot debian wheezy sparc in qemu

2014-07-18 Thread Mark Cave-Ayland
On 18/07/14 07:06, Dennis Luehring wrote: Am 18.07.2014 00:22, schrieb Mark Cave-Ayland: On 17/07/14 07:43, Dennis Luehring wrote: > Am 16.07.2014 00:21, schrieb Mark Cave-Ayland: >> At the moment my work is focused on getting the basic system emulation >> up and running, so I haven't spent mu

Re: [Qemu-devel] [PATCH for-2.1] pc: fix qemu exiting with error when -m X < 128 with old machines types

2014-07-18 Thread Peter Maydell
On 17 July 2014 16:46, Bruce Rogers wrote: > >>> On 7/8/2014 at 07:29 AM, wrote: >> If machine doesn't support memory hotplug then staring QEMU >> with initial memory less than default will make QEMU exit with >> following error message: >> >> $QEMU -m 16 -M isapc >> qemu-system-i386: "-memory

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-18 Thread Andrey Korolyov
On Fri, Jul 18, 2014 at 12:21 PM, Marcin Gibuła wrote: >>> could you try attached patch? It's an incredibly ugly workaround that >>> calls >>> cpu_synchronize_all_states() in a way that bypasses lazy execution logic. >>> >>> But it works for me. If that works for you as well, its somehow related >

Re: [Qemu-devel] [PATCH V3 2/5] runner: Tool for fuzz tests execution

2014-07-18 Thread Stefan Hajnoczi
On Wed, Jul 16, 2014 at 11:49:36PM +0400, Maria Kustova wrote: > +def __init__(self, test_id, seed, work_dir, run_log, > + cleanup=True, log_all=False): > +"""Set test environment in a specified work directory. > + > +Path to qemu-img and qemu-io will be retrieve

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-18 Thread Marcin Gibuła
Does it fix problem with libvirt migration timing out for you as well? Oh, forgot to mention - yes, all migration-related problems are fixed. Though release right now in a freeze phase, I`d like to ask maintainers to consider possibility of fixing the problem on top of the current tree instead

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-18 Thread Paolo Bonzini
Il 17/07/2014 15:25, Marcin Gibuła ha scritto: +static void do_kvm_cpu_synchronize_state_always(void *arg) +{ +CPUState *cpu = arg; + +kvm_arch_get_registers(cpu); +} + The name of the hack^Wfunction is tricky, because compared to do_kvm_cpu_synchronize_state there are three things you

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-18 Thread Paolo Bonzini
Il 18/07/2014 10:44, Marcin Gibuła ha scritto: Paolo, if patch in its current form is not acceptable for you for inclusion, I'll try rewrite it according to your comments. The problem is that we don't know _why_ the patch is fixing things. Considering that your kvmclock bug has been there

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-18 Thread Amit Shah
On (Fri) 18 Jul 2014 [10:48:40], Paolo Bonzini wrote: > Il 17/07/2014 15:25, Marcin Gibuła ha scritto: > >+static void do_kvm_cpu_synchronize_state_always(void *arg) > >+{ > >+CPUState *cpu = arg; > >+ > >+kvm_arch_get_registers(cpu); > >+} > >+ > > The name of the hack^Wfunction is tricky

[Qemu-devel] [PULL for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18

2014-07-18 Thread Paolo Bonzini
The following changes since commit 146ae00192ffcbd78f6b11fa78c72d1b3d628d8a: Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' into staging (2014-07-15 15:51:12 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for y

[Qemu-devel] [PULL 4/6] module: Don't complain when a module is absent

2014-07-18 Thread Paolo Bonzini
From: Andreas Färber The current implementation depends on a configure-time generated list of block modules. When any of them is absent, module_load() emits a warning. This is suboptimal because extracting code to modules was mainly done to allow separate packaging of modules with intrusive depe

[Qemu-devel] [PULL 5/6] Revert "kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation"

2014-07-18 Thread Paolo Bonzini
This reverts commit 9b1786829aefb83f37a8f3135e3ea91c56001b56. Cc: ag...@suse.de Cc: mtosa...@redhat.com Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini --- hw/i386/kvm/clock.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/i386/kvm/clock.c b/hw/i386/kvm/clock.c index 272a88a..

[Qemu-devel] [PULL 2/6] qtest: new test for wdt_ib700

2014-07-18 Thread Paolo Bonzini
Since the "pause" watchdog action had a regression and it went unnoticed for a while, let's add a test for it. Signed-off-by: Paolo Bonzini --- tests/Makefile | 2 + tests/wdt_ib700-test.c | 134 + 2 files changed, 136 insertions(+) crea

[Qemu-devel] [PULL 1/6] target-i386: Allow execute from user mode when SMEP is enabled.

2014-07-18 Thread Paolo Bonzini
From: Ricky Zhou Previously, execute would be disabled for all pages with SMEP enabled, regardless of what mode the access took place in. Signed-off-by: Ricky Zhou Signed-off-by: Paolo Bonzini --- target-i386/helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/targe

[Qemu-devel] [PULL 3/6] module: Simplify module_load()

2014-07-18 Thread Paolo Bonzini
From: Andreas Färber The file path is not used for error reporting, so we can free it directly after use. Reviewed-by: Fam Zheng Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- util/module.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/util/module.

[Qemu-devel] [PULL 6/6] Revert "kvmclock: Ensure time in migration never goes backward"

2014-07-18 Thread Paolo Bonzini
This reverts commit a096b3a6732f846ec57dc28b47ee9435aa0609bf. Cc: ag...@suse.de Cc: mtosa...@redhat.com Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini --- hw/i386/kvm/clock.c | 48 1 file changed, 48 deletions(-) diff --git a/hw/i386/kvm

Re: [Qemu-devel] [PATCH V3 3/5] fuzz: Fuzzing functions for qcow2 images

2014-07-18 Thread Stefan Hajnoczi
On Wed, Jul 16, 2014 at 11:49:37PM +0400, Maria Kustova wrote: > +def string_validator(current, strings): > +"""Return a random string value from the list not equal to the current. > + > +This function is useful for selection from valid values except current > one. > +""" > +val =

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-18 Thread Marcin Gibuła
The name of the hack^Wfunction is tricky, because compared to do_kvm_cpu_synchronize_state there are three things you change: 1) you always synchronize the state 2) the next call to do_kvm_cpu_synchronize_state will do kvm_arch_get_registers Yes. 3) the next CPU entry will call kvm_arch_put_

[Qemu-devel] [PATCH v2] Tap: fix vcpu long time io blocking on tap

2014-07-18 Thread Wangkai (Kevin,C)
fix vcpu long time io blocking on tap, when too many packets was delivered to the guest os via tap interface. -- Signed-off-by: Wangkai diff --git a/net/tap.c b/net/tap.c index a40f7f0..1da6d89 100644 --- a/net/tap.c +++ b/net/tap.c @@ -189,6 +189,7 @@ static void tap_send(void *opaque) {

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-18 Thread Paolo Bonzini
Il 18/07/2014 11:32, Marcin Gibuła ha scritto: 3) the next CPU entry will call kvm_arch_put_registers: if (cpu->kvm_vcpu_dirty) { kvm_arch_put_registers(cpu, KVM_PUT_RUNTIME_STATE); cpu->kvm_vcpu_dirty = false; } But, I don't set cpu->kvm_vcpu_dirt

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-18 Thread Marcin Gibuła
W dniu 2014-07-18 11:37, Paolo Bonzini pisze: Il 18/07/2014 11:32, Marcin Gibuła ha scritto: 3) the next CPU entry will call kvm_arch_put_registers: if (cpu->kvm_vcpu_dirty) { kvm_arch_put_registers(cpu, KVM_PUT_RUNTIME_STATE); cpu->kvm_vcpu_dirty = false;

Re: [Qemu-devel] virtio + virtq + iommu

2014-07-18 Thread Anshul Makkar
Further adding on to it. iotlb = mr->iommu_ops->translate(mr, addr) in address_space_translate to get the translation from the tlb. What I found is that the "iommu_ops->translate" is assigned a function pointer only for alpha/typhoon and ppc/spapr. What about x86. Are we using any of these arch

[Qemu-devel] [Bug 1303926] Re: qemu-system-x86_64 crashed with SIGABRT

2014-07-18 Thread Sunding Wei
Anyone works on the crash now? The above back trace shows it crashed at assert(s->current) ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1303926 Title: qemu-system-x86_64 crashed with SIGABRT S

Re: [Qemu-devel] [PATCH v4 0/8] Obtain dirty bitmap via VM logging

2014-07-18 Thread Dr. David Alan Gilbert
* Sanidhya Kashyap (sanidhya.ii...@gmail.com) wrote: > Hi, > > The following patches introduce the support of the dirty bitmap logging and > dumping to a specified file. This patch addresses the previous issues raised > by David and Juan. Since, I have not received any comments on the runstates, >

Re: [Qemu-devel] [PATCH v4 1/8] enable sharing of the function between migration and bitmap dump

2014-07-18 Thread Dr. David Alan Gilbert
* Sanidhya Kashyap (sanidhya.ii...@gmail.com) wrote: > Added prefix qemu_ to the function as pointed out by Juan. > > Signed-off-by: Sanidhya Kashyap > --- > arch_init.c | 19 +++ > include/exec/ram_addr.h | 4 > 2 files changed, 15 insertions(+), 8 deletions(-)

Re: [Qemu-devel] [PATCH v4 2/8] RunState: added two new flags for bitmap dump and migration process

2014-07-18 Thread Dr. David Alan Gilbert
* Sanidhya Kashyap (sanidhya.ii...@gmail.com) wrote: > Changed those files that were directly using the RUN_STATE_RUNNING flag. Now, > they have been replaced by the runstate_is_running() function. I've cc'd Gerd (aka kraxel) in since he's the USB maintainer. (and those fixes look worth while irre

Re: [Qemu-devel] [PATCH for-2.1] po: Update German translation

2014-07-18 Thread Kevin Wolf
Am 17.07.2014 um 20:50 hat Stefan Weil geschrieben: > Line numbers changed, and some translations were missing after commit > 3d914488aee3dc1bf495e461aedf8fb4e5bb2270. > > Update also "Show Tabs" to a more common translation, and remove some > old unused lines at the end. > > Signed-off-by: Stefa

Re: [Qemu-devel] [PATCH for-2.1] qemu-iotests: fix 028 failure due to disk image path

2014-07-18 Thread Kevin Wolf
Am 17.07.2014 um 20:13 hat Stefan Hajnoczi geschrieben: > The disk image path is echoed by QEMU's readline when the "drive_backup > disk ${TEST_IMG}.copy" HMP command is issued. Unfortunately it is very > hard to filter out the path due to readline's character-by-character > output (with terminal

Re: [Qemu-devel] [PATCH] block/quorum: implement .bdrv_co_get_block_status

2014-07-18 Thread Kevin Wolf
Am 18.07.2014 um 07:52 hat Liu Yuan geschrieben: > On Fri, Jul 18, 2014 at 11:11:31AM +0800, Fam Zheng wrote: > > On Thu, 07/17 19:50, Liu Yuan wrote: > > > - allow drive-mirror to create sprase mirror on images like qcow2 > > > - allow qemu-img map to work as expected on quorum driver > > > > > >

Re: [Qemu-devel] [PATCH v4 3/8] BitmapLog: bitmap dump code via QAPI framework with runstates

2014-07-18 Thread Dr. David Alan Gilbert
* Sanidhya Kashyap (sanidhya.ii...@gmail.com) wrote: > Reformatted the code and added the functionality of dumping the blocks' info > which can be read by the user when required. I have also made the block name > length global. > Some minor modification to the structure which is now storing all the

Re: [Qemu-devel] [PATCH v4 3/8] BitmapLog: bitmap dump code via QAPI framework with runstates

2014-07-18 Thread Dr. David Alan Gilbert
* Sanidhya Kashyap (sanidhya.ii...@gmail.com) wrote: One more I forgot: > +while (b->current_epoch <= b->total_epochs) { > +if (!runstate_check(RUN_STATE_DUMP_BITMAP) || > +b->state != LOG_BITMAP_STATE_ACTIVE) { > +goto log_thread_end; > +} > +

Re: [Qemu-devel] [PATCH v2] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-18 Thread Markus Armbruster
Amit Shah writes: > On (Fri) 18 Jul 2014 [08:27:59], Markus Armbruster wrote: >> John Snow writes: >> >> > If a negative integer is used for the max_bytes parameter, QEMU currently >> > calls abort() and leaves behind a core dump. This patch adds a simple >> > error message to make the reason f

Re: [Qemu-devel] [PATCH v4 4/8] BitmapLog: hmp interface for dirty bitmap dump

2014-07-18 Thread Dr. David Alan Gilbert
* Sanidhya Kashyap (sanidhya.ii...@gmail.com) wrote: > Signed-off-by: Sanidhya Kashyap > --- > hmp-commands.hx | 16 > hmp.c | 16 > hmp.h | 1 + > 3 files changed, 33 insertions(+) > > diff --git a/hmp-commands.hx b/hmp-commands.hx > index

Re: [Qemu-devel] [PATCH v4 8/8] BitmapLog: python script for extracting bitmap from a binary file

2014-07-18 Thread Dr. David Alan Gilbert
* Sanidhya Kashyap (sanidhya.ii...@gmail.com) wrote: > Signed-off-by: Sanidhya Kashyap I'm not really a python-person, but one observation: > +def get_string(value, length): > + name = struct.unpack('<'+str(length)+'s', value)[0] > + for i in range(len(name)): > + if name[i]

Re: [Qemu-devel] [PATCH v2] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-18 Thread Amit Shah
On (Fri) 18 Jul 2014 [13:15:18], Markus Armbruster wrote: > Amit Shah writes: > > > On (Fri) 18 Jul 2014 [08:27:59], Markus Armbruster wrote: > >> John Snow writes: > >> > >> > If a negative integer is used for the max_bytes parameter, QEMU currently > >> > calls abort() and leaves behind a cor

Re: [Qemu-devel] [PULL 5/6] Revert "kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation"

2014-07-18 Thread Amit Shah
On (Fri) 18 Jul 2014 [11:04:24], Paolo Bonzini wrote: > This reverts commit 9b1786829aefb83f37a8f3135e3ea91c56001b56. > > Cc: ag...@suse.de > Cc: mtosa...@redhat.com > Cc: qemu-sta...@nongnu.org > Signed-off-by: Paolo Bonzini Please include some information on why this is being reverted. Helps

Re: [Qemu-devel] [PULL 5/6] Revert "kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation"

2014-07-18 Thread Alexander Graf
On 18.07.14 13:31, Amit Shah wrote: On (Fri) 18 Jul 2014 [11:04:24], Paolo Bonzini wrote: This reverts commit 9b1786829aefb83f37a8f3135e3ea91c56001b56. Cc: ag...@suse.de Cc: mtosa...@redhat.com Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini Please include some information on why thi

Re: [Qemu-devel] [PULL 5/6] Revert "kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation"

2014-07-18 Thread Amit Shah
On (Fri) 18 Jul 2014 [13:36:15], Alexander Graf wrote: > > On 18.07.14 13:31, Amit Shah wrote: > >On (Fri) 18 Jul 2014 [11:04:24], Paolo Bonzini wrote: > >>This reverts commit 9b1786829aefb83f37a8f3135e3ea91c56001b56. > >> > >>Cc: ag...@suse.de > >>Cc: mtosa...@redhat.com > >>Cc: qemu-sta...@nongn

Re: [Qemu-devel] [PATCH v2] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-18 Thread Markus Armbruster
Amit Shah writes: > On (Fri) 18 Jul 2014 [13:15:18], Markus Armbruster wrote: >> Amit Shah writes: >> >> > On (Fri) 18 Jul 2014 [08:27:59], Markus Armbruster wrote: >> >> John Snow writes: >> >> >> >> > If a negative integer is used for the max_bytes parameter, QEMU >> >> > currently >> >> >

Re: [Qemu-devel] [PATCH for-2.2] spapr: add host Linux version information to device tree

2014-07-18 Thread Eric Blake
On 07/17/2014 10:31 PM, cyril...@gmail.com wrote: > It may prove useful know which Linux distribution version the host machine > is running when an issue in the guest arises but a user cannot access > the host. > > Signed-off-by: Cyril Bur > --- > hw/ppc/spapr.c | 8 +++ > target-ppc/

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.2] spapr: add host Linux version information to device tree

2014-07-18 Thread Alexander Graf
On 18.07.14 13:59, Eric Blake wrote: On 07/17/2014 10:31 PM, cyril...@gmail.com wrote: It may prove useful know which Linux distribution version the host machine is running when an issue in the guest arises but a user cannot access the host. Signed-off-by: Cyril Bur --- hw/ppc/spapr.c

Re: [Qemu-devel] [PATCH V3 4/5] layout: Generator of fuzzed qcow2 images

2014-07-18 Thread Stefan Hajnoczi
On Wed, Jul 16, 2014 at 11:49:38PM +0400, Maria Kustova wrote: > +@staticmethod > +def _header(cluster_bits, img_size, backing_file_name=None): > +"""Generate a random valid header""" > +meta_header = [ > +['>4s', 0, "QFI\xfb", 'magic'], > +['>I', 4,

Re: [Qemu-devel] [PATCH] block/quorum: implement .bdrv_co_get_block_status

2014-07-18 Thread Eric Blake
On 07/17/2014 09:11 PM, Fam Zheng wrote: > On Thu, 07/17 19:50, Liu Yuan wrote: >> - allow drive-mirror to create sprase mirror on images like qcow2 >> - allow qemu-img map to work as expected on quorum driver >> >> >> +static int64_t coroutine_fn quorum_co_get_block_status(BlockDriverState *bs,

Re: [Qemu-devel] [PATCH v2] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-18 Thread Amit Shah
On (Fri) 18 Jul 2014 [13:54:01], Markus Armbruster wrote: > Amit Shah writes: > > > On (Fri) 18 Jul 2014 [13:15:18], Markus Armbruster wrote: > >> Amit Shah writes: > >> > >> > On (Fri) 18 Jul 2014 [08:27:59], Markus Armbruster wrote: > >> >> John Snow writes: > >> >> > >> >> > If a negative

Re: [Qemu-devel] [PATCH v4 2/8] RunState: added two new flags for bitmap dump and migration process

2014-07-18 Thread Eric Blake
On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote: > Changed those files that were directly using the RUN_STATE_RUNNING flag. Now, > they have been replaced by the runstate_is_running() function. > > Signed-off-by: Sanidhya Kashyap > --- > hw/usb/hcd-ehci.c | 2 +- > hw/usb/redirect.c | 6 +++---

Re: [Qemu-devel] [PATCH for-2.2 0/5] scsi: enable passthrough of vendor-specific commands

2014-07-18 Thread TAMUKI Shoichi
Hello, From: Paolo Bonzini Subject: [PATCH for-2.2 0/5] scsi: enable passthrough of vendor-specific commands Date: Wed, 16 Jul 2014 14:54:45 +0200 > Right now scsi-generic is parsing the CDB, in order to compute > the expected number of bytes to be transferred. This is necessary > if DMA is do

Re: [Qemu-devel] [PATCH v4 3/8] BitmapLog: bitmap dump code via QAPI framework with runstates

2014-07-18 Thread Eric Blake
On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote: > Reformatted the code and added the functionality of dumping the blocks' info > which can be read by the user when required. I have also made the block name > length global. > Some minor modification to the structure which is now storing all the > in

Re: [Qemu-devel] [PATCH for-2.1 0/2] raw-posix: Fail gracefully if no working alignment is found

2014-07-18 Thread Stefan Hajnoczi
On Wed, Jul 16, 2014 at 05:48:15PM +0200, Kevin Wolf wrote: > Kevin Wolf (2): > block: Add Error argument to bdrv_refresh_limits() > raw-posix: Fail gracefully if no working alignment is found > > block.c | 33 +++-- > block/iscsi.c |

Re: [Qemu-devel] [PATCH v4 5/8] BitmapLog: cancel mechanism for an already running dump bitmap process

2014-07-18 Thread Eric Blake
On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote: > Signed-off-by: Sanidhya Kashyap > --- > hmp-commands.hx | 14 ++ > hmp.c| 5 + > hmp.h| 1 + > qapi-schema.json | 8 > qmp-commands.hx | 21 + > savevm.c | 19 ++

Re: [Qemu-devel] [PULL v2 0/7] pc,vhost,test fixes

2014-07-18 Thread Peter Maydell
On 18 July 2014 00:44, Michael S. Tsirkin wrote: > Resending. > v1 has exactly the same patches but had the wrong text in the tag. > Sorry about that. > > The following changes since commit 3f0838ab8557c6071a5931183b2d7fed568cd35c: > > qemu-char: add chr_add_watch support in mux chardev (2014-07

Re: [Qemu-devel] [PATCH for-2.1] qemu-iotests: fix 028 failure due to disk image path

2014-07-18 Thread Stefan Hajnoczi
On Thu, Jul 17, 2014 at 07:13:39PM +0100, Stefan Hajnoczi wrote: > The disk image path is echoed by QEMU's readline when the "drive_backup > disk ${TEST_IMG}.copy" HMP command is issued. Unfortunately it is very > hard to filter out the path due to readline's character-by-character > output (with

Re: [Qemu-devel] [PATCH v4 6/8] BitmapLog: set the frequency of the dump bitmap process

2014-07-18 Thread Eric Blake
On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote: > Rectified the example mistake in qmp-commands.hx. Is this comment about a mistake that existed prior to your series, or is it a changelog compared to v1-3 of your posts? If the former, it might be nice to say which existing commit was buggy (so we

Re: [Qemu-devel] [PATCH v4 7/8] BitmapLog: get the information about the parameters

2014-07-18 Thread Eric Blake
On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote: > Added the qmp interface to know about the information of the bitmap dump > process. When the command is executed, one can know about the current epoch > value in which the process is in, the total iterations value and the current > frequency value.

Re: [Qemu-devel] [PATCH v4 0/8] Obtain dirty bitmap via VM logging

2014-07-18 Thread Eric Blake
On 07/17/2014 05:21 AM, Sanidhya Kashyap wrote: > Hi, > > The following patches introduce the support of the dirty bitmap logging and > dumping to a specified file. This patch addresses the previous issues raised > by David and Juan. Since, I have not received any comments on the runstates, > I'll

[Qemu-devel] [PULL for-2.1 1/4] qcow2: Fix error path for unknown incompatible features

2014-07-18 Thread Stefan Hajnoczi
From: Kevin Wolf qcow2's report_unsupported_feature() had two bugs: A 32 bit truncation would prevent feature table entries for bits 32-63 from being used, and it could assign errp multiple times if there was more than one unknown feature, resulting in an error_set() assertion failure. Fix the t

[Qemu-devel] [PULL for-2.1 4/4] qemu-iotests: fix 028 failure due to disk image path

2014-07-18 Thread Stefan Hajnoczi
The disk image path is echoed by QEMU's readline when the "drive_backup disk ${TEST_IMG}.copy" HMP command is issued. Unfortunately it is very hard to filter out the path due to readline's character-by-character output (with terminal escape sequences). Just redirect this command to /dev/null for

[Qemu-devel] [PULL for-2.1 2/4] block: Add Error argument to bdrv_refresh_limits()

2014-07-18 Thread Stefan Hajnoczi
From: Kevin Wolf Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- block.c | 33 +++-- block/iscsi.c | 3 +-- block/qcow2.c | 4 +--- block/qed.c | 4 +--- block/raw-posix

[Qemu-devel] [PULL for-2.1 0/4] Block patches

2014-07-18 Thread Stefan Hajnoczi
The following changes since commit 5a7348045091a2bc15d85bb177e5956aa6114e5a: Update version for v2.1.0-rc2 release (2014-07-15 18:55:37 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to 8283c5c316333fb9d2

[Qemu-devel] [PULL for-2.1 3/4] raw-posix: Fail gracefully if no working alignment is found

2014-07-18 Thread Stefan Hajnoczi
From: Kevin Wolf If qemu couldn't find out what O_DIRECT alignment to use with a given file, it would run into assert(bdrv_opt_mem_align(bs) != 0); in block.c and confuse users. This adds a more descriptive error message for such cases. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Signed-

Re: [Qemu-devel] [PULL for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18

2014-07-18 Thread Peter Maydell
On 18 July 2014 10:04, Paolo Bonzini wrote: > The following changes since commit 146ae00192ffcbd78f6b11fa78c72d1b3d628d8a: > > Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' > into staging (2014-07-15 15:51:12 +0100) > > are available in the git repository at: > > >

Re: [Qemu-devel] [PULL for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18

2014-07-18 Thread Paolo Bonzini
Il 18/07/2014 14:46, Peter Maydell ha scritto: > On 18 July 2014 10:04, Paolo Bonzini wrote: >> The following changes since commit 146ae00192ffcbd78f6b11fa78c72d1b3d628d8a: >> >> Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' >> into staging (2014-07-15 15:51:12 +0100

Re: [Qemu-devel] [PATCH v2] virtio-rng: Add human-readable error message for negative max-bytes parameter

2014-07-18 Thread Markus Armbruster
Amit Shah writes: > On (Fri) 18 Jul 2014 [13:54:01], Markus Armbruster wrote: >> Amit Shah writes: >> >> > On (Fri) 18 Jul 2014 [13:15:18], Markus Armbruster wrote: >> >> Amit Shah writes: >> >> >> >> > On (Fri) 18 Jul 2014 [08:27:59], Markus Armbruster wrote: >> >> >> John Snow writes: >> >

[Qemu-devel] USB MTP emulation state?

2014-07-18 Thread Paolo Bonzini
I took a quick look at the MTP emulation and the first things I noticed are: * all I/O is synchronous >> I guess this is just a limitation of the code * it doesn't use the -fsdev infrastructure >> Perhaps we should rename the "root" property to x-root to identify it as

[Qemu-devel] [PULL v2 for-2.1 0/6] target-i386, module, qtest patches for 2014-07-18

2014-07-18 Thread Paolo Bonzini
The following changes since commit 146ae00192ffcbd78f6b11fa78c72d1b3d628d8a: Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' into staging (2014-07-15 15:51:12 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for y

[Qemu-devel] [PULL 1/6] target-i386: Allow execute from user mode when SMEP is enabled.

2014-07-18 Thread Paolo Bonzini
From: Ricky Zhou Previously, execute would be disabled for all pages with SMEP enabled, regardless of what mode the access took place in. Signed-off-by: Ricky Zhou Signed-off-by: Paolo Bonzini --- target-i386/helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/targe

[Qemu-devel] [PULL 5/6] Revert "kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation"

2014-07-18 Thread Paolo Bonzini
This reverts commit 9b1786829aefb83f37a8f3135e3ea91c56001b56. This patch fixed a hang introduced by commit a096b3a (kvmclock: Ensure time in migration never goes backward, 2014-05-16), but it causes a regression in migration whose cause is not quite clear. Because of this, I'm choosing to revert

[Qemu-devel] [PULL 3/6] module: Simplify module_load()

2014-07-18 Thread Paolo Bonzini
From: Andreas Färber The file path is not used for error reporting, so we can free it directly after use. Reviewed-by: Fam Zheng Signed-off-by: Andreas Färber Signed-off-by: Paolo Bonzini --- util/module.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/util/module.

[Qemu-devel] [PULL 2/6] qtest: new test for wdt_ib700

2014-07-18 Thread Paolo Bonzini
Since the "pause" watchdog action had a regression and it went unnoticed for a while, let's add a test for it. Signed-off-by: Paolo Bonzini --- tests/Makefile | 3 ++ tests/wdt_ib700-test.c | 134 + 2 files changed, 137 insertions(+) cre

[Qemu-devel] [PULL 4/6] module: Don't complain when a module is absent

2014-07-18 Thread Paolo Bonzini
From: Andreas Färber The current implementation depends on a configure-time generated list of block modules. When any of them is absent, module_load() emits a warning. This is suboptimal because extracting code to modules was mainly done to allow separate packaging of modules with intrusive depe

[Qemu-devel] [PULL 6/6] Revert "kvmclock: Ensure time in migration never goes backward"

2014-07-18 Thread Paolo Bonzini
This reverts commit a096b3a6732f846ec57dc28b47ee9435aa0609bf. This patch caused a hang that was fixed by commit 9b17868 (kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation, 2014-06-03), and we just had to revert that commit. Drop this one too. Cc: ag...@suse.de Cc: mtos

Re: [Qemu-devel] [PATCH] block/quorum: implement .bdrv_co_get_block_status

2014-07-18 Thread Paolo Bonzini
Il 17/07/2014 13:50, Liu Yuan ha scritto: > - allow drive-mirror to create sprase mirror on images like qcow2 > - allow qemu-img map to work as expected on quorum driver > > Cc: Benoit Canet > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Signed-off-by: Liu Yuan > --- > block/quorum.c | 16 +

Re: [Qemu-devel] [PATCH v4 0/8] Obtain dirty bitmap via VM logging

2014-07-18 Thread Eric Blake
On 07/18/2014 04:56 AM, Dr. David Alan Gilbert wrote: > * Sanidhya Kashyap (sanidhya.ii...@gmail.com) wrote: >> Hi, >> >> The following patches introduce the support of the dirty bitmap logging and >> dumping to a specified file. This patch addresses the previous issues raised >> by David and Juan.

Re: [Qemu-devel] [Intel-gfx] ResettRe: [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-18 Thread Konrad Rzeszutek Wilk
On Thu, Jul 17, 2014 at 05:37:12PM +, Kay, Allen M wrote: > > That sounds great. Tiejun could you confirm that with windows driver guys > > too? > > I believe windows driver can also assume specific CPU/PCH combos. I will > discuss this with native Windows driver guys. Preferably, the same

Re: [Qemu-devel] [PULL for-2.1 0/4] Block patches

2014-07-18 Thread Peter Maydell
On 18 July 2014 13:41, Stefan Hajnoczi wrote: > The following changes since commit 5a7348045091a2bc15d85bb177e5956aa6114e5a: > > Update version for v2.1.0-rc2 release (2014-07-15 18:55:37 +0100) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git tags/block-pull-

Re: [Qemu-devel] [PULL 4/6] module: Don't complain when a module is absent

2014-07-18 Thread Michael Tokarev
18.07.2014 13:04, Paolo Bonzini wrote: > From: Andreas Färber > > The current implementation depends on a configure-time generated list of > block modules. When any of them is absent, module_load() emits a warning. > > This is suboptimal because extracting code to modules was mainly done to > al

[Qemu-devel] [PULL 7/8] migration: Add missing 'static' attribute

2014-07-18 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- block-migration.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block-migration.c b/block-migration.c index 25a0388..73cdd07 100644 --- a/block-migration.c +++ b/block-migration.c @@ -861,7

[Qemu-devel] [PULL 6/8] qga: Add missing 'static' attribute

2014-07-18 Thread Michael Tokarev
From: Stefan Weil This fixes a warning from the static code analysis (smatch). Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- qga/commands-posix.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 34ddba0..8

[Qemu-devel] [PULL 4/8] doc: slirp supports ICMP echo if enabled in Linux

2014-07-18 Thread Michael Tokarev
From: Gernot Hillier Since QEMU 0.15, slirp (user mode networking) supports ping to the Internet, see e6d43cfb1f9 Signed-off-by: Gernot Hillier Signed-off-by: Michael Tokarev --- qemu-doc.texi | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/qemu-doc.texi b

[Qemu-devel] [PULL 2/8] Fix new typos in comments (found by codespell)

2014-07-18 Thread Michael Tokarev
From: Stefan Weil arbitary -> arbitrary basicly -> basically Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- hw/i386/pc_piix.c |2 +- hw/i386/pc_q35.c |2 +- include/libdecnumber/decNumberLocal.h |2 +- xen-hvm.c

[Qemu-devel] [PULL 5/8] hw/usb: Add missing 'static' attribute

2014-07-18 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- hw/usb/hcd-ohci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index cace945..13afdf5 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -2021,

[Qemu-devel] [PULL for-2.1 0/8] Trivial patches for 2014-07-18

2014-07-18 Thread Michael Tokarev
Since we're close to release, I included only really-really-trivial and safe changes in this pull request, -- only those which wont break anything. One good patch is a documentation change mentioning icmp sockets, plus a series from Stefan Weil which adds some missing `static' attributes here and

[Qemu-devel] [PULL 3/8] qemu-img: Remove redundancy "ret = -1"

2014-07-18 Thread Michael Tokarev
From: Chen Gang In this case, 'ret' is already '-1', so need not do it again. Signed-off-by: Chen Gang Signed-off-by: Michael Tokarev --- qemu-img.c |1 - 1 file changed, 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index c98896b..d4518e7 100644 --- a/qemu-img.c +++ b/qemu-img.c @@

[Qemu-devel] [PULL 8/8] tests: Add missing 'static' attributes (fix warnings from smatch)

2014-07-18 Thread Michael Tokarev
From: Stefan Weil Smatch also complains about 0 used for pointers, so replace those by NULL in test-visitor-serialization.c, too. Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- tests/fdc-test.c |2 +- tests/test-aio.c |2 +- tests/tes

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Andreas Färber
Am 17.07.2014 19:00, schrieb Paolo Bonzini: > Il 17/07/2014 18:47, Michael Roth ha scritto: >>> > My argument for getting this into 2.1 had been to avoid tools >>> picking up >>> > these to-be-renamed property names from the start. At this point, I'm >>> > not so sure whether it's worse to break ma

[Qemu-devel] [PULL 1/8] slirp: Give error message if hostfwd_add/remove for unrecognized vlan/stack

2014-07-18 Thread Michael Tokarev
From: Peter Maydell If the user specified a (vlan ID, slirp stack name) tuple in a monitor hostfwd_add/remove command and we can't find it, give the user an error message rather than silently doing nothing. This brings this error case in slirp_lookup() into line with the other two. Signed-off-b

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Paolo Bonzini
Il 18/07/2014 16:15, Andreas Färber ha scritto: > I was mainly concerned about qom-set, but same goes for qom-get. The > breakage would be in 2.2, if in 2.1 we introduce properties with foo_bar > and rename them to foo-bar in 2.2. Since they're not in 2.0, I had asked > Marcel to rename them for 2.

Re: [Qemu-devel] [PULL 2/8] Fix new typos in comments (found by codespell)

2014-07-18 Thread Andrey Korolyov
On Fri, Jul 18, 2014 at 6:09 PM, Michael Tokarev wrote: > From: Stefan Weil > > arbitary -> arbitrary > basicly -> basically > > Signed-off-by: Stefan Weil > Signed-off-by: Michael Tokarev > --- > hw/i386/pc_piix.c |2 +- > hw/i386/pc_q35.c |2 +

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Andreas Färber
Am 29.06.2014 11:09, schrieb Marcel Apfelbaum: > Replaced '_' with '-' to comply with QOM guidelines. > Made the conversion from HMP to QMP in vl.c > > Signed-off-by: Marcel Apfelbaum > --- > hw/core/machine.c | 8 > vl.c | 12 +++- > 2 files changed, 15 insertions

Re: [Qemu-devel] [PATCH] machine: replace underscores in machine's property names

2014-07-18 Thread Paolo Bonzini
Il 18/07/2014 16:25, Andreas Färber ha scritto: > Actually, is this really safe? By my reading, this function handles > -object as well, which in turn allows - in theory - to instantiate any > device, where some will still have underscores in their property names. > Not sure if all non-device objec

[Qemu-devel] [PATCH v2 for-2.1] po: Fix Makefile rules for in-tree builds without configuration

2014-07-18 Thread Stefan Weil
Adding 'update' to the phony targets fixes this error: $ LANG=C make -C po update make: Entering directory `/qemu/po' LINK update /qemu/po/de_DE.po: file not recognized: File format not recognized collect2: error: ld returned 1 exit status make: *** [update] Error 1 make: Leaving directory `/qe

[Qemu-devel] [PATCH v2 for-2.1] po: Update German translation

2014-07-18 Thread Stefan Weil
Line numbers changed, and some translations were missing after commit 3d914488aee3dc1bf495e461aedf8fb4e5bb2270. Update also "Show Tabs" to a more common translation, and remove some old unused lines at the end. Signed-off-by: Stefan Weil --- v2: Rebased. v1 was based not based on the official Q

[Qemu-devel] is there a limit on the number of in-flight I/O operations?

2014-07-18 Thread Chris Friesen
Hi, I've recently run up against an interesting issue where I had a number of guests running and when I started doing heavy disk I/O on a virtio disk (backed via ceph rbd) the memory consumption spiked and triggered the OOM-killer. I want to reserve some memory for I/O, but I don't know how

[Qemu-devel] [Bug 1343827] [NEW] block.c: multiwrite_merge() truncates overlapping requests

2014-07-18 Thread Slava Pestov
Public bug reported: If the list of requests passed to multiwrite_merge() contains two requests where the first is for a range of sectors that is a strict subset of the second's, the second request is truncated to end where the first starts, so the second half of the second request is lost. This

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2014-07-18 Thread Paolo Bonzini
Il 18/07/2014 16:58, Chris Friesen ha scritto: > > I've recently run up against an interesting issue where I had a number > of guests running and when I started doing heavy disk I/O on a virtio > disk (backed via ceph rbd) the memory consumption spiked and triggered > the OOM-killer. > > I want t

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2014-07-18 Thread Andrey Korolyov
On Fri, Jul 18, 2014 at 6:58 PM, Chris Friesen wrote: > Hi, > > I've recently run up against an interesting issue where I had a number of > guests running and when I started doing heavy disk I/O on a virtio disk > (backed via ceph rbd) the memory consumption spiked and triggered the > OOM-killer.

  1   2   >