* Sanidhya Kashyap (sanidhya.ii...@gmail.com) wrote:
> Signed-off-by: Sanidhya Kashyap <sanidhya.ii...@gmail.com>
> ---
> hmp-commands.hx | 16 ++++++++++++++++
> hmp.c | 16 ++++++++++++++++
> hmp.h | 1 +
> 3 files changed, 33 insertions(+)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index d0943b1..575df78 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1788,6 +1788,22 @@ STEXI
> show available trace events and their state
> ETEXI
>
> + {
> + .name = "ldb|log-dirty-bitmap",
> + .args_type = "filename:s,epochs:i?,frequency:i?",
> + .params = "filename epochs frequency",
> + .help = "dumps the memory's dirty bitmap to file\n\t\t\t"
> + "filename: name of the file in which the bitmap will be
> saved\n\t\t\t"
> + "epochs: number of times, the memory will be
> logged\n\t\t\t"
> + "frequency: time difference in milliseconds between
> each epoch",
> + .mhandler.cmd = hmp_log_dirty_bitmap,
> + },
> +STEXI
> +@item ldb or log-dirty-bitmap @var{filename}
> +@findex log-dirty-bitmap
> +dumps the writable working set of a VM's memory to a file
> +ETEXI
> +
> STEXI
> @end table
> ETEXI
> diff --git a/hmp.c b/hmp.c
> index 4d1838e..3c8e56d 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -1318,6 +1318,22 @@ void hmp_device_del(Monitor *mon, const QDict *qdict)
> hmp_handle_error(mon, &err);
> }
>
> +void hmp_log_dirty_bitmap(Monitor *mon, const QDict *qdict)
> +{
> + const char *filename = qdict_get_str(qdict, "filename");
> + int64_t epochs = qdict_get_try_int(qdict, "epochs", 3);
> + int64_t frequency = qdict_get_try_int(qdict, "frequency", 10);
> + Error *err = NULL;
> +
> + qmp_log_dirty_bitmap(filename, !!epochs, epochs, !!frequency,
> + frequency, &err);
Other hmp functions that have optional integer parameters use
qdict_haskey, e.g.
int has_hold_time = qdict_haskey(qdict, "hold-time");
int hold_time = qdict_get_try_int(qdict, "hold-time", -1);
Dave
> + if (err) {
> + monitor_printf(mon, "log-dirty-bitmap: %s\n", error_get_pretty(err));
> + error_free(err);
> + return;
> + }
> +}
> +
> void hmp_dump_guest_memory(Monitor *mon, const QDict *qdict)
> {
> Error *err = NULL;
> diff --git a/hmp.h b/hmp.h
> index 4fd3c4a..0895182 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -94,6 +94,7 @@ void hmp_cpu_add(Monitor *mon, const QDict *qdict);
> void hmp_object_add(Monitor *mon, const QDict *qdict);
> void hmp_object_del(Monitor *mon, const QDict *qdict);
> void hmp_info_memdev(Monitor *mon, const QDict *qdict);
> +void hmp_log_dirty_bitmap(Monitor *mon, const QDict *qdict);
> void object_add_completion(ReadLineState *rs, int nb_args, const char *str);
> void object_del_completion(ReadLineState *rs, int nb_args, const char *str);
> void device_add_completion(ReadLineState *rs, int nb_args, const char *str);
> --
> 1.9.3
>
--
Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
