Re: [Qemu-devel] [PATCH] qdev: fix crash by validating the object type

2014-04-16 Thread Markus Armbruster
Amos Kong writes: > QEMU crashed when I try to list device parameters, the driver name is > actually the available bus name. > > # qemu -device virtio-pci-bus,? > # qemu -device virtio-bus,? > # qemu -device virtio-serial-bus,? > qdev-monitor.c:212:qdev_device_help: Object 0x7fd932f50620 is n

Re: [Qemu-devel] [PATCH] scsi-disk: Improve error messager if can't get version number

2014-04-16 Thread Markus Armbruster
Fam Zheng writes: > More often it is that bdrv_ioctl fails due to not supported by driver or > whatever reason, in this case we should be specific, because "interface > too old" is very confusing. > > Signed-off-by: Fam Zheng > --- > hw/scsi/scsi-disk.c | 9 +++-- > 1 file changed, 7 insert

Re: [Qemu-devel] [PATCH trivial v2 0/2] vl: simplify code for main()

2014-04-16 Thread Markus Armbruster
Chen Gang writes: > In "vl.c", at least, we can simplify the code below, so can let readers > read professional C code (especially for new readers, which often start > reading code at main function). > > - Remove useless 'continue' in main(). > > - Eliminate a superfluous local variable in main

[Qemu-devel] [PATCH 3/7] megasas: add MegaRAID SAS 2108 emulation

2014-04-16 Thread Hannes Reinecke
The 2108 chip supports MSI and MSI-X, so update the emulation to support both chips. Signed-off-by: Hannes Reinecke --- hw/scsi/megasas.c| 95 ++-- hw/scsi/mfi.h| 7 include/hw/pci/pci_ids.h | 1 + 3 files changed, 91 inserti

[Qemu-devel] [PATCH 1/7] megasas: Enable MSI-X support

2014-04-16 Thread Hannes Reinecke
MSI-X support has been fixed in qemu, so we can enable it again. Signed-off-by: Hannes Reinecke --- hw/scsi/megasas.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index e6e1ffd..496bab8 100644 --- a/hw/scsi/megasa

[Qemu-devel] [PATCH 2/7] megasas: Add MSI support

2014-04-16 Thread Hannes Reinecke
Some hardware instances do support MSI, so we should do likewise. Signed-off-by: Hannes Reinecke --- hw/scsi/megasas.c | 49 +++-- trace-events | 5 - 2 files changed, 47 insertions(+), 7 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi

[Qemu-devel] [PATCH 0/7] megasas Update

2014-04-16 Thread Hannes Reinecke
Hi all, here's an update to the megasas driver. I've re-enabled MSI-X support and added a new emulation mode 'megasas-gen2' which emulates the MegaRAID SAS 2108 HBA. The advantage here is that the original silicon supports both MSI-X and MSI, so some drivers (most notably windows) will refuse to e

[Qemu-devel] [PATCH 4/7] megasas: simplify trace event messages

2014-04-16 Thread Hannes Reinecke
The trace events already contain the function name, so the actual message doesn't need to contain any of these informations. Signed-off-by: Hannes Reinecke --- trace-events | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/trace-events b/trace-event

[Qemu-devel] [PATCH 5/7] megasas: Implement LD_LIST_QUERY

2014-04-16 Thread Hannes Reinecke
New drivers implement a LD_LIST_QUERY command, and due to a driver issue no drives might be detected if this command isn't supported. So add emulation for this command, too. Signed-off-by: Hannes Reinecke --- hw/scsi/megasas.c | 17 + hw/scsi/mfi.h | 9 + trace-event

[Qemu-devel] [PATCH 6/7] megasas: Decode register names

2014-04-16 Thread Hannes Reinecke
To ease debugging we should be decoding the register names. Signed-off-by: Hannes Reinecke --- hw/scsi/megasas.c | 22 +++--- trace-events | 4 ++-- 2 files changed, 21 insertions(+), 5 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index 859b294..dafa012

[Qemu-devel] [PATCH 7/7] MAINTAINERS: mark megasas as maintained

2014-04-16 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c66946f..f1d3f09 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -651,6 +651,12 @@ S: Supported F: hw/block/nvme* F: tests/nvme-test.c +megasas +M: Hannes Rei

Re: [Qemu-devel] KVM call agenda for 2014-04-15

2014-04-16 Thread Alexander Graf
> Am 16.04.2014 um 08:26 schrieb Markus Armbruster : > > Alexander Graf writes: > >>> Am 15.04.2014 um 18:56 schrieb Markus Armbruster : >>> >>> Alexander Graf writes: >>> > On 04/15/2014 04:00 PM, Markus Armbruster wrote: > Juan Quintela writes: > >> Juan Quintela wrote:

Re: [Qemu-devel] [PATCH v1 0/3] Introduce qemu_get_boot_opts()

2014-04-16 Thread Markus Armbruster
Peter Crosthwaite writes: > Hi Markus, > > This series introduces qemu_get_boot_opts(), in much the same way as > was done for qemu_get_machine_opts(). > > As usual, I have out-of-scope and out-of-tree usages :) But P3 does > clean up the one existing instance of the long-and-awkward form of > th

Re: [Qemu-devel] QEMU 2.0 RC with Spice

2014-04-16 Thread Dr. David Alan Gilbert
* Rick Vernam (rtver...@hobi.com) wrote: > On Tuesday 15 April 2014 19:25:22 Rick Vernam wrote: > > Looks like it's in Spice: > > I'll see if I can build spice with debugging symbols and what not and write > > back with findings. Are others have problems with Qemu 2.0 RCs & Spice? > > > > Here

[Qemu-devel] [Bug 1257352] Re: kvm hangs occasionally when switching out of the qemu console

2014-04-16 Thread James Hunt
Hi Serge, I'm running on pure amd64 too so the problem is not arch-specific. The simplest way to recreate: $ kvm -cdrom /usr/lib/memtest86+/memtest86+.iso -m 512 Just hold down control+alt and frantically toggle the monitor using the '2' and '1'. Within a couple of seconds it hangs. -- You re

[Qemu-devel] [questions] host panic happened when kvm guest access the memory which was provided by host remap_pfn_range page to qemu

2014-04-16 Thread Zhang Haoyu
Hi, all I provide host's memory to guest by remap_pfn_range host page to qemu, and when guest access the page, host paniced. host code: static int my_mmap(struct file *filep, struct vm_area_struct *vma) { int ret; unsigned long page; if (vma->vm_end < vma->vm_start) return -

[Qemu-devel] [PATCH v2 0/2] HMP: support specifying dump format for dump-guest-memory

2014-04-16 Thread Qiao Nuohan
The last version is here: http://lists.nongnu.org/archive/html/qemu-devel/2014-04/msg00018.html ChangLog: Changes from v7 to v8: 1. add a patch to fix doc of dump-guest-memory Qiao Nuohan (2): HMP: fix doc of dump-guest-memory HMP: support specifying dump format for dump-guest-memory hmp-c

[Qemu-devel] [PATCH v2 1/2] HMP: fix doc of dump-guest-memory

2014-04-16 Thread Qiao Nuohan
Signed-off-by: Qiao Nuohan --- hmp-commands.hx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 0da8f28..ca5737b 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1000,10 +1000,10 @@ ETEXI .name = "dump-gu

[Qemu-devel] [PATCH v2 2/2] HMP: support specifying dump format for dump-guest-memory

2014-04-16 Thread Qiao Nuohan
Dumping guest memory is available to specify the dump format now. This patch adds options '-z|-l|-s' to HMP command dump-guest-memory to specify dumping in kdump-compression format, with zlib/lzo/snappy compression. And without these options ELF format will be used. The discussion about this featu

Re: [Qemu-devel] [PATCH 13/35] pc: initialize memory hotplug address space

2014-04-16 Thread Hu Tao
On Fri, Apr 04, 2014 at 03:36:38PM +0200, Igor Mammedov wrote: > initialize and map hotplug memory address space container > into guest's RAM address space. > > Signed-off-by: Igor Mammedov > --- > hw/i386/pc.c | 19 +-- > include/hw/i386/pc.h | 10 ++ > 2 files c

Re: [Qemu-devel] [PATCH 33/35] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-04-16 Thread Hu Tao
On Tue, Apr 15, 2014 at 05:55:22PM +0200, Igor Mammedov wrote: > On Tue, 15 Apr 2014 14:37:01 +0800 > Hu Tao wrote: > > > On Mon, Apr 14, 2014 at 06:44:42PM +0200, Igor Mammedov wrote: > > > On Mon, 14 Apr 2014 15:25:01 +0800 > > > Hu Tao wrote: > > > > > > > On Fri, Apr 04, 2014 at 03:36:58PM

[Qemu-devel] [PATCH] ivshmem: fix potential OOB r/w access

2014-04-16 Thread Sebastian Krahmer
Fix OOB access via malformed incoming_posn parameters and check that requested memory is actually alloced. Signed-off-by: Sebastian Krahmer --- diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 8d144ba..f58356e 100644 --- a/hw/misc/ivshmem.c +++ b/hw/misc/ivshmem.c @@ -28,6 +28,7 @@

[Qemu-devel] [Bug 1308381] [NEW] illegal instructions for AArch64 ARMv8

2014-04-16 Thread Hao Liu
Public bug reported: The test case is in the attachment. To reproduce as following (I tried both GCC and Clang): $aarch64-linux-gnu-gcc qemu.c -o test $./test qemu: uncaught target signal 4 (Illegal instruction) - core dumped Illegal instruction (core dumped) In the test case, 3 intrinsics are

[Qemu-devel] [Bug 1308381] Re: illegal instructions for AArch64 ARMv8

2014-04-16 Thread Hao Liu
** Description changed: The test case is in the attachment. To reproduce as following (I tried both GCC and Clang): $aarch64-linux-gnu-gcc qemu.c -o test $./test qemu: uncaught target signal 4 (Illegal instruction) - core dumped Illegal instruction (core dumped) - In the test case

[Qemu-devel] smp support in mips64

2014-04-16 Thread Maryyam Muhammad Din
I am trying to add smp support in octeon-mips by usnig QEM-1.0.1. My octeon guest is not initializing secondary cores. QEMU monitor show (qemu) info cpus * CPU #0: PC=0xc0031d04 thread_id=12661 CPU #1: PC=0xbfc00380 thread_id=12660 Can anyone have any idea about this issue? --

[Qemu-devel] [Bug 1308381] Re: illegal instructions for AArch64 ARMv8

2014-04-16 Thread Peter Maydell
Can you attach a statically linked test case binary, please? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1308381 Title: illegal instructions for AArch64 ARMv8 Status in QEMU: New Bug descript

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Eliminate Magic Number MSR Masks

2014-04-16 Thread Alexander Graf
On 15.04.14 19:21, Tom Musta wrote: Use MSR mnemonics from cpu.h instead of magic numbers for the CPUPPCState.msr_mask initialization. There is one bit in the 401x2 (and subsequent) model that I could not find any documentation for. It is open coded at little endian bit position 20: pcc

Re: [Qemu-devel] KVM call agenda for 2014-04-15

2014-04-16 Thread Alexander Graf
On 15.04.14 17:32, Eric Auger wrote: On 04/15/2014 04:55 PM, Alexander Graf wrote: On 04/15/2014 04:00 PM, Markus Armbruster wrote: Juan Quintela writes: Juan Quintela wrote: Hi Please, send any topic that you are interested in covering. Thanks, Juan. As there are no topics, no call.

Re: [Qemu-devel] [PATCH] target-ppc: Remove PVR check from migration

2014-04-16 Thread Alexander Graf
On 15.04.14 07:06, Alexey Kardashevskiy wrote: Currently migration fails if CPU version (PVR register) is different even a bit. This check is performed at the very end of migration when device states are sent. This is too late for management software and we need to provide a way for the user to

Re: [Qemu-devel] [Bug 1308381] Re: illegal instructions for AArch64ARMv88

2014-04-16 Thread Alex Bennée
Peter Maydell writes: > Can you attach a statically linked test case binary, please? I can reproduce with the source file. It looks like: @@ -7553,12 +7555,9 @@ static void disas_simd_scalar_two_reg_misc(DisasContext *s, uint32_t insn) } break; case 0x12: /* SQXTUN */ -

Re: [Qemu-devel] [Bug 1308381] Re: illegal instructions for AArch64ARMv88

2014-04-16 Thread Peter Maydell
On 16 April 2014 11:55, Alex Bennée wrote: > > Peter Maydell writes: > >> Can you attach a statically linked test case binary, please? > > I can reproduce with the source file. It looks like: > > @@ -7553,12 +7555,9 @@ static void > disas_simd_scalar_two_reg_misc(DisasContext *s, uint32_t insn)

Re: [Qemu-devel] [Bug 1308381] Re: illegal instructions for AArch64ARMv88

2014-04-16 Thread Janne Grunau
On 2014-04-16 11:59:58 +0100, Peter Maydell wrote: > On 16 April 2014 11:55, Alex Bennée wrote: > > > > Peter Maydell writes: > > > >> Can you attach a statically linked test case binary, please? > > > > I can reproduce with the source file. It looks like: > > > > @@ -7553,12 +7555,9 @@ static vo

Re: [Qemu-devel] [PATCH v6] spapr: Add support for time base offset migration

2014-04-16 Thread Alexander Graf
On 14.04.14 14:53, Alexey Kardashevskiy wrote: This allows guests to have a different timebase origin from the host. This is needed for migration, where a guest can migrate from one host to another and the two hosts might have a different timebase origin. However, the timebase seen by the guest

Re: [Qemu-devel] [PATCH 2/9] kvm: add kvm_enable_cap_{vm,vcpu}

2014-04-16 Thread Alexander Graf
On 14.04.14 18:48, Cornelia Huck wrote: Provide helper functions for enabling capabilities (on a vcpu and on a vm). Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- include/sysemu/kvm.h |4 kvm-all.c| 33 - 2 files changed, 3

Re: [Qemu-devel] [PATCH 3/9] s390x: use kvm_enable_cap_vcpu()

2014-04-16 Thread Alexander Graf
On 14.04.14 18:48, Cornelia Huck wrote: Make kvm_s390_enable_css_support() use new interface. Signed-off-by: Cornelia Huck What I was trying to indicate with the "convert users" comment last time was to convert non-s390 users :). After all, ENABLE_CAP is a cross-architecture interface and

Re: [Qemu-devel] [PATCH 4/9] s390x: Add I/O adapter registration.

2014-04-16 Thread Alexander Graf
On 14.04.14 18:48, Cornelia Huck wrote: Register an I/O adapter interrupt source for when virtio-ccw devices start using adapter interrupts. Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- hw/intc/s390_flic.c | 59 + hw/s390x/cs

[Qemu-devel] [PATCH] target-arm: A64: fix unallocated test of scalar SQXTUN

2014-04-16 Thread Alex Bennée
The test for the U bit was incorrectly inverted in the scalar case of SQXTUN. This doesn't affect the vector case as the U bit is used to select XTN(2). Reported-by: Hao Liu Signed-off-by: Alex Bennée --- target-arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [Qemu-devel] [PATCH 6/9] s390x/virtio-ccw: Wire up irq routing and irqfds.

2014-04-16 Thread Alexander Graf
On 14.04.14 18:48, Cornelia Huck wrote: Make use of the new s390 adapter irq routing support to enable real in-kernel irqfds for virtio-ccw with adapter interrupts. Note that s390 doesn't provide the common KVM_CAP_IRQCHIP capability, but rather needs KVM_CAP_S390_IRQCHIP to be enabled. This is

Re: [Qemu-devel] [PATCH 9/9] s390x/kvm: sync gbea and pp register

2014-04-16 Thread Alexander Graf
On 14.04.14 18:48, Cornelia Huck wrote: From: Christian Borntraeger We also need to sync guest breaking event address and program parameter register for migration support. Signed-off-by: Christian Borntraeger Reviewed-by: Jason J. Herne Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck

Re: [Qemu-devel] [PATCH] target-arm: A64: fix unallocated test of scalar SQXTUN

2014-04-16 Thread Claudio Fontana
On 16.04.2014 13:29, Alex Bennée wrote: > The test for the U bit was incorrectly inverted in the scalar case of SQXTUN. > This doesn't affect the vector case as the U bit is used to select XTN(2). > > Reported-by: Hao Liu > Signed-off-by: Alex Bennée > --- > target-arm/translate-a64.c | 2 +- >

Re: [Qemu-devel] [PATCH 1/1] ppc: use kvm_enable_cap_vcpu()

2014-04-16 Thread Alexander Graf
On 14.04.14 18:48, Cornelia Huck wrote: Convert existing users of KVM_ENABLE_CAP to new helper. Signed-off-by: Cornelia Huck Ah, you made the ppc patch separate. I would prefer if we had one patch set that introduces the helper and converts every arch in follow-up patches. Then your s390x

Re: [Qemu-devel] [PATCH 2/9] kvm: add kvm_enable_cap_{vm,vcpu}

2014-04-16 Thread Alexander Graf
On 16.04.2014, at 13:22, Alexander Graf wrote: > > On 14.04.14 18:48, Cornelia Huck wrote: >> Provide helper functions for enabling capabilities (on a vcpu and on a vm). >> >> Reviewed-by: Thomas Huth >> Signed-off-by: Cornelia Huck >> --- >> include/sysemu/kvm.h |4 >> kvm-all.c

[Qemu-devel] [Bug 1308381] Re: illegal instructions for AArch64 ARMv8

2014-04-16 Thread Alex Bennée
@pmaydell: yeah vector is unaffected as U is used to select another opcode. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1308381 Title: illegal instructions for AArch64 ARMv8 Status in QEMU: Ne

[Qemu-devel] [Bug 1308381] Re: illegal instructions for AArch64 ARMv8

2014-04-16 Thread Alex Bennée
Fix identified ** Changed in: qemu Assignee: (unassigned) => Alex Bennée (ajbennee) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1308381 Title: illegal instructions for AArch64 ARMv8 Status

[Qemu-devel] [Bug 1308381] Re: illegal instructions for AArch64 ARMv8

2014-04-16 Thread Alex Bennée
I've sent this patch to the mailing list but it fixes the attached test case and has been tested with risu patterns. ** Patch added: "fix" https://bugs.launchpad.net/qemu/+bug/1308381/+attachment/4085353/+files/0001-target-arm-A64-fix-unallocated-test-of-scalar-SQXTUN.patch -- You received t

Re: [Qemu-devel] [PATCH] target-arm: A64: fix unallocated test of scalar SQXTUN

2014-04-16 Thread Peter Maydell
On 16 April 2014 12:29, Alex Bennée wrote: > The test for the U bit was incorrectly inverted in the scalar case of SQXTUN. > This doesn't affect the vector case as the U bit is used to select XTN(2). > > Reported-by: Hao Liu > Signed-off-by: Alex Bennée Reviewed-by: Peter Maydell Cc: qemu-sta.

Re: [Qemu-devel] [PATCH 1/7] megasas: Enable MSI-X support

2014-04-16 Thread Alexander Graf
On 16.04.14 09:16, Hannes Reinecke wrote: MSI-X support has been fixed in qemu, so we can enable it again. Signed-off-by: Hannes Reinecke --- hw/scsi/megasas.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c ind

Re: [Qemu-devel] [PATCH 5/7] megasas: Implement LD_LIST_QUERY

2014-04-16 Thread Alexander Graf
On 16.04.14 09:17, Hannes Reinecke wrote: New drivers implement a LD_LIST_QUERY command, and due to a driver issue no drives might be detected if this command isn't supported. So add emulation for this command, too. Signed-off-by: Hannes Reinecke Should this go into stable? After all it woul

Re: [Qemu-devel] [PATCH 0/7] megasas Update

2014-04-16 Thread Alexander Graf
On 16.04.14 09:16, Hannes Reinecke wrote: Hi all, here's an update to the megasas driver. I've re-enabled MSI-X support and added a new emulation mode 'megasas-gen2' which emulates the MegaRAID SAS 2108 HBA. The advantage here is that the original silicon supports both MSI-X and MSI, so some dr

Re: [Qemu-devel] [PATCH 5/7] megasas: Implement LD_LIST_QUERY

2014-04-16 Thread Hannes Reinecke
On 04/16/2014 01:45 PM, Alexander Graf wrote: > > On 16.04.14 09:17, Hannes Reinecke wrote: >> New drivers implement a LD_LIST_QUERY command, and due to a driver >> issue no drives might be detected if this command isn't supported. >> So add emulation for this command, too. >> >> Signed-off-by: Ha

Re: [Qemu-devel] [PATCH 5/7] megasas: Implement LD_LIST_QUERY

2014-04-16 Thread Alexander Graf
On 16.04.14 13:47, Hannes Reinecke wrote: On 04/16/2014 01:45 PM, Alexander Graf wrote: On 16.04.14 09:17, Hannes Reinecke wrote: New drivers implement a LD_LIST_QUERY command, and due to a driver issue no drives might be detected if this command isn't supported. So add emulation for this comm

Re: [Qemu-devel] [PATCH 1/7] megasas: Enable MSI-X support

2014-04-16 Thread Hannes Reinecke
On 04/16/2014 01:43 PM, Alexander Graf wrote: > > On 16.04.14 09:16, Hannes Reinecke wrote: >> MSI-X support has been fixed in qemu, so we can enable it again. >> >> Signed-off-by: Hannes Reinecke >> --- >> hw/scsi/megasas.c | 20 ++-- >> 1 file changed, 6 insertions(+), 14 del

Re: [Qemu-devel] [PATCH 1/7] megasas: Enable MSI-X support

2014-04-16 Thread Alexander Graf
On 16.04.14 13:49, Hannes Reinecke wrote: On 04/16/2014 01:43 PM, Alexander Graf wrote: On 16.04.14 09:16, Hannes Reinecke wrote: MSI-X support has been fixed in qemu, so we can enable it again. Signed-off-by: Hannes Reinecke --- hw/scsi/megasas.c | 20 ++-- 1 file chang

Re: [Qemu-devel] [PATCH 2/9] kvm: add kvm_enable_cap_{vm,vcpu}

2014-04-16 Thread Cornelia Huck
On Wed, 16 Apr 2014 13:38:27 +0200 Alexander Graf wrote: > > On 16.04.2014, at 13:22, Alexander Graf wrote: > > > > > On 14.04.14 18:48, Cornelia Huck wrote: > >> Provide helper functions for enabling capabilities (on a vcpu and on a vm). > >> > >> Reviewed-by: Thomas Huth > >> Signed-off-b

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-16 Thread Michael S. Tsirkin
On Fri, Apr 11, 2014 at 11:14:00AM +0200, Igor Mammedov wrote: > On Mon, 7 Apr 2014 18:14:51 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Apr 07, 2014 at 04:32:16PM +0200, Igor Mammedov wrote: > > > On Mon, 7 Apr 2014 13:23:54 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Fri, A

Re: [Qemu-devel] QEMU 2.0 RC with Spice

2014-04-16 Thread Richard Vernam
On Apr 16, 2014 3:07 AM, "Dr. David Alan Gilbert" wrote: > > * Rick Vernam (rtver...@hobi.com) wrote: > > On Tuesday 15 April 2014 19:25:22 Rick Vernam wrote: > > > Looks like it's in Spice: > > > > > > I'll see if I can build spice with debugging symbols and what not and write > > > back with fi

Re: [Qemu-devel] [PATCH v1 2/3] memory: Add sysbus memory device

2014-04-16 Thread Alexander Graf
On 15.04.14 04:21, Peter Crosthwaite wrote: Add a sysbus device consisting of a single ram. This allows for instantiation of RAM just like any other device. There are a number of good reasons to want to do this this: 1: Consistency. RAM is not that special where board level files should have to

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-16 Thread Gerd Hoffmann
On Di, 2014-04-15 at 20:47 -0400, Kevin O'Connor wrote: > On Tue, Apr 15, 2014 at 10:29:26AM +0200, Gerd Hoffmann wrote: > > Leave the old interface code basically as-is. type0 and type1 > > individual fields are passed like they are passed today. We don't > > change to to pass full tables, and w

Re: [Qemu-devel] segfault while booting from saved snapshot

2014-04-16 Thread Kevin Wolf
Am 15.04.2014 um 16:55 hat Shehbaz Jaffer geschrieben: > Thankyou for your reply. I do not face the error using qemu.1.7.1 version. > > 1 quick question: > > I want to create a qcow2 image file after my VM has completed booting; i.e., > when I boot from this new snapshot, I should directly get to

[Qemu-devel] [PATCH 0/3] block: Improve request length checks

2014-04-16 Thread Kevin Wolf
Kevin Wolf (3): block: Fix nb_sectors check in bdrv_check_byte_request() block: Limit size to INT_MAX in bdrv_check_byte_request() block: Catch integer overflow in bdrv_rw_co() block.c| 10 +- tests/qemu-iotests/084.out | 5 + 2 files changed, 10 insertions(

[Qemu-devel] [PATCH 2/3] block: Limit size to INT_MAX in bdrv_check_byte_request()

2014-04-16 Thread Kevin Wolf
Commit 8f4754ed intended to protect against integer overflow bugs in block drivers by making sure that a single request that is passed to drivers is no longer than INT_MAX bytes. However, meanwhile there are some callers that don't use that code path any more but call bdrv_check_byte_request() dir

[Qemu-devel] [PATCH 1/3] block: Fix nb_sectors check in bdrv_check_byte_request()

2014-04-16 Thread Kevin Wolf
nb_sectors is signed, check for negative values. Signed-off-by: Kevin Wolf --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 75c3948..8be40bb 100644 --- a/block.c +++ b/block.c @@ -2609,7 +2609,7 @@ static int bdrv_check_byte_request(BlockDri

[Qemu-devel] [PATCH 3/3] block: Catch integer overflow in bdrv_rw_co()

2014-04-16 Thread Kevin Wolf
Insanely large requests could cause an integer overflow in bdrv_rw_co() while converting sectors to bytes. This patch catches the problem and returns an error (if we hadn't overflown the integer here, bdrv_check_byte_request() would have rejected the request, so we're not breaking anything that was

[Qemu-devel] [PATCH] block: Check bdrv_getlength() return value in bdrv_make_zero()

2014-04-16 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index d268ece..8510ba2 100644 --- a/block.c +++ b/block.c @@ -2757,10 +2757,16 @@ int bdrv_write_zeroes(BlockDriverState *bs, int64_t sector_num, */ int bdrv_make

Re: [Qemu-devel] [RFC v2 4/6] vfio: Add initial IRQ support in QEMU platform device

2014-04-16 Thread Eric Auger
On 04/11/2014 03:34 AM, Kim Phillips wrote: > On Wed, 9 Apr 2014 16:33:07 +0100 > Eric Auger wrote: > >> This work is inspired of PCI INTx. The code was prepared to support >> multiple IRQs but this was not tested at that stage. Similarly to what >> is done on PCI, the device register space is RA

Re: [Qemu-devel] [PATCH 3/7] megasas: add MegaRAID SAS 2108 emulation

2014-04-16 Thread Andreas Färber
Am 16.04.2014 09:16, schrieb Hannes Reinecke: > The 2108 chip supports MSI and MSI-X, so update the emulation > to support both chips. > > Signed-off-by: Hannes Reinecke > --- > hw/scsi/megasas.c| 95 > ++-- > hw/scsi/mfi.h| 7 +++

[Qemu-devel] what is the differences between file and block disk

2014-04-16 Thread longguang.yue
hi,all 1. what is the differences between file and block disk? which is better? it seems that qemu always use pread and pwrite , does not care about the type of vm's disk. am i right? thanks

Re: [Qemu-devel] [PATCH 1/7] megasas: Enable MSI-X support

2014-04-16 Thread Andreas Färber
Am 16.04.2014 09:16, schrieb Hannes Reinecke: > MSI-X support has been fixed in qemu, so we can enable it again. "QEMU" fwiw > > Signed-off-by: Hannes Reinecke We had discussed enabling MSI-X before, and what I am missing here is a change to the VMStateDescription. As long as no patches moving

Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event to ACPI device

2014-04-16 Thread Igor Mammedov
On Wed, 16 Apr 2014 15:02:40 +0300 "Michael S. Tsirkin" wrote: > On Fri, Apr 11, 2014 at 11:14:00AM +0200, Igor Mammedov wrote: > > On Mon, 7 Apr 2014 18:14:51 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Apr 07, 2014 at 04:32:16PM +0200, Igor Mammedov wrote: > > > > On Mon, 7 Apr 20

[Qemu-devel] [PATCH v2] Add remove_boot_device_path() function for hot-unplug device

2014-04-16 Thread Jun Li
Add remove_boot_device_path() function to remove bootindex when hot-unplug a device. This patch fixed virtio-blk/virtio-net/scsi-disk/scsi-generic device. So it has fixed bug1086603, ref: https://bugzilla.redhat.com/show_bug.cgi?id=1086603 Make some changes based on Andreas's good suggestion. Sig

[Qemu-devel] QEMU APIC version ID bug?

2014-04-16 Thread Neil McGill
Seems there is a bug in qemu where the APIC version is being checked as value 3. However, it should be 1. static uint32_t apic_mem_readl(void *opaque, hwaddr addr) { ... switch(index) { case 0x03: /* version */ val = 0x11 | ((APIC_LVT_NB - 1) << 16); /* version 0x11 */ br

Re: [Qemu-devel] [PATCH RFC qom-next for-next v2 6/6] pci: Move VMSTATE_MSIX() into vmstate_pci_device

2014-04-16 Thread Andreas Färber
Am 02.09.2013 13:31, schrieb Michael S. Tsirkin: > On Mon, Jul 29, 2013 at 02:27:01AM +0200, Andreas Färber wrote: >> Use it conditional on msix_present() and drop msix_{save,load}() calls >> following pci_device_{save,load}(). >> >> This reorders the msix_save() and msix_unuse_all_vectors() calls

[Qemu-devel] disk cache question and drawback of cache

2014-04-16 Thread longguang.yue
hi,all libvirt supply "default", "none", "writethrough", "writeback", "directsync", "unsafe" disk cache options 1. as for qemu, how qemu uses those options? and what are the differences? better tell me where are the codes corresponding to those options? 2. after a long time of running

Re: [Qemu-devel] [PATCH 13/35] pc: initialize memory hotplug address space

2014-04-16 Thread Igor Mammedov
On Wed, 16 Apr 2014 16:59:25 +0800 Hu Tao wrote: > On Fri, Apr 04, 2014 at 03:36:38PM +0200, Igor Mammedov wrote: > > initialize and map hotplug memory address space container > > into guest's RAM address space. > > > > Signed-off-by: Igor Mammedov > > --- > > hw/i386/pc.c | 19 +++

Re: [Qemu-devel] [PATCH 2/9] kvm: add kvm_enable_cap_{vm,vcpu}

2014-04-16 Thread Cornelia Huck
On Wed, 16 Apr 2014 13:58:31 +0200 Cornelia Huck wrote: > On Wed, 16 Apr 2014 13:38:27 +0200 > Alexander Graf wrote: > > > > > On 16.04.2014, at 13:22, Alexander Graf wrote: > > > > > > > > On 14.04.14 18:48, Cornelia Huck wrote: > > >> Provide helper functions for enabling capabilities (on

Re: [Qemu-devel] [PATCH 2/9] kvm: add kvm_enable_cap_{vm,vcpu}

2014-04-16 Thread Alexander Graf
On 16.04.14 16:25, Cornelia Huck wrote: On Wed, 16 Apr 2014 13:58:31 +0200 Cornelia Huck wrote: On Wed, 16 Apr 2014 13:38:27 +0200 Alexander Graf wrote: On 16.04.2014, at 13:22, Alexander Graf wrote: On 14.04.14 18:48, Cornelia Huck wrote: Provide helper functions for enabling capabili

Re: [Qemu-devel] [PATCH 2/9] kvm: add kvm_enable_cap_{vm,vcpu}

2014-04-16 Thread Cornelia Huck
On Wed, 16 Apr 2014 16:26:30 +0200 Alexander Graf wrote: > > On 16.04.14 16:25, Cornelia Huck wrote: > > On Wed, 16 Apr 2014 13:58:31 +0200 > > Cornelia Huck wrote: > > > >> On Wed, 16 Apr 2014 13:38:27 +0200 > >> Alexander Graf wrote: > >> > >>> On 16.04.2014, at 13:22, Alexander Graf wrote:

Re: [Qemu-devel] [Xen-devel] [PATCH 1/2] xen: fix usage of ENODATA

2014-04-16 Thread Roger Pau Monné
On 15/04/14 14:33, Egger, Christoph wrote: > On 15.04.14 10:33, Roger Pau Monne wrote: >> ENODATA doesn't exist on FreeBSD, so ENODATA errors returned by the >> hypervisor are translated to ENOENT. >> >> Also, the error code is returned in errno if the call returns -1, so >> compare the error code

Re: [Qemu-devel] [PATCH 4/9] s390x: Add I/O adapter registration.

2014-04-16 Thread Cornelia Huck
On Wed, 16 Apr 2014 13:25:49 +0200 Alexander Graf wrote: > > On 14.04.14 18:48, Cornelia Huck wrote: > > Register an I/O adapter interrupt source for when virtio-ccw devices start > > using adapter interrupts. > > > > Reviewed-by: Thomas Huth > > Signed-off-by: Cornelia Huck > > --- > > hw/i

Re: [Qemu-devel] [PATCH v4 3/6] qemu-img: Implement commit like QMP

2014-04-16 Thread Kevin Wolf
Am 12.04.2014 um 20:57 hat Max Reitz geschrieben: > qemu-img should use QMP commands whenever possible in order to ensure > feature completeness of both online and offline image operations. As > qemu-img itself has no access to QMP (since this would basically require > just everything being linked

Re: [Qemu-devel] [PATCH v4 2/6] blockjob: Introduce block_job_complete_sync()

2014-04-16 Thread Kevin Wolf
Am 12.04.2014 um 20:57 hat Max Reitz geschrieben: > Implement block_job_complete_sync() by doing the exact same thing as > block_job_cancel_sync() does, only with calling block_job_complete() > instead of block_job_cancel(). > > Signed-off-by: Max Reitz > --- > blockjob.c | 24

Re: [Qemu-devel] [PATCH 4/9] s390x: Add I/O adapter registration.

2014-04-16 Thread Alexander Graf
On 16.04.14 16:38, Cornelia Huck wrote: On Wed, 16 Apr 2014 13:25:49 +0200 Alexander Graf wrote: On 14.04.14 18:48, Cornelia Huck wrote: Register an I/O adapter interrupt source for when virtio-ccw devices start using adapter interrupts. Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huc

[Qemu-devel] [PATCH 1/7] megasas: Implement LD_LIST_QUERY

2014-04-16 Thread Hannes Reinecke
Newer firmware implement a LD_LIST_QUERY command, and due to a driver issue no drives might be detected if this command isn't supported. So add emulation for this command, too. Cc: qemu-sta...@nongnu.org Signed-off-by: Hannes Reinecke --- hw/scsi/megasas.c | 17 + hw/scsi/mfi.h

[Qemu-devel] [PATCHv2 0/7] megasas Update

2014-04-16 Thread Hannes Reinecke
Hi all, here is now the second iteration of my megasas update. Changes to the previous version: - Keep original emulation backwards-compatible by not changing defaults and keeping the original version number - Save MSIX vmstate - Reshuffle patches - Add different defaults for megasas and megasas

[Qemu-devel] [PATCH 3/7] megasas: Add MSI support

2014-04-16 Thread Hannes Reinecke
Some hardware instances do support MSI, so we should do likewise. Signed-off-by: Hannes Reinecke --- hw/scsi/megasas.c | 49 +++-- trace-events | 5 - 2 files changed, 47 insertions(+), 7 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi

[Qemu-devel] [PATCH 2/7] megasas: Enable MSI-X support

2014-04-16 Thread Hannes Reinecke
MSI-X support has been fixed in qemu, so we can enable it again. Signed-off-by: Hannes Reinecke --- hw/scsi/megasas.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index 1781525..df45286 100644 --- a/hw/scsi/megasas

Re: [Qemu-devel] [PATCH 6/9] s390x/virtio-ccw: Wire up irq routing and irqfds.

2014-04-16 Thread Cornelia Huck
On Wed, 16 Apr 2014 13:29:05 +0200 Alexander Graf wrote: > > On 14.04.14 18:48, Cornelia Huck wrote: > > Make use of the new s390 adapter irq routing support to enable real > > in-kernel irqfds for virtio-ccw with adapter interrupts. > > > > Note that s390 doesn't provide the common KVM_CAP_IRQC

[Qemu-devel] [PATCH 4/7] megasas: add MegaRAID SAS 2108 emulation

2014-04-16 Thread Hannes Reinecke
The 2108 chip supports MSI and MSI-X, so update the emulation to support both chips. Signed-off-by: Hannes Reinecke --- hw/scsi/megasas.c| 118 ++- hw/scsi/mfi.h| 7 +++ include/hw/pci/pci_ids.h | 1 + 3 files changed, 114 inser

[Qemu-devel] [PATCH 5/7] megasas: simplify trace event messages

2014-04-16 Thread Hannes Reinecke
The trace events already contain the function name, so the actual message doesn't need to contain any of these informations. Signed-off-by: Hannes Reinecke --- trace-events | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/trace-events b/trace

[Qemu-devel] [PATCH 7/7] MAINTAINERS: mark megasas as maintained

2014-04-16 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c66946f..f1d3f09 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -651,6 +651,12 @@ S: Supported F: hw/block/nvme* F: tests/nvme-test.c +megasas +M: Hannes Rei

[Qemu-devel] [PATCH 6/7] megasas: Decode register names

2014-04-16 Thread Hannes Reinecke
To ease debugging we should be decoding the register names. Signed-off-by: Hannes Reinecke --- hw/scsi/megasas.c | 22 +++--- trace-events | 4 ++-- 2 files changed, 21 insertions(+), 5 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index a5bfeba..6d60427

Re: [Qemu-devel] [PATCH V6 0/2] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-16 Thread Kevin O'Connor
On Thu, Apr 10, 2014 at 09:55:20PM +0300, Marcel Apfelbaum wrote: > If a pci-2-pci bridge supports hot-plug functionality but there are no devices > connected to it, reserve IO/mem in order to be able to attach devices > later. Do not waste space, use minimum allowed. Thanks - I have committed thi

Re: [Qemu-devel] [PATCH v4 4/6] qemu-img: Enable progress output for commit

2014-04-16 Thread Kevin Wolf
Am 12.04.2014 um 20:57 hat Max Reitz geschrieben: > Implement progress output for the commit command by querying the > progress of the block job. > > Signed-off-by: Max Reitz > --- > qemu-img-cmds.hx | 4 ++-- > qemu-img.c | 44 ++-- > qemu-img.texi

Re: [Qemu-devel] [PATCH v1 2/3] memory: Add sysbus memory device

2014-04-16 Thread Igor Mammedov
On Wed, 16 Apr 2014 14:24:18 +0200 Alexander Graf wrote: > > On 15.04.14 04:21, Peter Crosthwaite wrote: > > Add a sysbus device consisting of a single ram. This allows for > > instantiation of RAM just like any other device. There are a number > > of good reasons to want to do this this: > > >

Re: [Qemu-devel] [PATCH 1/7] megasas: Enable MSI-X support

2014-04-16 Thread Michael S. Tsirkin
On Wed, Apr 16, 2014 at 04:04:43PM +0200, Andreas Färber wrote: > Am 16.04.2014 09:16, schrieb Hannes Reinecke: > > MSI-X support has been fixed in qemu, so we can enable it again. > > "QEMU" fwiw > > > > > Signed-off-by: Hannes Reinecke > > We had discussed enabling MSI-X before, and what I a

[Qemu-devel] [PATCH v5] tcg-aarch64: Properly detect SIGSEGV writes

2014-04-16 Thread Richard Henderson
Since the kernel doesn't pass any info on the reason for the fault, disassemble the instruction to detect a store. Signed-off-by: Richard Henderson --- Rather than spam the rest of the reviewed patch series to the list, I'm just sending the update of the one patch that had issues. >From v4, Cla

Re: [Qemu-devel] [PATCH v1 1/3] qdev: Expose the qdev id string as a prop

2014-04-16 Thread Andreas Färber
Am 16.04.2014 08:42, schrieb Markus Armbruster: > Peter Crosthwaite writes: > >> On Wed, Apr 16, 2014 at 2:16 AM, Andreas Färber wrote: >>> Am 15.04.2014 04:21, schrieb Peter Crosthwaite: So clients can set the top level id string. Signed-off-by: Peter Crosthwaite >>> >>> Anthony

Re: [Qemu-devel] [PATCH v5] tcg-aarch64: Properly detect SIGSEGV writes

2014-04-16 Thread Claudio Fontana
On 16.04.2014 17:14, Richard Henderson wrote: > Since the kernel doesn't pass any info on the reason for the fault, > disassemble the instruction to detect a store. > > Signed-off-by: Richard Henderson > --- > > Rather than spam the rest of the reviewed patch series to the list, > I'm just sendi

Re: [Qemu-devel] Turning off default storage devices?

2014-04-16 Thread Andy Lutomirski
On Mon, Apr 14, 2014 at 1:15 AM, Markus Armbruster wrote: > Peter Crosthwaite writes: > >> Hi Andy, >> >> On Thu, Apr 10, 2014 at 5:55 AM, Andy Lutomirski wrote: >>> Currently, -M q35 boots linux quite a bit slower than the default >>> machine type. This seems to be because it takes a few hundr

Re: [Qemu-devel] [PATCH v5] tcg-aarch64: Properly detect SIGSEGV writes

2014-04-16 Thread Alex Bennée
Richard Henderson writes: > Since the kernel doesn't pass any info on the reason for the fault, > disassemble the instruction to detect a store. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

  1   2   3   >