Peter Crosthwaite <peter.crosthwa...@xilinx.com> writes: > Hi Markus, > > This series introduces qemu_get_boot_opts(), in much the same way as > was done for qemu_get_machine_opts(). > > As usual, I have out-of-scope and out-of-tree usages :) But P3 does > clean up the one existing instance of the long-and-awkward form of > this query and makes it consistent with an immediately surrounding > qemu_get_machine_opts().
I doubt this is worthwhile on its own as it stands. However, you missed the two uses of "boot-opts" in hw/nvram/fw_cfg.c. Since these uses are currently wrong the same way as the the uses of "machine" fixed in commit 36ad0e9 were, covering them could strengthen your case quite a bit,
