Re: [Qemu-devel] [PATCH v17 10/14] qmp: Add command 'blockdev-backup'

2014-04-08 Thread Fam Zheng
On Mon, 04/07 15:07, Eric Blake wrote: > On 03/10/2014 01:26 AM, Fam Zheng wrote: > > Similar to drive-backup, but this command uses a device id as target > > instead of creating/opening an image file. > > > > Also add blocker on target bs, since the target is also a named device > > now. > > > >

[Qemu-devel] [PULL 04/11] net: Report error when device / hub combo is not found.

2014-04-08 Thread Michael Tokarev
From: Hani Benhabiles Also convert nearby monitor_printf() call to error_report(). Signed-off-by: Hani Benhabiles Signed-off-by: Michael Tokarev --- net/net.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/net.c b/net/net.c index e3ef1e4..a4aadff 100644 --- a/ne

[Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08

2014-04-08 Thread Michael Tokarev
This is the last-minute trivial-patches tree. We're very close to release now, and here are mostly doc/comment/identation fixes which are safe even at this stage of the release process. There's also addition of the coverity model which does not affect code in any way. And there's a series of 3 p

[Qemu-devel] [PULL 09/11] configure: Remove redundant message for -Werror

2014-04-08 Thread Michael Tokarev
From: Stefan Weil The compiler flag -Werror is printed (or not printed) as any other compiler flag which is part of QEMU_CFLAGS. Therefore an extra output line for -Werror is redundant and can be removed. Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- configure |1 - 1 fil

[Qemu-devel] [PULL 03/11] configure: Fix indentation of help for --enable/disable-debug-info

2014-04-08 Thread Michael Tokarev
From: Peter Maydell The help text for the --enable-debug-info and --disable-debug-info command line options was misindented: delete the stray extra space and bring it in to line with everything else. Signed-off-by: Peter Maydell Signed-off-by: Michael Tokarev --- configure |4 ++-- 1 file

Re: [Qemu-devel] [PATCH for-2.1 v2 0/2] Generalise FIFO to more integer types

2014-04-08 Thread Markus Armbruster
Peter Crosthwaite writes: > There is a utility helper for dealing with 8 bit fifos. This should be > applicable to other integer widths as well. These two patches > generalise this FIFO to work for 16, 32 and 64 bit ints. Can you show us a user for the wider FIFOs? [...]

[Qemu-devel] [PULL 06/11] int128.h: Avoid undefined behaviours involving signed arithmetic

2014-04-08 Thread Michael Tokarev
From: Peter Maydell Add casts when we're performing arithmetic on the .hi parts of an Int128, to avoid undefined behaviour. Signed-off-by: Peter Maydell Signed-off-by: Michael Tokarev --- include/qemu/int128.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/

Re: [Qemu-devel] [PULL 01/11] vl: Report accelerator not supported for target more nicely

2014-04-08 Thread Chen Gang
Thanks, and I will/should finish the left trivial patches within this week (2014-04-13) On 04/08/2014 03:04 PM, Michael Tokarev wrote: > From: Chen Gang > > When you ask for an accelerator not supported for your target, you get > a bogus "accelerator does not exist" message: > > $ qemu-syste

[Qemu-devel] [PULL 10/11] doc: grammify "allows to"

2014-04-08 Thread Michael Tokarev
English language grammar does not allow usage of the word "allows" directly followed by an infinitive, declaring constructs like "something allows to do somestuff" un-grammatical. Often it is possible to just insert "one" between "allows" and "to" to make the construct grammatical, but usually it

Re: [Qemu-devel] [PATCH for-2.1 v2 0/2] Generalise FIFO to more integer types

2014-04-08 Thread Peter Crosthwaite
On Tue, Apr 8, 2014 at 5:14 PM, Markus Armbruster wrote: > Peter Crosthwaite writes: > >> There is a utility helper for dealing with 8 bit fifos. This should be >> applicable to other integer widths as well. These two patches >> generalise this FIFO to work for 16, 32 and 64 bit ints. > > Can you

[Qemu-devel] [PULL 05/11] hw/ide/ahci.c: Avoid shift left into sign bit

2014-04-08 Thread Michael Tokarev
From: Peter Maydell Add U suffix to avoid shifting left into the sign bit, which is undefined behaviour. Signed-off-by: Peter Maydell Signed-off-by: Michael Tokarev --- hw/ide/ahci.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index

Re: [Qemu-devel] [PATCH v17 06/14] block: Add backing_blocker in BlockDriverState

2014-04-08 Thread Fam Zheng
On Sun, 04/06 20:31, Jeff Cody wrote: > On Mon, Mar 10, 2014 at 03:26:02PM +0800, Fam Zheng wrote: > > This makes use of op_blocker and blocks all the operations except for > > commit target, on each BlockDriverState->backing_hd. > > > > The asserts for op_blocker in bdrv_swap are removed because

[Qemu-devel] [PULL 07/11] xbzrle.c: Avoid undefined behaviour with signed arithmetic

2014-04-08 Thread Michael Tokarev
From: Peter Maydell Use unsigned types for doing bitwise arithmetic in the xzbrle calculations, to avoid undefined behaviour: xbzrle.c:99:49: runtime error: left shift of 72340172838076673 by 7 places cannot be represented in type 'long' Signed-off-by: Peter Maydell Signed-off-by: Michael To

[Qemu-devel] [PULL 11/11] Fix grammar in comment

2014-04-08 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Peter Crosthwaite Signed-off-by: Michael Tokarev --- hw/i2c/smbus_eeprom.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c index 86f35c1..72c09cb 100644 --- a/hw/i2c/

Re: [Qemu-devel] [PATCH] target-arm: return more meaningful exit status

2014-04-08 Thread Peter Maydell
On 7 April 2014 22:42, Eric Botcazou wrote: > Hi, > > this partially addresses a long-standing limitation of the ARM semi-hosting > mode, whereby the only exit status of the emulator is 0, whatever the exit > status of the target executable, by mapping arguments of the SYS_EXIT syscall. > > See ht

[Qemu-devel] [PULL 08/11] scripts: add sample model file for Coverity Scan

2014-04-08 Thread Michael Tokarev
From: Paolo Bonzini This is the model file that is being used for the QEMU project's scans on scan.coverity.com. It fixed about 30 false positives (10% of the total) and exposed about 60 new memory leaks. The file is not automatically used; changes to it must be propagated to the website manual

[Qemu-devel] [PULL 01/11] vl: Report accelerator not supported for target more nicely

2014-04-08 Thread Michael Tokarev
From: Chen Gang When you ask for an accelerator not supported for your target, you get a bogus "accelerator does not exist" message: $ qemu-system-arm -machine none,accel=kvm KVM not supported for this target "kvm" accelerator does not exist. No accelerator found! Suppress it. Signed-o

[Qemu-devel] [PULL 02/11] qga: trivial fix for unclear documentation of guest-set-time

2014-04-08 Thread Michael Tokarev
From: Amos Kong We mixed the use of "guest time", "system time", "hardware time", "RTC" in documentation, it's unclear. This patch just added two remarks of RTC and replace two "guest time" by "guest's system time". Signed-off-by: Amos Kong Reviewed-by: Michal Privoznik Reviewed-by: Eric Blak

Re: [Qemu-devel] [PATCH v3 4/4] gtk: Add "Grab On Click" option

2014-04-08 Thread Michael S. Tsirkin
On Tue, Apr 08, 2014 at 08:25:34AM +0200, Gerd Hoffmann wrote: > On Mo, 2014-04-07 at 23:38 +0300, Michael S. Tsirkin wrote: > > On Mon, Apr 07, 2014 at 10:07:43AM +0200, Gerd Hoffmann wrote: > > > On Fr, 2014-04-04 at 12:41 +0200, Takashi Iwai wrote: > > > > I simply like it better, you don't? :)

Re: [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08

2014-04-08 Thread Peter Maydell
On 8 April 2014 08:04, Michael Tokarev wrote: > And there's a series of 3 patches by Peter Maydell which adds casts > to uint* in a few places. Those are also quite simple and safe, even > with quite some disagreement about whenever this is necessary to > start with -- I mean the int128 change, t

Re: [Qemu-devel] [PATCH v17 08/14] block: Support dropping active in bdrv_drop_intermediate

2014-04-08 Thread Markus Armbruster
Jeff Cody writes: > On Mon, Mar 10, 2014 at 03:26:04PM +0800, Fam Zheng wrote: >> Dropping intermediate could be useful both for commit and stream, and >> BDS refcnt plus bdrv_swap could do most of the job nicely. It also needs >> to work with op blockers. >> >> Signed-off-by: Fam Zheng >> ---

Re: [Qemu-devel] [PATCH] target-arm: return more meaningful exit status

2014-04-08 Thread Eric Botcazou
> Since you've found that, can you provide your answer to the objection > raised back then, that this is not permitted by the semihosting API > which we are implementing here? I don't understand the question: what is not permitted exactly? -- Eric Botcazou

Re: [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08

2014-04-08 Thread Michael Tokarev
08.04.2014 12:10, Peter Maydell wrote: > On 8 April 2014 08:04, Michael Tokarev wrote: >> And there's a series of 3 patches by Peter Maydell which adds casts >> to uint* in a few places. Those are also quite simple and safe, even >> with quite some disagreement about whenever this is necessary to

Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached

2014-04-08 Thread Michael S. Tsirkin
On Tue, Apr 08, 2014 at 08:05:23AM +0200, Gerd Hoffmann wrote: > On Mo, 2014-04-07 at 16:34 +0300, Michael S. Tsirkin wrote: > > On Mon, Apr 07, 2014 at 02:44:06PM +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > +u8 shpc_cap = pci_find_capability(s->bus_dev, > > > > > PCI_CAP_ID_S

Re: [Qemu-devel] [PATCH v3 4/4] gtk: Add "Grab On Click" option

2014-04-08 Thread Michael S. Tsirkin
On Tue, Apr 08, 2014 at 10:49:57AM +0200, Gerd Hoffmann wrote: > On Di, 2014-04-08 at 11:11 +0300, Michael S. Tsirkin wrote: > > On Tue, Apr 08, 2014 at 08:25:34AM +0200, Gerd Hoffmann wrote: > > > On Mo, 2014-04-07 at 23:38 +0300, Michael S. Tsirkin wrote: > > > > On Mon, Apr 07, 2014 at 10:07:43A

Re: [Qemu-devel] [PATCH v3 4/4] gtk: Add "Grab On Click" option

2014-04-08 Thread Gerd Hoffmann
On Di, 2014-04-08 at 11:11 +0300, Michael S. Tsirkin wrote: > On Tue, Apr 08, 2014 at 08:25:34AM +0200, Gerd Hoffmann wrote: > > On Mo, 2014-04-07 at 23:38 +0300, Michael S. Tsirkin wrote: > > > On Mon, Apr 07, 2014 at 10:07:43AM +0200, Gerd Hoffmann wrote: > > > > On Fr, 2014-04-04 at 12:41 +0200,

Re: [Qemu-devel] [PATCH 27/26] tcg-aarch64: Introduce tcg_out_insn_3312, _3310, _3313

2014-04-08 Thread Claudio Fontana
On 07.04.2014 20:34, Richard Henderson wrote: > Merge TCGMemOp size, AArch64LdstType type and a few stray opcode bits > into a single I3312_* argument, eliminating some magic numbers from > helper functions. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 129 > +

Re: [Qemu-devel] [PATCH v17 08/14] block: Support dropping active in bdrv_drop_intermediate

2014-04-08 Thread Fam Zheng
On Tue, 04/08 10:15, Markus Armbruster wrote: > Jeff Cody writes: > > > On Mon, Mar 10, 2014 at 03:26:04PM +0800, Fam Zheng wrote: > >> Dropping intermediate could be useful both for commit and stream, and > >> BDS refcnt plus bdrv_swap could do most of the job nicely. It also needs > >> to work

Re: [Qemu-devel] [PATCH for-2.1 v2 0/2] Generalise FIFO to more integer types

2014-04-08 Thread Markus Armbruster
Peter Crosthwaite writes: > On Tue, Apr 8, 2014 at 5:14 PM, Markus Armbruster wrote: >> Peter Crosthwaite writes: >> >>> There is a utility helper for dealing with 8 bit fifos. This should be >>> applicable to other integer widths as well. These two patches >>> generalise this FIFO to work for

Re: [Qemu-devel] [PATCH v6] spapr_hcall: add address-translation-mode-on-interrupt resource in H_SET_MODE

2014-04-08 Thread Alexander Graf
On 22.03.14 14:03, Alexey Kardashevskiy wrote: This adds handling of the RESOURCE_ADDR_TRANS_MODE resource from the H_SET_MODE, for POWER8 (PowerISA 2.07) only. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Mike Day Unfortunately I'm lacking a specification to verify this patch against,

Re: [Qemu-devel] [PATCH v3 4/4] gtk: Add "Grab On Click" option

2014-04-08 Thread Takashi Iwai
At Tue, 8 Apr 2014 11:57:19 +0300, Michael S. Tsirkin wrote: > > On Tue, Apr 08, 2014 at 10:49:57AM +0200, Gerd Hoffmann wrote: > > On Di, 2014-04-08 at 11:11 +0300, Michael S. Tsirkin wrote: > > > On Tue, Apr 08, 2014 at 08:25:34AM +0200, Gerd Hoffmann wrote: > > > > On Mo, 2014-04-07 at 23:38 +0

[Qemu-devel] [PATCH] gtk: Implement grab-on-click behavior in relative mode

2014-04-08 Thread Takashi Iwai
This patch changes the behavior in the relative mode to be compatible with other UIs, namely, grabbing the input at the first left click. It improves the usability a lot; otherwise you have to press ctl-alt-G or select from menu at each time you want to move the pointer. Also, the input grab is cl

Re: [Qemu-devel] [PATCH v6] spapr_hcall: add address-translation-mode-on-interrupt resource in H_SET_MODE

2014-04-08 Thread Alexander Graf
On 22.03.14 14:03, Alexey Kardashevskiy wrote: This adds handling of the RESOURCE_ADDR_TRANS_MODE resource from the H_SET_MODE, for POWER8 (PowerISA 2.07) only. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Mike Day ... but I can comment on style issues regardless for now ;) --- Change

[Qemu-devel] [PULL 2.0 03/15] softfloat: Introduce float32_to_uint64_round_to_zero

2014-04-08 Thread Alexander Graf
From: Tom Musta This change adds the float32_to_uint64_round_to_zero function to the softfloat library. This function fills out the complement of float32 to INT round-to-zero conversion rountines, where INT is {int32_t, uint32_t, int64_t, uint64_t}. This contribution can be licensed under eithe

[Qemu-devel] [PULL 2.0 13/15] PPC: Only enter MSR_POW when no interrupts pending

2014-04-08 Thread Alexander Graf
We were entering the power saving state even when interrupts (like an external interrupt or a decrementer interrupt) were still in flight. In case we find a pending interrupt, don't enter power saving state. Signed-off-by: Alexander Graf Reviewed-by: Tom Musta --- target-ppc/helper_regs.h | 2

[Qemu-devel] [PULL 2.0 09/15] target-ppc: Correct VSX FP to FP Conversions

2014-04-08 Thread Alexander Graf
From: Tom Musta This change corrects the VSX double precision to single precision and single precision to double precisions conversion routines. The endian correct accessors are now used. The auxiliary "j" index is no longer necessary and is eliminated. Signed-off-by: Tom Musta Tested-by: Tom

[Qemu-devel] [PULL 2.0 01/15] PPC: E500: Set PIR default reset value rather than SPR value

2014-04-08 Thread Alexander Graf
We now reset SPRs to their reset values on CPU reset. So if we want to have an SPR persistently changed, we need to change its default reset value rather than the value itself manually. Do this for SPR_BOOKE_PIR, fixing e500v2 SMP boot. Reported-by: Frederic Konrad Signed-off-by: Alexander Graf

[Qemu-devel] [PULL 2.0 10/15] target-ppc: Correct VSX FP to Integer Conversion

2014-04-08 Thread Alexander Graf
From: Tom Musta This patch corrects the VSX floating point to integer conversion instructions by using the endian correct accessors. The auxiliary "j" index used by the existing macros is now obsolete and is removed. Signed-off-by: Tom Musta Tested-by: Tom Musta Signed-off-by: Alexander Graf

[Qemu-devel] [PULL 2.0 14/15] ppce500_spin: Initialize struct properly

2014-04-08 Thread Alexander Graf
The spinning struct is in guest endianness, so we need to initialize its variables in guest endianness too. This fixes booting e500 guests with SMP on x86 for me. Signed-off-by: Alexander Graf --- hw/ppc/ppce500_spin.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw

[Qemu-devel] [PULL 2.0 12/15] PPC: Clean up DECR implementation

2014-04-08 Thread Alexander Graf
There are 3 different variants of the decrementor for BookE and BookS. The BookE variant sets TSR[DIS] to 1 when the DEC value becomes 1 or 0. TSR[DIS] is then the indicator whether the decrementor interrupt line is asserted or not. The old BookS variant treats DEC as an edge interrupt that gets

Re: [Qemu-devel] [PATCH] target-arm: return more meaningful exit status

2014-04-08 Thread Peter Maydell
On 8 April 2014 09:34, Eric Botcazou wrote: >> Since you've found that, can you provide your answer to the objection >> raised back then, that this is not permitted by the semihosting API >> which we are implementing here? > > I don't understand the question: what is not permitted exactly? The re

Re: [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08

2014-04-08 Thread Peter Maydell
On 8 April 2014 09:52, Michael Tokarev wrote: > Well. At least one of them is entirely safe (hw/ide/ahci.c). > Another - xbzrle.c - looks okay, and even maybe fixing a bug. > And this int128 thing is okay too, except that the whole thing > is questionable as has been mentioned in that thread. > >

Re: [Qemu-devel] [RFC PATCH] target-ppc: enable migration within the same CPU family

2014-04-08 Thread Michael Mueller
On Tue, 08 Apr 2014 11:23:14 +1000 Alexey Kardashevskiy wrote: > On 04/08/2014 04:53 AM, Andreas Färber wrote: > > Am 07.04.2014 05:27, schrieb Alexey Kardashevskiy: > >> On 04/04/2014 11:28 PM, Alexander Graf wrote: > >>> On 04/04/2014 07:17 AM, Alexey Kardashevskiy wrote: > On 03/24/2014 0

[Qemu-devel] [PULL 2.0 00/15] ppc patch queue 2014-04-08 for 2.0

2014-04-08 Thread Alexander Graf
Hi Peter, This is my last 2.0 queue for ppc. Please pull. Alex The following changes since commit 55519a4b244e4822774b593e36647ecf7598286b: Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-2.0' into staging (2014-04-07 17:57:23 +0100) are available in the git repository

Re: [Qemu-devel] [PATCH] target-arm: return more meaningful exit status

2014-04-08 Thread Eric Botcazou
> The reason we only exit with zero here is because the > semihosting API doesn't provide a way for the application > to report a non-zero exit code. In this case you're > distinguishing "application exit" from the other > failure reasons, which seems OK, though. I'm just > wary of patches trying t

Re: [Qemu-devel] [PULL for-2.0 0/2] qemu-ga w32 build fixes

2014-04-08 Thread Peter Maydell
On 7 April 2014 21:21, Michael Roth wrote: > Hi Peter, > > Please pull the following 2 patches, which fix a w32 build regression for > qemu-ga that was introduced during 2.0 development cycle. > > The following changes since commit 55519a4b244e4822774b593e36647ecf7598286b: > > Merge remote-track

Re: [Qemu-devel] [RFC PATCH] target-ppc: enable migration within the same CPU family

2014-04-08 Thread Alexey Kardashevskiy
On 04/08/2014 07:47 PM, Michael Mueller wrote: > On Tue, 08 Apr 2014 11:23:14 +1000 > Alexey Kardashevskiy wrote: > >> On 04/08/2014 04:53 AM, Andreas Färber wrote: >>> Am 07.04.2014 05:27, schrieb Alexey Kardashevskiy: On 04/04/2014 11:28 PM, Alexander Graf wrote: > On 04/04/2014 07:17

[Qemu-devel] [PULL 2.0 15/15] PPC: Add l1 cache sizes for 970 and above systems

2014-04-08 Thread Alexander Graf
Book3s_64 guests expect the L1 cache size in device tree, so let's give them proper values for all CPU types we support. This fixes a "not compliant" warning with sles11 guests on -M pseries for me. Signed-off-by: Alexander Graf --- target-ppc/translate_init.c | 8 1 file changed, 8 in

[Qemu-devel] [PULL 2.0 08/15] target-ppc: Correct VSX Scalar Compares

2014-04-08 Thread Alexander Graf
From: Tom Musta This change fixes the VSX scalar compare instructions. The existing usage of "x.f64[0]" is changed to "x.VsrD(0)". Signed-off-by: Tom Musta Tested-by: Tom Musta Signed-off-by: Alexander Graf --- target-ppc/fpu_helper.c | 13 +++-- 1 file changed, 7 insertions(+), 6

[Qemu-devel] [PULL 2.0 05/15] target-ppc: Define Endian-Correct Accessors for VSR Field Access

2014-04-08 Thread Alexander Graf
From: Tom Musta This change defines accessors for VSR doubleword and word fields that are correct from a host Endian perspective. This allows code to use the Power ISA indexing numbers in code. For example, the xscvdpsxws instruction has a target VSR that looks like this: 0 32

[Qemu-devel] [PULL 2.0 04/15] target-ppc: Bug: VSX Convert to Integer Should Truncate

2014-04-08 Thread Alexander Graf
From: Tom Musta The various VSX Convert to Integer instructions should truncate the floating point number to an integer value, which is equivalent to a round-to-zero rounding mode. The existing VSX floating point to integer conversion helpers are erroneously using the rounding mode set int the P

[Qemu-devel] [PULL 2.0 11/15] target-ppc: Correct VSX Integer to FP Conversion

2014-04-08 Thread Alexander Graf
From: Tom Musta This patch corrects the VSX integer to floating point conversion instructions by using the endian correct accessors. The auxiliary "j" index used by the existing macros is now obsolete and is removed. The JOFFSET preprocessor macro is also obsolete and removed. Signed-off-by: T

Re: [Qemu-devel] [RFC PATCH] target-ppc: enable migration within the same CPU family

2014-04-08 Thread Michael Mueller
On Tue, 08 Apr 2014 20:04:42 +1000 Alexey Kardashevskiy wrote: > On 04/08/2014 07:47 PM, Michael Mueller wrote: > > On Tue, 08 Apr 2014 11:23:14 +1000 > > Alexey Kardashevskiy wrote: > > > >> On 04/08/2014 04:53 AM, Andreas Färber wrote: > >>> Am 07.04.2014 05:27, schrieb Alexey Kardashevskiy:

[Qemu-devel] [PULL 2.0 06/15] target-ppc: Correct LE Host Inversion of Lower VSRs

2014-04-08 Thread Alexander Graf
From: Tom Musta This change properly orders the doublewords of the VSRs 0-31. Because these registers are constructed from separate doublewords, they must be inverted on Little Endian hosts. The inversion is performed both when the VSR is read and when it is written. Signed-off-by: Tom Musta

[Qemu-devel] [PULL 2.0 07/15] target-ppc: Correct Simple VSR LE Host Inversions

2014-04-08 Thread Alexander Graf
From: Tom Musta A common pattern in the VSX helper code macros is the use of "x.fld[i]" where "x" is a VSR and "fld" is an argument to a macro ("f64" or "f32" is passed). This is not always correct on LE hosts. This change addresses all instances of this pattern to be "x.fld" where "fld" is:

Re: [Qemu-devel] [PULL 2.0 00/15] ppc patch queue 2014-04-08 for 2.0

2014-04-08 Thread Peter Maydell
On 8 April 2014 10:31, Alexander Graf wrote: > Hi Peter, > > This is my last 2.0 queue for ppc. Please pull. Applied, thanks. -- PMM

[Qemu-devel] [PATCH] gtk: clarify grab menu item text

2014-04-08 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index c85aea3..7a7e432 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1432,10 +1432,12 @@ static GtkWidget *gd_create_menu_view(GtkDisplayState *s, GtkAccelGroup *acc

Re: [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08

2014-04-08 Thread Markus Armbruster
Peter Maydell writes: > On 8 April 2014 09:52, Michael Tokarev wrote: >> Well. At least one of them is entirely safe (hw/ide/ahci.c). >> Another - xbzrle.c - looks okay, and even maybe fixing a bug. >> And this int128 thing is okay too, except that the whole thing >> is questionable as has been

Re: [Qemu-devel] [PATCH 3/4] qemu-img: Implement commit like QMP

2014-04-08 Thread Max Reitz
On 08.04.2014 08:49, Markus Armbruster wrote: Max Reitz writes: On 07.04.2014 21:10, Eric Blake wrote: On 04/07/2014 11:29 AM, Max Reitz wrote: qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. As qemu-img

Re: [Qemu-devel] [RFC PATCH] target-ppc: enable migration within the same CPU family

2014-04-08 Thread Alexey Kardashevskiy
On 04/08/2014 08:32 PM, Michael Mueller wrote: > On Tue, 08 Apr 2014 20:04:42 +1000 > Alexey Kardashevskiy wrote: > >> On 04/08/2014 07:47 PM, Michael Mueller wrote: >>> On Tue, 08 Apr 2014 11:23:14 +1000 >>> Alexey Kardashevskiy wrote: >>> On 04/08/2014 04:53 AM, Andreas Färber wrote:

Re: [Qemu-devel] [PULL for-2.0 00/11] Trivial patches for 2014-04-08

2014-04-08 Thread Michael Tokarev
08.04.2014 14:57, Markus Armbruster wrote: > Peter Maydell writes: > >> On 8 April 2014 09:52, Michael Tokarev wrote: >>> Well. At least one of them is entirely safe (hw/ide/ahci.c). >>> Another - xbzrle.c - looks okay, and even maybe fixing a bug. >>> And this int128 thing is okay too, except

[Qemu-devel] [PATCH trivial 0/3] vl: simplify code for main() and get_boot_device()

2014-04-08 Thread Chen Gang
In "vl.c", at least, we can simplify the code below, so can let readers read professional C code (especially for new readers, which often start reading code at main function). - remove useless 'continue' in main(). - remove redundant local variable 'res' in get_boot_device(). - remove local v

[Qemu-devel] [PATCH trivial 1/3] vl: remove useless 'continue'

2014-04-08 Thread Chen Gang
Normal "if (...) {...} else {...}" is enough in "while(...) {...}", not need additional useless 'continue'. Signed-off-by: Chen Gang --- vl.c |1 - 1 file changed, 1 deletion(-) diff --git a/vl.c b/vl.c index 9975e5a..7505002 100644 --- a/vl.c +++ b/vl.c @@ -3034,7 +3034,6 @@ int main(int a

[Qemu-devel] [PATCH trivial 2/3] vl: remove redundant local variable 'res'

2014-04-08 Thread Chen Gang
In function, if no additional resources to free before quit, commonly, need not use additional local variable 'res' to notice about it. So remove it to simplify code. Signed-off-by: Chen Gang --- vl.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/vl.c b/vl.c index

[Qemu-devel] [PATCH trivial 3/3] vl: remove local variable 'args' in the middle of code block

2014-04-08 Thread Chen Gang
For C code, it does not recommend to define a local variable in the middle of code block without "{...}". The original author may want to zero members not mentioned in structure assignment. So recommend to use structure initializing block "{...}" for structure assignment in the middle of code bloc

[Qemu-devel] [PULL for-2.0 0/1] gtk: one more usability fix

2014-04-08 Thread Gerd Hoffmann
Hi, Finally sorted things, with this patch the gtk ui behavior in relative mouse mode is consistent with everybody else (sdl, virt-viewer, ...). please pull, Gerd The following changes since commit 55519a4b244e4822774b593e36647ecf7598286b: Merge remote-tracking branch 'remotes/afaerber/ta

[Qemu-devel] [PULL 1/1] gtk: Implement grab-on-click behavior in relative mode

2014-04-08 Thread Gerd Hoffmann
From: Takashi Iwai This patch changes the behavior in the relative mode to be compatible with other UIs, namely, grabbing the input at the first left click. It improves the usability a lot; otherwise you have to press ctl-alt-G or select from menu at each time you want to move the pointer. Also,

Re: [Qemu-devel] [RFC PATCH] target-ppc: enable migration within the same CPU family

2014-04-08 Thread Michael Mueller
On Tue, 08 Apr 2014 21:47:39 +1000 Alexey Kardashevskiy wrote: > On 04/08/2014 08:32 PM, Michael Mueller wrote: > > On Tue, 08 Apr 2014 20:04:42 +1000 > > Alexey Kardashevskiy wrote: > > > >> On 04/08/2014 07:47 PM, Michael Mueller wrote: > >>> On Tue, 08 Apr 2014 11:23:14 +1000 > >>> Alexey Ka

[Qemu-devel] [PULL for-2.0] acpi bug fix

2014-04-08 Thread Michael S. Tsirkin
The following changes since commit 55519a4b244e4822774b593e36647ecf7598286b: Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-2.0' into staging (2014-04-07 17:57:23 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for

[Qemu-devel] [PULL for-2.0] dsdt: tweak ACPI ID for hotplug resource device

2014-04-08 Thread Michael S. Tsirkin
ACPI0004 seems too new: Windows XP complains about an unrecognized device. This is a regression since 1.7. Use PNP0A06 instead - Generic Container Device. Signed-off-by: Michael S. Tsirkin Reviewed-By: Igor Mammedov --- hw/i386/acpi-dsdt-cpu-hotplug.dsl | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH] gtk: Keep the pointer within window during input grab

2014-04-08 Thread Takashi Iwai
The current code shows annoying behavior where the X pointer can move out of the window during the input grab in the absolute mode. Due to this, the pointer in qemu window looks as if frozen until the real (invisible) X pointer comes back to the window again. For avoiding such an unexpected lag,

[Qemu-devel] [PATCH v2 1/6] block-commit: Expose granularity

2014-04-08 Thread Max Reitz
Allow QMP users to manipulate the granularity used in the block-commit command. Signed-off-by: Max Reitz --- block/commit.c| 16 +--- block/mirror.c| 4 ++-- blockdev.c| 23 +-- include/block/block_int.h | 6 -- qapi-s

[Qemu-devel] [PATCH v2 0/6] qemu-img: Implement commit like QMP

2014-04-08 Thread Max Reitz
qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. For the "commit" command, this is relatively easy, so implement it first (in the hope that indeed others will follow). As qemu-img does not have access to QMP (du

[Qemu-devel] [PATCH v2 2/6] block-commit: speed is an optional parameter

2014-04-08 Thread Max Reitz
As speed is an optional parameter for the QMP block-commit command, it should be set to 0 if not given (as it is undefined if has_speed is false), that is, the speed should not be limited. Signed-off-by: Max Reitz --- blockdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/blockdev.c b

[Qemu-devel] [PATCH v2 3/6] qemu-img: Implement commit like QMP

2014-04-08 Thread Max Reitz
qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. As qemu-img itself has no access to QMP (since this would basically require just everything being linked into qemu-img), imitate QMP's implementation of block-comm

[Qemu-devel] [PATCH v2 4/6] qemu-img: Enable progress output for commit

2014-04-08 Thread Max Reitz
Implement progress output for the commit command by querying the progress of the block job. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 33 +++-- qemu-img.texi| 2 +- 3 files changed, 34 insertions(+), 5 de

[Qemu-devel] [PATCH v2 5/6] qemu-img: Specify backing file for commit

2014-04-08 Thread Max Reitz
Introduce a new parameter for qemu-img commit which may be used to explicitly specify the backing file unto which an image should be committed if the backing chain has more than a single layer. Signed-off-by: Max Reitz --- qemu-img-cmds.hx | 4 ++-- qemu-img.c | 22 +++---

Re: [Qemu-devel] [PULL for-2.0 0/1] gtk: one more usability fix

2014-04-08 Thread Peter Maydell
On 8 April 2014 13:06, Gerd Hoffmann wrote: > Hi, > > Finally sorted things, with this patch the gtk ui behavior > in relative mouse mode is consistent with everybody else > (sdl, virt-viewer, ...). > > please pull, > Gerd > > The following changes since commit 55519a4b244e4822774b593e36647ecf

Re: [Qemu-devel] [PATCH v2 07/12] block/json: Add bdrv_co_get_block_status()

2014-04-08 Thread Max Reitz
On 07.03.2014 23:55, Max Reitz wrote: Implement this function in the same way as raw_bsd does: Acknowledge that this is a passthrough driver (always return BDRV_BLOCK_OFFSET_VALID and BDRV_BLOCK_DATA and derive the offset directly from the sector index) and add BDRV_BLOCK_RAW to the returned valu

Re: [Qemu-devel] [PULL for-2.0] acpi bug fix

2014-04-08 Thread Peter Maydell
On 8 April 2014 13:24, Michael S. Tsirkin wrote: > The following changes since commit 55519a4b244e4822774b593e36647ecf7598286b: > > Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-2.0' > into staging (2014-04-07 17:57:23 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] E820 (Re: [v4 PATCH 00/12] SMBIOS: build full tables in QEMU)

2014-04-08 Thread Gabriel L. Somlo
On Mon, Apr 07, 2014 at 02:57:08PM -0400, Kevin O'Connor wrote: > On Mon, Apr 07, 2014 at 02:05:21PM -0400, Gabriel L. Somlo wrote: > > On Mon, Apr 07, 2014 at 11:23:44AM -0400, Kevin O'Connor wrote: > > > So, I'm suggesting QEMU produce two new fw_cfg files: an anchor file > > > with the valid anc

Re: [Qemu-devel] [PATCH 1/2] pci-assign: Fix a bug when map MSI-X table memory failed

2014-04-08 Thread Gonglei (Arei)
Hi, mst and alex. Ping... These two bug fix can be accepted for KVM pci-assign ? Thanks. BTW, I have finished the testing work of the Emulex Corporation OneConnect NIC (Lancer) Nic by vfio-pci, and the pass-troughed VF works well. My environment of testing as follows: Host: 3.12.16-0.6.6-defa

[Qemu-devel] [PATCH v4 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-04-08 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Make qemu_peek_buffer repeatedly call fill_buffer until it gets all the data it requires, or until there is an error. At the moment, qemu_peek_buffer will try one qemu_fill_buffer if there isn't enough data waiting, however the kernel is entitled to return ju

Re: [Qemu-devel] [PULL for-2.0 2/7] raven: Implement non-contiguous I/O region

2014-04-08 Thread Peter Maydell
On 7 April 2014 20:31, Paolo Bonzini wrote: > I think if you are using address_space_read/write > then you must use DEVICE_NATIVE_ENDIAN I think it's actually worse than that. address_space_read/write have an API which requires you to pass them a buffer which is in guest CPU endianness. This mean

Re: [Qemu-devel] [RFC PATCH] target-ppc: enable migration within the same CPU family

2014-04-08 Thread Alexander Graf
On 04/08/2014 02:19 PM, Michael Mueller wrote: On Tue, 08 Apr 2014 21:47:39 +1000 Alexey Kardashevskiy wrote: On 04/08/2014 08:32 PM, Michael Mueller wrote: On Tue, 08 Apr 2014 20:04:42 +1000 Alexey Kardashevskiy wrote: On 04/08/2014 07:47 PM, Michael Mueller wrote: On Tue, 08 Apr 2014 11

Re: [Qemu-devel] [PATCH v2 2/6] block-commit: speed is an optional parameter

2014-04-08 Thread Kevin Wolf
Am 08.04.2014 um 14:50 hat Max Reitz geschrieben: > As speed is an optional parameter for the QMP block-commit command, it > should be set to 0 if not given (as it is undefined if has_speed is > false), that is, the speed should not be limited. > > Signed-off-by: Max Reitz Should this be Cc: qem

Re: [Qemu-devel] [PATCH v2 1/6] block-commit: Expose granularity

2014-04-08 Thread Kevin Wolf
Am 08.04.2014 um 14:50 hat Max Reitz geschrieben: > Allow QMP users to manipulate the granularity used in the block-commit > command. > > Signed-off-by: Max Reitz Granularity is a strange name for live commit, especially on non-active layers where it's really just the buffer size. Not that I hav

Re: [Qemu-devel] [PATCH v2 3/6] qemu-img: Implement commit like QMP

2014-04-08 Thread Kevin Wolf
Am 08.04.2014 um 14:50 hat Max Reitz geschrieben: > qemu-img should use QMP commands whenever possible in order to ensure > feature completeness of both online and offline image operations. As > qemu-img itself has no access to QMP (since this would basically require > just everything being linked

Re: [Qemu-devel] [PATCH 1/2] pci-assign: Fix a bug when map MSI-X table memory failed

2014-04-08 Thread Michael S. Tsirkin
On Thu, Apr 03, 2014 at 01:18:23PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > when map MSI-X table memory failed, the dev->msix_table not be > set to NULL, the assigned_dev_unregister_msix_mmio() will case > a segfault when munmap the failed dev->msix_table. > > Signed-off-by: Gon

Re: [Qemu-devel] [PATCH 2/2] pci-assign: Fix memory out of bound when MSI-X table not fit in a single page

2014-04-08 Thread Michael S. Tsirkin
On Thu, Apr 03, 2014 at 01:18:24PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > QEMU only mmap MSIX_PAGE_SIZE memory for all pci devices in > assigned_dev_register_msix_mmio(), meanwhile the set the one > page memmory to zero, so the rest memory will be random value > (maybe etnry.da

Re: [Qemu-devel] [PATCH v2 4/6] qemu-img: Enable progress output for commit

2014-04-08 Thread Kevin Wolf
Am 08.04.2014 um 14:50 hat Max Reitz geschrieben: > Implement progress output for the commit command by querying the > progress of the block job. > > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > qemu-img-cmds.hx | 4 ++-- > qemu-img.c | 33 +++--

[Qemu-devel] [PATCH for-2.0] hw/pci-host/prep: Don't reverse IO accesses on bigendian hosts

2014-04-08 Thread Peter Maydell
The raven_io_read() and raven_io_write() functions pass and return values in little-endian format (since the IO op struct is marked DEVICE_LITTLE_ENDIAN); however they were storing the values in the buffer to pass to address_space_read/write() in host-endian order, which meant that on big-endian ho

Re: [Qemu-devel] [PATCH v4 1/1] Make qemu_peek_buffer loop until it gets it's data

2014-04-08 Thread Dr. David Alan Gilbert
* (chenliang0...@icloud.com) wrote: > > ?? 2014??4??810:29??Dr. David Alan Gilbert (git) > ?? > > > From: "Dr. David Alan Gilbert" > > > > Make qemu_peek_buffer repeatedly call fill_buffer until it gets > > all the data it requires, or until there is an error. > > > > At th

Re: [Qemu-devel] [PATCH v2 1/6] block-commit: Expose granularity

2014-04-08 Thread Eric Blake
On 04/08/2014 06:50 AM, Max Reitz wrote: > Allow QMP users to manipulate the granularity used in the block-commit > command. > > Signed-off-by: Max Reitz > --- > +++ b/include/block/block_int.h > @@ -426,6 +426,7 @@ void stream_start(BlockDriverState *bs, BlockDriverState > *base, > * @top:

Re: [Qemu-devel] [PATCH v2 2/6] block-commit: speed is an optional parameter

2014-04-08 Thread Eric Blake
On 04/08/2014 06:50 AM, Max Reitz wrote: > As speed is an optional parameter for the QMP block-commit command, it > should be set to 0 if not given (as it is undefined if has_speed is > false), that is, the speed should not be limited. > > Signed-off-by: Max Reitz > --- > blockdev.c | 3 +++ > 1

Re: [Qemu-devel] [PATCH v2 3/6] qemu-img: Implement commit like QMP

2014-04-08 Thread Eric Blake
On 04/08/2014 09:14 AM, Kevin Wolf wrote: > Am 08.04.2014 um 14:50 hat Max Reitz geschrieben: >> qemu-img should use QMP commands whenever possible in order to ensure >> feature completeness of both online and offline image operations. As >> qemu-img itself has no access to QMP (since this would ba

Re: [Qemu-devel] [libvirt] [PATCH] qemu: Adjust size for qcow2/qed if not on sector boundary

2014-04-08 Thread Eric Blake
On 04/08/2014 10:26 AM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1002813 > > If qemuDomainBlockResize() is passed a size not on a KiB boundary - that > is passed a size based in bytes (VIR_DOMAIN_BLOCK_RESIZE_BYTES), then > depending on the source format (qcow2 or qed), the

Re: [Qemu-devel] [PATCH v2 4/6] qemu-img: Enable progress output for commit

2014-04-08 Thread Eric Blake
On 04/08/2014 09:34 AM, Kevin Wolf wrote: > Am 08.04.2014 um 14:50 hat Max Reitz geschrieben: >> Implement progress output for the commit command by querying the >> progress of the block job. >> >> Signed-off-by: Max Reitz >> Reviewed-by: Eric Blake >> --- >> >> info = block_job_query

Re: [Qemu-devel] [PATCH v2 5/6] qemu-img: Specify backing file for commit

2014-04-08 Thread Eric Blake
On 04/08/2014 06:50 AM, Max Reitz wrote: > Introduce a new parameter for qemu-img commit which may be used to > explicitly specify the backing file unto which an image should be s/unto/into/ > committed if the backing chain has more than a single layer. > > Signed-off-by: Max Reitz > --- > qem

Re: [Qemu-devel] [PATCH for-2.0] hw/pci-host/prep: Don't reverse IO accesses on bigendian hosts

2014-04-08 Thread Peter Maydell
On 8 April 2014 16:51, Peter Maydell wrote: > This fixes the endianness test failure on bigendian hosts. > HOWEVER I have not actually tested it with a guest :-) Alex found me a prep kernel. It seems to have issues with its userspace, but; without this patch, when we probe the IDE devices we get:

  1   2   >