On 04/08/2014 09:14 AM, Kevin Wolf wrote: > Am 08.04.2014 um 14:50 hat Max Reitz geschrieben: >> qemu-img should use QMP commands whenever possible in order to ensure >> feature completeness of both online and offline image operations. As >> qemu-img itself has no access to QMP (since this would basically require >> just everything being linked into qemu-img), imitate QMP's >> implementation of block-commit by using commit_active_start() and then >> waiting for the block job to finish. > > Leaves us with the HMP commit command that uses the old bdrv_commit() > function. I wonder if we can get rid of it by letting the HMP command > stop the VM, do a live commit, and then restart the VM.
Not a bad idea, actually. Of course, as additional patches. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
