On 8 April 2014 16:51, Peter Maydell <peter.mayd...@linaro.org> wrote: > This fixes the endianness test failure on bigendian hosts. > HOWEVER I have not actually tested it with a guest :-)
Alex found me a prep kernel. It seems to have issues with its userspace, but; without this patch, when we probe the IDE devices we get: hdc: EQUMD DVR-MO, ATAPI cdrom or floppy?, assuming FLOPPY drive (spot the byte-reversed halfwords!) and with the patch we get: hdc: QEMU DVD-ROM, ATAPI CD/DVD-ROM drive so I'm pretty confident this patch is not just fixing a test case but also fixing problems with real guests. thanks -- PMM