On Fri, 7 Feb 2014 10:30:40 -0500
"Gabriel L. Somlo" wrote:
> IRQNoFlags on HPET._CRS crashes WinXP because it causes the HPET
> to conflict with the system timer and/or the RTC. It only occurs
> on Apple hardware, and even there it is exposed fully only when
> OS X is detected (via _OSI). Recent
On Sun, 02/09 10:48, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> block/gluster.c | 24 +---
> 1 file changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/block/gluster.c b/block/gluster.c
> index f9dd37f..bc9c59f 100644
> --- a/block/gluster.c
> +++ b/b
On Sun, 02/09 10:48, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> block/cow.c | 12 +++-
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/block/cow.c b/block/cow.c
> index 7fc0b12..43a2150 100644
> --- a/block/cow.c
> +++ b/block/cow.c
> @@ -82,7 +82,7 @@
On Sun, 02/09 10:48, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> block/curl.c | 13 +
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/block/curl.c b/block/curl.c
> index a807584..353bab1 100644
> --- a/block/curl.c
> +++ b/block/curl.c
> @@ -456,30
On Sun, 02/09 10:48, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> block/qcow.c | 16 ++--
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/block/qcow.c b/block/qcow.c
> index 948b0c5..23bc691 100644
> --- a/block/qcow.c
> +++ b/block/qcow.c
> @@ -119
On Sun, 02/09 10:48, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> block/qed.c | 16 ++--
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/block/qed.c b/block/qed.c
> index 694e6e2..59bdd58 100644
> --- a/block/qed.c
> +++ b/block/qed.c
> @@ -398,7 +3
On Sun, 02/09 10:48, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> block/vhdx.c | 21 +
> 1 file changed, 9 insertions(+), 12 deletions(-)
>
> diff --git a/block/vhdx.c b/block/vhdx.c
> index 9ee0a61..de1a80a 100644
> --- a/block/vhdx.c
> +++ b/block/vhdx.c
> @@
On Mon, Feb 10, 2014 at 09:33:06AM +0800, Fam Zheng wrote:
> On Sun, 02/09 07:03, Eduardo Habkost wrote:
> > We had an unwritten rule about declarations having to be at beginning of
> > blocks. Make it a written rule.
> >
> > Signed-off-by: Eduardo Habkost
> > ---
> > CODING_STYLE | 7 +++
>
On Sun, 02/09 10:48, Paolo Bonzini wrote:
> Before:
> $ ./qemu-io-old
> qemu-io-old> open -r -o driver=vvfat,fat-type=24,dir=i386-softmmu
> Valid FAT types are only 12, 16 and 32
> qemu-io-old: can't open device (null): Could not open image: Invalid
> argument
>
> After:
> $ .
On Mon, Feb 10, 2014 at 01:23:37AM +0100, Andreas Färber wrote:
[...]
> > /**
> > * X86CPUClass:
> > * @parent_realize: The parent class' realize handler.
> > @@ -49,6 +52,16 @@ typedef struct X86CPUClass {
> > CPUClass parent_class;
> > /*< public >*/
> >
> > +/* CPU model def
Il 09/02/2014 16:24, Mark Cave-Ayland ha scritto:
Alright I can change those for the next version of the patch. Does that
mean the use of hex output is now a display option rather than a
separate property type?
"info qtree" will always print both decimal and hex.
Paolo
Il 10/02/2014 08:38, Fam Zheng ha scritto:
> if (s->client.is_unix) {
> -sock = unix_socket_outgoing(qemu_opt_get(s->socket_opts, "path"));
> +sock = unix_connect(qemu_opt_get(s->socket_opts, "path"), errp);
Why not use unix_connect_opts like below?
Right!
> } else
On Mon, Feb 10, 2014 at 06:19:58AM -0200, Eduardo Habkost wrote:
> On Mon, Feb 10, 2014 at 01:23:37AM +0100, Andreas Färber wrote:
> [...]
> > > /**
> > > * X86CPUClass:
> > > * @parent_realize: The parent class' realize handler.
> > > @@ -49,6 +52,16 @@ typedef struct X86CPUClass {
> > >
Il 10/02/2014 09:02, Fam Zheng ha scritto:
On Sun, 02/09 10:48, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> block/gluster.c | 24 +---
> 1 file changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/block/gluster.c b/block/gluster.c
> index f9dd37f..bc9
Il 10/02/2014 09:04, Fam Zheng ha scritto:
I'm never sure about choice of using local_err with error_propagate, or
straightly pass errp, but the logic still looks right to me, so,
Basically, never use error_is_set. If you do, you probably should have
used instead &local_err and error_propagat
On Sun, 02/09 10:48, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> block/vmdk.c | 40 +---
> 1 file changed, 29 insertions(+), 11 deletions(-)
>
> diff --git a/block/vmdk.c b/block/vmdk.c
> index 99ca60f..58f4c34 100644
> --- a/block/vmdk.c
> +++
Il 10/02/2014 09:09, Fam Zheng ha scritto:
On Sun, 02/09 10:48, Paolo Bonzini wrote:
Signed-off-by: Paolo Bonzini
---
block/qcow.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index 948b0c5..23bc691 100644
--- a/block/qcow.c
On 02/10/14 04:34, Qiao Nuohan wrote:
> On 01/31/2014 11:04 PM, Ekaterina Tumanova wrote:
>> True! Fixed. Tested.
>>
>> Can you please put it into push-queue?
>>
>> Thanks,
>> Kate.
>>
>> Ekaterina Tumanova (1):
>>Define the architecture for compressed dump format.
>>
>> dump.c |
On Sun, 02/09 10:48, Paolo Bonzini wrote:
> Currently, we just try reading a VMDK file as both image and descriptor.
> This makes it hard to choose which of the two attempts gave the best error.
> We'll decide in advance if the file looks like an image or a descriptor,
> and this patch is the first
On Fri, Jan 31, 2014 at 06:34:40PM +0100, Antonios Motakis wrote:
> Add a new QEMU netdev backend that is intended to invoke vhost_net with the
> vhost-user backend.
>
> At runtime the netdev will detect if the vhost backend is up or down. Upon
> disconnection it will set link_down accordingly and
On Sun, 02/09 10:48, Paolo Bonzini wrote:
> This prepares for propagating errors from vmdk_open_sparse and
> vmdk_open_desc_file up to the caller of vmdk_open.
>
> Signed-off-by: Paolo Bonzini
> ---
> block/vmdk.c | 22 +++---
> tests/qemu-iotests/059.out | 4 ++--
On Sun, 02/09 10:48, Paolo Bonzini wrote:
> Now that we can return the "right" errors, use the Error** parameter
> to pass them back instead of just printing them.
>
> Signed-off-by: Paolo Bonzini
> ---
> block/vmdk.c | 11 ++-
> tests/qemu-iotests/059.out | 6 ++
> 2
On Fri, Jan 31, 2014 at 06:34:41PM +0100, Antonios Motakis wrote:
> The supplied chardev id will be inspected for supported options. Only
> a socket backend, with a set path (i.e. a unix socket) and optionally
> the server parameter set, will be allowed. Other options (nowait, telnet)
> will make t
On Sun, 02/09 10:48, Paolo Bonzini wrote:
> diff --git a/block/bochs.c b/block/bochs.c
> index 51d9a90..f0f9a7e 100644
> --- a/block/bochs.c
> +++ b/block/bochs.c
> @@ -129,7 +129,8 @@ static int bochs_open(BlockDriverState *bs, QDict
> *options, int flags,
> strcmp(bochs.subtype, GROWING
Fam Zheng writes:
> This prints an error message, instead of core dump, when "-qtest"
> option value is invalid, e.g.:
>
> $ ./x86_64-softmmu/qemu-system-x86_64 -qtest unknown
> qemu-system-x86_64: Failed to initialize device for qtest:
> "unknown"
>
> Signed-off-by: Fam Zheng
On Fri, Jan 31, 2014 at 06:34:29PM +0100, Antonios Motakis wrote:
> In this patch series we would like to introduce our approach for putting a
> virtio-net backend in an external userspace process. Our eventual target is to
> run the network backend in the Snabbswitch ethernet switch, while receivi
On Sun, 02/09 10:48, Paolo Bonzini wrote:
> Instead of just putting it in debugging output, we can now put the
> value in an Error.
>
> Signed-off-by: Paolo Bonzini
> ---
> block/vdi.c | 25 -
> 1 file changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/block/vdi.
On 02/10/2014 04:29 PM, Laszlo Ersek wrote:
Last time I had submitted patches for dump, they went in via Luiz's queue:
http://repo.or.cz/w/qemu/qmp-unstable.git/shortlog/refs/heads/queue/qmp-next
It seems appropriate now as well; in my clone:
$ git diff master..qiao_v8>squashed.patch
$ scripts
Il 10/02/2014 09:47, Fam Zheng ha scritto:
> @@ -449,7 +449,7 @@ static int qcow2_open(BlockDriverState *bs, QDict
*options, int flags,
>
> if (header.magic != QCOW_MAGIC) {
> error_setg(errp, "Image is not in qcow2 format");
It might be good to have a consistent message pattern i
On Fri, Feb 07, 2014 at 10:30:40AM -0500, Gabriel L. Somlo wrote:
> IRQNoFlags on HPET._CRS crashes WinXP because it causes the HPET
> to conflict with the system timer and/or the RTC. It only occurs
> on Apple hardware, and even there it is exposed fully only when
> OS X is detected (via _OSI). Re
On Wed, Feb 05, 2014 at 04:36:43PM +0100, Igor Mammedov wrote:
> changes since v5:
> - fixed typos Eric pointed to
> - fix conflict of [5/9] with new patch "acpi-build: append description for
> non-hotplug"
> - rebased on top of todays PCI tree
>
> changes since v4:
> - rebased on top of PCI
Hi Edgar and Guenter,
2014-02-08 Edgar E. Iglesias :
> On Fri, Feb 07, 2014 at 03:17:31PM -0800, Guenter Roeck wrote:
> > Michal,
> >
> > commit 34b9c07a3 (microblaze: Disable stack protection from bootloader)
> results
> > in the following qemu crash in 3.14-rc1.
> >
> > /opt/buildbot/bin/qemu-
On Mon, 02/10 09:24, Paolo Bonzini wrote:
> Il 10/02/2014 08:38, Fam Zheng ha scritto:
> >>> if (s->client.is_unix) {
> >>> -sock = unix_socket_outgoing(qemu_opt_get(s->socket_opts,
> >>> "path"));
> >>> +sock = unix_connect(qemu_opt_get(s->socket_opts, "path"), errp);
> >Why
On Mon, 02/10 09:27, Paolo Bonzini wrote:
> Il 10/02/2014 09:02, Fam Zheng ha scritto:
> >On Sun, 02/09 10:48, Paolo Bonzini wrote:
> >>> Signed-off-by: Paolo Bonzini
> >>> ---
> >>> block/gluster.c | 24 +---
> >>> 1 file changed, 13 insertions(+), 11 deletions(-)
> >>>
> >>>
Andreas Färber writes:
> Paolo,
>
> Am 08.02.2014 11:01, schrieb Paolo Bonzini:
>> Anthony, Peter,
>>
>> The following changes since commit 0169c511554cb0014a00290b0d3d26c31a49818f:
>>
>> Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2014-01-24
>> 15:52:44 -0800)
>>
>> are
On 9 February 2014 22:15, Paolo Bonzini wrote:
> However, I'd prefer to first apply the patch to fix exec.c in order to keep
> bisection as clean as possible.
Agreed; can you point me at the pullreq (or failing that, patches you
want me to apply) that fixes that?
thanks
-- PMM
* Stefan Priebe (s.pri...@profihost.ag) wrote:
> i could fix it by explicitly disable xbzrle - it seems its
> automatically on if i do not set the migration caps to false.
>
> So it seems to be a xbzrle bug.
Ah right, yes that would make sense for the type of errors
you're seeing, and does make i
I was able to trace the flow to some extent but i still have some queries :
1. CPUARCHState is the main structure where we store the register
info. for e.g. - CPUARMState for ARM. We also main some local
temporaries cpu_R. So where and how are these temporary values
committed to the main structure
On Mon, 10 Feb 2014 01:23:37 +0100
Andreas Färber wrote:
> Am 31.01.2014 19:13, schrieb Eduardo Habkost:
> > Register separate QOM classes for each x86 CPU model.
> >
> > This will allow management code to more easily probe what each CPU model
> > provides, by simply creating objects using the a
* Laszlo Ersek (ler...@redhat.com) wrote:
> comments below
Thanks,
> On 01/30/14 11:20, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > If enabled, set the thread name at creation (on GNU systems with
> > pthread_set_np)
> > Fix up all the callers with a thread
On Mon, 10 Feb 2014 11:09:16 +0200
"Michael S. Tsirkin" wrote:
> On Wed, Feb 05, 2014 at 04:36:43PM +0100, Igor Mammedov wrote:
> > changes since v5:
> > - fixed typos Eric pointed to
> > - fix conflict of [5/9] with new patch "acpi-build: append description for
> > non-hotplug"
> > - rebased
* Laszlo Ersek (ler...@redhat.com) wrote:
> On 01/30/14 11:20, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > Signed-off-by: Dr. David Alan Gilbert
> > Reviewed-by: Alex Bennée
> > ---
> > vl.c | 52 +++-
> > 1 fil
The big lock implementation in block/vmdk.c causes dead lock with
dependent breakpoints in test_io(), so the test hangs. Disable it for
now.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/077 | 4
1 file changed, 4 insertions(+)
diff --git a/tests/qemu-iotests/077 b/tests/qemu-iotests/077
* Laszlo Ersek (ler...@redhat.com) wrote:
> a few irrelevant comments below:
>
> On 01/30/14 11:20, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > Add flag storage to qemu-thread-* to store the namethreads flag
> >
> > Signed-off-by: Dr. David Alan Gilbert
> > -
Am 10.02.2014 um 11:09 hat Fam Zheng geschrieben:
> The big lock implementation in block/vmdk.c causes dead lock with
> dependent breakpoints in test_io(), so the test hangs. Disable it for
> now.
>
> Signed-off-by: Fam Zheng
This is already solved by "qemu-iotest: Make 077 raw-only" (pull reque
Am 10.02.2014 um 08:00 hat Fam Zheng geschrieben:
> On Sun, 02/09 10:02, Kevin Wolf wrote:
> > Signed-off-by: Kevin Wolf
> > ---
> > hw/sd/sdhci.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
> > index 0906a1d..a0b90ba 100644
> > --- a/hw/sd/sdhci.c
On Fri, Feb 07, 2014 at 08:54:00AM +0100, Alexander Graf wrote:
>
>
> > Am 07.02.2014 um 08:05 schrieb Michael Tokarev :
> >
> > 06.02.2014 19:30, Alexander Graf wrote:
> >> The checksum calculation header exports a function that refers to struct
> >> iov which is defined in iov.h. Include the h
Register separate QOM classes for each x86 CPU model.
This will allow management code to more easily probe what each CPU model
provides, by simply creating objects using the appropriate class name,
without having to restart QEMU.
This also allows us to eliminate the qdev_prop_set_globals_for_type
On Mon, 02/10 11:16, Kevin Wolf wrote:
> Am 10.02.2014 um 11:09 hat Fam Zheng geschrieben:
> > The big lock implementation in block/vmdk.c causes dead lock with
> > dependent breakpoints in test_io(), so the test hangs. Disable it for
> > now.
> >
> > Signed-off-by: Fam Zheng
>
> This is already
On 10 February 2014 09:46, Gaurav Sharma wrote:
> I was able to trace the flow to some extent but i still have some queries :
> 1. CPUARCHState is the main structure where we store the register
> info. for e.g. - CPUARMState for ARM. We also main some local
> temporaries cpu_R. So where and how ar
ping
http://patchwork.ozlabs.org/patch/313937/
http://patchwork.ozlabs.org/patch/313938/
http://patchwork.ozlabs.org/patch/313944/
http://patchwork.ozlabs.org/patch/313936/
From: Petar Jovanovic
Sent: Tuesday, February 04, 2014 2:59 PM
To: Petar Jovanovic; q
Le Friday 07 Feb 2014 à 18:43:29 (+0800), Fam Zheng a écrit :
> This will enable accounting of aio requests issued from qemu-io aio
> read/write commands.
>
> Signed-off-by: Fam Zheng
> ---
> qemu-io-cmds.c | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/qemu-io-cmds.c b/qe
On 10 February 2014 11:21, Petar Jovanovic wrote:
> ping
> http://patchwork.ozlabs.org/patch/313937/
> http://patchwork.ozlabs.org/patch/313938/
> http://patchwork.ozlabs.org/patch/313944/
> http://patchwork.ozlabs.org/patch/313936/
These look reasonably sane to me on a quick glance.
So, in the
Le Friday 07 Feb 2014 à 18:43:30 (+0800), Fam Zheng a écrit :
> This removes the dummy scripts/qtest and adds scripts/qtest/qtest.py as
> a python library for qtest protocol.
>
> This is a skeleton with a basic "cmd" method to execute a command,
> reading and parsing of qtest output will be added
Le Friday 07 Feb 2014 à 18:43:31 (+0800), Fam Zheng a écrit :
> This will allow test case to run command in qtest protocol. It's
> write-only for now.
>
> Signed-off-by: Fam Zheng
> ---
> tests/qemu-iotests/iotests.py | 20 ++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
Sorry if i am a bit slow on this,
1. For ld/st do we will always have a mapping in the CPUTLBEntry ?
2. I see a lot helper functions in /include/exec/software_template.h ,
from where and how do these come into picture ?
3. When is the TLB populated for addresses within RAM device ?
On 2/10/14, Pet
Hi
Please, send any topic that you are interested in covering.
Agenda:
* [Qemu-devel] [PATCH V17 00/11] Add support for binding guest numa
nodes
Any news about this? (Vinod)
* Should we change anything to get more people to sign for the call?
There hasn't been a call in quite a long time.
Le Friday 07 Feb 2014 à 18:43:33 (+0800), Fam Zheng a écrit :
> This case utilizes qemu-io command "aio_{read,write} -q" to verify the
> effectiveness of IO throttling options.
>
> It's implemented by driving the vm timer from qtest protocol, so the
> throttling timers are signaled with determined
Am 08.02.2014 um 18:39 hat Max Reitz geschrieben:
> Make bdrv_open() take a pointer to a BDS pointer, similarly to
> bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open()
> will create a new BDS with an empty name; if the BDS pointer is not
> NULL, that existing BDS will be reused
Le Saturday 08 Feb 2014 à 18:39:12 (+0100), Max Reitz a écrit :
> Make bdrv_open() take a pointer to a BDS pointer, similarly to
> bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open()
> will create a new BDS with an empty name; if the BDS pointer is not
> NULL, that existing BDS w
On Mon, 10 Feb 2014 16:57:08 +0800
Qiao Nuohan wrote:
> On 02/10/2014 04:29 PM, Laszlo Ersek wrote:
> > Last time I had submitted patches for dump, they went in via Luiz's queue:
> >
> > http://repo.or.cz/w/qemu/qmp-unstable.git/shortlog/refs/heads/queue/qmp-next
> >
> > It seems appropriate now
Markus Armbruster writes:
> Paolo Bonzini writes:
>
>> Il 06/02/2014 15:30, Markus Armbruster ha scritto:
>>> Visitors get passed a pointer to the visited object. The generated
>>> visitors try to cope with this pointer being null in some places, for
>>> instance like this:
>>>
>>> visit_st
Richard Henderson writes:
> On 02/04/2014 12:01 PM, Lluís Vilanova wrote:
>> Richard Henderson writes:
>>
>>> On 01/31/2014 08:10 AM, Lluís Vilanova wrote:
+#define ldub(p)({ trace_guest_vmem(p, 1, 0); ldub_raw(p);})
>>
>>> Are you sure you want to log these here? Uses of these mac
Le Saturday 08 Feb 2014 à 18:39:13 (+0100), Max Reitz a écrit :
> Allow bdrv_open() to handle references to existing block devices just as
> bdrv_file_open() is already capable of.
>
> Signed-off-by: Max Reitz
> ---
> block.c | 41 ++---
> block/
Le Saturday 08 Feb 2014 à 18:39:14 (+0100), Max Reitz a écrit :
> Add the bdrv_open() option BDRV_O_PROTOCOL which results in passing the
> call to bdrv_file_open(). Additionally, make bdrv_file_open() static and
> therefore bdrv_open() the only way to call it.
>
> Consequently, all existing calls
Le Saturday 08 Feb 2014 à 18:39:15 (+0100), Max Reitz a écrit :
> Remove the reference parameter and the related handling code from
> bdrv_file_open(), since it exists in bdrv_open() now as well.
>
> Signed-off-by: Max Reitz
> Reviewed-by: Benoit Canet
> ---
> block.c | 33 +++--
Am 10.02.2014 09:48, schrieb Markus Armbruster:
> Fam Zheng writes:
>
>> This prints an error message, instead of core dump, when "-qtest"
>> option value is invalid, e.g.:
>>
>> $ ./x86_64-softmmu/qemu-system-x86_64 -qtest unknown
>> qemu-system-x86_64: Failed to initialize device fo
Am 24.01.2014 17:18, schrieb Petar Jovanovic:
> From: Petar Jovanovic
>
> Add mips32r5-generic among CPU definitions for MIPS.
> Define ISA_MIPS32R3 and ISA_MIPS32R5.
>
> Signed-off-by: Petar Jovanovic
> ---
> target-mips/mips-defs.h |8
> target-mips/translate_init.c | 25
Le Saturday 08 Feb 2014 à 18:39:16 (+0100), Max Reitz a écrit :
> Change bdrv_file_open() to take a simple pointer to an already existing
> BDS instead of an indirect one. The BDS will be created in bdrv_open()
> if necessary.
>
> Signed-off-by: Max Reitz
> ---
> block.c | 24 +--
Am 16.12.2013 15:12, schrieb James Hogan:
> From: Sanjay Lal
>
> Implement the main KVM arch API for MIPS.
>
> Signed-off-by: Sanjay Lal
> Signed-off-by: James Hogan
> Cc: Aurelien Jarno
> Cc: Gleb Natapov
> Cc: Paolo Bonzini
> ---
> Changes in v2:
> - Expand commit message
> - Checkpatch
On Sun, 2014-02-02 at 15:47 +0200, Michael S. Tsirkin wrote:
> On Fri, Jan 31, 2014 at 12:39:01PM -0700, Eric Blake wrote:
> > On 01/31/2014 12:03 PM, Gabriel L. Somlo wrote:
> > > Allow guests to omit the configuration of a floppy disk controller.
> > >
> > > Signed-off-by: Gabriel Somlo
> > > -
The scripts carry this copyright notice:
# This work is licensed under the terms of the GNU GPLv2.
# See the COPYING.LIB file in the top-level directory.
The sentences contradict each other, as COPYING.LIB contains the LGPL
2.1. Michael Roth says this was a simple pasto, and he meant to
Visitors get passed a pointer to the visited object. The generated
visitors try to cope with this pointer being null in some places, for
instance like this:
visit_start_optional(m, obj ? &(*obj)->has_name : NULL, "name", &err);
visit_start_optional() passes its second argument to Visitor met
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
scripts/qapi-commands.py | 20
1 file changed, 20 deletions(-)
diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py
index 38c2347..9734ab0 100644
--- a/scripts/qapi-commands.py
+++ b/scripts/qapi-comma
Argument is null when visiting an unboxed struct. I can't see such a
visit in the current code. Fix it anyway.
Signed-off-by: Markus Armbruster
---
qapi/opts-visitor.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index 96ed858
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
tests/qapi-schema/qapi-schema-test.json | 6 +-
tests/qapi-schema/qapi-schema-test.out | 6 --
tests/test-qmp-commands.c | 15 ++-
tests/test-qmp-input-visitor.c | 4 ++--
tests/test-qmp-o
Argument can't be null. No other Visitor method type_str() checks for
null.
Signed-off-by: Markus Armbruster
---
qapi/qapi-dealloc-visitor.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/qapi/qapi-dealloc-visitor.c b/qapi/qapi-dealloc-visitor.c
index dc53545..d0ea118 10
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
scripts/qapi-visit.py | 2 --
1 file changed, 2 deletions(-)
diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py
index b2a1c1c..97e9b11 100644
--- a/scripts/qapi-visit.py
+++ b/scripts/qapi-visit.py
@@ -494,10 +494,8 @@ fdecl.w
Coverity is unhappy with the generated code. Nothing serious, just
heaps of valid DEADCODE defects topped off with a few bogus
FORWARD_NULL defects.
I had a look at the generator, and decided I don't want to mess with
it without decent test coverage. Unfortunately, a few features have
been added
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
tests/test-qmp-commands.c | 43 +++
1 file changed, 35 insertions(+), 8 deletions(-)
diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-commands.c
index 5a3e82a..d039b87 100644
--- a/tests/
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
tests/qapi-schema/qapi-schema-test.json | 2 ++
tests/qapi-schema/qapi-schema-test.out | 1 +
tests/test-qmp-commands.c | 16
3 files changed, 19 insertions(+)
diff --git a/tests/qapi-schema/qapi-sche
I know now as how the helper methods called for address translation.
In case of slow path, the address translation is done at the end of
block by method "tcg_out_tb_finalize". Any specific reasons for it ?
Thanks,
Gaurav
On 2/10/14, Gaurav Sharma wrote:
> Sorry if i am a bit slow on this,
> 1. F
Andreas Färber writes:
> Am 10.02.2014 09:48, schrieb Markus Armbruster:
>> Fam Zheng writes:
>>
>>> This prints an error message, instead of core dump, when "-qtest"
>>> option value is invalid, e.g.:
>>>
>>> $ ./x86_64-softmmu/qemu-system-x86_64 -qtest unknown
>>> qemu-system-x86_
The test demonstrates a generator bug: the generated struct
UserDefFlatUnion doesn't include members for the indirect base
UserDefZero.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
tests/qapi-schema/qapi-schema-test.json | 7 +++
tests/qapi-schema/qapi-schema-test.out | 2
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
tests/qapi-schema/qapi-schema-test.json | 4
tests/qapi-schema/qapi-schema-test.out | 6 +-
tests/test-qmp-input-strict.c | 32
tests/test-qmp-input-visitor.c | 18 +++
Am 10.02.2014 10:20, schrieb Markus Armbruster:
> Andreas Färber writes:
>
>> Paolo,
>>
>> Am 08.02.2014 11:01, schrieb Paolo Bonzini:
>>> Anthony, Peter,
>>>
>>> The following changes since commit 0169c511554cb0014a00290b0d3d26c31a49818f:
>>>
>>> Merge remote-tracking branch 'qemu-kvm/uq/maste
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
tests/qapi-schema/qapi-schema-test.json | 1 +
tests/qapi-schema/qapi-schema-test.out | 2 +-
tests/test-qmp-input-strict.c | 4 ++--
tests/test-qmp-input-visitor.c | 3 ++-
tests/test-qmp-output-visitor.c |
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
tests/qapi-schema/qapi-schema-test.json | 4 +++-
tests/qapi-schema/qapi-schema-test.out | 2 +-
tests/test-qmp-commands.c | 8 +---
3 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/tests/qapi-schema/qa
Am 08.02.2014 um 18:39 hat Max Reitz geschrieben:
> The fail and success paths of bdrv_file_open() may be further shortened
> by reusing code already existent in bdrv_open(). This includes
> bdrv_file_open() not taking the reference to options which allows the
> removal of QDECREF(options) in that
Am 08.02.2014 um 18:39 hat Max Reitz geschrieben:
> bdrv_file_open() is now nearly a subset of bdrv_open(), except for the
> fact that bdrv_file_open() is for protocols and bdrv_open() for block
> drivers. It is possible to use bdrv_file_open() with a block driver, but
> in that case that block dri
Hi,
After rebooting, qemu hangs with 100% cpu usage when loading
DISPLAY.SYS. It is loaded by the following line in CONFIG.SYS:
DEVICE=C:\DOS\DISPLAY.SYS CON=(EGA,,1)
Thanks. That DEVICE line causes a failure for me as well and the call
trace is much easier to understand.
The SeaVGABIOS pat
On Tue, 28 Jan 2014 13:30:03 +0530
"Aneesh Kumar K.V" wrote:
> This support updating htab managed by the hypervisor. Currently we don't
> have any user for this feature. This actually bring the store_hpte
> interface in-line with the load_hpte one. We may want to use this when we
> want to emulate
> with the generic model for a long time. What's the difficulty with
> taking "a real CPU model"? Is there no silicon yet
No silicon available yet.
Regards,
Petar
From: Andreas Färber [afaer...@suse.de]
Sent: Monday, February 10, 2014 2:51 PM
To: Petar Jov
On 02/10/2014 07:20 AM, Markus Armbruster wrote:
> The scripts carry this copyright notice:
>
> # This work is licensed under the terms of the GNU GPLv2.
> # See the COPYING.LIB file in the top-level directory.
>
> The sentences contradict each other, as COPYING.LIB contains the LGPL
> 2.
On 02/10/2014 07:20 AM, Markus Armbruster wrote:
> Argument is null when visiting an unboxed struct. I can't see such a
> visit in the current code. Fix it anyway.
Is this a sign of missing testsuite coverage?
>
> Signed-off-by: Markus Armbruster
> ---
> qapi/opts-visitor.c | 4 +++-
> 1 fil
On 02/10/2014 07:20 AM, Markus Armbruster wrote:
> Argument can't be null. No other Visitor method type_str() checks for
> null.
>
> Signed-off-by: Markus Armbruster
> ---
> qapi/qapi-dealloc-visitor.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Eric Blake
>
> di
On Mon, Feb 10, 2014 at 03:57:46PM +0100, Sebastian wrote:
> Hi,
>
> >>After rebooting, qemu hangs with 100% cpu usage when loading
> >>DISPLAY.SYS. It is loaded by the following line in CONFIG.SYS:
> >>
> >>DEVICE=C:\DOS\DISPLAY.SYS CON=(EGA,,1)
> >
> >Thanks. That DEVICE line causes a failure f
On Wed, Feb 05, 2014 at 11:04:42PM -0500, Kevin O'Connor wrote:
> On Wed, Feb 05, 2014 at 12:44:06PM -0500, Kevin O'Connor wrote:
> > On Tue, Feb 04, 2014 at 04:33:19PM +0400, Michael Tokarev wrote:
> > > We have a bugreport in debian, http://bugs.debian.org/737142,
> > > stating that PC-BSD does n
On 10 February 2014 13:51, Andreas Färber wrote:
> Am 24.01.2014 17:18, schrieb Petar Jovanovic:
>> From: Petar Jovanovic
>> --- a/target-mips/translate_init.c
>> +++ b/target-mips/translate_init.c
>> @@ -333,6 +333,31 @@ static const mips_def_t mips_defs[] =
>> .insn_flags = CPU_MIPS32R
Am 10.02.2014 04:52, schrieb Alexey Kardashevskiy:
> This adds a test if SPAPR PHB can be added via the command line.
>
> Signed-off-by: Alexey Kardashevskiy
> ---
> tests/Makefile | 2 ++
> tests/spapr-phb-test.c | 28
> 2 files changed, 30 insertions(+)
>
1 - 100 of 357 matches
Mail list logo
