Am 08.02.2014 um 18:39 hat Max Reitz geschrieben: > bdrv_file_open() is now nearly a subset of bdrv_open(), except for the > fact that bdrv_file_open() is for protocols and bdrv_open() for block > drivers. It is possible to use bdrv_file_open() with a block driver, but > in that case that block driver must be explicitly specified. > > Due to these great similarities, bdrv_file_open() can be integrated and > made a special case of bdrv_open(). If the flag BDRV_O_PROTOCOL is > specified, bdrv_open() will now do what bdrv_file_open() used to do: > Auto-detecting a protocol instead of a block driver. > > This series implements this and changes all calls to bdrv_file_open() to > bdrv_open() calls with BDRV_O_PROTOCOL specified. > > Note that this flag cannot be discerned automatically since it is > impossible for bdrv_open() to know by itself whether a given file should > be opened with or without the format layer involved: Both are valid > alternatives. Therefore, it still has to be specified by the user.
I had two or three comments that can be addressed in a follow-up. Series: Reviewed-by: Kevin Wolf <kw...@redhat.com>
