On 02/10/2014 07:20 AM, Markus Armbruster wrote: > Argument is null when visiting an unboxed struct. I can't see such a > visit in the current code. Fix it anyway.
Is this a sign of missing testsuite coverage?
>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
> ---
> qapi/opts-visitor.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <ebl...@redhat.com>
>
> diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
> index 96ed858..5d830a2 100644
> --- a/qapi/opts-visitor.c
> +++ b/qapi/opts-visitor.c
> @@ -124,7 +124,9 @@ opts_start_struct(Visitor *v, void **obj, const char
> *kind,
> OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
> const QemuOpt *opt;
>
> - *obj = g_malloc0(size > 0 ? size : 1);
> + if (obj) {
> + *obj = g_malloc0(size > 0 ? size : 1);
> + }
> if (ov->depth++ > 0) {
> return;
> }
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
