Re: [Qemu-devel] [PATCHv6 5/6] qemu-iotests: fix expected output of test 067

2014-01-15 Thread Fam Zheng
On Wed, 01/15 08:01, Peter Lieven wrote: > On 15.01.2014 07:54, Fam Zheng wrote: > >On Mon, 01/13 11:21, Peter Lieven wrote: > >>Signed-off-by: Peter Lieven > >>--- > >> tests/qemu-iotests/067.out |8 > >> 1 file changed, 4 insertions(+), 4 deletions(-) > >> > >>diff --git a/tests/qe

Re: [Qemu-devel] [PATCH] KVM: fix addr type for KVM_IOEVENTFD

2014-01-15 Thread Michael S. Tsirkin
On Fri, Jan 10, 2014 at 06:20:18PM +1100, Alexey Kardashevskiy wrote: > The @addr here is a guest physical address and can easily be bigger > than 4G. > > This changes uint32_t to hwaddr. > > Cc: Michael S. Tsirkin > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Michael S. Tsirkin > ---

Re: [Qemu-devel] 回复: Re: 回复: Re: [PATCH] linux-user: sync syscall numbers upto 3.13

2014-01-15 Thread Riku Voipio
On 14 January 2014 12:50, Peter Maydell wrote: > On 14 January 2014 01:33, 管雪涛 wrote: > > I'm sorry, but what's exactly your meaning? > > Change linux-user/unicore32/syscall_nr.h to be the same as linux kernel. > > This. We should support the same set of binaries you can > run on the upstream ke

Re: [Qemu-devel] [PATCH v2 1/2] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-15 Thread Peter Crosthwaite
On Tue, Jan 14, 2014 at 3:19 PM, Stefan Hajnoczi wrote: > On Mon, Jan 13, 2014 at 11:16:37PM +1000, Peter Crosthwaite wrote: >> On Mon, Jan 13, 2014 at 11:15 PM, Peter Crosthwaite >> wrote: >> > On Sat, Jan 11, 2014 at 8:13 PM, Beniamino Galvani >> > wrote: >> >> +} else { >> >> +mi

Re: [Qemu-devel] [PATCH v15 6/9] module: implement module loading

2014-01-15 Thread Fam Zheng
On Tue, 01/14 15:45, Daniel P. Berrange wrote: > On Tue, Jan 14, 2014 at 04:19:41PM +0100, Paolo Bonzini wrote: > > Il 14/01/2014 15:47, Richard Henderson ha scritto: > > +echo "CONFIG_STAMP=`date +%s`_$$_$RANDOM" >> $config_host_mak > > >>> >> > > >>> >> I really really don't like random numb

[Qemu-devel] [Bug 1256546] Re: qemu-s390x-static: segmentation fault entering chroot

2014-01-15 Thread Ken Sharp
Version: 1.5.0+dfsg-3ubuntu5.2 This doesn't occur in version 1.5.0 in Saucy. Regression? The second stage fails anyway because it claims it cannot find /debootstrap/debootstrap which is similar to other open bugs, but there is no segfault. ** Tags added: regression-release -- You received this

[Qemu-devel] [PATCH v16 1/9] rules.mak: fix $(obj) to a real relative path

2014-01-15 Thread Fam Zheng
Makefile.target includes rule.mak and unnested common-obj-y, then prefix them with '../', this will ignore object specific QEMU_CFLAGS in subdir Makefile.objs: $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) Because $(obj) here is './block', instead of '../block'. This doesn't hurt compiling bec

[Qemu-devel] [PATCH v16 4/9] darwin: do not use -mdynamic-no-pic

2014-01-15 Thread Fam Zheng
From: Paolo Bonzini While -mdynamic-no-pic can speed up the code somewhat, it is only used on the legacy PowerPC Mac OS X, and I am not sure if anyone is still testing that. Disabling PIC can cause problems when enabling modules, so do not do that. Signed-off-by: Paolo Bonzini Signed-off-by: F

[Qemu-devel] [PATCH v16 0/9] Shared library module support

2014-01-15 Thread Fam Zheng
A few changes on Paolo's v15, to fix MacOSX build (in fact fix Linux as well) and get rid of $RANDOM: [05/09] build-sys: introduce common-obj-m and block-obj-m for DSO Add " -undefined dynamic_lookup" to Darwin LDFLAGS. Otherwise the linker complains about undefined sy

[Qemu-devel] [PATCH v16 8/9] .gitignore: ignore module related files (dll, so, mo)

2014-01-15 Thread Fam Zheng
Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 1c9d63d..7702b0c 100644 --- a/.gitignore +++ b/.gitignore @@ -64,6 +64,9 @@ fsdev/virtfs-proxy-helper.pod *.cp *.dvi *.exe +*.dll +*.so +*.

[Qemu-devel] [PATCH v16 2/9] rules.mak: allow per object cflags and libs

2014-01-15 Thread Fam Zheng
Adds extract-libs in LINK to expand any "per object libs", the syntax to define such a libs options is like: foo.o-libs := $(CURL_LIBS) in block/Makefile.objs. Similarly, foo.o-cflags := $(FOO_CFLAGS) is also supported. "foo.o" must be listed in a nested var (e.g. common-obj-y

[Qemu-devel] [PATCH v16 7/9] Makefile: install modules with "make install"

2014-01-15 Thread Fam Zheng
Install all the modules to ${MODDIR}. Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini --- Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Makefile b/Makefile index 670ce44..a91f119 100644 --- a/Makefile +++ b/Makefile @@ -371,6 +371,12 @@ install-datadir install-localst

[Qemu-devel] [PATCH v16 9/9] block: convert block drivers linked with libs to modules

2014-01-15 Thread Fam Zheng
The converted block drivers are: curl iscsi rbd ssh glusterfs Signed-off-by: Fam Zheng Signed-off-by: Paolo Bonzini Signed-off-by: Fam Zheng --- configure | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 77f09ba..8

Re: [Qemu-devel] [PATCH v6 0/8] Vhost and vhost-net support for userspace based backends

2014-01-15 Thread Michael S. Tsirkin
On Tue, Jan 14, 2014 at 07:13:29PM +0100, Antonios Motakis wrote: > Hello, > > > On Tue, Jan 14, 2014 at 12:14 PM, Michael S. Tsirkin wrote: > > On Mon, Jan 13, 2014 at 03:25:11PM +0100, Antonios Motakis wrote: > > In this patch series we would like to introduce our approach for putting

Re: [Qemu-devel] [PATCH v6 0/8] Vhost and vhost-net support for userspace based backends

2014-01-15 Thread Michael S. Tsirkin
On Tue, Jan 14, 2014 at 07:13:43PM +0100, Antonios Motakis wrote: > > > > On Tue, Jan 14, 2014 at 12:33 PM, Michael S. Tsirkin wrote: > > On Mon, Jan 13, 2014 at 03:25:11PM +0100, Antonios Motakis wrote: > > In this patch series we would like to introduce our approach for putting >

[Qemu-devel] [PATCH v16 3/9] block: use per-object cflags and libs

2014-01-15 Thread Fam Zheng
No longer adds flags and libs for them to global variables, instead create config-host.mak variables like FOO_CFLAGS and FOO_LIBS, which is used as per object cflags and libs. This removes unwanted dependencies from libcacard. Signed-off-by: Fam Zheng [Split from Fam's patch to enable modules. -

[Qemu-devel] [PATCH target-arm v5 0/5] Reset and Halting modifications + Zynq SMP

2014-01-15 Thread Peter Crosthwaite
Hi All, The clock controller module in the Zynq platform has the ability to halt and reset arbitrary devices, including the CPU. We use this feature to implement SMP Linux - the kernel halts CPU1 then rewrites the vector table to the secondary entry point and the resets+unhalts. This series adds

Re: [Qemu-devel] [PATCH v6 5/8] Add domain socket communication for vhost-user backend

2014-01-15 Thread Michael S. Tsirkin
On Tue, Jan 14, 2014 at 07:14:38PM +0100, Antonios Motakis wrote: > > > > On Tue, Jan 14, 2014 at 12:10 PM, Michael S. Tsirkin wrote: > > On Mon, Jan 13, 2014 at 03:25:16PM +0100, Antonios Motakis wrote: > > Add structures for passing vhost-user messages over a unix domain > socket. >

Re: [Qemu-devel] [PATCH v6 6/8] Add vhost-user calls implementation

2014-01-15 Thread Michael S. Tsirkin
On Tue, Jan 14, 2014 at 07:14:53PM +0100, Antonios Motakis wrote: > > > > On Tue, Jan 14, 2014 at 12:21 PM, Michael S. Tsirkin wrote: > > On Mon, Jan 13, 2014 at 03:25:17PM +0100, Antonios Motakis wrote: > > Each ioctl request of vhost-kernel has a vhost-user message equivalent, >

[Qemu-devel] [PATCH target-arm v5 1/5] arm: zynq: Macroify OCM Base and Size

2014-01-15 Thread Peter Crosthwaite
Convert magic numbers for OCM to Macros. Signed-off-by: Peter Crosthwaite --- hw/arm/xilinx_zynq.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index 98e0958..33a47e0 100644 --- a/hw/arm/xilinx_zynq.c +++ b/hw/arm/xilinx

[Qemu-devel] [PATCH target-arm v5 3/5] zynq_slcr: Implement CPU reset

2014-01-15 Thread Peter Crosthwaite
Implement the CPU reset IO line of the A9_CPU_RST_CTRL register (offset 0x244). This is trivial GPIO mapping straight to the register bits. Signed-off-by: Peter Crosthwaite --- changed from v4: Use GPIOs instead (PMM review) changed from v3: Author reset Use CPU reset rather than device reset use

[Qemu-devel] [PATCH target-arm v5 5/5] arm: zynq: Connect CPU resets to SLCR

2014-01-15 Thread Peter Crosthwaite
Wire up the reset line from the SLCR to the CPUs. Signed-off-by: Peter Crosthwaite --- hw/arm/xilinx_zynq.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index 63390f7..1898d5a 100644 --- a/hw/arm/xilinx_zynq.c +++ b/hw/arm/xilinx_zynq.c @@

[Qemu-devel] [PATCH target-arm v5 4/5] arm: Implement reset GPIO.

2014-01-15 Thread Peter Crosthwaite
Implement a reset GPIO for ARM CPUs. This allows individual reset of ARM CPUs from device land without the need for the much unwanted reset API calls. The CPU is halted as long as the pin is held in reset. Releasing the reset starts the CPU running again. Signed-off-by: Peter Crosthwaite --- Unt

[Qemu-devel] [PATCH V2] qemu-ga: isa-serial support on Windows

2014-01-15 Thread Miki Mishael
Add support for isa-serial method for qemu-ga on Windows, Added -p command line parameter for serial port name specification, e.g. "-p COM15". Changes since V1: * define default path for isa-serial for linux, "/dev/ttyS0". * replaced static void ga_serial_path_correction function for path correcti

[Qemu-devel] [PATCH V2] qemu-ga: isa-serial support on Windows

2014-01-15 Thread Miki Mishael
Add support for isa-serial method for qemu-ga on Windows, Added -p command line parameter for serial port name specification, e.g. "-p COM15". Signed-off-by: Miki Mishael Signed-off-by: Dmitry Fleytman --- qga/channel-win32.c | 20 ++-- qga/main.c | 12 +--- 2 f

Re: [Qemu-devel] [PATCH v2 0/3] virtio-scsi unplug of active device

2014-01-15 Thread Paolo Bonzini
Il 14/01/2014 20:16, Eric Farman ha scritto: > In working with hot-plug/unplug of virtio-scsi devices on s390, > we have occasionally noticed some erratic behavior when an unplug > occurs while I/O is in flight. Ideally a device is not being used > when it is removed from a guest configuration, bu

[Qemu-devel] [PATCH target-arm v5 2/5] arm: zynq: added SMP support

2014-01-15 Thread Peter Crosthwaite
Added Linux SMP support for the Xilinx Zynq platform (2x CPUs are supported) Signed-off-by: Peter Crosthwaite --- Changed from v4: Removed dummy bootreg addr (PMM review) Implemented custom secondary cpu reset (PMM review) Changed from v3: Author reset s/zynq_cpus/cpus simplified custom secondary

Re: [Qemu-devel] [BUGFIX][PATCH v2] configure: Disable libtool if -fPIE does not work with it (bug #1257099)

2014-01-15 Thread Paolo Bonzini
Il 03/01/2014 03:12, Don Slutz ha scritto: > Adjust TMPO and added TMPB, TMPL, and TMPA. libtool needs the names > to be fixed (TMPB). > > Add new functions do_libtool and libtool_prog. > > Add check for broken gcc and libtool. > > Signed-off-by: Don Slutz > --- > Was posted as an attachment.

Re: [Qemu-devel] [PATCH] block: add .bdrv_reopen_prepare() stub for iscsi

2014-01-15 Thread Paolo Bonzini
Il 14/01/2014 19:10, Jeff Cody ha scritto: > To suppport reopen(), the .bdrv_reopen_prepare() stub must exist. > iSCSI does not have anything that needs to be done to support reopen, > so we can just implement the _prepare() stub. > > Signed-off-by: Jeff Cody > --- > block/iscsi.c | 9 +

Re: [Qemu-devel] Fix make check breakage (was [PULL 00/14] QMP queue)

2014-01-15 Thread Markus Armbruster
Luiz Capitulino writes: > On Tue, 14 Jan 2014 17:44:51 +0100 > Kevin Wolf wrote: > >> Am 14.01.2014 um 04:38 hat Edgar E. Iglesias geschrieben: >> > On Tue, Jan 14, 2014 at 09:27:10AM +1000, Peter Crosthwaite wrote: >> > > Ping, >> > > >> > > Has this one been forgotten or are there issues? PMM

Re: [Qemu-devel] [PATCH build-fix v1 1/1] error: Don't use error_report() for assertion msgs.

2014-01-15 Thread Markus Armbruster
Andreas Färber writes: > Am 15.01.2014 03:29, schrieb Peter Crosthwaite: >> Use fprintf(stderr instead. This removes dependency of libqemuutil.a >> on the monitor. >> >> We can further justify this change, in that this code path should only >> trigger under a fatal error condition. fprintf-stder

Re: [Qemu-devel] Enabling vhost-net cause insane high memory usage.

2014-01-15 Thread Michael S. Tsirkin
On Fri, Jan 10, 2014 at 12:00:31AM +0100, Piotr Karbowski wrote: > Hello, > > kernel 3.12.5, qemu-1.7.0. > > With vhost=on, qemu shortly after start uses all its assigned memory > (2G for example), without vhost-net enabled it does not go to more > than 200 MB on my idling test virtual machine.

Re: [Qemu-devel] [PATCH v6 0/8] Vhost and vhost-net support for userspace based backends

2014-01-15 Thread Michael S. Tsirkin
On Mon, Jan 13, 2014 at 03:25:11PM +0100, Antonios Motakis wrote: > In this patch series we would like to introduce our approach for putting a > virtio-net backend in an external userspace process. Our eventual target is to > run the network backend in the Snabbswitch ethernet switch, while receivi

Re: [Qemu-devel] [PATCH v6 6/8] Add vhost-user calls implementation

2014-01-15 Thread Michael S. Tsirkin
On Wed, Jan 15, 2014 at 11:14:14AM +0200, Michael S. Tsirkin wrote: > On Tue, Jan 14, 2014 at 07:14:53PM +0100, Antonios Motakis wrote: > > > > > > > > On Tue, Jan 14, 2014 at 12:21 PM, Michael S. Tsirkin > > wrote: > > > > On Mon, Jan 13, 2014 at 03:25:17PM +0100, Antonios Motakis wrote:

[Qemu-devel] [PATCH v2 2/2] vfio: Do not reattempt a failed rom read

2014-01-15 Thread Bandan Das
During lazy rom loading, if rom read fails, and the guest attempts a read again, vfio will again attempt it. Add a boolean to prevent this. There could be a case where a failed rom read might succeed the next time because of a device reset or such, but it's best to exclude unpredictable behavior S

[Qemu-devel] [Bug 1256546] Re: qemu-s390x-static: segmentation fault entering chroot

2014-01-15 Thread Peter Maydell
Does this patch fix this issue? http://patchwork.ozlabs.org/patch/309529/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1256546 Title: qemu-s390x-static: segmentation fault entering chroot Status

[Qemu-devel] [PATCH v2 1/2] vfio: warn if host device rom can't be read

2014-01-15 Thread Bandan Das
If the device rom can't be read, report an error to the user. This alerts the user that the device has a bad state that is causing rom read failure or option rom loading has been disabled from the device boot menu (among other reasons). Signed-off-by: Bandan Das --- v2: Removed the macros to prin

[Qemu-devel] [PATCH v2 0/2] vfio: Warn on failure to read device rom

2014-01-15 Thread Bandan Das
Minor changes to print a message on the monitor console in case of a rom read failure. Please see individual patches for more details. Bandan Das (2): vfio: warn if host device rom can't be read vfio: Do not reattempt a failed rom read hw/misc/vfio.c | 13 + 1 file changed, 13 in

[Qemu-devel] [PULL 05/42] block/iscsi: return -ENOMEM if an async call fails immediately

2014-01-15 Thread Kevin Wolf
From: Peter Lieven if an async libiscsi call fails directly it can only be due to an out of memory condition. All other errors are returned through the callback. Signed-off-by: Peter Lieven Reviewed-by: Ronnie Sahlberg Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/iscsi

[Qemu-devel] [PULL 01/42] rbd: switch from pipe to QEMUBH completion notification

2014-01-15 Thread Kevin Wolf
From: Stefan Hajnoczi rbd callbacks are called from non-QEMU threads. Up until now a pipe was used to signal completion back to the QEMU iothread. The pipe writer code handles EAGAIN using select(2). The select(2) API is not scalable since fd_set size is static. FD_SET() can write beyond the

[Qemu-devel] [PULL 00/42] Block patches

2014-01-15 Thread Kevin Wolf
The following changes since commit 1cf892ca2689c84960b4ce4d2723b6bee453711c: SPARC: Fix LEON3 power down instruction (2014-01-15 15:37:33 +1000) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-anthony for you to fetch changes up to 01dfcc17541a97e2662b6ce403

[Qemu-devel] [PULL 07/42] gluster: Implement .bdrv_co_write_zeroes for gluster

2014-01-15 Thread Kevin Wolf
From: Bharata B Rao Support .bdrv_co_write_zeroes() from gluster driver by using GlusterFS API glfs_zerofill() that off-loads the writing of zeroes to GlusterFS server. Signed-off-by: Bharata B Rao Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/gluster.c | 79

[Qemu-devel] [PULL 09/42] sheepdog: fix clone operation by 'qemu-img create -b'

2014-01-15 Thread Kevin Wolf
From: Liu Yuan We should pass base_inode->vdi_id to base_vdi_id of SheepdogVdiReq so that sheep can create a clone instead a fresh volume. This fixes following command: qemu-create -b sheepdog:base sheepdog:clone so users can boot sheepdog:clone as a normal volume. Cc: qemu-devel@nongnu.org C

[Qemu-devel] [PULL 02/42] qemu-iotests: Introduce _unsupported_imgopts

2014-01-15 Thread Kevin Wolf
From: Fam Zheng Introduce _unsupported_imgopts that causes _notrun for specific image options. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- tests/qemu-iotests/common.rc | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/qemu-iotest

[Qemu-devel] [PULL 13/42] readline: decouple readline from the monitor

2014-01-15 Thread Kevin Wolf
From: Stefan Hajnoczi Make the readline.c functionality reusable. Instead of calling monitor_printf() and monitor_flush() directly, invoke function pointers provided by the user. This way readline.c does not know about Monitor and other users will be able to make use of readline.c. Note that t

[Qemu-devel] [PULL 18/42] blkdebug: Use errp for read_config()

2014-01-15 Thread Kevin Wolf
From: Max Reitz Use an Error variable in the read_config() function. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/blkdebug.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/block/blkdebug.c b/bloc

[Qemu-devel] [PULL 03/42] qemu-iotests: Add _unsupported_imgopts for vmdk subformats

2014-01-15 Thread Kevin Wolf
From: Fam Zheng Some cases are not applicable for vmdk subformats those don't support certain features, e.g. backing file, and some others can't run on mult-file image, e.g. monolithicFlat. This adds declaration in test cases to skip them automatically, so that iotests on vmdk can go more smoothl

[Qemu-devel] [PULL 12/42] vmdk: Fix big flat extent IO

2014-01-15 Thread Kevin Wolf
From: Fam Zheng Local variable "n" as int64_t avoids overflow with large sector number calculation. See test case change for failure case. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- block/vmdk.c | 4 +-- tests/qemu-iotests/059 | 7 + tests/qemu-iotests/059.

[Qemu-devel] [PULL 04/42] qemu-iotests: Clean up all extents for vmdk

2014-01-15 Thread Kevin Wolf
From: Fam Zheng This modifies _cleanup_test_img to remove all the extent files listed by "qemu-img info"'s format specific information. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- tests/qemu-iotests/common.rc | 17 ++--- 1 file changed, 1

[Qemu-devel] [PULL 15/42] osdep: add qemu_set_tty_echo()

2014-01-15 Thread Kevin Wolf
From: Stefan Hajnoczi Using stdin with readline.c requires disabling echo and line buffering. Add a portable wrapper to set the terminal attributes under Linux and Windows. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- include/qemu/osdep.h | 2 ++ util/oslib-posix.c | 18 +++

[Qemu-devel] [PULL 06/42] gluster: Convert aio routines into coroutines

2014-01-15 Thread Kevin Wolf
From: Bharata B Rao Convert the read, write, flush and discard implementations from aio-based ones to coroutine based ones. Signed-off-by: Bharata B Rao Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/gluster.c | 221 +++-

[Qemu-devel] [PULL 14/42] readline: move readline to a generic location

2014-01-15 Thread Kevin Wolf
From: Stefan Hajnoczi Now that the monitor and readline are decoupled, readline.h no longer belongs in include/monitor/. Put the header into include/qemu/. Move the source file into util/ so it can be linked as part of libqemuutil.a. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf -

[Qemu-devel] [PULL 10/42] qtest: Fix the bug about disable vnc causes "make check" fail

2014-01-15 Thread Kevin Wolf
From: Kewei Yu When we disable vnc from "./configure", QEMU can't use the vnc option. So qtest can't use the "vnc -none ", otherwise "make check" fails. If QEMU uses "-display none", "-vnc none" is excrescent, So we just need to drop it. Signed-off-by: Kewei Yu Reviewed-by: Paolo Bonzini Sign

[Qemu-devel] [PULL 25/42] block: Allow reference for bdrv_file_open()

2014-01-15 Thread Kevin Wolf
From: Max Reitz Allow specifying a reference to an existing block device (by name) for bdrv_file_open() instead of a filename and/or options. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block.c | 25 ++--- block/blkdebug.c

[Qemu-devel] [PULL 28/42] block: Add bdrv_open_image()

2014-01-15 Thread Kevin Wolf
From: Max Reitz Add a common function for opening images to be used for block drivers specified through BlockdevRefs in an option QDict. The difference from bdrv_file_open() is that this function may invoke bdrv_open() instead, allowing auto-detection of the driver to be used; and second, it auto

[Qemu-devel] [PULL 08/42] gluster: Add support for creating zero-filled image

2014-01-15 Thread Kevin Wolf
From: Bharata B Rao GlusterFS supports creation of zero-filled file on GlusterFS volume by means of an API called glfs_zerofill(). Use this API from QEMU to create an image that is filled with zeroes by using the preallocation option of qemu-img. qemu-img create gluster://server/volume/image -o

[Qemu-devel] [PULL 31/42] blockdev: Move "file" to legacy_opts

2014-01-15 Thread Kevin Wolf
From: Max Reitz Specifying the image filename through the "file" option is a legacy option and should not be supported by blockdev-add (in that case, giving a string for "file" references an existing block device). Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf ---

[Qemu-devel] [PULL 20/42] qdict: Add qdict_array_split()

2014-01-15 Thread Kevin Wolf
From: Max Reitz This function splits a QDict consisting of entries prefixed by incrementally enumerated indices into a QList of QDicts. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- include/qapi/qmp/qdict.h | 1 + qobject/qdict.c

[Qemu-devel] [PULL 39/42] tests: Add test for qdict_flatten()

2014-01-15 Thread Kevin Wolf
From: Max Reitz Add a test case for qdict_flatten() in tests/check-qdict.c. This test case covers the flattening of subordinate QLists as well. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- tests/check-qdict.c | 76

[Qemu-devel] [PULL 30/42] block: Allow recursive "file"s

2014-01-15 Thread Kevin Wolf
From: Max Reitz It should be possible to use a format as a driver for a file which in turn requires another file, i.e., nesting file formats. Allowing nested file formats results in e.g. qcow2 BlockDriverStates never being directly passed to bdrv_open_common() from bdrv_file_open(), but instead

[Qemu-devel] [PULL 38/42] tests: Add test for qdict_array_split()

2014-01-15 Thread Kevin Wolf
From: Max Reitz Add a test case for qdict_array_split() in tests/check-qdict.c. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- tests/check-qdict.c | 80 + 1 file changed, 80 insertions(+) diff --git a/tests/

[Qemu-devel] [PULL 21/42] qapi: extend qdict_flatten() for QLists

2014-01-15 Thread Kevin Wolf
From: Max Reitz Reversing qdict_array_split(), qdict_flatten() should flatten QLists as well by interpreting them as QDicts where every entry's key is its index. This allows bringing QDicts with QLists from QMP commands to the same form as they would be given as command-line options, thereby all

[Qemu-devel] [PULL 35/42] qapi: Add "errno" to the list of polluted words

2014-01-15 Thread Kevin Wolf
From: Max Reitz Using "errno" directly as an identifier results in various syntax errors; therefore it should be added to the list of polluted words. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- scripts/qapi.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scri

[Qemu-devel] [PULL 26/42] block: Pass reference to bdrv_file_open()

2014-01-15 Thread Kevin Wolf
From: Max Reitz With that now being possible, bdrv_open() should try to extract a block device reference from the options and pass it to bdrv_file_open(). Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block.c | 5 - 1 file changed, 4 insertions(+), 1 dele

[Qemu-devel] [PULL 29/42] block: Use bdrv_open_image() in bdrv_open()

2014-01-15 Thread Kevin Wolf
From: Max Reitz Using bdrv_open_image() instead of bdrv_file_open() directly in bdrv_open() is easier. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/block.c b/block.c index 76b6c25..9e4e85

[Qemu-devel] [PULL 33/42] blkverify: Allow command-line configuration

2014-01-15 Thread Kevin Wolf
From: Max Reitz Introduce the "test" and "raw" options for specifying images. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/blkverify.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/block/blkverify.c b/block/blkverify.c index e15

[Qemu-devel] [PULL 32/42] blkdebug: Allow command-line file configuration

2014-01-15 Thread Kevin Wolf
From: Max Reitz Introduce the "image" option as an alternative to specifying the image through the filename. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/blkdebug.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/block/blkdebug.c b/block/blkdeb

[Qemu-devel] [PULL 41/42] iotests: Test file format nesting

2014-01-15 Thread Kevin Wolf
From: Max Reitz Add a test for nested image formats. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- tests/qemu-iotests/072 | 69 ++ tests/qemu-iotests/072.out | 21 ++ tests/qemu-iotests/group | 1 + 3 files changed, 91 in

[Qemu-devel] [PULL 42/42] block: fix backing file segfault

2014-01-15 Thread Kevin Wolf
From: Peter Feiner When a backing file is opened such that (1) a protocol is directly used as the block driver and (2) the block driver has bdrv_file_open, bdrv_open_backing_file segfaults. The problem arises because bdrv_open_common returns without setting bd->backing_hd->file. To effect (1), y

[Qemu-devel] [PULL 34/42] blkverify: Don't require protocol filename

2014-01-15 Thread Kevin Wolf
From: Max Reitz If the filename is not prefixed by "blkverify:" in blkverify_parse_filename(), the blkverify driver was not selected through that protocol prefix, but by an explicit command line (or QMP) option (like driver=blkverify). If blkverify_parse_filename() has been called, a filename ha

[Qemu-devel] [PULL 27/42] block: Allow block devices without files

2014-01-15 Thread Kevin Wolf
From: Max Reitz blkdebug and blkverify will, in order to retain compatibility, not support the field "file" implicitly through bdrv_open(). In order to be able to use those drivers without giving a filename anyway, it is necessary to be able to have block devices without files implicitly opened b

[Qemu-devel] [PULL 37/42] qemu-io: Make filename optional

2014-01-15 Thread Kevin Wolf
From: Max Reitz Giving a filename is actually not essential, since it can be specified through the options as well - on the contrary: Sometimes a filename must not be given. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- qemu-io.c | 8 +--- 1 file changed,

[Qemu-devel] [Bug 1256546] Re: qemu-s390x-static: segmentation fault entering chroot

2014-01-15 Thread Ken Sharp
It certainly does! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1256546 Title: qemu-s390x-static: segmentation fault entering chroot Status in QEMU: Confirmed Status in “qemu” package in Ubuntu

[Qemu-devel] Secondary VGA passthrough not working, hitting linux kernel's pci_fixup_video

2014-01-15 Thread Sander Eikelenboom
Hi Michael / Anthony, I'm trying to do secondary VGA passthrough with on Xen for some time. The problem was that the driver would get the rom of the emulated VGA device instead of it's own rom from the rom bar. In the end I found out it is because of a "fixup" in the linux kernel, "pci_fixup_v

[Qemu-devel] [PATCH v16 6/9] module: implement module loading

2014-01-15 Thread Fam Zheng
This patch adds loading, stamp checking and initialization of modules. The init function of dynamic module is no longer directly called as __attribute__((constructor)) in static linked version, it is called only after passed the checking of presense of stamp symbol: qemu_stamp_$RELEASEHASH w

[Qemu-devel] [PATCH v16 5/9] build-sys: introduce common-obj-m and block-obj-m for DSO

2014-01-15 Thread Fam Zheng
Add necessary rules and flags for shared object generation. $(common-obj-m) will include $(block-obj-m), like $(common-obj-y) does for $(block-obj-y). The new rules introduced here are: 0) For all %.so compiling: QEMU_CFLAGS += -fPIC 1) %.o in $(common-obj-m) is compiled to %.o, then linked

[Qemu-devel] [PULL 40/42] iotests: Test new blkdebug/blkverify interface

2014-01-15 Thread Kevin Wolf
From: Max Reitz Add a test for the new blkdebug/blkverify interface. This test is not written in Python, although it uses QMP. This is because it invokes the qemu-io HMP command, which outputs errors to stderr instead of returning them through QMP. Filtering and testing that output is easier in

[Qemu-devel] [PATCH v1 1/2] tests: Add libqemustub to qom-interface-check

2014-01-15 Thread Peter Crosthwaite
The recent addition of util/error.c's dependency on error_report() causes this test to fail to link due to a number of missing monitor related symbols. All these symbols are however defined by libqemustub. Add this libary to the link. Signed-off-by: Peter Crosthwaite --- tests/Makefile | 2 +-

[Qemu-devel] [PATCH v1 2/2] Revert "error: Don't use error_report() for assertion msgs."

2014-01-15 Thread Peter Crosthwaite
This reverts commit d32934c84c72f57e78d430c22974677b7bcabe5d. The original implementation before this patch makes abortive error messages much more friendly. The underlying bug that required this change is now fixed. Revert. Signed-off-by: Peter Crosthwaite --- util/error.c | 8 1 fil

[Qemu-devel] [PULL 23/42] blkdebug: Always call read_config()

2014-01-15 Thread Kevin Wolf
From: Max Reitz Move the check whether there actually is a config file into the read_config() function. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- block/blkdebug.c | 36 +++- 1 file changed, 19 inser

[Qemu-devel] [PULL 36/42] qapi: QMP interface for blkdebug and blkverify

2014-01-15 Thread Kevin Wolf
From: Max Reitz Add structures to support blkdebug and blkverify in blockdev-add. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- qapi-schema.json | 113 +-- 1 file changed, 109 insertions(+), 4 deletions(-) diff --git a/qapi-schema.

Re: [Qemu-devel] [PATCH] Add option to disable FDC from ISA bus and ACPI on i386

2014-01-15 Thread Paolo Bonzini
Il 08/01/2014 22:09, Gabriel L. Somlo ha scritto: > On Wed, Jan 08, 2014 at 10:38:21PM +0200, Michael S. Tsirkin wrote: >>> > > +/* _STA will be patched to 0x0F if the FDC is present */ >>> > > +ACPI_EXTRACT_NAME_WORD_CONST DSDT_FDC_STA >>> > > +Name(_STA, 0xFF00) >> > >> >

[Qemu-devel] [PULL 17/42] qemu-io: add command completion

2014-01-15 Thread Kevin Wolf
From: Stefan Hajnoczi Autocomplete qemu-io commands at the interactive prompt. Note this only completes command names and not their options. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- include/qemu-io.h | 3 +++ qemu-io-cmds.c| 15 +++ qemu-io.c | 8

[Qemu-devel] [PULL 19/42] blkdebug: Don't require sophisticated filename

2014-01-15 Thread Kevin Wolf
From: Max Reitz If the filename is not prefixed by "blkdebug:" in blkdebug_parse_filename(), the blkdebug driver was not selected through that protocol prefix, but by an explicit command line option (file.driver=blkdebug or something similar). Contrary to the current reaction, this is not a probl

[Qemu-devel] [PULL 16/42] qemu-io: use readline.c

2014-01-15 Thread Kevin Wolf
From: Stefan Hajnoczi Use readline.c for command-line history. There was support for GNU Readline and BSD Editline but it was never compiled in. Since QEMU has its own readline.c, just use that when qemu-io runs with stdin attached to a terminal. Signed-off-by: Stefan Hajnoczi Signed-off-by:

Re: [Qemu-devel] [PATCH v5] rdma: rename 'x-rdma' => 'rdma'

2014-01-15 Thread Juan Quintela
mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > As far as we can tell, all known bugs have been fixed: > > 1. Parallel migrations are working > 2. IPv6 migration is working > 3. virt-test is working > > I'm not comfortable sending the revised libvirt patch > until this is accepted

Re: [Qemu-devel] [PATCH v16 6/9] module: implement module loading

2014-01-15 Thread Peter Maydell
On 15 January 2014 08:48, Fam Zheng wrote: > This patch adds loading, stamp checking and initialization of modules. > +echo "CONFIG_STAMP=`(echo $qemu_version; echo $pkgversion; cat $0) | > sha256sum - | cut -f1 -d\ `" >> $config_host_mak This fails to configure under MacOSX, I'm afraid -- ther

Re: [Qemu-devel] [PATCH v16 6/9] module: implement module loading

2014-01-15 Thread Paolo Bonzini
Il 15/01/2014 12:53, Peter Maydell ha scritto: >> > This patch adds loading, stamp checking and initialization of modules. >> > +echo "CONFIG_STAMP=`(echo $qemu_version; echo $pkgversion; cat $0) | >> > sha256sum - | cut -f1 -d\ `" >> $config_host_mak > This fails to configure under MacOSX, I'm af

Re: [Qemu-devel] [PATCH v2 1/2] hw/net: add support for Allwinner EMAC Fast Ethernet controller

2014-01-15 Thread Juan Quintela
Peter Crosthwaite wrote: > But is the saved link state meaningful? The fact that net is not > migrating means that this link_ok migrated variable is potentially > incoherent with the net layer. E.G. What happens in the following > case: > > Run QEMU > Link is Good > Save > > Run Again > Link is b

Re: [Qemu-devel] Secondary VGA passthrough not working, hitting linux kernel's pci_fixup_video

2014-01-15 Thread Michael S. Tsirkin
On Wed, Jan 15, 2014 at 11:37:29AM +0100, Sander Eikelenboom wrote: > Hi Michael / Anthony, > > I'm trying to do secondary VGA passthrough with on Xen for some time. The > problem was that the driver > would get the rom of the emulated VGA device instead of it's own rom from the > rom bar. > >

[Qemu-devel] [PULL 11/42] docs: qcow2 compat=1.1 is now the default

2014-01-15 Thread Kevin Wolf
From: Stefan Hajnoczi Commit 9117b47717ad208b12786ce88eacb013f9b3dd1c ("qcow2: Change default for new images to compat=1.1") changed the default qcow2 image format version but forgot to update qemu-doc.texi and qemu-img.texi. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake Signed-off-by

Re: [Qemu-devel] [PATCH] KVM: fix addr type for KVM_IOEVENTFD

2014-01-15 Thread Paolo Bonzini
Il 10/01/2014 08:20, Alexey Kardashevskiy ha scritto: > The @addr here is a guest physical address and can easily be bigger > than 4G. > > This changes uint32_t to hwaddr. > > Cc: Michael S. Tsirkin > Signed-off-by: Alexey Kardashevskiy > --- > > This was found during investigation why vhost i

[Qemu-devel] [PULL 22/42] qemu-option: Add qemu_config_parse_qdict()

2014-01-15 Thread Kevin Wolf
From: Max Reitz This function basically parses command-line options given as a QDict replacing a config file. For instance, the QDict {"section.opt1": 42, "section.opt2": 23} corresponds to the config file: [section] opt1 = 42 opt2 = 23 It is possible to specify multiple sections and also mult

Re: [Qemu-devel] [PATCH v1 1/2] tests: Add libqemustub to qom-interface-check

2014-01-15 Thread Igor Mammedov
On Wed, 15 Jan 2014 03:05:36 -0800 Peter Crosthwaite wrote: > The recent addition of util/error.c's dependency on error_report() > causes this test to fail to link due to a number of missing monitor > related symbols. All these symbols are however defined by libqemustub. > Add this libary to the

Re: [Qemu-devel] [PATCH v16 6/9] module: implement module loading

2014-01-15 Thread Peter Maydell
On 15 January 2014 11:56, Paolo Bonzini wrote: > Il 15/01/2014 12:53, Peter Maydell ha scritto: >>> > This patch adds loading, stamp checking and initialization of modules. >>> > +echo "CONFIG_STAMP=`(echo $qemu_version; echo $pkgversion; cat $0) | >>> > sha256sum - | cut -f1 -d\ `" >> $config_ho

Re: [Qemu-devel] [PATCH v16 6/9] module: implement module loading

2014-01-15 Thread Paolo Bonzini
Il 15/01/2014 13:03, Peter Maydell ha scritto: > >>> > This patch adds loading, stamp checking and initialization of > >>> > modules. > >>> > +echo "CONFIG_STAMP=`(echo $qemu_version; echo $pkgversion; cat $0) > >>> > | sha256sum - | cut -f1 -d\ `" >> $config_host_mak >>> >> This

[Qemu-devel] [PULL 24/42] blkdebug: Use command-line in read_config()

2014-01-15 Thread Kevin Wolf
From: Max Reitz Use qemu_config_parse_qdict() to parse the command-line options in addition to the config file. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Signed-off-by: Kevin Wolf --- block/blkdebug.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH v16 6/9] module: implement module loading

2014-01-15 Thread Alex Bligh
On 15 Jan 2014, at 12:03, Peter Maydell wrote: > Nope. There is shasum (because perl provides it) and md5 > (not md5sum). shasum -a 256 should produce the same output as sha256sum From the manpage: Since shasum uses the same interface employed by the familiar sha1sum program (and

Re: [Qemu-devel] [PATCH v16 6/9] module: implement module loading

2014-01-15 Thread Paolo Bonzini
Il 15/01/2014 13:09, Alex Bligh ha scritto: >> > Nope. There is shasum (because perl provides it) and md5 >> > (not md5sum). > shasum -a 256 should produce the same output as sha256sum > > From the manpage: > >Since shasum uses the same interface employed by the familiar sha1sum >

Re: [Qemu-devel] [PATCH v16 6/9] module: implement module loading

2014-01-15 Thread Peter Maydell
On 15 January 2014 12:05, Paolo Bonzini wrote: > Il 15/01/2014 13:03, Peter Maydell ha scritto: >> >>> > This patch adds loading, stamp checking and initialization of >> >>> > modules. >> >>> > +echo "CONFIG_STAMP=`(echo $qemu_version; echo $pkgversion; cat >> >>> > $0) | sha256s

  1   2   3   >