On 08/16/13 06:55, Alex Williamson wrote:
> Since commit 23326164 we align access sizes to match the alignment of
> the address, but we don't align the access size itself. This means we
> let illegal access sizes (ex. 3) slip through if the address is
> sufficiently aligned (ex. 4). This results
Ping then, for 1.7 :)
(Don't stone me, I don't have the slightest clue about the 1.7 backlog.
I'm fine with this being tacked to the end, just don't let it fall
through the cracks.)
Thanks
Laszlo
On 07/22/13 23:07, Laszlo Ersek wrote:
> rfc->v1:
> - addressed Paolo's comments for patches 1 and 2
于 2013-8-16 0:32, Michael Roth 写道:
Quoting Michael Roth (2013-08-15 10:23:20)
Quoting Wenchao Xia (2013-08-13 03:44:39)
于 2013-8-13 1:01, Michael Roth 写道:
Quoting Paolo Bonzini (2013-08-12 02:30:28)
1) rename AioContext to AioSource.
This is my major purpose, which declare it is not a "co
Series has been on list for more than 8 weeks (not counting the initial
PATCH RFC), and rebased twice. Right now, it still applies. Please
either merge or tell me what I need to do to get it merged. Thanks!
Markus Armbruster writes:
> All I wanted to do is exit(1) instead of abort() on guest
Hi all,
when using the released qemu-1.6.0.tar.bz2, I get the following error message:
[...]
ar: creating libfdt/libfdt.a
a - libfdt/fdt.o
a - libfdt/fdt_ro.o
a - libfdt/fdt_wip.o
a - libfdt/fdt_sw.o
a - libfdt/fdt_rw.o
a - libfdt/fdt_strerror.o
GEN qemu-options.def
GEN qmp-commands.h
Tra
On 08/16/2013 12:47 AM, Andreas Färber wrote:
> Am 15.08.2013 15:55, schrieb Alexey Kardashevskiy:
>> On 08/15/2013 09:48 PM, Andreas Färber wrote:
>>> Am 15.08.2013 13:03, schrieb Alexander Graf:
On 15.08.2013, at 12:52, Andreas Färber wrote:
> Am 15.08.2013 10:45, schrieb Alexa
于 2013-8-16 15:15, Wenchao Xia 写道:
于 2013-8-16 0:32, Michael Roth 写道:
Quoting Michael Roth (2013-08-15 10:23:20)
Quoting Wenchao Xia (2013-08-13 03:44:39)
于 2013-8-13 1:01, Michael Roth 写道:
Quoting Paolo Bonzini (2013-08-12 02:30:28)
1) rename AioContext to AioSource.
This is my major pu
On Mon, Aug 05, 2013 at 08:07:25AM -1000, Richard Henderson wrote:
> Instead of using a branch-call-branch sequence, arrange for a
> call-branch sequence, using the ARM's conditional call insn.
> This reduces the size of the slow-path within the TB, and makes
> the GETPC_EXT implementation identica
On Thu, Aug 15, 2013 at 01:44:08PM -0700, Richard Henderson wrote:
> On 08/15/2013 08:54 AM, Aurelien Jarno wrote:
> >> > # define GETRA() ((uintptr_t)__builtin_return_address(0))
> >> > -# define GETPC_LDST() ((uintptr_t)(GETRA() + 7 + \
> >> > -*(int32_t *)(
On Mon, Aug 5, 2013 at 10:11 AM, Asias He wrote:
> From: MORITA Kazutaka
>
> While Asias is debugging an issue creating qcow2 images on top of
> non-file protocols. It boils down to this example using NBD:
>
> $ qemu-io -c 'open -g nbd+unix:///?socket=/tmp/nbd.sock' -c 'read -v 0 512'
>
> Notice
On Thu, Aug 15, 2013 at 01:45:31PM -0700, Richard Henderson wrote:
> On 08/15/2013 08:54 AM, Aurelien Jarno wrote:
> > Why removing this st*_cmmu versions? There might be a good reason, but
> > it should be indicated in the patch description.
>
> Though the prototypes existed, the bodies were neve
Hi,
opened a ticket with the ceph-guys, and it turned out to be a bug in
"librados aio flush".
With latest "wip-librados-aio-flush (bobtail)" I got no error even with
_very_ high load.
Thnx for the attention ;)
Oliver.
--
You received this bug notification because you are a member of qemu-
de
Am 05.08.2013 20:07, schrieb Richard Henderson:
> Instead of using a branch-call-branch sequence, arrange for a
> call-branch sequence, using the ARM's conditional call insn.
> This reduces the size of the slow-path within the TB, and makes
> the GETPC_EXT implementation identical for TCG and not-T
Hi, all
I compared the traditional qemu-dm and upstream qemu,
and I found the upstream qemu will create the expansion ROM at f300, but
qemu-dm don't.
the details as below (by "lspci -vnnn"):
1) traditional qemu-dm:
00:02.0 VGA compatible controller [0300]: Cirrus Logic GD 5446 [1013:00b8]
(
Ping?
On 08/09/2013 06:50 PM, Alexey Kardashevskiy wrote:
> spapr-pci config space accessors use find_dev() to find a PCI device.
> However find_dev() only searched on a primary bus and did not do
> recursive search through secondary buses so config space access was not
> possible for devices oth
On 07/29/2013 04:13 PM, Alexey Kardashevskiy wrote:
> On 07/29/2013 04:08 PM, Paolo Bonzini wrote:
>> Il 29/07/2013 06:49, Alexey Kardashevskiy ha scritto:
>>> At the moment the guest kernel issues two types of task management
>>> requests to the hypervisor - task about and lun reset. This adds
>>>
On 08/07/2013 06:08 PM, Alexey Kardashevskiy wrote:
> Currently only single TCE entry per requiest is supported (H_PUT_TCE).
> However PAPR+ specification allows multiple entry requests such as
> H_PUT_TCE_INDIRECT and H_STUFFF_TCE. Having less transitions to the host
> kernel via ioctls, support o
Am 09.08.2013 10:50, schrieb Alexey Kardashevskiy:
> spapr-pci config space accessors use find_dev() to find a PCI device.
> However find_dev() only searched on a primary bus and did not do
> recursive search through secondary buses so config space access was not
> possible for devices other that o
Am 12.08.2013 19:22, schrieb Andreas Färber:
> Commit a0e372f0c49ac01faeaeb73a6e8f50e8ac615f34 reorganized the register
> counting for GDB. While it seems correct not to let the total number of
> registers skyrocket in an SMP scenario through a static variable, the
> distinction between total regis
spapr-pci config space accessors use find_dev() to find a PCI device.
However find_dev() only searched on a primary bus and did not do
recursive search through secondary buses so config space access was not
possible for devices other that on a primary bus.
This fixed find_dev() by using the PCI AP
This adds pci_cfg_read and pci_cfg_write traces for config spaces accesses.
Signed-off-by: Alexey Kardashevskiy
---
hw/pci/pci_host.c | 9 -
trace-events | 4
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c
index 7dd9b25..f1b
From: Markus Armbruster
The first five patches are admittedly related to the stated purpose of
this series pretty much only by "I can't stand perpetuating this
stupid crap". Max Filippov and Peter Maydell already cleaned up
Xtensa and ARM the same way.
v4:
* Rebase
v3:
* Rebase
* Don't screw up
From: Markus Armbruster
Don't explode when the variable is used just once, and never changed.
Signed-off-by: Markus Armbruster
Acked-by: Alexander Graf
---
hw/ppc/e500plat.c | 18 ++
hw/ppc/mpc8544ds.c | 18 ++
2 files changed, 12 insertions(+), 24 deletions(-
From: Markus Armbruster
Don't explode when the variable is used just a few times, and never
changed.
Signed-off-by: Markus Armbruster
---
hw/i386/pc_q35.c | 22 +-
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 10e77
Markus Armbruster writes:
> Anthony Liguori writes:
>
>> Markus Armbruster writes:
>>
>>> Ping?
>>
>> This needs a rebase.
>
> v3 sent.
Series has been on list for nine weeks, rebased twice, and now needs
another rebase. Just sent. Please either merge that, or tell me what I
need to do to ge
From: Markus Armbruster
Don't explode QEMUMachineInitArgs before passing it to pc_init1().
Signed-off-by: Markus Armbruster
---
hw/i386/pc_piix.c | 65 ++-
1 file changed, 16 insertions(+), 49 deletions(-)
diff --git a/hw/i386/pc_piix.c b/hw
From: Markus Armbruster
Don't explode QEMUMachineInitArgs before passing it to
sun4m_hw_init(), sun4uv_init().
Signed-off-by: Markus Armbruster
---
hw/sparc/sun4m.c | 113 -
hw/sparc64/sun4u.c | 52 +++-
2 files changed
From: Markus Armbruster
Pass on the generic arguments unadulterated, and the machine-specific
ones as separate argument.
Signed-off-by: Markus Armbruster
Acked-by: Alexander Graf
---
hw/ppc/e500.c | 35 ++-
hw/ppc/e500.h | 13 +++--
hw/ppc/e50
From: Markus Armbruster
We set default boot order "cad" in every single machine definition
except "pseries" and "moxiesim", even though very few boards actually
care for boot order, and "cad" makes sense for even fewer.
Machines that care:
* pc and its variants
Accept up to three letters 'a'
On Mon, Aug 12, 2013 at 06:53:12PM +0200, Benoît Canet wrote:
> +#ifndef THROTTLING_H
> +#define THROTTLING_H
THROTTLE_H
> +
> +#include
> +#include "qemu-common.h"
> +#include "qemu/timer.h"
> +
> +#define NANOSECONDS_PER_SECOND 10.0
> +
> +#define BUCKETS_COUNT 6
> +
> +typedef enum {
On Mon, Aug 12, 2013 at 06:53:14PM +0200, Benoît Canet wrote:
> +/* this function drain all the throttled IOs */
> +static bool bdrv_drain_throttled(BlockDriverState *bs)
> +{
> +bool drained = false;
> +bool enabled = bs->io_limits_enabled;
> +int i;
>
> -do {} while (qemu_co_ent
Resent to fix wrapping that took place.
Signed-off-by: John Arbuckle
Deciding when and how to send the command key has not been easy. A simple
protocol that this patch implements is send the command key to the guest
operating system when the mouse is grabbed. Otherwise send the command key
to QE
On Mon, Aug 12, 2013 at 06:53:15PM +0200, Benoît Canet wrote:
> The max parameter of the leaky bycket throttling algoritm can be used to
s/bycket/bucket/
s/algoritm/algorithm/
> @@ -1098,7 +1112,19 @@ void hmp_block_set_io_throttle(Monitor *mon, const
> QDict *qdict)
>
On Mon, Aug 12, 2013 at 06:53:11PM +0200, Benoît Canet wrote:
> This patchset implement continous leaky bucket throttling.
>
> It use two requests queue to enable to do silly unbalanced throttling like
> block_set_io_throttle 0 0 0 0 6000 1
>
> It use two timer to get the timer callbacks and the
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1208944
Title:
-kernel option broken for some multiboot kernels
Status in QEMU:
Fix
On Mon, Aug 12, 2013 at 06:53:16PM +0200, Benoît Canet wrote:
> diff --git a/block/qapi.c b/block/qapi.c
> index 5ba10f4..f98ff64 100644
> --- a/block/qapi.c
> +++ b/block/qapi.c
> @@ -258,6 +258,9 @@ void bdrv_query_info(BlockDriverState *bs,
> cfg.buckets[THROTTLE_OPS_WRITE].max;
Hi All,
I am using CentOS 6.3 .
I want to use qemu-1.4.0 with it ( due to dpdk_ovs requirement) .
If qemu-1.4.0 is supported with Centos 6.3 ( kernel version 2.6.32-279) ?
Thanks & Regards
Ashish
On Fri, 2013-08-16 at 09:10 +0200, Laszlo Ersek wrote:
> On 08/16/13 06:55, Alex Williamson wrote:
> > Since commit 23326164 we align access sizes to match the alignment of
> > the address, but we don't align the access size itself. This means we
> > let illegal access sizes (ex. 3) slip through i
Hi,
Please find the result of upstream testing, we ran the test cases
against following git versions:
Kernel : 3.9.5-301.fc19.x86_64
libvirt : 1.1.1
commit b9ac5d923b820a0f0152a2df56067e55ce34f487
qemu-system-x86_64 : 1.5.91
commit 2737aaafe953fc63c3387aa3ecc540b0f44c735c
Guest Kernel : 3
Since commit 23326164 we align access sizes to match the alignment of
the address, but we don't align the access size itself. This means we
let illegal access sizes (ex. 3) slip through if the address is
sufficiently aligned (ex. 4). This results in an abort which would be
easy for a guest to tri
On 16.08.2013, at 13:09, Alexey Kardashevskiy wrote:
> spapr-pci config space accessors use find_dev() to find a PCI device.
> However find_dev() only searched on a primary bus and did not do
> recursive search through secondary buses so config space access was not
> possible for devices other th
On 07.08.2013, at 10:08, Alexey Kardashevskiy wrote:
> Currently only single TCE entry per requiest is supported (H_PUT_TCE).
> However PAPR+ specification allows multiple entry requests such as
> H_PUT_TCE_INDIRECT and H_STUFFF_TCE. Having less transitions to the host
> kernel via ioctls, suppor
On Fri, 16 Aug 2013 09:59:24 +0200 (CEST)
Erik Rull wrote:
> Hi all,
>
> when using the released qemu-1.6.0.tar.bz2, I get the following error message:
>
> [...]
> ar: creating libfdt/libfdt.a
> a - libfdt/fdt.o
> a - libfdt/fdt_ro.o
> a - libfdt/fdt_wip.o
> a - libfdt/fdt_sw.o
> a - libfdt/fdt
From: Markus Armbruster
We allow either tables or fields for the same type. Makes sense,
because SeaBIOS uses fields only when no tables are present.
We do this by searching the SMBIOS blob for a previously added table
or field. Error messages look like this:
qemu-system-x86_64: -smbios t
From: Markus Armbruster
So that it can be set in config file for -readconfig.
This tightens parsing of -smbios, and makes it more consistent with
other options: unknown parameters are rejected, numbers with trailing
junk are rejected, when a parameter is given multiple times, last
rather than fi
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
hw/i386/smbios.c | 61 +++-
1 file changed, 25 insertions(+), 36 deletions(-)
diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c
index fb1b27b..a2eb9bf 100644
From: Markus Armbruster
Currently, -smbios type=T,NAME=VAL,... adds one field (T,NAME) with
value VAL to fw_cfg for each unique NAME. If NAME occurs multiple
times, the last one's VAL is used (before the QemuOpts conversion, the
first one was used).
Multiple -smbios can add multiple fields with
From: Markus Armbruster
I'd like to access QEMUMachine from a QEMUMachine init() method, which
is currently not possible. Instead of passing it as an argument, I
simply set current_machine earlier.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
vl.c | 3 +--
1 file changed, 1 i
From: Markus Armbruster
It exits on all error conditions but one, where it returns -1.
Normalize, and return void.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
arch_init.c | 4 +---
hw/i386/smbios.c | 10 +-
include/hw/i386/smbios.h | 2 +-
3 fil
From: Markus Armbruster
This gets rid of one of the last get_param_value() users, makes
multiple -smbios work sanely, cleans up the gross side effect in
qemu_uuid_parse(), and more. Topped off with a little feature in the
last patch.
v2: Rebase, only last patch had conflicts
Markus Armbruster
On 16 August 2013 08:59, Erik Rull wrote:
> Hi all,
>
> when using the released qemu-1.6.0.tar.bz2, I get the following error message:
> File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164
> except QAPISchemaError as e:
> ^
> SyntaxError: invalid syntax
> make:
On Fri, Aug 16, 2013 at 2:59 PM, Andreas Färber wrote:
> Am 12.08.2013 19:22, schrieb Andreas Färber:
>> Commit a0e372f0c49ac01faeaeb73a6e8f50e8ac615f34 reorganized the register
>> counting for GDB. While it seems correct not to let the total number of
>> registers skyrocket in an SMP scenario thr
Hi List,
Below is the mail I sent to libvirt list, but didn't get much response.
Trying here to see if someone can help provide suggestions on why
"Invalid Argument" is recd for
/var/run/vdsm/017d-1278-4bfb-8129-62bded257399
while doing the disk hotplug ?
Appreciate some response
tha
From: Markus Armbruster
Currently, we get SeaBIOS defaults: manufacturer Bochs, product Bochs,
no version. Best SeaBIOS can do, but we can provide better defaults:
manufacturer QEMU, product & version taken from QEMUMachine desc and
name.
Take care to do this only for new machine types, of cour
On 08/16/13 14:50, Alex Williamson wrote:
> Since commit 23326164 we align access sizes to match the alignment of
> the address, but we don't align the access size itself. This means we
> let illegal access sizes (ex. 3) slip through if the address is
> sufficiently aligned (ex. 4). This results
Hello everyone,in QEMU 1.5.1, block-migration.c, there is a function below:static void alloc_aio_bitmap(BlkMigDevState *bmds){ BlockDriverState *bs = bmds->bs; int64_t bitmap_size; bitmap_size = (bdrv_getlength(bs) >> BDRV_SECTOR_BITS) + BDRV_SECTORS_PER_DIRTY_CHUNK * 8 - 1;
Erik Rull writes:
> Hi all,
>
> when using the released qemu-1.6.0.tar.bz2, I get the following error message:
>
> [...]
> ar: creating libfdt/libfdt.a
> a - libfdt/fdt.o
> a - libfdt/fdt_ro.o
> a - libfdt/fdt_wip.o
> a - libfdt/fdt_sw.o
> a - libfdt/fdt_rw.o
> a - libfdt/fdt_strerror.o
> GEN
Erik Rull writes:
> Hi all,
>
> I'm struggling with the QEMU VNC on qemu-kvm-1.2.0 a bit, the following two
> things are not working properly:
Have you tried to reproduce on a current version?
Il 14/08/2013 13:21, Michael S. Tsirkin ha scritto:
On Wed, Aug 14, 2013 at 01:16:24PM +0200, Laszlo Ersek wrote:
On 08/14/13 12:54, Fabio Fantoni wrote:
Il 14/08/2013 11:56, Laszlo Ersek ha scritto:
On 08/14/13 11:19, Fabio Fantoni wrote:
Tried with qemu 1.4.2 and it works also with 4 gb of
Paolo asked me to write such a driver based on his textual specification
alone. The first patch captures his email in full, the rest re-quotes
parts that are being implemented.
The tree compiles at each patch. The series passes "make check-block".
"block/raw.c" is not removed because I wanted to
On 08/05/13 15:03, Paolo Bonzini wrote:
>
> [...]
>
> 2) This is also a simple forwarder function:
>
> .bdrv_create
>
> but there is no BlockDriverState argument so the forwarded-to function
> does not have a bs->file argument either. The forwarded-to function is
> bdrv_create_file.
Signed-of
On 08/05/13 15:03, Paolo Bonzini wrote:
>
> [...]
>
> 1) BlockDriver is a struct in which these function members are
> interesting:
>
> .bdrv_reopen_prepare
> .bdrv_co_readv
> .bdrv_co_writev
> .bdrv_co_is_allocated
> .bdrv_co_write_zeroes
> .bdrv_co_discard
> .bdrv_getl
On 08/05/13 15:03, Paolo Bonzini wrote:
>
> [...]
>
> 3) These members are special
>
> .format_name is the string "raw"
> .bdrv_open raw_open should set bs->sg to bs->file->sg and return 0
> .bdrv_closeraw_close should do nothing
> .bdrv_proberaw_probe should just retu
On 08/05/13 15:03, Paolo Bonzini wrote:
>
>
> - Original Message -
>> From: "Laszlo Ersek"
>> To: "Paolo Bonzini"
>> Sent: Monday, August 5, 2013 2:43:46 PM
>> Subject: Re: [PATCH 1/2] raw: add license header
>>
>> On 08/02/13 00:27, Paolo Bonzini wrote:
>>> On 08/01/2013 10:13 AM, Christ
On 08/05/13 15:03, Paolo Bonzini wrote:
>
> [...]
>
> 4) There is another member, .create_options, which is an array of
> QEMUOptionParameter structs, terminated by an all-zero item. The only
> option you need is for the virtual disk size. You will find something
> to copy from in other block dri
"Incoming" function prototypes and "outgoing" function calls must match
reality. Implemented using the "struct BlockDriver" definition in
"include/block/block_int.h", and gcc errors & warnings.
Signed-off-by: Laszlo Ersek
---
block/Makefile.objs |2 +-
block/raw_bsd.c | 81
On 08/05/13 15:03, Paolo Bonzini wrote:
>
> [...]
>
> 5) Formats are registered with bdrv_register (takes a BlockDriver*). You
> also need to pass the caller of bdrv_register to block_init.
Fill in the BlockDriver structure with the raw_*() functions that have
been added to "block/raw_bsd.c", in t
This patch set merges Paolo's conversion of address spaces to enable
RCU. There is one more patchset coming for TLB access that I'm
debugging right now. After I submit the last one I'll start working on
enabling RCU more widely - and the series will need to be refactored.
The series is availale on
From: Paolo Bonzini
This makes it possible to start following RCU rules, which require
not dereferencing as->dispatch more than once. It is not covering
the whole of TCG, since the TLB data structures are not RCU-friendly,
but it is enough for exec.c.
Signed-off-by: Paolo Bonzini
Reviewed-by:
From: Paolo Bonzini
Reviewed-by: Mike Day
---
aio-posix.c | 1 +
aio-win32.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/aio-posix.c b/aio-posix.c
index 562add6..7f27ea5 100644
--- a/aio-posix.c
+++ b/aio-posix.c
@@ -176,6 +176,7 @@ bool aio_poll(AioContext *ctx, bool blocking)
in
From: Paolo Bonzini
Reviewed-by: Mike Day
---
cpus.c | 3 +++
exec.c | 4 +++-
include/exec/cpu-all.h | 3 +++
3 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/cpus.c b/cpus.c
index 624658e..d6f2775 100644
--- a/cpus.c
+++ b/cpus.c
@@ -764,6 +764,7 @@
On 08/16/13 15:39, Yaodong Yang wrote:
> Hello everyone,
>
> in QEMU 1.5.1, block-migration.c, there is a function below:
>
> static void alloc_aio_bitmap(BlkMigDevState *bmds)
> {
> BlockDriverState *bs = bmds->bs;
> int64_t bitmap_size;
>
> bitmap_size = (bdrv_getlength(bs) >> BDRV
In some cases (Xen), it will not be initialized before to be used. This
leads to segv.
Signed-off-by: Anthony PERARD
---
It works with this simple initialization to NULL, but would it be
necessary (or better) to assign a proper value to this variables ?
---
hw/i386/pc_piix.c | 2 +-
1 file cha
Laszlo Ersek writes:
> Paolo asked me to write such a driver based on his textual specification
> alone. The first patch captures his email in full, the rest re-quotes
> parts that are being implemented.
>
> The tree compiles at each patch. The series passes "make check-block".
>
> "block/raw.c"
On Fri, Aug 16, 2013 at 09:59:07AM -0500, Anthony Liguori wrote:
> Laszlo Ersek writes:
>
> > Paolo asked me to write such a driver based on his textual specification
> > alone. The first patch captures his email in full, the rest re-quotes
> > parts that are being implemented.
> >
> > The tree c
On Thu, Aug 15, 2013 at 09:34:08PM +0100, Alex Bligh wrote:
> [ This patch set is available from git at:
>https://github.com/abligh/qemu/tree/aio-timers11
> As autogenerated patch 30 of the series is too large for the mailing list. ]
>
> This patch series adds support for timers attached to an
Hello Laszlo,
Thank you very much for your very informative answer! It makes me understood
totally about the bitmap calculation.
Thanks again!
Yaodong
On Aug 16, 2013, at 9:45 AM, Laszlo Ersek wrote:
> On 08/16/13 15:39, Yaodong Yang wrote:
>> Hello everyone,
>>
>> in QEMU 1.5.1, block-mig
On 08/16/2013 05:50 AM, Alex Williamson wrote:
> +/* Size must be a power of 2 */
> +if (l & (l - 1)) {
> +while (l & (access_size_max - 1)) {
> +access_size_max >>= 1;
> +}
> +}
> +
Why the loop at all? x & -x extracts the lsb of x.
r~
Am 16.08.2013 16:41, schrieb Mike Day:
> This patch set merges Paolo's conversion of address spaces to enable
> RCU. There is one more patchset coming for TLB access that I'm
> debugging right now. After I submit the last one I'll start working on
> enabling RCU more widely - and the series will ne
On Thu, Jul 25, 2013 at 04:22:58PM +0200, Paolo Bonzini wrote:
> This series adds a subcommand to "map" that can dump file metadata.
> Metadata that is dumped includes:
>
> - whether blocks are allocated in bs->file and, if so, where
>
> - whether blocks are zero
>
> - whether data is read from
On Wed, Aug 07, 2013 at 11:00:11AM +0800, Wenchao Xia wrote:
> v6:
> Address Stefan's comments:
> 2/8: macro STR_PRINT_CHAR was renamed as STR_OR_NULL, and moved into patch
> 5,
> since implement function in this patch do not printf snapshot id any more, as
> Kevin's suggestion.
Great.
> A
Stefan,
On 16 Aug 2013, at 16:24, Stefan Hajnoczi wrote:
> Please run qemu-iotests on this series and fix any failures. It is
> failing with "I/O thread has spun for 1000 iterations".
It does that without my patch. Below is the iterative build log for
each revision being added (I've snipped all
On Fri, 2013-08-16 at 08:27 -0700, Richard Henderson wrote:
> On 08/16/2013 05:50 AM, Alex Williamson wrote:
> > +/* Size must be a power of 2 */
> > +if (l & (l - 1)) {
> > +while (l & (access_size_max - 1)) {
> > +access_size_max >>= 1;
> > +}
> > +}
> > +
On Fri, 2013-08-16 at 09:37 -0600, Alex Williamson wrote:
> On Fri, 2013-08-16 at 08:27 -0700, Richard Henderson wrote:
> > On 08/16/2013 05:50 AM, Alex Williamson wrote:
> > > +/* Size must be a power of 2 */
> > > +if (l & (l - 1)) {
> > > +while (l & (access_size_max - 1)) {
> >
On Fri, 2013-08-16 at 09:43 -0600, Alex Williamson wrote:
> On Fri, 2013-08-16 at 09:37 -0600, Alex Williamson wrote:
> > On Fri, 2013-08-16 at 08:27 -0700, Richard Henderson wrote:
> > > On 08/16/2013 05:50 AM, Alex Williamson wrote:
> > > > +/* Size must be a power of 2 */
> > > > +if (l
In bdrv_delete() make sure to call bdrv_make_anon() *after* bdrv_close()
so that the device is still seen by bdrv_drain_all() when iterating
bdrv_states.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Stefan Hajnoczi
---
block.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/
fatal: Needed a single revision
The following changes since commit f202039811d8746b0586d2fd5f61de6c8cf68056:
Open up 1.7 development branch (2013-08-15 15:41:13 -0500)
are available in the git repository at:
git://github.com/stefanha/qemu.git block-next
for you to fetch changes up to ab97be
.io_flush() is no longer called so drop have_co_req() and
aio_flush_request().
Signed-off-by: Stefan Hajnoczi
---
block/sheepdog.c | 25 +
1 file changed, 5 insertions(+), 20 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index afe0533..3fb4361 100644
---
If a block driver has no file descriptors to monitor but there are still
active requests, it can return 1 from .io_flush(). This is used to spin
during synchronous I/O.
Stop relying on .io_flush() and instead check
QLIST_EMPTY(&bs->tracked_requests) to decide whether there are active
requests.
T
aio_poll(ctx, true) will soon block if any fd handlers have been set.
Previously it would only block when .io_flush() returned true.
This means that callers must check their wait condition *before*
aio_poll() to avoid deadlock.
Reviewed-by: Paolo Bonzini
Signed-off-by: Stefan Hajnoczi
---
test
Now that aio_poll() users check their termination condition themselves,
it is no longer necessary to call .io_flush() handlers.
The behavior of aio_poll() changes as follows:
1. .io_flush() is no longer invoked and file descriptors are *always*
monitored. Previously returning 0 from .io_flush()
.io_flush() is no longer called so drop nbd_have_request(). We cannot
drop in_flight since it is still used by other block/nbd.c code.
Signed-off-by: Stefan Hajnoczi
---
block/nbd.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
inde
Check exit conditions before entering blocking aio_poll(). This is
mainly for consistency since it's unlikely that we are stopping in the
first event loop iteration.
Signed-off-by: Stefan Hajnoczi
---
hw/block/dataplane/virtio-blk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
dif
.io_flush() is no longer called so drop thread_pool_active(). The block
layer is the only thread-pool.c user and it already tracks in-flight
requests, therefore we do not need thread_pool_active().
Signed-off-by: Stefan Hajnoczi
---
thread-pool.c | 8 +---
1 file changed, 1 insertion(+), 7
.io_flush() is no longer called so drop curl_aio_flush(). The acb[]
array that the function checks is still used in other parts of
block/curl.c. Therefore we cannot remove acb[], it is needed.
Signed-off-by: Stefan Hajnoczi
---
block/curl.c | 22 +++---
1 file changed, 3 insert
Since .io_flush() is no longer called we do not need
qemu_gluster_aio_flush_cb() anymore. It turns out that qemu_aio_count
is unused now and can be dropped.
Signed-off-by: Stefan Hajnoczi
---
block/gluster.c | 16 +---
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/bl
.io_flush() is no longer called so drop iscsi_process_flush().
Signed-off-by: Stefan Hajnoczi
---
block/iscsi.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index e7c1c2b..180b827 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -146,
.io_flush() is no longer called so drop qemu_laio_completion_cb(). It
turns out that count is now unused so drop that too.
Signed-off-by: Stefan Hajnoczi
---
block/linux-aio.c | 17 ++---
1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/block/linux-aio.c b/block/linux-
.io_flush() is no longer called so drop qemu_rbd_aio_flush_cb().
qemu_aio_count is unused now so drop it too.
Signed-off-by: Stefan Hajnoczi
---
block/rbd.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index cb71751..71b4a0c 100644
.io_flush() is no longer called so drop return_true().
Signed-off-by: Stefan Hajnoczi
---
block/ssh.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index d7e7bf8..e149da9 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -740,14 +740,6 @@ sta
1 - 100 of 188 matches
Mail list logo
