On Mon, Aug 12, 2013 at 06:53:16PM +0200, Benoît Canet wrote: > diff --git a/block/qapi.c b/block/qapi.c > index 5ba10f4..f98ff64 100644 > --- a/block/qapi.c > +++ b/block/qapi.c > @@ -258,6 +258,9 @@ void bdrv_query_info(BlockDriverState *bs, > cfg.buckets[THROTTLE_OPS_WRITE].max; > info->inserted->iops_wr_max = > cfg.buckets[THROTTLE_OPS_WRITE].max; > + > + info->inserted->has_iops_sector_count = cfg.op_size; > + info->inserted->iops_sector_count = cfg.op_size;
Why introduce the concept of sectors here? Throttling uses bytes and that will help prevent confusion if the user has 4 KB sector disks, for example, instead of 512 bytes.