[Qemu-devel] [PATCH V2 1/5] Refine and export infinite loop checking in collect_image_info_list()

2013-07-08 Thread Xu Wang
Signed-off-by: Xu Wang --- block.c | 101 ++ include/block/block.h | 4 ++ qemu-img.c| 30 +-- 3 files changed, 114 insertions(+), 21 deletions(-) diff --git a/block.c b/block.c index b88ad2f..53b1a01 100644

[Qemu-devel] [PATCH V2 0/5] Add infinite loop check for backing file chain

2013-07-08 Thread Xu Wang
Updates: 1. Changed infinite loop check in collect_image_info_list() from filename checking to inode checking. 2. Absolute or relative path is OK for filename path. 3. Hard and soft link are works well. 4. Added WIN32 platform support (shortcuts could be recognized correctly.) 5. Cre

[Qemu-devel] [PATCH V2 4/5] Add backing file loop check in change_backing_file()

2013-07-08 Thread Xu Wang
Signed-off-by: Xu Wang --- block.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block.c b/block.c index 6df25d9..379b79b 100644 --- a/block.c +++ b/block.c @@ -1971,6 +1971,12 @@ int bdrv_change_backing_file(BlockDriverState *bs, return -EINVAL; } +/* Check if loo

[Qemu-devel] [PATCH V2 2/5] Add WIN32 platform support for backing_file_loop_check()

2013-07-08 Thread Xu Wang
Signed-off-by: Xu Wang --- block.c | 94 + 1 file changed, 94 insertions(+) diff --git a/block.c b/block.c index 53b1a01..8dc6ded 100644 --- a/block.c +++ b/block.c @@ -4431,6 +4431,83 @@ bdrv_acct_done(BlockDriverState *bs, BlockAc

[Qemu-devel] [PATCH V2 3/5] Check infinite loop in bdrv_img_create()

2013-07-08 Thread Xu Wang
Signed-off-by: Xu Wang --- block.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index 8dc6ded..6df25d9 100644 --- a/block.c +++ b/block.c @@ -4688,15 +4688,15 @@ void bdrv_img_create(const char *filename, const char *fmt, } backing_

[Qemu-devel] [PATCH V2 5/5] Add infinite loop check in drive_init()

2013-07-08 Thread Xu Wang
Signed-off-by: Xu Wang --- blockdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/blockdev.c b/blockdev.c index 5975dde..0178764 100644 --- a/blockdev.c +++ b/blockdev.c @@ -695,6 +695,11 @@ DriveInfo *drive_init(QemuOpts *all_opts, BlockInterfaceType block_default_type) er

Re: [Qemu-devel] [PATCH 1/2] Refine and export infinite loop checking in collect_image_info_list()

2013-07-08 Thread Xu Wang
2013/6/29 Eric Blake > On 06/27/2013 01:38 AM, Xu Wang wrote: > > From: Xu Wang > > > > Signed-off-by: Xu Wang > > --- > > qemu-img.c | 110 > + > > 1 file changed, 89 insertions(+), 21 deletions(-) > > > > > +/** > > + * Check backin

[Qemu-devel] QEMU live block-migration

2013-07-08 Thread Yaodong Yang
Hello everyone, I have a short question about the implementation of QEMU. When the qemu perform the live block migration using "migrate -b tcp:" command. Does a new thread for migration created or not? I went through the code, only find that this activity is triggered in the main loop (main_lo

Re: [Qemu-devel] [PATCH v4 00/11] Fix versatile_pci

2013-07-08 Thread Peter Maydell
On 8 July 2013 07:43, Rob Landley wrote: > On 06/29/2013 06:03:26 AM, Peter Maydell wrote: >> The "with the patch" case is uninteresting, because it's not >> actually a fix for anything, it's just a change that happened >> to work with old QEMU, and it's not a change that is in upstream >> Linux.

[Qemu-devel] [PATCH V4 1/9] snapshot: new function bdrv_snapshot_find_by_id_and_name()

2013-07-08 Thread Wenchao Xia
To make it clear about id and name in searching, add this API to distinguish them. Caller can choose to search by id or name, *errp will be set only for exception. Some code are modified based on Pavel's patch. Signed-off-by: Wenchao Xia Signed-off-by: Pavel Hrdina --- block/snapshot.c

[Qemu-devel] [PATCH V4 0/9] add internal snapshot support at block device level

2013-07-08 Thread Wenchao Xia
This series brings internal snapshot support at block devices level, now we have two three methods to do block snapshot lively: 1) backing chain, 2) internal one and 3) drive-back up approach. Comparation: Advantages:Disadvantages: 1)delta data, taken

[Qemu-devel] [PATCH V4 2/9] snapshot: add paired functions for internal snapshot id and name

2013-07-08 Thread Wenchao Xia
Internal snapshot's ID and name concept are both visible in general block level, they are observed by user in "info snapshots", so it is possible to have conflict. Although we can separate the two concept in programming, but if they can be distinguished in string itself, things will be simple and c

[Qemu-devel] [PATCH V4 7/9] hmp: add interface hmp_snapshot_blkdev_internal

2013-07-08 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- hmp-commands.hx | 19 +-- hmp.c | 10 ++ hmp.h |1 + 3 files changed, 28 insertions(+), 2 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 915b0d1..53e3ef3 100644 --- a/hmp-commands.hx +++ b/hmp-c

[Qemu-devel] [PATCH V4 3/9] snapshot: distinguish id and name in snapshot delete

2013-07-08 Thread Wenchao Xia
Snapshot creation actually already distinguish id and name since it take a structured parameter *sn, but delete can't. Later an accurate delete is needed in qmp_transaction abort and blockdev-snapshot-delete-sync, so change its prototype. Also *errp is added to tip error, but return value is kepted

[Qemu-devel] [PATCH V4 9/9] qemu-iotests: add 056 internal snapshot for block device test case

2013-07-08 Thread Wenchao Xia
Create in transaction and deletion in single command will be tested. Signed-off-by: Wenchao Xia --- tests/qemu-iotests/056 | 267 tests/qemu-iotests/056.out |5 + tests/qemu-iotests/group |1 + 3 files changed, 273 insertions(+), 0 dele

[Qemu-devel] [PATCH V4 4/9] qmp: add internal snapshot support in qmp_transaction

2013-07-08 Thread Wenchao Xia
Unlike savevm, the qmp_transaction interface will not generate snapshot name automatically, saving trouble to return information of the new created snapshot. The snapshot name should not collide with snapshot ID, there is a check for it. Although qcow2 support storing multiple snapshots with same

[Qemu-devel] [PATCH V4 8/9] hmp: add interface hmp_snapshot_delete_blkdev_internal

2013-07-08 Thread Wenchao Xia
It is hard to make both id and name optional in hmp console as qmp interface, so this interface require user to specify name. Signed-off-by: Wenchao Xia --- hmp-commands.hx | 18 ++ hmp.c | 12 hmp.h |1 + 3 files changed, 31 insertions(+)

[Qemu-devel] [PATCH V4 5/9] qmp: add interface blockdev-snapshot-internal-sync

2013-07-08 Thread Wenchao Xia
Snapshot ID can't be specified in this interface. Signed-off-by: Wenchao Xia --- blockdev.c | 13 + qapi-schema.json | 22 ++ qmp-commands.hx | 30 ++ 3 files changed, 65 insertions(+), 0 deletions(-) diff --git a/blockdev

[Qemu-devel] [PATCH V4 6/9] qmp: add interface blockdev-snapshot-delete-internal-sync

2013-07-08 Thread Wenchao Xia
This interface use id and name as optional parameters, to handle the case that one image contain multiple snapshots with same name which may be '', but with different id. Adding parameter id is for historical compatiability reason, and that case is not possible in qemu's new interface for internal

Re: [Qemu-devel] [PATCH 28/66] exec: reorganize address_space_map

2013-07-08 Thread Peter Maydell
On 4 July 2013 16:13, Paolo Bonzini wrote: > -rlen = todo; > -ret = qemu_ram_ptr_length(raddr, &rlen); > -*plen = rlen; > -return ret; > + > +*plen = done; > +return qemu_ram_ptr_length(raddr + base, plen); This change provokes a warning from clang on MacOSX: CCarm-

[Qemu-devel] [Qeustion] USB passthough doesn't work on Windows.

2013-07-08 Thread Geunhae Lee
hi, i have questions about USB passthrough . it seems that host usb passthrough is not working on Windows/Mac (as host) is there any work-around solution for that? or is there some patches out there? thank you.

Re: [Qemu-devel] [PATCH 1/7] block: Convert BlockDriverState.in_use to refcount

2013-07-08 Thread Fam Zheng
On Tue, 07/02 12:21, Paolo Bonzini wrote: > Il 02/07/2013 07:59, Fam Zheng ha scritto: > > Use numeric value to replace in_use flag in BDS, this will make > > lifecycle management with ref count possible. This patch only replaces > > existing uses of bdrv_set_in_use, so no logic change here. > > T

[Qemu-devel] [PATCH] exec.c: Pass correct pointer type to qemu_ram_ptr_length

2013-07-08 Thread Peter Maydell
Commit e3127ae0 introduced a problem where we're passing a hwaddr* to qemu_ram_ptr_length() but it wants a ram_addr_t*; this will cause problems on 32 bit hosts and in any case provokes a clang warning on MacOSX: CCarm-softmmu/exec.o exec.c:2164:46: warning: incompatible pointer types passin

Re: [Qemu-devel] [PATCH 18/19] target-ppc: Enhance the CPU node labels for the guest device tree for pseries.

2013-07-08 Thread Andreas Färber
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 08.07.2013 03:09, schrieb David Gibson: > On Sat, Jul 06, 2013 at 11:54:15PM +1000, Alexey Kardashevskiy > wrote: >> @@ -1342,6 +1346,13 @@ static void >> ppc_spapr_init(QEMUMachineInitArgs *args) >> register_savevm_live(NULL, "spapr/htab", -1, 1,

[Qemu-devel] [PATCH] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-08 Thread Fabio Fantoni
Usage: usb=0|1|2|3 (default=0) Enables and specifies the type of an emulated USB bus in the guest. 0 for none, 1 for usb1, 2 for usb2 and 3 for usb3. Usb2 and usb3 only for upstream qemu. Signed-off-by: Fabio Fantoni --- docs/man/xl.cfg.pod.5 |6 -- tools/libxl/libxl_create.c |

Re: [Qemu-devel] [Qeustion] USB passthough doesn't work on Windows.

2013-07-08 Thread Andreas Färber
Hi, Am 08.07.2013 10:25, schrieb Geunhae Lee: > hi, > i have questions about USB passthrough . > > it seems that host usb passthrough is not working on Windows/Mac (as host) > > is there any work-around solution for that? > or > is there some patches out there? Your question is lacking too

Re: [Qemu-devel] [PATCH v3] linux-user: improve target_to_host_sock_type conversion

2013-07-08 Thread Petar Jovanovic
ping http://patchwork.ozlabs.org/patch/255998/ Riku, can you integrate this change? Thank you. Petar From: Peter Maydell [peter.mayd...@linaro.org] Sent: Tuesday, July 02, 2013 3:44 PM To: Petar Jovanovic Cc: qemu-devel@nongnu.org; Petar Jovanovic; aurel..

Re: [Qemu-devel] [PATCH v2] target-mips: fix mipsdsp_trunc16_sat16_round

2013-07-08 Thread Petar Jovanovic
ping http://patchwork.ozlabs.org/patch/255967/ From: Richard Henderson [rth7...@gmail.com] on behalf of Richard Henderson [r...@twiddle.net] Sent: Monday, July 01, 2013 4:52 PM To: Petar Jovanovic Cc: qemu-devel@nongnu.org; Petar Jovanovic; aurel...@aurel3

Re: [Qemu-devel] [PATCH] target-mips: fix multiplication in mipsdsp_rndq15_mul_q15_q15

2013-07-08 Thread Petar Jovanovic
ping http://patchwork.ozlabs.org/patch/245990/ From: Richard Henderson [rth7...@gmail.com] on behalf of Richard Henderson [r...@twiddle.net] Sent: Thursday, June 27, 2013 8:26 PM To: Petar Jovanovic Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurel...@aur

Re: [Qemu-devel] [PATCH V2 1/2] Implement sync modes for drive-backup.

2013-07-08 Thread Fam Zheng
Great work! The patch looks good for me, I made two trivial style comments (if you respin, you can check your patches for style problems by running scripts/checkpatch.pl). On Fri, 07/05 18:35, Ian Main wrote: > This patch adds sync-modes to the drive-backup interface and > implements the FULL, NON

Re: [Qemu-devel] [PATCH V1 1/2] Implement sync modes for drive-backup.

2013-07-08 Thread Fam Zheng
On Mon, 07/01 14:16, Paolo Bonzini wrote: > Il 28/06/2013 04:28, Ian Main ha scritto: > > diff --git a/blockdev.c b/blockdev.c > > index c5abd65..000dea6 100644 > > --- a/blockdev.c > > +++ b/blockdev.c > > @@ -1430,17 +1430,13 @@ void qmp_drive_backup(const char *device, const > > char *target, >

Re: [Qemu-devel] [PATCH v5 02/14] Add SIZE type to qdev properties

2013-07-08 Thread Andreas Färber
Am 26.06.2013 11:13, schrieb Hu Tao: > From: Vasilis Liaskovitis > > This patch adds a 'SIZE' type property to qdev. > > It will make dimm description more convenient by allowing sizes to be > specified > with K,M,G,T prefixes instead of number of bytes e.g.: > -device dimm,id=mem0,size=2G,bus=

Re: [Qemu-devel] [PATCH] target-mips: fix branch in likely delay slot tcg assert

2013-07-08 Thread Yongbok Kim
Ping! http://lists.gnu.org/archive/html/qemu-devel/2013-06/msg04259.html Regards, Yongbok -Original Message- From: Yongbok Kim Sent: 24 June 2013 17:46 To: qemu-devel@nongnu.org Cc: aurel...@aurel32.net; Leon Alrae; Cristian Cuna; James Hogan; Yongbok Kim Subject: [PATCH] target-mips:

Re: [Qemu-devel] [Xen-devel] [PATCH] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-08 Thread Wei Liu
On Mon, Jul 08, 2013 at 11:13:00AM +0200, Fabio Fantoni wrote: > Usage: usb=0|1|2|3 (default=0) > Enables and specifies the type of an emulated USB bus in the guest. > 0 for none, 1 for usb1, 2 for usb2 and 3 for usb3. Usb2 and usb3 > only for upstream qemu. > > Signed-off-by: Fabio Fantoni > ---

Re: [Qemu-devel] [PATCH v5 00/14] ACPI memory hotplug

2013-07-08 Thread Andreas Färber
Am 26.06.2013 11:13, schrieb Hu Tao: > It's been quite a while since v4 and lots of changes happend > in qemu and v4 just can't apply anymore. So this series is > basically a rebase. Another purpose is to bring up discussions > to make consensus on some questions since v4, see > http://lists.gnu.or

Re: [Qemu-devel] [PATCH] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-08 Thread Fabio Fantoni
Il 08/07/2013 11:13, Fabio Fantoni ha scritto: Usage: usb=0|1|2|3 (default=0) Enables and specifies the type of an emulated USB bus in the guest. 0 for none, 1 for usb1, 2 for usb2 and 3 for usb3. Usb2 and usb3 only for upstream qemu. Signed-off-by: Fabio Fantoni --- docs/man/xl.cfg.pod.5

Re: [Qemu-devel] [Xen-devel] [PATCH] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-08 Thread Fabio Fantoni
Il 08/07/2013 11:44, Wei Liu ha scritto: On Mon, Jul 08, 2013 at 11:13:00AM +0200, Fabio Fantoni wrote: Usage: usb=0|1|2|3 (default=0) Enables and specifies the type of an emulated USB bus in the guest. 0 for none, 1 for usb1, 2 for usb2 and 3 for usb3. Usb2 and usb3 only for upstream qemu. Sig

Re: [Qemu-devel] [PATCH v3] KVM: nVMX: Fix read/write to MSR_IA32_FEATURE_CONTROL

2013-07-08 Thread Gleb Natapov
On Sun, Jul 07, 2013 at 11:07:33PM +0800, Arthur Chunqi Li wrote: > Fix read/write to IA32_FEATURE_CONTROL MSR in nested environment. > > This patch simulate this MSR in nested_vmx and the default value is > 0x0. BIOS should set it to 0x5 before VMXON. After setting the lock > bit, write to it wil

[Qemu-devel] [PATCH v4] KVM: nVMX: Fix read/write to MSR_IA32_FEATURE_CONTROL

2013-07-08 Thread Arthur Chunqi Li
From: Nadav Har'El Fix read/write to IA32_FEATURE_CONTROL MSR in nested environment. This patch simulate this MSR in nested_vmx and the default value is 0x0. BIOS should set it to 0x5 before VMXON. After setting the lock bit, write to it will cause #GP(0). Another QEMU patch is also needed to h

Re: [Qemu-devel] [PATCH 09/15] target-i386: move hyperv_* static globals to CPUState

2013-07-08 Thread Andreas Färber
Am 05.06.2013 15:18, schrieb Igor Mammedov: > - since hyperv_* helper functions are used only in target-i386/kvm.c > move them there as static helpers > > Signed-off-by: Igor Mammedov > Requestd-By: Eduardo Habkost > --- > target-i386/Makefile.objs |2 +- > target-i386/cpu.c | 1

[Qemu-devel] [PATCH v2] pseries: rework PAPR virtual SCSI

2013-07-08 Thread Alexey Kardashevskiy
The patch reimplements handling of indirect requests in order to simplify upcoming live migration support. - all pointers (except SCSIRequest*) were replaces with integer indexes and offsets; - DMA'ed srp_direct_buf kept untouched (ie. BE format); - vscsi_fetch_desc() is added, now it is the only p

[Qemu-devel] 回复: Re: 回复: Re: 回复: Re: Which part of qemu responds to ACPI control method?

2013-07-08 Thread bobooscar
To laszlo: unfortunitely, thereˊs no _S3, _S4, _S5 either. Back to the *actual* question, the exact problem is as follows: 1 We found that the guest os(rhel 6.1) got stuck(suspended) for about 30-60 seconds after it migrates from host A to host B. 2 such problem doesnˊt occur with guest os rhel6.

Re: [Qemu-devel] [PATCH qom-cpu v9] target-i386: Move hyperv_* static globals to X86CPU

2013-07-08 Thread Igor Mammedov
On Mon, 8 Jul 2013 03:03:54 +0200 Andreas Färber wrote: > From: Igor Mammedov > > - since hyperv_* helper functions are used only in target-i386/kvm.c > move them there as static helpers > > Requested-by: Eduardo Habkost > Signed-off-by: Igor Mammedov > Signed-off-by: Andreas Färber I'm

Re: [Qemu-devel] [PATCH 09/15] target-i386: move hyperv_* static globals to CPUState

2013-07-08 Thread Igor Mammedov
On Mon, 08 Jul 2013 13:48:55 +0200 Andreas Färber wrote: > Am 05.06.2013 15:18, schrieb Igor Mammedov: > > - since hyperv_* helper functions are used only in target-i386/kvm.c > > move them there as static helpers > > > > Signed-off-by: Igor Mammedov > > Requestd-By: Eduardo Habkost > > ---

Re: [Qemu-devel] [PATCH 0/8] Add virtio-mmio and use it in vexpress

2013-07-08 Thread Alexander Graf
On 27.06.2013, at 15:04, Peter Maydell wrote: > This patch series adds an implementation of the virtio-mmio > transport, and uses it in the vexpress-a9 and vexpress-a15 > board models. > > The basic idea is that the board instantiates some transports, I really dislike that idea. Couldn't you al

Re: [Qemu-devel] [PATCH 0/8] Add virtio-mmio and use it in vexpress

2013-07-08 Thread Alexander Graf
On 08.07.2013, at 14:57, Alexander Graf wrote: > > On 27.06.2013, at 15:04, Peter Maydell wrote: > >> This patch series adds an implementation of the virtio-mmio >> transport, and uses it in the vexpress-a9 and vexpress-a15 >> board models. >> >> The basic idea is that the board instantiates s

Re: [Qemu-devel] 回复: Re: 回复: Re: 回复: Re: Which part of qemu responds to ACPI control method?

2013-07-08 Thread Laszlo Ersek
On 07/08/13 14:24, bobooscar wrote: > To laszlo: unfortunitely, thereˊs no _S3, _S4, _S5 either. > > Back to the *actual* question, the exact problem is as follows: > 1 We found that the guest os(rhel 6.1) got stuck(suspended) for about > 30-60 seconds after it migrates from host A to host B. > 2

Re: [Qemu-devel] [PATCH 0/8] Add virtio-mmio and use it in vexpress

2013-07-08 Thread Alexander Graf
On 08.07.2013, at 15:08, Peter Maydell wrote: > On 8 July 2013 13:59, Alexander Graf wrote: >> On 08.07.2013, at 14:57, Alexander Graf wrote: >>> On 27.06.2013, at 15:04, Peter Maydell wrote: The basic idea is that the board instantiates some transports, >>> >>> I really dislike that idea.

Re: [Qemu-devel] [PULL 00/66] Memory API changes for 1.6: ownership, I/O ports, RCU preparation

2013-07-08 Thread Anthony Liguori
Paolo Bonzini writes: > Il 04/07/2013 17:12, Paolo Bonzini ha scritto: >> Anthony, >> >> the following changes since commit 1acd5a373905ddb28957842256a038956941f332: >> >> Merge remote-tracking branch 'agraf/ppc-for-upstream' into staging >> (2013-07-01 09:03:04 -0500) >> >> are available i

Re: [Qemu-devel] [PATCH 0/8] Add virtio-mmio and use it in vexpress

2013-07-08 Thread Peter Maydell
On 8 July 2013 13:59, Alexander Graf wrote: > On 08.07.2013, at 14:57, Alexander Graf wrote: >> On 27.06.2013, at 15:04, Peter Maydell wrote: >>> The basic idea is that the board instantiates some transports, >> >> I really dislike that idea. Couldn't you also create a new >> bus for your vexpress

Re: [Qemu-devel] [PATCH 0/8] Add virtio-mmio and use it in vexpress

2013-07-08 Thread Peter Maydell
On 8 July 2013 14:16, Alexander Graf wrote: > > On 08.07.2013, at 15:08, Peter Maydell wrote: > >> On 8 July 2013 13:59, Alexander Graf wrote: >>> On 08.07.2013, at 14:57, Alexander Graf wrote: On 27.06.2013, at 15:04, Peter Maydell wrote: > The basic idea is that the board instantiates

Re: [Qemu-devel] [PATCH 0/8] Add virtio-mmio and use it in vexpress

2013-07-08 Thread Alexander Graf
On 08.07.2013, at 15:23, Peter Maydell wrote: > On 8 July 2013 14:16, Alexander Graf wrote: >> >> On 08.07.2013, at 15:08, Peter Maydell wrote: >> >>> On 8 July 2013 13:59, Alexander Graf wrote: On 08.07.2013, at 14:57, Alexander Graf wrote: > On 27.06.2013, at 15:04, Peter Maydell w

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Anthony Liguori
Stefano Stabellini writes: > On Thu, 4 Jul 2013, Paul Durrant wrote: >> Introduces a new Xen PV PCI device which will act as a binding point for >> PV drivers for Xen. >> The device has parameterized vendor-id, device-id and revision to allow to >> be configured as a binding point for any vendor'

Re: [Qemu-devel] [PATCH 0/8] Add virtio-mmio and use it in vexpress

2013-07-08 Thread Peter Maydell
On 8 July 2013 14:45, Alexander Graf wrote: > On 08.07.2013, at 15:23, Peter Maydell wrote: >> Now I'm completely confused. Why would assigned devices >> have anything to do with this? Can you explain in more >> detail, because I don't really see what you're suggesting? > > The only missing link w

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Anthony Liguori
Paul Durrant writes: > Introduces a new Xen PV PCI device which will act as a binding point for > PV drivers for Xen. > The device has parameterized vendor-id, device-id and revision to allow to > be configured as a binding point for any vendor's PV drivers. > > Signed-off-by: Paul Durrant > Cc:

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Peter Maydell
On 8 July 2013 15:04, Anthony Liguori wrote: > (Just a nit and responding because this happens commonly). > > You probably mean Reviewed-by. Acked-by really means, "I am not the > maintainer of this area, I have not reviewed this patch, but I am > generally okay with the idea as best I can tell."

Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install'

2013-07-08 Thread Tomoki Sekiyama
On 7/8/13 9:58 , "Laszlo Ersek" wrote: >On 07/05/13 19:06, Tomoki Sekiyama wrote: >> On 7/4/13 8:54 , "Paolo Bonzini" wrote: >> >>> Il 03/07/2013 18:19, Tomoki Sekiyama ha scritto: On 7/3/13 11:58 , "Paolo Bonzini" wrote: > Il 03/07/2013 17:49, Tomoki Sekiyama ha scritto: >>

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Alex Bligh
--On 8 July 2013 15:10:49 +0100 Peter Maydell wrote: You probably mean Reviewed-by. Acked-by really means, "I am not the maintainer of this area, I have not reviewed this patch, but I am generally okay with the idea as best I can tell." Don't you mean "I *am* the maintainer of this area"

Re: [Qemu-devel] [PATCH V5 0/7] monitor: support sub command group in auto completion and help

2013-07-08 Thread Luiz Capitulino
On Mon, 08 Jul 2013 06:39:52 +0800 Wenchao Xia wrote: > Any comments for it? I should review it shortly.

Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install'

2013-07-08 Thread Laszlo Ersek
On 07/05/13 19:06, Tomoki Sekiyama wrote: > On 7/4/13 8:54 , "Paolo Bonzini" wrote: > >> Il 03/07/2013 18:19, Tomoki Sekiyama ha scritto: >>> On 7/3/13 11:58 , "Paolo Bonzini" wrote: >>> Il 03/07/2013 17:49, Tomoki Sekiyama ha scritto: > -return ga_install_service(path,

Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install'

2013-07-08 Thread Laszlo Ersek
On 07/08/13 16:16, Tomoki Sekiyama wrote: > On 7/8/13 9:58 , "Laszlo Ersek" wrote: > >> On 07/05/13 19:06, Tomoki Sekiyama wrote: >>> On 7/4/13 8:54 , "Paolo Bonzini" wrote: >>> Il 03/07/2013 18:19, Tomoki Sekiyama ha scritto: > On 7/3/13 11:58 , "Paolo Bonzini" wrote: > >> Il

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Andreas Färber
Am 08.07.2013 16:10, schrieb Peter Maydell: > On 8 July 2013 15:04, Anthony Liguori wrote: >> (Just a nit and responding because this happens commonly). >> >> You probably mean Reviewed-by. Acked-by really means, "I am not the >> maintainer of this area, I have not reviewed this patch, but I am >

Re: [Qemu-devel] PVFS2 Block Driver Support

2013-07-08 Thread Timothy Scott
I pass all 15/15 tests that actually run when I just run './check -pvfs2' When running './check -pvfs2 -qcow2' I fail 39 of 44 tests. These seem to be the most common errors: +IOError: [Errno 2] No such file or directory: 'pvfs2:/home/tscott2/qemu/tests/qemu-iotests/scratch/t.qcow2' +qemu-img: He

Re: [Qemu-devel] [Qeustion] USB passthough doesn't work on Windows.

2013-07-08 Thread Geunhae Lee
hi thanks for you kind answer, admit about lacking of infos haha.. here's my situations. 1. i currently use QEMU ver 1.2, but plan to upgrade to 1.5 soon. 2. in version 1.2, i found that USB passthrough is not supported on Windows/Mac. In version 1.5, however, it seems possible to use passthr

Re: [Qemu-devel] [Qeustion] USB passthough doesn't work on Windows.

2013-07-08 Thread Geunhae Lee
one more thing , if someone tested USB passthrough on Windows/Mac, can i have the version of QEMU and libusb library ? 2013/7/9 Geunhae Lee > hi thanks for you kind answer, > admit about lacking of infos haha.. > > here's my situations. > > 1. i currently use QEMU ver 1.2, but plan to upgra

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Anthony Liguori
Peter Maydell writes: > On 8 July 2013 15:04, Anthony Liguori wrote: >> (Just a nit and responding because this happens commonly). >> >> You probably mean Reviewed-by. Acked-by really means, "I am not the >> maintainer of this area, I have not reviewed this patch, but I am >> generally okay wit

Re: [Qemu-devel] [PATCH] Spelling fixes

2013-07-08 Thread Corentin Chary
The comments (and most of the code) are from libvncserver (and, earlier, from "THE 'ZYWRLE' VNC CODEC SOURCE CODE. " as described in the header): http://fastdroid-vnc.googlecode.com/svn-history/r3/trunk/LibVNCServer-0.9.7/libvncserver/zywrletemplate.c On Mon, Jul 8, 2013 at 5:43 AM, Stefan Weil

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-07-08 Thread Ed Maste
On 3 July 2013 04:57, Stefan Hajnoczi wrote: > On Tue, Jul 02, 2013 at 09:35:41AM +0200, Christian Berendt wrote: >> On 07/02/2013 09:31 AM, Stefan Hajnoczi wrote: >> >I think the solution is to add another buildmaster administrator. I >> >believe Christian offered that in the past. >> >> Sure. I

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Anthony Liguori
Andreas Färber writes: > Am 08.07.2013 16:10, schrieb Peter Maydell: >> On 8 July 2013 15:04, Anthony Liguori wrote: >>> (Just a nit and responding because this happens commonly). >>> >>> You probably mean Reviewed-by. Acked-by really means, "I am not the >>> maintainer of this area, I have not

Re: [Qemu-devel] [PATCH V5 1/7] monitor: avoid direct use of global *cur_mon in completion functions

2013-07-08 Thread Luiz Capitulino
On Sat, 29 Jun 2013 11:52:55 +0800 Wenchao Xia wrote: > Parameter *mon is added to replace *cur_mon, and readline_completion() > pass rs->mon as value, which should be initialized in readline_init() > called by monitor_init(). In short, structure ReadLineState controls > where the action would be

Re: [Qemu-devel] [PATCH V5 3/7] monitor: code move for parse_cmdline()

2013-07-08 Thread Luiz Capitulino
On Sat, 29 Jun 2013 11:52:57 +0800 Wenchao Xia wrote: > get_str() is called by parse_cmdline() so it is moved also. Some > code style error reported by check script, is also fixed. Please, explain why you're doing this move. > > Signed-off-by: Wenchao Xia > --- > monitor.c | 191 >

Re: [Qemu-devel] QEMU live block-migration

2013-07-08 Thread Michael Roth
Quoting Yaodong Yang (2013-07-07 09:55:06) > Hello everyone, >I have a short question about the implementation of QEMU. When the qemu >perform the live block migration using "migrate -b tcp:" command. Does >a new thread for migration created or not? I went through the code, only >

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Peter Maydell
On 8 July 2013 16:20, Anthony Liguori wrote: > Right, it goes: > > 1) Acked-by: > > I haven't reviewed the code in detail but the general idea seems sane. > > 2) Reviewed-by: > > The general idea seems sane, and I have done a thorough review of the > patch in question. > > 3) Signed-off-by: > > Al

Re: [Qemu-devel] [PATCH V5 4/7] monitor: avoid direct use of global *info_cmds in help functions

2013-07-08 Thread Luiz Capitulino
On Sat, 29 Jun 2013 11:52:58 +0800 Wenchao Xia wrote: > In help functions info_cmds is treated as sub command group now, not as > a special case any more. Still help can't show message for single command > under "info", since command parser reject additional parameter, which What you meant by "h

Re: [Qemu-devel] [PATCH V5 2/7] monitor: avoid direct use of global variable *mon_cmds

2013-07-08 Thread Luiz Capitulino
On Sat, 29 Jun 2013 11:52:56 +0800 Wenchao Xia wrote: > New member *cmd_table is added in structure Monitor to avoid direct usage of > *mon_cmds. Now monitor have an associated command table, when global variable > *info_cmds is also discarded, structure Monitor would gain full control about > ho

[Qemu-devel] [PATCH v2 18/19] target-ppc: Enhance the CPU node labels for the guest device tree for pseries.

2013-07-08 Thread Prerna Saxena
Hi David, Thanks for the review feedback. I have incorporated your changes in v2 of the patch, which follows herewith. Regards, Prerna Subject: [PATCH v2] Target-ppc : Enhance the CPU node labels for the guest device tree for pseries. In absence of a -CPU parameter in the qemu command line, the

Re: [Qemu-devel] [PATCH 18/19] target-ppc: Enhance the CPU node labels for the guest device tree for pseries.

2013-07-08 Thread Prerna Saxena
On 07/08/2013 02:32 PM, Andreas Färber wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 08.07.2013 03:09, schrieb David Gibson: >> On Sat, Jul 06, 2013 at 11:54:15PM +1000, Alexey Kardashevskiy >> wrote: >>> @@ -1342,6 +1346,13 @@ static void >>> ppc_spapr_init(QEMUMachineInitArgs *

Re: [Qemu-devel] QEMU live block-migration

2013-07-08 Thread Yaodong Yang
Hello Michael, Thanks for your help! I read the function of tcp_wait_for_connect(), there is a statement; " qemu_set_fd_handler2(s->fd, NULL, NULL, NULL, NULL); " I guess this will disable this file-descriptor from the main loop and make the current execution parallel with the main loop. Is it co

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Andreas Färber
Am 08.07.2013 17:34, schrieb Peter Maydell: > On 8 July 2013 16:20, Anthony Liguori wrote: >> Right, it goes: >> >> 1) Acked-by: >> >> I haven't reviewed the code in detail but the general idea seems sane. >> >> 2) Reviewed-by: >> >> The general idea seems sane, and I have done a thorough review o

Re: [Qemu-devel] [PATCH V5 6/7] monitor: improve "help" in auto completion for sub command

2013-07-08 Thread Luiz Capitulino
On Sat, 29 Jun 2013 11:53:00 +0800 Wenchao Xia wrote: > Now special case "help *" in auto completion can work with sub commands, > such as "help info a*". The auto-completion works, but the command is still refused: (qemu) help info u usb usbhost usernet uuid (qemu) help info uuid hel

Re: [Qemu-devel] [PATCH V5 7/7] monitor: improve "help" to allow show details of single command in sub group

2013-07-08 Thread Luiz Capitulino
On Sat, 29 Jun 2013 11:53:01 +0800 Wenchao Xia wrote: > A new parameter type 'S' is introduced to allow user input any string. > "help info block" do not tip extra parameter error now. > > Signed-off-by: Wenchao Xia > --- > hmp-commands.hx |2 +- > monitor.c | 30 ++

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Stefano Stabellini
On Mon, 8 Jul 2013, Anthony Liguori wrote: > Andreas Färber writes: > > > Am 08.07.2013 16:10, schrieb Peter Maydell: > >> On 8 July 2013 15:04, Anthony Liguori wrote: > >>> (Just a nit and responding because this happens commonly). > >>> > >>> You probably mean Reviewed-by. Acked-by really mea

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Stefano Stabellini
On Mon, 8 Jul 2013, Stefano Stabellini wrote: > On Mon, 8 Jul 2013, Anthony Liguori wrote: > > Andreas Färber writes: > > > > > Am 08.07.2013 16:10, schrieb Peter Maydell: > > >> On 8 July 2013 15:04, Anthony Liguori wrote: > > >>> (Just a nit and responding because this happens commonly). > > >

Re: [Qemu-devel] [PATCH 18/19] target-ppc: Enhance the CPU node labels for the guest device tree for pseries.

2013-07-08 Thread Andreas Färber
Hi, Am 08.07.2013 17:49, schrieb Prerna Saxena: > On 07/08/2013 02:32 PM, Andreas Färber wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Am 08.07.2013 03:09, schrieb David Gibson: >>> On Sat, Jul 06, 2013 at 11:54:15PM +1000, Alexey Kardashevskiy >>> wrote: @@ -1342,6 +1346,1

Re: [Qemu-devel] [Bug 1187529] [PATCH] Update mappings after PCI bridge live migration or save-restore.

2013-07-08 Thread Don Koch
On 07/03/2013 12:15 PM, Andreas Färber wrote: > Am 03.07.2013 17:04, schrieb Don Koch: >> From: Don Koch >> >> Update mappings for PCI bridge after live migration. >> >> Signed-off-by: Don Koch >> --- >> This fixes bug 1187529: devices on a PCI bridge stop working after migration. > > Feel free

Re: [Qemu-devel] QEMU live block-migration

2013-07-08 Thread Michael Roth
Quoting Yaodong Yang (2013-07-08 10:57:25) > Hello Michael, >Thanks for your help! >I read the function of tcp_wait_for_connect(), there is a statement; " >qemu_set_fd_handler2(s->fd, NULL, NULL, NULL, NULL); " I guess this will >disable this file-descriptor from the main loop and

Re: [Qemu-devel] QEMU live block-migration

2013-07-08 Thread Yaodong Yang
I used the qemu-kvm 1.2.0, so I did not find it in the code. I will move to the current qemu version. Thanks! On Mon, Jul 8, 2013 at 12:18 PM, Michael Roth wrote: > Quoting Yaodong Yang (2013-07-08 10:57:25) > > Hello Michael, > >Thanks for your help! > >I read the function of tcp_wait_

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Anthony Liguori
Stefano Stabellini writes: > On Mon, 8 Jul 2013, Anthony Liguori wrote: >> Andreas Färber writes: >> >> Right, it goes: >> >> 1) Acked-by: >> >> I haven't reviewed the code in detail but the general idea seems sane. >> >> 2) Reviewed-by: >> >> The general idea seems sane, and I have done a

Re: [Qemu-devel] [PATCH v3 0/3] qapi: Top-level type reference for command definitions

2013-07-08 Thread Luiz Capitulino
On Mon, 1 Jul 2013 16:31:49 +0200 Kevin Wolf wrote: > v2: > - Updated documentation in patch 3 > > v3: > - Refactored differently (introduced get_expr()) as suggested by Michael > > Kevin Wolf (3): > qapi.py: Avoid code duplication > qapi.py: Allow top-level type reference for command defi

[Qemu-devel] [RFC] Undeterministic behaviour with icount.

2013-07-08 Thread Frederic Konrad
Hi everybody, We get some issues with reverse execution caused by indeterminism. Something catched our attention: static void icount_warp_rt(void *opaque), cpus.c:276 We have the feeling that icount is synchronized with rt_clock, is that possible? According to this Paolo's series

Re: [Qemu-devel] [Bug 1187529] [PATCH] Update mappings after PCI bridge live migration or save-restore.

2013-07-08 Thread Don Koch
On 07/04/2013 04:57 AM, Michael S. Tsirkin wrote: > On Wed, Jul 03, 2013 at 11:04:16AM -0400, Don Koch wrote: >> From: Don Koch >> >> Update mappings for PCI bridge after live migration. >> >> Signed-off-by: Don Koch >> --- >> This fixes bug 1187529: devices on a PCI bridge stop working after mig

Re: [Qemu-devel] QEMU live block-migration

2013-07-08 Thread Yaodong Yang
Yes, I found it in the qemu-1.5.1 and it's much clear for me now. I think I need to work on this version, other than the out-of-date version qemu-kvm-1.2.0. Thanks a lot. On Mon, Jul 8, 2013 at 12:29 PM, Yaodong Yang wrote: > I used the qemu-kvm 1.2.0, so I did not find it in the code. I will m

Re: [Qemu-devel] [PATCH 00/17 v3] spapr: migration, pci, msi, power8

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > This series spent quite a lot of time waiting when David's PCI series > reaches the upstream but it does not seem to happen soon so I rebased > those on top of agraf/ppc-next rebased on top qemu.org/master. > > > While this series applies and compiles, the migration

Re: [Qemu-devel] [PATCH v6] add timestamp to error_report()

2013-07-08 Thread Luiz Capitulino
On Wed, 03 Jul 2013 23:02:46 -0400 Seiji Aguchi wrote: > [Issue] > When we offer a customer support service and a problem happens > in a customer's system, we try to understand the problem by > comparing what the customer reports with message logs of the > customer's system. > > In this case, we

Re: [Qemu-devel] [PATCH 01/17] pseries: move interrupt controllers to hw/intc/

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > default-configs/ppc64-softmmu.mak |1 + > hw/intc/Makefile.objs |1 + > hw/{ppc => intc}/xics.c |0 > hw/ppc/Makefile.objs

Re: [Qemu-devel] [PATCH V4 08/10] NUMA: add qmp command set-mpol to set memory policy for NUMA node

2013-07-08 Thread Luiz Capitulino
On Thu, 4 Jul 2013 17:53:15 +0800 Wanlong Gao wrote: > The QMP command let it be able to set node's memory policy > through the QMP protocol. The qmp-shell command is like: > set-mpol nodeid=0 mem-policy=membind mem-hostnode=0-1 > > Signed-off-by: Wanlong Gao > --- > cpus.c | 54

Re: [Qemu-devel] [PATCH 02/17] pseries: rework XICS

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > On 06/27/2013 09:47 PM, David Gibson wrote: >> On Thu, Jun 27, 2013 at 04:45:45PM +1000, Alexey Kardashevskiy wrote: >>> Currently XICS interrupt controller is not a QEMU device. As we are going >>> to support in-kernel emulated XICS which is a part of KVM, it make

[Qemu-devel] [PATCH v2 2/4] loader: allow adding ROMs in done callbacks

2013-07-08 Thread Michael S. Tsirkin
Don't abort if machine done callbacks add ROMs. Signed-off-by: Michael S. Tsirkin --- hw/core/loader.c| 6 +- include/hw/loader.h | 1 + vl.c| 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 1ead722..3f1d89b 1

[Qemu-devel] [PATCH v2 0/4] qemu: generate acpi tables for the guest

2013-07-08 Thread Michael S. Tsirkin
This patchset moves all generation of ACPI tables from guest BIOS to the hypervisor. Please review, and consider for 1.6. Changes from v1 RFC: - added code to address cross version compatibility - rebased to latest bits - updated acpi tables to latest seabios bits (added pvpanic device) Comments

[Qemu-devel] [PATCH v2 1/4] loader: support for unmapped ROM blobs

2013-07-08 Thread Michael S. Tsirkin
Support ROM blobs not mapped into guest memory: let user pass in MR for memory serving as the backing store. Signed-off-by: Michael S. Tsirkin --- hw/core/loader.c | 32 +--- hw/lm32/lm32_hwsetup.h | 2 +- include/hw/loader.h| 4 ++-- 3 files changed, 32 i

  1   2   >