-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 08.07.2013 03:09, schrieb David Gibson: > On Sat, Jul 06, 2013 at 11:54:15PM +1000, Alexey Kardashevskiy > wrote: >> @@ -1342,6 +1346,13 @@ static void >> ppc_spapr_init(QEMUMachineInitArgs *args) >> register_savevm_live(NULL, "spapr/htab", -1, 1, >> &savevm_htab_handlers, spapr); >> >> + /* Ensure that cpu_model is correctly reflected for a KVM >> guest */ + if (kvm_enabled() && !strcmp(cpu_model, "host")) { >> + asm ("mfpvr %0" + : "=r"(pvr)); + >> cpu_model = ppc_cpu_alias_by_pvr(pvr); > > This needs to be protected by an ifdef CONFIG_KVM or similar. If > the compiler optimization level is turned down, so that it doesn't > recognize that the kvm_enabled() is always false, then this could > attempt to compile the ppc asm instructions on an x86 (or > whatever) host.
This hunk can be completely replaced by QOM mechanisms - just didn't get to replying yet... Andreas - -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendrffer; HRB 16746 AG Nrnberg -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJR2oAjAAoJEPou0S0+fgE/kxEP/2hvke1o/T4/h3Gl48W2+ASv 84iu5M7atndRF1L1bI6VogmQGlhE4qiAMxuLljpqriXz5lZndslMMcP3mx4skljD Y3YX9Hi37yR9KEaw0AzoQCBhhS5ZIMGjd/mtW/DqPDcN0H0IdCu340Mz/Lr+0HHy wp+ChUA8q8iYWJd6zmFmIvnaHUdbRoOHePhVlJD+GZQ2oBNu48DAaiiCdnrEJy+R ipyZJEF+QmO2RlNDgImOKfyKry6PhuWPBIjMB3qZWyuFzmkwNEcQILnOVSW/bBIl zXkEkWy3u5fES1+bYs1J4ZL6MZ+Edcd0c2BRKQ9JNUGM6mBj1S61aP8rC7u1VgLp eUfkSRYOrsvVvJJ/kpOzgWgcgYnfSYp/CUTRURHxlyIxNuvhjDllRhC4wxbF4Bk4 l6jbIDa8jAMTlbCj9EW03Fi+i+oGemkOg2g5Dxl5GnFwdPC95fE39RvSa5vB3X3q 6IgdkbicFReR1dY8JxdcJsTln6b2eMTSHvUjH56FEvDQ9Z/W7TM/qc1jpmNDX7WS bdWHcziPeAoY9Sk0aMK/LlTKmgZQM1gi5eyKIrL4ujtU3O4VKcNSihYu+Moc+oyx pEfJrkXP6cvYLwW60yxj8soBv9ssCSBU5ZqgcSK7NlfST0KxtQe4y+jwCT0LkhyS Qoat9lALzVlVlQwCWM6/ =2tHJ -----END PGP SIGNATURE-----