On 07/08/2013 02:32 PM, Andreas Färber wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Am 08.07.2013 03:09, schrieb David Gibson: >> On Sat, Jul 06, 2013 at 11:54:15PM +1000, Alexey Kardashevskiy >> wrote: >>> @@ -1342,6 +1346,13 @@ static void >>> ppc_spapr_init(QEMUMachineInitArgs *args) >>> register_savevm_live(NULL, "spapr/htab", -1, 1, >>> &savevm_htab_handlers, spapr); >>> >>> + /* Ensure that cpu_model is correctly reflected for a KVM >>> guest */ + if (kvm_enabled() && !strcmp(cpu_model, "host")) { >>> + asm ("mfpvr %0" + : "=r"(pvr)); + >>> cpu_model = ppc_cpu_alias_by_pvr(pvr); >> >> This needs to be protected by an ifdef CONFIG_KVM or similar. If >> the compiler optimization level is turned down, so that it doesn't >> recognize that the kvm_enabled() is always false, then this could >> attempt to compile the ppc asm instructions on an x86 (or >> whatever) host. > > This hunk can be completely replaced by QOM mechanisms - just didn't > get to replying yet... >
Hi Andreas, Sorry I already sent out a v2, and only then saw your message. Could you pls explain how I could use QOM to replace this code block ? Regards, -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India