From: Kuo-Jung Su
The FTI2C010 is a simple I2C master controller.
Signed-off-by: Kuo-Jung Su
---
hw/arm/Makefile.objs|2 +-
hw/arm/ftplat_a369soc.c |6 ++
hw/fti2c010.c | 224 +++
hw/fti2c010.h | 74
From: Scott Feldman
Socket buffer sizes were hard-coded to 4K for VDE and socket netdevs. Bump this
up to 68K (ala tap netdev) to handle maximum GSO packet size (64k) plus plenty
of room for the ethernet and virtio_net headers.
Originally, ran into this limitation when using -netdev UDP sockets
On Mon, Mar 25, 2013 at 12:17:39PM +, Peter Maydell wrote:
> On 25 March 2013 12:12, Michael S. Tsirkin wrote:
> > On Sun, Mar 24, 2013 at 11:32:37AM +, Peter Maydell wrote:
> >> +return (PCI_SLOT(d->devfn) + irq_num - 2) % PCI_NUM_PINS;
> >
> > It seems this can be a bit shorter:
> >
On Fri, Mar 22, 2013 at 01:04:55PM +, Richard W.M. Jones wrote:
> I got it working with Curl, patch attached.
>
> However there are multiple issues (these are mainly notes for myself):
>
> (1) libcurl cannot read the size of the file. I had to hard-code
> this. This is probably just a short
We fixed this issue by below patch which computed the correct size for
test_bits(). qemu_get_ram_ptr() and qemu_safe_ram_ptr() will call
xen_map_cache() with size is 0 if the requested address is in the RAM. Then
xen_map_cache() will pass the size 0 to test_bits() for checking if the
correspond
Hans de Goede writes:
> Add tracking of the fe_open state to struct CharDriverState.
>
> Signed-off-by: Hans de Goede
> ---
> include/char/char.h | 1 +
> qemu-char.c | 2 ++
> 2 files changed, 3 insertions(+)
>
> diff --git a/include/char/char.h b/include/char/char.h
> index dd8f39a..3
Hans de Goede writes:
> Most frontends can't really determine if the guest actually has the frontend
> side open. So lets automatically generate fe_open / fe_close as soon as a
> frontend becomes ready (as signalled by calling qemu_chr_add_handlers) /
> becomes non ready (as signalled by setting
Jan Kiszka writes:
> On 2013-02-25 16:44, Jan Kiszka wrote:
>> On 2013-02-25 16:39, Anthony Liguori wrote:
>>> Jan Kiszka writes:
>>>
This is in fact very simply: When the input in grabbed, everything
should be exclusively passed to the guest - except it has our magic
CTRL-ALT mod
> Maybe I should have explained the output more detailed. The percentages
> are added. 35.8% in the second last column means that
> 35.8% have a return value that is less than TARGET_PAGE_SIZE.
> This was meant to illustrate at how many 64-bit chunks you have
> to look to grab a certain percentage
Hi,
On 03/25/2013 01:45 PM, Anthony Liguori wrote:
Hans de Goede writes:
Add tracking of the fe_open state to struct CharDriverState.
Signed-off-by: Hans de Goede
---
include/char/char.h | 1 +
qemu-char.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/include/char/char.
- Messaggio originale -
> Da: "Michael R. Hines"
> A: "Orit Wasserman"
> Cc: qemu-devel@nongnu.org, pbonz...@redhat.com, m...@redhat.com, "chegu
> vinod" ,
> quint...@redhat.com
> Inviato: Sabato, 23 marzo 2013 17:27:49
> Oggetto: Re: [Qemu-devel] [RFC 10/12] Add qemu_put_buffer_no_cop
On Mon, Mar 25, 2013 at 1:32 PM, Richard W.M. Jones wrote:
> On Fri, Mar 22, 2013 at 01:04:55PM +, Richard W.M. Jones wrote:
>> I got it working with Curl, patch attached.
>>
>> However there are multiple issues (these are mainly notes for myself):
>>
>> (1) libcurl cannot read the size of the
Hi,
On 03/25/2013 01:46 PM, Anthony Liguori wrote:
Hans de Goede writes:
Most frontends can't really determine if the guest actually has the frontend
side open. So lets automatically generate fe_open / fe_close as soon as a
frontend becomes ready (as signalled by calling qemu_chr_add_handlers
Instead of ignoring any errors that occur when adding properties
to a new device in device_initfn(), check for them and abort if any
occur. The most likely cause is accidentally adding a duplicate
property, which is a programming error by the device author.
Signed-off-by: Peter Maydell
Reviewed-b
Detect attempts to add a property to an object if one of
that name already exists, and report them as errors.
Signed-off-by: Peter Maydell
Reviewed-by: Anthony Liguori
Acked-by: Paolo Bonzini
---
qom/object.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/q
Hi
Please send in any agenda topics you are interested in.
Later, Juan.
Hi Richard,
I've finally gotten around to debug why TCG on s390 hosts breaks for me. The
reason turned out to be quite simple. The broken TB ends with a goto_tb
instruction:
exit_tb $0x3fffb258010
which gets translated into:
0x9040: lgfi%r2,-81428464
0x9046: iihl%r2
On 03/22/2013 06:09 PM, Paolo Bonzini wrote:
Il 22/03/2013 22:37, Corey Bryant ha scritto:
Is it desirable to change a mac address under the covers?
This is the TAP mac address. It is unrelated to the guest's MAC
address. It is a random link-local address, all this patch does is make
it le
Am 25.03.2013 um 14:02 schrieb Paolo Bonzini :
>> Maybe I should have explained the output more detailed. The percentages
>> are added. 35.8% in the second last column means that
>> 35.8% have a return value that is less than TARGET_PAGE_SIZE.
>> This was meant to illustrate at how many 64-bit ch
On 03/22/2013 12:57 PM, Paolo Bonzini wrote:
Linux uses the lowest enslaved MAC address as the MAC address of
the bridge. Set MAC address to a high value so that it does not
affect the MAC address of the bridge.
Changing the MAC address of the bridge could cause a few seconds
of network downt
Am 25.03.2013 um 14:23 schrieb Peter Lieven :
>
> Am 25.03.2013 um 14:02 schrieb Paolo Bonzini :
>
>>> Maybe I should have explained the output more detailed. The percentages
>>> are added. 35.8% in the second last column means that
>>> 35.8% have a return value that is less than TARGET_PAGE_SI
On 18.03.2013 10:53, Michael S. Tsirkin wrote:
Do you see all interrupts going to the same CPU? If yes is
irqbalance in guest running?
I had the same issue today. Problem is irqs are going to all vCPUs. If the
smp_affinity is set to one CPU only
performance is OK. irqbalance is running, but it
Now we have error_setg() we can improve the error message emitted if
you attempt to set a property of a device after the device is realized
(the previous message was "permission denied" which was not very
informative).
Signed-off-by: Peter Maydell
---
Another attempt at updating this patch (v3 Oc
Detect and abort on duplicate properties in a qdev Property array.
This patchset actually dates back to October last year (and got
reviewed then, hence Anthony's r-b tags) but it didn't get applied
(maybe we were in codefreeze) and I forgot about it. Anyway, I've
rebased it so here we are again.
Ping!
thanks
-- PMM
On 14 March 2013 17:57, Peter Maydell wrote:
> The main aim of this patchset is patch 2, which changes the coroutine
> backend selection logic so that it goes 'ucontext -> sigaltstack'
> rather than 'ucontext -> gthread', since the gthread backend is
> broken. To do this prop
On 03/25/2013 02:37 PM, Gerd Hoffmann wrote:
>
>>Hi,
>>
>> [5425.580115] displaysurface_create_from surface=0x7ff315d3df40,
>>> 800x600, bpp 16, bswap 0 [5425.580257] displaysurface_free
>>> surface=0x7ff3158c33b0
>>>
>>
>> This is vga=0x314
>>
>> Looks like we have some funky interaction betw
On Thu, Mar 21, 2013 at 01:07:11PM +0100, Peter Lieven wrote:
> this patch adds a check for qemu_find_opts("iscsi") returning
> NULL instead of blindly passing the result to qemu_opts_parse().
>
> Signed-off-by: Peter Lieven
> ---
> vl.c |9 ++---
> 1 file changed, 6 insertions(+), 3 del
After the latest patch of Richard's, qemu-system-x86_64 now runs
GNU/Linux properly. The denorm problem is gone, and there seem to be no
(or at least much fewer) spurious segfaults.
This ends a multi-month period of qemu-system-x86_64 instability.
Still qemu-system-mips64, qemu-system-mips64el,
On 25 March 2013 14:06, Torbjorn Granlund wrote:
> Still qemu-system-mips64, qemu-system-mips64el, and qemu-system-arm
> give spurious errors.
If you can provide a reasonably sized test case for
qemu-system-arm I can investigate that one.
thanks
-- PMM
On Thu, Mar 21, 2013 at 01:07:10PM +0100, Peter Lieven wrote:
> commit 4d454574 "qemu-option: move standard option definitions
> out of qemu-config.c" broke support for commandline option
> groups that where registered during bdrv_init(). In particular
> support for -iscsi options was broken since
Am 25.03.2013 um 15:00 schrieb Stefan Hajnoczi :
> On Thu, Mar 21, 2013 at 01:07:11PM +0100, Peter Lieven wrote:
>> this patch adds a check for qemu_find_opts("iscsi") returning
>> NULL instead of blindly passing the result to qemu_opts_parse().
>>
>> Signed-off-by: Peter Lieven
>> ---
>> vl.c
On Fri, Mar 22, 2013 at 05:51:14PM -, Kenneth Salerno wrote:
> Public bug reported:
>
> (Note: problem is not present in version 1.3.0)
Please run git-bisect(1) to identify the commit that introduced the bug.
Information about git-bisect(1):
http://git-scm.com/book/en/Git-Tools-Debugging-wit
Shehbaz, you seem to be mixing up -m and -M. -M is a shorthand for
-machine, whereas -m is the memory.
Jiamswang, are you saying the second command gets fixed by adding a
comma and the first by changing -M to -machine? That sounds more like a
heisenbug (works sometimes, fails apparently randomly).
On 25 March 2013 14:10, Peter Lieven wrote:
> Am 25.03.2013 um 15:00 schrieb Stefan Hajnoczi :
>> On Thu, Mar 21, 2013 at 01:07:11PM +0100, Peter Lieven wrote:
>>> this patch adds a check for qemu_find_opts("iscsi") returning
>>> NULL instead of blindly passing the result to qemu_opts_parse().
>>>
Il 25/03/2013 14:32, Peter Lieven ha scritto:
>
> Am 25.03.2013 um 14:23 schrieb Peter Lieven :
>
>>
>> Am 25.03.2013 um 14:02 schrieb Paolo Bonzini :
>>
Maybe I should have explained the output more detailed. The percentages
are added. 35.8% in the second last column means that
35
Am 21.03.2013 um 14:38 hat Richard W.M. Jones geschrieben:
> From: "Richard W.M. Jones"
>
> qemu-system-x86_64 -drive file=ssh://hostname/some/image
>
> QEMU will ssh into 'hostname' and open '/some/image' which is made
> available as a standard block device.
>
> You can specify a username (s
qmp-shell converts only integer arguments and the rest
is assumed to be strings which are faithfully sent as
quoted strings by json. But QEMU refuses to accept qmp
command with boolean argument whose value is escaped
as string.
Fix it by special-casing true/false keywords and store
value as corres
On 03/24/2013 03:59 AM, Peter Maydell wrote:
> PC is FF600400 so either we've messed it up already or this
> is just "64 bit address space doesn't fit in a 32 bit one".
This is probably the fallback vdso address.
I've previously sent patches to the list (several times) to add a real
vdso
On 03/23/2013 06:42 AM, Thomas Knauth wrote:
> Hi Eric,
>
> thanks for the reply. This indeed solved my issue. Suspending is much
> faster without the artificial throttle.
>
> On a related note: I'm curious about the baseline resume latency. It takes
> about 5 seconds to resume an instance with a
Hans de Goede writes:
> Hi,
>
> On 03/25/2013 01:46 PM, Anthony Liguori wrote:
>> Hans de Goede writes:
>>
>>> Most frontends can't really determine if the guest actually has the frontend
>>> side open. So lets automatically generate fe_open / fe_close as soon as a
>>> frontend becomes ready (as
On Mon, Mar 25, 2013 at 03:36:22PM +0100, Kevin Wolf wrote:
> You don't have a bdrv_co_flush_to_disk, what does this mean? Is every
> write immediately flushed to the disk, is the driver unsafe by design,
> or is this just a missing implementation detail?
Initially there is no .bdrv_co_flush_to_di
On Mon, 25 Mar 2013 10:39:36 +0100
Andreas Färber wrote:
> Am 28.02.2013 03:12, schrieb H. Peter Anvin:
> > From: "H. Peter Anvin"
> >
> > Add models for 486SX, and pre-CPUID versions of the 486 (DX & SX).
> > Change the model number for the standard 486DX to a model which
> > actually had CPUI
On Mon, 25 Mar 2013 15:48:46 +0100
Igor Mammedov wrote:
> qmp-shell converts only integer arguments and the rest
> is assumed to be strings which are faithfully sent as
> quoted strings by json. But QEMU refuses to accept qmp
> command with boolean argument whose value is escaped
> as string.
>
Right, the header's not used - but, are we certain that
put_buffer_copy() will *always* be used for RAM in the future?
- Michael
On 03/25/2013 09:05 AM, Paolo Bonzini wrote:
- Messaggio originale -
Da: "Michael R. Hines"
A: "Orit Wasserman"
Cc: qemu-devel@nongnu.org, pbonz...@redha
Signed-off-by: Igor Mammedov
---
v2:
* s/cpu_set/cpu-set/
* qmp doc style fix
* use bool type instead of opencodding online/offline string
suggested-by: Eric Blake
changes are on WIP branch: https://github.com/imammedo/qemu/tree/cpu_set.WIP
---
include/sysemu/sysemu.h |2 ++
qa
On Mon, Mar 25, 2013 at 4:03 PM, Richard Henderson wrote:
> On 03/24/2013 03:59 AM, Peter Maydell wrote:
>> PC is FF600400 so either we've messed it up already or this
>> is just "64 bit address space doesn't fit in a 32 bit one".
>
> This is probably the fallback vdso address.
Yes, it lo
Signed-off-by: Anthony Liguori
---
include/glib-compat.h | 27 +++
include/qemu-common.h | 2 +-
2 files changed, 28 insertions(+), 1 deletion(-)
create mode 100644 include/glib-compat.h
diff --git a/include/glib-compat.h b/include/glib-compat.h
new file mode 100644
ind
On Thu, 21 Mar 2013 20:46:57 -0600
Eric Blake wrote:
> On 03/21/2013 08:28 AM, Igor Mammedov wrote:
> > ... via do_cpu_hot_add() hook called by cpu_set QMP command,
> > for x86 target.
> >
> > * add extra check that APIC ID is in allowed range
>
> > +if (x86_cpu_is_cpu_exist(qdev_get_machin
On 25 March 2013 15:24, Anthony Liguori wrote:
> Signed-off-by: Anthony Liguori
> +#if !GLIB_CHECK_VERSION(2, 14, 0)
> +static inline guint g_timeout_add_seconds(guint interval, GSourceFunc
> function,
> + gpointer data)
> +{
> +return g_timeout_add(i
On 03/25/2013 02:05 AM, Paolo Bonzini wrote:
>
> Interesting, do you have SeaBIOS and/or OVMF patches for this?
>
Not at this point.
-hpa
> On 03/25/2013 02:05 AM, Paolo Bonzini wrote:
> > Interesting, do you have SeaBIOS and/or OVMF patches for this?
>
> Not at this point.
I guess you could repost 1 and 2 without the RFC tag, then.
Paolo
On Mon, 25 Mar 2013 13:06:27 +0100
Michal Novotny wrote:
>
> On 03/21/2013 01:51 PM, Luiz Capitulino wrote:
> > On Tue, 12 Mar 2013 17:03:31 +0100
> > Michal Novotny wrote:
> >
> >> This is the patch to introduce the query-cpu-max QMP command to get
> >> the maximum number of CPUs supported by
Resent now. it went to my inbox (added from SOB) so hopefully it went to
you and list too (however list is too slow to verify now).
Michal
On 03/25/2013 04:52 PM, Luiz Capitulino wrote:
> On Mon, 25 Mar 2013 13:06:27 +0100
> Michal Novotny wrote:
>
>> On 03/21/2013 01:51 PM, Luiz Capitulino wrot
Peter Maydell writes:
On 25 March 2013 14:06, Torbjorn Granlund wrote:
> Still qemu-system-mips64, qemu-system-mips64el, and qemu-system-arm
> give spurious errors.
If you can provide a reasonably sized test case for
qemu-system-arm I can investigate that one.
I don't know how to
On Mon, 25 Mar 2013 16:58:50 +0100
Michal Novotny wrote:
> These commands return the maximum number of CPUs supported by the
/These commands/This command
> currently running emulator instance, as defined in its QEMUMachine
> struct.
>
> Signed-off-by: Michal Novotny
> ---
> hmp-commands.hx
On Fri, Mar 15, 2013 at 05:29:03PM +0800, Lei Li wrote:
> This patch series attempts to add Windows implementation
> for qemu-ga commands guest-get-time and guest-set-time.
Thanks, applied to qga branch.
>
> The previous thread about the interfaces introduced and
> the POSIX-specific command im
On Fri, Mar 15, 2013 at 07:07:49PM +0100, Laszlo Ersek wrote:
> Laszlo Ersek (2):
> qga schema: mark optional GuestLogicalProcessor.can-offline with
> #optional
> qga schema: document generic QERR_UNSUPPORTED
>
> qga/qapi-schema.json | 18 +++---
> 1 files changed, 15 insert
> Right, the header's not used - but, are we certain that
> put_buffer_copy() will *always* be used for RAM in the future?
I think you should not make any assumption and proceed as if this
series didn't exist.
Paolo
On Fri, Mar 22, 2013 at 04:31:07PM -0400, Luiz Capitulino wrote:
> Today we reset fd_counter if it wraps, but it's better to abort()
> instead, as fd_counter should never reach INT64_MAX.
>
> Signed-off-by: Luiz Capitulino
Thanks, applied to qga branch with s/resonable/reasonable/ typo fix.
> -
On 03/25/2013 05:13 PM, Luiz Capitulino wrote:
> On Mon, 25 Mar 2013 16:58:50 +0100
> Michal Novotny wrote:
>
>> These commands return the maximum number of CPUs supported by the
> /These commands/This command
I meant both of them - both QMP (query-cpu-max) one HMP (cpu_max) one.
>
>> current
On Mon, 25 Mar 2013 17:24:02 +0100
Michal Novotny wrote:
> >> +void hmp_query_cpu_max(Monitor *mon, const QDict *qdict)
> >> +{
> >> +int cpu_max;
> >> +Error *errp = NULL;
> >> +
> >> +cpu_max = qmp_query_cpu_max(&errp);
> >> +if (errp) {
> >> +monitor_printf(mon, "%s\n",
Version 3 sent to both you and list.
Michal
On 03/25/2013 05:27 PM, Luiz Capitulino wrote:
> On Mon, 25 Mar 2013 17:24:02 +0100
> Michal Novotny wrote:
>
+void hmp_query_cpu_max(Monitor *mon, const QDict *qdict)
+{
+int cpu_max;
+Error *errp = NULL;
+
+c
This is the start of the latest Delayed COW series. As there seem to be serious
problems with the actual Delayed COW (which in fact exist today, but would
become a bit easier to hit) and I don't have the time to complete this at the
moment, here is another series with preparatory patches, for which
The unlock wakes up the next coroutine, but the currently running
coroutine will lock it again before it yields, so this doesn't make a
lot of sense.
Signed-off-by: Kevin Wolf
---
block/qcow2.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 8ea696a..3f7e
The old code detected an overlapping allocation even when the
allocations didn't actually overlap, but were only adjacent.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 2 +-
tests/qemu-iotests/038.out | 10 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/
This moves some code that prepares the allocation of new clusters to
where the actual allocation happens. This is the minimum required to be
able to move it to a separate function in the next patch.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 35 ---
1 f
This should be based on the virtual disk size, not on the size of the
image.
Interesting observation: With some VM state stored in the image file,
percentages higher than 100% are possible, even though snapshots
themselves are ignored. This is a qcow2 bug to be fixed another day: The
VM state shou
Handling overlapping allocations isn't just a detail of cluster
allocation. It is rather one of three ways to get the host cluster
offset for a write request:
1. If a request overlaps an in-flight allocations, the cluster offset
can be taken from there (this is what handle_dependencies will evo
Things can be simplified a bit now. No semantic changes.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 110 --
1 file changed, 53 insertions(+), 57 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 457f162..2047
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 240 +++---
trace-events | 1 +
2 files changed, 152 insertions(+), 89 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 9550927..454a30c 100644
--- a/block/qc
handle_copied() uses its bytes parameter now to determine how many
clusters it should try to find.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index
Instead of expecting a single l2meta, have a list of them. This allows
to still have a single I/O request for the guest data, even though
multiple l2meta may be needed in order to describe both a COW overwrite
and a new cluster allocation (typical sequential write case).
Signed-off-by: Kevin Wolf
The interface works completely on a byte granularity now and duplicated
parameters are removed.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 29 -
block/qcow2.h | 5 +
2 files changed, 21 insertions(+), 13 deletions(-)
diff --git a/block/qcow2-c
We already communicate the same information in *bytes.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 454a30c..009f62a 100644
--- a/block/qcow2-cluste
This gets rid of the nb_clusters and keep_clusters and the associated
complicated calculations. Just advance the number of bytes that have
been processed and everything is fine.
This patch advances the variables even after the last operation even
though they aren't used any more afterwards to make
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 133 +++---
trace-events | 1 +
2 files changed, 94 insertions(+), 40 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 2047468..4be43c3 100644
--- a/block/qco
Now *bytes is used to return the length of the area that can be written
to without performing an allocation or COW.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow
Look only for clusters that start at a given physical offset.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 28
1 file changed, 20 insertions(+), 8 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index c36b1e7..3588773 100644
--- a/bl
This patch is mainly to separate the indentation change from the
semantic changes. All that really changes here is that everything moves
into a while loop, all 'goto done' become 'break' and at the end of the
loop a new 'break is inserted.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 13
Instead of just checking once in exactly this order if there are
dependendies, non-COW clusters and new allocation, this starts looping
around these. This way we can, for example, gather non-COW clusters after
new allocations as long as the host cluster offsets stay contiguous.
Once handle_depende
On Sun, 2013-03-24 at 11:14 +0200, Michael S. Tsirkin wrote:
> On Fri, Mar 22, 2013 at 09:25:13AM -0600, Alex Williamson wrote:
> > On Thu, 2013-03-21 at 18:56 +0200, Michael S. Tsirkin wrote:
> > > On Tue, Mar 19, 2013 at 04:24:47PM -0600, Alex Williamson wrote:
> > > > Enable PCIe devices to nego
This is a more precise description of what really constitutes a
dependency. The behaviour doesn't change at this point because the COW
area of the old request is still aligned to cluster boundaries and
therefore an overlap is detected wheneven the requests touch any part of
the same cluster.
Signe
handle_alloc() is now called with the offset at which the actual new
allocation starts instead of the offset at which the whole write request
starts, part of which may already be processed.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 44 +++-
blo
On 03/23/2013 06:24:49 AM, Peter Maydell wrote:
On 22 March 2013 22:05, Scott Wood wrote:
> On 03/22/2013 08:08:57 AM, Peter Maydell wrote:
>> The memory API flattens the tree of memory regions down into a flat
>> view of the address space. These callbacks get called for the
>> final flattened v
On Mar 25, 2013 5:40 PM, "Peter Maydell" wrote:
>
> Now we have error_setg() we can improve the error message emitted if
> you attempt to set a property of a device after the device is realized
> (the previous message was "permission denied" which was not very
> informative).
>
> Signed-off-by: Pe
On Mon, 25 Mar 2013 17:31:33 +0100
Michal Novotny wrote:
> These commands return the maximum number of CPUs supported by the
> currently running emulator instance, as defined in its QEMUMachine
> struct.
I've applied this patch to the QMP tree, but with one change (see below).
>
> Signed-off-b
On 03/25/2013 08:15 AM, Igor Mammedov wrote:
>>
>> Such changes have been rejected in the past (e.g., n270 Atom).
>> I personally wouldn't object to 486 changes, but I guess it should
>> rather be handled via Igor's CPU static properties that I have in my
>> review queue: The .model value would be
Am 25.03.2013 um 18:30 hat Kevin Wolf geschrieben:
> Instead of just checking once in exactly this order if there are
> dependendies, non-COW clusters and new allocation, this starts looping
> around these. This way we can, for example, gather non-COW clusters after
> new allocations as long as the
On 03/25/2013 11:30 AM, Kevin Wolf wrote:
> This should be based on the virtual disk size, not on the size of the
> image.
>
> Interesting observation: With some VM state stored in the image file,
> percentages higher than 100% are possible, even though snapshots
> themselves are ignored. This is
On Mon, Mar 25, 2013 at 04:15:15PM +0100, Igor Mammedov wrote:
> On Mon, 25 Mar 2013 10:39:36 +0100
> Andreas Färber wrote:
>
> > Am 28.02.2013 03:12, schrieb H. Peter Anvin:
> > > From: "H. Peter Anvin"
> > >
> > > Add models for 486SX, and pre-CPUID versions of the 486 (DX & SX).
> > > Change
On 03/25/2013 11:30 AM, Kevin Wolf wrote:
> The unlock wakes up the next coroutine, but the currently running
> coroutine will lock it again before it yields, so this doesn't make a
> lot of sense.
>
> Signed-off-by: Kevin Wolf
> ---
> block/qcow2.c | 2 --
> 1 file changed, 2 deletions(-)
Code
On Mon, Mar 25, 2013 at 11:44:30AM -0700, H. Peter Anvin wrote:
> On 03/25/2013 08:15 AM, Igor Mammedov wrote:
> >>
> >> Such changes have been rejected in the past (e.g., n270 Atom).
> >> I personally wouldn't object to 486 changes, but I guess it should
> >> rather be handled via Igor's CPU stati
On 03/25/2013 11:30 AM, Kevin Wolf wrote:
> The old code detected an overlapping allocation even when the
> allocations didn't actually overlap, but were only adjacent.
>
> Signed-off-by: Kevin Wolf
> ---
> block/qcow2-cluster.c | 2 +-
> tests/qemu-iotests/038.out | 10 +-
> 2 fil
Hi,
This series fixes an easy to reproduce assertion in the Monitor code. The
second patch contains all the relevant details.
Gerd, I'd like a reviewed-by from you before merging this.
Luiz Capitulino (2):
qstring: add qobject_get_length()
Monitor: Make output buffer dynamic
include/qapi/q
Long overdue.
Signed-off-by: Luiz Capitulino
---
include/qapi/qmp/qstring.h | 1 +
qobject/qstring.c | 8
2 files changed, 9 insertions(+)
diff --git a/include/qapi/qmp/qstring.h b/include/qapi/qmp/qstring.h
index 0e690f4..1bc3666 100644
--- a/include/qapi/qmp/qstring.h
+++ b/
Commit f628926bb423fa8a7e0b114511400ea9df38b76a changed monitor_flush()
to retry on qemu_chr_fe_write() errors. However, the Monitor's output
buffer can keep growing while the retry is not issued and this can
cause the buffer to overflow.
To reproduce this issue, just start qemu and type on the Mo
Am 25.03.2013 um 18:30 hat Kevin Wolf geschrieben:
> This gets rid of the nb_clusters and keep_clusters and the associated
> complicated calculations. Just advance the number of bytes that have
> been processed and everything is fine.
>
> This patch advances the variables even after the last opera
Hi,
>>> The previous version of monitor_flush() ignores errors, and everything
>>> works, so doing the same thing here fixes the problem :)
>>
>> No, ignoring errors breaks qmp because the output isn't valid json any
>> more when you cut off something ...
>
> What you mean "when you cut off"? W
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
101 - 200 of 240 matches
Mail list logo
