On Mon, 25 Mar 2013 17:24:02 +0100
Michal Novotny <minov...@redhat.com> wrote:
> >> +void hmp_query_cpu_max(Monitor *mon, const QDict *qdict)
> >> +{
> >> + int cpu_max;
> >> + Error *errp = NULL;
> >> +
> >> + cpu_max = qmp_query_cpu_max(&errp);
> >> + if (errp) {
> >> + monitor_printf(mon, "%s\n", error_get_pretty(errp));
> >> + error_free(errp);
> >> + return;
> >> + }
> > Sorry for not noticing this before, but you can pass NULL to
> > qmp_query_cpu_max(), as it never fails.
>
>
> Ok, I just went according to the docs and there was no mention about
> it's possible to pass NULL. I don't know what magic qemu does with that
> one so I rather don't pass NULL. However, respin necessary?
If you look in hmp.c you'll see examples of this. Please respin, otherwise
we'll be committing code that is never used.
