Re: [Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

2013-01-29 Thread Markus Armbruster
Peter Maydell writes: > On 28 January 2013 19:14, Andreas Färber wrote: >> Am 28.01.2013 19:59, schrieb Peter Maydell: >>> Er, what? "do ... while (0)" is completely standard practice >>> for writing robust macros in C. Patches which don't do that >>> should fail code review. >> >> Oh really? No

Re: [Qemu-devel] [PATCH for-1.4 v2] target-i386: kvm: prevent buffer overflow if -cpu foo, [x]level is too big

2013-01-29 Thread Gleb Natapov
On Mon, Jan 28, 2013 at 12:49:26PM +0100, Igor Mammedov wrote: > Stack corruption may occur if too big 'level' or 'xlevel' values passed > on command line with KVM enabled, due to limited size of cpuid_data > in kvm_arch_init_vcpu(). > > reproduces with: > qemu -enable-kvm -cpu qemu64,level=42949

[Qemu-devel] [PATCH] sheepdog: pass vdi_id to sheep daemon for sd_close()

2013-01-29 Thread Liu Yuan
From: Liu Yuan Sheep daemon needs vdi_id to identify which vdi is closed to release resources such as object cache. Signed-off-by: Liu Yuan --- block/sheepdog.c |1 + 1 file changed, 1 insertion(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index 3e49bb8..97c76f5 100644 --- a/block/

Re: [Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variables

2013-01-29 Thread Andreas Färber
Hi, Am 29.01.2013 07:42, schrieb Kuo-Jung Su: > Thanks for reminding me of the usb_ehci_pci_initfn. > > But I have a stupid question... > > Which one do the upcoming path v2 looks like ? > > 1. It contains only the diff to usb_ehci_pci_initfn, for example: > > [Qemu-devel][PATCH v2 0/1

Re: [Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variables

2013-01-29 Thread Gerd Hoffmann
On 01/29/13 07:42, Kuo-Jung Su wrote: > Hi Gerd: > > Thanks for reminding me of the usb_ehci_pci_initfn. > > But I have a stupid question... > > Which one do the upcoming path v2 looks like ? > > 1. It contains only the diff to usb_ehci_pci_initfn, for example: > > [Qemu-devel][PATCH v

Re: [Qemu-devel] [PATCH] vmdk: Allow selecting SCSI adapter in image creation

2013-01-29 Thread Paolo Bonzini
Il 29/01/2013 00:18, Othmar Pasteka ha scritto: > right after sending the patch I discovered this indentation bug. > I check with checkpatch before sending it, but it didn't complain > and it slipped on my side. Should I resend the patch with that fixed? Yes, please do. Paolo

[Qemu-devel] [PATCH] sheepdog: pass vdi_id to sheep daemon for sd_close()

2013-01-29 Thread Liu Yuan
From: Liu Yuan Sheep daemon needs vdi_id to identify which vdi is closed to release resources such as object cache. Cc: MORITA Kazutaka Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- block/sheepdog.c |1 + 1 file changed, 1 insertion(+) diff --git a/block/sheepdog.c b/b

Re: [Qemu-devel] [PATCH v3 5/5] sheepdog: add support for connecting to unix domain socket

2013-01-29 Thread Paolo Bonzini
Il 29/01/2013 01:11, MORITA Kazutaka ha scritto: > This patch adds support for a unix domain socket for a connection > between qemu and local sheepdog server. You can use the unix domain > socket with the following syntax: > > $ qemu sheepdog+unix:///?[#snapid] Should be "?socket=". Otherwise,

Re: [Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

2013-01-29 Thread Andreas Färber
Am 28.01.2013 22:10, schrieb Peter Maydell: [lengthy discussion of what may go wrong without do { ... } while (0)] We seem to to agree to disagree here. The use of an if (foo) { ... } inside Fred's macro (or my pseudocode?) was what prompted this whole mess, so there is no need to explain that to

Re: [Qemu-devel] [PATCH] sheepdog: pass vdi_id to sheep daemon for sd_close()

2013-01-29 Thread MORITA Kazutaka
At Tue, 29 Jan 2013 16:22:49 +0800, Liu Yuan wrote: > > From: Liu Yuan > > Sheep daemon needs vdi_id to identify which vdi is closed to release resources > such as object cache. > > Cc: MORITA Kazutaka > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Signed-off-by: Liu Yuan > --- > block/sheepdog.

Re: [Qemu-devel] KVM call agenda for 2013-01-29

2013-01-29 Thread Alexander Graf
On 28.01.2013, at 15:14, Anthony Liguori wrote: > Juan Quintela writes: > >> Hi >> >> Please send in any agenda topics you are interested in. > > - Outstanding virtio work for 1.4 > - Multiqueue virtio-net (Amos/Michael) > - Refactorings (Fred/Peter) > - virtio-ccw (Cornelia/Alex) - Wh

Re: [Qemu-devel] [PATCH v3 5/5] sheepdog: add support for connecting to unix domain socket

2013-01-29 Thread MORITA Kazutaka
At Tue, 29 Jan 2013 09:25:13 +0100, Paolo Bonzini wrote: > > Il 29/01/2013 01:11, MORITA Kazutaka ha scritto: > > This patch adds support for a unix domain socket for a connection > > between qemu and local sheepdog server. You can use the unix domain > > socket with the following syntax: > > >

[Qemu-devel] [PATCH v4 1/5] slirp/tcp_subr.c: fix coding style in tcp_connect

2013-01-29 Thread MORITA Kazutaka
Fix coding style in tcp_connect before the next patch. Signed-off-by: MORITA Kazutaka --- slirp/tcp_subr.c | 140 -- 1 files changed, 72 insertions(+), 68 deletions(-) diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c index 1542e43..317dc07 10

[Qemu-devel] [PATCH v4 5/5] sheepdog: add support for connecting to unix domain socket

2013-01-29 Thread MORITA Kazutaka
This patch adds support for a unix domain socket for a connection between qemu and local sheepdog server. You can use the unix domain socket with the following syntax: $ qemu sheepdog+unix:///?socket=[#snapid] Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 82

[Qemu-devel] [PATCH v4 4/5] sheepdog: use inet_connect to simplify connect code

2013-01-29 Thread MORITA Kazutaka
This uses the form ":" for the representation of the sheepdog server to use inet_connect. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 111 ++--- 1 files changed, 30 insertions(+), 81 deletions(-) diff --git a/block/sheepdog.c b/block/sh

[Qemu-devel] [PATCH v4 3/5] sheepdog: accept URIs

2013-01-29 Thread MORITA Kazutaka
The URI syntax is consistent with the NBD and Gluster syntax. The syntax is sheepdog[+tcp]://[host:port]/vdiname[#snapid|#tag] Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 139 - qemu-doc.texi| 16 +++--- qemu-options.hx |

[Qemu-devel] [PATCH v4 2/5] move socket_set_nodelay to osdep.c

2013-01-29 Thread MORITA Kazutaka
Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 11 +-- gdbstub.c |5 ++--- include/qemu/sockets.h |1 + qemu-char.c|6 -- slirp/tcp_subr.c |3 +-- util/osdep.c |6 ++ 6 files changed, 11 insertions(+), 21

Re: [Qemu-devel] [PATCH] sheepdog: pass vdi_id to sheep daemon for sd_close()

2013-01-29 Thread Liu Yuan
On 01/29/2013 04:51 PM, MORITA Kazutaka wrote: > At Tue, 29 Jan 2013 16:22:49 +0800, > Liu Yuan wrote: >> >> From: Liu Yuan >> >> Sheep daemon needs vdi_id to identify which vdi is closed to release >> resources >> such as object cache. >> >> Cc: MORITA Kazutaka >> Cc: Kevin Wolf >> Cc: Stefan

[Qemu-devel] [PATCH v2] sheepdog: pass vdi_id to sheep daemon for sd_close()

2013-01-29 Thread Liu Yuan
From: Liu Yuan Sheep daemon needs vdi_id to identify which vdi is closed to release resources such as object cache. Cc: MORITA Kazutaka Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- v2: rename base_vdi_id as vdi_id to exclude confusion. block/sheepdog.c |5 +++-- 1 fi

[Qemu-devel] 答复: [RFC 19/19] target-unicore32: Refactor debug output macros

2013-01-29 Thread Guan Xuetao
> -邮件原件- > 发件人: Andreas Färber [mailto:afaer...@suse.de] > 发送时间: Sunday, January 27, 2013 21:32 > 收件人: qemu-devel@nongnu.org > 抄送: Andreas Färber; Guan Xuetao (maintainer:UniCore32) > 主题: [RFC 19/19] target-unicore32: Refactor debug output macros > > Make debug output compile-testable even

Re: [Qemu-devel] [RFC V7 06/13] quorum: Add quorum mechanism.

2013-01-29 Thread Stefan Hajnoczi
On Mon, Jan 28, 2013 at 02:22:52PM +0100, Benoît Canet wrote: > +static void quorum_vote(QuorumAIOCB *acb) > +{ > +bool quorum = true; > +int i, j, ret; > +QuorumVoteValue hash; > +BDRVQuorumState *s = acb->bqs; > +QuorumVoteVersion *winner; > + > +/* get the index of the fi

[Qemu-devel] 答复: [PATCH qom-cpu for-1.4] target-unicore32: Rename CPU subtypes

2013-01-29 Thread Guan Xuetao
> -邮件原件- > 发件人: Andreas Färber [mailto:afaer...@suse.de] > 发送时间: Monday, January 28, 2013 23:47 > 收件人: qemu-devel@nongnu.org > 抄送: Guan Xuetao > 主题: Re: [Qemu-devel] [PATCH qom-cpu for-1.4] target-unicore32: Rename > CPU subtypes > > Am 27.01.2013 23:50, schrieb Andreas Färber: > > In th

Re: [Qemu-devel] [PATCH v2] sheepdog: pass vdi_id to sheep daemon for sd_close()

2013-01-29 Thread MORITA Kazutaka
At Tue, 29 Jan 2013 17:14:16 +0800, Liu Yuan wrote: > > From: Liu Yuan > > Sheep daemon needs vdi_id to identify which vdi is closed to release resources > such as object cache. > > Cc: MORITA Kazutaka > Cc: Kevin Wolf > Cc: Stefan Hajnoczi > Signed-off-by: Liu Yuan > --- > v2: rename base

[Qemu-devel] [PATCH v4 0/5] sheepdog: unix domain socket support

2013-01-29 Thread MORITA Kazutaka
This series makes sheepdog accept URI syntax, and adds a unix domain socket support for a connection between qemu and local sheepdog server based on the syntax. Changes from v3: - fix wrong URI syntax in the commit log Changes from v2: - fix coding style in tcp_connect - accept URI syntax Cha

Re: [Qemu-devel] [PATCH V11 3/4] Use QemuOpts support in block layer

2013-01-29 Thread Markus Armbruster
Dong Xu Wang writes: > Markus Armbruster writes: >> Dong Xu Wang writes: >> >>> Markus Armbruster writes: Dong Xu Wang writes: [...] > @@ -264,17 +264,13 @@ static int cow_create(const char *filename, > QEMUOptionParameter *options) >int ret; >BlockDrive

Re: [Qemu-devel] [PATCH 2/2] usb-ehci: add Faraday FUSBH200 support

2013-01-29 Thread Andreas Färber
Am 29.01.2013 06:43, schrieb Kuo-Jung Su: > From: Kuo-Jung Su > > Add Faraday FUSBH200 support, which is slightly different from EHCI spec. > (Or maybe simply a bad/wrong implementation...) > > Signed-off-by: Kuo-Jung Su > Cc: Gerd Hoffmann > Cc: Andreas > Cc: Peter Crosthwaite > --- > hw/u

Re: [Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

2013-01-29 Thread Peter Maydell
On 29 January 2013 08:42, Andreas Färber wrote: > Am 28.01.2013 22:10, schrieb Peter Maydell: > Where we disagree is that you suggest that do { ... while (0) is any > better than G_STMT_START ... G_STMT_END. I disagree and find *both* > obscuring the code. I clearly stated why.P > > Therefore I am

[Qemu-devel] [PATCH] qemu-iotests: Test qcow2 image creation options

2013-01-29 Thread Kevin Wolf
Just create lots of images and try out each of the creation options that qcow2 provides (except backing_file/fmt for now) I'm not totally happy with the behaviour of qemu-img in each of the cases, but let's be explicit and update the test when we do change things later. Signed-off-by: Kevin Wolf

Re: [Qemu-devel] KVM call agenda for 2013-01-29

2013-01-29 Thread Peter Maydell
On 29 January 2013 08:49, Alexander Graf wrote: > - What's the plan for -device and IRQ assignment? > > We need to start coming up with a solution to connect irq > lines between cmdline created devices and interrupt > controllers. Currently, I'm aware of 2 potential users > > - virtio-mmio > -

Re: [Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

2013-01-29 Thread Markus Armbruster
Andreas Färber writes: > Am 28.01.2013 22:10, schrieb Peter Maydell: > [lengthy discussion of what may go wrong without do { ... } while (0)] > > We seem to to agree to disagree here. > > The use of an if (foo) { ... } inside Fred's macro (or my pseudocode?) > was what prompted this whole mess, s

Re: [Qemu-devel] [PATCH 2/2] usb-ehci: add Faraday FUSBH200 support

2013-01-29 Thread Gerd Hoffmann
> This is not what I had in mind. For one thing your initialization does > not need to go before sysbus_init_{irq,mmio}. > > What I am not too sure about without digging out SysBus and PCI EHCI > sources is at which point the fields may get modified. In 1/2 your new > fields are only ever initiali

Re: [Qemu-devel] 答复: [PATCH qom-cpu for-1.4] target-unicore32: Rename CPU subtypes

2013-01-29 Thread Andreas Färber
嗨, Am 29.01.2013 10:25, schrieb Guan Xuetao: >> -邮件原件- >> 发件人: Andreas Färber [mailto:afaer...@suse.de] >> 发送时间: Monday, January 28, 2013 23:47 >> 收件人: qemu-devel@nongnu.org >> 抄送: Guan Xuetao >> 主题: Re: [Qemu-devel] [PATCH qom-cpu for-1.4] target-unicore32: Rename >> CPU subtypes >> >> Am

Re: [Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

2013-01-29 Thread Andreas Färber
Am 29.01.2013 11:03, schrieb Markus Armbruster: > Andreas Färber writes: > >> b) Working around an issue resulting from hiding C statements inside a >> preprocessor macro is totally backwards compared to properly using the C >> language in the first place. Its mechanism for reuse are functions, a

Re: [Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

2013-01-29 Thread Andreas Färber
Am 29.01.2013 10:56, schrieb Peter Maydell: > On 29 January 2013 08:42, Andreas Färber wrote: >> Analysing the reasons for the obscured suggestion: >> >> a) "if (foo) MACRO1(); else MACRO2();" is forbidden by Coding Style. >> Thus, if careful review indicates there are no such Coding Style >> viol

Re: [Qemu-devel] 答复: [RFC 19/19] target-unicore32: Refactor debug output macros

2013-01-29 Thread Andreas Färber
Am 29.01.2013 10:23, schrieb Guan Xuetao: >> -邮件原件- >> 发件人: Andreas Färber [mailto:afaer...@suse.de] >> 发送时间: Sunday, January 27, 2013 21:32 >> 收件人: qemu-devel@nongnu.org >> 抄送: Andreas Färber; Guan Xuetao (maintainer:UniCore32) >> 主题: [RFC 19/19] target-unicore32: Refactor debug output mac

Re: [Qemu-devel] [PATCH qom-cpu for-1.4] target-arm: Rename CPU types

2013-01-29 Thread Peter Maydell
On 27 January 2013 16:30, Andreas Färber wrote: > In the initial conversion of CPU models to QOM types, model names were > mapped 1:1 to type names. As a side effect this gained us a type "any", > which is now a device. > > To avoid "-device any" silliness and to pave the way for compiling > multi

Re: [Qemu-devel] [PATCH v8 2/4] qemu-img: Add "Quiet mode" option

2013-01-29 Thread Kevin Wolf
Am 14.01.2013 11:26, schrieb Miroslav Rezanina: > There can be a need to turn output to stdout off. This patch adds a -q option > that enable "Quiet mode". In Quiet mode, only errors are printed out. > > Signed-off-by: Miroslav Rezanina This patch introduces trailing whitespace in some lines. K

[Qemu-devel] [PATCH 0/2] [PULL] qemu-kvm.git uq/master queue

2013-01-29 Thread Gleb Natapov
The following changes since commit 1356b98d3e95a85071e6bf9a99e8799e1ae1bbee: sysbus: Drop sysbus_from_qdev() cast macro (2013-01-21 13:52:24 -0600) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master for you to fetch changes up to f8bb056564e

[Qemu-devel] [PATCH 1/2] vmxcap: bit 9 of VMX_PROCBASED_CTLS2 is 'virtual interrupt delivery'

2013-01-29 Thread Gleb Natapov
From: Marcelo Tosatti Bit 9 of MSR_IA32_VMX_PROCBASED_CTLS2 is virtual interrupt delivery. Signed-off-by: Marcelo Tosatti --- scripts/kvm/vmxcap |1 + 1 file changed, 1 insertion(+) diff --git a/scripts/kvm/vmxcap b/scripts/kvm/vmxcap index cbe6440..0b23f77 100755 --- a/scripts/kvm/vmxcap

Re: [Qemu-devel] [PATCH v8 3/4] qemu-img: Add compare subcommand

2013-01-29 Thread Kevin Wolf
Am 14.01.2013 11:26, schrieb Miroslav Rezanina: > This patch adds new qemu-img subcommand that compares content of two disk > images. > > Signed-off-by: Miroslav Rezanina > --- > qemu-img-cmds.hx |6 ++ > qemu-img.c | 266 > ++ > 2

[Qemu-devel] [PATCH 2/2] target-i386: kvm: prevent buffer overflow if -cpu foo, [x]level is too big

2013-01-29 Thread Gleb Natapov
From: Igor Mammedov Stack corruption may occur if too big 'level' or 'xlevel' values passed on command line with KVM enabled, due to limited size of cpuid_data in kvm_arch_init_vcpu(). reproduces with: qemu -enable-kvm -cpu qemu64,level=4294967295 or qemu -enable-kvm -cpu qemu64,xlevel=4294967

Re: [Qemu-devel] [PATCH V2 2/4] block: make path_hash_protocol public.

2013-01-29 Thread Benoît Canet
> While you are touching this function, does it make sense to change it to > return 'bool' instead of 'int'? I think so. Benoît

Re: [Qemu-devel] [PATCH v8 3/4] qemu-img: Add compare subcommand

2013-01-29 Thread Miroslav Rezanina
See response inline, if no response that comment will be handled in next version. - Original Message - > From: "Kevin Wolf" > To: "Miroslav Rezanina" > Cc: qemu-devel@nongnu.org > Sent: Tuesday, January 29, 2013 12:28:22 PM > Subject: Re: [Qemu-devel] [PATCH v8 3/4] qemu-img: Add compar

Re: [Qemu-devel] [PATCH V2 4/4] block: Optionally block drivers to optionally reopen images after snapshot creation.

2013-01-29 Thread Kevin Wolf
Am 28.01.2013 18:04, schrieb Benoît Canet: > Protocols like quorum will be able to queue multiple reopens. > > Signed-off-by: Benoit Canet -EPARSE for the subject line. Also, what's the difference between this and a normal reopen? Kevin

Re: [Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

2013-01-29 Thread Markus Armbruster
Andreas Färber writes: > Am 29.01.2013 11:03, schrieb Markus Armbruster: >> Andreas Färber writes: >> >>> b) Working around an issue resulting from hiding C statements inside a >>> preprocessor macro is totally backwards compared to properly using the C >>> language in the first place. Its mech

Re: [Qemu-devel] [PULL 00/15] s390 patch queue 2013-01-25

2013-01-29 Thread Alexander Graf
On 01/28/2013 06:45 PM, Stefan Weil wrote: Am 28.01.2013 18:34, schrieb Cornelia Huck: On Mon, 28 Jan 2013 18:08:10 +0100 Stefan Weil wrote: Am 28.01.2013 17:06, schrieb Cornelia Huck: On Sat, 26 Jan 2013 14:17:36 + Blue Swirl wrote: On Fri, Jan 25, 2013 at 12:48 PM, Alexander Graf w

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Kevin Wolf
Am 28.01.2013 18:04, schrieb Benoît Canet: > Signed-off-by: Benoit Canet > --- > blockdev.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/blockdev.c b/blockdev.c > index 0ce45c5..b1f388b 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -800,7 +800,8 @@ void qmp_t

Re: [Qemu-devel] [PATCH V16 3/9] libqblock: build: add rule for libqblock.la

2013-01-29 Thread Paolo Bonzini
Il 29/01/2013 05:51, Wenchao Xia ha scritto: > Now libqblock.la can be built with neccessary object files, > and can be automatically cleaned by make clean in root directory. > make libqblock-clean also clean it. -fvisibility=hidden was used > to hide symbols, and a special macro was introduced t

Re: [Qemu-devel] [PATCH V5 03/13] block: add bdrv_can_read_snapshot() function

2013-01-29 Thread Kevin Wolf
Am 25.01.2013 19:11, schrieb Eric Blake: > On 01/23/2013 07:57 PM, Wenchao Xia wrote: >> Compared to bdrv_can_snapshot(), this function return whether >> bs* is ready to read snapshot info from instead of write. If yes, >> caller can then query snapshot information, but taking snapshot >> is not

[Qemu-devel] [PATCH] hmp: hmp_memchar_read(): skip non-printable chars

2013-01-29 Thread Luiz Capitulino
Otherwise we can get funny stuff printed and if the buffer contains a '\0' char it won't be fully printed. Signed-off-by: Luiz Capitulino --- hmp.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/hmp.c b/hmp.c index 249b89b..5bfc8bd 100644 --- a/hmp.c +++ b/hm

Re: [Qemu-devel] [PATCH V16 6/9] libqblock: libqblock API design and type defines

2013-01-29 Thread Paolo Bonzini
Il 29/01/2013 05:51, Wenchao Xia ha scritto: > + * qb_fmt_info_new: create a new QBlockFormatInfo structure. > + * > + * return 0 on success, libqblock negative error value on fail. > + * > + * @context: operation context. > + * @p_fmt: pointer that will receive created struct. > + */ > +LIBQB_DLL_

Re: [Qemu-devel] [Bug 1102027] [NEW] QED Time travel

2013-01-29 Thread Stefan Hajnoczi
On Sun, Jan 20, 2013 at 11:54:33AM -, Mekza wrote: > Public bug reported: > > This night after a reboot of a VM, it was back to 8 Oct. 2012, i've lost > all data between 8 Oct 2012 and now. I've check the QED file and mount > on another VM, all seems OK. Hi Mekza, Are you able to reproduce th

Re: [Qemu-devel] [PATCH V16 9/9] libqblock: test: libqblock test example

2013-01-29 Thread Paolo Bonzini
Il 29/01/2013 05:51, Wenchao Xia ha scritto: > In this example, first it will create some qcow2 images, then try get > information including backing file relationship, then it will do sync IO on > the image. > > Signed-off-by: Wenchao Xia Patch 8 alone won't compile. This line: +check-libqbl

Re: [Qemu-devel] [PATCH V5 04/13] block: add snapshot info query function bdrv_query_snapshot_infolist()

2013-01-29 Thread Kevin Wolf
Am 24.01.2013 03:57, schrieb Wenchao Xia: > This patch add function bdrv_query_snapshot_infolist(), which will > return snapshot info of an image in qmp object format. The implementation > code are mostly copied from qemu-img.c with modification to fit more > for qmp based block layer API. > To

Re: [Qemu-devel] [PATCH v8 4/4] Add qemu-img compare documentation

2013-01-29 Thread Kevin Wolf
Am 14.01.2013 11:26, schrieb Miroslav Rezanina: > Adding documentation for new qemu-img subcommand compare. > > Signed-off-by: Miroslav Rezanina > --- > qemu-img.c|7 ++- > qemu-img.texi | 32 > 2 files changed, 38 insertions(+), 1 deletions(-) Ah,

Re: [Qemu-devel] [PATCH qom-cpu for-1.4] target-arm: Rename CPU types

2013-01-29 Thread Andreas Färber
Am 29.01.2013 12:03, schrieb Peter Maydell: > On 27 January 2013 16:30, Andreas Färber wrote: >> In the initial conversion of CPU models to QOM types, model names were >> mapped 1:1 to type names. As a side effect this gained us a type "any", >> which is now a device. >> >> To avoid "-device any"

Re: [Qemu-devel] [PATCH V2 2/4] block: make path_hash_protocol public.

2013-01-29 Thread Kevin Wolf
Am 28.01.2013 18:04, schrieb Benoît Canet: > Signed-off-by: Benoit Canet > --- > block.c |2 +- > include/block/block.h |1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/block.c b/block.c > index 41a9ac0..843583f 100644 > --- a/block.c > +++ b/block.c

Re: [Qemu-devel] QEMU buildbot maintenance state (was: Re: KVM call agenda for 2013-01-29)

2013-01-29 Thread Stefan Hajnoczi
On Mon, Jan 28, 2013 at 03:29:16PM +0100, Daniel Gollub wrote: > > If Daniel does not have sufficient time to administer it, can we maybe > > have that set up on qemu.org instead, with more than one person that has > > access to it? > > JFYI, I just requested if I am allowed to grant Stefan root a

Re: [Qemu-devel] [PATCH V16 1/9] build: add command check-clean

2013-01-29 Thread Paolo Bonzini
Il 29/01/2013 05:51, Wenchao Xia ha scritto: > +CHECK_CLEAN_TARGETS = $(check-unit-y) $(check-qtest-i386-y) > $(check-qtest-x86_64-y) $(check-qtest-sparc64-y) > $(check-qtest-sparc-y) tests/*.o This is just $(check-unit-y) $(check-qtest-y) tests/*.o. At this point it is short enough that you can

Re: [Qemu-devel] [PATCH V16 8/9] libqblock: build: add rules for test case

2013-01-29 Thread Paolo Bonzini
Il 29/01/2013 05:51, Wenchao Xia ha scritto: > Libtool will be used for final link, the rules do nothing if > libqblock was disabled. Temp directory was used to store image > created in test, which will be deleted in clean. > > Signed-off-by: Wenchao Xia > --- > tests/Makefile | 13 +

Re: [Qemu-devel] [PATCH V16 7/9] libqblock: libqblock API implement

2013-01-29 Thread Paolo Bonzini
Il 29/01/2013 05:51, Wenchao Xia ha scritto: > + > +int qb_context_new(QBlockContext **p_context) > +{ > +*p_context = g_malloc0_n(1, sizeof(QBlockContext)); Please use g_malloc0. > +/* AIO code could comes here later. */ > +return 0; > +} Paolo

Re: [Qemu-devel] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-29 Thread harryxiyou
On Tue, Jan 29, 2013 at 12:05 AM, MORITA Kazutaka wrote: > At Mon, 28 Jan 2013 23:43:04 +0800, > harryxiyou wrote: >> >> Following test is Libvirt v0.8.6, which you just add Sheepdog volume >> patch to Libvirt. > > The version doesn't support Sheepdog storage pool and volume. Please > note that m

Re: [Qemu-devel] [PATCH V5 06/13] qemu-img: switch image retrieving function

2013-01-29 Thread Kevin Wolf
Am 24.01.2013 03:57, schrieb Wenchao Xia: > Now qemu-img call block layer function to get image info and check > if error happens. > > Signed-off-by: Wenchao Xia > Reviewed-by: Eric Blake Merge this with patch 5. Kevin

Re: [Qemu-devel] [PATCH V5 05/13] block: add image info query function bdrv_query_image_info()

2013-01-29 Thread Kevin Wolf
Am 24.01.2013 03:57, schrieb Wenchao Xia: > This patch add function bdrv_query_image_info(), which will return > image info in qmp object format. The implementation code are mostly > copied from qemu-img.c, but use block layer function to get snapshot > info. Don't copy code, reuse it. Can you

Re: [Qemu-devel] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt

2013-01-29 Thread harryxiyou
On Tue, Jan 29, 2013 at 8:55 PM, harryxiyou wrote: > On Tue, Jan 29, 2013 at 12:05 AM, MORITA Kazutaka > wrote: >> At Mon, 28 Jan 2013 23:43:04 +0800, >> harryxiyou wrote: >>> >>> Following test is Libvirt v0.8.6, which you just add Sheepdog volume >>> patch to Libvirt. >> >> The version doesn't

Re: [Qemu-devel] KVM call agenda for 2013-01-29

2013-01-29 Thread Andreas Färber
Am 28.01.2013 11:59, schrieb Juan Quintela: > Please send in any agenda topics you are interested in. I/O port rework: * Proposal by Hervé: move I/O port list registration to ISA http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg00508.html This causes modeling issues since PCI VGA/QXL then

Re: [Qemu-devel] [PATCH V5 07/13] block: rename bdrv_query_info to bdrv_query_block_info

2013-01-29 Thread Kevin Wolf
Am 24.01.2013 03:57, schrieb Wenchao Xia: > Now that we have bdrv_query_image_info, rename this function to make it > more obvious what it is doing. > > Reviewed-by: Eric Blake > Signed-off-by: Wenchao Xia Should this provide an option to give information on each image in the backing file cha

Re: [Qemu-devel] [PATCH V5 07/13] block: rename bdrv_query_info to bdrv_query_block_info

2013-01-29 Thread Kevin Wolf
Am 29.01.2013 14:04, schrieb Kevin Wolf: > Am 24.01.2013 03:57, schrieb Wenchao Xia: >> Now that we have bdrv_query_image_info, rename this function to make it >> more obvious what it is doing. >> >> Reviewed-by: Eric Blake >> Signed-off-by: Wenchao Xia > > Should this provide an option to giv

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Benoît Canet
> Wait, what's happening here? I don't understand this patch and how it's > related to snapshotting non-file protocols (if this is even what you > mean). What is your exact scenario, what does the existing code do in > it, and how does this change improve it? An empty commit message is > definitely

Re: [Qemu-devel] [PATCH] fix qemu_flush_queued_packets() in presence of a hub

2013-01-29 Thread Stefan Hajnoczi
On Tue, Jan 22, 2013 at 07:54:20AM +0100, Luigi Rizzo wrote: > when frontend and backend are connected through a hub as below > (showing only one direction), and the frontend (or in general, all > output ports of the hub) cannot accept more traffic, the backend > queues packets in queue-A. > > Whe

Re: [Qemu-devel] [PATCH V2 4/4] block: Optionally block drivers to optionally reopen images after snapshot creation.

2013-01-29 Thread Benoît Canet
Le Tuesday 29 Jan 2013 à 13:22:12 (+0100), Kevin Wolf a écrit : > Am 28.01.2013 18:04, schrieb Benoît Canet: > > Protocols like quorum will be able to queue multiple reopens. > > > > Signed-off-by: Benoit Canet > > -EPARSE for the subject line. > > Also, what's the difference between this and a

Re: [Qemu-devel] [RFC] qemu snapshot enchancement

2013-01-29 Thread Stefan Hajnoczi
On Mon, Jan 28, 2013 at 01:38:40PM +, Dietmar Maurer wrote: > > If you've been using it for 4 years then it was without dm-thin, which is a > > new > > snapshot mechanism that solves limitations of classic LVM snapshot > > volumes. So if you're referring to inefficient LVM snapshots then that

Re: [Qemu-devel] [PATCH] hmp: hmp_memchar_read(): skip non-printable chars

2013-01-29 Thread Markus Armbruster
Luiz Capitulino writes: > Otherwise we can get funny stuff printed and if the buffer contains > a '\0' char it won't be fully printed. > > Signed-off-by: Luiz Capitulino > --- > hmp.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/hmp.c b/hmp.c > index

Re: [Qemu-devel] [PATCH v2 2/3] VFIO-AER: Vfio-pci driver changes for supporting AER

2013-01-29 Thread Alex Williamson
On Mon, 2013-01-28 at 12:31 -0700, Alex Williamson wrote: > On Mon, 2013-01-28 at 09:54 +, Pandarathil, Vijaymohan R wrote: > > - New VFIO_SET_IRQ ioctl option to pass the eventfd that is signalled > > when > > an error occurs in the vfio_pci_device > > > > - Register pci_er

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Kevin Wolf
Am 29.01.2013 14:07, schrieb Benoît Canet: >> Wait, what's happening here? I don't understand this patch and how it's >> related to snapshotting non-file protocols (if this is even what you >> mean). What is your exact scenario, what does the existing code do in >> it, and how does this change impr

Re: [Qemu-devel] [RFC] qemu snapshot enchancement

2013-01-29 Thread Stefan Hajnoczi
On Tue, Jan 29, 2013 at 10:58:56AM +0800, Wenchao Xia wrote: > 于 2013-1-28 21:00, Stefan Hajnoczi 写道: > >On Fri, Jan 25, 2013 at 05:16:46PM +0800, Wenchao Xia wrote: > >>于 2013-1-24 17:47, Stefan Hajnoczi 写道: > >>> > >Case 3: > > > > * What does "blank data" mean? Besides that the use

Re: [Qemu-devel] [PATCH V2 4/4] block: Optionally block drivers to optionally reopen images after snapshot creation.

2013-01-29 Thread Kevin Wolf
Am 29.01.2013 14:09, schrieb Benoît Canet: > Le Tuesday 29 Jan 2013 à 13:22:12 (+0100), Kevin Wolf a écrit : >> Am 28.01.2013 18:04, schrieb Benoît Canet: >>> Protocols like quorum will be able to queue multiple reopens. >>> >>> Signed-off-by: Benoit Canet >> >> -EPARSE for the subject line. >> >>

Re: [Qemu-devel] [RFC] qemu snapshot enchancement

2013-01-29 Thread Paolo Bonzini
Il 29/01/2013 14:27, Stefan Hajnoczi ha scritto: >> > and in step 5, may need export the delta data, not the whole disk >> > data. > NBD doesn't have a way to perform bdrv_is_allocated(). Either we need > to enhance the protocol or we need to add a QMP command to read > the allocation bitmap for a

Re: [Qemu-devel] [RFC] qemu snapshot enchancement

2013-01-29 Thread Dietmar Maurer
> > Are you sure this work on shared iSCSI devices (I have my doubts)? > > If by "shared" you mean clustering support so multiple hosts can access > volumes from the same pool, then the answer is no. Unfortunately this is the standard setup with our environment. > If by "shared" you mean that th

Re: [Qemu-devel] [Bug 1102027] [NEW] QED Time travel

2013-01-29 Thread Mekza
On Tue, Jan 29, 2013 at 1:46 PM, Stefan Hajnoczi <1102...@bugs.launchpad.net > wrote: > On Sun, Jan 20, 2013 at 11:54:33AM -, Mekza wrote: > > Public bug reported: > > > > This night after a reboot of a VM, it was back to 8 Oct. 2012, i've lost > > all data between 8 Oct 2012 and now. I've che

Re: [Qemu-devel] [PATCH] qemu-iotests: Add regression test for b7ab0fea

2013-01-29 Thread Stefan Hajnoczi
On Wed, Jan 23, 2013 at 04:52:49PM +0100, Kevin Wolf wrote: > It turned out that the change in b7ab0fea was actually a real qcow2 > corruption fix. This is a reproducer for the bug. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/047 | 75 > +++

Re: [Qemu-devel] [PATCH V5 09/13] block: export function bdrv_find_snapshot()

2013-01-29 Thread Kevin Wolf
Am 24.01.2013 03:57, schrieb Wenchao Xia: > This patch move it from savevm.c to block.c and export it. To make > it clear about id and name in searching, the API was changed a bit > to distinguish them. Caller can choose to search by id or name now. > > Signed-off-by: Wenchao Xia Please keep c

Re: [Qemu-devel] [PATCH] hmp: hmp_memchar_read(): skip non-printable chars

2013-01-29 Thread Luiz Capitulino
On Tue, 29 Jan 2013 14:20:30 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > Otherwise we can get funny stuff printed and if the buffer contains > > a '\0' char it won't be fully printed. > > > > Signed-off-by: Luiz Capitulino > > --- > > hmp.c | 14 -- > > 1 file c

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Benoît Canet
Le Tuesday 29 Jan 2013 à 14:25:42 (+0100), Kevin Wolf a écrit : > Am 29.01.2013 14:07, schrieb Benoît Canet: > >> Wait, what's happening here? I don't understand this patch and how it's > >> related to snapshotting non-file protocols (if this is even what you > >> mean). What is your exact scenario

Re: [Qemu-devel] [PATCH] qemu-iotests: Test qcow2 image creation options

2013-01-29 Thread Markus Armbruster
Kevin Wolf writes: > Just create lots of images and try out each of the creation options that > qcow2 provides (except backing_file/fmt for now) > > I'm not totally happy with the behaviour of qemu-img in each of the > cases, but let's be explicit and update the test when we do change > things la

Re: [Qemu-devel] [PATCH V2 4/4] block: Optionally block drivers to optionally reopen images after snapshot creation.

2013-01-29 Thread Benoît Canet
Le Tuesday 29 Jan 2013 à 14:30:39 (+0100), Kevin Wolf a écrit : > Am 29.01.2013 14:09, schrieb Benoît Canet: > > Le Tuesday 29 Jan 2013 à 13:22:12 (+0100), Kevin Wolf a écrit : > >> Am 28.01.2013 18:04, schrieb Benoît Canet: > >>> Protocols like quorum will be able to queue multiple reopens. > >>>

Re: [Qemu-devel] [PATCH V2 11/20] tap: support enabling or disabling a queue

2013-01-29 Thread Jason Wang
On 01/26/2013 03:13 AM, Blue Swirl wrote: > On Fri, Jan 25, 2013 at 10:35 AM, Jason Wang wrote: >> This patch introduce a new bit - enabled in TAPState which tracks whether a >> specific queue/fd is enabled. The tap/fd is enabled during initialization and >> could be enabled/disabled by tap_enalbe

[Qemu-devel] [PATCH] PPC: Allow book3s ppc32 to run dcbzl

2013-01-29 Thread Alexander Graf
The bit that makes a dcbz instruction a dcbzl instruction was declared as reserved in ppc32 ISAs. However, hardware simply ignores the bit, making code valid if it simply invokes dcbzl instead of dcbz even on 750 and G4. Thus, mark the bit as unreserved so that we properly emulate a simple dcbz in

Re: [Qemu-devel] [PATCH V2 14/20] vhost: multiqueue support

2013-01-29 Thread Jason Wang
On 01/25/2013 06:35 PM, Jason Wang wrote: > This patch lets vhost support multiqueue. The idea is simple, just launching > multiple threads of vhost and let each of vhost thread processing a subset of > the virtqueues of the device. After this change each emulated device can have > multiple vhost t

Re: [Qemu-devel] [PATCH] qemu-iotests: Test qcow2 image creation options

2013-01-29 Thread Kevin Wolf
Am 29.01.2013 14:43, schrieb Markus Armbruster: >> +echo "=== Check correct interpretation of suffixes for image size ===" >> +echo >> +sizes="1024 1024b 1k 1K 1M 1G 1T " >> +sizes+="1024.0 1024.0b 1.5k 1.5K 1.5M 1.5G 1.5T" >> + >> +echo "== 1. Traditional size parameter ==" >> +echo >> +for s in $

[Qemu-devel] [PATCH V3 00/20] Multiqueue virtio-net

2013-01-29 Thread Jason Wang
Hello all: This seires is an update of last version of multiqueue virtio-net support. This series tries to brings multiqueue support to virtio-net through a multiqueue support tap backend and multiple vhost threads. To support this, multiqueue nic support were added to qemu. This is done by intr

[Qemu-devel] [PATCH V3 03/20] net: intorduce qemu_del_nic()

2013-01-29 Thread Jason Wang
To support multiqueue nic, this patch separate the nic destructor from qemu_del_net_client() to a new helper qemu_del_nic() since the mapping bettween NiCState and NetClientState were not 1:1 in multiqueue. The following patches would refactor this function to support multiqueue nic. Signed-off-by

[Qemu-devel] [PATCH V3 10/20] tap: add Linux multiqueue support

2013-01-29 Thread Jason Wang
This patch add basic multiqueue support for Linux. When multiqueue is needed, we will first check whether kernel support multiqueue tap before creating more queues. Two new functions tap_fd_enable() and tap_fd_disable() were introduced to enable and disable a specific queue. Since the multiqueue is

[Qemu-devel] [PATCH V3 12/20] tap: introduce a helper to get the name of an interface

2013-01-29 Thread Jason Wang
This patch introduces a helper tap_get_ifname() to get the device name of tap device. This is needed when ifname is unspecified in the command line and qemu were asked to create tap device by itself. In this situation, the name were allocated by kernel, so if multiqueue is asked, we need to fetch i

Re: [Qemu-devel] [PATCH qom-cpu for-1.4 0/6] Unmigratable CPUs for 1.4

2013-01-29 Thread Juan Quintela
Andreas Färber wrote: > Hello, > > Prompted by earlier patches from Juan, this series cleans up some targets > that don't implement migration - be it by no-op implementations, by erroring > out in the implementation or by lack of implementation. Agreed with this. At least we move the problem in

[Qemu-devel] [PATCH V3 20/20] virtio-net: compat multiqueue support

2013-01-29 Thread Jason Wang
Disable multiqueue support for pre 1.4. Signed-off-by: Jason Wang --- hw/pc_piix.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 0a6923d..7bc3563 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -297,6 +297,10 @@ static QEMUMachine p

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Kevin Wolf
Am 29.01.2013 14:45, schrieb Benoît Canet: > Le Tuesday 29 Jan 2013 à 14:25:42 (+0100), Kevin Wolf a écrit : >> Am 29.01.2013 14:07, schrieb Benoît Canet: Wait, what's happening here? I don't understand this patch and how it's related to snapshotting non-file protocols (if this is even wh

[Qemu-devel] [PATCH V3 06/20] net: introduce NetClientState destructor

2013-01-29 Thread Jason Wang
To allow allocating an array of NetClientState and free it once, this patch introduces destructor of NetClientState. Which could do type specific free, which could be used by multiqueue to free the array once. Signed-off-by: Jason Wang --- include/net/net.h |2 ++ net/net.c | 17 ++

Re: [Qemu-devel] [PATCH] qemu-iotests: Test qcow2 image creation options

2013-01-29 Thread Markus Armbruster
Kevin Wolf writes: > Am 29.01.2013 14:43, schrieb Markus Armbruster: >>> +echo "=== Check correct interpretation of suffixes for image size ===" >>> +echo >>> +sizes="1024 1024b 1k 1K 1M 1G 1T " >>> +sizes+="1024.0 1024.0b 1.5k 1.5K 1.5M 1.5G 1.5T" >>> + >>> +echo "== 1. Traditional size paramete

Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.

2013-01-29 Thread Benoît Canet
> base1 [file] --- base1 [qcow2] --- snap1.qcow2 --\ > base2 [file] --- base2 [qcow2] --- snap2.qcow2 --->-- quorum > base3 [file] --- base3 [qcow2] --- snap3.qcow2 --/ > > I think the last one is what you really want, but it's certainly not the > case that is enabled by this patch. Yes I am try

  1   2   3   >