Re: [Qemu-devel] [PATCH 00/10] Drop code for non-qdevified IDE, and clean up

2012-12-18 Thread Markus Armbruster
Anthony Liguori writes: > Markus Armbruster writes: > >> *** Important *** >> This *breaks* all non-qdevified controllers, see PATCH 01/10. >> Maintainers are cc'ed. >> >> If you want still more time to qdevify your controller, please speak >> up now, and tell us how much. >> >> The rest of the

Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring.

2012-12-18 Thread Michael S. Tsirkin
On Tue, Dec 18, 2012 at 02:56:58PM +, Peter Maydell wrote: > > True, it is not pure qdev, but it is much simpler and doesn't require > > convincing grumpy maintainers. :) > > I'm not actually personally all that attached to this design -- it's just > trying to implement a suggestion by Anthony

Re: [Qemu-devel] [Bug 1089281] [NEW] kvm crash when writing on disk

2012-12-18 Thread Stefan Hajnoczi
On Wed, Dec 12, 2012 at 10:19:06AM -, xavy wrote: > Public bug reported: > > When running the following command: > > /usr/bin/kvm -S -M pc-1.0 -cpu qemu32 -enable-kvm -m 1024 -smp > 1,sockets=1,cores=1,threads=1 -name winxp -uuid f86ef88f-b90e-699a- > 74b8-9675063fc26e -nodefconfig -nodefault

Re: [Qemu-devel] [PATCH v6 12/12] virtio-blk: add x-data-plane=on|off performance feature

2012-12-18 Thread Michael S. Tsirkin
On Tue, Dec 18, 2012 at 03:57:17PM +0100, Stefan Hajnoczi wrote: > > > @@ -407,6 +409,14 @@ static void virtio_blk_handle_output(VirtIODevice > > > *vdev, VirtQueue *vq) > > > .num_writes = 0, > > > }; > > > > > > +/* Some guests kick before setting VIRTIO_CONFIG_S_DRIVER_OK so

Re: [Qemu-devel] [PATCH] block/raw-win32: Fix compiler warnings (wrong format specifiers)

2012-12-18 Thread Stefan Hajnoczi
On Mon, Dec 17, 2012 at 08:40:01PM +0100, Stefan Weil wrote: > Commit fbcad04d6bfdff937536eb23088a01a280a1a3af added fprintf statements > with wrong format specifiers. > > GetLastError() returns a DWORD which is unsigned long, so %lu must be used. > > Signed-off-by: Stefan Weil > --- > > Do we

Re: [Qemu-devel] [PATCH 07/20] target-i386: cpu_x86_register() consolidate freeing resources

2012-12-18 Thread Eduardo Habkost
On Mon, Dec 17, 2012 at 05:01:19PM +0100, Igor Mammedov wrote: > freeing resources in one place would require setting 'error' > to not NULL, so add some more error reporting before jumping to > exit branch. > > Signed-off-by: Igor Mammedov [...] > +out: > +g_strfreev(model_pieces); > if

Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring.

2012-12-18 Thread Paolo Bonzini
Il 18/12/2012 15:56, Peter Maydell ha scritto: > On 18 December 2012 14:36, Paolo Bonzini wrote: >> Yes, that's true. And you're basically using virtio as the pluggable >> discoverable bus, which is actually a pretty good idea. >> >> However, what you are doing is very similar to what virtio-s390

Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring.

2012-12-18 Thread Michael S. Tsirkin
On Tue, Dec 18, 2012 at 03:59:59PM +0100, Paolo Bonzini wrote: > > It does seem frankly bizarre that adding a new transport requires > > knowing about all the backends (notice how s390-virtio-bus.c has > > to register types for each backend). The kernel gets the transport > > vs backend separation

Re: [Qemu-devel] [Qemu-trivial] [PATCH v1 0/4] Trivial patches

2012-12-18 Thread Stefan Hajnoczi
On Tue, Dec 04, 2012 at 04:04:32PM +1000, Peter Crosthwaite wrote: > My trivial patches from during the freeze. > > Peter Crosthwaite (4): > pflash_cfi01: qemu_log_mask "unimplemented" msg > pflash_cfi0x: Send debug messages to stderr > zynq_slcr: Compile time warning fixes. > arm_gic: Add

[Qemu-devel] SMDK2440 NAND Flash in QEMU 1.2.0

2012-12-18 Thread Reinier Millo Sánchez
Hello I'm trying to implements the Samsung SMDK2440 board on Qemu 1.2.0. I'm basing my implementation in the S3C SoC path publishied by Vincent Sanders in the QEMU-Devel list and the mini2440 Source Code, combined with the user manual of Samsung S3C2440A. Now i'm trying to implement the NAND

Re: [Qemu-devel] [PATCH qom-cpu 1/4] cpu: Introduce CPUListState struct

2012-12-18 Thread Igor Mammedov
On Tue, 18 Dec 2012 08:53:40 +0100 Andreas Färber wrote: > This generalizes {ARM,M68k,Alpha}CPUListState to avoid declaring it for > each target. > > Signed-off-by: Andreas Färber > --- > include/qemu/cpu.h | 12 > target-alpha/cpu.c |9 ++--- > target-arm/helper.c

Re: [Qemu-devel] [PATCH v2] arch_init/ram_load: add error message for block length mismatch

2012-12-18 Thread Stefan Hajnoczi
On Thu, Dec 06, 2012 at 02:08:20PM +0200, Alon Levy wrote: > Signed-off-by: Alon Levy > --- > Please ignore previous version, accidentally removed goto done and used wrong > format size specifiers. > > arch_init.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch_init.c b/arch_in

Re: [Qemu-devel] [Qemu-trivial] [PATCH] gitignore: Add virtfs-proxy-helper

2012-12-18 Thread Stefan Hajnoczi
On Thu, Dec 06, 2012 at 08:03:26PM -0500, Cole Robinson wrote: > > Signed-off-by: Cole Robinson > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan

[Qemu-devel] Is mips-user broken on 64bit host?

2012-12-18 Thread Michael Tokarev
Since at least 1.1 version of qemu, I can't run any mips binary using statically linked qemu-mips on x86_64 host. It immediately fails with SIGSEGV: # chroot mipsroot /bin/bash qemu: uncaught target signal 11 (Segmentation fault) - core dumped mipsroot/bin/bash: ELF 32-bit MSB executable, MIPS,

Re: [Qemu-devel] [PATCH 07/20] target-i386: cpu_x86_register() consolidate freeing resources

2012-12-18 Thread Igor Mammedov
On Tue, 18 Dec 2012 13:28:29 -0200 Eduardo Habkost wrote: > On Mon, Dec 17, 2012 at 05:01:19PM +0100, Igor Mammedov wrote: > > freeing resources in one place would require setting 'error' > > to not NULL, so add some more error reporting before jumping to > > exit branch. > > > > Signed-off-by:

Re: [Qemu-devel] [PATCH] e1000: Discard oversized packets based on SBP|LPE

2012-12-18 Thread Michael Tokarev
On 18.12.2012 17:44, Stefan Hajnoczi wrote: > On Wed, Dec 05, 2012 at 01:31:30PM -0500, Michael Contreras wrote: >> Discard packets longer than 16384 when !SBP to match the hardware behavior. >> >> Signed-off-by: Michael Contreras >> --- >> hw/e1000.c | 7 +-- >> 1 file changed, 5 insertions(

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/4] fix build error on ARM due to wrong glibc check

2012-12-18 Thread Stefan Hajnoczi
On Mon, Dec 10, 2012 at 07:59:44AM +0100, John Spencer wrote: > the test for glibc < 2 "succeeds" wrongly for any non-glibc C library, > and breaks the build on musl libc. > we must first test if __GLIBC__ is defined at all, before using it > unconditionally. > > Signed-off-by: John Spencer > >

Re: [Qemu-devel] [Qemu-trivial] [PATCH 4/4] linux-user/syscall.c: remove wrong forward decl of setgroups()

2012-12-18 Thread Stefan Hajnoczi
On Mon, Dec 10, 2012 at 07:59:46AM +0100, John Spencer wrote: > this declaration is wrong: > the correct prototype on linux is: > int setgroups(size_t size, const gid_t *list); > > since by default musl libc exposes this symbol in unistd.h > additionally to grp.h, the wrong declaration causes a bu

[Qemu-devel] [PATCH 1/3] target-i386/cpu.c: coding style fix

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 2d4fc42..fe27def 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1789,10 +1789,11 @@ void cpu_x86_cpuid(CPUX86State

[Qemu-devel] [PATCH 2/3] target-i386/cpu.c: remove last TAB character from the source

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index fe27def..6bfc8cc 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1787,7 +1787,7 @@ void cpu_x86_cpuid(CPUX86State *env, u

[Qemu-devel] [PATCH 0/3] replace cpuid_*features fields with a featue word array (v3)

2012-12-18 Thread Eduardo Habkost
I would like to give emphasis to the following, from description of patch 3: This should also help avoid bugs like the ones introduced when we added cpuid_7_0_ebx_features. Today, adding a new feature word to the code requires chaning 5 or 6 different places in the code, and it's very easy to mis

[Qemu-devel] [PATCH 07/20 v2] target-i386: cpu_x86_register() consolidate freeing resources

2012-12-18 Thread Igor Mammedov
freeing resources in one place would require setting 'error' to not NULL, so add some more error reporting before jumping to exit branch. Signed-off-by: Igor Mammedov --- v2: - add missing 'return -1' on exit if error is not NULL, Spotted-By: Eduardo Habkost --- target-i386/cpu.

Re: [Qemu-devel] [PATCH v2] exec.c: Use tb1->phys_hash_next directly in tb_remove

2012-12-18 Thread Stefan Hajnoczi
On Wed, Nov 21, 2012 at 07:52:48AM +0800, 陳韋任 (Wei-Ren Chen) wrote: > When tb_remove was first commited at fd6ce8f6, there were three different > calls pass different names to offsetof. In current codebase, the other two > calls are replaced with tb_page_remove. There is no need to have a general

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmmouse_reset(): remove minimal code duplication

2012-12-18 Thread Stefan Hajnoczi
On Thu, Dec 13, 2012 at 03:01:49PM +0100, Laszlo Ersek wrote: > Commit 069ab0eb added a vmmouse_disable() call to vmmouse_reset(). > vmmouse_disable() resets the status already. > > Signed-off-by: Laszlo Ersek > --- > hw/vmmouse.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Tha

Re: [Qemu-devel] [PATCH 1/3] target-i386/cpu.c: coding style fix

2012-12-18 Thread Igor Mammedov
On Tue, 18 Dec 2012 14:29:21 -0200 Eduardo Habkost wrote: > Signed-off-by: Eduardo Habkost > --- > target-i386/cpu.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 2d4fc42..fe27def 100644 > --- a/target-i386/cpu.c > +

Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2012-12-18 Thread Zhi Yong Wu
HI, One stupid question, 'dimm' presents one guest memory, then why it is called as "dimm"? what is its full name? On Tue, Dec 18, 2012 at 8:41 PM, Vasilis Liaskovitis wrote: > This is v4 of the ACPI memory hotplug functionality. Only x86_64 target is > supported (both i440fx and q35). There are

Re: [Qemu-devel] [PATCH] e1000: Discard oversized packets based on SBP|LPE

2012-12-18 Thread Stefan Hajnoczi
On Tue, Dec 18, 2012 at 5:20 PM, Michael Tokarev wrote: > On 18.12.2012 17:44, Stefan Hajnoczi wrote: >> On Wed, Dec 05, 2012 at 01:31:30PM -0500, Michael Contreras wrote: >>> Discard packets longer than 16384 when !SBP to match the hardware behavior. >>> >>> Signed-off-by: Michael Contreras >>>

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Earlier pkg-config probe

2012-12-18 Thread Stefan Hajnoczi
On Sun, Dec 16, 2012 at 11:29:45AM +0100, Stefan Weil wrote: > Probe pkg-config before it is used for the first time (libseccomp check). > > Signed-off-by: Stefan Weil > --- > configure | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Thanks, applied to the trivial pat

[Qemu-devel] [PULL 00/10] Trivial patches for December 8 to 18 2012

2012-12-18 Thread Stefan Hajnoczi
The following changes since commit a8a826a3c3b8c8a1c4def0e9e22b46e78e6163a0: exec: refactor cpu_restore_state (2012-12-16 08:35:24 +) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch changes up to 779ab5e3ddb9ad903f9a0ec21e148ed

[Qemu-devel] [PATCH 04/10] zynq_slcr: Compile time warning fixes.

2012-12-18 Thread Stefan Hajnoczi
From: Peter Crosthwaite Few warnings when compiled with debug printfs enabled. Fixed all. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- hw/zynq_slcr.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/zynq_slcr.c b/

[Qemu-devel] [PATCH 01/10] net, hub: fix the indent in the comments

2012-12-18 Thread Stefan Hajnoczi
From: Zhi Yong Wu Remove some redundant blanks in the comments of net_hub_id_for_client(). Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi --- net/hub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/hub.c b/net/hub.c index be41301..3b2d1ff 100644 --- a/ne

[Qemu-devel] [PATCH 05/10] arm_gic: Add cpu nr to Raised IRQ message

2012-12-18 Thread Stefan Hajnoczi
From: Peter Crosthwaite Add the relevant CPU nr to this debug message to make IRQ debugging more informative. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- hw/arm_gic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm

Re: [Qemu-devel] [PATCH 1/3] target-i386/cpu.c: coding style fix

2012-12-18 Thread Eduardo Habkost
On Tue, Dec 18, 2012 at 05:44:12PM +0100, Igor Mammedov wrote: > On Tue, 18 Dec 2012 14:29:21 -0200 > Eduardo Habkost wrote: > > > Signed-off-by: Eduardo Habkost > > --- > > target-i386/cpu.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/target-i386/cpu.c

[Qemu-devel] [PATCH 02/10] pflash_cfi01: qemu_log_mask "unimplemented" msg

2012-12-18 Thread Stefan Hajnoczi
From: Peter Crosthwaite This printf is informing the user of unimplemented functionality. It should be re-directed to qemu_log(LOG_UNIMP, ...) accordingly. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- hw/pflash_cfi01.c | 6 +++--- 1 file chan

Re: [Qemu-devel] target-i386: Allow tsc-frequency to be larger then 2.147G

2012-12-18 Thread Don Slutz
On 12/16/12 12:06, Michael Tokarev wrote: This is a follow-up to a more-or-less trivial commit, 2e84849aa2cc7f220d3b3668f5f7e3c57bb1b590 . I'm adding some more context - the whole function in question. commit 2e84849aa2cc7f220d3b3668f5f7e3c57bb1b590 Author: Don Slutz Date: Fri Sep 21 20:13:

[Qemu-devel] [PATCH 06/10] gitignore: Add virtfs-proxy-helper

2012-12-18 Thread Stefan Hajnoczi
From: Cole Robinson Signed-off-by: Cole Robinson Signed-off-by: Stefan Hajnoczi --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index bd6ba1c..3ce57cc 100644 --- a/.gitignore +++ b/.gitignore @@ -47,6 +47,7 @@ test-qmp-output-visitor test-string-inpu

Re: [Qemu-devel] [PATCH RFC qom-cpu 2/4] qemu-common.h: Move fprintf_function to qemu-types.h

2012-12-18 Thread Eduardo Habkost
On Tue, Dec 18, 2012 at 08:53:41AM +0100, Andreas Färber wrote: > This avoids a dependency on qemu-common.h from qemu/cpu.h. > > Signed-off-by: Andreas Färber When I introduced qemu-types.h, I just planned to use it for the trivial "typedef struct Foobar Foobar" typedefs that can't be anywhere e

[Qemu-devel] [PATCH 09/10] vmmouse_reset(): remove minimal code duplication

2012-12-18 Thread Stefan Hajnoczi
From: Laszlo Ersek Commit 069ab0eb added a vmmouse_disable() call to vmmouse_reset(). vmmouse_disable() resets the status already. Signed-off-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- hw/vmmouse.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/vmmouse.c b/hw/vmmouse.c index 6

Re: [Qemu-devel] [PATCH] e1000: Discard oversized packets based on SBP|LPE

2012-12-18 Thread Michael Contreras
On Tue, Dec 18, 2012 at 05:49:16PM +0100, Stefan Hajnoczi wrote: > On Tue, Dec 18, 2012 at 5:20 PM, Michael Tokarev wrote: > > On 18.12.2012 17:44, Stefan Hajnoczi wrote: > >> On Wed, Dec 05, 2012 at 01:31:30PM -0500, Michael Contreras wrote: > >>> Discard packets longer than 16384 when !SBP to ma

Re: [Qemu-devel] [PATCH qom-cpu 1/4] cpu: Introduce CPUListState struct

2012-12-18 Thread Eduardo Habkost
On Tue, Dec 18, 2012 at 08:53:40AM +0100, Andreas Färber wrote: > This generalizes {ARM,M68k,Alpha}CPUListState to avoid declaring it for > each target. > > Signed-off-by: Andreas Färber > --- > include/qemu/cpu.h | 12 > target-alpha/cpu.c |9 ++--- > target-arm/helpe

[Qemu-devel] [PATCH 07/10] fix build error on ARM due to wrong glibc check

2012-12-18 Thread Stefan Hajnoczi
From: John Spencer the test for glibc < 2 "succeeds" wrongly for any non-glibc C library, and breaks the build on musl libc. we must first test if __GLIBC__ is defined at all, before using it unconditionally. Signed-off-by: John Spencer Reviewed-by: Stefan Weil Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 0/3] s390: ipl device, cpu reset handler and cpu model support

2012-12-18 Thread Jens Freimann
Hi Alex, here's a reworked version of the ipl-device patch, the cpu reset handler and the patch to query cpu definitions via QMP. Patch 1: Creates a new ipl device and moves ipl code from s390_virtio.c Patch 2: Adds a cpu reset handler to Patch 3 Allow to query cpu types via commandline -? argu

[Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions

2012-12-18 Thread Jens Freimann
From: Viktor Mihajlovski This enables qemu -cpu help to return a list of supported CPU models on s390 and also to query for cpu definitions in the monitor. Initially only cpu model = host is returned. This needs to be reworked into a full-fledged CPU model handling later on. This change is needed

[Qemu-devel] [PATCH 03/10] pflash_cfi0x: Send debug messages to stderr

2012-12-18 Thread Stefan Hajnoczi
From: Peter Crosthwaite These debug info messages should go to stderr rather than stdout. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- hw/pflash_cfi01.c | 8 hw/pflash_cfi02.c | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions

[Qemu-devel] [PATCH 08/10] linux-user/syscall.c: remove wrong forward decl of setgroups()

2012-12-18 Thread Stefan Hajnoczi
From: John Spencer this declaration is wrong: the correct prototype on linux is: int setgroups(size_t size, const gid_t *list); since by default musl libc exposes this symbol in unistd.h additionally to grp.h, the wrong declaration causes a build error. the proper fix is to simply include the c

[Qemu-devel] [PATCH 10/10] configure: Earlier pkg-config probe

2012-12-18 Thread Stefan Hajnoczi
From: Stefan Weil Probe pkg-config before it is used for the first time (libseccomp check). Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- configure | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/configure b/configure index ecdb33a..728caca

[Qemu-devel] [PATCH 1/3] s390: Move IPL code into a separate device

2012-12-18 Thread Jens Freimann
From: Christian Borntraeger Lets move the code to setup IPL for external kernel or via the zipl rom into a separate file. This allows to - define a reboot handler, setting up the PSW appropriately - enhance the boot code to IPL disks that contain a bootmap that was created with zipl under LPAR

Re: [Qemu-devel] [PATCH qom-cpu 3/4] target-ppc: Slim conversion of model definitions to QOM subclasses

2012-12-18 Thread Eduardo Habkost
On Tue, Dec 18, 2012 at 08:53:42AM +0100, Andreas Färber wrote: > Since the model list is highly macrofied, keep ppc_def_t for now and > save a pointer to it in PowerPCCPUClass. This results in a flat list of > subclasses including aliases, to be refined later. > > Move cpu_ppc_init() to translate

[Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-18 Thread Jens Freimann
Add a CPU reset handler to have all CPUs in a PoP compliant state. Signed-off-by: Jens Freimann --- v2 -> v3: * remove FIXME * separate parent reset from local reset by adding a while line * use defines for register reset values v1 -> v2: * move setting of control registers and psa to s390_cpu_

Re: [Qemu-devel] [PATCH 1/3] target-i386/cpu.c: coding style fix

2012-12-18 Thread Andreas Färber
Am 18.12.2012 18:03, schrieb Eduardo Habkost: > On Tue, Dec 18, 2012 at 05:44:12PM +0100, Igor Mammedov wrote: >> On Tue, 18 Dec 2012 14:29:21 -0200 >> Eduardo Habkost wrote: >> >>> Signed-off-by: Eduardo Habkost >>> --- >>> target-i386/cpu.c | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 del

Re: [Qemu-devel] [PATCH 1/3] target-i386/cpu.c: coding style fix

2012-12-18 Thread Eduardo Habkost
On Tue, Dec 18, 2012 at 07:33:13PM +0100, Andreas Färber wrote: > Am 18.12.2012 18:03, schrieb Eduardo Habkost: > > On Tue, Dec 18, 2012 at 05:44:12PM +0100, Igor Mammedov wrote: > >> On Tue, 18 Dec 2012 14:29:21 -0200 > >> Eduardo Habkost wrote: > >> > >>> Signed-off-by: Eduardo Habkost > >>> --

Re: [Qemu-devel] [PATCH qom-cpu 1/4] cpu: Introduce CPUListState struct

2012-12-18 Thread Andreas Färber
Am 18.12.2012 16:59, schrieb Igor Mammedov: > On Tue, 18 Dec 2012 08:53:40 +0100 > Andreas Färber wrote: > >> This generalizes {ARM,M68k,Alpha}CPUListState to avoid declaring it for >> each target. >> >> Signed-off-by: Andreas Färber >> --- >> include/qemu/cpu.h | 12 >> target

Re: [Qemu-devel] [PATCH v2] Added uapi directory into linux-header

2012-12-18 Thread David Howells
Alexander Graf wrote: > But looking through this whole thing, it seems like the root cause is > actually different. We don't want any uapi directories exposed to user > space. So let's go back a step: > > Why do we need the uapi include dir? Because some header is using it. > > linux-headers/as

Re: [Qemu-devel] [PATCH v2] Added uapi directory into linux-header

2012-12-18 Thread David Howells
Alexander Graf wrote: > Could you please try and see if this kernel side patch makes things work for > you too? > > > Alex > > > diff --git a/arch/powerpc/include/uapi/asm/kvm_para.h > b/arch/powerpc/include/uapi/asm/kvm_para.h > index ed0e025..e3af328 100644 > --- a/arch/powerpc/include/ua

[Qemu-devel] [Bug 1091766] [NEW] Physical host crash with Mellanox IB PCI passthrough

2012-12-18 Thread Vlastimil Holer
Public bug reported: (from http://permalink.gmane.org/gmane.comp.emulators.kvm.devel/100736) We have been using PCI passthrough with the Mellanox IB interface (MT27500 Family [ConnectX-3]) on Debian 6.0.6, kernel 3.2.23 and qemu-kvm-1.0 (both from backports). It worked fine until latest update in

[Qemu-devel] (bisected): Is mips-user broken on 64bit host since v1.1?

2012-12-18 Thread Michael Tokarev
On 18.12.2012 20:10, Michael Tokarev wrote: > Since at least 1.1 version of qemu, I can't run any > mips binary using statically linked qemu-mips on x86_64 > host. It immediately fails with SIGSEGV: > > # chroot mipsroot /bin/bash > qemu: uncaught target signal 11 (Segmentation fault) - core dump

Re: [Qemu-devel] [PATCH qom-cpu 1/4] cpu: Introduce CPUListState struct

2012-12-18 Thread Andreas Färber
Am 18.12.2012 18:42, schrieb Eduardo Habkost: > On Tue, Dec 18, 2012 at 08:53:40AM +0100, Andreas Färber wrote: >> diff --git a/include/qemu/cpu.h b/include/qemu/cpu.h >> index 61b7698..5fbb3f9 100644 >> --- a/include/qemu/cpu.h >> +++ b/include/qemu/cpu.h >> @@ -21,6 +21,7 @@ >> #define QEMU_CPU_

[Qemu-devel] [RFC 01/20] qemu-common.h: "use" env parameter in no-op version of qemu_init_vcpu()

2012-12-18 Thread Eduardo Habkost
This will avoid warnings about unused variables when compiling code that calls qemu_init_vcpu(). Signed-off-by: Eduardo Habkost --- qemu-common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-common.h b/qemu-common.h index e674786..bfd4c1a 100644 --- a/qemu-common.h ++

[Qemu-devel] [RFC 05/20] alpha: convert cpu_init to QOM

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-alpha/cpu.h | 5 ++--- target-alpha/translate.c | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/target-alpha/cpu.h b/target-alpha/cpu.h index c04d436..a34cf0e 100644 --- a/target-alpha/cpu.h +++ b/target-alpha/cpu.h @@ -290,

[Qemu-devel] [RFC 11/20] target-openrisc: implement CPU realize() method

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-openrisc/cpu.c | 19 ++- target-openrisc/cpu.h | 1 - 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c index e152a3a..0a8253e 100644 --- a/target-openrisc/cpu.c +++ b/target-ope

[Qemu-devel] [RFC 15/20] target-arm: replace cpu_arm_init() with generic_cpu_init()

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-arm/cpu.h| 6 -- target-arm/helper.c | 13 - 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 718f1d9..bf50ea1 100644 --- a/target-arm/cpu.h +++ b/target-arm/cpu.h @@ -232,7 +23

[Qemu-devel] [RFC 12/20] hw/openrisc_sim.c: coding style/indentation fix

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- hw/openrisc_sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/openrisc_sim.c b/hw/openrisc_sim.c index 23c66df..440dc9e 100644 --- a/hw/openrisc_sim.c +++ b/hw/openrisc_sim.c @@ -96,7 +96,7 @@ static void openrisc_sim_init(QEMUMachineI

[Qemu-devel] [RFC 04/20] cpu: replace trivial old_cpu_init functions

2012-12-18 Thread Eduardo Habkost
Most of the existing old_cpu_init functions were just wrappers around QOM-ready cpu_*_init() functions, so just define cpu_init as a call to those functions (wrapped inside CPU macro). Signed-off-by: Eduardo Habkost --- target-arm/cpu.h| 10 +- target-cris/cpu.h | 10 +-

[Qemu-devel] [RFC 00/20] generic_cpu_init() and generic_cpu_create() functions

2012-12-18 Thread Eduardo Habkost
This is just a proof of concept, of how I think we could gradually move to make the architectures share CPU creation/initialization code. I have implemented a quick cpu_realize() function, just for testing, while we don't have qdev realizefn support implemented. I have converted the following tar

[Qemu-devel] [RFC 13/20] target-openrisc: replace cpu_openrisc_init() with generic_cpu_init()

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- hw/openrisc_sim.c | 2 +- target-openrisc/cpu.c | 22 -- target-openrisc/cpu.h | 4 +--- 3 files changed, 2 insertions(+), 26 deletions(-) diff --git a/hw/openrisc_sim.c b/hw/openrisc_sim.c index 440dc9e..1955854 100644 --- a/hw/openri

[Qemu-devel] [RFC 19/20] target-unicore32: replace uc32_cpu_init() with generic_cpu_init()

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-unicore32/cpu.h| 2 +- target-unicore32/helper.c | 12 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/target-unicore32/cpu.h b/target-unicore32/cpu.h index 43bdd84..ad6fee4 100644 --- a/target-unicore32/cpu.h +++ b/target

[Qemu-devel] [RFC 20/20] cpu: convert cpu_copy() to QOM

2012-12-18 Thread Eduardo Habkost
Instead of using CPUArchState for parameters and return value, get/return CPUState objects. It is still an ugly hack that should die, but at least it's an ugly hack that can use the QOM CPU object if necessary, and allows the calling code to be converted to QOM as well. This also keeps the cpu_co

[Qemu-devel] [RFC 0/3] auto-ballooning prototype (host part)

2012-12-18 Thread Luiz Capitulino
Hi, This series implements an early protoype of a new feature called automatic ballooning. This is based on ideas by Rik van Riel and I also got some help from Rafael Aquini (misconceptions and bugs are all mine, though). The auto-ballooning feature automatically performs balloon inflate and defl

[Qemu-devel] [RFC 2/3] virtio-balloon: add virtio_balloon_conf skeleton

2012-12-18 Thread Luiz Capitulino
Next commit wants it. Signed-off-by: Luiz Capitulino --- hw/virtio-balloon.c | 2 +- hw/virtio-balloon.h | 4 hw/virtio-pci.c | 2 +- hw/virtio-pci.h | 2 ++ hw/virtio.h | 3 ++- 5 files changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/virtio-balloon.c b/hw/virtio-

[Qemu-devel] [RFC 07/20] target-unicore32: convert cpu_init to QOM

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-unicore32/cpu.h| 6 +++--- target-unicore32/helper.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target-unicore32/cpu.h b/target-unicore32/cpu.h index 86a6959..43bdd84 100644 --- a/target-unicore32/cpu.h +++ b/target-unico

Re: [Qemu-devel] [PATCH 03/11] qom: preserve object while unparenting it

2012-12-18 Thread Andreas Färber
Am 05.12.2012 21:44, schrieb Paolo Bonzini: > Avoid that the object disappears after it's deleted from the QOM > composition tree, in case that was the only reference to it. > > Signed-off-by: Paolo Bonzini Reviewed-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409

[Qemu-devel] [RFC 08/20] cpu: move cpu_model_str to CPUState

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- cpu-defs.h | 1 - exec.c | 3 ++- include/qemu/cpu.h | 1 + target-alpha/translate.c | 2 +- target-arm/helper.c | 2 +- target-i386/helper.c | 4 +--- target-m68k/helper.c | 2 +- target-mips/translate.c | 2 +

[Qemu-devel] [RFC 06/20] m68k: convert cpu_init to QOM

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-m68k/cpu.h| 5 ++--- target-m68k/helper.c | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/target-m68k/cpu.h b/target-m68k/cpu.h index fbb35dc..9823267 100644 --- a/target-m68k/cpu.h +++ b/target-m68k/cpu.h @@ -116,7 +116,7 @@

[Qemu-devel] [RFC 02/20] cpu: introduce CPU_GET_ENV macros

2012-12-18 Thread Eduardo Habkost
This will help us gradually convert code based on CPUArchState to QOM-based code. The macro checks for NULL cpu value, so a NULL cpu safely becomes a NULL env pointer. Signed-off-by: Eduardo Habkost --- target-alpha/cpu-qom.h | 7 +++ target-arm/cpu-qom.h| 7 +++ target-cri

[Qemu-devel] [RFC 10/20] cpu: introduce generic_cpu_init() & generic_cpu_create() functions

2012-12-18 Thread Eduardo Habkost
Useful for architectures where cpu_init() is just creation of a CPU object and a call to cpu_realize(). All the functions should need is the base CPU class name and cpu_model string. Any target-specific behavior/information can later be provided by the target-specific CPU class, if necessary. Sig

[Qemu-devel] [RFC 18/20] target-unicore32: move final steps of uc32_cpu_init() to realize function

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-unicore32/cpu.c| 21 + target-unicore32/helper.c | 11 +-- 2 files changed, 22 insertions(+), 10 deletions(-) diff --git a/target-unicore32/cpu.c b/target-unicore32/cpu.c index 76750da..5467127 100644 --- a/target-unicore3

[Qemu-devel] [RFC 16/20] target-m68k: move final steps of cpu_m68k_init() to realize function

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-m68k/cpu.c| 52 +++- target-m68k/helper.c | 47 +-- 2 files changed, 52 insertions(+), 47 deletions(-) diff --git a/target-m68k/cpu.c b/target-m68k/cpu.c inde

[Qemu-devel] [RFC 14/20] target-arm: move final steps of cpu_arm_init() to realize function

2012-12-18 Thread Eduardo Habkost
This way we will be able to replace cpu_arm_init() with generic_cpu_init(). Signed-off-by: Eduardo Habkost --- target-arm/cpu-qom.h | 1 - target-arm/cpu.c | 76 +++- target-arm/helper.c | 76 +-

Re: [Qemu-devel] [PATCH 10/11] cpu: do not use object_delete

2012-12-18 Thread Andreas Färber
Am 05.12.2012 21:44, schrieb Paolo Bonzini: > CPUs are never added to the composition tree, so delete is achieved > simply by removing the last references to them. > > Signed-off-by: Paolo Bonzini Reviewed-by: Andreas Färber Note however that x86 is undergoing major changes and other targets a

[Qemu-devel] [RFC 17/20] target-m68k: replace cpu_m68k_init() with generic_cpu_init()

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-m68k/cpu.h| 3 +-- target-m68k/helper.c | 14 -- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/target-m68k/cpu.h b/target-m68k/cpu.h index 9823267..3573c05 100644 --- a/target-m68k/cpu.h +++ b/target-m68k/cpu.h @@ -116,7

[Qemu-devel] [RFC 1/3] virtio-balloon: add guest_get_actual_ram()

2012-12-18 Thread Luiz Capitulino
A future commit will also want to use this. Signed-off-by: Luiz Capitulino --- hw/virtio-balloon.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c index dd1a650..03248df 100644 --- a/hw/virtio-balloon.c +++ b/hw/virtio-balloon

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread Paolo Bonzini
Il 18/12/2012 21:59, Anthony Liguori ha scritto: > But this series breaks the build of make check. It's not just one test > case but almost every single one. I think you must have eliminated an > implicit include of qemu-common.h which makes PRId64 et al all > undeclared. > > I started fixing th

[Qemu-devel] [RFC 3/3] virtio-balloon: add auto-ballooning support

2012-12-18 Thread Luiz Capitulino
The auto-ballooning feature automatically performs balloon inflate or deflate based on host and guest memory pressure. This can help to avoid swapping or worse in both, host and guest. Auto-ballooning has a host and a guest part. The host performs automatic inflate by requesting the guest to infla

[Qemu-devel] [RFC 03/20] cpu: make cpu_init return CPUState QOM object

2012-12-18 Thread Eduardo Habkost
This will allow us to gradually change the existing cpu_init()/cpu_copy() code to use QOM, and to gradually move CPU_COMMON fields to CPUState. The existing implementations were mechanically changed to be called 'old_cpu_init', and a wrapper was added to all architectures. Later the wrappers and

Re: [Qemu-devel] [PATCH 01/11] qdev: export and use qbus_init

2012-12-18 Thread Andreas Färber
Am 05.12.2012 21:44, schrieb Paolo Bonzini: > BusState subclasses need to do their own allocation because > qbus_create_inplace calls object_initialize (which wipes out the > "free" callback). This patch separates the initialization of the object > (object_initialize) from its insertion in the qde

Re: [Qemu-devel] [PATCH 10/11] cpu: do not use object_delete

2012-12-18 Thread Paolo Bonzini
Il 18/12/2012 22:07, Andreas Färber ha scritto: >> > CPUs are never added to the composition tree, so delete is achieved >> > simply by removing the last references to them. >> > >> > Signed-off-by: Paolo Bonzini > Reviewed-by: Andreas Färber > > Note however that x86 is undergoing major change

[Qemu-devel] [RFC 09/20] cpu: introduce cpu_realize()

2012-12-18 Thread Eduardo Habkost
This is just for testing/demonstration purposes. Probably this will be replaced by the more generic DeviceState realize() method, later. Signed-off-by: Eduardo Habkost --- include/qemu/cpu.h | 13 + qom/cpu.c | 10 ++ 2 files changed, 23 insertions(+) diff --git a/i

Re: [Qemu-devel] (bisected): Is mips-user broken on 64bit host since v1.1?

2012-12-18 Thread Stefan Weil
Am 18.12.2012 20:05, schrieb Michael Tokarev: On 18.12.2012 20:10, Michael Tokarev wrote: Since at least 1.1 version of qemu, I can't run any mips binary using statically linked qemu-mips on x86_64 host. It immediately fails with SIGSEGV: # chroot mipsroot /bin/bash qemu: uncaught target signa

Re: [Qemu-devel] (bisected): Is mips-user broken on 64bit host since v1.1?

2012-12-18 Thread Alexander Graf
On 18.12.2012, at 20:05, Michael Tokarev wrote: > On 18.12.2012 20:10, Michael Tokarev wrote: >> Since at least 1.1 version of qemu, I can't run any >> mips binary using statically linked qemu-mips on x86_64 >> host. It immediately fails with SIGSEGV: >> >> # chroot mipsroot /bin/bash >> qemu:

Re: [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API

2012-12-18 Thread Eric Blake
On 12/17/2012 03:13 AM, Dietmar Maurer wrote: >> Next commit will re-enable balloon stats with a different interface, but this >> old code conflicts with it. Let's drop it. > > I don't really see any conflicts here? > >> It's important to note that the QMP and HMP interfaces are also dropped by >

Re: [Qemu-devel] [PULLv2] pci,net,misc infrastructure

2012-12-18 Thread Michael S. Tsirkin
On Mon, Dec 17, 2012 at 01:12:10PM +0200, Michael S. Tsirkin wrote: > On Sun, Dec 16, 2012 at 11:11:37PM +0200, Michael S. Tsirkin wrote: > > The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d: > > > > Merge remote-tracking branch 'afaerber/qom-cpu' into staging (2012-12

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread Paolo Bonzini
Ok... I had really merged the wrong branch with mst's. I fixed it up and pushed again to the same place; it's now commit 6cdf60e, "make check" builds and passes. Here is the diff, sorry for the mistake. Paolo On Tue, Dec 18, 2012 at 10:11 PM, Paolo Bonzini wrote: > Il 18/12/2012 21:59, Antho

Re: [Qemu-devel] [PATCH 5/8] qdev: Coding style fixes

2012-12-18 Thread Andreas Färber
Am 05.12.2012 17:49, schrieb Eduardo Habkost: > Add missing braces and break lines larger than 80 chars. > > Signed-off-by: Eduardo Habkost Thanks, applied to qom-cpu queue: https://github.com/afaerber/qemu-cpu/commits/qom-cpu Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread Paolo Bonzini
And how does it conflicts with Alex's ppc pull request? It is a fast forward from origin/master as of now (commit a8a826a, exec: refactor cpu_restore_state, 2012-12-04), and that includes Alex's commits... Paolo On Tue, Dec 18, 2012 at 10:11 PM, Paolo Bonzini wrote: > Il 18/12/2012 21:59, Ant

Re: [Qemu-devel] [PATCH 6/8] qdev-properties.c: Separate core from the code used only by qemu-system-*

2012-12-18 Thread Andreas Färber
Am 05.12.2012 17:49, schrieb Eduardo Habkost: > This separates the qdev properties code in two parts: > - qdev-properties.c, that contains most of the qdev properties code; > - qdev-properties-system.c for code specific for qemu-system-*, >containing: >- Property types: drive, chr, netdev

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread Anthony Liguori
Paolo Bonzini writes: > Ok... I had really merged the wrong branch with mst's. I fixed it up and > pushed again to the same place; it's now commit 6cdf60e, "make check" > builds and passes. > > Here is the diff, sorry for the mistake. No problem. I'm processing other pull requests now but will

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread Anthony Liguori
Paolo Bonzini writes: > And how does it conflicts with Alex's ppc pull request? It is a fast > forward from origin/master as of now (commit a8a826a, exec: refactor > cpu_restore_state, 2012-12-04), and that includes Alex's commits... Something from the e500 changes because hw/ppc/e500.c and hw/p

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread Michael S. Tsirkin
On Tue, Dec 18, 2012 at 04:35:53PM -0600, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Ok... I had really merged the wrong branch with mst's. I fixed it up and > > pushed again to the same place; it's now commit 6cdf60e, "make check" > > builds and passes. > > > > Here is the diff, sorry

Re: [Qemu-devel] [Bug 1089006] Re: Qemu scrambles order of eth devices in vm

2012-12-18 Thread john fisher
For the benefit of 1) others and 2) me when I forget how this works- I did find a solution in formatting the xml file. If you leave the vnets out completely, see file below, the generic xml file will cooperate with libvirt and qemu and order the VM's eth devices as they are ordered on the hyper

Re: [Qemu-devel] [RFC 00/20] generic_cpu_init() and generic_cpu_create() functions

2012-12-18 Thread Andreas Färber
Am 18.12.2012 21:03, schrieb Eduardo Habkost: > This is just a proof of concept, of how I think we could gradually move to > make the architectures share CPU creation/initialization code. > > I have implemented a quick cpu_realize() function, just for testing, while we > don't have qdev realizefn

<    1   2   3   >