Anthony Liguori <anth...@codemonkey.ws> writes: > Markus Armbruster <arm...@redhat.com> writes: > >> *** Important *** >> This *breaks* all non-qdevified controllers, see PATCH 01/10. >> Maintainers are cc'ed. >> >> If you want still more time to qdevify your controller, please speak >> up now, and tell us how much. >> >> The rest of the series is obvious cleanups enabled by dropping the >> special case of a non-qdevified controller. The block configuration >> stuff I'm working on also profits from it, and is real reason I'm >> posting this. > > Breaking is not the right approach. If you're asserting that the code > is unused and unloved, then remove it entirely from the tree.
Can do. > Just breaking something is always wrong though. > > I only see three users of ide_init2_with_non_qdev_drives. Is there any > reason you didn't just convert these users to qdev? Yes: it's more work than I can do on the side.