Re: [Qemu-devel] [PULL 0/5] Block patches for 1.1

2012-05-31 Thread Kevin Wolf
Am 31.05.2012 02:52, schrieb Anthony Liguori: > On 05/30/2012 09:37 PM, Kevin Wolf wrote: >> The following changes since commit e78bd5ab07d65fec77fcae468b2836c79a836d49: >> >>xhci: add usage info to docs (2012-05-30 10:28:44 +0800) >> >> are available in the git repository at: >>git://repo.

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 00:53, Luigi Rizzo ha scritto: > The image contains my fast packet generator "pkt-gen" (a stock > traffic generator such as netperf etc. is too slow to show the > problem). pkt-gen can send about 1Mpps in this configuration using > -net netmap in the backend. The qemu process in this

Re: [Qemu-devel] [PATCH 0/2] qmp: implement readline handlig for stdio

2012-05-31 Thread Kevin Wolf
Am 30.05.2012 18:41, schrieb Luiz Capitulino: > On Wed, 30 May 2012 16:19:43 +0200 > Kevin Wolf wrote: > >> Am 30.05.2012 12:01, schrieb Pavel Hrdina: >>> For debug it would be nice to have a same functionality for the qmp monitor >>> on stdio as the hmp monitor on stdio has. For this purpose we

Re: [Qemu-devel] [PATCH qom-next] qom: make object cast assert if NULL object is passed as argument

2012-05-31 Thread Igor Mammedov
On 05/30/2012 07:05 PM, Igor Mitsyanko wrote: On 05/30/2012 08:19 PM, Igor Mammedov wrote: without assert it will crash at following point: OBJECT_CHECK(type, obj, name) \ ((type *)object_dynamic_cast_assert(OBJECT(obj), (name))) => object_dynamic_cast(obj, typename) => object_is_type(obj, targe

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Luigi Rizzo
On Thu, May 31, 2012 at 9:38 AM, Paolo Bonzini wrote: > Il 31/05/2012 00:53, Luigi Rizzo ha scritto: > > The image contains my fast packet generator "pkt-gen" (a stock > > traffic generator such as netperf etc. is too slow to show the > > problem). pkt-gen can send about 1Mpps in this configurati

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Jan Kiszka
On 2012-05-31 09:38, Paolo Bonzini wrote: > Il 31/05/2012 00:53, Luigi Rizzo ha scritto: >> The image contains my fast packet generator "pkt-gen" (a stock >> traffic generator such as netperf etc. is too slow to show the >> problem). pkt-gen can send about 1Mpps in this configuration using >> -net

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Jan Kiszka
On 2012-05-31 10:23, Luigi Rizzo wrote: > But i think it would be more robust to make fewer assumptions on > what the guest does, and send the notify on all register writes > (those are relatively rare in a driver, and the datapath touches > exactly the registers we ought to be interested in), > an

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Luigi Rizzo
On Thu, May 31, 2012 at 10:23 AM, Jan Kiszka wrote: > On 2012-05-31 09:38, Paolo Bonzini wrote > ... > > This still looks like the wrong tool: Packets that can't be delivered > are queued. So we need to flush the queue and clear the blocked delivery > there. qemu_flush_queued_packets appears mor

Re: [Qemu-devel] [PATCH qom-next] qom: make object cast assert if NULL object is passed as argument

2012-05-31 Thread Markus Armbruster
Igor Mitsyanko writes: > On 05/30/2012 08:19 PM, Igor Mammedov wrote: >> without assert it will crash at following point: >> OBJECT_CHECK(type, obj, name) \ >> ((type *)object_dynamic_cast_assert(OBJECT(obj), (name))) >>=> object_dynamic_cast(obj, typename) >> => obj

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Jan Kiszka
On 2012-05-31 10:32, Luigi Rizzo wrote: > On Thu, May 31, 2012 at 10:23 AM, Jan Kiszka wrote: > >> On 2012-05-31 09:38, Paolo Bonzini wrote >> > ... > >> >> This still looks like the wrong tool: Packets that can't be delivered >> are queued. So we need to flush the queue and clear the blocked de

Re: [Qemu-devel] Can't convert to vmdk with the streamOptimized subformat

2012-05-31 Thread Stefan Hajnoczi
On Thu, May 31, 2012 at 12:59 AM, Sebastien Douche wrote: > Hi all, > I'm trying to convert a qcow2 image file to the vmdk (on Ubuntu Server 12.04): > > root@srv8:/srv/kvm/lib# qemu-img convert -f qcow2 -O vmdk -o Stream > spv-2912.qcow2 spv-2912-3.vmdk -o subformat=streamOptimized > VMDK: can't w

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Stefan Hajnoczi
On Wed, May 30, 2012 at 8:59 AM, Luigi Rizzo wrote: > Hi, > while investigating rx performance for emulated network devices > (i am looking at the userspace version, relying on net=tap > or similar approaches) i noticed the code > in net/queue.c :: qemu_net_queue_send() > which look strange to me

Re: [Qemu-devel] general question

2012-05-31 Thread Wei-Ren Chen
> Hmmm, does it? > > void helper_invlpg(target_ulong addr) > { > helper_svm_check_intercept_param(SVM_EXIT_INVLPG, 0); > tlb_flush_page(env, addr); > } I would be wrong, so let the code speak. ;) --- void tlb_flush_page(CPUArchState *env, target_ulong addr) { if ((addr & env->tlb_f

Re: [Qemu-devel] [PATCH block-next 0/3] qemu-img check/qcow2: Allow fixing refcounts

2012-05-31 Thread Stefan Hajnoczi
On Wed, May 30, 2012 at 9:31 AM, Zhi Yong Wu wrote: > On Sat, May 12, 2012 at 12:48 AM, Kevin Wolf wrote: >> A prerequisite for a "QED mode" in qcow2, which doesn't update the refcount > Recently some new concepts such as "QED mode" in qcow2 are seen > frequencely, can anyone explain what it mean

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Luigi Rizzo
On Thu, May 31, 2012 at 11:18 AM, Stefan Hajnoczi wrote: > On Wed, May 30, 2012 at 8:59 AM, Luigi Rizzo wrote: > > Hi, > > while investigating rx performance for emulated network devices > > (i am looking at the userspace version, relying on net=tap > > or similar approaches) i noticed the code >

Re: [Qemu-devel] [PATCH qom-next] qom: make object cast assert if NULL object is passed as argument

2012-05-31 Thread Igor Mitsyanko
On 05/31/2012 12:11 PM, Igor Mammedov wrote: On 05/30/2012 07:05 PM, Igor Mitsyanko wrote: On 05/30/2012 08:19 PM, Igor Mammedov wrote: without assert it will crash at following point: OBJECT_CHECK(type, obj, name) \ ((type *)object_dynamic_cast_assert(OBJECT(obj), (name))) => object_dynamic_ca

Re: [Qemu-devel] general question

2012-05-31 Thread Max Filippov
On Thu, May 31, 2012 at 1:21 PM, ���f任 (Wei-Ren Chen) wrote: >> Hmmm, does it? >> >> void helper_invlpg(target_ulong addr) >> { >> helper_svm_check_intercept_param(SVM_EXIT_INVLPG, 0); >> tlb_flush_page(env, addr); >> } > > I would be wrong, so let the code speak. ;) > > --- > void tlb_fl

Re: [Qemu-devel] [PATCH qom-next] qom: make object cast assert if NULL object is passed as argument

2012-05-31 Thread Igor Mammedov
On 05/31/2012 11:34 AM, Igor Mitsyanko wrote: On 05/31/2012 12:11 PM, Igor Mammedov wrote: On 05/30/2012 07:05 PM, Igor Mitsyanko wrote: On 05/30/2012 08:19 PM, Igor Mammedov wrote: without assert it will crash at following point: OBJECT_CHECK(type, obj, name) \ ((type *)object_dynamic_cast_as

[Qemu-devel] [PATCH, v2] qemu/xendisk: set maximum number of grants to be used

2012-05-31 Thread Jan Beulich
Legacy (non-pvops) gntdev drivers may require this to be done when the number of grants intended to be used simultaneously exceeds a certain driver specific default limit. Change in v2: Double the number requested, as we need to account for the allocations needing to happen in contiguous chunks. T

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 10:23, Jan Kiszka ha scritto: >> > @@ -922,6 +923,7 @@ set_rdt(E1000State *s, int index, uint32_t val) >> > { >> > s->check_rxov = 0; >> > s->mac_reg[index] = val & 0x; >> > +qemu_notify_event(); > This still looks like the wrong tool: Packets that can't be delivere

Re: [Qemu-devel] general question

2012-05-31 Thread Peter Maydell
On 31 May 2012 10:21, 陳韋任 (Wei-Ren Chen) wrote: > void tlb_flush_page(CPUArchState *env, target_ulong addr) > { >    if ((addr & env->tlb_flush_mask) == env->tlb_flush_addr) { >        tlb_flush(env, 1); --- (1) >        return; >    } This case (see the comments) is only for handling "large page

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 11:34, Luigi Rizzo ha scritto: > > > i was under the impression that qemu_net_queue_deliver() may also return > 0 if the other side (frontend network device) has no room for the packet. Correct. > This would cause the queue to > contain data on entry in the next call, even without

Re: [Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 10:44, Roni Luxenberg ha scritto: > a continuous replication application expects to get all IOs in the same order > as > issued by the guest irrespective of the (rate of the) flushes done within the > guest. Does real hardware give such consistency, unless you disable caching? > T

Re: [Qemu-devel] [PATCH qom-next] qom: make object cast assert if NULL object is passed as argument

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 10:30, Markus Armbruster ha scritto: >> > Makes much sense, but maybe it should be done in OBJECT() cast? Assert >> > when we do OBJECT(NULL). > In my opinion, OBJECT(p) where p is a null pointer is perfectly valid > and should yield a null pointer. Perhaps object_dynamic_cast and ob

Re: [Qemu-devel] [PATCH, v2] qemu/xendisk: set maximum number of grants to be used

2012-05-31 Thread Stefano Stabellini
On Thu, 31 May 2012, Jan Beulich wrote: > Legacy (non-pvops) gntdev drivers may require this to be done when the > number of grants intended to be used simultaneously exceeds a certain > driver specific default limit. > > Change in v2: Double the number requested, as we need to account for > the a

Re: [Qemu-devel] Can't convert to vmdk with the streamOptimized subformat

2012-05-31 Thread Sebastien Douche
On Thu, May 31, 2012 at 11:10 AM, Stefan Hajnoczi wrote: > Hi Sebastien, Hi Stephan > It won't be possible for QEMU 1.1 since the release is imminent. Sad news. This bug impose Virtualbox for the conversion :(. BTW, thanks Stephan for your quick reponse. -- Sebastien Douche Twitter: @sdou

Re: [Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-31 Thread ronnie sahlberg
On Fri, May 25, 2012 at 11:25 PM, Paolo Bonzini wrote: > Il 25/05/2012 14:09, Stefan Hajnoczi ha scritto: >>> > >>> > Perhaps that be simply a new qemu-img subcommand?  It should be possible >>> > to run it while the VM is offline.  Then the file that is produced could >>> > be fed to blockdev-dir

Re: [Qemu-devel] [PATCH 1/2] qmp: use readline mode for stdio

2012-05-31 Thread Paolo Bonzini
Il 30/05/2012 12:01, Pavel Hrdina ha scritto: > Instead of using an echo for '-qmp stdio' we use a readline mode. The > readline mode > adds a history for users which is useful. > > Signed-off-by: Pavel Hrdina > --- > monitor.c | 83 +---

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Jan Kiszka
On 2012-05-31 11:34, Luigi Rizzo wrote: > On Thu, May 31, 2012 at 11:18 AM, Stefan Hajnoczi wrote: > >> On Wed, May 30, 2012 at 8:59 AM, Luigi Rizzo wrote: >>> Hi, >>> while investigating rx performance for emulated network devices >>> (i am looking at the userspace version, relying on net=tap >>

Re: [Qemu-devel] [PATCH 2/2] qmp: revert "add set_echo implementation for qemu_chr_stdio"

2012-05-31 Thread Paolo Bonzini
Il 30/05/2012 14:49, Eric Blake ha scritto: > On 05/30/2012 04:01 AM, Pavel Hrdina wrote: >> This reverts commit bb002513a9bd2bff169c3d431a8f00c5b2e3aa99 because this >> code is not used >> in order that we use readline mode for '-qmp stdio'. >> >> Conflicts: >> >> qemu-char.c > > This is ev

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Jan Kiszka
On 2012-05-31 12:03, Paolo Bonzini wrote: > Il 31/05/2012 10:23, Jan Kiszka ha scritto: @@ -922,6 +923,7 @@ set_rdt(E1000State *s, int index, uint32_t val) { s->check_rxov = 0; s->mac_reg[index] = val & 0x; +qemu_notify_event(); >> This still looks like t

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Paolo Bonzini
Il 30/05/2012 16:14, Luiz Capitulino ha scritto: > New errors for write() and open() failures. Will be used by the > next commits. Ouch. We have already these errors: #define QERR_OPEN_FILE_FAILED \ "{ 'class': 'OpenFileFailed', 'data': { 'filename': %s } }" #define QERR_SOCKET_CONNECT_FAIL

Re: [Qemu-devel] [PATCH] s390x: fix s390 virtio aliases

2012-05-31 Thread Christian Borntraeger
On 18/05/12 02:43, Alexander Graf wrote: > Some of the virtio devices have the same frontend name, but actually > implement different devices behind the scenes through aliases. > > The indicator which device type to use is the architecture. On s390, we > want s390 virtio devices. On everything els

Re: [Qemu-devel] [PATCH 01/14] qerror: extend QERR_TOO_MANY_FILES

2012-05-31 Thread Paolo Bonzini
Il 30/05/2012 16:14, Luiz Capitulino ha scritto: > Specify it's too many open files in system (ENFILE). > > There's no compatibility issue because QERR_TOO_MANY_FILES is actually > not used today. Let's kill it then. :) Are there any others? Paolo > Signed-off-by: Luiz Capitulino > --- > qer

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Jan Kiszka
On 2012-05-31 11:18, Stefan Hajnoczi wrote: > On Wed, May 30, 2012 at 8:59 AM, Luigi Rizzo wrote: >> Hi, >> while investigating rx performance for emulated network devices >> (i am looking at the userspace version, relying on net=tap >> or similar approaches) i noticed the code >> in net/queue.c :

Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/25] dt: add helper for 64bit cell adds

2012-05-31 Thread David Gibson
On Wed, May 30, 2012 at 01:00:29PM +0200, Alexander Graf wrote: > Some times in the device tree, we find an array of 2 u32 cells that > really are a single u64 value. This patch adds a helper to make the > creation of these easy. I don't like the name. "cell" is pretty strongly associated with a

Re: [Qemu-devel] [Qemu-ppc] [PATCH 06/25] dt: add helper for empty dt creation

2012-05-31 Thread David Gibson
On Wed, May 30, 2012 at 01:00:27PM +0200, Alexander Graf wrote: > We want to get rid of the concept of loading an external device tree and > instead > generate our own. However, to do this we need to also create a device tree > template programatically. > > This patch adds a helper to create an e

Re: [Qemu-devel] [PATCH] slirp: add 'cmd:' target for guestfwd

2012-05-31 Thread Jan Kiszka
On 2012-05-31 01:08, Alexander Graf wrote: > > On 04.06.2011, at 08:12, Alexander Graf wrote: > >> When using guestfwd=, Qemu only connects the virtual server's TCP port >> to a single chardev. This is useless in most cases, as we usually want >> to have more than a single connection from the gue

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-31 Thread Paolo Bonzini
Il 30/05/2012 15:26, Luiz Capitulino ha scritto: >> > >> > qapi-types.h: >> > typedef enum KeyCodes >> > { >> > KEY_CODES_SHIFT = 0, >> > KEY_CODES_SHIFT_R = 1, >> > KEY_CODES_ALT = 2, >> > >> > KEY_CODES_< = .. >> > >> > ^^^ problem should exist here > That's b

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 12:40, Jan Kiszka ha scritto: > On 2012-05-31 12:03, Paolo Bonzini wrote: >> Il 31/05/2012 10:23, Jan Kiszka ha scritto: > @@ -922,6 +923,7 @@ set_rdt(E1000State *s, int index, uint32_t val) > { > s->check_rxov = 0; > s->mac_reg[index] = val & 0x; >

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Stefano Stabellini
On Thu, 31 May 2012, Paolo Bonzini wrote: > Il 31/05/2012 00:53, Luigi Rizzo ha scritto: > > The image contains my fast packet generator "pkt-gen" (a stock > > traffic generator such as netperf etc. is too slow to show the > > problem). pkt-gen can send about 1Mpps in this configuration using > > -

Re: [Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-31 Thread Geert Jansen
On 05/30/2012 05:06 PM, Paolo Bonzini wrote: I think it's beginning to dawn on me that what you have is correct, when i combine this: 2) target flushes do not have to coincide with a source flush. Writes after the last source flush _can_ be inconsistent between the source and the destinatio

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 13:06, Stefano Stabellini ha scritto: >> > For Xen I think this is not possible at the moment because it doesn't >> > implement rx notification. > > Why do you say that? Xen supports the iothread and CONFIG_EVENTFD. No, it's not that. I was talking about feature-rx-notify. But I

Re: [Qemu-devel] [PATCH qom-next] qom: make object cast assert if NULL object is passed as argument

2012-05-31 Thread Igor Mammedov
On 05/31/2012 12:16 PM, Paolo Bonzini wrote: Il 31/05/2012 10:30, Markus Armbruster ha scritto: Makes much sense, but maybe it should be done in OBJECT() cast? Assert when we do OBJECT(NULL). In my opinion, OBJECT(p) where p is a null pointer is perfectly valid and should yield a null pointer.

Re: [Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 13:08, Geert Jansen ha scritto: > 1) Target flushes are not guaranteed to happen at all. If the latency of > the target is higher than the maximum interval between writes to the > source, the bitmap will always be dirty when a write to the target > returns, and a target flush will nev

[Qemu-devel] [PATCH, v3] qemu/xendisk: set maximum number of grants to be used

2012-05-31 Thread Jan Beulich
Legacy (non-pvops) gntdev drivers may require this to be done when the number of grants intended to be used simultaneously exceeds a certain driver specific default limit. Change in v2: Double the number requested, as we need to account for the allocations needing to happen in contiguous chunks. T

Re: [Qemu-devel] [PATCH, v3] qemu/xendisk: set maximum number of grants to be used

2012-05-31 Thread Stefano Stabellini
On Thu, 31 May 2012, Jan Beulich wrote: > Legacy (non-pvops) gntdev drivers may require this to be done when the > number of grants intended to be used simultaneously exceeds a certain > driver specific default limit. > > Change in v2: Double the number requested, as we need to account for > the a

Re: [Qemu-devel] [PATCH 1.2 3/7] block: always open protocol in writeback mode

2012-05-31 Thread Kevin Wolf
Am 22.05.2012 18:17, schrieb Paolo Bonzini: > Formats are entirely in charge of flushes for metadata writes. For > guest-initiated writes, a writethrough cache is faked in the block layer. > > Signed-off-by: Paolo Bonzini > --- > block.c |2 +- > 1 files changed, 1 insertions(+), 1 deletion

Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

2012-05-31 Thread Amos Kong
On 31/05/12 19:00, Paolo Bonzini wrote: Il 30/05/2012 15:26, Luiz Capitulino ha scritto: qapi-types.h: typedef enum KeyCodes { KEY_CODES_SHIFT = 0, KEY_CODES_SHIFT_R = 1, KEY_CODES_ALT = 2, KEY_CODES_< = .. ^^^ problem should exist here That's because

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Stefano Stabellini
On Thu, 31 May 2012, Paolo Bonzini wrote: > Il 31/05/2012 13:06, Stefano Stabellini ha scritto: > >> > For Xen I think this is not possible at the moment because it doesn't > >> > implement rx notification. > > > > Why do you say that? Xen supports the iothread and CONFIG_EVENTFD. > > No, it's n

Re: [Qemu-devel] [PATCH 1.2 3/7] block: always open protocol in writeback mode

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 13:33, Kevin Wolf ha scritto: >> > diff --git a/block.c b/block.c >> > index 7add33c..43b3de6 100644 >> > --- a/block.c >> > +++ b/block.c >> > @@ -661,7 +661,7 @@ static int bdrv_open_common(BlockDriverState *bs, >> > const char *filename, >> > if (drv->bdrv_file_open) { >> >

Re: [Qemu-devel] [PATCH 1.2 5/7] block: add bdrv_set_enable_write_cache

2012-05-31 Thread Kevin Wolf
Am 22.05.2012 18:17, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > block.c |5 + > block.h |1 + > 2 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/block.c b/block.c > index b682764..bb709c2 100644 > --- a/block.c > +++ b/block.c > @@ -2369,6 +2369,11

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 13:43, Stefano Stabellini ha scritto: >> > No, it's not that. I was talking about feature-rx-notify. But I >> > remembered wrong, that feature is advertised by the front-end, not the >> > back-end. > Yes, that's right. > > >> > IIRC there is only one event channel per Xen network

Re: [Qemu-devel] [PATCH 1.2 6/7] ide: support enable/disable write cache

2012-05-31 Thread Kevin Wolf
Am 22.05.2012 18:17, schrieb Paolo Bonzini: > Enabling or disabling the write cache is done with the SET FEATURES > command. The command can be issued with sg_sat_set_features from > sg3-utils. > > Signed-off-by: Paolo Bonzini > --- > hw/ide/core.c | 18 +++--- > 1 files changed,

Re: [Qemu-devel] [PATCH 1.2 3/7] block: always open protocol in writeback mode

2012-05-31 Thread Kevin Wolf
Am 31.05.2012 13:43, schrieb Paolo Bonzini: > Il 31/05/2012 13:33, Kevin Wolf ha scritto: diff --git a/block.c b/block.c index 7add33c..43b3de6 100644 --- a/block.c +++ b/block.c @@ -661,7 +661,7 @@ static int bdrv_open_common(BlockDriverState *bs, const char *filenam

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc3 release

2012-05-31 Thread Jan Kiszka
On 2012-05-30 10:42, Jan Kiszka wrote: > On 2012-05-30 04:32, Anthony Liguori wrote: >> On 05/22/2012 11:09 PM, Jan Kiszka wrote: >>> On 2012-05-22 11:32, Anthony Liguori wrote: Hi, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate

Re: [Qemu-devel] [PATCH 1.2 3/7] block: always open protocol in writeback mode

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 13:56, Kevin Wolf ha scritto: >> > Because in this case there is no format over it, so the topmost BDS will >> > be open with BDRV_O_CACHE_WB and no one will call bdrv_flush. > Doesn't block.c do it now? bs->enable_write_cache still wouldn't be set, > even if .bdrv_file_open() is call

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc3 release

2012-05-31 Thread Max Filippov
On Thu, May 31, 2012 at 4:06 PM, Jan Kiszka wrote: > On 2012-05-30 10:42, Jan Kiszka wrote: >> On 2012-05-30 04:32, Anthony Liguori wrote: >>> On 05/22/2012 11:09 PM, Jan Kiszka wrote: On 2012-05-22 11:32, Anthony Liguori wrote: > Hi, > > On behalf of the QEMU Team, I'd like to an

Re: [Qemu-devel] [PATCH 1.2 5/7] block: add bdrv_set_enable_write_cache

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 13:44, Kevin Wolf ha scritto: > Am 22.05.2012 18:17, schrieb Paolo Bonzini: >> Signed-off-by: Paolo Bonzini >> --- >> block.c |5 + >> block.h |1 + >> 2 files changed, 6 insertions(+), 0 deletions(-) >> >> diff --git a/block.c b/block.c >> index b682764..bb709c2 100644

Re: [Qemu-devel] [PATCH 1.2 6/7] ide: support enable/disable write cache

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 13:53, Kevin Wolf ha scritto: >> > case 0x02: /* write cache enable */ >> > +bdrv_set_enable_write_cache(s->bs, true); >> > +identify_data = (uint16_t *)s->identify_data; >> > +put_le16(identify_data + 85, (1 << 14) | (1 << 5) | 1); > How a

Re: [Qemu-devel] general question

2012-05-31 Thread 吴晓琳
I am wirting a little kernel by myself, but come into a problem which seems strange. I implement the system call fork, in which memory data is copied from parent's space to child's, I insert a fake page into the parent's page, and set its physical address to an empty frame, and then copy data fr

Re: [Qemu-devel] [PATCH 1.2 6/7] ide: support enable/disable write cache

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 14:33, Paolo Bonzini ha scritto: >> > case 0x02: /* write cache enable */ >> > +bdrv_set_enable_write_cache(s->bs, true); >> > +identify_data = (uint16_t *)s->identify_data; >> > +put_le16(identify_data + 85, (1 << 14) |

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Zhi Yong Wu
On Thu, May 31, 2012 at 5:34 PM, Luigi Rizzo wrote: > > > On Thu, May 31, 2012 at 11:18 AM, Stefan Hajnoczi > wrote: >> >> On Wed, May 30, 2012 at 8:59 AM, Luigi Rizzo wrote: >> > Hi, >> > while investigating rx performance for emulated network devices >> > (i am looking at the userspace version

Re: [Qemu-devel] [PATCH 1/2] qmp: use readline mode for stdio

2012-05-31 Thread Pavel Hrdina
On 05/31/2012 12:34 PM, Paolo Bonzini wrote: Il 30/05/2012 12:01, Pavel Hrdina ha scritto: Instead of using an echo for '-qmp stdio' we use a readline mode. The readline mode adds a history for users which is useful. Signed-off-by: Pavel Hrdina --- monitor.c | 83 ++

Re: [Qemu-devel] [PATCH 1.2 6/7] ide: support enable/disable write cache

2012-05-31 Thread Kevin Wolf
Am 31.05.2012 15:06, schrieb Paolo Bonzini: > Il 31/05/2012 14:33, Paolo Bonzini ha scritto: case 0x02: /* write cache enable */ +bdrv_set_enable_write_cache(s->bs, true); +identify_data = (uint16_t *)s->identify_data; +

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 15:07, Zhi Yong Wu ha scritto: > Yeah, this case actually exists, but tcp/ip protocol stack in guest > will make sure this ordering will finally be correct. Nevertheless it's not good, and the latest Windows Logo tests will fail if you reorder frames. Paolo

[Qemu-devel] Malta MIPS

2012-05-31 Thread maheen butt
I found this link very useful to emulate MIPS malta http://people.debian.org/~aurel32/qemu/mips/ kernel and file system images are provided. But I'm facing a problem. Actually I want to share files between guest and for this purpose I try to modify the provided  file system but whenever I trie

[Qemu-devel] PPC 40p emulation

2012-05-31 Thread Mary Disler
Hi developers, is there a qemu version which can emulate an IBM 40p machine? Google finds http://repo.or.cz/w/qemu/hpoussin.git, but when I compile and start it nothing happens, except for qemu-system-ppc eating 100% cpu. My PC has Ubuntu 10.10, maybe this is too old for qemu? Mary Disler

Re: [Qemu-devel] Block job commands in QEMU 1.2 [v2, including support for replication]

2012-05-31 Thread Roni Luxenberg
- Original Message - > Il 30/05/2012 14:34, Geert Jansen ha scritto: > > > > On 05/29/2012 02:52 PM, Paolo Bonzini wrote: > > > >>> Does the drive-mirror coroutine send the writes to the target in > >>> the > >>> same order as they are sent to the source? I assume so. > >> > >> No, it doe

Re: [Qemu-devel] [PATCH, v3] qemu/xendisk: set maximum number of grants to be used

2012-05-31 Thread Jan Beulich
>>> On 31.05.12 at 13:27, Stefano Stabellini wrote: > On Thu, 31 May 2012, Jan Beulich wrote: >> Legacy (non-pvops) gntdev drivers may require this to be done when the >> number of grants intended to be used simultaneously exceeds a certain >> driver specific default limit. >> >> Change in v2: Do

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Luigi Rizzo
On Thu, May 31, 2012 at 03:23:12PM +0200, Jan Kiszka wrote: > On 2012-05-31 15:19, Paolo Bonzini wrote: > > Il 31/05/2012 15:07, Zhi Yong Wu ha scritto: > >> Yeah, this case actually exists, but tcp/ip protocol stack in guest > >> will make sure this ordering will finally be correct. > > > > Never

Re: [Qemu-devel] [PATCH, v3] qemu/xendisk: set maximum number of grants to be used

2012-05-31 Thread Stefano Stabellini
On Thu, 31 May 2012, Jan Beulich wrote: > >>> On 31.05.12 at 13:27, Stefano Stabellini > >>> > wrote: > > On Thu, 31 May 2012, Jan Beulich wrote: > >> Legacy (non-pvops) gntdev drivers may require this to be done when the > >> number of grants intended to be used simultaneously exceeds a certain

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Jan Kiszka
On 2012-05-31 15:19, Paolo Bonzini wrote: > Il 31/05/2012 15:07, Zhi Yong Wu ha scritto: >> Yeah, this case actually exists, but tcp/ip protocol stack in guest >> will make sure this ordering will finally be correct. > > Nevertheless it's not good, and the latest Windows Logo tests will fail > if

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Jan Kiszka
On 2012-05-31 15:49, Luigi Rizzo wrote: > On Thu, May 31, 2012 at 03:23:12PM +0200, Jan Kiszka wrote: >> On 2012-05-31 15:19, Paolo Bonzini wrote: >>> Il 31/05/2012 15:07, Zhi Yong Wu ha scritto: Yeah, this case actually exists, but tcp/ip protocol stack in guest will make sure this order

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Zhi Yong Wu
On Thu, May 31, 2012 at 5:18 PM, Stefan Hajnoczi wrote: > On Wed, May 30, 2012 at 8:59 AM, Luigi Rizzo wrote: >> Hi, >> while investigating rx performance for emulated network devices >> (i am looking at the userspace version, relying on net=tap >> or similar approaches) i noticed the code >> in

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Jan Kiszka
On 2012-05-31 15:45, Zhi Yong Wu wrote: > On Thu, May 31, 2012 at 5:18 PM, Stefan Hajnoczi wrote: >> On Wed, May 30, 2012 at 8:59 AM, Luigi Rizzo wrote: >>> Hi, >>> while investigating rx performance for emulated network devices >>> (i am looking at the userspace version, relying on net=tap >>> o

Re: [Qemu-devel] [PATCH 0/2] qmp: implement readline handlig for stdio

2012-05-31 Thread Luiz Capitulino
On Thu, 31 May 2012 10:10:07 +0200 Kevin Wolf wrote: > Am 30.05.2012 18:41, schrieb Luiz Capitulino: > > On Wed, 30 May 2012 16:19:43 +0200 > > Kevin Wolf wrote: > > > >> Am 30.05.2012 12:01, schrieb Pavel Hrdina: > >>> For debug it would be nice to have a same functionality for the qmp > >>>

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Zhi Yong Wu
On Thu, May 31, 2012 at 9:19 PM, Paolo Bonzini wrote: > Il 31/05/2012 15:07, Zhi Yong Wu ha scritto: >> Yeah, this case actually exists, but tcp/ip protocol stack in guest >> will make sure this ordering will finally be correct. > > Nevertheless it's not good, and the latest Windows Logo tests wil

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Luiz Capitulino
On Thu, 31 May 2012 12:42:34 +0200 Paolo Bonzini wrote: > Il 30/05/2012 16:14, Luiz Capitulino ha scritto: > > New errors for write() and open() failures. Will be used by the > > next commits. > > Ouch. We have already these errors: > > #define QERR_OPEN_FILE_FAILED \ > "{ 'class': 'OpenFi

Re: [Qemu-devel] [PATCH 01/14] qerror: extend QERR_TOO_MANY_FILES

2012-05-31 Thread Luiz Capitulino
On Thu, 31 May 2012 12:43:24 +0200 Paolo Bonzini wrote: > Il 30/05/2012 16:14, Luiz Capitulino ha scritto: > > Specify it's too many open files in system (ENFILE). > > > > There's no compatibility issue because QERR_TOO_MANY_FILES is actually > > not used today. > > Let's kill it then. :) It's

Re: [Qemu-devel] PPC 40p emulation

2012-05-31 Thread Andreas Färber
Hi, Am 31.05.2012 11:14, schrieb Mary Disler: > is there a qemu version which can emulate an IBM 40p machine? > > Google finds http://repo.or.cz/w/qemu/hpoussin.git, but when I compile > and start it nothing happens, except for qemu-system-ppc eating 100% > cpu. Hervé and me are working on PReP

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Zhi Yong Wu
On Thu, May 31, 2012 at 9:48 PM, Jan Kiszka wrote: > On 2012-05-31 15:45, Zhi Yong Wu wrote: >> On Thu, May 31, 2012 at 5:18 PM, Stefan Hajnoczi wrote: >>> On Wed, May 30, 2012 at 8:59 AM, Luigi Rizzo wrote: Hi, while investigating rx performance for emulated network devices (i am

Re: [Qemu-devel] frame reordering in qemu_net_queue_send() ?

2012-05-31 Thread Jan Kiszka
On 2012-05-31 16:10, Zhi Yong Wu wrote: > On Thu, May 31, 2012 at 9:48 PM, Jan Kiszka wrote: >> On 2012-05-31 15:45, Zhi Yong Wu wrote: >>> On Thu, May 31, 2012 at 5:18 PM, Stefan Hajnoczi wrote: On Wed, May 30, 2012 at 8:59 AM, Luigi Rizzo wrote: > Hi, > while investigating rx perf

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 16:06, Luiz Capitulino ha scritto: >> What about errno values? Let's add an enum QemuErrno and convert host >> errnos to that enum. Enums are sent as strings, so they are neutral to >> the OS of the host and client. And the client (if it desires) can >> convert back to an errno val

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Luiz Capitulino
On Thu, 31 May 2012 16:25:48 +0200 Paolo Bonzini wrote: > Il 31/05/2012 16:06, Luiz Capitulino ha scritto: > >> What about errno values? Let's add an enum QemuErrno and convert host > >> errnos to that enum. Enums are sent as strings, so they are neutral to > >> the OS of the host and client.

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 16:31, Luiz Capitulino ha scritto: Errors are not QAPI-ized yet, so we can add errno values to the above five errors too. >>> >>> We've preferred adding new errors instead of adding errno values to >>> existing errors. I don't remember exactly why, but I personally don't car

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Kevin Wolf
Am 31.05.2012 16:06, schrieb Luiz Capitulino: > On Thu, 31 May 2012 12:42:34 +0200 > Paolo Bonzini wrote: >> Errors are not QAPI-ized yet, so we can add errno values to the above >> five errors too. > > We've preferred adding new errors instead of adding errno values to > existing errors. I don't

Re: [Qemu-devel] [PATCH 0/2] qmp: implement readline handlig for stdio

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 15:49, Luiz Capitulino ha scritto: >> Seriously? The natural thing to do is -qmp stdio, and I don't read any >> wikis for that. >> >> It's nice that you can get some kind of usability by typing in long >> network addresses or path names and hacking a rlwrap around it (didn't >> know t

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc4 release

2012-05-31 Thread Anthony Liguori
On 05/31/2012 01:58 PM, Stefan Weil wrote: Am 31.05.2012 05:21, schrieb Anthony Liguori: Hi, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 1.1 release. This release is meant for testing purposes and should not be used in a product

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc3 release

2012-05-31 Thread Anthony Liguori
On 05/31/2012 08:06 PM, Jan Kiszka wrote: On 2012-05-30 10:42, Jan Kiszka wrote: On 2012-05-30 04:32, Anthony Liguori wrote: On 05/22/2012 11:09 PM, Jan Kiszka wrote: On 2012-05-22 11:32, Anthony Liguori wrote: Hi, On behalf of the QEMU Team, I'd like to announce the availability of the thir

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Luiz Capitulino
On Thu, 31 May 2012 16:54:47 +0200 Paolo Bonzini wrote: > Il 31/05/2012 16:31, Luiz Capitulino ha scritto: > Errors are not QAPI-ized yet, so we can add errno values to the above > five errors too. > >>> > >>> We've preferred adding new errors instead of adding errno values to > >>> exi

Re: [Qemu-devel] [PATCH 0/2] qmp: implement readline handlig for stdio

2012-05-31 Thread Luiz Capitulino
On Thu, 31 May 2012 17:18:18 +0200 Paolo Bonzini wrote: > Il 31/05/2012 15:49, Luiz Capitulino ha scritto: > >> Seriously? The natural thing to do is -qmp stdio, and I don't read any > >> wikis for that. > >> > >> It's nice that you can get some kind of usability by typing in long > >> network ad

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 17:44, Luiz Capitulino ha scritto: >> One is "do not shoehorn errors into errno values". So for QOM invalid >> values we >> have PropertyValueBad, not a generic InvalidArgument value. We convert >> everything >> to Error rather than returning negative errno values and then returni

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Luiz Capitulino
On Thu, 31 May 2012 17:49:42 +0200 Paolo Bonzini wrote: > Il 31/05/2012 17:44, Luiz Capitulino ha scritto: > >> One is "do not shoehorn errors into errno values". So for QOM invalid > >> values we > >> have PropertyValueBad, not a generic InvalidArgument value. We convert > >> everything > >>

Re: [Qemu-devel] Proposed patch: huge RX speedup for hw/e1000.c

2012-05-31 Thread Stefan Weil
Hi Paolo, I suggest using false / true instead of 0 / 1 for the boolean values, see my comments below. Regards, Stefan Am 31.05.2012 12:03, schrieb Paolo Bonzini: [...] -void qemu_net_queue_flush(NetQueue *queue) +bool qemu_net_queue_flush(NetQueue *queue) { while (!QTAILQ_EMPTY(&qu

Re: [Qemu-devel] [PATCH 02/14] qerror: add new errors

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 18:08, Luiz Capitulino ha scritto: > On Thu, 31 May 2012 17:49:42 +0200 > Paolo Bonzini wrote: > >> Il 31/05/2012 17:44, Luiz Capitulino ha scritto: One is "do not shoehorn errors into errno values". So for QOM invalid values we have PropertyValueBad, not a generic

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.1-rc4 release

2012-05-31 Thread Stefan Weil
Am 31.05.2012 17:29, schrieb Anthony Liguori: On 05/31/2012 01:58 PM, Stefan Weil wrote: Did you tag the release? Yup. http://git.qemu.org/qemu.git I pushed that tag when I pushed the version change FWIW. Regards, Anthony Liguori Ah, I found the reason why I neither see the new VERSION

[Qemu-devel] [PATCH] linux-user: fix multi-threaded /proc/self/maps

2012-05-31 Thread Alexander Graf
When reading our faked /proc/self/maps from a secondary thread, we get an invalid stack entry. This is because ts->stack_base is not initialized in non-primary threads. However, ts->info is, and the stack layout information we're looking for is there too. So let's use that one instead! Signed-off

Re: [Qemu-devel] Can we improve virtio data structures with QOM?

2012-05-31 Thread Markus Armbruster
Anthony Liguori writes: [On how to model virtio devices in QOM:] > Basically, it should look like: > > VirtioPCIDevice is-a PCIDevice > > VirtioPCIDevice has-a link Could you explain why this is link<> and not child<>? > VirtioDevice is-a DeviceState > > VirtioBlk is-a VirtioDevice > VirtioNet

Re: [Qemu-devel] [PATCH qom-next 57/59] cpu: Introduce mandatory tlb_flush callback

2012-05-31 Thread Paul Brook
> >> +void cpu_tlb_flush(CPUState *cpu, bool flush_global) > >> +{ > >> +CPUClass *cc = CPU_GET_CLASS(cpu); > >> + > >> +g_assert(cc->tlb_flush != NULL); > >> + > >> +cc->tlb_flush(cpu, flush_global); > >> +} > > > > This needs to be able to call tlb_flush() itself > > rather than havi

  1   2   >